hipanel\modules\finance\models\Price

Complexity

Total Complexity

15

Size/Duplication

Total Lines	137
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	8

Test Coverage

Coverage

0%

Importance

Changes

0

13 Methods

Rating	Name	Duplication	Size	Complexity
A	rules()	0	17	1
A	attributeLabels()	0	13	1
A	getTypeOptions()	0	9	1
B	getUnitOptions()	0	27	1
A	getUnitLabel()	0	4	1
A	getCurrencyOptions()	0	4	1
A	getObject()	0	4	1
A	getPlan()	0	4	1
A	tableName()	0	4	1
A	isOveruse()	0	4	1
A	getSubtype()	0	5	1
A	instantiate()	0	10	2
A	formulaLines()	0	8	2

<?php

namespace hipanel\modules\finance\models;

use Yii;
use yii\helpers\Inflector;
use yii\helpers\StringHelper;
use hipanel\models\Ref;
use hipanel\modules\finance\models\factories\PriceModelFactory;

/**
 * Class Price
 *
 * @property int $id
 * @property int $plan_id
 * @property string|int $object_id
 * @property string|float $price
 * @property string $currency
 * @property string|int $main_object_id
 * @property string $unit
 * @property string $type
 * @property string $quantity
 * @property string $formula
 *
 * @property TargetObject $object
 * @property Plan $plan
 *
 * @author Dmytro Naumenko <d.naumenko.a@gmail.com>
 */
class Price extends \hipanel\base\Model
{
    use \hipanel\base\ModelTrait;

    const SCENARIO_CREATE = 'create';
    const SCENARIO_UPDATE = 'update';
    const SCENARIO_DELETE = 'delete';

    public function rules()
    {
        return array_merge(parent::rules(), [
            [['id', 'parent_id', 'plan_id', 'object_id', 'type_id', 'unit_id', 'currency_id', 'main_object_id'], 'integer'],
            [['type', 'plan_name', 'unit', 'currency', 'note', 'data'], 'string'],
            [['quantity', 'price'], 'number'],
            [['class'], 'string'], // todo: probably, refactor is needed

            [['plan_id', 'type', 'price', 'currency'], 'required', 'on' => ['create', 'update']],
            [['id'], 'required', 'on' => ['update', 'set-note', 'delete']],
            [['class'], 'default', 'value' => function ($model) {

The parameter $model is not used and could be removed.

                return (new \ReflectionClass($this))->getShortName();
            }],
            [['class'], 'string'],
            [['formula'], 'string', 'on' => ['create', 'update']] // TODO syn check
        ]);
    }

    public function attributeLabels()
    {
        return [
            'plan_id' => Yii::t('hipanel:finance', 'Tariff plan'),
            'plan' => Yii::t('hipanel:finance', 'Tariff plan'),
            'quantity' => Yii::t('hipanel:finance', 'Prepaid'),
            'unit' => Yii::t('hipanel:finance', 'Unit'),
            'price' => Yii::t('hipanel:finance', 'Price'),
            'formula' => Yii::t('hipanel.finance.price', 'Formula'),
            'note' => Yii::t('hipanel', 'Note'),
            'type' => Yii::t('hipanel', 'Type'),
        ];
    }

    public function getTypeOptions()
    {
        return Ref::getList('type,bill', null, [
            'select' => 'oname_label',
            'pnames' => 'monthly,overuse',
            'with_recursive' => 1,
            'mapOptions' => ['from' => 'oname'],
        ]);
    }

    public function getUnitOptions()
    {
        $unitGroup = [
            'speed' => ['bps', 'kbps', 'mbps', 'gbps', 'tbps'],
            'size' => ['mb', 'mb10', 'mb100', 'gb', 'tb'],
        ];

        $availableUnitsByPriceType = [
            'overuse,ip_num' => ['items'],
            'overuse,support_time' => ['hour'],
            'overuse,backup_du' => $unitGroup['size'],
            'overuse,server_traf_max' => $unitGroup['size'],
            'overuse,server_traf95_max' => $unitGroup['speed'],
            'overuse,server_du' => $unitGroup['size'],
            'overuse,server_ssd' => $unitGroup['size'],
            'overuse,server_sata' => $unitGroup['size'],
        ];

        $units = Ref::getList('type,unit', 'hipanel.finance.units', [
            'with_recursive' => 1,
            'select' => 'oname_label',
            'mapOptions' => ['from' => 'oname'],
        ]);

        $possibleTypes = $availableUnitsByPriceType[$this->type] ?? [];
        return array_intersect_key($units, array_combine($possibleTypes, $possibleTypes));
    }

    public function getUnitLabel()
    {
        return $this->getUnitOptions()[$this->unit] ?? null;
    }

    public function getCurrencyOptions()
    {
        return Ref::getList('type,currency');
    }

    public function getObject()
    {
        return $this->hasOne(TargetObject::class, ['id' => 'id']);
    }

    public function getPlan()
    {
        return $this->hasOne(Plan::class, ['id' => 'plan_id']);
    }

    public static function tableName()
    {
        return Inflector::camel2id(StringHelper::basename(__CLASS__), '-');
    }

    public function isOveruse()
    {
        return strpos($this->type, 'overuse,') === 0;
    }

    public function getSubtype()
    {
        [, $subtype] = explode(',', $this->type);

The variable $subtype does not exist. Did you forget to declare it?

        return $subtype;
    }

    /**
     * {@inheritdoc}
     */
    public static function instantiate($row)
    {
        if (empty($row['class'])) {
            return parent::instance($row);

It seems like you call parent on a different method (instance() instead of instantiate()). Are you sure this is correct? If so, you might want to change this to $this->instance().

        }

        /** @var PriceModelFactory $factory */
        $factory = Yii::$container->get(PriceModelFactory::class);
        return $factory->build($row['class']);
    }

    public function formulaLines(): array
    {
        if (strlen($this->formula) === 0) {
            return [];
        }

        return explode("\n", $this->formula);
    }
}