GitMerger::mergeTo() - Code Metrics - Inspection of "refactoring" - hiqdev/chkipper - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3862ca...808823 )

by Andrii

created 2016-06-18 15:07 UTC

GitMerger::mergeTo() A

↳ Parent: GitMerger

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	5
ccs	0
cts	5
cp	0
rs	9.4285
cc	1
eloc	3
nc	1
nop	1
crap	2

<?php

/*
 * Changelog keeper
 *
 * @link      https://github.com/hiqdev/chkipper
 * @package   chkipper
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2016, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\chkipper\history;

use UnexpectedValueException;

/**
 * Git merger.
 * Merges git log into History.
 *
 * @author Andrii Vasyliev <[email protected]>
 */
class GitMerger extends Builder
{
    public function mergeTo($history)
    {
        $this->setHistory($history);

        $this->mergeGitLog();
    }

    public function mergeGitLog()
    {
        $log = $this->fetchGitLog();
        foreach ($log as $hash => $data) {
            $this->getHistory()->prependCommit($data['tag'], null, $data['commit']);

        }
    }

    public function fetchGitLog($reverse = false)
    {
        $reverse = $reverse ? '--reverse' : '';
        exec("git log $reverse --date=short --pretty='format:%h %ad %s [%ae] %d'", $logs);
        $res = [];
        foreach ($logs as $log) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            if (!preg_match('/^(\w+) ([0-9-]+ .*? \[.*?\]) \(?(.*?)\)?$/', $log, $m)) {
                throw new UnexpectedValueException('failed parse git log');
            }
            var_dump($m);

            $res[$m[1]] = [
                'tag'    => isset($m[3]) ? $this->matchTag($m[3]) : null,
                'commit' => new Commit($m[1], $m2[2]),

            ];
        }

        return $res;
    }

    /**
     * Finds first tag in given refs string.
     * @param string $str 
     * @return string
     */
    public function matchTag($str)
    {
        $refs = explode(', ', $str);
        foreach ($refs as $ref) {
            if (preg_match('/^tag: (.*)$/', $ref, $m)) {
                return $m[1];
            }
        }

        return null;
    }
}


1			<?php
2
3			/*
4			* Changelog keeper
5			*
6			* @link https://github.com/hiqdev/chkipper
7			* @package chkipper
8			* @license BSD-3-Clause
9			* @copyright Copyright (c) 2016, HiQDev (http://hiqdev.com/)
10			*/
11
12			namespace hiqdev\chkipper\history;
13
14			use UnexpectedValueException;
15
16			/**
17			* Git merger.
18			* Merges git log into History.
19			*
20			* @author Andrii Vasyliev <[email protected]>
21			*/
22			class GitMerger extends Builder
23			{
24			public function mergeTo($history)
25			{
26			$this->setHistory($history);
			0 ignored issues – show Bug introduced 2016-06-18 15:10 UTC by Report Bug Copy Issue Report The method `setHistory()` does not seem to exist on `object<hiqdev\chkipper\history\GitMerger>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
27			$this->mergeGitLog();
28			}
29
30			public function mergeGitLog()
31			{
32			$log = $this->fetchGitLog();
33			foreach ($log as $hash => $data) {
34			$this->getHistory()->prependCommit($data['tag'], null, $data['commit']);
			0 ignored issues – show Bug introduced 2016-06-18 15:10 UTC by Report Bug Copy Issue Report The method `prependCommit()` does not seem to exist on `object<hiqdev\chkipper\history\History>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
35			}
36			}
37
38			public function fetchGitLog($reverse = false)
39			{
40			$reverse = $reverse ? '--reverse' : '';
41			exec("git log $reverse --date=short --pretty='format:%h %ad %s [%ae] %d'", $logs);
42			$res = [];
43			foreach ($logs as $log) {
			0 ignored issues – show Bug introduced 2016-06-18 15:10 UTC by Report Bug Copy Issue Report The expression `$logs` of type `null\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
44			if (!preg_match('/^(\w+) ([0-9-]+ .? \[.?\]) \(?(.*?)\)?$/', $log, $m)) {
45			throw new UnexpectedValueException('failed parse git log');
46			}
47			var_dump($m);
			0 ignored issues – show Security Debugging Code introduced 2016-06-18 15:10 UTC by Report Bug Copy Issue Report `var_dump($m);` looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data. Loading history...
48			$res[$m[1]] = [
49			'tag' => isset($m[3]) ? $this->matchTag($m[3]) : null,
50			'commit' => new Commit($m[1], $m2[2]),
			0 ignored issues – show Bug introduced 2016-06-18 15:10 UTC by Report Bug Copy Issue Report The variable `$m2` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
51			];
52			}
53
54			return $res;
55			}
56
57			/**
58			* Finds first tag in given refs string.
59			* @param string $str
60			* @return string
61			*/
62			public function matchTag($str)
63			{
64			$refs = explode(', ', $str);
65			foreach ($refs as $ref) {
66			if (preg_match('/^tag: (.*)$/', $ref, $m)) {
67			return $m[1];
68			}
69			}
70
71			return null;
72			}
73			}
74

hiqdev / chkipper

Push — master ( 3862ca...808823 )

GitMerger::mergeTo() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like