hiqdev\chkipper\history\GitMerger

Complexity

Total Complexity

11

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	mergeTo()	0	5	1
A	mergeGitLog()	0	7	2
B	fetchGitLog()	0	18	5
A	matchTag()	0	11	3

<?php

/*
 * Changelog keeper
 *
 * @link      https://github.com/hiqdev/chkipper
 * @package   chkipper
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2016, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\chkipper\history;

use UnexpectedValueException;

/**
 * Git merger.
 * Merges git log into History.
 *
 * @author Andrii Vasyliev <sol@hiqdev.com>
 */
class GitMerger extends Builder
{
    public function mergeTo($history)
    {
        $this->setHistory($history);

The method setHistory() does not seem to exist on object<hiqdev\chkipper\history\GitMerger>.

        $this->mergeGitLog();
    }

    public function mergeGitLog()
    {
        $log = $this->fetchGitLog();
        foreach ($log as $hash => $data) {
            $this->getHistory()->prependCommit($data['tag'], null, $data['commit']);

The method prependCommit() does not seem to exist on object<hiqdev\chkipper\history\History>.

        }
    }

    public function fetchGitLog($reverse = false)
    {
        $reverse = $reverse ? '--reverse' : '';
        exec("git log $reverse --date=short --pretty='format:%h %ad %s [%ae] %d'", $logs);
        $res = [];
        foreach ($logs as $log) {

The expression $logs of type null|array is not guaranteed to be traversable. How about adding an additional type check?

            if (!preg_match('/^(\w+) ([0-9-]+ .*? \[.*?\]) \(?(.*?)\)?$/', $log, $m)) {
                throw new UnexpectedValueException('failed parse git log');
            }
            var_dump($m);

var_dump($m); looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data.

            $res[$m[1]] = [
                'tag'    => isset($m[3]) ? $this->matchTag($m[3]) : null,
                'commit' => new Commit($m[1], $m2[2]),

The variable $m2 does not exist. Did you forget to declare it?

            ];
        }

        return $res;
    }

    /**
     * Finds first tag in given refs string.
     * @param string $str 
     * @return string
     */
    public function matchTag($str)
    {
        $refs = explode(', ', $str);
        foreach ($refs as $ref) {
            if (preg_match('/^tag: (.*)$/', $ref, $m)) {
                return $m[1];
            }
        }

        return null;
    }
}