hideyo /
ecommerce-framework
| Conditions | 10 |
| Paths | 57 |
| Total Lines | 73 |
| Code Lines | 51 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 109 | public function createOrderFrontend(array $attributes, $shopId, $noAccountUser) |
||
| 110 | { |
||
| 111 | $attributes['shop_id'] = $shopId; |
||
| 112 | $attributes['client_id'] = $attributes['user_id']; |
||
| 113 | $client = ClientService::selectOneByShopIdAndId($shopId, $attributes['user_id']); |
||
| 114 | |||
| 115 | $this->repo->getModel()->fill($attributes); |
||
| 116 | $this->repo->getModel()->save(); |
||
| 117 | |||
| 118 | if (!Cart::getContent()->count()) { |
||
| 119 | return false; |
||
| 120 | } |
||
| 121 | |||
| 122 | $this->addProducts($this->repo->getModel(), Cart::getContent()); |
||
| 123 | |||
| 124 | if ($client) { |
||
| 125 | if ($client->clientDeliveryAddress) { |
||
| 126 | $deliveryOrderAddress = $this->createAddress($client->clientDeliveryAddress->toArray(), $this->repo->getModel()->id); |
||
| 127 | } |
||
| 128 | |||
| 129 | if ($client->clientBillAddress) { |
||
| 130 | $billOrderAddress = $this->createAddress($client->clientBillAddress->toArray(), $this->repo->getModel()->id); |
||
| 131 | } |
||
| 132 | |||
| 133 | $this->repo->getModel()->fill(array('delivery_order_address_id' => $deliveryOrderAddress->id, 'bill_order_address_id' => $billOrderAddress->id)); |
||
| 134 | $this->repo->getModel()->save(); |
||
| 135 | |||
| 136 | } elseif ($noAccountUser) { |
||
| 137 | if (isset($noAccountUser['delivery'])) { |
||
| 138 | $deliveryOrderAddress = $billOrderAddress = $this->createAddress($noAccountUser['delivery'], $this->repo->getModel()->id); |
||
| 139 | } else { |
||
| 140 | $deliveryOrderAddress = $billOrderAddress = $this->createAddress($noAccountUser, $this->repo->getModel()->id); |
||
| 141 | } |
||
| 142 | |||
| 143 | $billOrderAddress = $billOrderAddress = $this->createAddress($noAccountUser, $this->repo->getModel()->id); |
||
| 144 | $this->repo->getModel()->fill(array('delivery_order_address_id' => $deliveryOrderAddress->id, 'bill_order_address_id' => $billOrderAddress->id)); |
||
| 145 | $this->repo->getModel()->save(); |
||
| 146 | } |
||
| 147 | |||
| 148 | if (Cart::getConditionsByType('sending_method')->count()) { |
||
| 149 | $attributes = Cart::getConditionsByType('sending_method')->first()->getAttributes(); |
||
| 150 | $sendingMethod = SendingMethodService::find($attributes['data']['id']); |
||
| 151 | $price = $sendingMethod->getPriceDetails(); |
||
| 152 | $sendingMethodArray = $sendingMethod->toArray(); |
||
| 153 | $sendingMethodArray['price_with_tax'] = Cart::getConditionsByType('sending_method')->first()->getAttributes()['data']['price_details']['original_price_inc_tax']; |
||
| 154 | $sendingMethodArray['price_without_tax'] = Cart::getConditionsByType('sending_method')->first()->getAttributes()['data']['price_details']['original_price_ex_tax']; |
||
| 155 | $sendingMethodArray['tax_rate'] = $price['tax_rate']; |
||
| 156 | $sendingMethodArray['sending_method_id'] = $sendingMethod->id; |
||
| 157 | $sendingMethodArray['order_id'] = $this->repo->getModel()->id; |
||
| 158 | $orderSendingMethod = $this->getSendingMethodModel()->fill($sendingMethodArray); |
||
| 159 | $orderSendingMethod = $orderSendingMethod->save(); |
||
| 160 | } |
||
| 161 | |||
| 162 | if (Cart::getConditionsByType('payment_method')->count()) { |
||
| 163 | $attributes = Cart::getConditionsByType('payment_method')->first()->getAttributes(); |
||
| 164 | $paymentMethod = PaymentMethodService::find($attributes['data']['id']); |
||
| 165 | $price = $paymentMethod->getPriceDetails(); |
||
| 166 | $paymentMethodArray = $paymentMethod->toArray(); |
||
| 167 | $paymentMethodArray['price_with_tax'] = Cart::getConditionsByType('payment_method')->first()->getAttributes()['data']['value_inc_tax']; |
||
| 168 | $paymentMethodArray['price_without_tax'] = Cart::getConditionsByType('payment_method')->first()->getAttributes()['data']['value_ex_tax']; |
||
| 169 | $paymentMethodArray['tax_rate'] = $price['tax_rate']; |
||
| 170 | $paymentMethodArray['payment_method_id'] = $paymentMethod->id; |
||
| 171 | $paymentMethodArray['order_id'] = $this->repo->getModel()->id; |
||
| 172 | $orderPaymentMethod = $this->getPaymentMethodModel()->fill($paymentMethodArray); |
||
| 173 | $orderPaymentMethod = $orderPaymentMethod->save(); |
||
| 174 | } |
||
| 175 | |||
| 176 | if ($this->repo->getModel()->orderPaymentMethod->paymentMethod->order_confirmed_order_status_id) { |
||
| 177 | $this->repo->getModel()->fill(array('order_status_id' => $this->repo->getModel()->orderPaymentMethod->paymentMethod->order_confirmed_order_status_id)); |
||
| 178 | $this->repo->getModel()->save(); |
||
| 179 | } |
||
| 180 | |||
| 181 | return $this->repo->getModel(); |
||
| 182 | } |
||
| 216 | } |
Loading history...
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths