Hideyo\Ecommerce\Framework\Services\Order\OrderService

Complexity

Total Complexity

28

Size/Duplication

Total Lines	201
Duplicated Lines	0 %

Importance

Changes	3
Bugs	1	Features	0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	getPaymentMethodModel()	0	3	1
A	updateStatus()	0	11	2
A	createAddress()	0	12	2
B	createOrderFrontend()	0	73	10
A	updateById()	0	10	2
A	getAddressModel()	0	3	1
A	create()	0	12	2
A	addProducts()	0	46	5
A	__construct()	0	3	1
A	getSendingMethodModel()	0	3	1
A	getProductModel()	0	3	1

<?php

namespace Hideyo\Ecommerce\Framework\Services\Order;

use Validator;
use File;
use Hideyo\Ecommerce\Framework\Services\Order\Entity\OrderRepository;
use Hideyo\Ecommerce\Framework\Services\BaseService;
use Hideyo\Ecommerce\Framework\Services\Client\ClientFacade as ClientService;
use Hideyo\Ecommerce\Framework\Services\SendingMethod\SendingMethodFacade as SendingMethodService;
use Hideyo\Ecommerce\Framework\Services\PaymentMethod\PaymentMethodFacade as PaymentMethodService;
use Cart; 

The type Cart was not found. Maybe you did not declare it correctly or list all dependencies?

class OrderService extends BaseService
{
	public function __construct(OrderRepository $order)
	{
		$this->repo = $order;

The property repo does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

	} 

    public function createAddress(array $attributes, $orderId)
    {
        if (auth('hideyobackend')->check()) {
            $userId = auth('hideyobackend')->user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            $attributes['modified_by_user_id'] = $userId;
        }

        $attributes['order_id'] = $orderId;  
        $this->getAddressModel()->fill($attributes);
        $this->getAddressModel()->save();
        
        return $this->getAddressModel();
    }

    public function create(array $attributes)
    {
        $attributes['shop_id'] = auth('hideyobackend')->user()->selected_shop_id;

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $attributes['modified_by_user_id'] = auth('hideyobackend')->user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->repo->getModel()->fill($attributes);
        $this->repo->getModel()->save();

        if (isset($attributes['categories'])) {
            $this->repo->getModel()->categories()->sync($attributes['categories']);
        }
        
        return $this->model;

The property model does not exist on Hideyo\Ecommerce\Framework\Services\Order\OrderService. Did you maybe forget to declare it?

    }

    public function updateById(array $attributes, $id)
    {
        $model = $this->find($id);
        if (auth('hideyobackend')->check()) {
            $attributes['shop_id'] = auth('hideyobackend')->user()->selected_shop_id;

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            $attributes['modified_by_user_id'] = auth('hideyobackend')->user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        }

        $model->fill($attributes);
        return $model->save();   
    }

    public function addProducts($orderModel, $products) 
    {
        foreach ($products  as $product) {

            $quantity = $product->quantity;
            $newProduct = array(
                'product_id' => $product['attributes']['id'],
                'title' => $product['attributes']['title'],
                'original_price_without_tax' => $product['attributes']['price_details']['original_price_ex_tax'],
                'original_price_with_tax' => $product['attributes']['price_details']['original_price_inc_tax'],
                'original_total_price_without_tax' => $quantity * $product['attributes']['price_details']['original_price_ex_tax'],
                'original_total_price_with_tax' => $quantity * $product['attributes']['price_details']['original_price_inc_tax'],
                'price_without_tax' => $product->getOriginalPriceWithoutTaxAndConditions(false),
                'price_with_tax' => $product->getOriginalPriceWithTaxAndConditions(false),
                'total_price_without_tax' => $product->getOriginalPriceWithoutTaxSum(false),
                'total_price_with_tax' => $product->getOriginalPriceWithTaxSum(false),
                'amount' => $quantity,
                'tax_rate' => $product['attributes']['tax_rate'],
                'tax_rate_id' => $product['attributes']['tax_rate_id'],
                'weight' => $product['attributes']['weight'],
                'reference_code' => $product['attributes']['reference_code'],
            );

            if (isset($product['attributes']['product_combination_id'])) {
                $newProduct['product_attribute_id'] = $product['attributes']['product_combination_id'];
                $productCombinationTitleArray = array();

The assignment to $productCombinationTitleArray is dead and can be removed.

                if (isset($product['attributes']['product_combination_title'])) {
                    $productCombinationTitle = array();

                    foreach ($product['attributes']['product_combination_title'] as $key => $val) {

                        $productCombinationTitle[] = $key.': '.$val;
                    }

                    $newProduct['product_attribute_title'] = implode(', ', $productCombinationTitle);
                
                }
            }
            $modelProduct = $this->getProductModel();
            $newProducts[] = new $modelProduct($newProduct);
        }

        $orderModel->products()->saveMany($newProducts);

The variable $newProducts seems to be defined by a foreach iteration on line 63. Are you sure the iterator is never empty, otherwise this variable is not defined?

        return $orderModel;
    }

    public function createOrderFrontend(array $attributes, $shopId, $noAccountUser)
    {
        $attributes['shop_id'] = $shopId;
        $attributes['client_id'] = $attributes['user_id'];
        $client  = ClientService::selectOneByShopIdAndId($shopId, $attributes['user_id']);

        $this->repo->getModel()->fill($attributes);
        $this->repo->getModel()->save();

        if (!Cart::getContent()->count()) {
            return false;
        }

        $this->addProducts($this->repo->getModel(), Cart::getContent());
        
        if ($client) {
            if ($client->clientDeliveryAddress) {
                $deliveryOrderAddress = $this->createAddress($client->clientDeliveryAddress->toArray(), $this->repo->getModel()->id);
            }

            if ($client->clientBillAddress) {
                $billOrderAddress = $this->createAddress($client->clientBillAddress->toArray(), $this->repo->getModel()->id);
            }

            $this->repo->getModel()->fill(array('delivery_order_address_id' => $deliveryOrderAddress->id, 'bill_order_address_id' => $billOrderAddress->id));

The variable $billOrderAddress does not seem to be defined for all execution paths leading up to this point.

The variable $deliveryOrderAddress does not seem to be defined for all execution paths leading up to this point.

            $this->repo->getModel()->save();

        } elseif ($noAccountUser) {
            if (isset($noAccountUser['delivery'])) {
                $deliveryOrderAddress = $billOrderAddress = $this->createAddress($noAccountUser['delivery'], $this->repo->getModel()->id);

The assignment to $billOrderAddress is dead and can be removed.

            } else {
                $deliveryOrderAddress = $billOrderAddress = $this->createAddress($noAccountUser, $this->repo->getModel()->id);
            }

            $billOrderAddress = $billOrderAddress = $this->createAddress($noAccountUser, $this->repo->getModel()->id);
            $this->repo->getModel()->fill(array('delivery_order_address_id' => $deliveryOrderAddress->id, 'bill_order_address_id' => $billOrderAddress->id));
            $this->repo->getModel()->save();
        }

        if (Cart::getConditionsByType('sending_method')->count()) {
            $attributes = Cart::getConditionsByType('sending_method')->first()->getAttributes();
            $sendingMethod = SendingMethodService::find($attributes['data']['id']);
            $price = $sendingMethod->getPriceDetails();
            $sendingMethodArray = $sendingMethod->toArray();
            $sendingMethodArray['price_with_tax'] = Cart::getConditionsByType('sending_method')->first()->getAttributes()['data']['price_details']['original_price_inc_tax'];
            $sendingMethodArray['price_without_tax'] = Cart::getConditionsByType('sending_method')->first()->getAttributes()['data']['price_details']['original_price_ex_tax'];
            $sendingMethodArray['tax_rate'] = $price['tax_rate'];
            $sendingMethodArray['sending_method_id'] = $sendingMethod->id;
            $sendingMethodArray['order_id'] = $this->repo->getModel()->id;
            $orderSendingMethod = $this->getSendingMethodModel()->fill($sendingMethodArray);
            $orderSendingMethod = $orderSendingMethod->save();

The assignment to $orderSendingMethod is dead and can be removed.

        }

        if (Cart::getConditionsByType('payment_method')->count()) {
            $attributes = Cart::getConditionsByType('payment_method')->first()->getAttributes();
            $paymentMethod = PaymentMethodService::find($attributes['data']['id']);
            $price = $paymentMethod->getPriceDetails();
            $paymentMethodArray = $paymentMethod->toArray();
            $paymentMethodArray['price_with_tax'] = Cart::getConditionsByType('payment_method')->first()->getAttributes()['data']['value_inc_tax'];
            $paymentMethodArray['price_without_tax'] = Cart::getConditionsByType('payment_method')->first()->getAttributes()['data']['value_ex_tax'];
            $paymentMethodArray['tax_rate'] = $price['tax_rate'];
            $paymentMethodArray['payment_method_id'] = $paymentMethod->id;
            $paymentMethodArray['order_id'] = $this->repo->getModel()->id;
            $orderPaymentMethod = $this->getPaymentMethodModel()->fill($paymentMethodArray);
            $orderPaymentMethod = $orderPaymentMethod->save();

The assignment to $orderPaymentMethod is dead and can be removed.

        }

        if ($this->repo->getModel()->orderPaymentMethod->paymentMethod->order_confirmed_order_status_id) {
            $this->repo->getModel()->fill(array('order_status_id' => $this->repo->getModel()->orderPaymentMethod->paymentMethod->order_confirmed_order_status_id));
            $this->repo->getModel()->save();
        }

        return $this->repo->getModel();
    }

    public function getProductModel()
    {
        return $this->repo->getProductModel();
    }

    public function getAddressModel()
    {
        return $this->repo->getAddressModel();
    }

    public function getSendingMethodModel()
    {
        return $this->repo->getOrderSendingMethodModel();
    }

    public function getPaymentMethodModel()
    {
        return $this->repo->getOrderPaymentMethodModel();
    }

    public function updateStatus($id, $orderStatusId)
    {
        $model = $this->find($id);

        $attributes['order_status_id'] = $orderStatusId;

$attributes was never initialized. Although not strictly required by PHP, it is generally a good practice to add $attributes = array(); before regardless.

        if (count($attributes) > 0) {
            $model->fill($attributes);
            $model->save();
        }

        return $model;
    }
}