heroesofabenez / combat

src/Team.php

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -77,11 +77,11 @@
    */
   public function setCharacterPosition($id, int $row, int $column): void {
     if(!$this->hasItems(["id" => $id])) {
-      throw new \OutOfBoundsException("Character $id is not in the team");
+      throw new \OutOfBoundsException("character $id is not in the team");
     } elseif(count($this->getItems(["positionRow" => $row])) >= $this->maxRowSize) {
-      throw new InvalidCharacterPositionException("Row $row is full.", InvalidCharacterPositionException::ROW_FULL);
+      throw new InvalidCharacterPositionException("row $row is full.", InvalidCharacterPositionException::ROW_FULL);
     } elseif($this->hasItems(["positionRow" => $row, "positionColumn" => $column])) {
-      throw new InvalidCharacterPositionException("Row $row column $column is occupied.", InvalidCharacterPositionException::POSITION_OCCUPIED);
+      throw new InvalidCharacterPositionException("row $row column $column is occupied.", InvalidCharacterPositionException::POSITION_OCCUPIED);
     }
     $character = $this->getItems(["id" => $id])[0];
     $character->positionRow = $row;

src/CombatActions/SkillSpecial.php

Braces +3 added lines, -1 removed lines

@@ -52,9 +52,11 @@
   /**
    * @throws NotImplementedException
    */
-  public function do(CombatBase $combat, Character $character): void {
+  public function do {
+    (CombatBase $combat, Character $character): void {
     /** @var CharacterSpecialSkill $skill */
     $skill = $character->usableSkills[0];
+  }
     $targets = [];
     switch($skill->skill->target) {
       case Skill::TARGET_ENEMY:

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -37,7 +37,7 @@ 
       "character1" => $character1, "character2" => $target,
     ];
     $effect = new CharacterEffect([
-      "id" => "skill{$skill->skill->id}Effect",
+      "id" => "skill{$skill->skill->id}effect",
       "type" => $skill->skill->type,
       "stat" => ((in_array($skill->skill->type, Skill::NO_STAT_TYPES, true)) ? null : $skill->skill->stat),
       "value" => $skill->value,
@@ -70,7 +70,7 @@ 
         $targets = $combat->getEnemyTeam($character)->toArray();
         break;
       default:
-        throw new NotImplementedException("Target {$skill->skill->target} for special skills is not implemented.");
+        throw new NotImplementedException("target {$skill->skill->target} for special skills is not implemented.");
     }
     foreach($targets as $target) {
       $this->doSingleTarget($character, $target, $skill, $combat);

src/CombatActions/SkillAttack.php

Braces +3 added lines, -1 removed lines

@@ -54,9 +54,11 @@
   /**
    * @throws NotImplementedException
    */
-  public function do(CombatBase $combat, Character $character): void {
+  public function do {
+    (CombatBase $combat, Character $character): void {
     /** @var CharacterAttackSkill $skill */
     $skill = $character->usableSkills[0];
+  }
     $targets = [];
     /** @var Character $primaryTarget */
     $primaryTarget = $combat->selectAttackTarget($character);

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
         $targets = $combat->getTeam($primaryTarget)->getItems(["positionColumn" => $primaryTarget->positionColumn]);
         break;
       default:
-        throw new NotImplementedException("Target {$skill->skill->target} for attack skills is not implemented.");
+        throw new NotImplementedException("target {$skill->skill->target} for attack skills is not implemented.");
     }
     /** @var Character $target */
     foreach($targets as $target) {

src/ICombatAction.php

Braces +4 added lines, -2 removed lines

@@ -10,6 +10,8 @@
   public function getName(): string;
   public function getPriority(): int;
   public function shouldUse(CombatBase $combat, Character $character): bool;
-  public function do(CombatBase $combat, Character $character): void;
-}
+  public function do {
+    (CombatBase $combat, Character $character): void;
+  }
+  }
 ?>
\ No newline at end of file

tests/bootstrap.php

Spacing +1 added lines, -1 removed lines

@@ -2,7 +2,7 @@
 declare(strict_types=1);
 
 require __DIR__ . "/../vendor/autoload.php";
-Testbench\Bootstrap::setup(__DIR__ . '/_temp', function (\Nette\Configurator $configurator) {
+Testbench\Bootstrap::setup(__DIR__ . '/_temp', function(\Nette\Configurator $configurator) {
   $configurator->addParameters(["appDir" => __DIR__, ]);
   $configurator->addConfig(__DIR__ . "/tests.neon");
 });

src/CombatActions/Heal.php

Braces +3 added lines, -1 removed lines

@@ -26,8 +26,10 @@
     return (in_array($character, $this->findHealers($combat)->toArray(), true) && $this->selectHealingTarget($character, $combat) !== null);
   }
 
-  public function do(CombatBase $combat, Character $character): void {
+  public function do {
+    (CombatBase $combat, Character $character): void {
     $result = [];
+  }
     /** @var Character $patient */
     $patient = $this->selectHealingTarget($character, $combat);
     $result["result"] = $combat->successCalculator->hasHealed($character);

src/CombatActions/Attack.php

Braces +3 added lines, -1 removed lines

@@ -30,8 +30,10 @@
    * Hit chance = Attacker's hit - Defender's dodge, but at least 15%
    * Damage = Attacker's damage - defender's defense
    */
-  public function do(CombatBase $combat, Character $character): void {
+  public function do {
+    (CombatBase $combat, Character $character): void {
     $result = [];
+  }
     $defender = $combat->selectAttackTarget($character);
     if($defender === null) {
       return;

src/TextCombatLogRender.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
    */
   protected function setTemplate(string $template): void {
     if(!is_file($template)) {
-      throw new \RuntimeException("File $template does not exist.");
+      throw new \RuntimeException("file $template does not exist.");
     }
     $this->template = $template;
   }