Heal::do() - Code Metrics - Inspection of "allowed changing default action in CombatActionSel..." - heroesofabenez/combat - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 29e2cf...033bf5 )

by Jakub

created 2018-11-18 18:52 UTC

Heal::do() A

↳ Parent: Heal

Complexity

Conditions	3
Paths	4

Size

Total Lines	15
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
eloc	13
dl	0
loc	15
ccs	0
cts	12
cp	0
rs	9.8333
c	0
b	0
f	0
nc	4
nop	2
cc	3
crap	12

<?php
declare(strict_types=1);

namespace HeroesofAbenez\Combat\CombatActions;

use HeroesofAbenez\Combat\Character;
use HeroesofAbenez\Combat\CombatBase;
use HeroesofAbenez\Combat\CombatLogEntry;
use Nexendrie\Utils\Numbers;

final class Heal implements ICombatAction {
  public function getName(): string {
    return CombatLogEntry::ACTION_HEALING;
  }

  public function getPriority(): int {
    return 1000;
  }

  public function shouldUse(CombatBase $combat, Character $character): bool {
    return (in_array($character, $combat->findHealers()->toArray(), true) AND !is_null($combat->selectHealingTarget($character)));

  }

  public function do(CombatBase $combat, Character $character): void {
    $result = [];
    /** @var Character $patient */
    $patient = $combat->selectHealingTarget($character);
    $result["result"] = $combat->successCalculator->hasHealed($character);
    $amount = ($result["result"]) ? (int) ($character->intelligence / 2) : 0;
    $result["amount"] = Numbers::range($amount, 0, $patient->maxHitpoints - $patient->hitpoints);
    if($result["amount"] > 0) {
      $patient->heal($result["amount"]);
    }
    $result["action"] = CombatLogEntry::ACTION_HEALING;
    $result["name"] = "";
    $result["character1"] = $character;
    $result["character2"] = $patient;
    $combat->log->log($result);
  }
}
?>

1		<?php
2		declare(strict_types=1);
3
4		namespace HeroesofAbenez\Combat\CombatActions;
5
6		use HeroesofAbenez\Combat\Character;
7		use HeroesofAbenez\Combat\CombatBase;
8		use HeroesofAbenez\Combat\CombatLogEntry;
9		use Nexendrie\Utils\Numbers;
10
11	1	final class Heal implements ICombatAction {
12		public function getName(): string {
13	1	return CombatLogEntry::ACTION_HEALING;
14		}
15
16		public function getPriority(): int {
17	1	return 1000;
18		}
19
20		public function shouldUse(CombatBase $combat, Character $character): bool {
21	1	return (in_array($character, $combat->findHealers()->toArray(), true) AND !is_null($combat->selectHealingTarget($character)));
		0 ignored issues – show introduced 2018-11-18 18:55 UTC by Report Bug Copy Issue Report Line exceeds 120 characters; contains 130 characters Loading history...
22		}
23
24		public function do(CombatBase $combat, Character $character): void {
25		$result = [];
26		/** @var Character $patient */
27		$patient = $combat->selectHealingTarget($character);
28		$result["result"] = $combat->successCalculator->hasHealed($character);
29		$amount = ($result["result"]) ? (int) ($character->intelligence / 2) : 0;
30		$result["amount"] = Numbers::range($amount, 0, $patient->maxHitpoints - $patient->hitpoints);
31		if($result["amount"] > 0) {
32		$patient->heal($result["amount"]);
33		}
34		$result["action"] = CombatLogEntry::ACTION_HEALING;
35		$result["name"] = "";
36		$result["character1"] = $character;
37		$result["character2"] = $patient;
38		$combat->log->log($result);
39		}
40		}
41		?>

heroesofabenez / combat

Push — master ( 29e2cf...033bf5 )

Heal::do() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like