CombatActionSelector::chooseAction() - Code Metrics - Inspection of "allowed changing default action in CombatActionSel..." - heroesofabenez/combat - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 29e2cf...033bf5 )

by Jakub

created 2018-11-18 18:52 UTC

CombatActionSelector::chooseAction() A

↳ Parent: CombatActionSelector

Complexity

Conditions	4
Paths	4

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4.128

Importance

Changes

Metric	Value
eloc	9
dl	0
loc	15
ccs	8
cts	10
cp	0.8
rs	9.9666
c	0
b	0
f	0
nc	4
nop	2
cc	4
crap	4.128

<?php
declare(strict_types=1);

namespace HeroesofAbenez\Combat;

use HeroesofAbenez\Combat\CombatActions\ICombatAction;

/**
 * CombatActionSelector
 *
 * @author Jakub Konečný
 * @property string $defaultAction
 */
final class CombatActionSelector implements ICombatActionSelector {
  use \Nette\SmartObject;

  /** @var string */
  protected $defaultAction = CombatLogEntry::ACTION_ATTACK;

  /**
   * @return string
   */
  public function getDefaultAction(): string {
    return $this->defaultAction;
  }

  /**
   * @param string $defaultAction
   */
  public function setDefaultAction(string $defaultAction): void {
    $this->defaultAction = $defaultAction;
  }

  public function chooseAction(CombatBase $combat, Character $character): ?string {
    if($character->hitpoints < 1) {
      return null;
    }
    /** @var ICombatAction[] $actions */
    $actions = $combat->combatActions->toArray();
    usort($actions, function(ICombatAction $a, ICombatAction $b) {
      return $a->getPriority() < $b->getPriority();
    });
    foreach($actions as $action) {
      if($action->shouldUse($combat, $character)) {
        return $action->getName();
      }
    }
    return $this->defaultAction;
  }
}
?>

1		<?php
2		declare(strict_types=1);
3
4		namespace HeroesofAbenez\Combat;
5
6		use HeroesofAbenez\Combat\CombatActions\ICombatAction;
7
8		/**
9		* CombatActionSelector
10		*
11		* @author Jakub Konečný
12		* @property string $defaultAction
13		*/
14	1	final class CombatActionSelector implements ICombatActionSelector {
15	1	use \Nette\SmartObject;
16
17		/** @var string */
18		protected $defaultAction = CombatLogEntry::ACTION_ATTACK;
19
20		/**
21		* @return string
22		*/
23		public function getDefaultAction(): string {
24		return $this->defaultAction;
25		}
26
27		/**
28		* @param string $defaultAction
29		*/
30		public function setDefaultAction(string $defaultAction): void {
31		$this->defaultAction = $defaultAction;
32		}
33
34		public function chooseAction(CombatBase $combat, Character $character): ?string {
35	1	if($character->hitpoints < 1) {
36		return null;
37		}
38		/** @var ICombatAction[] $actions */
39	1	$actions = $combat->combatActions->toArray();
40	1	usort($actions, function(ICombatAction $a, ICombatAction $b) {
41	1	return $a->getPriority() < $b->getPriority();
42	1	});
43	1	foreach($actions as $action) {
44	1	if($action->shouldUse($combat, $character)) {
45	1	return $action->getName();
46		}
47		}
48		return $this->defaultAction;
49		}
50		}
51		?>

heroesofabenez / combat

Push — master ( 29e2cf...033bf5 )

CombatActionSelector::chooseAction() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like