Inspection of "marked some properties as readonly" - heroesofabenez/combat - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( bc69e6...465240 )

by Jakub

created 2025-07-19 20:49 UTC

Status

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -22,7 +22,7 @@
 block discarded – undo
   
   protected function generateCharacter(int $id): Character {
     $stats = [
-      "id" => $id, "name" => "Player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
+      "id" => $id, "name" => "player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
       "dexterity" => 10, "constitution" => 10, "intelligence" => 10, "charisma" => 10
     ];
     $petStats = [

Please login to merge, or discard this patch.

tests/HeroesofAbenez/Combat/CombatActions/HealTest.php 1 patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -28,7 +28,7 @@
 block discarded – undo
 
   protected function generateCharacter(int $id): Character {
     $stats = [
-      "id" => $id, "name" => "Player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
+      "id" => $id, "name" => "player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
       "dexterity" => 10, "constitution" => 10, "intelligence" => 10, "charisma" => 10
     ];
     return new Character($stats);

Please login to merge, or discard this patch.

tests/HeroesofAbenez/Combat/CombatActions/SkillAttackTest.php 1 patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -29,7 +29,7 @@
 block discarded – undo
 
   protected function generateCharacter(int $id): Character {
     $stats = [
-      "id" => $id, "name" => "Player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
+      "id" => $id, "name" => "player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
       "dexterity" => 10, "constitution" => 10, "intelligence" => 10, "charisma" => 10
     ];
     $skillData = [

Please login to merge, or discard this patch.

tests/HeroesofAbenez/Combat/CombatActions/SkillSpecialTest.php 1 patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -29,7 +29,7 @@
 block discarded – undo
 
   protected function generateCharacter(int $id): Character {
     $stats = [
-      "id" => $id, "name" => "Player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
+      "id" => $id, "name" => "player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
       "dexterity" => 10, "constitution" => 10, "intelligence" => 10, "charisma" => 10
     ];
     $skillData = [

Please login to merge, or discard this patch.

tests/HeroesofAbenez/Combat/CombatActions/AttackTest.php 1 patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -27,7 +27,7 @@
 block discarded – undo
 
   protected function generateCharacter(int $id): Character {
     $stats = [
-      "id" => $id, "name" => "Player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
+      "id" => $id, "name" => "player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
       "dexterity" => 10, "constitution" => 10, "intelligence" => 10, "charisma" => 10
     ];
     return new Character($stats);

Please login to merge, or discard this patch.

tests/HeroesofAbenez/Combat/StaticSuccessCalculatorTest.php 1 patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -20,7 +20,7 @@
 block discarded – undo
   
   protected function generateCharacter(int $id): Character {
     $stats = [
-      "id" => $id, "name" => "Player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
+      "id" => $id, "name" => "player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
       "dexterity" => 10, "constitution" => 10, "intelligence" => 10, "charisma" => 10
     ];
     return new Character($stats);

Please login to merge, or discard this patch.

tests/HeroesofAbenez/Combat/TextCombatLogRenderTest.php 1 patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -17,7 +17,7 @@
 block discarded – undo
 
   protected function generateCharacter(int $id): Character {
     $stats = [
-      "id" => $id, "name" => "Player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
+      "id" => $id, "name" => "player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
       "dexterity" => 10, "constitution" => 10, "intelligence" => 10, "charisma" => 10
     ];
     return new Character($stats);

Please login to merge, or discard this patch.

tests/HeroesofAbenez/Combat/CharacterTest.php 1 patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -14,7 +14,7 @@
 block discarded – undo
 final class CharacterTest extends \Tester\TestCase {
   protected function generateCharacter(int $id): Character {
     $stats = [
-      "id" => $id, "name" => "Player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
+      "id" => $id, "name" => "player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
       "dexterity" => 10, "constitution" => 10, "intelligence" => 10, "charisma" => 10
     ];
     return new Character($stats);

Please login to merge, or discard this patch.

tests/HeroesofAbenez/Combat/CombatLoggerTest.php 1 patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -48,7 +48,7 @@
 block discarded – undo
   
   protected function generateCharacter(int $id): Character {
     $stats = [
-      "id" => $id, "name" => "Player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
+      "id" => $id, "name" => "player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
       "dexterity" => 10, "constitution" => 10, "intelligence" => 10, "charisma" => 10
     ];
     return new Character($stats);

Please login to merge, or discard this patch.

		@@ -29,7 +29,7 @@
		block discarded – undo
29	29
30	30	protected function generateCharacter(int $id): Character {
31	31	$stats = [
32		- "id" => $id, "name" => "Player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
	32	+ "id" => $id, "name" => "player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
33	33	"dexterity" => 10, "constitution" => 10, "intelligence" => 10, "charisma" => 10
34	34	];
35	35	$skillData = [

		@@ -29,7 +29,7 @@
		block discarded – undo
29	29
30	30	protected function generateCharacter(int $id): Character {
31	31	$stats = [
32		- "id" => $id, "name" => "Player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
	32	+ "id" => $id, "name" => "player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
33	33	"dexterity" => 10, "constitution" => 10, "intelligence" => 10, "charisma" => 10
34	34	];
35	35	$skillData = [

		@@ -22,7 +22,7 @@
		block discarded – undo
22	22
23	23	protected function generateCharacter(int $id): Character {
24	24	$stats = [
25		- "id" => $id, "name" => "Player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
	25	+ "id" => $id, "name" => "player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
26	26	"dexterity" => 10, "constitution" => 10, "intelligence" => 10, "charisma" => 10
27	27	];
28	28	$petStats = [

		@@ -28,7 +28,7 @@
		block discarded – undo
28	28
29	29	protected function generateCharacter(int $id): Character {
30	30	$stats = [
31		- "id" => $id, "name" => "Player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
	31	+ "id" => $id, "name" => "player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
32	32	"dexterity" => 10, "constitution" => 10, "intelligence" => 10, "charisma" => 10
33	33	];
34	34	return new Character($stats);

		@@ -27,7 +27,7 @@
		block discarded – undo
27	27
28	28	protected function generateCharacter(int $id): Character {
29	29	$stats = [
30		- "id" => $id, "name" => "Player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
	30	+ "id" => $id, "name" => "player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
31	31	"dexterity" => 10, "constitution" => 10, "intelligence" => 10, "charisma" => 10
32	32	];
33	33	return new Character($stats);

		@@ -20,7 +20,7 @@
		block discarded – undo
20	20
21	21	protected function generateCharacter(int $id): Character {
22	22	$stats = [
23		- "id" => $id, "name" => "Player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
	23	+ "id" => $id, "name" => "player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
24	24	"dexterity" => 10, "constitution" => 10, "intelligence" => 10, "charisma" => 10
25	25	];
26	26	return new Character($stats);

		@@ -17,7 +17,7 @@
		block discarded – undo
17	17
18	18	protected function generateCharacter(int $id): Character {
19	19	$stats = [
20		- "id" => $id, "name" => "Player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
	20	+ "id" => $id, "name" => "player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
21	21	"dexterity" => 10, "constitution" => 10, "intelligence" => 10, "charisma" => 10
22	22	];
23	23	return new Character($stats);

		@@ -14,7 +14,7 @@
		block discarded – undo
14	14	final class CharacterTest extends \Tester\TestCase {
15	15	protected function generateCharacter(int $id): Character {
16	16	$stats = [
17		- "id" => $id, "name" => "Player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
	17	+ "id" => $id, "name" => "player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
18	18	"dexterity" => 10, "constitution" => 10, "intelligence" => 10, "charisma" => 10
19	19	];
20	20	return new Character($stats);

		@@ -48,7 +48,7 @@
		block discarded – undo
48	48
49	49	protected function generateCharacter(int $id): Character {
50	50	$stats = [
51		- "id" => $id, "name" => "Player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
	51	+ "id" => $id, "name" => "player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
52	52	"dexterity" => 10, "constitution" => 10, "intelligence" => 10, "charisma" => 10
53	53	];
54	54	return new Character($stats);

heroesofabenez / combat

Push — master ( bc69e6...465240 )

Status

Category

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch