heiglandreas / JUnitDiff

src/Writer/Summary.php

Doc Comments +4 added lines

@@ -41,6 +41,10 @@
 
     protected $file2;
 
+    /**
+     * @param string $file1
+     * @param string $file2
+     */
     public function __construct(StyleInterface $style, $file1, $file2)
     {
         $this->style = $style;

src/Writer/Standard.php

Doc Comments +3 added lines

@@ -40,6 +40,9 @@
 
     private $verbosity;
 
+    /**
+     * @param integer $verbosity
+     */
     public function __construct(StyleInterface $style, $verbosity = Output::VERBOSITY_NORMAL)
     {
         $this->style = $style;

Spacing +4 added lines, -4 removed lines

@@ -51,11 +51,11 @@ 
         $mergeResult->sort();
 
         foreach ($mergeResult as $key => $value) {
-            if (! isset($value['base'])) {
+            if (!isset($value['base'])) {
                 $this->writeAddedTest($key);
                 continue;
             }
-            if (! isset($value['current'])) {
+            if (!isset($value['current'])) {
                 $this->writeRemovedTest($key);
                 continue;
             }
@@ -112,7 +112,7 @@ 
 
     private function addVerboseInformationToChangedTest($current)
     {
-        if (! $current['message']) {
+        if (!$current['message']) {
             return;
         }
 
@@ -129,7 +129,7 @@ 
 
     private function addVeryVerboseInformationToChangedTest($current)
     {
-        if (! $current['info']) {
+        if (!$current['info']) {
             return;
         }
 

src/Command/CompareCommand.php

Unused Use Statements -1 removed lines

@@ -36,7 +36,6 @@
 use Org_Heigl\JUnitDiff\Writer\FileSummary;
 use Org_Heigl\JUnitDiff\Writer\Legend;
 use Org_Heigl\JUnitDiff\Writer\Standard;
-use Org_Heigl\JUnitDiff\Writer\Quiet;
 use Org_Heigl\JUnitDiff\Writer\Summary;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputArgument;

Indentation +6 added lines, -6 removed lines

@@ -49,12 +49,12 @@
     protected function configure()
     {
         $this->setName('compare')
-             ->setDescription('Compares two JUnit log files')
-             ->setDefinition([
-                 new InputArgument('base', InputArgument::REQUIRED, 'Base file for the comparison'),
-                 new InputArgument('current', InputArgument::REQUIRED, 'Current file to compare against the base file')
-             ])
-             ->setHelp('');
+                ->setDescription('Compares two JUnit log files')
+                ->setDefinition([
+                    new InputArgument('base', InputArgument::REQUIRED, 'Base file for the comparison'),
+                    new InputArgument('current', InputArgument::REQUIRED, 'Current file to compare against the base file')
+                ])
+                ->setHelp('');
     }
 
 

src/JUnitParser.php

Spacing +5 added lines, -5 removed lines

@@ -39,7 +39,7 @@ 
     public function getLastLibXmlError()
     {
         $error = libxml_get_last_error();
-        if (! $error instanceof \LibXMLError) {
+        if (!$error instanceof \LibXMLError) {
             return false;
         }
 
@@ -54,7 +54,7 @@ 
      */
     public function parseFile($filename)
     {
-        if (! is_readable($filename)) {
+        if (!is_readable($filename)) {
             throw new \UnexpectedValueException(sprintf(
                 'File %s is not readable',
                 basename($filename)
@@ -77,7 +77,7 @@ 
         $items = $xpath->query('//testcase');
         foreach ($items as $item) {
             $class = $item->getAttribute('class');
-            if (! $class) {
+            if (!$class) {
                 $class = explode('::', $item->parentNode->getAttribute('name'))[0];
             }
 
@@ -98,14 +98,14 @@ 
             switch ($type) {
                 case 'error':
                 case 'failure':
-                    if (! $element->hasAttributes()) {
+                    if (!$element->hasAttributes()) {
                         break;
                     }
                     $message = $element->attributes->getNamedItem('message');
                     if ($message instanceof \DOMAttr) {
                         $message = $message->value;
                     }
-                    $ftype   = $element->attributes->getNamedItem('type');
+                    $ftype = $element->attributes->getNamedItem('type');
                     if ($ftype instanceof \DOMAttr) {
                         $ftype = $ftype->value;
                     }

src/Command/DiffCommand.php

Indentation +6 added lines, -6 removed lines

@@ -41,12 +41,12 @@
     protected function configure()
     {
         $this->setName('diff')
-             ->setDescription('Shows a diff between two JUnit log files')
-             ->setDefinition([
-                 new InputOption('input1', '1', InputOption::VALUE_REQUIRED, 'First input file'),
-                 new InputOption('input2', '2', InputOption::VALUE_REQUIRED, 'Second input file')
-             ])
-             ->setHelp('');
+                ->setDescription('Shows a diff between two JUnit log files')
+                ->setDefinition([
+                    new InputOption('input1', '1', InputOption::VALUE_REQUIRED, 'First input file'),
+                    new InputOption('input2', '2', InputOption::VALUE_REQUIRED, 'Second input file')
+                ])
+                ->setHelp('');
     }
 
 

Spacing +2 added lines, -2 removed lines

@@ -78,11 +78,11 @@
         $array = $this->merge($array1, $array2);
 
         foreach ($array as $key => $value) {
-            if (! isset($value['base'])) {
+            if (!isset($value['base'])) {
                 $output->writeln('<bg=green;fg=black>+</> ' . $key);
                 continue;
             }
-            if (! isset($value['current'])) {
+            if (!isset($value['current'])) {
                 $output->writeln('<bg=red;fg=yellow>-</> ' . $key);
                 continue;
             }