TransitionController::store() - Code Metrics - hechoenlaravel/jarvis-foundation - Measure and Improve Code Quality continuously with Scrutinizer

TransitionController::store() A
last analyzed 2018-01-10 19:19 UTC

↳ Parent: TransitionController

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	7
nc	1
nop	1

<?php

namespace Hechoenlaravel\JarvisFoundation\Http\Controllers\Core;

use Hechoenlaravel\JarvisFoundation\Flows\Flow;
use Hechoenlaravel\JarvisFoundation\Flows\Step;
use Hechoenlaravel\JarvisFoundation\Http\Requests;
use Hechoenlaravel\JarvisFoundation\Flows\Transition;
use Hechoenlaravel\JarvisFoundation\Traits\FlowManager;
use Hechoenlaravel\JarvisFoundation\Http\Controllers\Controller;
use Hechoenlaravel\JarvisFoundation\Flows\Transformers\TransitionTransformer;

/**
 * Class TransitionController
 * @package Hechoenlaravel\JarvisFoundation\Http\Controllers\Core
 */
class TransitionController extends Controller
{
    use FlowManager;

    /**
     * @param Requests\TransitionRequest $request
     * @return \Illuminate\Http\JsonResponse
     */
    public function store(Requests\TransitionRequest $request)
    {
        $transition = $this->createTransition([
            'flow' => Flow::find($request->get('flow_id')),
            'from' => Step::find($request->get('from')),
            'to' => Step::find($request->get('to'))
        ]);
        $response = fractal()->item($transition, new TransitionTransformer())->toArray();
        return response()->json($response);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     * @param $id
     * @return \Illuminate\Http\JsonResponse
     */
    public function destroy($id)
    {
        $this->deleteTransition(Transition::findOrFail($id));
        return response()->json(null, 204);
    }
}


1			<?php
2
3			namespace Hechoenlaravel\JarvisFoundation\Http\Controllers\Core;
4
5			use Hechoenlaravel\JarvisFoundation\Flows\Flow;
6			use Hechoenlaravel\JarvisFoundation\Flows\Step;
7			use Hechoenlaravel\JarvisFoundation\Http\Requests;
8			use Hechoenlaravel\JarvisFoundation\Flows\Transition;
9			use Hechoenlaravel\JarvisFoundation\Traits\FlowManager;
10			use Hechoenlaravel\JarvisFoundation\Http\Controllers\Controller;
11			use Hechoenlaravel\JarvisFoundation\Flows\Transformers\TransitionTransformer;
12
13			/**
14			* Class TransitionController
15			* @package Hechoenlaravel\JarvisFoundation\Http\Controllers\Core
16			*/
17			class TransitionController extends Controller
18			{
19			use FlowManager;
20
21			/**
22			* @param Requests\TransitionRequest $request
23			* @return \Illuminate\Http\JsonResponse
24			*/
25			public function store(Requests\TransitionRequest $request)
26			{
27			$transition = $this->createTransition([
28			'flow' => Flow::find($request->get('flow_id')),
29			'from' => Step::find($request->get('from')),
30			'to' => Step::find($request->get('to'))
31			]);
32			$response = fractal()->item($transition, new TransitionTransformer())->toArray();
33			return response()->json($response);
			0 ignored issues – show Bug introduced 2017-02-06 19:54 UTC by Report Bug Copy Issue Report It seems like `$response` defined by `fractal()->item($transit...ansformer())->toArray()` on line `32` can also be of type `null`; however, `Illuminate\Contracts\Rou...ResponseFactory::json()` does only seem to accept `string\|array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
34			}
35
36			/**
37			* @param $id
38			* @return \Illuminate\Http\JsonResponse
39			*/
40			public function destroy($id)
41			{
42			$this->deleteTransition(Transition::findOrFail($id));
43			return response()->json(null, 204);
44			}
45			}
46

hechoenlaravel / jarvis-foundation

TransitionController::store() A last analyzed 2018-01-10 19:19 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

TransitionController::store() A
last analyzed 2018-01-10 19:19 UTC