Hechoenlaravel\JarvisFoundation\Http\Controllers\Core\TransitionController

Complexity

Total Complexity

2

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	store()	0	10	1
A	destroy()	0	5	1

<?php

namespace Hechoenlaravel\JarvisFoundation\Http\Controllers\Core;

use Hechoenlaravel\JarvisFoundation\Flows\Flow;
use Hechoenlaravel\JarvisFoundation\Flows\Step;
use Hechoenlaravel\JarvisFoundation\Http\Requests;
use Hechoenlaravel\JarvisFoundation\Flows\Transition;
use Hechoenlaravel\JarvisFoundation\Traits\FlowManager;
use Hechoenlaravel\JarvisFoundation\Http\Controllers\Controller;
use Hechoenlaravel\JarvisFoundation\Flows\Transformers\TransitionTransformer;

/**
 * Class TransitionController
 * @package Hechoenlaravel\JarvisFoundation\Http\Controllers\Core
 */
class TransitionController extends Controller
{
    use FlowManager;

    /**
     * @param Requests\TransitionRequest $request
     * @return \Illuminate\Http\JsonResponse
     */
    public function store(Requests\TransitionRequest $request)
    {
        $transition = $this->createTransition([
            'flow' => Flow::find($request->get('flow_id')),
            'from' => Step::find($request->get('from')),
            'to' => Step::find($request->get('to'))
        ]);
        $response = fractal()->item($transition, new TransitionTransformer())->toArray();
        return response()->json($response);

It seems like $response defined by fractal()->item($transition, new \Hechoenlaravel\JarvisFoundation\Flows\Transformers\TransitionTransformer())->toArray() on line 32 can also be of type null; however, Illuminate\Contracts\Routing\ResponseFactory::json() does only seem to accept string|array, maybe add an additional type check?

    }

    /**
     * @param $id
     * @return \Illuminate\Http\JsonResponse
     */
    public function destroy($id)
    {
        $this->deleteTransition(Transition::findOrFail($id));
        return response()->json(null, 204);
    }
}