StepController::store() - Code Metrics - hechoenlaravel/jarvis-foundation - Measure and Improve Code Quality continuously with Scrutinizer

StepController::store() A
last analyzed 2018-01-10 19:19 UTC

↳ Parent: StepController

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	6
nc	1
nop	1

<?php

namespace Hechoenlaravel\JarvisFoundation\Http\Controllers\Core;

use Illuminate\Http\Request;
use Hechoenlaravel\JarvisFoundation\Flows\Flow;
use Hechoenlaravel\JarvisFoundation\Flows\Step;
use Hechoenlaravel\JarvisFoundation\Http\Requests;
use Hechoenlaravel\JarvisFoundation\Traits\FlowManager;
use Hechoenlaravel\JarvisFoundation\Http\Controllers\Controller;
use Hechoenlaravel\JarvisFoundation\Flows\Transformers\StepTransformer;

/**
 * Class StepController
 * @package Hechoenlaravel\JarvisFoundation\Http\Controllers\Core
 */
class StepController extends Controller
{
    use FlowManager;

    /**
     * @param Request $request
     * @return \Illuminate\Http\JsonResponse
     */
    public function index(Request $request)
    {
        $step = Step::with('transitions')->orderBy('order', 'asc');
        if ($request->has('flow_id')) {
            $step->where('flow_id', $request->get('flow_id'));
        }
        $response = fractal()->collection($step->get(), new StepTransformer())->toArray();
        return response()->json($response);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     * @param Requests\StepRequest $request
     * @return \Illuminate\Http\JsonResponse
     */
    public function store(Requests\StepRequest $request)
    {
        $input = $request->only(['flow_id', 'name', 'description']);
        $input['flow'] = Flow::find($input['flow_id']);
        $step = $this->createStep($input);
        $response = fractal()->item($step, new StepTransformer())->toArray();
        return response()->json($response);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     * @param Requests\StepRequest $request
     * @param $id
     * @return \Illuminate\Http\JsonResponse
     */
    public function update(Requests\StepRequest $request, $id)
    {
        $step = $this->updateStep(Step::findOrFail($id), $request->all());
        $response = fractal()->item($step, new StepTransformer())->toArray();
        return response()->json($response);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     * @param $id
     * @return \Illuminate\Http\JsonResponse
     */
    public function destroy($id)
    {
        $this->deleteStep(Step::findOrFail($id));
        return response()->json(null, 204);
    }
}


1			<?php
2
3			namespace Hechoenlaravel\JarvisFoundation\Http\Controllers\Core;
4
5			use Illuminate\Http\Request;
6			use Hechoenlaravel\JarvisFoundation\Flows\Flow;
7			use Hechoenlaravel\JarvisFoundation\Flows\Step;
8			use Hechoenlaravel\JarvisFoundation\Http\Requests;
9			use Hechoenlaravel\JarvisFoundation\Traits\FlowManager;
10			use Hechoenlaravel\JarvisFoundation\Http\Controllers\Controller;
11			use Hechoenlaravel\JarvisFoundation\Flows\Transformers\StepTransformer;
12
13			/**
14			* Class StepController
15			* @package Hechoenlaravel\JarvisFoundation\Http\Controllers\Core
16			*/
17			class StepController extends Controller
18			{
19			use FlowManager;
20
21			/**
22			* @param Request $request
23			* @return \Illuminate\Http\JsonResponse
24			*/
25			public function index(Request $request)
26			{
27			$step = Step::with('transitions')->orderBy('order', 'asc');
28			if ($request->has('flow_id')) {
29			$step->where('flow_id', $request->get('flow_id'));
30			}
31			$response = fractal()->collection($step->get(), new StepTransformer())->toArray();
32			return response()->json($response);
			0 ignored issues – show Bug introduced 2018-01-10 19:19 UTC by Report Bug Copy Issue Report It seems like `$response` defined by `fractal()->collection($s...ansformer())->toArray()` on line `31` can also be of type `null`; however, `Illuminate\Contracts\Rou...ResponseFactory::json()` does only seem to accept `string\|array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
33			}
34
35			/**
36			* @param Requests\StepRequest $request
37			* @return \Illuminate\Http\JsonResponse
38			*/
39			public function store(Requests\StepRequest $request)
40			{
41			$input = $request->only(['flow_id', 'name', 'description']);
42			$input['flow'] = Flow::find($input['flow_id']);
43			$step = $this->createStep($input);
44			$response = fractal()->item($step, new StepTransformer())->toArray();
45			return response()->json($response);
			0 ignored issues – show Bug introduced 2017-02-06 19:54 UTC by Report Bug Copy Issue Report It seems like `$response` defined by `fractal()->item($step, n...ansformer())->toArray()` on line `44` can also be of type `null`; however, `Illuminate\Contracts\Rou...ResponseFactory::json()` does only seem to accept `string\|array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
46			}
47
48			/**
49			* @param Requests\StepRequest $request
50			* @param $id
51			* @return \Illuminate\Http\JsonResponse
52			*/
53			public function update(Requests\StepRequest $request, $id)
54			{
55			$step = $this->updateStep(Step::findOrFail($id), $request->all());
56			$response = fractal()->item($step, new StepTransformer())->toArray();
57			return response()->json($response);
			0 ignored issues – show Bug introduced 2017-02-06 19:54 UTC by Report Bug Copy Issue Report It seems like `$response` defined by `fractal()->item($step, n...ansformer())->toArray()` on line `56` can also be of type `null`; however, `Illuminate\Contracts\Rou...ResponseFactory::json()` does only seem to accept `string\|array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
58			}
59
60			/**
61			* @param $id
62			* @return \Illuminate\Http\JsonResponse
63			*/
64			public function destroy($id)
65			{
66			$this->deleteStep(Step::findOrFail($id));
67			return response()->json(null, 204);
68			}
69			}
70

hechoenlaravel / jarvis-foundation

StepController::store() A last analyzed 2018-01-10 19:19 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

StepController::store() A
last analyzed 2018-01-10 19:19 UTC