Hechoenlaravel\JarvisFoundation\Http\Controllers\Core\StepController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	9	2
A	store()	0	8	1
A	update()	0	6	1
A	destroy()	0	5	1

<?php

namespace Hechoenlaravel\JarvisFoundation\Http\Controllers\Core;

use Illuminate\Http\Request;
use Hechoenlaravel\JarvisFoundation\Flows\Flow;
use Hechoenlaravel\JarvisFoundation\Flows\Step;
use Hechoenlaravel\JarvisFoundation\Http\Requests;
use Hechoenlaravel\JarvisFoundation\Traits\FlowManager;
use Hechoenlaravel\JarvisFoundation\Http\Controllers\Controller;
use Hechoenlaravel\JarvisFoundation\Flows\Transformers\StepTransformer;

/**
 * Class StepController
 * @package Hechoenlaravel\JarvisFoundation\Http\Controllers\Core
 */
class StepController extends Controller
{
    use FlowManager;

    /**
     * @param Request $request
     * @return \Illuminate\Http\JsonResponse
     */
    public function index(Request $request)
    {
        $step = Step::with('transitions')->orderBy('order', 'asc');
        if ($request->has('flow_id')) {
            $step->where('flow_id', $request->get('flow_id'));
        }
        $response = fractal()->collection($step->get(), new StepTransformer())->toArray();
        return response()->json($response);

It seems like $response defined by fractal()->collection($step->get(), new \Hechoenlaravel\JarvisFoundation\Flows\Transformers\StepTransformer())->toArray() on line 31 can also be of type null; however, Illuminate\Contracts\Routing\ResponseFactory::json() does only seem to accept string|array, maybe add an additional type check?

    }

    /**
     * @param Requests\StepRequest $request
     * @return \Illuminate\Http\JsonResponse
     */
    public function store(Requests\StepRequest $request)
    {
        $input = $request->only(['flow_id', 'name', 'description']);
        $input['flow'] = Flow::find($input['flow_id']);
        $step = $this->createStep($input);
        $response = fractal()->item($step, new StepTransformer())->toArray();
        return response()->json($response);

It seems like $response defined by fractal()->item($step, new \Hechoenlaravel\JarvisFoundation\Flows\Transformers\StepTransformer())->toArray() on line 44 can also be of type null; however, Illuminate\Contracts\Routing\ResponseFactory::json() does only seem to accept string|array, maybe add an additional type check?

    }

    /**
     * @param Requests\StepRequest $request
     * @param $id
     * @return \Illuminate\Http\JsonResponse
     */
    public function update(Requests\StepRequest $request, $id)
    {
        $step = $this->updateStep(Step::findOrFail($id), $request->all());
        $response = fractal()->item($step, new StepTransformer())->toArray();
        return response()->json($response);

It seems like $response defined by fractal()->item($step, new \Hechoenlaravel\JarvisFoundation\Flows\Transformers\StepTransformer())->toArray() on line 56 can also be of type null; however, Illuminate\Contracts\Routing\ResponseFactory::json() does only seem to accept string|array, maybe add an additional type check?

    }

    /**
     * @param $id
     * @return \Illuminate\Http\JsonResponse
     */
    public function destroy($id)
    {
        $this->deleteStep(Step::findOrFail($id));
        return response()->json(null, 204);
    }
}