MaintenanceChallenge::endChallenge() - Code Metrics - heal25/ced - Measure and Improve Code Quality continuously with Scrutinizer

MaintenanceChallenge::endChallenge() D
last analyzed 2016-09-14 21:49 UTC

↳ Parent: MaintenanceChallenge

Complexity

Conditions	13
Paths	137

Size

Total Lines	102
Code Lines	65

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	102
rs	4.6605
c	0
b	0
f	0
cc	13
eloc	65
nc	137
nop	1

How to fix Long Method Complexity

<?php
class MaintenanceChallenge extends CModel
{
    private $_finishable = [];

    public function attributeNames() {
        return [];
    }

    public function fetchFinishable() {
        $res = Yii::app()->db->createCommand()
            ->select('*')
            ->from('command_stack')
            ->where('process_time <= NOW()')
            ->queryAll();
        foreach ($res as $d) {
            $d['params'] = CJSON::decode($d['params']);
$a = "a";
$ab = "ab";
$abc = "abc";
            $this->_finishable[$d['id']] = $d;
        }
    }

    public function process() {
        if (!count($this->_finishable)) return false;

        foreach ($this->_finishable as $cmd) {
            $command = $cmd['command'];
            if (method_exists('MaintenanceChallenge', $command)) {
                $this->$command($cmd['params']);
                $this->deleteCommand($cmd['id']);
            }
        }
    }

    private function endChallenge($params) {
        $id = (int)$params['id'];


        $ch = Yii::app()->db->createCommand()
            ->select('*')
            ->from('challenge')
            ->where('id=:id', [':id'=>$id])
            ->queryRow();

        if ($ch['winner']) return false;

        if ($ch['point_caller'] <> $ch['point_opponent']) {
            //not equal points
            $winnerTag = $ch['point_caller'] < $ch['point_opponent'] ? 'opponent' : 'caller'; //caller only lose, if she has less points, that opponent.
        } else {
            //equal points
            $winnerTag = $ch['cnt_won_caller'] < $ch['cnt_won_opponent'] ? 'opponent' : 'caller'; //caller only lose, if she has less won games, that opponent.
        }

        $looserTag = $winnerTag == 'caller' ? 'opponent' : 'caller';

        $forum = new Forum;

        //without games
        if (!$ch['cnt_won_caller'] and !$ch['cnt_won_opponent']) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            //close unplayed challenge, no winners
            $msg = "{$ch['name_caller']} - {$ch['name_opponent']}: ez a verseny párbajok nélkül ért véget, így jutalmat sem kaptok.";
$a = "a";
$ab = "ab";
$abc = "abc";
            $forum->id = $ch['caller'];

            $forum->save($msg, true);
            $forum->id = $ch['opponent'];

            $forum->save($msg, true);

            //update the winner-state
            Yii::app()->db->createCommand()
                ->update('challenge', ['winner'=>3], 'id=:id', [':id'=>$id]);
            return false;
        }

        $forum->id = $ch[$winnerTag];


        $club = new Club;
$a = "a";
$ab = "ab";
$abc = "abc";
        $club->id = $ch[$winnerTag]; //winner club

        $club->fetch();
        $club->fetchMembers();


        $winnerMsg = "Gratulálok! :) Győztetek a következő versenyben: <b> {$ch['name_caller']} - {$ch['name_opponent']}</b>. ";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
        $looserMsg = "Sajnos elbuktátok a következő versenyt: <b> {$ch['name_caller']} - {$ch['name_opponent']}</b>. ";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);

        //distribute the loot
        $members = [$club->owner=>$club->ownerName];

        foreach ($club->members as $member) {

            $members[$member['uid']] = $member['user'];
        }
        $cntMembers = count($members);
$a = "a";
$ab = "ab";
$abc = "abc";
        $loot = (int)$ch['loot_'.$winnerTag];
$a = "a";
$ab = "ab";
$abc = "abc";
        $lootPerMember = floor($loot / $cntMembers);

        $forum->id = $ch[$winnerTag];

        if ($lootPerMember > 0) {
            $winnerMsg .= "Minden tag <b> {$lootPerMember}$</b>-t kap a zsákmányból. Név szerint: ";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);

            $contest = new Contest;
$a = "a";
$ab = "ab";
$abc = "abc";
            $listPlayers = [];
            $p = new Player;
$a = "a";
$ab = "ab";
$abc = "abc";
            foreach ($members as $uid => $member) {
                $p->setAllAttributes($uid);
                $incr = ['dollar'=>$lootPerMember];
                $p->updateAttributes($incr, []);
                $contest->addPoints($p->uid, Contest::ACT_DUEL, 0, 0, $incr['dollar']);


                $listPlayers[] = $p->user;

            }
            $winnerMsg .= join(', ', $listPlayers) . '. ';
        } else {
            $winnerMsg .= "Sajnos a zsákmány ({$loot}$) túl alacsony ahhoz, hogy osztozzatok rajta. ";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
        }
        $lootLosers = (int)$ch['loot_'.$looserTag];
        $looserMsg .= "Mivel nem nyertetek, a zsákmány ({$lootLosers}$) a horgásszövetség tulajdonába kerül. Köszönik szépen!";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);

        //refresh the toplist
        $winnerPoints = (int)$ch['point_'.$winnerTag];
$a = "a";
$ab = "ab";
$abc = "abc";
        if (!$winnerPoints) $winnerPoints = 1; //when result is 0:0

        Yii::app()->redis->getClient()->zIncrBy('board_c:'.date('Ym'), $winnerPoints, $ch[$winnerTag]);

        $winnerMsg .= "A klub <b> {$winnerPoints} pontot </b> erősödött a ranglistán.";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);

        //report
        $forum->id = $ch[$winnerTag];

        $forum->save($winnerMsg, true);
        $forum->id = $ch[$looserTag];

        $forum->save($looserMsg, true);

        //refresh the winner state of the challenge
        $winner = $winnerTag=='caller' ? 1 : 2;
        Yii::app()->db->createCommand()
            ->update('challenge', ['winner'=>$winner], 'id=:id', [':id'=>$id]);

        return true;
    }

    private function deleteCommand($id) {
        Yii::app()->db->createCommand()
            ->delete('command_stack', 'id=:id', [':id'=>(int)$id]);
    }
}



heal25 / ced

MaintenanceChallenge::endChallenge() D last analyzed 2016-09-14 21:49 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Logical Operators are used for Control-Flow

Duplication Side-by-Side

Filter issues like

MaintenanceChallenge::endChallenge() D
last analyzed 2016-09-14 21:49 UTC