MaintenanceChallenge

Complexity

Total Complexity

21

Size/Duplication

Total Lines	140
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	attributeNames()	0	3	1
A	fetchFinishable()	0	11	2
A	process()	0	11	4
D	endChallenge()	0	102	13
A	deleteCommand()	0	4	1

<?php
class MaintenanceChallenge extends CModel
{
    private $_finishable = [];

    public function attributeNames() {
        return [];
    }

    public function fetchFinishable() {
        $res = Yii::app()->db->createCommand()
            ->select('*')
            ->from('command_stack')
            ->where('process_time <= NOW()')
            ->queryAll();
        foreach ($res as $d) {
            $d['params'] = CJSON::decode($d['params']);

Equals sign not aligned with surrounding assignments; expected 17 spaces but found 1 space

            $this->_finishable[$d['id']] = $d;
        }
    }

    public function process() {
        if (!count($this->_finishable)) return false;

        foreach ($this->_finishable as $cmd) {
            $command = $cmd['command'];
            if (method_exists('MaintenanceChallenge', $command)) {
                $this->$command($cmd['params']);
                $this->deleteCommand($cmd['id']);
            }
        }
    }

    private function endChallenge($params) {
        $id = (int)$params['id'];


        $ch = Yii::app()->db->createCommand()
            ->select('*')
            ->from('challenge')
            ->where('id=:id', [':id'=>$id])
            ->queryRow();

        if ($ch['winner']) return false;

        if ($ch['point_caller'] <> $ch['point_opponent']) {
            //not equal points
            $winnerTag = $ch['point_caller'] < $ch['point_opponent'] ? 'opponent' : 'caller'; //caller only lose, if she has less points, that opponent.
        } else {
            //equal points
            $winnerTag = $ch['cnt_won_caller'] < $ch['cnt_won_opponent'] ? 'opponent' : 'caller'; //caller only lose, if she has less won games, that opponent.
        }

        $looserTag = $winnerTag == 'caller' ? 'opponent' : 'caller';

        $forum = new Forum;

        //without games
        if (!$ch['cnt_won_caller'] and !$ch['cnt_won_opponent']) {

Using logical operators such as and instead of && is generally not recommended.

            //close unplayed challenge, no winners
            $msg = "{$ch['name_caller']} - {$ch['name_opponent']}: ez a verseny párbajok nélkül ért véget, így jutalmat sem kaptok.";

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

As per coding-style, please use concatenation or sprintf for the variable $ch instead of interpolation.

            $forum->id = $ch['caller'];

The property id cannot be accessed from this context as it is declared private in class Forum.

            $forum->save($msg, true);
            $forum->id = $ch['opponent'];

The property id cannot be accessed from this context as it is declared private in class Forum.

            $forum->save($msg, true);

            //update the winner-state
            Yii::app()->db->createCommand()
                ->update('challenge', ['winner'=>3], 'id=:id', [':id'=>$id]);
            return false;
        }

        $forum->id = $ch[$winnerTag];

The property id cannot be accessed from this context as it is declared private in class Forum.

        $club = new Club;

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

        $club->id = $ch[$winnerTag]; //winner club

The property id cannot be accessed from this context as it is declared private in class Club.

        $club->fetch();
        $club->fetchMembers();


        $winnerMsg = "Gratulálok! :) Győztetek a következő versenyben: <b> {$ch['name_caller']} - {$ch['name_opponent']}</b>. ";

As per coding-style, please use concatenation or sprintf for the variable $ch instead of interpolation.

        $looserMsg = "Sajnos elbuktátok a következő versenyt: <b> {$ch['name_caller']} - {$ch['name_opponent']}</b>. ";

As per coding-style, please use concatenation or sprintf for the variable $ch instead of interpolation.

        //distribute the loot
        $members = [$club->owner=>$club->ownerName];

The property owner cannot be accessed from this context as it is declared private in class Club.

The property ownerName cannot be accessed from this context as it is declared private in class Club.

        foreach ($club->members as $member) {

The property members cannot be accessed from this context as it is declared private in class Club.

            $members[$member['uid']] = $member['user'];
        }
        $cntMembers = count($members);

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

        $loot = (int)$ch['loot_'.$winnerTag];

Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space

        $lootPerMember = floor($loot / $cntMembers);

        $forum->id = $ch[$winnerTag];

The property id cannot be accessed from this context as it is declared private in class Forum.

        if ($lootPerMember > 0) {
            $winnerMsg .= "Minden tag <b> {$lootPerMember}$</b>-t kap a zsákmányból. Név szerint: ";

As per coding-style, please use concatenation or sprintf for the variable $lootPerMember instead of interpolation.

            $contest = new Contest;

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

            $listPlayers = [];
            $p = new Player;

Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space

            foreach ($members as $uid => $member) {
                $p->setAllAttributes($uid);
                $incr = ['dollar'=>$lootPerMember];
                $p->updateAttributes($incr, []);
                $contest->addPoints($p->uid, Contest::ACT_DUEL, 0, 0, $incr['dollar']);

The property uid cannot be accessed from this context as it is declared private in class Player.

                $listPlayers[] = $p->user;

The property user cannot be accessed from this context as it is declared private in class Player.

            }
            $winnerMsg .= join(', ', $listPlayers) . '. ';
        } else {
            $winnerMsg .= "Sajnos a zsákmány ({$loot}$) túl alacsony ahhoz, hogy osztozzatok rajta. ";

As per coding-style, please use concatenation or sprintf for the variable $loot instead of interpolation.

        }
        $lootLosers = (int)$ch['loot_'.$looserTag];
        $looserMsg .= "Mivel nem nyertetek, a zsákmány ({$lootLosers}$) a horgásszövetség tulajdonába kerül. Köszönik szépen!";

As per coding-style, please use concatenation or sprintf for the variable $lootLosers instead of interpolation.

        //refresh the toplist
        $winnerPoints = (int)$ch['point_'.$winnerTag];

Equals sign not aligned with surrounding assignments; expected 21 spaces but found 1 space

        if (!$winnerPoints) $winnerPoints = 1; //when result is 0:0

        Yii::app()->redis->getClient()->zIncrBy('board_c:'.date('Ym'), $winnerPoints, $ch[$winnerTag]);

        $winnerMsg .= "A klub <b> {$winnerPoints} pontot </b> erősödött a ranglistán.";

As per coding-style, please use concatenation or sprintf for the variable $winnerPoints instead of interpolation.

        //report
        $forum->id = $ch[$winnerTag];

The property id cannot be accessed from this context as it is declared private in class Forum.

        $forum->save($winnerMsg, true);
        $forum->id = $ch[$looserTag];

The property id cannot be accessed from this context as it is declared private in class Forum.

        $forum->save($looserMsg, true);

        //refresh the winner state of the challenge
        $winner = $winnerTag=='caller' ? 1 : 2;
        Yii::app()->db->createCommand()
            ->update('challenge', ['winner'=>$winner], 'id=:id', [':id'=>$id]);

        return true;
    }

    private function deleteCommand($id) {
        Yii::app()->db->createCommand()
            ->delete('command_stack', 'id=:id', [':id'=>(int)$id]);
    }
}

As per coding style, files should not end with a newline character.