LocationAction

Complexity

Total Complexity

28

Size/Duplication

Total Lines	173
Duplicated Lines	2.89 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	attributeNames()	0	4	1
A	setLocation()	0	4	1
A	getCompletedId()	0	4	1
B	getReduction()	0	26	6
B	completeMission()	0	25	6
A	allMissionRoutinesAreFull()	5	9	4
B	incrementRoutine()	0	26	2
A	addAwardForRoutine()	0	10	3
A	addAward()	0	17	1
B	visitNewLocation()	0	28	3

<?php
/*
 * @property integer $completedId
 */
class LocationAction extends CModel
{
    private $location;
    private $completedId = 0;

    public function attributeNames()
    {
        return [];
    }

    public function setLocation($location)
    {
        $this->location = $location;
    }

    public function getCompletedId()
    {
        return $this->completedId;
    }

    private function getReduction()
    {
        $reduction = 0;

        if ($this->location->routine >= 3) {

The property routine cannot be accessed from this context as it is declared private in class Location.

            $reduction = 1; // silver
        }

        if ($this->location->routine >= 9) {

The property routine cannot be accessed from this context as it is declared private in class Location.

            $reduction = 2; // gold
        }

        if ($this->location->routine >= 27) {

The property routine cannot be accessed from this context as it is declared private in class Location.

            $reduction = 3; // emerald
        }

        if ($this->location->routine >= 81) {

The property routine cannot be accessed from this context as it is declared private in class Location.

            $reduction = 4; // diamant
        }

        if ($this->location->routine >= 243) {

The property routine cannot be accessed from this context as it is declared private in class Location.

            $reduction = 5; // 3 diamants
        }

        return $reduction;
    }

    public function completeMission($id)
    {
        if (!isset($this->location->missions[$id])) {

The property missions cannot be accessed from this context as it is declared private in class Location.

            return false;
        }

        //max routine
        if ($this->location->routine >= 243) {

The property routine cannot be accessed from this context as it is declared private in class Location.

            Yii::app()->user->setFlash('info', 'Ezen a helyszínen már elérted a legnagyobb helyszínrutint, így nem teljesítheted a megbízást.');
            return false; //max routine reached
        }

        $this->completedId = $id;
        $m = $this->location->missions[$id];

The property missions cannot be accessed from this context as it is declared private in class Location.

Equals sign not aligned with surrounding assignments; expected 17 spaces but found 1 space

        if ($m->gate) {
            $m->locationRoutinesFull = $this->allMissionRoutinesAreFull();
        }

        $m->routine_reduction = $this->getReduction();
        $m->complete();
        if ($m->gate && $m->action->success) {
            $this->incrementRoutine();
            $this->visitNewLocation($m);
        }
    }

    private function allMissionRoutinesAreFull()
    {
        foreach ($this->location->missions as $mission) {

The property missions cannot be accessed from this context as it is declared private in class Location.

This code seems to be duplicated across your project.

            if (!$mission->gate && $mission->routine < 100) {
                return false;
            }
        }
        return true;
    }

    private function incrementRoutine()
    {
        $uid = Yii::app()->player->model->uid;

        //increment location routine
        Yii::app()->db
            ->createCommand("UPDATE visited SET routine=routine+1 WHERE uid=:uid AND water_id=:water_id")

The string literal UPDATE visited SET routine=routine+1 WHERE uid=:uid AND water_id=:water_id does not require double quotes, as per coding-style, please use single quotes.

            ->bindValues([':uid'=>$uid, ':water_id'=>$this->location->id])

The property id cannot be accessed from this context as it is declared private in class Location.

            ->execute();

        //reset all missions routine on this location
        Yii::app()->db
            ->createCommand("UPDATE users_missions SET routine=0 WHERE uid=:uid AND water_id=:water_id")

The string literal UPDATE users_missions SET routine=0 WHERE uid=:uid AND water_id=:water_id does not require double quotes, as per coding-style, please use single quotes.

            ->bindValues([':uid'=>$uid, ':water_id'=>$this->location->id])

The property id cannot be accessed from this context as it is declared private in class Location.

            ->execute();

        //refresh objects
        foreach ($this->location->missions as $mission) {

The property missions cannot be accessed from this context as it is declared private in class Location.

            $mission->routine = 0;
        }
        $this->location->incrementRoutine();
        Yii::app()->badge->model->triggerLocationRoutine($this->location->id, $this->location->routine);

The property id cannot be accessed from this context as it is declared private in class Location.

The property routine cannot be accessed from this context as it is declared private in class Location.

        //add routine awards
        $this->addAwardForRoutine();
    }

    private function addAwardForRoutine()
    {
        if ($this->location->routine == 9) { //gold

The property routine cannot be accessed from this context as it is declared private in class Location.

            $this->addAward(1, Yii::app()->params['routineAwardForGold'], 'az arany');
        }

        if ($this->location->routine == 81) { //diamant

The property routine cannot be accessed from this context as it is declared private in class Location.

            $this->addAward(1, Yii::app()->params['routineAwardForDiamant'], 'a gyémánt');
        }
    }

    /**
     * @param integer $sp
     * @param integer $gold
     * @param string $title
     */
    private function addAward($sp, $gold, $title)
    {
        $player = Yii::app()->player->model;

        $logger = new Logger;

Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space

        $logger->key = 'routineAward:'.$player->uid;

The property key cannot be accessed from this context as it is declared private in class Logger.

        $logger->addToSet('----start: '.date('Y.m.d. H:i:s').'----');
        $logger->addToSet('id: ' . $this->location->id . ', routine: ' . $this->location->routine);

The property id cannot be accessed from this context as it is declared private in class Location.

The property routine cannot be accessed from this context as it is declared private in class Location.

        $logger->addToSet('before: ' . $player->status_points . 'sp, ' . $player->gold . 'gold');

        $player->updateAttributes(['status_points'=>$sp, 'gold'=>$gold], []);
        Yii::app()->user->setFlash('info', "Gratulálok, elérted <strong> {$title} </strong> helyszínrutint!<br/>Jutalmad: {$sp} státuszpont és {$gold} arany.");

As per coding-style, please use concatenation or sprintf for the variable $title instead of interpolation.

As per coding-style, please use concatenation or sprintf for the variable $sp instead of interpolation.

As per coding-style, please use concatenation or sprintf for the variable $gold instead of interpolation.

        $logger->addToSet('after: ' . $player->status_points . 'sp, ' . $player->gold . 'gold');

        Yii::app()->gameLogger->log(['type'=>'routine_award', 'water_id'=>$this->location->id, 'routine'=>$this->location->routine]);

The property id cannot be accessed from this context as it is declared private in class Location.

The property routine cannot be accessed from this context as it is declared private in class Location.

    }

    private function visitNewLocation($mission)
    {
        if ($mission->gate_visited) {
            return false; //do not open the same location twice
        }

        $player = Yii::app()->player->model;
        $gate = (int)$mission->gate;

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

        $location = Yii::app()->db->createCommand()
            ->select('uid, water_id')
            ->from('visited')
            ->where('uid=:uid AND water_id=:water_id', [':uid'=>$player->uid, ':water_id'=>$gate])
            ->queryScalar();

        if (!$location) {
            Yii::app()->db->createCommand()
                ->insert('visited', [
                'uid'=>$player->uid,
                'water_id'=>$gate,
                'skill_extended_at_visit'=>(int)$player->skill_extended,
                ]);
        }
        $mission->action->gained_visit = true;
        Yii::app()->gameLogger->log(['type'=>'travel', 'traveled_to'=>$gate]);

        Yii::app()->badge->model->triggerTravel($gate);
    }
}

As per coding style, files should not end with a newline character.