hborras / twitter-php-ads-sdk

autoload.php

Spacing +3 added lines, -3 removed lines

@@ -6,13 +6,13 @@ 
  * @param string $class The fully-qualified class name.
  * @return void
  */
-spl_autoload_register(function ($class) {
+spl_autoload_register(function($class) {
 
     // project-specific namespace prefix
     $prefix = 'Hborras\\TwitterAdsSDK\\';
 
     // base directory for the namespace prefix
-    $base_dir = __DIR__ . '/src/';
+    $base_dir = __DIR__.'/src/';
 
     // does the class use the namespace prefix?
     $len = strlen($prefix);
@@ -27,7 +27,7 @@ 
     // replace the namespace prefix with the base directory, replace namespace
     // separators with directory separators in the relative class name, append
     // with .php
-    $file = $base_dir . str_replace('\\', '/', $relative_class) . '.php';
+    $file = $base_dir.str_replace('\\', '/', $relative_class).'.php';
 
     // if the file exists, require it
     if (file_exists($file)) {

src/TONUpload.php

Doc Comments +6 added lines

@@ -90,6 +90,12 @@
         return $response;
     }
 
+    /**
+     * @param integer $chunkSize
+     * @param string $bytes
+     * @param integer $bytesStart
+     * @param integer $bytesRead
+     */
     public function uploadChunk($resource, $chunkSize, $bytes, $bytesStart, $bytesRead)
     {
         $headers = [

Spacing +13 added lines, -13 removed lines

@@ -81,22 +81,22 @@ 
     {
         /** Here you can add any header you want to the request*/
         $headers = [
-            'x-ton-expires: ' . gmdate('D, d M Y H:i:s T', strtotime("+10 day")),
-            'content-type: ' . $this->getContentType(),
-            'Content-Length: ' . $this->fileSize
+            'x-ton-expires: '.gmdate('D, d M Y H:i:s T', strtotime("+10 day")),
+            'content-type: '.$this->getContentType(),
+            'Content-Length: '.$this->fileSize
         ];
 
-        $response = $this->getTwitterAds()->post(self::DEFAULT_DOMAIN . self::DEFAULT_RESOURCE . self::DEFAULT_BUCKET, ['raw' => file_get_contents($this->filePath)], $headers);
+        $response = $this->getTwitterAds()->post(self::DEFAULT_DOMAIN.self::DEFAULT_RESOURCE.self::DEFAULT_BUCKET, ['raw' => file_get_contents($this->filePath)], $headers);
         return $response;
     }
 
     public function uploadChunk($resource, $chunkSize, $bytes, $bytesStart, $bytesRead)
     {
         $headers = [
-            'Content-Type: ' . $this->getContentType(),
-            'Content-Range: bytes ' . $bytesStart . '-' . ($bytesRead - 1) . '/' . $this->fileSize
+            'Content-Type: '.$this->getContentType(),
+            'Content-Range: bytes '.$bytesStart.'-'.($bytesRead - 1).'/'.$this->fileSize
         ];
-        $response = $this->getTwitterAds()->put(self::DEFAULT_DOMAIN . $resource, ['raw' => $bytes], $headers);
+        $response = $this->getTwitterAds()->put(self::DEFAULT_DOMAIN.$resource, ['raw' => $bytes], $headers);
 
         return $response;
     }
@@ -104,14 +104,14 @@ 
     public function initChunkedUpload()
     {
         $headers = [
-            'X-Ton-Content-Type: ' . $this->getContentType(),
-            'X-Ton-Content-Length: ' . $this->fileSize,
-            'X-Ton-Expires: ' . gmdate('D, d M Y H:i:s T', strtotime("+6 day")),
-            'Content-Type: ' . $this->getContentType(),
-            'Content-Length: ' . strval(0)
+            'X-Ton-Content-Type: '.$this->getContentType(),
+            'X-Ton-Content-Length: '.$this->fileSize,
+            'X-Ton-Expires: '.gmdate('D, d M Y H:i:s T', strtotime("+6 day")),
+            'Content-Type: '.$this->getContentType(),
+            'Content-Length: '.strval(0)
         ];
 
-        $resource = self::DEFAULT_DOMAIN . self::DEFAULT_RESOURCE . self::DEFAULT_BUCKET . '?resumable=true';
+        $resource = self::DEFAULT_DOMAIN.self::DEFAULT_RESOURCE.self::DEFAULT_BUCKET.'?resumable=true';
         $response = $this->getTwitterAds()->post($resource, [], $headers);
         return $response;
     }

examples/chunked_upload.php

Unused Use Statements -5 removed lines

@@ -2,12 +2,7 @@
 
 use Hborras\TwitterAdsSDK\TwitterAds;
 use Hborras\TwitterAdsSDK\TwitterAds\Account;
-use Hborras\TwitterAdsSDK\TwitterAds\Campaign\Campaign;
-use Hborras\TwitterAdsSDK\TwitterAds\Campaign\LineItem;
 use Hborras\TwitterAdsSDK\TwitterAds\Campaign\Tweet;
-use Hborras\TwitterAdsSDK\TwitterAds\Creative\PromotedTweet;
-use Hborras\TwitterAdsSDK\TwitterAds\Creative\WebsiteCard;
-use Hborras\TwitterAdsSDK\TwitterAds\Enumerations;
 
 require '../autoload.php';
 

Spacing +1 added lines, -1 removed lines

@@ -26,4 +26,4 @@
 
 // create request for a simple nullcasted tweet
 $media = $twitterAds->upload(['media' => 'twitter-gif.gif', 'media_type' => 'image/gif'], true);
-$tweet = Tweet::create($account, 'Tweet with chunked upload GIF...' . rand() . ' http://twitter.com', ['media_ids' => $media->media_id]);
\ No newline at end of file
+$tweet = Tweet::create($account, 'Tweet with chunked upload GIF...'.rand().' http://twitter.com', ['media_ids' => $media->media_id]);
\ No newline at end of file

examples/video_upload.php

Unused Use Statements -6 removed lines

@@ -2,13 +2,7 @@
 
 use Hborras\TwitterAdsSDK\TwitterAds;
 use Hborras\TwitterAdsSDK\TwitterAds\Account;
-use Hborras\TwitterAdsSDK\TwitterAds\Campaign\Campaign;
-use Hborras\TwitterAdsSDK\TwitterAds\Campaign\LineItem;
-use Hborras\TwitterAdsSDK\TwitterAds\Campaign\Tweet;
-use Hborras\TwitterAdsSDK\TwitterAds\Creative\PromotedTweet;
 use Hborras\TwitterAdsSDK\TwitterAds\Creative\Video;
-use Hborras\TwitterAdsSDK\TwitterAds\Creative\WebsiteCard;
-use Hborras\TwitterAdsSDK\TwitterAds\Enumerations;
 
 require '../autoload.php';
 

Spacing +2 added lines, -2 removed lines

@@ -30,7 +30,7 @@
 
 /** Create a video entity and save it*/
 $video = new Video($account);
-$video->setTitle("Test Video " . rand());
-$video->setDescription("Description" . rand());
+$video->setTitle("Test Video ".rand());
+$video->setDescription("Description".rand());
 $video->setVideoMediaId($media->media_id);
 $video->save();

src/TwitterAds/TailoredAudience/TailoredAudience.php

Doc Comments +2 added lines, -2 removed lines

@@ -148,7 +148,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getListType()
     {
@@ -212,7 +212,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public static function getTypes()
     {

src/TwitterAds/TailoredAudience/TailoredAudiencePermission.php

Unused Use Statements -3 removed lines

@@ -2,12 +2,9 @@
 
 namespace Hborras\TwitterAdsSDK\TwitterAds\TailoredAudience;
 
-use Hborras\TwitterAdsSDK\TONUpload;
 use Hborras\TwitterAdsSDK\TwitterAds;
-use Hborras\TwitterAdsSDK\TwitterAds\Account;
 use Hborras\TwitterAdsSDK\TwitterAds\Cursor;
 use Hborras\TwitterAdsSDK\TwitterAds\Resource;
-use Hborras\TwitterAdsSDK\TwitterAds\TailoredAudience\Exception\InvalidType;
 
 final class TailoredAudiencePermission extends Resource
 {

src/TwitterAds.php

Doc Comments +5 added lines, -1 removed lines

@@ -250,7 +250,7 @@ 
      * @param string $path
      * @param array $parameters
      *
-     * @param array $headers
+     * @param string[] $headers
      * @return Response
      */
     public function post($path, array $parameters = [], array $headers = [])
@@ -648,6 +648,10 @@ 
     // This function takes a input like a=b&a=c&d=e and returns the parsed
     // parameters like this
     // array('a' => array('b','c'), 'd' => 'e')
+
+    /**
+     * @param string $input
+     */
     public static function parse_parameters($input)
     {
         if (!isset($input) || !$input) {

Spacing +7 added lines, -7 removed lines

@@ -226,7 +226,7 @@ 
         $this->response->setApiPath($path);
         $url = sprintf('%s/%s', self::API_HOST_OAUTH, $path);
         $request = Request::fromConsumerAndToken($this->consumer, $this->token, $method, $url, $parameters);
-        $authorization = 'Authorization: Basic ' . $this->encodeAppAuthorization($this->consumer);
+        $authorization = 'Authorization: Basic '.$this->encodeAppAuthorization($this->consumer);
         $result = $this->request($request->getNormalizedHttpUrl(), $method, $authorization, $parameters);
         $response = JsonDecoder::decode($result, $this->decodeJsonAsArray);
         $this->response->setBody($response);
@@ -495,7 +495,7 @@ 
             $request->signRequest($this->signatureMethod, $this->consumer, $this->token);
             $authorization = $request->toHeader();
         } else {
-            $authorization = 'Authorization: Bearer ' . $this->bearer;
+            $authorization = 'Authorization: Bearer '.$this->bearer;
         }
         if (strpos($url, TONUpload::DEFAULT_DOMAIN) === 0) {
             return $this->request($url, $method, $authorization, $parameters, $headers);
@@ -522,7 +522,7 @@ 
         /* Curl settings */
         $options = [
             CURLOPT_VERBOSE => false,
-            CURLOPT_CAINFO => __DIR__ . DIRECTORY_SEPARATOR . 'cacert.pem',
+            CURLOPT_CAINFO => __DIR__.DIRECTORY_SEPARATOR.'cacert.pem',
             CURLOPT_CONNECTTIMEOUT => $this->connectionTimeout,
             CURLOPT_HEADER => true,
             CURLOPT_HTTPHEADER => array_merge(['Accept: */*', $authorization, 'Expect:'], $headers, ['Connection: close']),
@@ -567,7 +567,7 @@ 
         }
 
         if (in_array($method, ['GET', 'PUT', 'DELETE']) && !empty($postfields) && !isset($postfields['raw'])) {
-            $options[CURLOPT_URL] .= '?' . Util::buildHttpQuery($postfields);
+            $options[CURLOPT_URL] .= '?'.Util::buildHttpQuery($postfields);
         }
 
         $curlHandle = curl_init();
@@ -643,7 +643,7 @@ 
         $key = $consumer->key;
         $secret = $consumer->secret;
 
-        return base64_encode($key . ':' . $secret);
+        return base64_encode($key.':'.$secret);
     }
 
     /**
@@ -790,9 +790,9 @@ 
             $token = $token['oauth_token'];
         }
         if (empty($sign_in_with_twitter)) {
-            return $this->authorizeURL() . "?oauth_token={$token}";
+            return $this->authorizeURL()."?oauth_token={$token}";
         } else {
-            return $this->authenticateURL() . "?oauth_token={$token}";
+            return $this->authenticateURL()."?oauth_token={$token}";
         }
     }
 }

examples/jobs.php

Unused Use Statements -5 removed lines

@@ -2,11 +2,6 @@
 
 use Hborras\TwitterAdsSDK\TwitterAds;
 use Hborras\TwitterAdsSDK\TwitterAds\Account;
-use Hborras\TwitterAdsSDK\TwitterAds\Analytics;
-use Hborras\TwitterAdsSDK\TwitterAds\Campaign\Campaign;
-use Hborras\TwitterAdsSDK\TwitterAds\Campaign\LineItem;
-use Hborras\TwitterAdsSDK\TwitterAds\Enumerations;
-use Hborras\TwitterAdsSDK\TwitterAds\Fields\AnalyticsFields;
 
 require '../autoload.php';
 

src/TwitterAds/Batch.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Hborras\TwitterAdsSDK\TwitterAds;
 use Hborras\TwitterAdsSDK\TwitterAds\Resource;
-use Hborras\TwitterAdsSDK\TwitterAds\Account;
 use Hborras\TwitterAdsSDK\Arrayable;
 use Hborras\TwitterAdsSDK\TwitterAds\Errors\BatchLimitExceeded;