hborras / twitter-php-ads-sdk

autoload.php

Spacing +3 added lines, -3 removed lines

@@ -6,13 +6,13 @@ 
  * @param string $class The fully-qualified class name.
  * @return void
  */
-spl_autoload_register(function ($class) {
+spl_autoload_register(function($class) {
 
     // project-specific namespace prefix
     $prefix = 'Hborras\\TwitterAdsSDK\\';
 
     // base directory for the namespace prefix
-    $base_dir = __DIR__ . '/src/';
+    $base_dir = __DIR__.'/src/';
 
     // does the class use the namespace prefix?
     $len = strlen($prefix);
@@ -27,7 +27,7 @@ 
     // replace the namespace prefix with the base directory, replace namespace
     // separators with directory separators in the relative class name, append
     // with .php
-    $file = $base_dir . str_replace('\\', '/', $relative_class) . '.php';
+    $file = $base_dir.str_replace('\\', '/', $relative_class).'.php';
 
     // if the file exists, require it
     if (file_exists($file)) {

src/TONUpload.php

Doc Comments +6 added lines

@@ -90,6 +90,12 @@
         return $response;
     }
 
+    /**
+     * @param integer $chunkSize
+     * @param string $bytes
+     * @param integer $bytesStart
+     * @param integer $bytesRead
+     */
     public function uploadChunk($resource, $chunkSize, $bytes, $bytesStart, $bytesRead)
     {
         $headers = [

Spacing +13 added lines, -13 removed lines

@@ -81,22 +81,22 @@ 
     {
         /** Here you can add any header you want to the request*/
         $headers = [
-            'x-ton-expires: ' . gmdate('D, d M Y H:i:s T', strtotime("+10 day")),
-            'content-type: ' . $this->getContentType(),
-            'Content-Length: ' . $this->fileSize
+            'x-ton-expires: '.gmdate('D, d M Y H:i:s T', strtotime("+10 day")),
+            'content-type: '.$this->getContentType(),
+            'Content-Length: '.$this->fileSize
         ];
 
-        $response = $this->getTwitterAds()->post(self::DEFAULT_DOMAIN . self::DEFAULT_RESOURCE . self::DEFAULT_BUCKET, ['raw' => file_get_contents($this->filePath)], $headers);
+        $response = $this->getTwitterAds()->post(self::DEFAULT_DOMAIN.self::DEFAULT_RESOURCE.self::DEFAULT_BUCKET, ['raw' => file_get_contents($this->filePath)], $headers);
         return $response;
     }
 
     public function uploadChunk($resource, $chunkSize, $bytes, $bytesStart, $bytesRead)
     {
         $headers = [
-            'Content-Type: ' . $this->getContentType(),
-            'Content-Range: bytes ' . $bytesStart . '-' . ($bytesRead - 1) . '/' . $this->fileSize
+            'Content-Type: '.$this->getContentType(),
+            'Content-Range: bytes '.$bytesStart.'-'.($bytesRead - 1).'/'.$this->fileSize
         ];
-        $response = $this->getTwitterAds()->put(self::DEFAULT_DOMAIN . $resource, ['raw' => $bytes], $headers);
+        $response = $this->getTwitterAds()->put(self::DEFAULT_DOMAIN.$resource, ['raw' => $bytes], $headers);
 
         return $response;
     }
@@ -104,14 +104,14 @@ 
     public function initChunkedUpload()
     {
         $headers = [
-            'X-Ton-Content-Type: ' . $this->getContentType(),
-            'X-Ton-Content-Length: ' . $this->fileSize,
-            'X-Ton-Expires: ' . gmdate('D, d M Y H:i:s T', strtotime("+6 day")),
-            'Content-Type: ' . $this->getContentType(),
-            'Content-Length: ' . strval(0)
+            'X-Ton-Content-Type: '.$this->getContentType(),
+            'X-Ton-Content-Length: '.$this->fileSize,
+            'X-Ton-Expires: '.gmdate('D, d M Y H:i:s T', strtotime("+6 day")),
+            'Content-Type: '.$this->getContentType(),
+            'Content-Length: '.strval(0)
         ];
 
-        $resource = self::DEFAULT_DOMAIN . self::DEFAULT_RESOURCE . self::DEFAULT_BUCKET . '?resumable=true';
+        $resource = self::DEFAULT_DOMAIN.self::DEFAULT_RESOURCE.self::DEFAULT_BUCKET.'?resumable=true';
         $response = $this->getTwitterAds()->post($resource, [], $headers);
         return $response;
     }

src/TwitterAds.php

Doc Comments +5 added lines, -1 removed lines

@@ -250,7 +250,7 @@ 
      * @param string $path
      * @param array $parameters
      *
-     * @param array $headers
+     * @param string[] $headers
      * @return Response
      */
     public function post($path, array $parameters = [], array $headers = [])
@@ -648,6 +648,10 @@ 
     // This function takes a input like a=b&a=c&d=e and returns the parsed
     // parameters like this
     // array('a' => array('b','c'), 'd' => 'e')
+
+    /**
+     * @param string $input
+     */
     public static function parse_parameters($input)
     {
         if (!isset($input) || !$input) {

Spacing +11 added lines, -11 removed lines

@@ -225,7 +225,7 @@ 
         $this->response->setApiPath($path);
         $url = sprintf('%s/%s', self::API_HOST_OAUTH, $path);
         $request = Request::fromConsumerAndToken($this->consumer, $this->token, $method, $url, $parameters);
-        $authorization = 'Authorization: Basic ' . $this->encodeAppAuthorization($this->consumer);
+        $authorization = 'Authorization: Basic '.$this->encodeAppAuthorization($this->consumer);
         $result = $this->request($request->getNormalizedHttpUrl(), $method, $authorization, $parameters);
         $response = JsonDecoder::decode($result, $this->decodeJsonAsArray);
         $this->response->setBody($response);
@@ -461,9 +461,9 @@ 
     public function manageErrors($response)
     {
         $errors = [];
-        if(isset($response->errors)){
+        if (isset($response->errors)) {
             $errors = $response->errors;
-        } else if(isset($response->operation_errors)){
+        } else if (isset($response->operation_errors)) {
             $errors = $response->operation_errors;
         }
 
@@ -509,7 +509,7 @@ 
             $request->signRequest($this->signatureMethod, $this->consumer, $this->token);
             $authorization = $request->toHeader();
         } else {
-            $authorization = 'Authorization: Bearer ' . $this->bearer;
+            $authorization = 'Authorization: Bearer '.$this->bearer;
         }
         if (strpos($url, TONUpload::DEFAULT_DOMAIN) === 0) {
             return $this->request($url, $method, $authorization, $parameters, $headers);
@@ -535,7 +535,7 @@ 
         /* Curl settings */
         $options = [
             CURLOPT_VERBOSE => false,
-            CURLOPT_CAINFO => __DIR__ . DIRECTORY_SEPARATOR . 'cacert.pem',
+            CURLOPT_CAINFO => __DIR__.DIRECTORY_SEPARATOR.'cacert.pem',
             CURLOPT_CONNECTTIMEOUT => $this->connectionTimeout,
             CURLOPT_HEADER => true,
             CURLOPT_HTTPHEADER => array_merge(['Accept: */*', $authorization, 'Expect:'], $headers, ['Connection: close']),
@@ -582,7 +582,7 @@ 
         }
 
         if (in_array($method, ['GET', 'PUT', 'DELETE']) && !empty($postfields) && !isset($postfields['raw'])) {
-            $options[CURLOPT_URL] .= '?' . Util::buildHttpQuery($postfields);
+            $options[CURLOPT_URL] .= '?'.Util::buildHttpQuery($postfields);
         }
 
         $curlHandle = curl_init();
@@ -658,7 +658,7 @@ 
         $key = $consumer->key;
         $secret = $consumer->secret;
 
-        return base64_encode($key . ':' . $secret);
+        return base64_encode($key.':'.$secret);
     }
 
     /**
@@ -692,7 +692,7 @@ 
      */
     public function getAccountId()
     {
-        if(!$this->account instanceof Account){
+        if (!$this->account instanceof Account) {
             return '';
         }
         return $this->account->getId();
@@ -703,7 +703,7 @@ 
      */
     public function getAccountTimezone()
     {
-        if(!$this->account instanceof Account){
+        if (!$this->account instanceof Account) {
             return 'UTC';
         }
         return $this->account->getTimezone();
@@ -819,9 +819,9 @@ 
             $token = $token['oauth_token'];
         }
         if (empty($sign_in_with_twitter)) {
-            return $this->authorizeURL() . "?oauth_token={$token}";
+            return $this->authorizeURL()."?oauth_token={$token}";
         } else {
-            return $this->authenticateURL() . "?oauth_token={$token}";
+            return $this->authenticateURL()."?oauth_token={$token}";
         }
     }
 }

src/TwitterAds/Batch.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Hborras\TwitterAdsSDK\TwitterAds;
 use Hborras\TwitterAdsSDK\TwitterAds\Resource;
-use Hborras\TwitterAdsSDK\TwitterAds\Account;
 use Hborras\TwitterAdsSDK\Arrayable;
 use Hborras\TwitterAdsSDK\TwitterAds\Errors\BatchLimitExceeded;
 

src/TwitterAds/Cursor.php

Doc Comments +1 added lines, -1 removed lines

@@ -217,7 +217,7 @@
     /**
      * Return the key of the current element
      * @link http://php.net/manual/en/iterator.key.php
-     * @return mixed scalar on success, or null on failure.
+     * @return integer scalar on success, or null on failure.
      * @since 5.0.0
      */
     public function key()

src/Util.php

Spacing +3 added lines, -3 removed lines

@@ -16,7 +16,7 @@ 
     {
         $output = '';
         if (is_array($input)) {
-            $output = array_map([__NAMESPACE__ . '\Util', 'urlencodeRfc3986'], $input);
+            $output = array_map([__NAMESPACE__.'\Util', 'urlencodeRfc3986'], $input);
         } elseif (is_scalar($input)) {
             $output = rawurlencode($input);
         }
@@ -104,10 +104,10 @@ 
                 // June 12th, 2010 - changed to sort because of issue 164 by hidetaka
                 sort($value, SORT_STRING);
                 foreach ($value as $duplicateValue) {
-                    $pairs[] = $parameter . '=' . $duplicateValue;
+                    $pairs[] = $parameter.'='.$duplicateValue;
                 }
             } else {
-                $pairs[] = $parameter . '=' . $value;
+                $pairs[] = $parameter.'='.$value;
             }
         }
         // For each parameter, the name is separated from the corresponding value by an '=' character (ASCII code 61)

src/Config.php

Spacing +4 added lines, -4 removed lines

@@ -34,8 +34,8 @@ 
      */
     public function setTimeouts($connectionTimeout, $timeout)
     {
-        $this->connectionTimeout = (int)$connectionTimeout;
-        $this->timeout = (int)$timeout;
+        $this->connectionTimeout = (int) $connectionTimeout;
+        $this->timeout = (int) $timeout;
     }
 
     /**
@@ -43,7 +43,7 @@ 
      */
     public function setDecodeJsonAsArray($value)
     {
-        $this->decodeJsonAsArray = (bool)$value;
+        $this->decodeJsonAsArray = (bool) $value;
     }
 
     /**
@@ -51,7 +51,7 @@ 
      */
     public function setUserAgent($userAgent)
     {
-        $this->userAgent = (string)$userAgent;
+        $this->userAgent = (string) $userAgent;
     }
 
     /**

src/TwitterAds/Analytics.php

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
     {
         $endTime = isset($params[AnalyticsFields::END_TIME]) ? $params[AnalyticsFields::END_TIME] : new \DateTime('now');
         $endTime->setTime($endTime->format('H'), 0, 0);
-        $startTime = isset($params[AnalyticsFields::START_TIME]) ? $params[AnalyticsFields::START_TIME] : new \DateTime($endTime->format('c') . " - 7 days");
+        $startTime = isset($params[AnalyticsFields::START_TIME]) ? $params[AnalyticsFields::START_TIME] : new \DateTime($endTime->format('c')." - 7 days");
         $startTime->setTime($startTime->format('H'), 0, 0);
         $granularity = isset($params[AnalyticsFields::GRANULARITY]) ? $params[AnalyticsFields::GRANULARITY] : Enumerations::GRANULARITY_TOTAL;
         $placement = isset($params[AnalyticsFields::PLACEMENT]) ? $params[AnalyticsFields::PLACEMENT] : Enumerations::PLACEMENT_ALL_ON_TWITTER;

src/Request.php

Spacing +3 added lines, -3 removed lines

@@ -178,7 +178,7 @@ 
         $postData = $this->toPostdata();
         $out = $this->getNormalizedHttpUrl();
         if ($postData) {
-            $out .= '?' . $postData;
+            $out .= '?'.$postData;
         }
 
         return $out;
@@ -213,7 +213,7 @@ 
                 throw new TwitterOAuthException('Arrays not supported in headers');
             }
             $out .= ($first) ? ' ' : ', ';
-            $out .= Util::urlencodeRfc3986($k) . '="' . Util::urlencodeRfc3986($v) . '"';
+            $out .= Util::urlencodeRfc3986($k).'="'.Util::urlencodeRfc3986($v).'"';
             $first = false;
         }
 
@@ -257,6 +257,6 @@ 
      */
     public static function generateNonce()
     {
-        return md5(microtime() . mt_rand());
+        return md5(microtime().mt_rand());
     }
 }