gyselroth / balloon

src/app/Balloon.App.Elasticsearch/Elasticsearch.php

Doc Comments +1 added lines, -1 removed lines

@@ -221,7 +221,7 @@
      * Search.
      *
      * @param array $query
-     * @param array $share
+     * @param array $shares
      *
      * @return array
      */

Spacing +9 added lines, -9 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -85,7 +85,7 @@ 
      *
      * @return Elasticsearch
      */
-    public function setOptions(?Iterable $config = null): self
+    public function setOptions(?Iterable $config = null) : self
     {
         if (null === $config) {
             return $this;
@@ -94,11 +94,11 @@ 
         foreach ($config as $option => $value) {
             switch ($option) {
                 case 'server':
-                    $this->es_server = (array) $value;
+                    $this->es_server = (array)$value;
 
                 break;
                 case 'index':
-                    $this->es_index = (string) $value;
+                    $this->es_index = (string)$value;
 
                 break;
                 default:
@@ -148,7 +148,7 @@ 
             ],
         ]);
 
-        $user = (string) $this->user->getId();
+        $user = (string)$this->user->getId();
         foreach ($result['hits']['hits'] as $node) {
             $id = false;
 
@@ -159,8 +159,8 @@ 
                     $_node = $this->fs->findNodeById($id);
                     if ($_node->isDeleted() && (1 === $deleted || 2 === $deleted)
                      || !$_node->isDeleted() && (0 === $deleted || 2 === $deleted)) {
-                        if (!($_node->isShared() && !$_node->isOwnerRequest()) && !isset($list[(string) $_node->getId()])) {
-                            $list[(string) $_node->getId()] = $_node;
+                        if (!($_node->isShared() && !$_node->isOwnerRequest()) && !isset($list[(string)$_node->getId()])) {
+                            $list[(string)$_node->getId()] = $_node;
                         }
                     }
                 } catch (\Exception $e) {
@@ -230,8 +230,8 @@ 
         $bool = $query['body']['query'];
 
         $filter1 = [];
-        $filter1['bool']['should'][]['term']['owner'] = (string) $this->user->getId();
-        $filter1['bool']['should'][]['term']['metadata.ref.owner'] = (string) $this->user->getId();
+        $filter1['bool']['should'][]['term']['owner'] = (string)$this->user->getId();
+        $filter1['bool']['should'][]['term']['metadata.ref.owner'] = (string)$this->user->getId();
 
         $share_filter = [
             'bool' => [

src/app/Balloon.App.Notification/Hook/NewShareAdded.php

Doc Comments +1 added lines, -1 removed lines

@@ -162,7 +162,7 @@
      * @param NodeInterface $node
      * @param User          $user
      *
-     * @return string
+     * @return boolean
      */
     protected function checkNotify(NodeInterface $node, User $user): bool
     {

Spacing +10 added lines, -10 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -81,7 +81,7 @@ 
      *
      * @return AbstractHook
      */
-    public function setOptions(?Iterable $config = null): AbstractHook
+    public function setOptions(?Iterable $config = null) : AbstractHook
     {
         if (null === $config) {
             return $this;
@@ -91,7 +91,7 @@ 
             switch ($option) {
                 case 'body':
                 case 'subject':
-                    $this->{$option} = (string) $value;
+                    $this->{$option} = (string)$value;
 
                 break;
                 default:
@@ -113,7 +113,7 @@ 
      * @param string        $recursion
      * @param bool          $recursion_first
      */
-    public function postSaveNodeAttributes(NodeInterface $node, array $attributes, array $remove, ?string $recursion, bool $recursion_first): void
+    public function postSaveNodeAttributes(NodeInterface $node, array $attributes, array $remove, ?string $recursion, bool $recursion_first) : void
     {
         if (!($node instanceof Collection)) {
             return;
@@ -130,24 +130,24 @@ 
         foreach ($node->getAcl() as $rule) {
             if ('user' === $rule['type']) {
                 $user = $this->server->getUserById(new ObjectId($rule['id']));
-                if (!isset($receiver[(string) $user->getId()]) && $this->checkNotify($node, $user)) {
-                    $receiver[(string) $user->getId()] = $user;
+                if (!isset($receiver[(string)$user->getId()]) && $this->checkNotify($node, $user)) {
+                    $receiver[(string)$user->getId()] = $user;
                 }
             } elseif ('group' === $rule['type']) {
                 foreach ($this->server->getGroupById($rule['id'])->getResolvedMember() as $user) {
-                    if (!isset($receiver[(string) $user->getId()]) && $this->checkNotify($node, $user)) {
-                        $receiver[(string) $user->getId()] = $user;
+                    if (!isset($receiver[(string)$user->getId()]) && $this->checkNotify($node, $user)) {
+                        $receiver[(string)$user->getId()] = $user;
                     }
                 }
             }
         }
 
         if (!empty($receiver)) {
-            $body = preg_replace_callback('/(\{(([a-z]\.*)+)\})/', function ($match) {
+            $body = preg_replace_callback('/(\{(([a-z]\.*)+)\})/', function($match) {
                 return '';
                 //return $node->getAttributes()[$match[2]];
             }, $this->body);
-            $subject = preg_replace_callback('/(\{(([a-z]\.*)+)\})/', function ($match) {
+            $subject = preg_replace_callback('/(\{(([a-z]\.*)+)\})/', function($match) {
                 return '';
                 //return $node->getAttributes()[$match[2]];
             }, $this->subject);

src/app/Balloon.App.Notification/Notifier.php

Doc Comments +2 added lines, -2 removed lines

@@ -251,10 +251,10 @@ 
      * Add notification.
      *
      * @param array  $receiver
-     * @param User   $user
      * @param string $subject
      * @param string $body
      * @param array  $context
+     * @param User $sender
      *
      * @return ObjectId
      */
@@ -295,7 +295,7 @@ 
     /**
      * Get notifications.
      *
-     * @param ObjectId $id
+     * @param User $id
      *
      * @return bool
      */

Spacing +8 added lines, -8 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -102,7 +102,7 @@ 
      *
      * @return Notifier
      */
-    public function setOptions(?Iterable $config = null): self
+    public function setOptions(?Iterable $config = null) : self
     {
         if (null === $config) {
             return $this;
@@ -145,7 +145,7 @@ 
      *
      * @return bool
      */
-    public function notify(array $receiver, ?User $sender, string $subject, string $body, array $context = []): bool
+    public function notify(array $receiver, ?User $sender, string $subject, string $body, array $context = []) : bool
     {
         if (0 === count($this->adapter)) {
             $this->logger->warning('there are no notification adapter enabled, notification can not be sent', [
@@ -185,7 +185,7 @@ 
      *
      * @return AdapterInterface
      */
-    public function injectAdapter($adapter, ?string $name = null): AdapterAwareInterface
+    public function injectAdapter($adapter, ?string $name = null) : AdapterAwareInterface
     {
         if (!($adapter instanceof AdapterInterface)) {
             throw new Exception('adapter needs to implement AdapterInterface');
@@ -258,7 +258,7 @@ 
      *
      * @return ObjectId
      */
-    public function postNotification(array $receiver, ?User $sender, string $subject, string $body, array $context = []): ObjectId
+    public function postNotification(array $receiver, ?User $sender, string $subject, string $body, array $context = []) : ObjectId
     {
         $data = [
             'subject' => $subject,
@@ -349,8 +349,8 @@ 
                 'category' => get_class($this),
             ]);
 
-            if (isset($subs[(string) $this->user->getId()])) {
-                unset($subs[(string) $this->user->getId()]);
+            if (isset($subs[(string)$this->user->getId()])) {
+                unset($subs[(string)$this->user->getId()]);
             }
 
             $node->setAppAttribute(__NAMESPACE__, 'subscription', $subs);
@@ -359,7 +359,7 @@ 
                 'category' => get_class($this),
             ]);
 
-            $subs[(string) $this->user->getId()] = new UTCDateTime();
+            $subs[(string)$this->user->getId()] = new UTCDateTime();
             $node->setAppAttribute(__NAMESPACE__, 'subscription', $subs);
         }
 

src/app/Balloon.App.Preview/Hook.php

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 
 namespace Balloon\App\Preview;
 
-use Balloon\Exception;
 use Balloon\Filesystem\Node\File;
 use Balloon\Hook\AbstractHook;
 use MongoDB\GridFS\Exception\FileNotFoundException;

src/lib/Api/v1/Node.php

Doc Comments +3 added lines, -3 removed lines

@@ -282,7 +282,7 @@ 
      * @param array|string $id
      * @param array|string $p
      * @param int          $offset
-     * @param int          $legnth
+     * @param int          $length
      * @param string       $encode
      * @param bool         $download
      * @param string       $name
@@ -1420,7 +1420,7 @@ 
      * @param string $class      Force set node type
      * @param bool   $multiple   Allow $id to be an array
      * @param bool   $allow_root Allow instance of root collection
-     * @param bool   $deleted    How to handle deleted node
+     * @param integer   $deleted    How to handle deleted node
      *
      * @return NodeInterface
      */
@@ -1454,7 +1454,7 @@ 
      * @param string $id
      * @param string $path
      * @param string $class   Force set node type
-     * @param bool   $deleted How to handle deleted node
+     * @param integer   $deleted How to handle deleted node
      *
      * @return Generator
      */

Indentation +44 added lines, -44 removed lines

@@ -320,50 +320,50 @@ 
         }
 
         return (new Response())
-          ->setOutputFormat(null)
-          ->setBody(function () use ($node, $encode, $offset, $length) {
-              $mime = $node->getContentType();
-              $stream = $node->get();
-              $name = $node->getName();
-
-              if (null === $stream) {
-                  return;
-              }
-
-              if (0 !== $offset) {
-                  if (fseek($stream, $offset) === -1) {
-                      throw new Exception\Conflict(
+            ->setOutputFormat(null)
+            ->setBody(function () use ($node, $encode, $offset, $length) {
+                $mime = $node->getContentType();
+                $stream = $node->get();
+                $name = $node->getName();
+
+                if (null === $stream) {
+                    return;
+                }
+
+                if (0 !== $offset) {
+                    if (fseek($stream, $offset) === -1) {
+                        throw new Exception\Conflict(
                         'invalid offset requested',
                         Exception\Conflict::INVALID_OFFSET
                     );
-                  }
-              }
-
-              $read = 0;
-              header('Content-Type: '.$mime.'');
-              if ('base64' === $encode) {
-                  header('Content-Encoding: base64');
-                  while (!feof($stream)) {
-                      if (0 !== $length && $read + 8192 > $length) {
-                          echo base64_encode(fread($stream, $length - $read));
-                          exit();
-                      }
-
-                      echo base64_encode(fread($stream, 8192));
-                      $read += 8192;
-                  }
-              } else {
-                  while (!feof($stream)) {
-                      if (0 !== $length && $read + 8192 > $length) {
-                          echo fread($stream, $length - $read);
-                          exit();
-                      }
-
-                      echo fread($stream, 8192);
-                      $read += 8192;
-                  }
-              }
-          });
+                    }
+                }
+
+                $read = 0;
+                header('Content-Type: '.$mime.'');
+                if ('base64' === $encode) {
+                    header('Content-Encoding: base64');
+                    while (!feof($stream)) {
+                        if (0 !== $length && $read + 8192 > $length) {
+                            echo base64_encode(fread($stream, $length - $read));
+                            exit();
+                        }
+
+                        echo base64_encode(fread($stream, 8192));
+                        $read += 8192;
+                    }
+                } else {
+                    while (!feof($stream)) {
+                        if (0 !== $length && $read + 8192 > $length) {
+                            echo fread($stream, $length - $read);
+                            exit();
+                        }
+
+                        echo fread($stream, 8192);
+                        $read += 8192;
+                    }
+                }
+            });
     }
 
     /**
@@ -1502,9 +1502,9 @@ 
                 $node->zip($archive);
             } catch (\Exception $e) {
                 $this->logger->debug('failed zip node in multi node request ['.$node->getId().']', [
-                   'category' => get_class($this),
-                   'exception' => $e,
-               ]);
+                    'category' => get_class($this),
+                    'exception' => $e,
+                ]);
             }
         }
 

Spacing +30 added lines, -30 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -116,13 +116,13 @@ 
      *
      * @return Response
      */
-    public function head(?string $id = null, ?string $p = null, int $deleted = 0): Response
+    public function head(?string $id = null, ?string $p = null, int $deleted = 0) : Response
     {
         try {
             $result = $this->_getNode($id, $p, null, false, false, $deleted);
 
             $response = (new Response())
-                ->setHeader('Content-Length', (string) $result->getSize())
+                ->setHeader('Content-Length', (string)$result->getSize())
                 ->setHeader('Content-Type', $result->getContentType())
                 ->setCode(200);
 
@@ -178,7 +178,7 @@ 
         ?string $destid = null,
         ?string $destp = null,
         int $conflict = 0
-    ): Response {
+    ) : Response {
         $parent = null;
 
         if (true === $move) {
@@ -205,7 +205,7 @@ 
                     }
                 } catch (\Exception $e) {
                     $failures[] = [
-                        'id' => (string) $node->getId(),
+                        'id' => (string)$node->getId(),
                         'name' => $node->getName(),
                         'error' => get_class($e),
                         'message' => $e->getMessage(),
@@ -295,14 +295,14 @@ 
         ?string $encode = null,
         bool $download = false,
         string $name = 'selected'
-    ): ?Response {
+    ) : ?Response {
         if (is_array($id) || is_array($p)) {
             return $this->combine($id, $p, $name);
         }
 
         $node = $this->_getNode($id, $p);
         if ($node instanceof Collection) {
-            return (new Response())->setBody(function () use ($node) {
+            return (new Response())->setBody(function() use ($node) {
                 $node->getZip();
             });
         }
@@ -313,7 +313,7 @@ 
             $response->setHeader('Content-Disposition', 'attachment; filename*=UTF-8\'\''.rawurlencode($name));
             $response->setHeader('Cache-Control', 'no-store, no-cache, must-revalidate, post-check=0, pre-check=0');
             $response->setHeader('Content-Type', 'application/octet-stream');
-            $response->setHeader('Content-Length', (string) $node->getSize());
+            $response->setHeader('Content-Length', (string)$node->getSize());
             $response->setHeader('Content-Transfer-Encoding', 'binary');
         } else {
             $response->setHeader('Content-Disposition', 'inline; filename*=UTF-8\'\''.rawurlencode($name));
@@ -321,7 +321,7 @@ 
 
         return (new Response())
           ->setOutputFormat(null)
-          ->setBody(function () use ($node, $encode, $offset, $length) {
+          ->setBody(function() use ($node, $encode, $offset, $length) {
               $mime = $node->getContentType();
               $stream = $node->get();
               $name = $node->getName();
@@ -401,7 +401,7 @@ 
                     $node->setReadonly($readonly);
                 } catch (\Exception $e) {
                     $failures[] = [
-                        'id' => (string) $node->getId(),
+                        'id' => (string)$node->getId(),
                         'name' => $node->getName(),
                         'error' => get_class($e),
                         'message' => $e->getMessage(),
@@ -589,7 +589,7 @@ 
      *
      * @return Response
      */
-    public function getParent(?string $id = null, ?string $p = null, array $attributes = []): Response
+    public function getParent(?string $id = null, ?string $p = null, array $attributes = []) : Response
     {
         $result = Helper::escape(
             $this->decorator->decorate($this->_getNode($id, $p)->getParent(), $attributes)
@@ -669,7 +669,7 @@ 
      *
      * @return Response
      */
-    public function getParents(?string $id = null, ?string $p = null, array $attributes = [], bool $self = false): Response
+    public function getParents(?string $id = null, ?string $p = null, array $attributes = [], bool $self = false) : Response
     {
         $request = $this->_getNode($id, $p);
         $parents = $request->getParents();
@@ -719,7 +719,7 @@ 
      *
      * @return Response
      */
-    public function postMetaAttributes(?string $id = null, ?string $p = null): Response
+    public function postMetaAttributes(?string $id = null, ?string $p = null) : Response
     {
         if (is_array($id) || is_array($p)) {
             $failures = [];
@@ -728,7 +728,7 @@ 
                     $node->setMetaAttribute(Helper::filter($_POST));
                 } catch (\Exception $e) {
                     $failures[] = [
-                        'id' => (string) $node->getId(),
+                        'id' => (string)$node->getId(),
                         'name' => $node->getName(),
                         'error' => get_class($e),
                         'message' => $e->getMessage(),
@@ -781,7 +781,7 @@ 
      *
      * @return Response
      */
-    public function postName(string $name, ?string $id = null, ?string $p = null): Response
+    public function postName(string $name, ?string $id = null, ?string $p = null) : Response
     {
         $this->_getNode($id, $p)->setName($name);
 
@@ -825,7 +825,7 @@ 
         ?string $destid = null,
         ?string $destp = null,
         int $conflict = 0
-    ): Response {
+    ) : Response {
         try {
             $parent = $this->_getNode($destid, $destp, Collection::class, false, true);
         } catch (Exception\NotFound $e) {
@@ -842,7 +842,7 @@ 
                     $node->copyTo($parent, $conflict);
                 } catch (\Exception $e) {
                     $failures[] = [
-                        'id' => (string) $node->getId(),
+                        'id' => (string)$node->getId(),
                         'name' => $node->getName(),
                         'error' => get_class($e),
                         'message' => $e->getMessage(),
@@ -864,7 +864,7 @@ 
         }
         $result = $this->_getNode($id, $p)->copyTo($parent, $conflict);
 
-        return (new Response())->setCode(201)->setBody((string) $result->getId());
+        return (new Response())->setCode(201)->setBody((string)$result->getId());
     }
 
     /**
@@ -911,7 +911,7 @@ 
         ?string $destid = null,
         ?string $destp = null,
         int $conflict = 0
-    ): Response {
+    ) : Response {
         try {
             $parent = $this->_getNode($destid, $destp, Collection::class, false, true);
         } catch (Exception\NotFound $e) {
@@ -928,7 +928,7 @@ 
                     $node->setParent($parent, $conflict);
                 } catch (\Exception $e) {
                     $failures[] = [
-                        'id' => (string) $node->getId(),
+                        'id' => (string)$node->getId(),
                         'name' => $node->getName(),
                         'error' => get_class($e),
                         'message' => $e->getMessage(),
@@ -995,7 +995,7 @@ 
         bool $force = false,
         bool $ignore_flag = false,
         ?string $at = null
-    ): Response {
+    ) : Response {
         $failures = [];
 
         if (null !== $at && '0' !== $at) {
@@ -1015,7 +1015,7 @@ 
                     }
                 } catch (\Exception $e) {
                     $failures[] = [
-                        'id' => (string) $node->getId(),
+                        'id' => (string)$node->getId(),
                         'name' => $node->getName(),
                         'error' => get_class($e),
                         'message' => $e->getMessage(),
@@ -1243,7 +1243,7 @@ 
         ?string $cursor = null,
         int $limit = 250,
         array $attributes = []
-    ): Response {
+    ) : Response {
         if (null !== $id || null !== $p) {
             $node = $this->_getNode($id, $p);
         } else {
@@ -1358,7 +1358,7 @@ 
      *
      * @return Response
      */
-    public function getEventLog(?string $id = null, ?string $p = null, int $skip = 0, int $limit = 100): Response
+    public function getEventLog(?string $id = null, ?string $p = null, int $skip = 0, int $limit = 100) : Response
     {
         if (null !== $id || null !== $p) {
             $node = $this->_getNode($id, $p);
@@ -1399,7 +1399,7 @@ 
      *
      * @return Response
      */
-    public function getLastCursor(?string $id = null, ?string $p = null): Response
+    public function getLastCursor(?string $id = null, ?string $p = null) : Response
     {
         if (null !== $id || null !== $p) {
             $node = $this->_getNode($id, $p);
@@ -1431,7 +1431,7 @@ 
         bool $multiple = false,
         bool $allow_root = false,
         int $deleted = 2
-    ): NodeInterface {
+    ) : NodeInterface {
         if (null === $class) {
             switch (get_class($this)) {
                 case ApiFile::class:
@@ -1463,7 +1463,7 @@ 
         $path = null,
         ?string $class = null,
         int $deleted = 2
-    ): Generator {
+    ) : Generator {
         if (null === $class) {
             switch (get_class($this)) {
                 case ApiFile::class:
@@ -1548,7 +1548,7 @@ 
 
                 break;
                 case 'filter':
-                    $attributes['filter'] = json_encode((array) $attributes['filter']);
+                    $attributes['filter'] = json_encode((array)$attributes['filter']);
 
                 break;
                 case 'destroy':
@@ -1563,14 +1563,14 @@ 
                     if (!Helper::isValidTimestamp($value)) {
                         throw new Exception\InvalidArgument($attribute.' Changed timestamp must be valid unix timestamp');
                     }
-                    if ((int) $value > time()) {
+                    if ((int)$value > time()) {
                         throw new Exception\InvalidArgument($attribute.' timestamp can not be set greater than the server time');
                     }
                     $attributes[$attribute] = new UTCDateTime($value.'000');
 
                 break;
                 case 'readonly':
-                    $attributes['readonly'] = (bool) $attributes['readonly'];
+                    $attributes['readonly'] = (bool)$attributes['readonly'];
 
                 break;
             }

src/lib/Filesystem.php

Doc Comments +2 added lines, -2 removed lines

@@ -291,7 +291,7 @@ 
      *
      * @param array  $id
      * @param string $class   Force check node type
-     * @param bool   $deleted
+     * @param integer   $deleted
      *
      * @return Generator
      */
@@ -411,7 +411,7 @@ 
      * @param string $class      Force set node type
      * @param bool   $multiple   Allow $id to be an array
      * @param bool   $allow_root Allow instance of root collection
-     * @param bool   $deleted    How to handle deleted node
+     * @param integer   $deleted    How to handle deleted node
      *
      * @return NodeInterface
      */

Spacing +6 added lines, -6 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -204,7 +204,7 @@ 
      *
      * @return NodeInterface
      */
-    public function findNodeById($id, ?string $class = null, int $deleted = NodeInterface::DELETED_INCLUDE): NodeInterface
+    public function findNodeById($id, ?string $class = null, int $deleted = NodeInterface::DELETED_INCLUDE) : NodeInterface
     {
         if (!is_string($id) && !($id instanceof ObjectId)) {
             throw new Exception\InvalidArgument($id.' node id has to be a string or instance of \MongoDB\BSON\ObjectId');
@@ -261,7 +261,7 @@ 
      *
      * @return NodeInterface
      */
-    public function findNodeByPath(string $path = '', ?string $class = null): NodeInterface
+    public function findNodeByPath(string $path = '', ?string $class = null) : NodeInterface
     {
         if (empty($path) || '/' !== $path[0]) {
             $path = '/'.$path;
@@ -295,7 +295,7 @@ 
      *
      * @return Generator
      */
-    public function findNodesById(array $id = [], ?string $class = null, int $deleted = NodeInterface::DELETED_INCLUDE): Generator
+    public function findNodesById(array $id = [], ?string $class = null, int $deleted = NodeInterface::DELETED_INCLUDE) : Generator
     {
         $find = [];
         foreach ($id as $i) {
@@ -341,7 +341,7 @@ 
      *
      * @return Generator
      */
-    public function findNodesByPath(array $path = [], ?string $class = null): Generator
+    public function findNodesByPath(array $path = [], ?string $class = null) : Generator
     {
         $find = [];
         foreach ($path as $p) {
@@ -379,7 +379,7 @@ 
      *
      * @return Generator
      */
-    public function getNodes(?array $id = null, ?array $path = null, $class = null, int $deleted = NodeInterface::DELETED_EXCLUDE): Generator
+    public function getNodes(? array $id = null, ? array $path = null, $class = null, int $deleted = NodeInterface::DELETED_EXCLUDE) : Generator
     {
         if (null === $id && null === $path) {
             throw new Exception\InvalidArgument('neither parameter id nor p (path) was given');

src/lib/Filesystem/Node/File.php

Doc Comments +2 added lines, -2 removed lines

@@ -694,7 +694,7 @@ 
      * @param string $path
      * @param bool   $new
      *
-     * @return bool
+     * @return string
      */
     protected function verifyFile(?string $path, bool $new = false): string
     {
@@ -827,7 +827,7 @@ 
     /**
      * Finalize put request.
      *
-     * @param resource|string $file
+     * @param string|null $file
      * @param bool            $new
      * @param array           $attributes
      *

Unused Use Statements -1 removed lines

@@ -20,7 +20,6 @@
 use Balloon\Helper;
 use Balloon\Hook;
 use Balloon\Mime;
-use Balloon\Server\User;
 use MongoDB\BSON\UTCDateTime;
 use Psr\Log\LoggerInterface;
 

Indentation +1 added lines, -1 removed lines

@@ -589,7 +589,7 @@
         ]);
 
         $this->addVersion($attributes)
-             ->postPutFile($file, $new, $attributes);
+                ->postPutFile($file, $new, $attributes);
 
         return $this->version;
     }

Spacing +17 added lines, -17 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -46,14 +46,14 @@ 
      * @param array
      **/
     protected $temp_files = [
-        '/^\._(.*)$/',     // OS/X resource forks
-        '/^.DS_Store$/',   // OS/X custom folder settings
+        '/^\._(.*)$/', // OS/X resource forks
+        '/^.DS_Store$/', // OS/X custom folder settings
         '/^desktop.ini$/', // Windows custom folder settings
-        '/^Thumbs.db$/',   // Windows thumbnail cache
-        '/^.(.*).swpx$/',  // ViM temporary files
-        '/^.(.*).swx$/',   // ViM temporary files
-        '/^.(.*).swp$/',   // ViM temporary files
-        '/^\.dat(.*)$/',   // Smultron seems to create these
+        '/^Thumbs.db$/', // Windows thumbnail cache
+        '/^.(.*).swpx$/', // ViM temporary files
+        '/^.(.*).swx$/', // ViM temporary files
+        '/^.(.*).swp$/', // ViM temporary files
+        '/^\.dat(.*)$/', // Smultron seems to create these
         '/^~lock.(.*)#$/', // Windows 7 lockfiles
     ];
 
@@ -154,7 +154,7 @@ 
      *
      * @return NodeInterface
      */
-    public function copyTo(Collection $parent, int $conflict = NodeInterface::CONFLICT_NOACTION, ?string $recursion = null, bool $recursion_first = true): NodeInterface
+    public function copyTo(Collection $parent, int $conflict = NodeInterface::CONFLICT_NOACTION, ?string $recursion = null, bool $recursion_first = true) : NodeInterface
     {
         $this->_hook->run(
             'preCopyFile',
@@ -198,7 +198,7 @@ 
         $filtered = [];
 
         foreach ($history as $version) {
-            $v = (array) $version;
+            $v = (array)$version;
 
             $v['user'] = $this->_fs->getServer()->getUserById($version['user'])->getUsername();
             $v['changed'] = Helper::DateTimeToUnix($version['changed']);
@@ -320,7 +320,7 @@ 
      *
      * @return bool
      */
-    public function delete(bool $force = false, ?string $recursion = null, bool $recursion_first = true): bool
+    public function delete(bool $force = false, ?string $recursion = null, bool $recursion_first = true) : bool
     {
         if (!$this->_acl->isAllowed($this, 'w')) {
             throw new ForbiddenException(
@@ -551,7 +551,7 @@ 
         }
 
         $this->hash = $new_hash;
-        $max = (int) (string) $this->_fs->getServer()->getMaxFileVersion();
+        $max = (int)(string)$this->_fs->getServer()->getMaxFileVersion();
         if (count($this->history) >= $max) {
             $del = key($this->history);
             $this->_logger->debug('history limit ['.$max.'] reached, remove oldest version ['.$del.'] from file ['.$this->_id.']', [
@@ -645,8 +645,8 @@ 
     {
         assert(16 === strlen($data));
 
-        $data[6] = chr(ord($data[6]) & 0x0f | 0x40); // set version to 0100
-        $data[8] = chr(ord($data[8]) & 0x3f | 0x80); // set bits 6-7 to 10
+        $data[6] = chr(ord($data[6])&0x0f|0x40); // set version to 0100
+        $data[8] = chr(ord($data[8])&0x3f|0x80); // set bits 6-7 to 10
 
         return vsprintf('%s%s-%s-%s-%s-%s%s%s', str_split(bin2hex($data), 4));
     }
@@ -696,7 +696,7 @@ 
      *
      * @return bool
      */
-    protected function verifyFile(?string $path, bool $new = false): string
+    protected function verifyFile(?string $path, bool $new = false) : string
     {
         if (null === $path) {
             $this->size = 0;
@@ -749,11 +749,11 @@ 
 
             $tmp_file = $tmp.DIRECTORY_SEPARATOR.$this->guidv4(openssl_random_pseudo_bytes(16));
             $stream = fopen($tmp_file, 'w+');
-            $size = stream_copy_to_stream($file, $stream, ((int) $this->_fs->getServer()->getMaxFileSize() + 1));
+            $size = stream_copy_to_stream($file, $stream, ((int)$this->_fs->getServer()->getMaxFileSize() + 1));
             rewind($stream);
             fclose($file);
 
-            if ($size > (int) $this->_fs->getServer()->getMaxFileSize()) {
+            if ($size > (int)$this->_fs->getServer()->getMaxFileSize()) {
                 unlink($tmp_file);
 
                 throw new Exception\InsufficientStorage(

src/lib/Filesystem/Node/NodeInterface.php

Doc Comments +1 added lines, -2 removed lines

@@ -108,14 +108,13 @@
      *
      * @param bool $reference
      *
-     * @return ObjectId
+     * @return ObjectId|null
      */
     public function getShareId(bool $reference = false): ?ObjectId;
 
     /**
      * Get share node.
      *
-     * @param bool $reference
      *
      * @return Collection
      */

Spacing +5 added lines, -5 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -56,7 +56,7 @@ 
      *
      * @return bool
      */
-    public function delete(bool $force = false, ?string $recursion = null, bool $recursion_first = true): bool;
+    public function delete(bool $force = false, ?string $recursion = null, bool $recursion_first = true) : bool;
 
     /**
      * Set filesystem.
@@ -101,7 +101,7 @@ 
      *
      * @return NodeInterface
      */
-    public function copyTo(Collection $parent, int $conflict = self::CONFLICT_NOACTION, ?string $recursion = null, bool $recursion_first = true): self;
+    public function copyTo(Collection $parent, int $conflict = self::CONFLICT_NOACTION, ?string $recursion = null, bool $recursion_first = true) : self;
 
     /**
      * Get share id.
@@ -204,7 +204,7 @@ 
      *
      * @return bool
      */
-    public function undelete(int $conflict = self::CONFLICT_NOACTION, ?string $recursion = null, bool $recursion_first = true): bool;
+    public function undelete(int $conflict = self::CONFLICT_NOACTION, ?string $recursion = null, bool $recursion_first = true) : bool;
 
     /**
      * Is node deleted?
@@ -234,7 +234,7 @@ 
      *
      * @return array
      */
-    public function getParents(?self $node = null, array $parents = []): array;
+    public function getParents(?self $node = null, array $parents = []) : array;
 
     /**
      * Download.

src/lib/Server/User.php

Doc Comments +1 added lines, -1 removed lines

@@ -618,7 +618,7 @@
     /**
      * Save.
      *
-     * @param array $attributes
+     * @param string[] $attributes
      *
      * @throws Exception\InvalidArgument if a given argument is not valid
      *

Indentation +14 added lines, -14 removed lines

@@ -144,18 +144,18 @@ 
      * @var array
      */
     protected static $valid_attributes = [
-         'id',
-         'username',
-         'created',
-         'soft_quota',
-         'hard_quota',
-         'mail',
-         'namespace',
-         'last_attr_sync',
-         'avatar',
-         'created',
-         'admin',
-     ];
+            'id',
+            'username',
+            'created',
+            'soft_quota',
+            'hard_quota',
+            'mail',
+            'namespace',
+            'last_attr_sync',
+            'avatar',
+            'created',
+            'admin',
+        ];
 
     /**
      * Instance user.
@@ -799,8 +799,8 @@ 
 
         $ops[] = [
             '$sort' => [
-               'sum' => -1,
-               '_id' => 1,
+                'sum' => -1,
+                '_id' => 1,
             ],
         ];
 

Spacing +10 added lines, -10 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 /**
  * Balloon
@@ -241,7 +241,7 @@ 
 
             switch ($attr) {
                 case 'id':
-                    $this->_id = (string) $value;
+                    $this->_id = (string)$value;
 
                 break;
                 case 'avatar':
@@ -287,7 +287,7 @@ 
         if (empty($attribute)) {
             $requested = $default;
         } elseif (is_string($attribute)) {
-            $requested = (array) $attribute;
+            $requested = (array)$attribute;
         } elseif (is_array($attribute)) {
             $requested = $attribute;
         }
@@ -300,7 +300,7 @@ 
 
             switch ($attr) {
                 case 'id':
-                    $resolved['id'] = (string) $this->_id;
+                    $resolved['id'] = (string)$this->_id;
 
                 break;
                 case 'avatar':
@@ -356,7 +356,7 @@ 
             }
 
             if (true === $string) {
-                $found[] = (string) $share;
+                $found[] = (string)$share;
             } else {
                 $found[] = $share;
             }
@@ -458,7 +458,7 @@ 
             '$or' => [
                 ['acl' => [
                     '$elemMatch' => [
-                        'id' => (string) $this->_id,
+                        'id' => (string)$this->_id,
                         'type' => 'user',
                     ],
                 ]],
@@ -474,7 +474,7 @@ 
         $list = [];
         foreach ($item as $child) {
             $found[] = $child['_id'];
-            $list[(string) $child['_id']] = $child;
+            $list[(string)$child['_id']] = $child;
         }
 
         if (empty($found)) {
@@ -511,7 +511,7 @@ 
 
         $new = array_diff($found, $exists);
         foreach ($new as $add) {
-            $node = $list[(string) $add];
+            $node = $list[(string)$add];
 
             $this->logger->info('found new share ['.$node['_id'].']', [
                 'category' => get_class($this),
@@ -594,7 +594,7 @@ 
      */
     public function setHardQuota(int $quota): self
     {
-        $this->hard_quota = (int) $quota;
+        $this->hard_quota = (int)$quota;
         $this->save(['hard_quota']);
 
         return $this;
@@ -609,7 +609,7 @@ 
      */
     public function setSoftQuota(int $quota): self
     {
-        $this->soft_quota = (int) $quota;
+        $this->soft_quota = (int)$quota;
         $this->save(['soft_quota']);
 
         return $this;