gurucomkz / silverstripe-eagerloading

src/ProxyDBCounterExtension.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
     public function updateProxy(ProxyGenerator &$proxy)
     {
         // In the closure, $this is the proxied database
-        $callback = function ($args, $next) {
+        $callback = function($args, $next) {
 
             // The first argument is always the sql query
             $sql = $args[0];

src/GridFieldEagerLoadManipulator.php

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
                 foreach ($export_fields as $field=>$_title) {
                     $parts = explode('.', $field);
                     if (count($parts) < 2) continue;
-                    $main = implode('.', array_slice($parts,0,-1));
+                    $main = implode('.', array_slice($parts, 0, -1));
                     if (!in_array($main, $eager)) {
                         $eager[] = $main;
                     }

Braces +6 added lines, -2 removed lines

@@ -40,7 +40,9 @@ 
                 $export_eager = [];
                 foreach ($export_fields as $field=>$_title) {
                     $parts = explode('.', $field);
-                    if (count($parts) < 2) continue;
+                    if (count($parts) < 2) {
+                        continue;
+                    }
                     $main = implode('.', array_slice($parts,0,-1));
                     if (!in_array($main, $eager)) {
                         $eager[] = $main;
@@ -48,7 +50,9 @@ 
                 }
             }
         }
-        if ($eager) return $dataList->with($eager);
+        if ($eager) {
+            return $dataList->with($eager);
+        }
         return $dataList;
     }
 }

src/Utils.php

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
         $result = [];
         foreach ($arr as $k => $v) {
             $key = $k;
-            if ($kfield!==null) {
+            if ($kfield !== null) {
                 if (is_array($v) && isset($v[$kfield])) $key = $v[$kfield];
                 elseif (is_object($v) && isset($v->$kfield)) $key = $v->$kfield;
             }

Braces +5 added lines, -2 removed lines

@@ -13,8 +13,11 @@
         foreach ($arr as $k => $v) {
             $key = $k;
             if ($kfield!==null) {
-                if (is_array($v) && isset($v[$kfield])) $key = $v[$kfield];
-                elseif (is_object($v) && isset($v->$kfield)) $key = $v->$kfield;
+                if (is_array($v) && isset($v[$kfield])) {
+                    $key = $v[$kfield];
+                } elseif (is_object($v) && isset($v->$kfield)) {
+                    $key = $v->$kfield;
+                }
             }
             $result[$key] = $v;
         }

src/EagerLoadedDataList.php

Spacing +10 added lines, -10 removed lines

@@ -10,7 +10,7 @@ 
  * Replaces DataList when EagerLoading is used. Fetches data when the main query is actually executed.
  * Appends related objects when a DataObject is actually created.
  */
-class EagerLoadedDataList extends DataList{
+class EagerLoadedDataList extends DataList {
 
     const ID_LIMIT = 5000;
     public $withList = [];
@@ -121,12 +121,12 @@ 
 
             $descriptor['map'] = Utils::extractField($data, $descriptor['localField']);
             $uniqueIDs = array_unique($descriptor['map']);
-            while(count($uniqueIDs)) {
-                $IDsubset = array_splice($uniqueIDs,0,self::ID_LIMIT);
+            while (count($uniqueIDs)) {
+                $IDsubset = array_splice($uniqueIDs, 0, self::ID_LIMIT);
                 $result = DataObject::get($depClass)->filter('ID', $IDsubset);
-                if (count($depSeq)>1) {
+                if (count($depSeq) > 1) {
                     $result = $result
-                        ->with(implode('.', array_slice($depSeq,1)));
+                        ->with(implode('.', array_slice($depSeq, 1)));
                 }
 
                 foreach ($result as $depRecord) {
@@ -142,7 +142,7 @@ 
     public function eagerLoadHasMany($data, $hasManys, $withHasManys)
     {
         $localClass = $this->dataClass();
-        $localClassTail = basename(str_replace('\\','/', $localClass));
+        $localClassTail = basename(str_replace('\\', '/', $localClass));
 
         foreach ($withHasManys as $depSeq) {
             $dep = $depSeq[0];
@@ -156,7 +156,7 @@ 
                 'map' => [],
             ];
             $result = DataObject::get($depClass)->filter($depKey, $data);
-            if (count($depSeq)>1) {
+            if (count($depSeq) > 1) {
                 $result = $result
                     ->with(implode('.', array_slice($depSeq, 1)));
             }
@@ -197,7 +197,7 @@ 
                 implode(',', [$component['childField'], $component['parentField']]),
                 $component['join'],
                 [
-                    $component['parentField'].' IN (' . implode(',', $data).')'
+                    $component['parentField'].' IN ('.implode(',', $data).')'
                 ]
                 )->execute();
 
@@ -212,9 +212,9 @@ 
             }
 
             $result = DataObject::get($depClass)->filter('ID', array_keys($relListReverted));
-            if (count($depSeq)>1) {
+            if (count($depSeq) > 1) {
                 $result = $result
-                    ->with(implode('.', array_slice($depSeq,1)));
+                    ->with(implode('.', array_slice($depSeq, 1)));
             }
 
             foreach ($result as $depRecord) {

Braces +6 added lines, -2 removed lines

@@ -67,7 +67,9 @@ 
     }
 
     public function prepareEagerRelations() {
-        if ($this->relationsPrepared) return;
+        if ($this->relationsPrepared) {
+            return;
+        }
         $this->relationsPrepared = true;
         $localClass = $this->dataClass();
         $config = Config::forClass($localClass);
@@ -221,7 +223,9 @@ 
             foreach ($idsQuery as $row) {
                 $relID = $row[$component['childField']];
                 $localID = $row[$component['parentField']];
-                if (!isset($collection[$localID])) $collection[$localID] = [];
+                if (!isset($collection[$localID])) {
+                    $collection[$localID] = [];
+                }
                 $collection[$localID][] = $relID;
                 $relListReverted[$relID] = 1; //use ids as keys to avoid
             }

src/DataFilterEagerLoadingExtension.php

Braces +3 added lines, -1 removed lines

@@ -16,7 +16,9 @@
         if (!isset($this->owner->withList)) {
             $this->owner->withList = [];
         }
-        if (!is_array($list)) $list = [$list];
+        if (!is_array($list)) {
+            $list = [$list];
+        }
         $list = array_map(function($e) {return explode('.', $e); }, $list);
         $this->owner->withList = array_merge($this->owner->withList, $list);
         return EagerLoadedDataList::cloneFrom($this->owner);