gui-don / rico-lib

src/Slib/FileUtils.php

<?php

declare(strict_types=1);

namespace Rico\Slib;

abstract class FileUtils
{
    /**
     * Adds a new $line at the end of a $file without duplication.
     *
     * @param string $file
     * @param string $line
     *
     * @return bool
     */
    public static function addLine(string $file, string $line): bool
    {
        if (!file_exists($file)) {
            return false;
        }

        $handle = fopen($file, 'r+');

        while (($currentLine = fgets($handle)) !== false) {

It seems like $handle can also be of type false; however, parameter $handle of fgets() does only seem to accept resource, maybe add an additional type check?

            if (trim($currentLine) == $line) {
                return false;
            }
        }

        fwrite($handle, $line.PHP_EOL);

It seems like $handle can also be of type false; however, parameter $handle of fwrite() does only seem to accept resource, maybe add an additional type check?

        fclose($handle);

It seems like $handle can also be of type false; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

        return true;
    }

    /**
     * Counts the number of lines in a $file.
     *
     * @param string $file
     * @param bool   $countEmpty
     *
     * @return int|null
     */
    public static function count(string $file, bool $countEmpty = false): ?int
    {
        if (!file_exists($file)) {
            return null;
        }

        $lines = 0;
        $handle = fopen($file, 'r');
        while (!feof($handle)) {

It seems like $handle can also be of type false; however, parameter $handle of feof() does only seem to accept resource, maybe add an additional type check?

            $line = fgets($handle, 8192);

It seems like $handle can also be of type false; however, parameter $handle of fgets() does only seem to accept resource, maybe add an additional type check?

            if (false === $line) {
                continue;
            }

            $lastChar = mb_strlen((string) $line) - 1;

            if ($lastChar == 0) {
                if ($countEmpty) {
                    ++$lines;
                }
                continue;
            }

            if ($line[$lastChar] == "\n" || $line[$lastChar] == "\r") {
                ++$lines;
            }
        }

        fclose($handle);

It seems like $handle can also be of type false; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

        return $lines;
    }

    /**
     * Extracts the extension (without the dot) of a filename alone or contained in a path.
     *
     * @param string $filename
     *
     * @return string
     */
    public static function extractExtension(string $filename): string
    {
        $fileInfo = pathinfo($filename);

        return $fileInfo['extension'] ?? '';
    }
}