Rico\Slib\FileUtils::count()

Complexity

Conditions	8
Paths	7

Size

Total Lines	32
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	1	Features	0

<?php
    public static function count(string $file, bool $countEmpty = false): ?int
    {
        if (!file_exists($file)) {
            return null;
        }

        $lines = 0;
        $handle = fopen($file, 'r');
        while (!feof($handle)) {

It seems like $handle can also be of type false; however, parameter $handle of feof() does only seem to accept resource, maybe add an additional type check?

            $line = fgets($handle, 8192);

It seems like $handle can also be of type false; however, parameter $handle of fgets() does only seem to accept resource, maybe add an additional type check?

            if (false === $line) {
                continue;
            }

            $lastChar = mb_strlen((string) $line) - 1;

            if ($lastChar == 0) {
                if ($countEmpty) {
                    ++$lines;
                }
                continue;
            }

            if ($line[$lastChar] == "\n" || $line[$lastChar] == "\r") {
                ++$lines;
            }
        }

        fclose($handle);

It seems like $handle can also be of type false; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

        return $lines;
    }