Passed
Push — master ( 42b683...7c1a7f )
by
unknown
16:41 queued 02:17
created
plugins/smime/php/plugin.smime.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -454,7 +454,7 @@
 block discarded – undo
454 454
 		}
455 455
 
456 456
 		if (!encryptionStoreExpirationSupport()) {
457
-			withPHPSession(function () use ($encryptionStore) {
457
+			withPHPSession(function() use ($encryptionStore) {
458 458
 				$encryptionStore->add('smime', '');
459 459
 			});
460 460
 		}
Please login to merge, or discard this patch.
server/includes/core/class.operations.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -2065,9 +2065,9 @@  discard block
 block discarded – undo
2065 2065
 		$messageProps = [];
2066 2066
 		// It stores the values that is exception allowed or not false -> not allowed
2067 2067
 		$isExceptionAllowed = true;
2068
-		$delete = $actionType == 'delete';	// Flag for MeetingRequest Class whether to send update or cancel mail.
2069
-		$basedate = false;	// Flag for MeetingRequest Class whether to send an exception or not.
2070
-		$isReminderTimeAllowed = true;	// Flag to check reminder minutes is in range of the occurrences
2068
+		$delete = $actionType == 'delete'; // Flag for MeetingRequest Class whether to send update or cancel mail.
2069
+		$basedate = false; // Flag for MeetingRequest Class whether to send an exception or not.
2070
+		$isReminderTimeAllowed = true; // Flag to check reminder minutes is in range of the occurrences
2071 2071
 		$properties = $GLOBALS['properties']->getAppointmentProperties();
2072 2072
 		$send = false;
2073 2073
 		$oldProps = [];
@@ -3016,7 +3016,7 @@  discard block
 block discarded – undo
3016 3016
 			 * convert flags of PR_MESSAGE_FLAGS property to flags that is
3017 3017
 			 * used in mapi_message_setreadflag.
3018 3018
 			 */
3019
-			$flag = MAPI_DEFERRED_ERRORS;		// set unread flag, read receipt will be sent
3019
+			$flag = MAPI_DEFERRED_ERRORS; // set unread flag, read receipt will be sent
3020 3020
 
3021 3021
 			if (($flags & MSGFLAG_RN_PENDING) && isset($msg_action['send_read_receipt']) && $msg_action['send_read_receipt'] == false) {
3022 3022
 				$flag |= SUPPRESS_RECEIPT;
Please login to merge, or discard this patch.
server/includes/core/class.entryid.php 1 patch
Spacing   +35 added lines, -36 removed lines patch added patch discarded remove patch
@@ -60,13 +60,13 @@  discard block
 block discarded – undo
60 60
 		$entryId = strtoupper((string) $entryid);
61 61
 
62 62
 		$res = [
63
-			'abFlags' => '',		// BYTE[4],   4 bytes,  8 hex characters
64
-			'guid' => '',		// GUID,     16 bytes, 32 hex characters
65
-			'version' => '',		// ULONG,     4 bytes,  8 hex characters
66
-			'type' => '',		// ULONG,     4 bytes,  8 hex characters
67
-			'uniqueId' => '',		// ULONG,    16 bytes,  32 hex characters
68
-			'server' => '',		// CHAR,     variable length
69
-			'padding' => '',		// TCHAR[3],  4 bytes,  8 hex characters (upto 4 bytes)
63
+			'abFlags' => '', // BYTE[4],   4 bytes,  8 hex characters
64
+			'guid' => '', // GUID,     16 bytes, 32 hex characters
65
+			'version' => '', // ULONG,     4 bytes,  8 hex characters
66
+			'type' => '', // ULONG,     4 bytes,  8 hex characters
67
+			'uniqueId' => '', // ULONG,    16 bytes,  32 hex characters
68
+			'server' => '', // CHAR,     variable length
69
+			'padding' => '', // TCHAR[3],  4 bytes,  8 hex characters (upto 4 bytes)
70 70
 		];
71 71
 
72 72
 		$res['length'] = strlen($entryId);
@@ -111,13 +111,13 @@  discard block
 block discarded – undo
111 111
 		$entryId = strtoupper((string) $entryid);
112 112
 
113 113
 		$res = [
114
-			'abFlags' => '',		// BYTE[4],   4 bytes,  8 hex characters
115
-			'guid' => '',		// GUID,     16 bytes, 32 hex characters
116
-			'version' => '',		// ULONG,     4 bytes,  8 hex characters
117
-			'type' => '',		// ULONG,     4 bytes,  8 hex characters
118
-			'id' => '',		// ULONG,     4 bytes,  8 hex characters
119
-			'server' => '',		// CHAR,     variable length
120
-			'padding' => '',		// TCHAR[3],  4 bytes,  8 hex characters (upto 4 bytes)
114
+			'abFlags' => '', // BYTE[4],   4 bytes,  8 hex characters
115
+			'guid' => '', // GUID,     16 bytes, 32 hex characters
116
+			'version' => '', // ULONG,     4 bytes,  8 hex characters
117
+			'type' => '', // ULONG,     4 bytes,  8 hex characters
118
+			'id' => '', // ULONG,     4 bytes,  8 hex characters
119
+			'server' => '', // CHAR,     variable length
120
+			'padding' => '', // TCHAR[3],  4 bytes,  8 hex characters (upto 4 bytes)
121 121
 		];
122 122
 
123 123
 		$res['length'] = strlen($entryId);
@@ -162,13 +162,13 @@  discard block
 block discarded – undo
162 162
 		$entryId = strtoupper((string) $entryId);
163 163
 
164 164
 		$res = [
165
-			'abFlags' => '',		// BYTE[4],   4 bytes,  8 hex characters
166
-			'guid' => '',		// GUID,     16 bytes, 32 hex characters
167
-			'version' => '',		// ULONG,     4 bytes,  8 hex characters
168
-			'type' => '',		// ULONG,     4 bytes,  8 hex characters
169
-			'id' => '',		// ULONG,    16 bytes,  32 hex characters
170
-			'extid' => '',		// CHAR,     variable length
171
-			'padding' => '',		// TCHAR[3],  4 bytes,  8 hex characters (upto 4 bytes)
165
+			'abFlags' => '', // BYTE[4],   4 bytes,  8 hex characters
166
+			'guid' => '', // GUID,     16 bytes, 32 hex characters
167
+			'version' => '', // ULONG,     4 bytes,  8 hex characters
168
+			'type' => '', // ULONG,     4 bytes,  8 hex characters
169
+			'id' => '', // ULONG,    16 bytes,  32 hex characters
170
+			'extid' => '', // CHAR,     variable length
171
+			'padding' => '', // TCHAR[3],  4 bytes,  8 hex characters (upto 4 bytes)
172 172
 		];
173 173
 
174 174
 		$res['length'] = strlen($entryId);
@@ -479,8 +479,7 @@  discard block
 block discarded – undo
479 479
 			}
480 480
 		}
481 481
 		elseif ($checkValue !== null && $val != $checkValue) {
482
-			$user = $GLOBALS["mapisession"] !== null ? $GLOBALS["mapisession"]->getUserName() :
483
-					"<mapisession not yet initialized>";
482
+			$user = $GLOBALS["mapisession"] !== null ? $GLOBALS["mapisession"]->getUserName() : "<mapisession not yet initialized>";
484 483
 			error_log(sprintf(
485 484
 				"Unexpected value in store entryid for user %s. Entryid: %s key: '%s' value: '%s' expected: %s",
486 485
 				$user,
@@ -511,13 +510,13 @@  discard block
 block discarded – undo
511 510
 		$entryId = strtoupper((string) $entryId);
512 511
 
513 512
 		$res = [
514
-			'providerguid' => '',			// GUID,     16 bytes, 32 hex characters
515
-			'messagetype' => '',			// UINT,      2 bytes,  4 hex characters
516
-			'folderdbguid' => '',			// GUID,     16 bytes, 32 hex characters
517
-			'foldercounter' => '',		// ULONG,     6 bytes, 12 hex characters
518
-			'padding' => '',					// TCHAR[3],  2 bytes,  4 hex characters
519
-			'messagedbguid' => '',		// GUID,     16 bytes, 32 hex characters
520
-			'messagecounter' => '',	// ULONG,     6 bytes, 12 hex characters
513
+			'providerguid' => '', // GUID,     16 bytes, 32 hex characters
514
+			'messagetype' => '', // UINT,      2 bytes,  4 hex characters
515
+			'folderdbguid' => '', // GUID,     16 bytes, 32 hex characters
516
+			'foldercounter' => '', // ULONG,     6 bytes, 12 hex characters
517
+			'padding' => '', // TCHAR[3],  2 bytes,  4 hex characters
518
+			'messagedbguid' => '', // GUID,     16 bytes, 32 hex characters
519
+			'messagecounter' => '', // ULONG,     6 bytes, 12 hex characters
521 520
 		];
522 521
 
523 522
 		if (!$entryId) {
@@ -577,12 +576,12 @@  discard block
 block discarded – undo
577 576
 		$entryId = strtoupper((string) $entryId);
578 577
 
579 578
 		$res = [
580
-			'abflags' => '',					// BYTE[4],   4 bytes,  8 hex characters
581
-			'providerguid' => '',			// GUID,     16 bytes, 32 hex characters
582
-			'foldertype' => '',				// UINT,      2 bytes,  4 hex characters
583
-			'folderdbguid' => '',			// GUID,     16 bytes, 32 hex characters
584
-			'foldercounter' => '',		// ULONG,     6 bytes, 12 hex characters
585
-			'padding' => '',					// TCHAR[3],  2 bytes,  4 hex characters
579
+			'abflags' => '', // BYTE[4],   4 bytes,  8 hex characters
580
+			'providerguid' => '', // GUID,     16 bytes, 32 hex characters
581
+			'foldertype' => '', // UINT,      2 bytes,  4 hex characters
582
+			'folderdbguid' => '', // GUID,     16 bytes, 32 hex characters
583
+			'foldercounter' => '', // ULONG,     6 bytes, 12 hex characters
584
+			'padding' => '', // TCHAR[3],  2 bytes,  4 hex characters
586 585
 		];
587 586
 
588 587
 		if (!$entryId) {
Please login to merge, or discard this patch.
server/includes/core/class.theming.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -358,7 +358,7 @@
 block discarded – undo
358 358
 
359 359
 		if ($themeProps['primary-color']) {
360 360
 			if (!$themeProps['primary-color:hover']) {
361
-				[, , $l] = Colors::rgb2hsl(Colors::colorString2Object($themeProps['primary-color']));
361
+				[,, $l] = Colors::rgb2hsl(Colors::colorString2Object($themeProps['primary-color']));
362 362
 				if ($l > 20) {
363 363
 					$themeProps['primary-color:hover'] = Colors::darker($themeProps['primary-color'], 10);
364 364
 				}
Please login to merge, or discard this patch.
server/includes/core/class.language.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -396,7 +396,7 @@  discard block
 block discarded – undo
396 396
 			if ($data_orig_strs[$i]['length'] > 0) {	// fread does not accept length=0
397 397
 				$length = $data_orig_strs[$i]['length'];
398 398
 				$orig_str = unpack('a' . $length . 'str', fread($fp, $length));
399
-				$translation_data[$i]['msgid'] = $orig_str['str'];	// unpack converts to array :S
399
+				$translation_data[$i]['msgid'] = $orig_str['str']; // unpack converts to array :S
400 400
 
401 401
 				// Find context in the original string
402 402
 				if (str_contains((string) $translation_data[$i]['msgid'], "\004")) {
@@ -423,7 +423,7 @@  discard block
 block discarded – undo
423 423
 			if ($data_transl_strs[$i]['length'] > 0) {	// fread does not accept length=0
424 424
 				$length = $data_transl_strs[$i]['length'];
425 425
 				$trans_str = unpack('a' . $length . 'str', fread($fp, $length));
426
-				$translation_data[$i]['msgstr'] = $trans_str['str'];	// unpack converts to array :S
426
+				$translation_data[$i]['msgstr'] = $trans_str['str']; // unpack converts to array :S
427 427
 
428 428
 				// If there are plural forms in the source string,
429 429
 				// then the translated string must contain plural
Please login to merge, or discard this patch.
server/includes/core/class.mapisession.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1034,7 +1034,7 @@
 block discarded – undo
1034 1034
 					// Postfix display name of every contact folder with respective owner name
1035 1035
 					// it is mandatory to keep display-name different
1036 1036
 					$userStoreProps = mapi_getprops($openedUserStore, [PR_MAILBOX_OWNER_NAME]);
1037
-					for ($i = 0,$len = count($userContactFolders); $i < $len; ++$i) {
1037
+					for ($i = 0, $len = count($userContactFolders); $i < $len; ++$i) {
1038 1038
 						$userContactFolders[$i][PR_DISPLAY_NAME] = $userContactFolders[$i][PR_DISPLAY_NAME] . " - " . $userStoreProps[PR_MAILBOX_OWNER_NAME];
1039 1039
 					}
1040 1040
 
Please login to merge, or discard this patch.
server/includes/core/constants.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -26,17 +26,17 @@
 block discarded – undo
26 26
 
27 27
 // used by distribution lists
28 28
 define("WAB_GUID", pack("H*", "C091ADD3519DCF11A4A900AA0047FAA4"));
29
-define("DL_USER", 0xC3);		//	195
30
-define("DL_USER2", 0xD3);		//	211
31
-define("DL_USER3", 0xE3);		//	227
29
+define("DL_USER", 0xC3); //	195
30
+define("DL_USER2", 0xD3); //	211
31
+define("DL_USER3", 0xE3); //	227
32 32
 /*
33 33
  * According to Exchange protocol, type property for oneoff contact
34 34
  * will be 0x00.
35 35
  */
36
-define("DL_EXTERNAL_MEMBER", 0x00);		//	0
37
-define("DL_DIST", 0xB4);		//	180
38
-define("DL_USER_AB", 0xB5);		//	181
39
-define("DL_DIST_AB", 0xB6);		//	182
36
+define("DL_EXTERNAL_MEMBER", 0x00); //	0
37
+define("DL_DIST", 0xB4); //	180
38
+define("DL_USER_AB", 0xB5); //	181
39
+define("DL_DIST_AB", 0xB6); //	182
40 40
 
41 41
 // @FIXME these needs to be changed in mapitags.php
42 42
 
Please login to merge, or discard this patch.
server/includes/util.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1003,8 +1003,7 @@
 block discarded – undo
1003 1003
 		// on the day before or after. This should be fine for all the
1004 1004
 		// timezones which do not exceed 12 hour difference to UTC.
1005 1005
 		$ts = $interval > 0 ?
1006
-			$ts - ($interval < 43200 ? $interval : $interval - 86400) :
1007
-			$ts + ($interval > -43200 ? $interval : $interval - 86400);
1006
+			$ts - ($interval < 43200 ? $interval : $interval - 86400) : $ts + ($interval > -43200 ? $interval : $interval - 86400);
1008 1007
 	}
1009 1008
 
1010 1009
 	return $ts;
Please login to merge, or discard this patch.
server/includes/modules/class.maillistmodule.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@
 block discarded – undo
87 87
 							$this->handleUnknownActionType($actionType);
88 88
 					}
89 89
 				}
90
-				catch (MAPIException|SearchException $e) {
90
+				catch (MAPIException | SearchException $e) {
91 91
 					$this->processException($e, $actionType);
92 92
 				}
93 93
 			}
Please login to merge, or discard this patch.