Test Failed
Push — master ( 6ab057...9e2699 )
by
unknown
23:26 queued 12:21
created
plugins/files/php/plugin.files.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@
 block discarded – undo
95 95
 						'notifier' => [
96 96
 							'info' => [
97 97
 								'files' => [
98
-									'value' => "dropdown",        // static notifier
98
+									'value' => "dropdown", // static notifier
99 99
 								],
100 100
 							],
101 101
 						],
Please login to merge, or discard this patch.
Switch Indentation   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -45,37 +45,37 @@
 block discarded – undo
45 45
 
46 46
 			case 'server.index.load.custom':
47 47
 				switch ($data['name']) {
48
-				case 'files_get_recipients':
49
-					RecipientHandler::doGetRecipients();
50
-					break;
48
+					case 'files_get_recipients':
49
+						RecipientHandler::doGetRecipients();
50
+						break;
51 51
 
52
-				case 'download_file':
53
-					DownloadHandler::doDownload();
54
-					break;
52
+					case 'download_file':
53
+						DownloadHandler::doDownload();
54
+						break;
55 55
 
56
-				case 'upload_file':
57
-					UploadHandler::doUpload();
58
-					break;
56
+					case 'upload_file':
57
+						UploadHandler::doUpload();
58
+						break;
59 59
 
60
-				case 'form':
61
-					if (isset($_GET['backend'])) {
62
-						$backend = urldecode($_GET["backend"]);
63
-					}
64
-					else {
65
-						$backend = '';
66
-					}
67
-					$backendstore = Files\Backend\BackendStore::getInstance();
60
+					case 'form':
61
+						if (isset($_GET['backend'])) {
62
+							$backend = urldecode($_GET["backend"]);
63
+						}
64
+						else {
65
+							$backend = '';
66
+						}
67
+						$backendstore = Files\Backend\BackendStore::getInstance();
68 68
 
69
-					if ($backendstore->backendExists($backend)) {
70
-						$backendInstance = $backendstore->getInstanceOfBackend($backend);
71
-						$formdata = $backendInstance->getFormConfig();
69
+						if ($backendstore->backendExists($backend)) {
70
+							$backendInstance = $backendstore->getInstanceOfBackend($backend);
71
+							$formdata = $backendInstance->getFormConfig();
72 72
 
73
-						exit($formdata);
74
-					}
73
+							exit($formdata);
74
+						}
75 75
 
76
-						exit("Specified backend does not exist!");
76
+							exit("Specified backend does not exist!");
77 77
 
78
-					break;
78
+						break;
79 79
 			}
80 80
 			break;
81 81
 		}
Please login to merge, or discard this patch.
plugins/files/php/Files/Backend/class.backendstore.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 	 * Search the backend folder for backends and register them.
61 61
 	 */
62 62
 	public function initialize() {
63
-		$list = [];    // this hold our plugin folders
63
+		$list = []; // this hold our plugin folders
64 64
 		$workdir = __DIR__ . self::BACKEND_DIR;
65 65
 
66 66
 		// Populate the list of directories to check against
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 	 * Search the backend folder for external backends and register them.
88 88
 	 */
89 89
 	public function initializeExternal() {
90
-		$list = [];    // this hold our plugin folders
90
+		$list = []; // this hold our plugin folders
91 91
 		$workdir = $this->EXTERNAL_BACKEND_DIR;
92 92
 
93 93
 		// Populate the list of directories to check against
Please login to merge, or discard this patch.
plugins/files/php/Files/Backend/Webdav/class.backend.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -191,7 +191,7 @@
 block discarded – undo
191 191
 				"fields" => $this->formFields,
192 192
 				"formConfig" => $this->formConfig,
193 193
 			],
194
-			"data" => [ // here we can specify the default values.
194
+			"data" => [// here we can specify the default values.
195 195
 				"server_address" => "files.demo.com",
196 196
 				"server_port" => "80",
197 197
 				"server_path" => "/remote.php/webdav",
Please login to merge, or discard this patch.
plugins/filesbackendOwncloud/php/class.backend.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@
 block discarded – undo
136 136
 				"fields" => $this->formFields,
137 137
 				"formConfig" => $this->formConfig,
138 138
 			],
139
-			"data" => [ // here we can specify the default values.
139
+			"data" => [// here we can specify the default values.
140 140
 				"server_address" => $_SERVER['HTTP_HOST'],
141 141
 				"server_ssl" => true,
142 142
 				"server_port" => "443",
Please login to merge, or discard this patch.
plugins/smime/php/lib/Nemid.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -445,7 +445,7 @@
 block discarded – undo
445 445
 
446 446
 	public static function my_rsa_sha_encode($data, $key_id, $signagure_alg) {
447 447
 		$algos = [
448
-			'sha1WithRSAEncryption' => ['alg' => 'sha1',   'oid' => '1.3.14.3.2.26'],
448
+			'sha1WithRSAEncryption' => ['alg' => 'sha1', 'oid' => '1.3.14.3.2.26'],
449 449
 			'sha256WithRSAEncryption' => ['alg' => 'sha256', 'oid' => '2.16.840.1.101.3.4.2.1'],
450 450
 			'sha384WithRSAEncryption' => ['alg' => 'sha384', 'oid' => '2.16.840.1.101.3.4.2.2'],
451 451
 			'sha512WithRSAEncryption' => ['alg' => 'sha512', 'oid' => '2.16.840.1.101.3.4.2.3'],
Please login to merge, or discard this patch.
plugins/smime/php/lib/Der.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -212,7 +212,7 @@
 block discarded – undo
212 212
 	}
213 213
 
214 214
 	protected function name($tag = null) {
215
-		$this->beginsequence($tag);  # seq of RDN
215
+		$this->beginsequence($tag); # seq of RDN
216 216
 		$res = [];
217 217
 		while ($this->in()) {
218 218
 			$parts = [];
Please login to merge, or discard this patch.
plugins/smime/php/plugin.smime.php 4 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -454,7 +454,7 @@
 block discarded – undo
454 454
 		}
455 455
 
456 456
 		if (!encryptionStoreExpirationSupport()) {
457
-			withPHPSession(function () use ($encryptionStore) {
457
+			withPHPSession(function() use ($encryptionStore) {
458 458
 				$encryptionStore->add('smime', '');
459 459
 			});
460 460
 		}
Please login to merge, or discard this patch.
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -163,9 +163,9 @@  discard block
 block discarded – undo
163 163
 		$messageClass = mapi_getprops($message, [PR_MESSAGE_CLASS]);
164 164
 		$messageClass = $messageClass[PR_MESSAGE_CLASS];
165 165
 		if ($messageClass !== 'IPM.Note.SMIME' &&
166
-		    $messageClass !== 'IPM.Note.SMIME.SignedEncrypt' &&
167
-		    $messageClass !== 'IPM.Note.deferSMIME' &&
168
-		    $messageClass !== 'IPM.Note.deferSMIME.SignedEncrypt')
166
+			$messageClass !== 'IPM.Note.SMIME.SignedEncrypt' &&
167
+			$messageClass !== 'IPM.Note.deferSMIME' &&
168
+			$messageClass !== 'IPM.Note.deferSMIME.SignedEncrypt')
169 169
 			return;
170 170
 
171 171
 		$recipients = $data['action']['props']['smime'];
@@ -607,17 +607,17 @@  discard block
 block discarded – undo
607 607
 		if (!isset($messageClass))
608 608
 			return;
609 609
 		if (stripos($messageClass, 'IPM.Note.deferSMIME') === false &&
610
-		    stripos($messageClass, 'IPM.Note.SMIME') === false)
610
+			stripos($messageClass, 'IPM.Note.SMIME') === false)
611 611
 			return;
612 612
 
613 613
 		// FIXME: for now return when we are going to sign but we don't have the passphrase set
614 614
 		// This should never happen sign
615 615
 		$encryptionStore = \EncryptionStore::getInstance();
616 616
 		if (($messageClass === 'IPM.Note.deferSMIME.SignedEncrypt' ||
617
-		    $messageClass === 'IPM.Note.deferSMIME.MultipartSigned' ||
618
-		    $messageClass === 'IPM.Note.SMIME.SignedEncrypt' ||
619
-		    $messageClass === 'IPM.Note.SMIME.MultipartSigned') &&
620
-		    !$encryptionStore->get('smime'))
617
+			$messageClass === 'IPM.Note.deferSMIME.MultipartSigned' ||
618
+			$messageClass === 'IPM.Note.SMIME.SignedEncrypt' ||
619
+			$messageClass === 'IPM.Note.SMIME.MultipartSigned') &&
620
+			!$encryptionStore->get('smime'))
621 621
 			return;
622 622
 		// NOTE: setting message class to IPM.Note, so that mapi_inetmapi_imtoinet converts the message to plain email
623 623
 		// and doesn't fail when handling the attachments.
Please login to merge, or discard this patch.
Switch Indentation   +56 added lines, -56 removed lines patch added patch discarded remove patch
@@ -92,45 +92,45 @@  discard block
 block discarded – undo
92 92
 	public function execute($eventID, &$data) {
93 93
 		switch ($eventID) {
94 94
 		// Register plugin
95
-		case 'server.core.settings.init.before':
96
-			$this->onBeforeSettingsInit($data);
97
-			break;
98
-		// Verify a signed or encrypted message when an email is opened
99
-		case 'server.util.parse_smime.signed':
100
-			$this->onSignedMessage($data);
101
-			break;
102
-
103
-		case 'server.util.parse_smime.encrypted':
104
-			$this->onEncrypted($data);
105
-			break;
106
-		// Add S/MIME property, which is send to the client
107
-		case 'server.module.itemmodule.open.after':
108
-			$this->onAfterOpen($data);
109
-			break;
110
-		// Catch uploaded certificate
111
-		case 'server.upload_attachment.upload':
112
-			$this->onUploadCertificate($data);
113
-			break;
114
-		// Sign email before sending
115
-		case 'server.core.operations.submitmessage':
116
-			$this->onBeforeSend($data);
117
-			break;
118
-		// Verify that we have public certificates for all recipients
119
-		case 'server.module.createmailitemmodule.beforesend':
120
-			$this->onCertificateCheck($data);
121
-			break;
122
-
123
-		case 'server.index.load.custom':
124
-			if ($data['name'] === 'smime_passphrase') {
125
-				include 'templates/passphrase.tpl.php';
126
-				exit();
127
-			}
128
-			if ($data['name'] === 'smime_passphrasecheck') {
129
-				// No need to do anything, this is just used to trigger
130
-				// the browser's autofill save password dialog.
131
-				exit();
132
-			}
133
-			break;
95
+			case 'server.core.settings.init.before':
96
+				$this->onBeforeSettingsInit($data);
97
+				break;
98
+			// Verify a signed or encrypted message when an email is opened
99
+			case 'server.util.parse_smime.signed':
100
+				$this->onSignedMessage($data);
101
+				break;
102
+
103
+			case 'server.util.parse_smime.encrypted':
104
+				$this->onEncrypted($data);
105
+				break;
106
+			// Add S/MIME property, which is send to the client
107
+			case 'server.module.itemmodule.open.after':
108
+				$this->onAfterOpen($data);
109
+				break;
110
+			// Catch uploaded certificate
111
+			case 'server.upload_attachment.upload':
112
+				$this->onUploadCertificate($data);
113
+				break;
114
+			// Sign email before sending
115
+			case 'server.core.operations.submitmessage':
116
+				$this->onBeforeSend($data);
117
+				break;
118
+			// Verify that we have public certificates for all recipients
119
+			case 'server.module.createmailitemmodule.beforesend':
120
+				$this->onCertificateCheck($data);
121
+				break;
122
+
123
+			case 'server.index.load.custom':
124
+				if ($data['name'] === 'smime_passphrase') {
125
+					include 'templates/passphrase.tpl.php';
126
+					exit();
127
+				}
128
+				if ($data['name'] === 'smime_passphrasecheck') {
129
+					// No need to do anything, this is just used to trigger
130
+					// the browser's autofill save password dialog.
131
+					exit();
132
+				}
133
+				break;
134 134
 		}
135 135
 	}
136 136
 
@@ -663,23 +663,23 @@  discard block
 block discarded – undo
663 663
 
664 664
 		// Sign then Encrypt email
665 665
 		switch ($messageClass) {
666
-		case 'IPM.Note.deferSMIME.SignedEncrypt':
667
-		case 'IPM.Note.SMIME.SignedEncrypt':
668
-			$tmpFile = tempnam(sys_get_temp_dir(), true);
669
-			$this->sign($tmpSendEmail, $tmpFile, $message, $signedAttach, $smimeProps);
670
-			$this->encrypt($tmpFile, $tmpSendSmimeEmail, $message, $signedAttach, $smimeProps);
671
-			unlink($tmpFile);
672
-			break;
673
-
674
-		case 'IPM.Note.deferSMIME.MultipartSigned':
675
-		case 'IPM.Note.SMIME.MultipartSigned':
676
-			$this->sign($tmpSendEmail, $tmpSendSmimeEmail, $message, $signedAttach, $smimeProps);
677
-			break;
678
-
679
-		case 'IPM.Note.deferSMIME':
680
-		case 'IPM.Note.SMIME':
681
-			$this->encrypt($tmpSendEmail, $tmpSendSmimeEmail, $message, $signedAttach, $smimeProps);
682
-			break;
666
+			case 'IPM.Note.deferSMIME.SignedEncrypt':
667
+			case 'IPM.Note.SMIME.SignedEncrypt':
668
+				$tmpFile = tempnam(sys_get_temp_dir(), true);
669
+				$this->sign($tmpSendEmail, $tmpFile, $message, $signedAttach, $smimeProps);
670
+				$this->encrypt($tmpFile, $tmpSendSmimeEmail, $message, $signedAttach, $smimeProps);
671
+				unlink($tmpFile);
672
+				break;
673
+
674
+			case 'IPM.Note.deferSMIME.MultipartSigned':
675
+			case 'IPM.Note.SMIME.MultipartSigned':
676
+				$this->sign($tmpSendEmail, $tmpSendSmimeEmail, $message, $signedAttach, $smimeProps);
677
+				break;
678
+
679
+			case 'IPM.Note.deferSMIME':
680
+			case 'IPM.Note.SMIME':
681
+				$this->encrypt($tmpSendEmail, $tmpSendSmimeEmail, $message, $signedAttach, $smimeProps);
682
+				break;
683 683
 		}
684 684
 
685 685
 		// Save the signed message as attachment of the send email
Please login to merge, or discard this patch.
Braces   +27 added lines, -18 removed lines patch added patch discarded remove patch
@@ -165,8 +165,9 @@  discard block
 block discarded – undo
165 165
 		if ($messageClass !== 'IPM.Note.SMIME' &&
166 166
 		    $messageClass !== 'IPM.Note.SMIME.SignedEncrypt' &&
167 167
 		    $messageClass !== 'IPM.Note.deferSMIME' &&
168
-		    $messageClass !== 'IPM.Note.deferSMIME.SignedEncrypt')
169
-			return;
168
+		    $messageClass !== 'IPM.Note.deferSMIME.SignedEncrypt') {
169
+					return;
170
+		}
170 171
 
171 172
 		$recipients = $data['action']['props']['smime'];
172 173
 		$missingCerts = [];
@@ -300,8 +301,9 @@  discard block
 block discarded – undo
300 301
 				$importCert = file_get_contents($outcert);
301 302
 				$parsedImportCert = openssl_x509_parse($importCert);
302 303
 				$parsedUserCert = openssl_x509_parse($userCert);
303
-				if (!$signed_ok || $openssl_error_code === OPENSSL_CA_VERIFY_FAIL)
304
-					continue;
304
+				if (!$signed_ok || $openssl_error_code === OPENSSL_CA_VERIFY_FAIL) {
305
+									continue;
306
+				}
305 307
 
306 308
 				// CA Checks out
307 309
 				$caCerts = $this->extractCAs($tmpfname);
@@ -528,8 +530,9 @@  discard block
 block discarded – undo
528 530
 	 * @param {mixed} $data
529 531
 	 */
530 532
 	public function onUploadCertificate($data) {
531
-		if ($data['sourcetype'] !== 'certificate')
532
-			return;
533
+		if ($data['sourcetype'] !== 'certificate') {
534
+					return;
535
+		}
533 536
 		$passphrase = $_POST['passphrase'];
534 537
 		$saveCert = false;
535 538
 		$tmpname = $data['tmpname'];
@@ -604,11 +607,13 @@  discard block
 block discarded – undo
604 607
 		$props = mapi_getprops($message, [PR_MESSAGE_CLASS]);
605 608
 		$messageClass = $props[PR_MESSAGE_CLASS];
606 609
 
607
-		if (!isset($messageClass))
608
-			return;
610
+		if (!isset($messageClass)) {
611
+					return;
612
+		}
609 613
 		if (stripos($messageClass, 'IPM.Note.deferSMIME') === false &&
610
-		    stripos($messageClass, 'IPM.Note.SMIME') === false)
611
-			return;
614
+		    stripos($messageClass, 'IPM.Note.SMIME') === false) {
615
+					return;
616
+		}
612 617
 
613 618
 		// FIXME: for now return when we are going to sign but we don't have the passphrase set
614 619
 		// This should never happen sign
@@ -617,8 +622,9 @@  discard block
 block discarded – undo
617 622
 		    $messageClass === 'IPM.Note.deferSMIME.MultipartSigned' ||
618 623
 		    $messageClass === 'IPM.Note.SMIME.SignedEncrypt' ||
619 624
 		    $messageClass === 'IPM.Note.SMIME.MultipartSigned') &&
620
-		    !$encryptionStore->get('smime'))
621
-			return;
625
+		    !$encryptionStore->get('smime')) {
626
+					return;
627
+		}
622 628
 		// NOTE: setting message class to IPM.Note, so that mapi_inetmapi_imtoinet converts the message to plain email
623 629
 		// and doesn't fail when handling the attachments.
624 630
 		mapi_setprops($message, [PR_MESSAGE_CLASS => 'IPM.Note']);
@@ -862,8 +868,9 @@  discard block
 block discarded – undo
862 868
 			foreach ($certs as $cert) {
863 869
 				$pubkey = mapi_msgstore_openentry($this->getStore(), $cert[PR_ENTRYID]);
864 870
 				$certificate = "";
865
-				if ($pubkey == false)
866
-					continue;
871
+				if ($pubkey == false) {
872
+									continue;
873
+				}
867 874
 				// retrieve pkcs#11 certificate from body
868 875
 				$stream = mapi_openproperty($pubkey, PR_BODY, IID_IStream, 0, 0);
869 876
 				$stat = mapi_stream_stat($stream);
@@ -985,8 +992,9 @@  discard block
 block discarded – undo
985 992
 	 */
986 993
 	public function importCertificate($cert, $certData, $type = 'public', $force = false) {
987 994
 		$certEmail = getCertEmail($certData);
988
-		if ($this->pubcertExists($certEmail) && !$force && $type !== 'private')
989
-			return;
995
+		if ($this->pubcertExists($certEmail) && !$force && $type !== 'private') {
996
+					return;
997
+		}
990 998
 		$issued_by = "";
991 999
 		foreach (array_keys($certData['issuer']) as $key) {
992 1000
 			$issued_by .= $key . '=' . $certData['issuer'][$key] . "\n";
@@ -1110,8 +1118,9 @@  discard block
 block discarded – undo
1110 1118
 	 * @return array with properties
1111 1119
 	 */
1112 1120
 	public function getSenderAddress($mapiMessage) {
1113
-		if (method_exists($GLOBALS['operations'], 'getSenderAddress'))
1114
-			return $GLOBALS["operations"]->getSenderAddress($mapiMessage);
1121
+		if (method_exists($GLOBALS['operations'], 'getSenderAddress')) {
1122
+					return $GLOBALS["operations"]->getSenderAddress($mapiMessage);
1123
+		}
1115 1124
 
1116 1125
 		$messageProps = mapi_getprops($mapiMessage, [PR_SENT_REPRESENTING_ENTRYID, PR_SENDER_ENTRYID]);
1117 1126
 		$senderEntryID = isset($messageProps[PR_SENT_REPRESENTING_ENTRYID]) ? $messageProps[PR_SENT_REPRESENTING_ENTRYID] : $messageProps[PR_SENDER_ENTRYID];
Please login to merge, or discard this patch.
server/includes/modules/class.contactitemmodule.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 		 * @return bool true on success or false on failure
109 109
 		 */
110 110
 		public function save($store, $parententryid, $entryid, $action) {
111
-			$properiesToDelete = [];		// create an array of properties which should be deleted
111
+			$properiesToDelete = []; // create an array of properties which should be deleted
112 112
 			// this array is passed to $GLOBALS['operations']->saveMessage() function
113 113
 
114 114
 			if (!$store && !$parententryid) {
@@ -449,7 +449,7 @@  discard block
 block discarded – undo
449 449
 
450 450
 			// UTC time
451 451
 			$startDateUTC = $actionProps[$type];
452
-			$dueDateUTC = $actionProps[$type] + (24 * 60 * 60);	// ONE DAY is added to set duedate of item.
452
+			$dueDateUTC = $actionProps[$type] + (24 * 60 * 60); // ONE DAY is added to set duedate of item.
453 453
 
454 454
 			// get local time from UTC time
455 455
 			$recur = new Recurrence($store, []);
Please login to merge, or discard this patch.
server/includes/modules/class.suggestemailaddressmodule.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -122,8 +122,8 @@
 block discarded – undo
122 122
 		if (!empty($action["query"]) && !empty($recipient_history) && !empty($recipient_history['recipients'])) {
123 123
 			// Setup result array with match levels
124 124
 			$l_aResult = [
125
-				0 => [],	// Matches on whole string
126
-				1 => [],	// Matches on part of string
125
+				0 => [], // Matches on whole string
126
+				1 => [], // Matches on part of string
127 127
 			];
128 128
 
129 129
 			// Loop through all the recipients
Please login to merge, or discard this patch.