Passed
Push — 45-mixed-bag-of-php-modernizat... ( 2062ef )
by
unknown
09:06
created
lib/request/request.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@  discard block
 block discarded – undo
8 8
  */
9 9
 
10 10
 class Request {
11
-	public const MAXMEMORYUSAGE = 0.9;     // use max. 90% of allowed memory when syncing
11
+	public const MAXMEMORYUSAGE = 0.9; // use max. 90% of allowed memory when syncing
12 12
 	public const UNKNOWN = "unknown";
13 13
 	public const IMPERSONATE_DELIM = '#';
14 14
 
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
198 198
 		else {
199 199
 			preg_replace_callback(
200 200
 				'/(\-?\d+)(.?)/',
201
-				function ($m) {
201
+				function($m) {
202 202
 					self::$memoryLimit = $m[1] * pow(1024, strpos('BKMG', $m[2])) * self::MAXMEMORYUSAGE;
203 203
 				},
204 204
 				strtoupper($memoryLimit)
Please login to merge, or discard this patch.
mapi/class.meetingrequest.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -152,15 +152,15 @@  discard block
 block discarded – undo
152 152
 		$properties['reminderminutes'] = 'PT_LONG:PSETID_Common:0x8501';
153 153
 		$properties['reminderset'] = 'PT_BOOLEAN:PSETID_Common:0x8503';
154 154
 		$properties['sendasical'] = 'PT_BOOLEAN:PSETID_Appointment:0x8200';
155
-		$properties['updatecounter'] = 'PT_LONG:PSETID_Appointment:0x8201';                    // AppointmentSequenceNumber
156
-		$properties['last_updatecounter'] = 'PT_LONG:PSETID_Appointment:0x8203';            // AppointmentLastSequence
155
+		$properties['updatecounter'] = 'PT_LONG:PSETID_Appointment:0x8201'; // AppointmentSequenceNumber
156
+		$properties['last_updatecounter'] = 'PT_LONG:PSETID_Appointment:0x8203'; // AppointmentLastSequence
157 157
 		$properties['unknown7'] = 'PT_LONG:PSETID_Appointment:0x8202';
158 158
 		$properties['busystatus'] = 'PT_LONG:PSETID_Appointment:0x8205';
159 159
 		$properties['intendedbusystatus'] = 'PT_LONG:PSETID_Appointment:0x8224';
160 160
 		$properties['start'] = 'PT_SYSTIME:PSETID_Appointment:0x820d';
161 161
 		$properties['responselocation'] = 'PT_STRING8:PSETID_Meeting:0x2';
162 162
 		$properties['location'] = 'PT_STRING8:PSETID_Appointment:0x8208';
163
-		$properties['requestsent'] = 'PT_BOOLEAN:PSETID_Appointment:0x8229';        // PidLidFInvited, MeetingRequestWasSent
163
+		$properties['requestsent'] = 'PT_BOOLEAN:PSETID_Appointment:0x8229'; // PidLidFInvited, MeetingRequestWasSent
164 164
 		$properties['startdate'] = 'PT_SYSTIME:PSETID_Appointment:0x820d';
165 165
 		$properties['duedate'] = 'PT_SYSTIME:PSETID_Appointment:0x820e';
166 166
 		$properties['flagdueby'] = 'PT_SYSTIME:PSETID_Common:0x8560';
@@ -169,11 +169,11 @@  discard block
 block discarded – undo
169 169
 		$properties['recurring'] = 'PT_BOOLEAN:PSETID_Appointment:0x8223';
170 170
 		$properties['clipstart'] = 'PT_SYSTIME:PSETID_Appointment:0x8235';
171 171
 		$properties['clipend'] = 'PT_SYSTIME:PSETID_Appointment:0x8236';
172
-		$properties['start_recur_date'] = 'PT_LONG:PSETID_Meeting:0xD';                // StartRecurTime
173
-		$properties['start_recur_time'] = 'PT_LONG:PSETID_Meeting:0xE';                // StartRecurTime
174
-		$properties['end_recur_date'] = 'PT_LONG:PSETID_Meeting:0xF';                // EndRecurDate
175
-		$properties['end_recur_time'] = 'PT_LONG:PSETID_Meeting:0x10';                // EndRecurTime
176
-		$properties['is_exception'] = 'PT_BOOLEAN:PSETID_Meeting:0xA';                // LID_IS_EXCEPTION
172
+		$properties['start_recur_date'] = 'PT_LONG:PSETID_Meeting:0xD'; // StartRecurTime
173
+		$properties['start_recur_time'] = 'PT_LONG:PSETID_Meeting:0xE'; // StartRecurTime
174
+		$properties['end_recur_date'] = 'PT_LONG:PSETID_Meeting:0xF'; // EndRecurDate
175
+		$properties['end_recur_time'] = 'PT_LONG:PSETID_Meeting:0x10'; // EndRecurTime
176
+		$properties['is_exception'] = 'PT_BOOLEAN:PSETID_Meeting:0xA'; // LID_IS_EXCEPTION
177 177
 		$properties['apptreplyname'] = 'PT_STRING8:PSETID_Appointment:0x8230';
178 178
 		// Propose new time properties
179 179
 		$properties['proposed_start_whole'] = 'PT_SYSTIME:PSETID_Appointment:0x8250';
@@ -545,7 +545,7 @@  discard block
 block discarded – undo
545 545
 		$listProperties['rcvd_representing_search_key'] = PR_RCVD_REPRESENTING_SEARCH_KEY;
546 546
 		$messageProps = mapi_getprops($this->message, $listProperties);
547 547
 
548
-		$goid = $messageProps[$this->proptags['goid']];    // GlobalID (0x3)
548
+		$goid = $messageProps[$this->proptags['goid']]; // GlobalID (0x3)
549 549
 		if (!isset($goid)) {
550 550
 			return;
551 551
 		}
@@ -1443,7 +1443,7 @@  discard block
 block discarded – undo
1443 1443
 		$props[$this->proptags['goid2']] = $goid;
1444 1444
 
1445 1445
 		if (!isset($props[$this->proptags['updatecounter']])) {
1446
-			$props[$this->proptags['updatecounter']] = 0;            // OL also starts sequence no with zero.
1446
+			$props[$this->proptags['updatecounter']] = 0; // OL also starts sequence no with zero.
1447 1447
 			$props[$this->proptags['last_updatecounter']] = 0;
1448 1448
 		}
1449 1449
 
@@ -2498,7 +2498,7 @@  discard block
 block discarded – undo
2498 2498
 				[
2499 2499
 					RES_PROPERTY,
2500 2500
 					[
2501
-						RELOP => RELOP_EQ,    // Equals recipient type 3: Resource
2501
+						RELOP => RELOP_EQ, // Equals recipient type 3: Resource
2502 2502
 						ULPROPTAG => PR_RECIPIENT_TYPE,
2503 2503
 						VALUE => [PR_RECIPIENT_TYPE => MAPI_BCC],
2504 2504
 					],
@@ -2780,7 +2780,7 @@  discard block
 block discarded – undo
2780 2780
 				[
2781 2781
 					RES_PROPERTY,
2782 2782
 					[
2783
-						RELOP => RELOP_EQ,    // Equals recipient type 3: Resource
2783
+						RELOP => RELOP_EQ, // Equals recipient type 3: Resource
2784 2784
 						ULPROPTAG => PR_RECIPIENT_TYPE,
2785 2785
 						VALUE => [PR_RECIPIENT_TYPE => MAPI_BCC],
2786 2786
 					],
@@ -3012,7 +3012,7 @@  discard block
 block discarded – undo
3012 3012
 				$restriction[1][] = [
3013 3013
 					RES_PROPERTY,
3014 3014
 					[
3015
-						RELOP => RELOP_NE,    // Does not equal recipient type: MAPI_BCC (Resource)
3015
+						RELOP => RELOP_NE, // Does not equal recipient type: MAPI_BCC (Resource)
3016 3016
 						ULPROPTAG => PR_RECIPIENT_TYPE,
3017 3017
 						VALUE => [PR_RECIPIENT_TYPE => MAPI_BCC],
3018 3018
 					],
@@ -3109,7 +3109,7 @@  discard block
 block discarded – undo
3109 3109
 									[
3110 3110
 										RES_PROPERTY,
3111 3111
 										[
3112
-											RELOP => RELOP_NE,    // Does not equal recipient type: MAPI_BCC (Resource)
3112
+											RELOP => RELOP_NE, // Does not equal recipient type: MAPI_BCC (Resource)
3113 3113
 											ULPROPTAG => PR_RECIPIENT_TYPE,
3114 3114
 											VALUE => [PR_RECIPIENT_TYPE => MAPI_BCC],
3115 3115
 										],
@@ -3216,7 +3216,7 @@  discard block
 block discarded – undo
3216 3216
 			$newmessageprops[PR_MESSAGE_CLASS] = 'IPM.Schedule.Meeting.Canceled';
3217 3217
 			$newmessageprops[$this->proptags['meetingstatus']] = olMeetingCanceled; // It's a cancel request
3218 3218
 			$newmessageprops[$this->proptags['busystatus']] = fbFree; // set the busy status as free
3219
-			$newmessageprops[PR_IMPORTANCE] = IMPORTANCE_HIGH;    // HIGH Importance
3219
+			$newmessageprops[PR_IMPORTANCE] = IMPORTANCE_HIGH; // HIGH Importance
3220 3220
 			if (isset($newmessageprops[PR_SUBJECT])) {
3221 3221
 				$newmessageprops[PR_SUBJECT] = _('Canceled: ') . $newmessageprops[PR_SUBJECT];
3222 3222
 			}
Please login to merge, or discard this patch.
lib/grommunio/mapiutils.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
 					],
143 143
 				], // EXISTS OR
144 144
 			],
145
-		];        // global OR
145
+		]; // global OR
146 146
 	}
147 147
 
148 148
 	/**
@@ -779,13 +779,13 @@  discard block
 block discarded – undo
779 779
 		$entryId = strtoupper($entryid);
780 780
 
781 781
 		$res = [
782
-			'abFlags' => '',  // BYTE[4],  4 bytes,  8 hex characters
783
-			'guid' => '',  // GUID,    16 bytes, 32 hex characters
784
-			'version' => '',  // ULONG,    4 bytes,  8 hex characters
785
-			'type' => '',  // ULONG,    4 bytes,  8 hex characters
786
-			'id' => '',  // ULONG,    4 bytes,  8 hex characters
787
-			'server' => '',  // CHAR,    variable length
788
-			'padding' => '',  // TCHAR[3], 4 bytes,  8 hex characters (upto 4 bytes)
782
+			'abFlags' => '', // BYTE[4],  4 bytes,  8 hex characters
783
+			'guid' => '', // GUID,    16 bytes, 32 hex characters
784
+			'version' => '', // ULONG,    4 bytes,  8 hex characters
785
+			'type' => '', // ULONG,    4 bytes,  8 hex characters
786
+			'id' => '', // ULONG,    4 bytes,  8 hex characters
787
+			'server' => '', // CHAR,    variable length
788
+			'padding' => '', // TCHAR[3], 4 bytes,  8 hex characters (upto 4 bytes)
789 789
 		];
790 790
 
791 791
 		$res['length'] = strlen($entryId);
@@ -830,13 +830,13 @@  discard block
 block discarded – undo
830 830
 		$entryId = strtoupper($entryid);
831 831
 
832 832
 		$res = [
833
-			'abFlags' => '',  // BYTE[4],  4 bytes,  8 hex characters
834
-			'guid' => '',  // GUID,    16 bytes, 32 hex characters
835
-			'version' => '',  // ULONG,    4 bytes,  8 hex characters
836
-			'type' => '',  // ULONG,    4 bytes,  8 hex characters
837
-			'uniqueId' => '',  // ULONG,   16 bytes,  32 hex characters
838
-			'server' => '',  // CHAR,    variable length
839
-			'padding' => '',  // TCHAR[3], 4 bytes,  8 hex characters (upto 4 bytes)
833
+			'abFlags' => '', // BYTE[4],  4 bytes,  8 hex characters
834
+			'guid' => '', // GUID,    16 bytes, 32 hex characters
835
+			'version' => '', // ULONG,    4 bytes,  8 hex characters
836
+			'type' => '', // ULONG,    4 bytes,  8 hex characters
837
+			'uniqueId' => '', // ULONG,   16 bytes,  32 hex characters
838
+			'server' => '', // CHAR,    variable length
839
+			'padding' => '', // TCHAR[3], 4 bytes,  8 hex characters (upto 4 bytes)
840 840
 		];
841 841
 
842 842
 		$res['length'] = strlen($entryId);
Please login to merge, or discard this patch.
lib/grommunio/grommunio.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1372,8 +1372,7 @@
 block discarded – undo
1372 1372
 
1373 1373
 		// if the search range is set limit the result to it, otherwise return all found messages
1374 1374
 		$rows = (is_array($searchRange) && isset($searchRange[0], $searchRange[1])) ?
1375
-			mapi_table_queryrows($table, [PR_ENTRYID], $searchRange[0], $searchRange[1] - $searchRange[0] + 1) :
1376
-			mapi_table_queryrows($table, [PR_ENTRYID], 0, SEARCH_MAXRESULTS);
1375
+			mapi_table_queryrows($table, [PR_ENTRYID], $searchRange[0], $searchRange[1] - $searchRange[0] + 1) : mapi_table_queryrows($table, [PR_ENTRYID], 0, SEARCH_MAXRESULTS);
1377 1376
 
1378 1377
 		$cnt = count($rows);
1379 1378
 		$items['searchtotal'] = $cnt;
Please login to merge, or discard this patch.