Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
12 | class Mission extends Game implements ServiceManagerAwareInterface |
||
13 | { |
||
14 | |||
15 | /** |
||
16 | * @var MissionMapperInterface |
||
17 | */ |
||
18 | protected $missionMapper; |
||
19 | |||
20 | /** |
||
21 | * @var MissionGameMapperInterface |
||
22 | */ |
||
23 | protected $missionGameMapper; |
||
24 | |||
25 | protected $options; |
||
26 | |||
27 | /** |
||
28 | * Find games associated to a mission and add the last entry of the user if it exists |
||
29 | * @param unknown $mission |
||
30 | * @return multitype:NULL |
||
|
|||
31 | */ |
||
32 | public function getMissionGames($mission, $user) |
||
44 | |||
45 | /** |
||
46 | * findMissionGameByMission : find associated games to a mission |
||
47 | * @param Mission $mission |
||
48 | * |
||
49 | * @return Collection de MissionGame $missionGames |
||
50 | */ |
||
51 | public function findGamesByMission($mission) |
||
55 | |||
56 | View Code Duplication | public function checkMissionCondition($game, $winner, $prediction, $entry) |
|
125 | |||
126 | public function getGameEntity() |
||
130 | |||
131 | /** |
||
132 | * getMissionMapper |
||
133 | * |
||
134 | * @return MissionMapperInterface |
||
135 | */ |
||
136 | public function getMissionMapper() |
||
144 | |||
145 | /** |
||
146 | * setMissionMapper |
||
147 | * |
||
148 | * @param MissionMapperInterface $missionMapper |
||
149 | * @return Mission |
||
150 | */ |
||
151 | public function setMissionMapper($missionMapper) |
||
157 | |||
158 | /** |
||
159 | * getMissionGameMapper |
||
160 | * |
||
161 | * @return MissionGameMapperInterface |
||
162 | */ |
||
163 | View Code Duplication | public function getMissionGameMapper() |
|
171 | |||
172 | /** |
||
173 | * setMissionMapper |
||
174 | * |
||
175 | * @param MissionMapperInterface $missionGameMapper |
||
176 | * @return Mission |
||
177 | */ |
||
178 | public function setMissionGameMapper($missionGameMapper) |
||
184 | } |
||
185 |
This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types.