Graze\UniControllerClient\Test\Unit\EntityHydratorTest::testHydrate()

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function testHydrate()
    {
        $entity = m::mock(EntityInterface::class);
        $entity->property1 = 'not hydrated';

Accessing property1 on the interface Mockery\MockInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $hydrator = new EntityHydrator();
        $entity = $hydrator->hydrate($entity, ['property1' => 'hydrated']);

$entity of type Mockery\MockInterface is incompatible with the type Graze\UnicontrollerClient\Entity\Entity\EntityInterface expected by parameter $entity of Graze\UnicontrollerClient\Entity\EntityHydrator::hydrate().

        $this->assertInstanceOf(EntityInterface::class, $entity);
        $this->assertEquals('hydrated', $entity->property1);

Accessing property1 on the interface Graze\UnicontrollerClient\Entity\Entity\EntityInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    }