Graze\UniControllerClient\Test\Unit\EntityHydratorTest

Complexity

Total Complexity

1

Size/Duplication

Total Lines	12
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	testHydrate()	0	10	1

<?php

/**
 * This file is part of graze/unicontroller-client.
 *
 * Copyright (c) 2016 Nature Delivered Ltd. <https://www.graze.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @license https://github.com/graze/unicontroller-client/blob/master/LICENSE.md
 * @link https://github.com/graze/unicontroller-client
 */

namespace Graze\UniControllerClient\Test\Unit;

use Mockery as m;
use Graze\UnicontrollerClient\Entity\EntityHydrator;
use Graze\UnicontrollerClient\Entity\Entity\EntityInterface;

class EntityHydratorTest extends \PHPUnit_Framework_TestCase
{
    public function testHydrate()
    {
        $entity = m::mock(EntityInterface::class);
        $entity->property1 = 'not hydrated';

Accessing property1 on the interface Mockery\MockInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $hydrator = new EntityHydrator();
        $entity = $hydrator->hydrate($entity, ['property1' => 'hydrated']);

$entity of type Mockery\MockInterface is incompatible with the type Graze\UnicontrollerClient\Entity\Entity\EntityInterface expected by parameter $entity of Graze\UnicontrollerClient\Entity\EntityHydrator::hydrate().

        $this->assertInstanceOf(EntityInterface::class, $entity);
        $this->assertEquals('hydrated', $entity->property1);

Accessing property1 on the interface Graze\UnicontrollerClient\Entity\Entity\EntityInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    }
}