Issues in Zend2Adapter.php (master) - Issues in master - graze/data-db - Measure and Improve Code Quality continuously with Scrutinizer

Issues (44)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Adapter/Zend2Adapter.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Graze\DataDb\Adapter;

use Graze\DataDb\Dialect\DialectInterface;
use Traversable;
use Zend\Db\Adapter\Adapter;

class Zend2Adapter implements AdapterInterface
{
    /** @var Adapter */
    private $zendAdapter;
    /** @var DialectInterface */
    private $dialect;

    /**
     * Zend1Adapter constructor.
     *
     * @param Adapter          $zendAdapter
     * @param DialectInterface $dialect
     */
    public function __construct(Adapter $zendAdapter, DialectInterface $dialect)
    {
        $this->zendAdapter = $zendAdapter;
        $this->dialect = $dialect;
    }

    /**
     * @param string $sql
     * @param array  $bind
     *
     * @return mixed
     */
    public function query($sql, array $bind = [])
    {
        return $this->zendAdapter->query($sql, $bind);
    }

    /**
     * @param string $sql
     * @param array  $bind
     *
     * @return Traversable
     */
    public function fetch($sql, array $bind = [])
    {
        return $this->zendAdapter->query($sql, $bind);

    }

    /**
     * @param string $sql
     * @param array  $bind
     *
     * @return array
     */
    public function fetchAll($sql, array $bind = [])
    {
        return iterator_to_array($this->fetch($sql, $bind), true);
    }

    /**
     * @param string $sql
     * @param array  $bind
     *
     * @return array
     */
    public function fetchRow($sql, array $bind = [])
    {
        $results = $this->zendAdapter->query($sql, $bind);
        return $results->current() ?: false;
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * @param string $sql
     * @param array  $bind
     *
     * @return mixed
     */
    public function fetchOne($sql, array $bind = [])

    {
        $row = $this->fetchRow($sql, $bind);
        if ($row) {

            return $row[0];
        } else {
            return false;
        }
    }

    /**
     * @param mixed $value
     *
     * @return string
     */
    public function quoteValue($value)
    {
        return $this->zendAdapter->getPlatform()->quoteValue($value);
    }

    /**
     * Start a transaction
     *
     * @return static
     */
    public function beginTransaction()
    {
        $this->zendAdapter->getDriver()->getConnection()->beginTransaction();
        return $this;
    }

    /**
     * @return static
     */
    public function commit()
    {
        $this->zendAdapter->getDriver()->getConnection()->commit();
        return $this;
    }

    /**
     * @return static
     */
    public function rollback()
    {
        $this->zendAdapter->getDriver()->getConnection()->rollback();
        return $this;
    }

    /**
     * @return DialectInterface
     */
    public function getDialect()
    {
        return $this->dialect;
    }
}


1		<?php
2
3		namespace Graze\DataDb\Adapter;
4
5		use Graze\DataDb\Dialect\DialectInterface;
6		use Traversable;
7		use Zend\Db\Adapter\Adapter;
8
9		class Zend2Adapter implements AdapterInterface
10		{
11		/** @var Adapter */
12		private $zendAdapter;
13		/** @var DialectInterface */
14		private $dialect;
15
16		/**
17		* Zend1Adapter constructor.
18		*
19		* @param Adapter $zendAdapter
20		* @param DialectInterface $dialect
21		*/
22		public function __construct(Adapter $zendAdapter, DialectInterface $dialect)
23		{
24		$this->zendAdapter = $zendAdapter;
25		$this->dialect = $dialect;
26		}
27
28		/**
29		* @param string $sql
30		* @param array $bind
31		*
32		* @return mixed
33		*/
34		public function query($sql, array $bind = [])
35		{
36		return $this->zendAdapter->query($sql, $bind);
37		}
38
39		/**
40		* @param string $sql
41		* @param array $bind
42		*
43		* @return Traversable
44		*/
45		public function fetch($sql, array $bind = [])
46		{
47		return $this->zendAdapter->query($sql, $bind);
		0 ignored issues – show Bug Compatibility introduced 2016-09-27 11:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$this->zendAdapter->query($sql, $bind);` of type `Zend\Db\Adapter\Driver\S...\Driver\ResultInterface` adds the type `Zend\Db\Adapter\Driver\StatementInterface` to the return on line 47 which is incompatible with the return type declared by the interface `Graze\DataDb\Adapter\AdapterInterface::fetch` of type `Traversable`. Loading history...
48		}
49
50		/**
51		* @param string $sql
52		* @param array $bind
53		*
54		* @return array
55		*/
56		public function fetchAll($sql, array $bind = [])
57		{
58		return iterator_to_array($this->fetch($sql, $bind), true);
59		}
60
61		/**
62		* @param string $sql
63		* @param array $bind
64		*
65		* @return array
66		*/
67		public function fetchRow($sql, array $bind = [])
68		{
69		$results = $this->zendAdapter->query($sql, $bind);
70		return $results->current() ?: false;
		0 ignored issues – show Bug introduced 2016-09-27 11:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `current` does only exist in `Zend\Db\Adapter\Driver\ResultInterface`, but not in `Zend\Db\Adapter\Driver\S...tSet\ResultSetInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
71		}
72
73		/**
74		* @param string $sql
75		* @param array $bind
76		*
77		* @return mixed
78		*/
79	View Code Duplication	public function fetchOne($sql, array $bind = [])
		0 ignored issues – show Duplication introduced 2016-09-27 11:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
80		{
81		$row = $this->fetchRow($sql, $bind);
82		if ($row) {
		0 ignored issues – show Bug Best Practice introduced 2016-09-27 11:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$row` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
83		return $row[0];
84		} else {
85		return false;
86		}
87		}
88
89		/**
90		* @param mixed $value
91		*
92		* @return string
93		*/
94		public function quoteValue($value)
95		{
96		return $this->zendAdapter->getPlatform()->quoteValue($value);
97		}
98
99		/**
100		* Start a transaction
101		*
102		* @return static
103		*/
104		public function beginTransaction()
105		{
106		$this->zendAdapter->getDriver()->getConnection()->beginTransaction();
107		return $this;
108		}
109
110		/**
111		* @return static
112		*/
113		public function commit()
114		{
115		$this->zendAdapter->getDriver()->getConnection()->commit();
116		return $this;
117		}
118
119		/**
120		* @return static
121		*/
122		public function rollback()
123		{
124		$this->zendAdapter->getDriver()->getConnection()->rollback();
125		return $this;
126		}
127
128		/**
129		* @return DialectInterface
130		*/
131		public function getDialect()
132		{
133		return $this->dialect;
134		}
135		}
136

graze / data-db

Issues (44)

Security Analysis no request data

src/Adapter/Zend2Adapter.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like