Graze\DataDb\Adapter\Zend2Adapter

Complexity

Total Complexity

13

Size/Duplication

Total Lines	127
Duplicated Lines	7.09 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	query()	0	4	1
A	fetch()	0	4	1
A	fetchAll()	0	4	1
A	fetchRow()	0	5	2
A	fetchOne()	9	9	2
A	quoteValue()	0	4	1
A	beginTransaction()	0	5	1
A	commit()	0	5	1
A	rollback()	0	5	1
A	getDialect()	0	4	1

<?php

namespace Graze\DataDb\Adapter;

use Graze\DataDb\Dialect\DialectInterface;
use Traversable;
use Zend\Db\Adapter\Adapter;

class Zend2Adapter implements AdapterInterface
{
    /** @var Adapter */
    private $zendAdapter;
    /** @var DialectInterface */
    private $dialect;

    /**
     * Zend1Adapter constructor.
     *
     * @param Adapter          $zendAdapter
     * @param DialectInterface $dialect
     */
    public function __construct(Adapter $zendAdapter, DialectInterface $dialect)
    {
        $this->zendAdapter = $zendAdapter;
        $this->dialect = $dialect;
    }

    /**
     * @param string $sql
     * @param array  $bind
     *
     * @return mixed
     */
    public function query($sql, array $bind = [])
    {
        return $this->zendAdapter->query($sql, $bind);
    }

    /**
     * @param string $sql
     * @param array  $bind
     *
     * @return Traversable
     */
    public function fetch($sql, array $bind = [])
    {
        return $this->zendAdapter->query($sql, $bind);

The expression $this->zendAdapter->query($sql, $bind); of type Zend\Db\Adapter\Driver\StatementInterface|Zend\Db\ResultSet\ResultSetInterface|Zend\Db\Adapter\Driver\ResultInterface adds the type Zend\Db\Adapter\Driver\StatementInterface to the return on line 47 which is incompatible with the return type declared by the interface Graze\DataDb\Adapter\AdapterInterface::fetch of type Traversable.

    }

    /**
     * @param string $sql
     * @param array  $bind
     *
     * @return array
     */
    public function fetchAll($sql, array $bind = [])
    {
        return iterator_to_array($this->fetch($sql, $bind), true);
    }

    /**
     * @param string $sql
     * @param array  $bind
     *
     * @return array
     */
    public function fetchRow($sql, array $bind = [])
    {
        $results = $this->zendAdapter->query($sql, $bind);
        return $results->current() ?: false;

The method current does only exist in Zend\Db\Adapter\Driver\ResultInterface, but not in Zend\Db\Adapter\Driver\StatementInterface and Zend\Db\ResultSet\ResultSetInterface.

    }

    /**
     * @param string $sql
     * @param array  $bind
     *
     * @return mixed
     */
    public function fetchOne($sql, array $bind = [])

This method seems to be duplicated in your project.

    {
        $row = $this->fetchRow($sql, $bind);
        if ($row) {

The expression $row of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return $row[0];
        } else {
            return false;
        }
    }

    /**
     * @param mixed $value
     *
     * @return string
     */
    public function quoteValue($value)
    {
        return $this->zendAdapter->getPlatform()->quoteValue($value);
    }

    /**
     * Start a transaction
     *
     * @return static
     */
    public function beginTransaction()
    {
        $this->zendAdapter->getDriver()->getConnection()->beginTransaction();
        return $this;
    }

    /**
     * @return static
     */
    public function commit()
    {
        $this->zendAdapter->getDriver()->getConnection()->commit();
        return $this;
    }

    /**
     * @return static
     */
    public function rollback()
    {
        $this->zendAdapter->getDriver()->getConnection()->rollback();
        return $this;
    }

    /**
     * @return DialectInterface
     */
    public function getDialect()
    {
        return $this->dialect;
    }
}