ConsoleDiff::lines() - Code Metrics - Inspection of "add consolediff files" - graze/console-diff-renderer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( aa415b...e4e762 )

by Harry

created 2017-06-07 16:50 UTC

ConsoleDiff::lines() B

↳ Parent: ConsoleDiff

Complexity

Conditions	7
Paths	2

Size

Total Lines	19
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
rs	8.2222
c	0
b	0
f	0
cc	7
eloc	10
nc	2
nop	3

<?php

namespace Graze\BufferedConsole\Diff;

use Symfony\Component\Console\Output\OutputInterface;

class ConsoleDiff extends FirstDiff
{
    const UNCLOSED_TAGS = '/<(?P<tag>[a-z;=]+)>(?!.*?<\/(?:(?P=tag)|)>)/i';

    /** @var FirstDiff */
    private $diff;

    /**
     * ConsoleDiff constructor.
     *
     * @param FirstDiff|null $differ
     */
    public function __construct($differ = null)
    {
        $this->diff = $differ ?: new FirstDiff();
    }

    /**
     * @param string[] $old
     * @param string[] $new
     * @param int      $options
     *
     * @return string[]
     */
    public function lines(array $old, array $new, $options = OutputInterface::OUTPUT_NORMAL)
    {
        $diff = $this->diff->lines($old, $new);

        if (($options & OutputInterface::OUTPUT_NORMAL) == OutputInterface::OUTPUT_NORMAL) {
            // replace col number with strip_tags version to represent what is outputted to the user
            for ($i = 0; $i < count($new); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                if (isset($diff[$i]) && !is_null($new[$i]) && $diff[$i]['col'] > 0) {
                    $tags = $this->getUnclosedTags(mb_substr($new[$i], 0, $diff[$i]['col']));
                    if (count($tags) > 0) {
                        $diff[$i]['str'] = '<' . implode('><', $tags) . '>' . $diff[$i]['str'];
                    }
                    $diff[$i]['col'] = mb_strlen(strip_tags(mb_substr($new[$i], 0, $diff[$i]['col'])));
                }
            }
        }

        return $diff;
    }

    /**
     * Find a list of unclosed tags
     *
     * @param string $string
     *
     * @return string[]
     */
    private function getUnclosedTags($string)
    {
        if (preg_match_all(static::UNCLOSED_TAGS, $string, $matches)) {
            return $matches['tag'];
        }
        return [];
    }
}


1			<?php
2
3			namespace Graze\BufferedConsole\Diff;
4
5			use Symfony\Component\Console\Output\OutputInterface;
6
7			class ConsoleDiff extends FirstDiff
8			{
9			const UNCLOSED_TAGS = '/<(?P<tag>[a-z;=]+)>(?!.*?<\/(?:(?P=tag)\|)>)/i';
10
11			/** @var FirstDiff */
12			private $diff;
13
14			/**
15			* ConsoleDiff constructor.
16			*
17			* @param FirstDiff\|null $differ
18			*/
19			public function __construct($differ = null)
20			{
21			$this->diff = $differ ?: new FirstDiff();
22			}
23
24			/**
25			* @param string[] $old
26			* @param string[] $new
27			* @param int $options
28			*
29			* @return string[]
30			*/
31			public function lines(array $old, array $new, $options = OutputInterface::OUTPUT_NORMAL)
32			{
33			$diff = $this->diff->lines($old, $new);
34
35			if (($options & OutputInterface::OUTPUT_NORMAL) == OutputInterface::OUTPUT_NORMAL) {
36			// replace col number with strip_tags version to represent what is outputted to the user
37			for ($i = 0; $i < count($new); $i++) {
			0 ignored issues – show Performance Best Practice introduced 2017-06-07 14:08 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
38			if (isset($diff[$i]) && !is_null($new[$i]) && $diff[$i]['col'] > 0) {
39			$tags = $this->getUnclosedTags(mb_substr($new[$i], 0, $diff[$i]['col']));
40			if (count($tags) > 0) {
41			$diff[$i]['str'] = '<' . implode('><', $tags) . '>' . $diff[$i]['str'];
42			}
43			$diff[$i]['col'] = mb_strlen(strip_tags(mb_substr($new[$i], 0, $diff[$i]['col'])));
44			}
45			}
46			}
47
48			return $diff;
49			}
50
51			/**
52			* Find a list of unclosed tags
53			*
54			* @param string $string
55			*
56			* @return string[]
57			*/
58			private function getUnclosedTags($string)
59			{
60			if (preg_match_all(static::UNCLOSED_TAGS, $string, $matches)) {
61			return $matches['tag'];
62			}
63			return [];
64			}
65			}
66

graze / console-diff-renderer

Push — master ( aa415b...e4e762 )

ConsoleDiff::lines() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like