Graze\BufferedConsole\Diff\ConsoleDiff

Complexity

Total Complexity

11

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	2
B	lines()	0	19	7
A	getUnclosedTags()	0	7	2

<?php

namespace Graze\BufferedConsole\Diff;

use Symfony\Component\Console\Output\OutputInterface;

class ConsoleDiff extends FirstDiff
{
    const UNCLOSED_TAGS = '/<(?P<tag>[a-z;=]+)>(?!.*?<\/(?:(?P=tag)|)>)/i';

    /** @var FirstDiff */
    private $diff;

    /**
     * ConsoleDiff constructor.
     *
     * @param FirstDiff|null $differ
     */
    public function __construct($differ = null)
    {
        $this->diff = $differ ?: new FirstDiff();
    }

    /**
     * @param string[] $old
     * @param string[] $new
     * @param int      $options
     *
     * @return string[]
     */
    public function lines(array $old, array $new, $options = OutputInterface::OUTPUT_NORMAL)
    {
        $diff = $this->diff->lines($old, $new);

        if (($options & OutputInterface::OUTPUT_NORMAL) == OutputInterface::OUTPUT_NORMAL) {
            // replace col number with strip_tags version to represent what is outputted to the user
            for ($i = 0; $i < count($new); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                if (isset($diff[$i]) && !is_null($new[$i]) && $diff[$i]['col'] > 0) {
                    $tags = $this->getUnclosedTags(mb_substr($new[$i], 0, $diff[$i]['col']));
                    if (count($tags) > 0) {
                        $diff[$i]['str'] = '<' . implode('><', $tags) . '>' . $diff[$i]['str'];
                    }
                    $diff[$i]['col'] = mb_strlen(strip_tags(mb_substr($new[$i], 0, $diff[$i]['col'])));
                }
            }
        }

        return $diff;
    }

    /**
     * Find a list of unclosed tags
     *
     * @param string $string
     *
     * @return string[]
     */
    private function getUnclosedTags($string)
    {
        if (preg_match_all(static::UNCLOSED_TAGS, $string, $matches)) {
            return $matches['tag'];
        }
        return [];
    }
}