Completed
Push — develop ( 49dad3...605b83 )
by Zack
58:02 queued 38:00
created
includes/helper-functions.php 1 patch
Spacing   +39 added lines, -39 removed lines patch added patch discarded remove patch
@@ -36,9 +36,9 @@  discard block
 block discarded – undo
36 36
 
37 37
 	$parsed_permalink = parse_url( get_permalink( $id ) );
38 38
 
39
-	$permalink_args =  isset( $parsed_permalink['query'] ) ? $parsed_permalink['query'] : false;
39
+	$permalink_args = isset( $parsed_permalink[ 'query' ] ) ? $parsed_permalink[ 'query' ] : false;
40 40
 
41
-	if( empty( $permalink_args ) ) {
41
+	if ( empty( $permalink_args ) ) {
42 42
 		return array();
43 43
 	}
44 44
 
@@ -63,15 +63,15 @@  discard block
 block discarded – undo
63 63
 function gv_selected( $value, $current, $echo = true, $type = 'selected' ) {
64 64
 
65 65
 	$output = '';
66
-	if( is_array( $current ) ) {
67
-		if( in_array( $value, $current ) ) {
66
+	if ( is_array( $current ) ) {
67
+		if ( in_array( $value, $current ) ) {
68 68
 			$output = __checked_selected_helper( true, true, false, $type );
69 69
 		}
70 70
 	} else {
71 71
 		$output = __checked_selected_helper( $value, $current, false, $type );
72 72
 	}
73 73
 
74
-	if( $echo ) {
74
+	if ( $echo ) {
75 75
 		echo $output;
76 76
 	}
77 77
 
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
 }
80 80
 
81 81
 
82
-if( ! function_exists( 'gravityview_sanitize_html_class' ) ) {
82
+if ( ! function_exists( 'gravityview_sanitize_html_class' ) ) {
83 83
 
84 84
 	/**
85 85
 	 * sanitize_html_class doesn't handle spaces (multiple classes). We remedy that.
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
  */
126 126
 function gravityview_strip_whitespace( $string ) {
127 127
 	$string = normalize_whitespace( $string );
128
-	return preg_replace('/[\r\n\t ]+/', ' ', $string );
128
+	return preg_replace( '/[\r\n\t ]+/', ' ', $string );
129 129
 }
130 130
 
131 131
 /**
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
  * @return string Included file contents
140 140
  */
141 141
 function gravityview_ob_include( $file_path, $object = NULL ) {
142
-	if( ! file_exists( $file_path ) ) {
142
+	if ( ! file_exists( $file_path ) ) {
143 143
 		do_action( 'gravityview_log_error', __FUNCTION__ . ': File path does not exist. ', $file_path );
144 144
 		return '';
145 145
 	}
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
  */
156 156
 function gravityview_get_floaty() {
157 157
 
158
-	if( function_exists('is_rtl') && is_rtl() ) {
158
+	if ( function_exists( 'is_rtl' ) && is_rtl() ) {
159 159
 		$style = 'margin:10px 10px 10px 0;';
160 160
 		$class = 'alignright';
161 161
 	} else {
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
 		$class = 'alignleft';
164 164
 	}
165 165
 
166
-	return '<img src="'.plugins_url( 'assets/images/astronaut-200x263.png', GRAVITYVIEW_FILE ).'" class="'.$class.'" height="87" width="66" alt="The GravityView Astronaut Says:" style="'.$style.'" />';
166
+	return '<img src="' . plugins_url( 'assets/images/astronaut-200x263.png', GRAVITYVIEW_FILE ) . '" class="' . $class . '" height="87" width="66" alt="The GravityView Astronaut Says:" style="' . $style . '" />';
167 167
 }
168 168
 
169 169
 /**
@@ -186,9 +186,9 @@  discard block
 block discarded – undo
186 186
 function gravityview_number_format( $number, $decimals = '' ) {
187 187
 	global $wp_locale;
188 188
 
189
-	if( '' === $decimals ) {
189
+	if ( '' === $decimals ) {
190 190
 
191
-		$decimal_point = isset( $wp_locale ) ? $wp_locale->number_format['decimal_point'] : '.';
191
+		$decimal_point = isset( $wp_locale ) ? $wp_locale->number_format[ 'decimal_point' ] : '.';
192 192
 
193 193
 		/**
194 194
 		 * Calculate the position of the decimal point in the number
@@ -217,7 +217,7 @@  discard block
 block discarded – undo
217 217
 	$parts = parse_url( $value );
218 218
 
219 219
 	// No domain? Strange...show the original text.
220
-	if( empty( $parts['host'] ) ) {
220
+	if ( empty( $parts[ 'host' ] ) ) {
221 221
 		return $value;
222 222
 	}
223 223
 
@@ -230,16 +230,16 @@  discard block
 block discarded – undo
230 230
 	 * @param boolean $enable Whether to strip the scheme. Return false to show scheme. (default: true)\n
231 231
 	 * If true: `http://example.com => example.com`
232 232
 	 */
233
-	if( false === apply_filters('gravityview_anchor_text_striphttp', true) ) {
233
+	if ( false === apply_filters( 'gravityview_anchor_text_striphttp', true ) ) {
234 234
 
235
-		if( isset( $parts['scheme'] ) ) {
236
-			$return .= $parts['scheme'];
235
+		if ( isset( $parts[ 'scheme' ] ) ) {
236
+			$return .= $parts[ 'scheme' ];
237 237
 		}
238 238
 
239 239
 	}
240 240
 
241 241
 	// The domain, which may contain a subdomain
242
-	$domain = $parts['host'];
242
+	$domain = $parts[ 'host' ];
243 243
 
244 244
 	/**
245 245
 	 * @filter `gravityview_anchor_text_stripwww` Strip www from the domain?
@@ -247,10 +247,10 @@  discard block
 block discarded – undo
247 247
 	 * @param boolean $enable Whether to strip www. Return false to show www. (default: true)\n
248 248
 	 * If true: `www.example.com => example.com`
249 249
 	 */
250
-	$strip_www = apply_filters('gravityview_anchor_text_stripwww', true );
250
+	$strip_www = apply_filters( 'gravityview_anchor_text_stripwww', true );
251 251
 
252
-	if( $strip_www ) {
253
-		$domain = str_replace('www.', '', $domain );
252
+	if ( $strip_www ) {
253
+		$domain = str_replace( 'www.', '', $domain );
254 254
 	}
255 255
 
256 256
 	/**
@@ -260,11 +260,11 @@  discard block
 block discarded – undo
260 260
 	 * If true: `http://demo.example.com => example.com` \n
261 261
 	 * If false: `http://demo.example.com => demo.example.com`
262 262
 	 */
263
-	$strip_subdomains = apply_filters('gravityview_anchor_text_nosubdomain', true);
263
+	$strip_subdomains = apply_filters( 'gravityview_anchor_text_nosubdomain', true );
264 264
 
265
-	if( $strip_subdomains ) {
265
+	if ( $strip_subdomains ) {
266 266
 
267
-		$domain = _gravityview_strip_subdomain( $parts['host'] );
267
+		$domain = _gravityview_strip_subdomain( $parts[ 'host' ] );
268 268
 
269 269
 	}
270 270
 
@@ -278,12 +278,12 @@  discard block
 block discarded – undo
278 278
 	 * If true: `http://example.com/sub/directory/page.html => example.com`  \n
279 279
 	 * If false: `http://example.com/sub/directory/page.html => example.com/sub/directory/page.html`
280 280
 	 */
281
-	$root_only = apply_filters('gravityview_anchor_text_rootonly', true);
281
+	$root_only = apply_filters( 'gravityview_anchor_text_rootonly', true );
282 282
 
283
-	if( empty( $root_only ) ) {
283
+	if ( empty( $root_only ) ) {
284 284
 
285
-		if( isset( $parts['path'] ) ) {
286
-			$return .= $parts['path'];
285
+		if ( isset( $parts[ 'path' ] ) ) {
286
+			$return .= $parts[ 'path' ];
287 287
 		}
288 288
 	}
289 289
 
@@ -293,12 +293,12 @@  discard block
 block discarded – undo
293 293
 	 * @param boolean $enable Whether to enable "root only". Return false to show full path. (default: true)\n
294 294
 	 * If true: `http://example.com/?query=example => example.com`
295 295
 	 */
296
-	$strip_query_string = apply_filters('gravityview_anchor_text_noquerystring', true );
296
+	$strip_query_string = apply_filters( 'gravityview_anchor_text_noquerystring', true );
297 297
 
298
-	if( empty( $strip_query_string ) ) {
298
+	if ( empty( $strip_query_string ) ) {
299 299
 
300
-		if( isset( $parts['query'] ) ) {
301
-			$return .= '?'.$parts['query'];
300
+		if ( isset( $parts[ 'query' ] ) ) {
301
+			$return .= '?' . $parts[ 'query' ];
302 302
 		}
303 303
 
304 304
 	}
@@ -315,8 +315,8 @@  discard block
 block discarded – undo
315 315
  */
316 316
 function _gravityview_strip_subdomain( $string_maybe_has_subdomain ) {
317 317
 
318
-	if( preg_match("/(?P<domain>[a-z0-9][a-z0-9\-]{1,63}\.(?:com\.|co\.|net\.|org\.|firm\.|me\.|school\.|law\.|gov\.|mod\.|msk\.|irkutsks\.|sa\.|act\.|police\.|plc\.|ac\.|tm\.|asso\.|biz\.|pro\.|cg\.|telememo\.)?[a-z\.]{2,6})$/i", $string_maybe_has_subdomain, $matches ) ) {
319
-		return $matches['domain'];
318
+	if ( preg_match( "/(?P<domain>[a-z0-9][a-z0-9\-]{1,63}\.(?:com\.|co\.|net\.|org\.|firm\.|me\.|school\.|law\.|gov\.|mod\.|msk\.|irkutsks\.|sa\.|act\.|police\.|plc\.|ac\.|tm\.|asso\.|biz\.|pro\.|cg\.|telememo\.)?[a-z\.]{2,6})$/i", $string_maybe_has_subdomain, $matches ) ) {
319
+		return $matches[ 'domain' ];
320 320
 	} else {
321 321
 		return $string_maybe_has_subdomain;
322 322
 	}
@@ -337,7 +337,7 @@  discard block
 block discarded – undo
337 337
  */
338 338
 function gv_empty( $value, $zero_is_empty = true, $allow_string_booleans = true ) {
339 339
 
340
-	if(
340
+	if (
341 341
 		! isset( $value ) // If it's not set, it's empty!
342 342
 		|| false === $value
343 343
 		|| null === $value
@@ -348,20 +348,20 @@  discard block
 block discarded – undo
348 348
 		return true;
349 349
 	}
350 350
 
351
-	if( is_string( $value ) && $allow_string_booleans ) {
351
+	if ( is_string( $value ) && $allow_string_booleans ) {
352 352
 
353 353
 		$value = trim( $value );
354 354
 		$value = strtolower( $value );
355 355
 
356 356
 		if ( in_array( $value, array( 'yes', 'true' ), true ) ) {
357 357
 			$value = true;
358
-		} else if( in_array( $value, array( 'no', 'false' ), true ) ) {
358
+		} else if ( in_array( $value, array( 'no', 'false' ), true ) ) {
359 359
 			$value = false;
360 360
 		}
361 361
 	}
362 362
 
363 363
 	// If zero isn't empty, then if $value is a number and it's empty, it's zero. Thus, return false.
364
-	if( ! $zero_is_empty && is_numeric( $value ) && empty( $value ) ) {
364
+	if ( ! $zero_is_empty && is_numeric( $value ) && empty( $value ) ) {
365 365
 		return false;
366 366
 	}
367 367
 
@@ -429,13 +429,13 @@  discard block
 block discarded – undo
429 429
 	 */
430 430
 	$args = apply_filters( 'gravityview_get_terms_choices_args', $args );
431 431
 
432
-	$terms = get_terms( $args['taxonomy'], $args );
432
+	$terms = get_terms( $args[ 'taxonomy' ], $args );
433 433
 
434 434
 	$choices = array();
435 435
 
436 436
 	if ( is_array( $terms ) ) {
437 437
 		foreach ( $terms as $term_id => $term_name ) {
438
-			$choices[] = array(
438
+			$choices[ ] = array(
439 439
 				'text'  => $term_name,
440 440
 				'value' => $term_id
441 441
 			);
Please login to merge, or discard this patch.
includes/widgets/search-widget/class-search-widget.php 1 patch
Spacing   +97 added lines, -97 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 				'type' => 'radio',
57 57
 				'full_width' => true,
58 58
 				'label' => esc_html__( 'Search Mode', 'gravityview' ),
59
-				'desc' => __('Should search results match all search fields, or any?', 'gravityview'),
59
+				'desc' => __( 'Should search results match all search fields, or any?', 'gravityview' ),
60 60
 				'value' => 'any',
61 61
 				'class' => 'hide-if-js',
62 62
 				'options' => array(
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 		$script_min = ( defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ) ? '' : '.min';
112 112
 		$script_source = empty( $script_min ) ? '/source' : '';
113 113
 
114
-		wp_enqueue_script( 'gravityview_searchwidget_admin', plugins_url( 'assets/js'.$script_source.'/admin-search-widget'.$script_min.'.js', __FILE__ ), array( 'jquery', 'gravityview_views_scripts' ), GravityView_Plugin::version );
114
+		wp_enqueue_script( 'gravityview_searchwidget_admin', plugins_url( 'assets/js' . $script_source . '/admin-search-widget' . $script_min . '.js', __FILE__ ), array( 'jquery', 'gravityview_views_scripts' ), GravityView_Plugin::version );
115 115
 
116 116
 
117 117
 		/**
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
 	 * Add admin script to the whitelist
164 164
 	 */
165 165
 	public function register_no_conflict( $required ) {
166
-		$required[] = 'gravityview_searchwidget_admin';
166
+		$required[ ] = 'gravityview_searchwidget_admin';
167 167
 		return $required;
168 168
 	}
169 169
 
@@ -176,24 +176,24 @@  discard block
 block discarded – undo
176 176
 	 */
177 177
 	public static function get_searchable_fields() {
178 178
 
179
-		if ( ! isset( $_POST['nonce'] ) || ! wp_verify_nonce( $_POST['nonce'], 'gravityview_ajaxsearchwidget' ) ) {
179
+		if ( ! isset( $_POST[ 'nonce' ] ) || ! wp_verify_nonce( $_POST[ 'nonce' ], 'gravityview_ajaxsearchwidget' ) ) {
180 180
 			exit( '0' );
181 181
 		}
182 182
 
183 183
 		$form = '';
184 184
 
185 185
 		// Fetch the form for the current View
186
-		if ( ! empty( $_POST['view_id'] ) ) {
186
+		if ( ! empty( $_POST[ 'view_id' ] ) ) {
187 187
 
188
-			$form = gravityview_get_form_id( $_POST['view_id'] );
188
+			$form = gravityview_get_form_id( $_POST[ 'view_id' ] );
189 189
 
190
-		} elseif ( ! empty( $_POST['formid'] ) ) {
190
+		} elseif ( ! empty( $_POST[ 'formid' ] ) ) {
191 191
 
192
-			$form = (int) $_POST['formid'];
192
+			$form = (int)$_POST[ 'formid' ];
193 193
 
194
-		} elseif ( ! empty( $_POST['template_id'] ) && class_exists( 'GravityView_Ajax' ) ) {
194
+		} elseif ( ! empty( $_POST[ 'template_id' ] ) && class_exists( 'GravityView_Ajax' ) ) {
195 195
 
196
-			$form = GravityView_Ajax::pre_get_form_fields( $_POST['template_id'] );
196
+			$form = GravityView_Ajax::pre_get_form_fields( $_POST[ 'template_id' ] );
197 197
 
198 198
 		}
199 199
 
@@ -241,8 +241,8 @@  discard block
 block discarded – undo
241 241
 			)
242 242
 		);
243 243
 
244
-		foreach( $custom_fields as $custom_field_key => $custom_field ) {
245
-			$output .= sprintf( '<option value="%s" %s data-inputtypes="%s" data-placeholder="%s">%s</option>', $custom_field_key, selected( $custom_field_key, $current, false ), $custom_field['type'], self::get_field_label( array('field' => $custom_field_key ) ), $custom_field['text'] );
244
+		foreach ( $custom_fields as $custom_field_key => $custom_field ) {
245
+			$output .= sprintf( '<option value="%s" %s data-inputtypes="%s" data-placeholder="%s">%s</option>', $custom_field_key, selected( $custom_field_key, $current, false ), $custom_field[ 'type' ], self::get_field_label( array( 'field' => $custom_field_key ) ), $custom_field[ 'text' ] );
246 246
 		}
247 247
 
248 248
 		if ( ! empty( $fields ) ) {
@@ -251,13 +251,13 @@  discard block
 block discarded – undo
251 251
 
252 252
 			foreach ( $fields as $id => $field ) {
253 253
 
254
-				if ( in_array( $field['type'], $blacklist_field_types ) ) {
254
+				if ( in_array( $field[ 'type' ], $blacklist_field_types ) ) {
255 255
 					continue;
256 256
 				}
257 257
 
258
-				$types = self::get_search_input_types( $id, $field['type'] );
258
+				$types = self::get_search_input_types( $id, $field[ 'type' ] );
259 259
 
260
-				$output .= '<option value="'. $id .'" '. selected( $id, $current, false ).'data-inputtypes="'. esc_attr( $types ) .'">'. esc_html( $field['label'] ) .'</option>';
260
+				$output .= '<option value="' . $id . '" ' . selected( $id, $current, false ) . 'data-inputtypes="' . esc_attr( $types ) . '">' . esc_html( $field[ 'label' ] ) . '</option>';
261 261
 			}
262 262
 		}
263 263
 
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
 	public static function get_search_input_types( $id = '', $field_type = null ) {
280 280
 
281 281
 		// @todo - This needs to be improved - many fields have . including products and addresses
282
-		if ( false !== strpos( (string) $id, '.' ) && in_array( $field_type, array( 'checkbox' ) ) || in_array( $id, array( 'is_fulfilled' ) ) ) {
282
+		if ( false !== strpos( (string)$id, '.' ) && in_array( $field_type, array( 'checkbox' ) ) || in_array( $id, array( 'is_fulfilled' ) ) ) {
283 283
 			$input_type = 'boolean'; // on/off checkbox
284 284
 		} elseif ( in_array( $field_type, array( 'checkbox', 'post_category', 'multiselect' ) ) ) {
285 285
 			$input_type = 'multi'; //multiselect
@@ -321,19 +321,19 @@  discard block
 block discarded – undo
321 321
 			$post_id = 0;
322 322
 
323 323
 			// We're in the WordPress Widget context, and an overriding post ID has been set.
324
-			if ( ! empty( $widget_args['post_id'] ) ) {
325
-				$post_id = absint( $widget_args['post_id'] );
324
+			if ( ! empty( $widget_args[ 'post_id' ] ) ) {
325
+				$post_id = absint( $widget_args[ 'post_id' ] );
326 326
 			}
327 327
 			// We're in the WordPress Widget context, and the base View ID should be used
328
-			else if ( ! empty( $widget_args['view_id'] ) ) {
329
-				$post_id = absint( $widget_args['view_id'] );
328
+			else if ( ! empty( $widget_args[ 'view_id' ] ) ) {
329
+				$post_id = absint( $widget_args[ 'view_id' ] );
330 330
 			}
331 331
 
332 332
 			$args = gravityview_get_permalink_query_args( $post_id );
333 333
 
334 334
 			// Add hidden fields to the search form
335 335
 			foreach ( $args as $key => $value ) {
336
-				$search_fields[] = array(
336
+				$search_fields[ ] = array(
337 337
 					'name'  => $key,
338 338
 					'input' => 'hidden',
339 339
 					'value' => $value,
@@ -365,15 +365,15 @@  discard block
 block discarded – undo
365 365
 		$get = array_map( 'urldecode', $get );
366 366
 
367 367
 		// add free search
368
-		if ( ! empty( $get['gv_search'] ) ) {
368
+		if ( ! empty( $get[ 'gv_search' ] ) ) {
369 369
 
370 370
 			// Search for a piece
371
-			$words = explode( ' ', $get['gv_search'] );
371
+			$words = explode( ' ', $get[ 'gv_search' ] );
372 372
 
373 373
 			$words = array_filter( $words );
374 374
 
375 375
 			foreach ( $words as $word ) {
376
-				$search_criteria['field_filters'][] = array(
376
+				$search_criteria[ 'field_filters' ][ ] = array(
377 377
 					'key' => null, // The field ID to search
378 378
 					'value' => $word, // The value to search
379 379
 					'operator' => 'contains', // What to search in. Options: `is` or `contains`
@@ -398,16 +398,16 @@  discard block
 block discarded – undo
398 398
 		/**
399 399
 		 * Don't set $search_criteria['start_date'] if start_date is empty as it may lead to bad query results (GFAPI::get_entries)
400 400
 		 */
401
-		if( !empty( $curr_start ) ) {
402
-			$search_criteria['start_date'] = $adjust_tz ? get_gmt_from_date( $curr_start ) : $curr_start;
401
+		if ( ! empty( $curr_start ) ) {
402
+			$search_criteria[ 'start_date' ] = $adjust_tz ? get_gmt_from_date( $curr_start ) : $curr_start;
403 403
 		}
404
-		if( !empty( $curr_end ) ) {
405
-			$search_criteria['end_date'] = $adjust_tz ? get_gmt_from_date( $curr_end ) : $curr_end;
404
+		if ( ! empty( $curr_end ) ) {
405
+			$search_criteria[ 'end_date' ] = $adjust_tz ? get_gmt_from_date( $curr_end ) : $curr_end;
406 406
 		}
407 407
 
408 408
 		// search for a specific entry ID
409 409
 		if ( ! empty( $get[ 'gv_id' ] ) ) {
410
-			$search_criteria['field_filters'][] = array(
410
+			$search_criteria[ 'field_filters' ][ ] = array(
411 411
 				'key' => 'id',
412 412
 				'value' => absint( $get[ 'gv_id' ] ),
413 413
 				'operator' => '=',
@@ -416,9 +416,9 @@  discard block
 block discarded – undo
416 416
 
417 417
 		// search for a specific Created_by ID
418 418
 		if ( ! empty( $get[ 'gv_by' ] ) ) {
419
-			$search_criteria['field_filters'][] = array(
419
+			$search_criteria[ 'field_filters' ][ ] = array(
420 420
 				'key' => 'created_by',
421
-				'value' => absint( $get['gv_by'] ),
421
+				'value' => absint( $get[ 'gv_by' ] ),
422 422
 				'operator' => '=',
423 423
 			);
424 424
 		}
@@ -430,22 +430,22 @@  discard block
 block discarded – undo
430 430
 		// get the other search filters
431 431
 		foreach ( $get as $key => $value ) {
432 432
 
433
-			if ( 0 !== strpos( $key, 'filter_' ) || empty( $value ) || ( is_array( $value ) && count( $value ) === 1 && empty( $value[0] ) ) ) {
433
+			if ( 0 !== strpos( $key, 'filter_' ) || empty( $value ) || ( is_array( $value ) && count( $value ) === 1 && empty( $value[ 0 ] ) ) ) {
434 434
 				continue;
435 435
 			}
436 436
 
437 437
 			// could return simple filter or multiple filters
438 438
 			$filter = $this->prepare_field_filter( $key, $value );
439 439
 
440
-			if ( isset( $filter[0]['value'] ) ) {
441
-				$search_criteria['field_filters'] = array_merge( $search_criteria['field_filters'], $filter );
440
+			if ( isset( $filter[ 0 ][ 'value' ] ) ) {
441
+				$search_criteria[ 'field_filters' ] = array_merge( $search_criteria[ 'field_filters' ], $filter );
442 442
 
443 443
 				// if date range type, set search mode to ALL
444
-				if ( ! empty( $filter[0]['operator'] ) && in_array( $filter[0]['operator'], array( '>', '<' ) ) ) {
444
+				if ( ! empty( $filter[ 0 ][ 'operator' ] ) && in_array( $filter[ 0 ][ 'operator' ], array( '>', '<' ) ) ) {
445 445
 					$mode = 'all';
446 446
 				}
447
-			} elseif( !empty( $filter ) ) {
448
-				$search_criteria['field_filters'][] = $filter;
447
+			} elseif ( ! empty( $filter ) ) {
448
+				$search_criteria[ 'field_filters' ][ ] = $filter;
449 449
 			}
450 450
 		}
451 451
 
@@ -454,7 +454,7 @@  discard block
 block discarded – undo
454 454
 		 * @since 1.5.1
455 455
 		 * @param[out,in] string $mode Search mode (`any` vs `all`)
456 456
 		 */
457
-		$search_criteria['field_filters']['mode'] = apply_filters( 'gravityview/search/mode', $mode );
457
+		$search_criteria[ 'field_filters' ][ 'mode' ] = apply_filters( 'gravityview/search/mode', $mode );
458 458
 
459 459
 		do_action( 'gravityview_log_debug', sprintf( '%s[filter_entries] Returned Search Criteria: ', get_class( $this ) ), $search_criteria );
460 460
 
@@ -490,11 +490,11 @@  discard block
 block discarded – undo
490 490
 			'value' => _wp_specialchars( $value ), // Gravity Forms encodes ampersands but not quotes
491 491
 		);
492 492
 
493
-		switch ( $form_field['type'] ) {
493
+		switch ( $form_field[ 'type' ] ) {
494 494
 
495 495
 			case 'select':
496 496
 			case 'radio':
497
-				$filter['operator'] = 'is';
497
+				$filter[ 'operator' ] = 'is';
498 498
 				break;
499 499
 
500 500
 			case 'post_category':
@@ -508,7 +508,7 @@  discard block
 block discarded – undo
508 508
 
509 509
 				foreach ( $value as $val ) {
510 510
 					$cat = get_term( $val, 'category' );
511
-					$filter[] = array(
511
+					$filter[ ] = array(
512 512
 						'key' => $field_id,
513 513
 						'value' => esc_attr( $cat->name ) . ':' . $val,
514 514
 						'operator' => 'is',
@@ -527,18 +527,18 @@  discard block
 block discarded – undo
527 527
 				$filter = array();
528 528
 
529 529
 				foreach ( $value as $val ) {
530
-					$filter[] = array( 'key' => $field_id, 'value' => $val );
530
+					$filter[ ] = array( 'key' => $field_id, 'value' => $val );
531 531
 				}
532 532
 
533 533
 				break;
534 534
 
535 535
 			case 'checkbox':
536 536
 				// convert checkbox on/off into the correct search filter
537
-				if ( false !== strpos( $field_id, '.' ) && ! empty( $form_field['inputs'] ) && ! empty( $form_field['choices'] ) ) {
538
-					foreach ( $form_field['inputs'] as $k => $input ) {
539
-						if ( $input['id'] == $field_id ) {
540
-							$filter['value'] = $form_field['choices'][ $k ]['value'];
541
-							$filter['operator'] = 'is';
537
+				if ( false !== strpos( $field_id, '.' ) && ! empty( $form_field[ 'inputs' ] ) && ! empty( $form_field[ 'choices' ] ) ) {
538
+					foreach ( $form_field[ 'inputs' ] as $k => $input ) {
539
+						if ( $input[ 'id' ] == $field_id ) {
540
+							$filter[ 'value' ] = $form_field[ 'choices' ][ $k ][ 'value' ];
541
+							$filter[ 'operator' ] = 'is';
542 542
 							break;
543 543
 						}
544 544
 					}
@@ -548,7 +548,7 @@  discard block
 block discarded – undo
548 548
 					$filter = array();
549 549
 
550 550
 					foreach ( $value as $val ) {
551
-						$filter[] = array(
551
+						$filter[ ] = array(
552 552
 								'key'   => $field_id,
553 553
 								'value' => $val,
554 554
 								'operator' => 'is',
@@ -569,9 +569,9 @@  discard block
 block discarded – undo
569 569
 					foreach ( $words as $word ) {
570 570
 						if ( ! empty( $word ) && strlen( $word ) > 1 ) {
571 571
 							// Keep the same key for each filter
572
-							$filter['value'] = $word;
572
+							$filter[ 'value' ] = $word;
573 573
 							// Add a search for the value
574
-							$filters[] = $filter;
574
+							$filters[ ] = $filter;
575 575
 						}
576 576
 					}
577 577
 
@@ -593,14 +593,14 @@  discard block
 block discarded – undo
593 593
 						}
594 594
 						$operator = 'start' === $k ? '>' : '<';
595 595
 
596
-						$filter[] = array(
596
+						$filter[ ] = array(
597 597
 							'key' => $field_id,
598 598
 							'value' => self::get_formatted_date( $date, 'Y-m-d' ),
599 599
 							'operator' => $operator,
600 600
 						);
601 601
 					}
602 602
 				} else {
603
-					$filter['value'] = self::get_formatted_date( $value, 'Y-m-d' );
603
+					$filter[ 'value' ] = self::get_formatted_date( $value, 'Y-m-d' );
604 604
 				}
605 605
 
606 606
 				break;
@@ -631,7 +631,7 @@  discard block
 block discarded – undo
631 631
 			'ymd_dot' => 'Y.m.d',
632 632
 		);
633 633
 
634
-		if ( ! empty( $field->dateFormat ) && isset( $datepicker[ $field->dateFormat ] ) ){
634
+		if ( ! empty( $field->dateFormat ) && isset( $datepicker[ $field->dateFormat ] ) ) {
635 635
 			$format = $datepicker[ $field->dateFormat ];
636 636
 		}
637 637
 
@@ -662,7 +662,7 @@  discard block
 block discarded – undo
662 662
 	public function add_template_path( $file_paths ) {
663 663
 
664 664
 		// Index 100 is the default GravityView template path.
665
-		$file_paths[102] = self::$file . 'templates/';
665
+		$file_paths[ 102 ] = self::$file . 'templates/';
666 666
 
667 667
 		return $file_paths;
668 668
 	}
@@ -684,7 +684,7 @@  discard block
 block discarded – undo
684 684
 		}
685 685
 
686 686
 		// get configured search fields
687
-		$search_fields = ! empty( $widget_args['search_fields'] ) ? json_decode( $widget_args['search_fields'], true ) : '';
687
+		$search_fields = ! empty( $widget_args[ 'search_fields' ] ) ? json_decode( $widget_args[ 'search_fields' ], true ) : '';
688 688
 
689 689
 		if ( empty( $search_fields ) || ! is_array( $search_fields ) ) {
690 690
 			do_action( 'gravityview_log_debug', sprintf( '%s[render_frontend] No search fields configured for widget:', get_class( $this ) ), $widget_args );
@@ -698,24 +698,24 @@  discard block
 block discarded – undo
698 698
 
699 699
 			$updated_field = $field;
700 700
 
701
-			if ( in_array( $field['input'], array( 'date', 'date_range' ) ) ) {
701
+			if ( in_array( $field[ 'input' ], array( 'date', 'date_range' ) ) ) {
702 702
 				$has_date = true;
703 703
 			}
704 704
 
705 705
 			$updated_field = $this->get_search_filter_details( $updated_field );
706 706
 
707
-			switch ( $field['field'] ) {
707
+			switch ( $field[ 'field' ] ) {
708 708
 
709 709
 				case 'search_all':
710
-					$updated_field['key'] = 'search_all';
711
-					$updated_field['input'] = 'search_all';
712
-					$updated_field['value'] = esc_attr( stripslashes_deep( rgget( 'gv_search' ) ) );
710
+					$updated_field[ 'key' ] = 'search_all';
711
+					$updated_field[ 'input' ] = 'search_all';
712
+					$updated_field[ 'value' ] = esc_attr( stripslashes_deep( rgget( 'gv_search' ) ) );
713 713
 					break;
714 714
 
715 715
 				case 'entry_date':
716
-					$updated_field['key'] = 'entry_date';
717
-					$updated_field['input'] = 'entry_date';
718
-					$updated_field['value'] = array(
716
+					$updated_field[ 'key' ] = 'entry_date';
717
+					$updated_field[ 'input' ] = 'entry_date';
718
+					$updated_field[ 'value' ] = array(
719 719
 						'start' => esc_attr( stripslashes_deep( rgget( 'gv_start' ) ) ),
720 720
 						'end' => esc_attr( stripslashes_deep( rgget( 'gv_end' ) ) ),
721 721
 					);
@@ -723,16 +723,16 @@  discard block
 block discarded – undo
723 723
 					break;
724 724
 
725 725
 				case 'entry_id':
726
-					$updated_field['key'] = 'entry_id';
727
-					$updated_field['input'] = 'entry_id';
728
-					$updated_field['value'] = esc_attr( stripslashes_deep( rgget( 'gv_id' ) ) );
726
+					$updated_field[ 'key' ] = 'entry_id';
727
+					$updated_field[ 'input' ] = 'entry_id';
728
+					$updated_field[ 'value' ] = esc_attr( stripslashes_deep( rgget( 'gv_id' ) ) );
729 729
 					break;
730 730
 
731 731
 				case 'created_by':
732
-					$updated_field['key'] = 'created_by';
733
-					$updated_field['name'] = 'gv_by';
734
-					$updated_field['value'] = esc_attr( stripslashes_deep( rgget( 'gv_by' ) ) );
735
-					$updated_field['choices'] = self::get_created_by_choices();
732
+					$updated_field[ 'key' ] = 'created_by';
733
+					$updated_field[ 'name' ] = 'gv_by';
734
+					$updated_field[ 'value' ] = esc_attr( stripslashes_deep( rgget( 'gv_by' ) ) );
735
+					$updated_field[ 'choices' ] = self::get_created_by_choices();
736 736
 					break;
737 737
 			}
738 738
 
@@ -750,16 +750,16 @@  discard block
 block discarded – undo
750 750
 		 */
751 751
 		$gravityview_view->search_fields = apply_filters( 'gravityview_widget_search_filters', $search_fields, $this, $widget_args );
752 752
 
753
-		$gravityview_view->search_layout = ! empty( $widget_args['search_layout'] ) ? $widget_args['search_layout'] : 'horizontal';
753
+		$gravityview_view->search_layout = ! empty( $widget_args[ 'search_layout' ] ) ? $widget_args[ 'search_layout' ] : 'horizontal';
754 754
 
755 755
 		/** @since 1.14 */
756
-		$gravityview_view->search_mode = ! empty( $widget_args['search_mode'] ) ? $widget_args['search_mode'] : 'any';
756
+		$gravityview_view->search_mode = ! empty( $widget_args[ 'search_mode' ] ) ? $widget_args[ 'search_mode' ] : 'any';
757 757
 
758
-		$custom_class = ! empty( $widget_args['custom_class'] ) ? $widget_args['custom_class'] : '';
758
+		$custom_class = ! empty( $widget_args[ 'custom_class' ] ) ? $widget_args[ 'custom_class' ] : '';
759 759
 
760 760
 		$gravityview_view->search_class = self::get_search_class( $custom_class );
761 761
 
762
-		$gravityview_view->search_clear = ! empty( $widget_args['search_clear'] ) ? $widget_args['search_clear'] : false;
762
+		$gravityview_view->search_clear = ! empty( $widget_args[ 'search_clear' ] ) ? $widget_args[ 'search_clear' ] : false;
763 763
 
764 764
 		if ( $has_date ) {
765 765
 			// enqueue datepicker stuff only if needed!
@@ -779,10 +779,10 @@  discard block
 block discarded – undo
779 779
 	public static function get_search_class( $custom_class = '' ) {
780 780
 		$gravityview_view = GravityView_View::getInstance();
781 781
 
782
-		$search_class = 'gv-search-'.$gravityview_view->search_layout;
782
+		$search_class = 'gv-search-' . $gravityview_view->search_layout;
783 783
 
784
-		if ( ! empty( $custom_class )  ) {
785
-			$search_class .= ' '.$custom_class;
784
+		if ( ! empty( $custom_class ) ) {
785
+			$search_class .= ' ' . $custom_class;
786 786
 		}
787 787
 
788 788
 		/**
@@ -825,11 +825,11 @@  discard block
 block discarded – undo
825 825
 
826 826
 		$label = rgget( 'label', $field );
827 827
 
828
-		if( '' === $label ) {
828
+		if ( '' === $label ) {
829 829
 
830
-			$label = isset( $form_field['label'] ) ? $form_field['label'] : '';
830
+			$label = isset( $form_field[ 'label' ] ) ? $form_field[ 'label' ] : '';
831 831
 
832
-			switch( $field['field'] ) {
832
+			switch ( $field[ 'field' ] ) {
833 833
 				case 'search_all':
834 834
 					$label = __( 'Search Entries:', 'gravityview' );
835 835
 					break;
@@ -847,10 +847,10 @@  discard block
 block discarded – undo
847 847
 					break;
848 848
 				default:
849 849
 					// If this is a field input, not a field
850
-					if ( strpos( $field['field'], '.' ) > 0 && ! empty( $form_field['inputs'] ) ) {
850
+					if ( strpos( $field[ 'field' ], '.' ) > 0 && ! empty( $form_field[ 'inputs' ] ) ) {
851 851
 
852 852
 						// Get the label for the field in question, which returns an array
853
-						$items = wp_list_filter( $form_field['inputs'], array( 'id' => $field['field'] ) );
853
+						$items = wp_list_filter( $form_field[ 'inputs' ], array( 'id' => $field[ 'field' ] ) );
854 854
 
855 855
 						// Get the item with the `label` key
856 856
 						$values = wp_list_pluck( $items, 'label' );
@@ -887,7 +887,7 @@  discard block
 block discarded – undo
887 887
 		$form = $gravityview_view->getForm();
888 888
 
889 889
 		// for advanced field ids (eg, first name / last name )
890
-		$name = 'filter_' . str_replace( '.', '_', $field['field'] );
890
+		$name = 'filter_' . str_replace( '.', '_', $field[ 'field' ] );
891 891
 
892 892
 		// get searched value from $_GET (string or array)
893 893
 		$value = rgget( $name );
@@ -897,26 +897,26 @@  discard block
 block discarded – undo
897 897
 		$value = is_array( $value ) ? array_map( 'urldecode', $value ) : urldecode( $value );
898 898
 
899 899
 		// get form field details
900
-		$form_field = gravityview_get_field( $form, $field['field'] );
900
+		$form_field = gravityview_get_field( $form, $field[ 'field' ] );
901 901
 
902 902
 		$filter = array(
903
-			'key' => $field['field'],
903
+			'key' => $field[ 'field' ],
904 904
 			'name' => $name,
905 905
 			'label' => self::get_field_label( $field, $form_field ),
906
-			'input' => $field['input'],
906
+			'input' => $field[ 'input' ],
907 907
 			'value' => _wp_specialchars( $value ),
908
-			'type' => $form_field['type'],
908
+			'type' => $form_field[ 'type' ],
909 909
 		);
910 910
 
911 911
 		// collect choices
912
-		if ( 'post_category' === $form_field['type'] && ! empty( $form_field['displayAllCategories'] ) && empty( $form_field['choices'] ) ) {
913
-			$filter['choices'] = gravityview_get_terms_choices();
914
-		} elseif ( ! empty( $form_field['choices'] ) ) {
915
-			$filter['choices'] = $form_field['choices'];
912
+		if ( 'post_category' === $form_field[ 'type' ] && ! empty( $form_field[ 'displayAllCategories' ] ) && empty( $form_field[ 'choices' ] ) ) {
913
+			$filter[ 'choices' ] = gravityview_get_terms_choices();
914
+		} elseif ( ! empty( $form_field[ 'choices' ] ) ) {
915
+			$filter[ 'choices' ] = $form_field[ 'choices' ];
916 916
 		}
917 917
 
918
-		if ( 'date_range' === $field['input'] && empty( $value ) ) {
919
-			$filter['value'] = array( 'start' => '', 'end' => '' );
918
+		if ( 'date_range' === $field[ 'input' ] && empty( $value ) ) {
919
+			$filter[ 'value' ] = array( 'start' => '', 'end' => '' );
920 920
 		}
921 921
 
922 922
 		return $filter;
@@ -940,7 +940,7 @@  discard block
 block discarded – undo
940 940
 
941 941
 		$choices = array();
942 942
 		foreach ( $users as $user ) {
943
-			$choices[] = array(
943
+			$choices[ ] = array(
944 944
 				'value' => $user->ID,
945 945
 				'text' => $user->display_name,
946 946
 			);
@@ -974,7 +974,7 @@  discard block
 block discarded – undo
974 974
 	 */
975 975
 	public function add_datepicker_js_dependency( $js_dependencies ) {
976 976
 
977
-		$js_dependencies[] = 'jquery-ui-datepicker';
977
+		$js_dependencies[ ] = 'jquery-ui-datepicker';
978 978
 
979 979
 		return $js_dependencies;
980 980
 	}
@@ -1018,7 +1018,7 @@  discard block
 block discarded – undo
1018 1018
 			'isRTL'             => is_rtl(),
1019 1019
 		), $view_data );
1020 1020
 
1021
-		$localizations['datepicker'] = $datepicker_settings;
1021
+		$localizations[ 'datepicker' ] = $datepicker_settings;
1022 1022
 
1023 1023
 		return $localizations;
1024 1024
 
@@ -1041,7 +1041,7 @@  discard block
 block discarded – undo
1041 1041
 		add_filter( 'gravityview_js_localization', array( $this, 'add_datepicker_localization' ), 10, 2 );
1042 1042
 
1043 1043
 		$scheme = is_ssl() ? 'https://' : 'http://';
1044
-		wp_enqueue_style( 'jquery-ui-datepicker', $scheme.'ajax.googleapis.com/ajax/libs/jqueryui/1.8.18/themes/smoothness/jquery-ui.css' );
1044
+		wp_enqueue_style( 'jquery-ui-datepicker', $scheme . 'ajax.googleapis.com/ajax/libs/jqueryui/1.8.18/themes/smoothness/jquery-ui.css' );
1045 1045
 
1046 1046
 		/**
1047 1047
 		 * @filter `gravityview_search_datepicker_class`
Please login to merge, or discard this patch.
includes/extensions/edit-entry/class-edit-entry-render.php 2 patches
Indentation   +1436 added lines, -1436 removed lines patch added patch discarded remove patch
@@ -10,21 +10,21 @@  discard block
 block discarded – undo
10 10
  */
11 11
 
12 12
 if ( ! defined( 'WPINC' ) ) {
13
-    die;
13
+	die;
14 14
 }
15 15
 
16 16
 
17 17
 class GravityView_Edit_Entry_Render {
18 18
 
19
-    /**
20
-     * @var GravityView_Edit_Entry
21
-     */
22
-    protected $loader;
19
+	/**
20
+	 * @var GravityView_Edit_Entry
21
+	 */
22
+	protected $loader;
23 23
 
24 24
 	/**
25 25
 	 * @var string String used to generate unique nonce for the entry/form/view combination. Allows access to edit page.
26 26
 	 */
27
-    static $nonce_key;
27
+	static $nonce_key;
28 28
 
29 29
 	/**
30 30
 	 * @since 1.9
@@ -44,142 +44,142 @@  discard block
 block discarded – undo
44 44
 	 */
45 45
 	private static $supports_product_fields = false;
46 46
 
47
-    /**
48
-     * Gravity Forms entry array
49
-     *
50
-     * @var array
51
-     */
52
-    var $entry;
53
-
54
-    /**
55
-     * Gravity Forms form array (GravityView modifies the content through this class lifecycle)
56
-     *
57
-     * @var array
58
-     */
59
-    var $form;
60
-
61
-    /**
62
-     * Gravity Forms form array (it won't get changed during this class lifecycle)
63
-     * @since 1.16.2.1
64
-     * @var array
65
-     */
66
-    var $original_form;
67
-
68
-    /**
69
-     * Gravity Forms form array after the form validation process
70
-     * @since 1.13
71
-     * @var array
72
-     */
73
-    var $form_after_validation = null;
74
-
75
-    /**
76
-     * Hold an array of GF field objects that have calculation rules
77
-     * @var array
78
-     */
79
-    var $fields_with_calculation = array();
80
-
81
-    /**
82
-     * Hold an array of GF field objects with type 'total'
83
-     * @var array
84
-     */
85
-    var $total_fields = array();
86
-
87
-    /**
88
-     * Gravity Forms form id
89
-     *
90
-     * @var int
91
-     */
92
-    var $form_id;
93
-
94
-    /**
95
-     * ID of the current view
96
-     *
97
-     * @var int
98
-     */
99
-    var $view_id;
100
-
101
-    /**
102
-     * Updated entry is valid (GF Validation object)
103
-     *
104
-     * @var array
105
-     */
106
-    var $is_valid = NULL;
107
-
108
-    function __construct( GravityView_Edit_Entry $loader ) {
109
-        $this->loader = $loader;
110
-    }
111
-
112
-    function load() {
113
-
114
-        /** @define "GRAVITYVIEW_DIR" "../../../" */
115
-        include_once( GRAVITYVIEW_DIR .'includes/class-admin-approve-entries.php' );
116
-
117
-        // Don't display an embedded form when editing an entry
118
-        add_action( 'wp_head', array( $this, 'prevent_render_form' ) );
119
-        add_action( 'wp_footer', array( $this, 'prevent_render_form' ) );
120
-
121
-        // Stop Gravity Forms processing what is ours!
122
-        add_filter( 'wp', array( $this, 'prevent_maybe_process_form'), 8 );
123
-
124
-        add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry') );
125
-
126
-        add_action( 'gravityview_edit_entry', array( $this, 'init' ) );
127
-
128
-        // Disable conditional logic if needed (since 1.9)
129
-        add_filter( 'gform_has_conditional_logic', array( $this, 'manage_conditional_logic' ), 10, 2 );
130
-
131
-        // Make sure GF doesn't validate max files (since 1.9)
132
-        add_filter( 'gform_plupload_settings', array( $this, 'modify_fileupload_settings' ), 10, 3 );
133
-
134
-        // Add fields expected by GFFormDisplay::validate()
135
-        add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation') );
136
-
137
-    }
138
-
139
-    /**
140
-     * Don't show any forms embedded on a page when GravityView is in Edit Entry mode
141
-     *
142
-     * Adds a `__return_empty_string` filter on the Gravity Forms shortcode on the `wp_head` action
143
-     * And then removes it on the `wp_footer` action
144
-     *
145
-     * @since 1.16.1
146
-     *
147
-     * @return void
148
-     */
149
-    function prevent_render_form() {
150
-        if( $this->is_edit_entry() ) {
151
-            if( 'wp_head' === current_filter() ) {
152
-                add_filter( 'gform_shortcode_form', '__return_empty_string' );
153
-            } else {
154
-                remove_filter( 'gform_shortcode_form', '__return_empty_string' );
155
-            }
156
-        }
157
-    }
158
-
159
-    /**
160
-     * Because we're mimicking being a front-end Gravity Forms form while using a Gravity Forms
161
-     * backend form, we need to prevent them from saving twice.
162
-     * @return void
163
-     */
164
-    function prevent_maybe_process_form() {
165
-
166
-        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[prevent_maybe_process_form] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
167
-
168
-        if( $this->is_edit_entry_submission() && $this->verify_nonce() ) {
169
-            remove_action( 'wp',  array( 'RGForms', 'maybe_process_form'), 9 );
170
-        }
171
-    }
172
-
173
-    /**
174
-     * Is the current page an Edit Entry page?
175
-     * @return boolean
176
-     */
177
-    public function is_edit_entry() {
178
-
179
-        $gf_page = ( 'entry' === RGForms::get( 'view' ) );
180
-
181
-        return ( $gf_page && isset( $_GET['edit'] ) || RGForms::post( 'action' ) === 'update' );
182
-    }
47
+	/**
48
+	 * Gravity Forms entry array
49
+	 *
50
+	 * @var array
51
+	 */
52
+	var $entry;
53
+
54
+	/**
55
+	 * Gravity Forms form array (GravityView modifies the content through this class lifecycle)
56
+	 *
57
+	 * @var array
58
+	 */
59
+	var $form;
60
+
61
+	/**
62
+	 * Gravity Forms form array (it won't get changed during this class lifecycle)
63
+	 * @since 1.16.2.1
64
+	 * @var array
65
+	 */
66
+	var $original_form;
67
+
68
+	/**
69
+	 * Gravity Forms form array after the form validation process
70
+	 * @since 1.13
71
+	 * @var array
72
+	 */
73
+	var $form_after_validation = null;
74
+
75
+	/**
76
+	 * Hold an array of GF field objects that have calculation rules
77
+	 * @var array
78
+	 */
79
+	var $fields_with_calculation = array();
80
+
81
+	/**
82
+	 * Hold an array of GF field objects with type 'total'
83
+	 * @var array
84
+	 */
85
+	var $total_fields = array();
86
+
87
+	/**
88
+	 * Gravity Forms form id
89
+	 *
90
+	 * @var int
91
+	 */
92
+	var $form_id;
93
+
94
+	/**
95
+	 * ID of the current view
96
+	 *
97
+	 * @var int
98
+	 */
99
+	var $view_id;
100
+
101
+	/**
102
+	 * Updated entry is valid (GF Validation object)
103
+	 *
104
+	 * @var array
105
+	 */
106
+	var $is_valid = NULL;
107
+
108
+	function __construct( GravityView_Edit_Entry $loader ) {
109
+		$this->loader = $loader;
110
+	}
111
+
112
+	function load() {
113
+
114
+		/** @define "GRAVITYVIEW_DIR" "../../../" */
115
+		include_once( GRAVITYVIEW_DIR .'includes/class-admin-approve-entries.php' );
116
+
117
+		// Don't display an embedded form when editing an entry
118
+		add_action( 'wp_head', array( $this, 'prevent_render_form' ) );
119
+		add_action( 'wp_footer', array( $this, 'prevent_render_form' ) );
120
+
121
+		// Stop Gravity Forms processing what is ours!
122
+		add_filter( 'wp', array( $this, 'prevent_maybe_process_form'), 8 );
123
+
124
+		add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry') );
125
+
126
+		add_action( 'gravityview_edit_entry', array( $this, 'init' ) );
127
+
128
+		// Disable conditional logic if needed (since 1.9)
129
+		add_filter( 'gform_has_conditional_logic', array( $this, 'manage_conditional_logic' ), 10, 2 );
130
+
131
+		// Make sure GF doesn't validate max files (since 1.9)
132
+		add_filter( 'gform_plupload_settings', array( $this, 'modify_fileupload_settings' ), 10, 3 );
133
+
134
+		// Add fields expected by GFFormDisplay::validate()
135
+		add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation') );
136
+
137
+	}
138
+
139
+	/**
140
+	 * Don't show any forms embedded on a page when GravityView is in Edit Entry mode
141
+	 *
142
+	 * Adds a `__return_empty_string` filter on the Gravity Forms shortcode on the `wp_head` action
143
+	 * And then removes it on the `wp_footer` action
144
+	 *
145
+	 * @since 1.16.1
146
+	 *
147
+	 * @return void
148
+	 */
149
+	function prevent_render_form() {
150
+		if( $this->is_edit_entry() ) {
151
+			if( 'wp_head' === current_filter() ) {
152
+				add_filter( 'gform_shortcode_form', '__return_empty_string' );
153
+			} else {
154
+				remove_filter( 'gform_shortcode_form', '__return_empty_string' );
155
+			}
156
+		}
157
+	}
158
+
159
+	/**
160
+	 * Because we're mimicking being a front-end Gravity Forms form while using a Gravity Forms
161
+	 * backend form, we need to prevent them from saving twice.
162
+	 * @return void
163
+	 */
164
+	function prevent_maybe_process_form() {
165
+
166
+		do_action('gravityview_log_debug', 'GravityView_Edit_Entry[prevent_maybe_process_form] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
167
+
168
+		if( $this->is_edit_entry_submission() && $this->verify_nonce() ) {
169
+			remove_action( 'wp',  array( 'RGForms', 'maybe_process_form'), 9 );
170
+		}
171
+	}
172
+
173
+	/**
174
+	 * Is the current page an Edit Entry page?
175
+	 * @return boolean
176
+	 */
177
+	public function is_edit_entry() {
178
+
179
+		$gf_page = ( 'entry' === RGForms::get( 'view' ) );
180
+
181
+		return ( $gf_page && isset( $_GET['edit'] ) || RGForms::post( 'action' ) === 'update' );
182
+	}
183 183
 
184 184
 	/**
185 185
 	 * Is the current page an Edit Entry page?
@@ -190,522 +190,522 @@  discard block
 block discarded – undo
190 190
 		return !empty( $_POST[ self::$nonce_field ] );
191 191
 	}
192 192
 
193
-    /**
194
-     * When Edit entry view is requested setup the vars
195
-     */
196
-    function setup_vars() {
197
-        $gravityview_view = GravityView_View::getInstance();
193
+	/**
194
+	 * When Edit entry view is requested setup the vars
195
+	 */
196
+	function setup_vars() {
197
+		$gravityview_view = GravityView_View::getInstance();
198 198
 
199 199
 
200
-        $entries = $gravityview_view->getEntries();
201
-        $this->entry = $entries[0];
200
+		$entries = $gravityview_view->getEntries();
201
+		$this->entry = $entries[0];
202 202
 
203
-        $this->original_form = $this->form = $gravityview_view->getForm();
204
-        $this->form_id = $gravityview_view->getFormId();
205
-        $this->view_id = $gravityview_view->getViewId();
203
+		$this->original_form = $this->form = $gravityview_view->getForm();
204
+		$this->form_id = $gravityview_view->getFormId();
205
+		$this->view_id = $gravityview_view->getViewId();
206 206
 
207
-        self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry['id'] );
208
-    }
207
+		self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry['id'] );
208
+	}
209 209
 
210 210
 
211
-    /**
212
-     * Load required files and trigger edit flow
213
-     *
214
-     * Run when the is_edit_entry returns true.
215
-     *
216
-     * @param GravityView_View_Data $gv_data GravityView Data object
217
-     * @return void
218
-     */
219
-    function init( $gv_data ) {
211
+	/**
212
+	 * Load required files and trigger edit flow
213
+	 *
214
+	 * Run when the is_edit_entry returns true.
215
+	 *
216
+	 * @param GravityView_View_Data $gv_data GravityView Data object
217
+	 * @return void
218
+	 */
219
+	function init( $gv_data ) {
220 220
 
221
-        require_once( GFCommon::get_base_path() . '/form_display.php' );
222
-        require_once( GFCommon::get_base_path() . '/entry_detail.php' );
221
+		require_once( GFCommon::get_base_path() . '/form_display.php' );
222
+		require_once( GFCommon::get_base_path() . '/entry_detail.php' );
223 223
 
224
-        $this->setup_vars();
224
+		$this->setup_vars();
225 225
 
226
-        // Multiple Views embedded, don't proceed if nonce fails
227
-        if( $gv_data->has_multiple_views() && ! wp_verify_nonce( $_GET['edit'], self::$nonce_key ) ) {
228
-            return;
229
-        }
226
+		// Multiple Views embedded, don't proceed if nonce fails
227
+		if( $gv_data->has_multiple_views() && ! wp_verify_nonce( $_GET['edit'], self::$nonce_key ) ) {
228
+			return;
229
+		}
230 230
 
231
-        // Sorry, you're not allowed here.
232
-        if( false === $this->user_can_edit_entry( true ) ) {
233
-            return;
234
-        }
231
+		// Sorry, you're not allowed here.
232
+		if( false === $this->user_can_edit_entry( true ) ) {
233
+			return;
234
+		}
235 235
 
236
-        $this->print_scripts();
236
+		$this->print_scripts();
237 237
 
238
-        $this->process_save();
238
+		$this->process_save();
239 239
 
240
-        $this->edit_entry_form();
240
+		$this->edit_entry_form();
241 241
 
242
-    }
242
+	}
243 243
 
244 244
 
245
-    /**
246
-     * Force Gravity Forms to output scripts as if it were in the admin
247
-     * @return void
248
-     */
249
-    function print_scripts() {
250
-        $gravityview_view = GravityView_View::getInstance();
245
+	/**
246
+	 * Force Gravity Forms to output scripts as if it were in the admin
247
+	 * @return void
248
+	 */
249
+	function print_scripts() {
250
+		$gravityview_view = GravityView_View::getInstance();
251 251
 
252
-        wp_register_script( 'gform_gravityforms', GFCommon::get_base_url().'/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
252
+		wp_register_script( 'gform_gravityforms', GFCommon::get_base_url().'/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
253 253
 
254
-        GFFormDisplay::enqueue_form_scripts($gravityview_view->getForm(), false);
254
+		GFFormDisplay::enqueue_form_scripts($gravityview_view->getForm(), false);
255 255
 
256
-        // Sack is required for images
257
-        wp_print_scripts( array( 'sack', 'gform_gravityforms' ) );
258
-    }
256
+		// Sack is required for images
257
+		wp_print_scripts( array( 'sack', 'gform_gravityforms' ) );
258
+	}
259 259
 
260 260
 
261
-    /**
262
-     * Process edit entry form save
263
-     */
264
-    function process_save() {
261
+	/**
262
+	 * Process edit entry form save
263
+	 */
264
+	function process_save() {
265 265
 
266
-        if( empty( $_POST ) ) {
267
-            return;
268
-        }
266
+		if( empty( $_POST ) ) {
267
+			return;
268
+		}
269 269
 
270
-        // Make sure the entry, view, and form IDs are all correct
271
-        $valid = $this->verify_nonce();
270
+		// Make sure the entry, view, and form IDs are all correct
271
+		$valid = $this->verify_nonce();
272 272
 
273
-        if( !$valid ) {
274
-            do_action('gravityview_log_error', __METHOD__ . ' Nonce validation failed.' );
275
-            return;
276
-        }
273
+		if( !$valid ) {
274
+			do_action('gravityview_log_error', __METHOD__ . ' Nonce validation failed.' );
275
+			return;
276
+		}
277 277
 
278
-        if( $this->entry['id'] !== $_POST['lid'] ) {
279
-            do_action('gravityview_log_error', __METHOD__ . ' Entry ID did not match posted entry ID.' );
280
-            return;
281
-        }
278
+		if( $this->entry['id'] !== $_POST['lid'] ) {
279
+			do_action('gravityview_log_error', __METHOD__ . ' Entry ID did not match posted entry ID.' );
280
+			return;
281
+		}
282 282
 
283
-        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[process_save] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
283
+		do_action('gravityview_log_debug', 'GravityView_Edit_Entry[process_save] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
284 284
 
285
-        $this->process_save_process_files( $this->form_id );
285
+		$this->process_save_process_files( $this->form_id );
286 286
 
287
-        $this->validate();
287
+		$this->validate();
288 288
 
289
-        if( $this->is_valid ) {
289
+		if( $this->is_valid ) {
290 290
 
291
-            do_action('gravityview_log_debug', 'GravityView_Edit_Entry[process_save] Submission is valid.' );
291
+			do_action('gravityview_log_debug', 'GravityView_Edit_Entry[process_save] Submission is valid.' );
292 292
 
293
-            /**
294
-             * @hack This step is needed to unset the adminOnly from form fields, to add the calculation fields
295
-             */
296
-            $form = $this->form_prepare_for_save();
293
+			/**
294
+			 * @hack This step is needed to unset the adminOnly from form fields, to add the calculation fields
295
+			 */
296
+			$form = $this->form_prepare_for_save();
297 297
 
298
-            /**
299
-             * @hack to avoid the capability validation of the method save_lead for GF 1.9+
300
-             */
301
-            unset( $_GET['page'] );
298
+			/**
299
+			 * @hack to avoid the capability validation of the method save_lead for GF 1.9+
300
+			 */
301
+			unset( $_GET['page'] );
302 302
 
303
-            GFFormsModel::save_lead( $form, $this->entry );
303
+			GFFormsModel::save_lead( $form, $this->entry );
304 304
 
305
-            // If there's a post associated with the entry, process post fields
306
-            if( !empty( $this->entry['post_id'] ) ) {
307
-                $this->maybe_update_post_fields( $form );
308
-            }
305
+			// If there's a post associated with the entry, process post fields
306
+			if( !empty( $this->entry['post_id'] ) ) {
307
+				$this->maybe_update_post_fields( $form );
308
+			}
309 309
 
310
-            // Process calculation fields
311
-            $this->update_calculation_fields();
310
+			// Process calculation fields
311
+			$this->update_calculation_fields();
312 312
 
313
-            // Perform actions normally performed after updating a lead
314
-            $this->after_update();
313
+			// Perform actions normally performed after updating a lead
314
+			$this->after_update();
315 315
 
316
-            /**
317
-             * @action `gravityview/edit_entry/after_update` Perform an action after the entry has been updated using Edit Entry
318
-             * @param array $form Gravity Forms form array
319
-             * @param string $entry_id Numeric ID of the entry that was updated
320
-             */
321
-            do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry['id'] );
322
-        }
316
+			/**
317
+			 * @action `gravityview/edit_entry/after_update` Perform an action after the entry has been updated using Edit Entry
318
+			 * @param array $form Gravity Forms form array
319
+			 * @param string $entry_id Numeric ID of the entry that was updated
320
+			 */
321
+			do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry['id'] );
322
+		}
323 323
 
324
-    } // process_save
324
+	} // process_save
325 325
 
326 326
 
327
-    /**
328
-     * Have GF handle file uploads
329
-     *
330
-     * Copy of code from GFFormDisplay::process_form()
331
-     *
332
-     * @param int $form_id
333
-     */
334
-    function process_save_process_files( $form_id ) {
327
+	/**
328
+	 * Have GF handle file uploads
329
+	 *
330
+	 * Copy of code from GFFormDisplay::process_form()
331
+	 *
332
+	 * @param int $form_id
333
+	 */
334
+	function process_save_process_files( $form_id ) {
335 335
 
336
-        //Loading files that have been uploaded to temp folder
337
-        $files = GFCommon::json_decode( stripslashes( RGForms::post( 'gform_uploaded_files' ) ) );
338
-        if ( ! is_array( $files ) ) {
339
-            $files = array();
340
-        }
336
+		//Loading files that have been uploaded to temp folder
337
+		$files = GFCommon::json_decode( stripslashes( RGForms::post( 'gform_uploaded_files' ) ) );
338
+		if ( ! is_array( $files ) ) {
339
+			$files = array();
340
+		}
341 341
 
342
-        RGFormsModel::$uploaded_files[ $form_id ] = $files;
343
-    }
342
+		RGFormsModel::$uploaded_files[ $form_id ] = $files;
343
+	}
344 344
 
345
-    /**
346
-     * Remove max_files validation (done on gravityforms.js) to avoid conflicts with GravityView
347
-     * Late validation done on self::custom_validation
348
-     *
349
-     * @param $plupload_init array Plupload settings
350
-     * @param $form_id
351
-     * @param $instance
352
-     * @return mixed
353
-     */
354
-    public function modify_fileupload_settings( $plupload_init, $form_id, $instance ) {
355
-        if( ! $this->is_edit_entry() ) {
356
-            return $plupload_init;
357
-        }
345
+	/**
346
+	 * Remove max_files validation (done on gravityforms.js) to avoid conflicts with GravityView
347
+	 * Late validation done on self::custom_validation
348
+	 *
349
+	 * @param $plupload_init array Plupload settings
350
+	 * @param $form_id
351
+	 * @param $instance
352
+	 * @return mixed
353
+	 */
354
+	public function modify_fileupload_settings( $plupload_init, $form_id, $instance ) {
355
+		if( ! $this->is_edit_entry() ) {
356
+			return $plupload_init;
357
+		}
358 358
 
359
-        $plupload_init['gf_vars']['max_files'] = 0;
359
+		$plupload_init['gf_vars']['max_files'] = 0;
360 360
 
361
-        return $plupload_init;
362
-    }
361
+		return $plupload_init;
362
+	}
363 363
 
364 364
 
365
-    /**
366
-     * Unset adminOnly and convert field input key to string
367
-     * @return array $form
368
-     */
369
-    private function form_prepare_for_save() {
365
+	/**
366
+	 * Unset adminOnly and convert field input key to string
367
+	 * @return array $form
368
+	 */
369
+	private function form_prepare_for_save() {
370 370
 
371
-        $form = $this->form;
371
+		$form = $this->form;
372 372
 
373
-        foreach( $form['fields'] as &$field ) {
373
+		foreach( $form['fields'] as &$field ) {
374 374
 
375
-            $field->adminOnly = false;
375
+			$field->adminOnly = false;
376 376
 
377
-            if( isset( $field->inputs ) && is_array( $field->inputs ) ) {
378
-                foreach( $field->inputs as $key => $input ) {
379
-                    $field->inputs[ $key ][ 'id' ] = (string)$input['id'];
380
-                }
381
-            }
382
-        }
377
+			if( isset( $field->inputs ) && is_array( $field->inputs ) ) {
378
+				foreach( $field->inputs as $key => $input ) {
379
+					$field->inputs[ $key ][ 'id' ] = (string)$input['id'];
380
+				}
381
+			}
382
+		}
383 383
 
384
-        return $form;
385
-    }
384
+		return $form;
385
+	}
386 386
 
387
-    private function update_calculation_fields() {
387
+	private function update_calculation_fields() {
388
+
389
+		$form = $this->original_form;
390
+		$update = false;
391
+
392
+		// get the most up to date entry values
393
+		$entry = GFAPI::get_entry( $this->entry['id'] );
394
+
395
+		if( !empty( $this->fields_with_calculation ) ) {
396
+			$update = true;
397
+			foreach ( $this->fields_with_calculation as $calc_field ) {
398
+				$inputs = $calc_field->get_entry_inputs();
399
+				if ( is_array( $inputs ) ) {
400
+					foreach ( $inputs as $input ) {
401
+						$input_name = 'input_' . str_replace( '.', '_', $input['id'] );
402
+						$entry[ strval( $input['id'] ) ] = RGFormsModel::prepare_value( $form, $calc_field, '', $input_name, $entry['id'], $entry );
403
+					}
404
+				} else {
405
+					$input_name = 'input_' . str_replace( '.', '_', $calc_field->id);
406
+					$entry[ strval( $calc_field->id ) ] = RGFormsModel::prepare_value( $form, $calc_field, '', $input_name, $entry['id'], $entry );
407
+				}
408
+			}
388 409
 
389
-        $form = $this->original_form;
390
-        $update = false;
391
-
392
-        // get the most up to date entry values
393
-        $entry = GFAPI::get_entry( $this->entry['id'] );
394
-
395
-        if( !empty( $this->fields_with_calculation ) ) {
396
-            $update = true;
397
-            foreach ( $this->fields_with_calculation as $calc_field ) {
398
-                $inputs = $calc_field->get_entry_inputs();
399
-                if ( is_array( $inputs ) ) {
400
-                    foreach ( $inputs as $input ) {
401
-                        $input_name = 'input_' . str_replace( '.', '_', $input['id'] );
402
-                        $entry[ strval( $input['id'] ) ] = RGFormsModel::prepare_value( $form, $calc_field, '', $input_name, $entry['id'], $entry );
403
-                    }
404
-                } else {
405
-                    $input_name = 'input_' . str_replace( '.', '_', $calc_field->id);
406
-                    $entry[ strval( $calc_field->id ) ] = RGFormsModel::prepare_value( $form, $calc_field, '', $input_name, $entry['id'], $entry );
407
-                }
408
-            }
409
-
410
-        }
411
-
412
-        //saving total field as the last field of the form.
413
-        if ( ! empty( $this->total_fields ) ) {
414
-            $update = true;
415
-            foreach ( $this->total_fields as $total_field ) {
416
-                $input_name = 'input_' . str_replace( '.', '_', $total_field->id);
417
-                $entry[ strval( $total_field->id ) ] = RGFormsModel::prepare_value( $form, $total_field, '', $input_name, $entry['id'], $entry );
418
-            }
419
-        }
420
-
421
-        if( $update ) {
422
-
423
-            $return_entry = GFAPI::update_entry( $entry );
424
-
425
-            if( is_wp_error( $return_entry ) ) {
426
-                do_action( 'gravityview_log_error', 'Updating the entry calculation and total fields failed', $return_entry );
427
-            } else {
428
-                do_action( 'gravityview_log_debug', 'Updating the entry calculation and total fields succeeded' );
429
-            }
430
-        }
431
-    }
432
-
433
-
434
-    /**
435
-     * Loop through the fields being edited and if they include Post fields, update the Entry's post object
436
-     *
437
-     * @param array $form Gravity Forms form
438
-     *
439
-     * @return void
440
-     */
441
-    function maybe_update_post_fields( $form ) {
442
-
443
-        $post_id = $this->entry['post_id'];
410
+		}
444 411
 
445
-        // Security check
446
-        if( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
447
-            do_action( 'gravityview_log_error', 'The current user does not have the ability to edit Post #'.$post_id );
448
-            return;
449
-        }
412
+		//saving total field as the last field of the form.
413
+		if ( ! empty( $this->total_fields ) ) {
414
+			$update = true;
415
+			foreach ( $this->total_fields as $total_field ) {
416
+				$input_name = 'input_' . str_replace( '.', '_', $total_field->id);
417
+				$entry[ strval( $total_field->id ) ] = RGFormsModel::prepare_value( $form, $total_field, '', $input_name, $entry['id'], $entry );
418
+			}
419
+		}
450 420
 
451
-        $update_entry = false;
421
+		if( $update ) {
452 422
 
453
-        $updated_post = $original_post = get_post( $post_id );
423
+			$return_entry = GFAPI::update_entry( $entry );
454 424
 
455
-        // get the most up to date entry values
456
-        $entry = GFAPI::get_entry( $this->entry['id'] );
425
+			if( is_wp_error( $return_entry ) ) {
426
+				do_action( 'gravityview_log_error', 'Updating the entry calculation and total fields failed', $return_entry );
427
+			} else {
428
+				do_action( 'gravityview_log_debug', 'Updating the entry calculation and total fields succeeded' );
429
+			}
430
+		}
431
+	}
457 432
 
458
-        foreach ( $entry as $field_id => $value ) {
459 433
 
460
-            //todo: only run through the edit entry configured fields
434
+	/**
435
+	 * Loop through the fields being edited and if they include Post fields, update the Entry's post object
436
+	 *
437
+	 * @param array $form Gravity Forms form
438
+	 *
439
+	 * @return void
440
+	 */
441
+	function maybe_update_post_fields( $form ) {
461 442
 
462
-            $field = RGFormsModel::get_field( $form, $field_id );
443
+		$post_id = $this->entry['post_id'];
463 444
 
464
-            if( class_exists('GF_Fields') ) {
465
-                $field = GF_Fields::create( $field );
466
-            }
445
+		// Security check
446
+		if( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
447
+			do_action( 'gravityview_log_error', 'The current user does not have the ability to edit Post #'.$post_id );
448
+			return;
449
+		}
467 450
 
468
-            if( GFCommon::is_post_field( $field ) ) {
451
+		$update_entry = false;
469 452
 
470
-                // Get the value of the field, including $_POSTed value
471
-                $value = RGFormsModel::get_field_value( $field );
453
+		$updated_post = $original_post = get_post( $post_id );
472 454
 
473
-                switch( $field->type ) {
455
+		// get the most up to date entry values
456
+		$entry = GFAPI::get_entry( $this->entry['id'] );
474 457
 
475
-                    case 'post_title':
476
-                    case 'post_content':
477
-                    case 'post_excerpt':
478
-                        $updated_post->{$field->type} = $value;
479
-                        break;
480
-                    case 'post_tags':
481
-                        wp_set_post_tags( $post_id, $value, false );
482
-                        break;
483
-                    case 'post_category':
458
+		foreach ( $entry as $field_id => $value ) {
484 459
 
485
-                        $categories = is_array( $value ) ? array_values( $value ) : (array)$value;
486
-                        $categories = array_filter( $categories );
460
+			//todo: only run through the edit entry configured fields
487 461
 
488
-                        wp_set_post_categories( $post_id, $categories, false );
462
+			$field = RGFormsModel::get_field( $form, $field_id );
489 463
 
490
-                        // if post_category is type checkbox, then value is an array of inputs
491
-                        if( isset( $value[ strval( $field_id ) ] ) ) {
492
-                            foreach( $value as $input_id => $val ) {
493
-                                $input_name = 'input_' . str_replace( '.', '_', $input_id );
494
-                                $entry[ strval( $input_id ) ] = RGFormsModel::prepare_value( $form, $field, $val, $input_name, $entry['id'], $entry );
495
-                            }
496
-                        } else {
497
-                            $input_name = 'input_' . str_replace( '.', '_', $field_id );
498
-                            $entry[ strval( $field_id ) ] = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], $entry );
499
-                        }
464
+			if( class_exists('GF_Fields') ) {
465
+				$field = GF_Fields::create( $field );
466
+			}
500 467
 
501
-                        break;
502
-                    case 'post_custom_field':
468
+			if( GFCommon::is_post_field( $field ) ) {
503 469
 
504
-                        $input_type = RGFormsModel::get_input_type( $field );
505
-                        $custom_field_name = $field->postCustomFieldName;
470
+				// Get the value of the field, including $_POSTed value
471
+				$value = RGFormsModel::get_field_value( $field );
506 472
 
507
-                        // Only certain custom field types are supported
508
-                        switch( $input_type ) {
509
-                            case 'fileupload':
510
-                            /** @noinspection PhpMissingBreakStatementInspection */
511
-                            case 'list':
512
-                                if( ! is_string( $value ) ) {
513
-                                    $value = function_exists('wp_json_encode') ? wp_json_encode( $value ) : json_encode( $value );
514
-                                }
515
-                            // break; left intentionally out
516
-                            default:
517
-                                update_post_meta( $post_id, $custom_field_name, $value );
518
-                        }
473
+				switch( $field->type ) {
519 474
 
520
-                        break;
475
+					case 'post_title':
476
+					case 'post_content':
477
+					case 'post_excerpt':
478
+						$updated_post->{$field->type} = $value;
479
+						break;
480
+					case 'post_tags':
481
+						wp_set_post_tags( $post_id, $value, false );
482
+						break;
483
+					case 'post_category':
521 484
 
522
-                    case 'post_image':
485
+						$categories = is_array( $value ) ? array_values( $value ) : (array)$value;
486
+						$categories = array_filter( $categories );
523 487
 
524
-                        $input_name = 'input_' . $field_id;
488
+						wp_set_post_categories( $post_id, $categories, false );
525 489
 
526
-                        if ( !empty( $_FILES[ $input_name ]['name'] ) ) {
490
+						// if post_category is type checkbox, then value is an array of inputs
491
+						if( isset( $value[ strval( $field_id ) ] ) ) {
492
+							foreach( $value as $input_id => $val ) {
493
+								$input_name = 'input_' . str_replace( '.', '_', $input_id );
494
+								$entry[ strval( $input_id ) ] = RGFormsModel::prepare_value( $form, $field, $val, $input_name, $entry['id'], $entry );
495
+							}
496
+						} else {
497
+							$input_name = 'input_' . str_replace( '.', '_', $field_id );
498
+							$entry[ strval( $field_id ) ] = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], $entry );
499
+						}
527 500
 
528
-                            // We have a new image
501
+						break;
502
+					case 'post_custom_field':
529 503
 
530
-                            $value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'] );
504
+						$input_type = RGFormsModel::get_input_type( $field );
505
+						$custom_field_name = $field->postCustomFieldName;
531 506
 
532
-                            // is this field set as featured image, if not, leave
533
-                            if ( ! $field->postFeaturedImage ) {
534
-                                break;
535
-                            }
507
+						// Only certain custom field types are supported
508
+						switch( $input_type ) {
509
+							case 'fileupload':
510
+							/** @noinspection PhpMissingBreakStatementInspection */
511
+							case 'list':
512
+								if( ! is_string( $value ) ) {
513
+									$value = function_exists('wp_json_encode') ? wp_json_encode( $value ) : json_encode( $value );
514
+								}
515
+							// break; left intentionally out
516
+							default:
517
+								update_post_meta( $post_id, $custom_field_name, $value );
518
+						}
536 519
 
537
-                            $ary = ! empty( $value ) ? explode( '|:|', $value ) : array();
538
-                            $img_url = rgar( $ary, 0 );
520
+						break;
539 521
 
540
-                            $img_title       = count( $ary ) > 1 ? $ary[1] : '';
541
-                            $img_caption     = count( $ary ) > 2 ? $ary[2] : '';
542
-                            $img_description = count( $ary ) > 3 ? $ary[3] : '';
522
+					case 'post_image':
543 523
 
544
-                            $image_meta = array(
545
-                                'post_excerpt' => $img_caption,
546
-                                'post_content' => $img_description,
547
-                            );
524
+						$input_name = 'input_' . $field_id;
548 525
 
549
-                            //adding title only if it is not empty. It will default to the file name if it is not in the array
550
-                            if ( ! empty( $img_title ) ) {
551
-                                $image_meta['post_title'] = $img_title;
552
-                            }
526
+						if ( !empty( $_FILES[ $input_name ]['name'] ) ) {
553 527
 
554
-                            //todo: As soon as \GFFormsModel::media_handle_upload becomes a public method, move this call to \GFFormsModel::media_handle_upload and remove the hack from this class.
555
-                            require_once GRAVITYVIEW_DIR . 'includes/class-gravityview-gfformsmodel.php';
556
-                            $media_id = GravityView_GFFormsModel::media_handle_upload( $img_url, $post_id, $image_meta );
528
+							// We have a new image
557 529
 
558
-                            if ( $media_id ) {
559
-                                set_post_thumbnail( $post_id, $media_id );
560
-                            }
530
+							$value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'] );
561 531
 
562
-                            break;
532
+							// is this field set as featured image, if not, leave
533
+							if ( ! $field->postFeaturedImage ) {
534
+								break;
535
+							}
563 536
 
564
-                        } elseif ( !empty( $_POST[ $input_name ] ) && is_array( $value ) ) {
537
+							$ary = ! empty( $value ) ? explode( '|:|', $value ) : array();
538
+							$img_url = rgar( $ary, 0 );
565 539
 
566
-                            // Same image although the image title, caption or description might have changed
540
+							$img_title       = count( $ary ) > 1 ? $ary[1] : '';
541
+							$img_caption     = count( $ary ) > 2 ? $ary[2] : '';
542
+							$img_description = count( $ary ) > 3 ? $ary[3] : '';
567 543
 
568
-                            $ary = ! empty( $entry[ $field_id ] ) ? explode( '|:|', $entry[ $field_id ] ) : array();
569
-                            $img_url = rgar( $ary, 0 );
544
+							$image_meta = array(
545
+								'post_excerpt' => $img_caption,
546
+								'post_content' => $img_description,
547
+							);
570 548
 
571
-                            // is this really the same image or something went wrong ?
572
-                            if( $img_url === $_POST[ $input_name ] ) {
549
+							//adding title only if it is not empty. It will default to the file name if it is not in the array
550
+							if ( ! empty( $img_title ) ) {
551
+								$image_meta['post_title'] = $img_title;
552
+							}
573 553
 
574
-                                $img_title       = isset( $value[ $field_id .'.1' ] ) ? $value[ $field_id .'.1' ] : '';
575
-                                $img_caption     = isset( $value[ $field_id .'.4' ] ) ? $value[ $field_id .'.4' ] : '';
576
-                                $img_description = isset( $value[ $field_id .'.7' ] ) ? $value[ $field_id .'.7' ] : '';
554
+							//todo: As soon as \GFFormsModel::media_handle_upload becomes a public method, move this call to \GFFormsModel::media_handle_upload and remove the hack from this class.
555
+							require_once GRAVITYVIEW_DIR . 'includes/class-gravityview-gfformsmodel.php';
556
+							$media_id = GravityView_GFFormsModel::media_handle_upload( $img_url, $post_id, $image_meta );
577 557
 
578
-                                $value = ! empty( $img_url ) ? $img_url . "|:|" . $img_title . "|:|" . $img_caption . "|:|" . $img_description : '';
558
+							if ( $media_id ) {
559
+								set_post_thumbnail( $post_id, $media_id );
560
+							}
579 561
 
580
-                                if ( $field->postFeaturedImage ) {
562
+							break;
581 563
 
582
-                                    $image_meta = array(
583
-                                        'ID' => get_post_thumbnail_id( $post_id ),
584
-                                        'post_title' => $img_title,
585
-                                        'post_excerpt' => $img_caption,
586
-                                        'post_content' => $img_description,
587
-                                    );
564
+						} elseif ( !empty( $_POST[ $input_name ] ) && is_array( $value ) ) {
588 565
 
589
-                                    // update image title, caption or description
590
-                                    wp_update_post( $image_meta );
591
-                                }
566
+							// Same image although the image title, caption or description might have changed
592 567
 
593
-                                break;
594
-                            }
568
+							$ary = ! empty( $entry[ $field_id ] ) ? explode( '|:|', $entry[ $field_id ] ) : array();
569
+							$img_url = rgar( $ary, 0 );
595 570
 
596
-                        }
571
+							// is this really the same image or something went wrong ?
572
+							if( $img_url === $_POST[ $input_name ] ) {
597 573
 
598
-                        // if we get here, image was removed or not set.
574
+								$img_title       = isset( $value[ $field_id .'.1' ] ) ? $value[ $field_id .'.1' ] : '';
575
+								$img_caption     = isset( $value[ $field_id .'.4' ] ) ? $value[ $field_id .'.4' ] : '';
576
+								$img_description = isset( $value[ $field_id .'.7' ] ) ? $value[ $field_id .'.7' ] : '';
599 577
 
600
-                        $value = '';
601
-                        if ( $field->postFeaturedImage ) {
602
-                            delete_post_thumbnail( $post_id );
603
-                        }
578
+								$value = ! empty( $img_url ) ? $img_url . "|:|" . $img_title . "|:|" . $img_caption . "|:|" . $img_description : '';
604 579
 
605
-                        break;
580
+								if ( $field->postFeaturedImage ) {
606 581
 
607
-                }
582
+									$image_meta = array(
583
+										'ID' => get_post_thumbnail_id( $post_id ),
584
+										'post_title' => $img_title,
585
+										'post_excerpt' => $img_caption,
586
+										'post_content' => $img_description,
587
+									);
608 588
 
609
-                //ignore fields that have not changed
610
-                if ( $value === rgget( (string) $field_id, $entry ) ) {
611
-                    continue;
612
-                }
589
+									// update image title, caption or description
590
+									wp_update_post( $image_meta );
591
+								}
613 592
 
614
-                // update entry
615
-                if( 'post_category' !== $field->type ) {
616
-                    $entry[ strval( $field_id ) ] = $value;
617
-                }
593
+								break;
594
+							}
618 595
 
619
-                $update_entry = true;
596
+						}
620 597
 
621
-            }
598
+						// if we get here, image was removed or not set.
622 599
 
623
-        }
600
+						$value = '';
601
+						if ( $field->postFeaturedImage ) {
602
+							delete_post_thumbnail( $post_id );
603
+						}
624 604
 
625
-        if( $update_entry ) {
605
+						break;
626 606
 
627
-            $return_entry = GFAPI::update_entry( $entry );
607
+				}
628 608
 
629
-            if( is_wp_error( $return_entry ) ) {
630
-                do_action( 'gravityview_log_error', 'Updating the entry post fields failed', $return_entry );
631
-            } else {
632
-                do_action( 'gravityview_log_debug', 'Updating the entry post fields for post #'.$post_id.' succeeded' );
633
-            }
609
+				//ignore fields that have not changed
610
+				if ( $value === rgget( (string) $field_id, $entry ) ) {
611
+					continue;
612
+				}
634 613
 
635
-        }
614
+				// update entry
615
+				if( 'post_category' !== $field->type ) {
616
+					$entry[ strval( $field_id ) ] = $value;
617
+				}
636 618
 
637
-        $return_post = wp_update_post( $updated_post, true );
619
+				$update_entry = true;
638 620
 
639
-        if( is_wp_error( $return_post ) ) {
640
-            $return_post->add_data( $updated_post, '$updated_post' );
641
-            do_action( 'gravityview_log_error', 'Updating the post content failed', $return_post );
642
-        } else {
643
-            do_action( 'gravityview_log_debug', 'Updating the post content for post #'.$post_id.' succeeded', $updated_post );
644
-        }
621
+			}
645 622
 
646
-    }
623
+		}
647 624
 
625
+		if( $update_entry ) {
648 626
 
649
-    /**
650
-     * Perform actions normally performed after updating a lead
651
-     *
652
-     * @since 1.8
653
-     *
654
-     * @see GFEntryDetail::lead_detail_page()
655
-     *
656
-     * @return void
657
-     */
658
-    function after_update() {
627
+			$return_entry = GFAPI::update_entry( $entry );
659 628
 
660
-        do_action( 'gform_after_update_entry', $this->form, $this->entry['id'] );
661
-        do_action( "gform_after_update_entry_{$this->form['id']}", $this->form, $this->entry['id'] );
629
+			if( is_wp_error( $return_entry ) ) {
630
+				do_action( 'gravityview_log_error', 'Updating the entry post fields failed', $return_entry );
631
+			} else {
632
+				do_action( 'gravityview_log_debug', 'Updating the entry post fields for post #'.$post_id.' succeeded' );
633
+			}
662 634
 
663
-        // Re-define the entry now that we've updated it.
664
-        $entry = RGFormsModel::get_lead( $this->entry['id'] );
635
+		}
665 636
 
666
-        $entry = GFFormsModel::set_entry_meta( $entry, $this->form );
637
+		$return_post = wp_update_post( $updated_post, true );
667 638
 
668
-        // We need to clear the cache because Gravity Forms caches the field values, which
669
-        // we have just updated.
670
-        foreach ($this->form['fields'] as $key => $field) {
671
-            GFFormsModel::refresh_lead_field_value( $entry['id'], $field->id );
672
-        }
639
+		if( is_wp_error( $return_post ) ) {
640
+			$return_post->add_data( $updated_post, '$updated_post' );
641
+			do_action( 'gravityview_log_error', 'Updating the post content failed', $return_post );
642
+		} else {
643
+			do_action( 'gravityview_log_debug', 'Updating the post content for post #'.$post_id.' succeeded', $updated_post );
644
+		}
673 645
 
674
-        $this->entry = $entry;
675
-    }
646
+	}
676 647
 
677 648
 
678
-    /**
679
-     * Display the Edit Entry form
680
-     *
681
-     * @return [type] [description]
682
-     */
683
-    public function edit_entry_form() {
649
+	/**
650
+	 * Perform actions normally performed after updating a lead
651
+	 *
652
+	 * @since 1.8
653
+	 *
654
+	 * @see GFEntryDetail::lead_detail_page()
655
+	 *
656
+	 * @return void
657
+	 */
658
+	function after_update() {
659
+
660
+		do_action( 'gform_after_update_entry', $this->form, $this->entry['id'] );
661
+		do_action( "gform_after_update_entry_{$this->form['id']}", $this->form, $this->entry['id'] );
684 662
 
685
-        ?>
663
+		// Re-define the entry now that we've updated it.
664
+		$entry = RGFormsModel::get_lead( $this->entry['id'] );
665
+
666
+		$entry = GFFormsModel::set_entry_meta( $entry, $this->form );
667
+
668
+		// We need to clear the cache because Gravity Forms caches the field values, which
669
+		// we have just updated.
670
+		foreach ($this->form['fields'] as $key => $field) {
671
+			GFFormsModel::refresh_lead_field_value( $entry['id'], $field->id );
672
+		}
673
+
674
+		$this->entry = $entry;
675
+	}
676
+
677
+
678
+	/**
679
+	 * Display the Edit Entry form
680
+	 *
681
+	 * @return [type] [description]
682
+	 */
683
+	public function edit_entry_form() {
684
+
685
+		?>
686 686
 
687 687
         <div class="gv-edit-entry-wrapper"><?php
688 688
 
689
-            $javascript = gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/inline-javascript.php', $this );
689
+			$javascript = gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/inline-javascript.php', $this );
690 690
 
691
-            /**
692
-             * Fixes weird wpautop() issue
693
-             * @see https://github.com/katzwebservices/GravityView/issues/451
694
-             */
695
-            echo gravityview_strip_whitespace( $javascript );
691
+			/**
692
+			 * Fixes weird wpautop() issue
693
+			 * @see https://github.com/katzwebservices/GravityView/issues/451
694
+			 */
695
+			echo gravityview_strip_whitespace( $javascript );
696 696
 
697
-            ?><h2 class="gv-edit-entry-title">
697
+			?><h2 class="gv-edit-entry-title">
698 698
                 <span><?php
699 699
 
700
-                    /**
701
-                     * @filter `gravityview_edit_entry_title` Modify the edit entry title
702
-                     * @param string $edit_entry_title Modify the "Edit Entry" title
703
-                     * @param GravityView_Edit_Entry_Render $this This object
704
-                     */
705
-                    $edit_entry_title = apply_filters('gravityview_edit_entry_title', __('Edit Entry', 'gravityview'), $this );
700
+					/**
701
+					 * @filter `gravityview_edit_entry_title` Modify the edit entry title
702
+					 * @param string $edit_entry_title Modify the "Edit Entry" title
703
+					 * @param GravityView_Edit_Entry_Render $this This object
704
+					 */
705
+					$edit_entry_title = apply_filters('gravityview_edit_entry_title', __('Edit Entry', 'gravityview'), $this );
706 706
 
707
-                    echo esc_attr( $edit_entry_title );
708
-            ?></span>
707
+					echo esc_attr( $edit_entry_title );
708
+			?></span>
709 709
             </h2>
710 710
 
711 711
             <?php $this->maybe_print_message(); ?>
@@ -716,672 +716,672 @@  discard block
 block discarded – undo
716 716
 
717 717
                 <?php
718 718
 
719
-                wp_nonce_field( self::$nonce_key, self::$nonce_key );
719
+				wp_nonce_field( self::$nonce_key, self::$nonce_key );
720 720
 
721
-                wp_nonce_field( self::$nonce_field, self::$nonce_field, false );
721
+				wp_nonce_field( self::$nonce_field, self::$nonce_field, false );
722 722
 
723
-                // Print the actual form HTML
724
-                $this->render_edit_form();
723
+				// Print the actual form HTML
724
+				$this->render_edit_form();
725 725
 
726
-                ?>
726
+				?>
727 727
             </form>
728 728
 
729 729
         </div>
730 730
 
731 731
     <?php
732
-    }
733
-
734
-    /**
735
-     * Display success or error message if the form has been submitted
736
-     *
737
-     * @uses GVCommon::generate_notice
738
-     *
739
-     * @since TODO
740
-     *
741
-     * @return void
742
-     */
743
-    private function maybe_print_message() {
744
-
745
-        if( rgpost('action') === 'update' ) {
746
-
747
-            $back_link = esc_url( remove_query_arg( array( 'page', 'view', 'edit' ) ) );
748
-
749
-            if( ! $this->is_valid ){
750
-
751
-                // Keeping this compatible with Gravity Forms.
752
-                $validation_message = "<div class='validation_error'>" . __('There was a problem with your submission.', 'gravityview') . " " . __('Errors have been highlighted below.', 'gravityview') . "</div>";
753
-                $message = apply_filters("gform_validation_message_{$this->form['id']}", apply_filters("gform_validation_message", $validation_message, $this->form), $this->form);
754
-
755
-                echo GVCommon::generate_notice( $message , 'gv-error' );
756
-
757
-            } else {
758
-                $entry_updated_message = sprintf( esc_attr__('Entry Updated. %sReturn to Entry%s', 'gravityview'), '<a href="'. $back_link .'">', '</a>' );
759
-
760
-                /**
761
-                 * @filter `gravityview/edit_entry/success` Modify the edit entry success message (including the anchor link)
762
-                 * @since 1.5.4
763
-                 * @param string $entry_updated_message Existing message
764
-                 * @param int $view_id View ID
765
-                 * @param array $entry Gravity Forms entry array
766
-                 * @param string $back_link URL to return to the original entry. @since 1.6
767
-                 */
768
-                $message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message , $this->view_id, $this->entry, $back_link );
769
-
770
-                echo GVCommon::generate_notice( $message );
771
-            }
772
-
773
-        }
774
-    }
775
-
776
-    /**
777
-     * Display the Edit Entry form in the original Gravity Forms format
778
-     *
779
-     * @since 1.9
780
-     *
781
-     * @param $form
782
-     * @param $lead
783
-     * @param $view_id
784
-     *
785
-     * @return void
786
-     */
787
-    private function render_edit_form() {
788
-
789
-        add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields'), 5000, 3 );
790
-        add_filter( 'gform_submit_button', array( $this, 'render_form_buttons') );
791
-        add_filter( 'gform_disable_view_counter', '__return_true' );
792
-
793
-        add_filter( 'gform_field_input', array( $this, 'verify_user_can_edit_post' ), 5, 5 );
794
-        add_filter( 'gform_field_input', array( $this, 'modify_edit_field_input' ), 10, 5 );
795
-
796
-        // We need to remove the fake $_GET['page'] arg to avoid rendering form as if in admin.
797
-        unset( $_GET['page'] );
798
-
799
-        // TODO: Make sure validation isn't handled by GF
800
-        // TODO: Include CSS for file upload fields
801
-        // TODO: Verify multiple-page forms
802
-        // TODO: Product fields are not editable
803
-        // TODO: Check Updated and Error messages
804
-
805
-        $html = GFFormDisplay::get_form( $this->form['id'], false, false, true, $this->entry );
806
-
807
-	    remove_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields' ), 5000 );
808
-        remove_filter( 'gform_submit_button', array( $this, 'render_form_buttons' ) );
809
-        remove_filter( 'gform_disable_view_counter', '__return_true' );
810
-        remove_filter( 'gform_field_input', array( $this, 'verify_user_can_edit_post' ), 5 );
811
-        remove_filter( 'gform_field_input', array( $this, 'modify_edit_field_input' ), 10 );
812
-
813
-        echo $html;
814
-    }
815
-
816
-    /**
817
-     * Display the Update/Cancel/Delete buttons for the Edit Entry form
818
-     * @since 1.8
819
-     * @return string
820
-     */
821
-    public function render_form_buttons() {
822
-        return gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/form-buttons.php', $this );
823
-    }
824
-
825
-
826
-    /**
827
-     * Modify the form fields that are shown when using GFFormDisplay::get_form()
828
-     *
829
-     * By default, all fields will be shown. We only want the Edit Tab configured fields to be shown.
830
-     *
831
-     * @param array $form
832
-     * @param boolean $ajax Whether in AJAX mode
833
-     * @param array|string $field_values Passed parameters to the form
834
-     *
835
-     * @since 1.9
836
-     *
837
-     * @return array Modified form array
838
-     */
839
-    public function filter_modify_form_fields( $form, $ajax = false, $field_values = '' ) {
840
-
841
-        // In case we have validated the form, use it to inject the validation results into the form render
842
-        if( isset( $this->form_after_validation ) ) {
843
-            $form = $this->form_after_validation;
844
-        } else {
845
-            $form['fields'] = $this->get_configured_edit_fields( $form, $this->view_id );
846
-        }
847
-
848
-        $form = $this->filter_conditional_logic( $form );
849
-
850
-        // for now we don't support Save and Continue feature.
851
-        if( ! self::$supports_save_and_continue ) {
852
-	        unset( $form['save'] );
853
-        }
854
-
855
-        return $form;
856
-    }
857
-
858
-    /**
859
-     * When displaying a field, check if it's a Post Field, and if so, make sure the post exists and current user has edit rights.
860
-     *
861
-     * @since TODO
862
-     *
863
-     * @param string $field_content Always empty. Returning not-empty overrides the input.
864
-     * @param GF_Field $field
865
-     * @param string|array $value If array, it's a field with multiple inputs. If string, single input.
866
-     * @param int $lead_id Lead ID. Always 0 for the `gform_field_input` filter.
867
-     * @param int $form_id Form ID
868
-     *
869
-     * @return string If error, the error message. If no error, blank string (modify_edit_field_input() runs next)
870
-     */
871
-    function verify_user_can_edit_post( $field_content = '', $field, $value, $lead_id = 0, $form_id ) {
872
-
873
-        if( GFCommon::is_post_field( $field ) ) {
874
-
875
-            $message = null;
876
-
877
-            // First, make sure they have the capability to edit the post.
878
-            if( false === current_user_can( 'edit_post', $this->entry['post_id'] ) ) {
879
-
880
-                /**
881
-                 * @filter `gravityview/edit_entry/unsupported_post_field_text` Modify the message when someone isn't able to edit a post
882
-                 * @param string $message The existing "You don't have permission..." text
883
-                 */
884
-                $message = apply_filters('gravityview/edit_entry/unsupported_post_field_text', __('You don&rsquo;t have permission to edit this post.', 'gravityview') );
885
-
886
-            } elseif( null === get_post( $this->entry['post_id'] ) ) {
887
-                /**
888
-                 * @filter `gravityview/edit_entry/no_post_text` Modify the message when someone is editing an entry attached to a post that no longer exists
889
-                 * @param string $message The existing "This field is not editable; the post no longer exists." text
890
-                 */
891
-                $message = apply_filters('gravityview/edit_entry/no_post_text', __('This field is not editable; the post no longer exists.', 'gravityview' ) );
892
-            }
893
-
894
-            if( $message ) {
895
-                $field_content = sprintf('<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
896
-            }
897
-        }
898
-
899
-        return $field_content;
900
-    }
901
-
902
-    /**
903
-     *
904
-     * Fill-in the saved values into the form inputs
905
-     *
906
-     * @param string $field_content Always empty. Returning not-empty overrides the input.
907
-     * @param GF_Field $field
908
-     * @param string|array $value If array, it's a field with multiple inputs. If string, single input.
909
-     * @param int $lead_id Lead ID. Always 0 for the `gform_field_input` filter.
910
-     * @param int $form_id Form ID
911
-     *
912
-     * @return mixed
913
-     */
914
-    function modify_edit_field_input( $field_content = '', $field, $value, $lead_id = 0, $form_id ) {
915
-
916
-        $gv_field = GravityView_Fields::get_associated_field( $field );
917
-
918
-        // If the form has been submitted, then we don't need to pre-fill the values,
919
-        // Except for fileupload type and when a field input is overridden- run always!!
920
-        if(
921
-            ( $this->is_edit_entry_submission() && !in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
922
-            && false === ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) )
923
-            || ! empty( $field_content )
924
-            || GFCommon::is_product_field( $field->type ) // Prevent product fields from appearing editable
925
-        ) {
926
-	        return $field_content;
927
-        }
928
-
929
-        // Turn on Admin-style display for file upload fields only
930
-        if( 'fileupload' === $field->type ) {
931
-            $_GET['page'] = 'gf_entries';
932
-        }
933
-
934
-        // SET SOME FIELD DEFAULTS TO PREVENT ISSUES
935
-        $field->adminOnly = false; /** @see GFFormDisplay::get_counter_init_script() need to prevent adminOnly */
936
-
937
-        // add categories as choices for Post Category field
938
-        if ( 'post_category' === $field->type ) {
939
-            $field = GFCommon::add_categories_as_choices( $field, $value );
940
-        }
941
-
942
-        $field_value = $this->get_field_value( $field );
943
-
944
-        /**
945
-         * @filter `gravityview/edit_entry/field_value` Change the value of an Edit Entry field, if needed
946
-         * @since 1.11
947
-         * @param mixed $field_value field value used to populate the input
948
-         * @param object $field Gravity Forms field object ( Class GF_Field )
949
-         */
950
-        $field_value = apply_filters( 'gravityview/edit_entry/field_value', $field_value, $field );
951
-
952
-	    // Prevent any PHP warnings, like undefined index
953
-	    ob_start();
954
-
955
-        if( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
956
-            $return = $gv_field->get_field_input( $this->form, $field_value, $this->entry, $field );
957
-        } else {
958
-	        $return = $field->get_field_input( $this->form, $field_value, $this->entry );
959
-        }
960
-
961
-
962
-	    // If there was output, it's an error
963
-	    $warnings = ob_get_clean();
964
-
965
-	    if( !empty( $warnings ) ) {
966
-		    do_action( 'gravityview_log_error', __METHOD__ . $warnings, $field_value );
967
-	    }
968
-
969
-        /**
970
-         * Unset hack $_GET['page'] = 'gf_entries'
971
-         * We need the fileupload html field to render with the proper id
972
-         *  ( <li id="field_80_16" ... > )
973
-         */
974
-        unset( $_GET['page'] );
975
-
976
-        return $return;
977
-    }
978
-
979
-    /**
980
-     * Modify the value for the current field input
981
-     *
982
-     * @param GF_Field $field
983
-     *
984
-     * @return array|mixed|string|void
985
-     */
986
-    private function get_field_value( $field ) {
987
-
988
-        /**
989
-         * @filter `gravityview/edit_entry/pre_populate/override` Allow the pre-populated value to override saved value in Edit Entry form. By default, pre-populate mechanism only kicks on empty fields.
990
-         * @param boolean True: override saved values; False: don't override (default)
991
-         * @param $field GF_Field object Gravity Forms field object
992
-         * @since 1.13
993
-         */
994
-        $override_saved_value = apply_filters( 'gravityview/edit_entry/pre_populate/override', false, $field );
995
-
996
-        // We're dealing with multiple inputs (e.g. checkbox) but not time or date (as it doesn't store data in input IDs)
997
-        if( isset( $field->inputs ) && is_array( $field->inputs ) && !in_array( $field->type, array( 'time', 'date' ) ) ) {
998
-
999
-            $field_value = array();
1000
-
1001
-            // only accept pre-populated values if the field doesn't have any choice selected.
1002
-            $allow_pre_populated = $field->allowsPrepopulate;
1003
-
1004
-            foreach ( (array)$field->inputs as $input ) {
1005
-
1006
-                $input_id = strval( $input['id'] );
732
+	}
733
+
734
+	/**
735
+	 * Display success or error message if the form has been submitted
736
+	 *
737
+	 * @uses GVCommon::generate_notice
738
+	 *
739
+	 * @since TODO
740
+	 *
741
+	 * @return void
742
+	 */
743
+	private function maybe_print_message() {
744
+
745
+		if( rgpost('action') === 'update' ) {
746
+
747
+			$back_link = esc_url( remove_query_arg( array( 'page', 'view', 'edit' ) ) );
748
+
749
+			if( ! $this->is_valid ){
750
+
751
+				// Keeping this compatible with Gravity Forms.
752
+				$validation_message = "<div class='validation_error'>" . __('There was a problem with your submission.', 'gravityview') . " " . __('Errors have been highlighted below.', 'gravityview') . "</div>";
753
+				$message = apply_filters("gform_validation_message_{$this->form['id']}", apply_filters("gform_validation_message", $validation_message, $this->form), $this->form);
754
+
755
+				echo GVCommon::generate_notice( $message , 'gv-error' );
756
+
757
+			} else {
758
+				$entry_updated_message = sprintf( esc_attr__('Entry Updated. %sReturn to Entry%s', 'gravityview'), '<a href="'. $back_link .'">', '</a>' );
759
+
760
+				/**
761
+				 * @filter `gravityview/edit_entry/success` Modify the edit entry success message (including the anchor link)
762
+				 * @since 1.5.4
763
+				 * @param string $entry_updated_message Existing message
764
+				 * @param int $view_id View ID
765
+				 * @param array $entry Gravity Forms entry array
766
+				 * @param string $back_link URL to return to the original entry. @since 1.6
767
+				 */
768
+				$message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message , $this->view_id, $this->entry, $back_link );
769
+
770
+				echo GVCommon::generate_notice( $message );
771
+			}
772
+
773
+		}
774
+	}
775
+
776
+	/**
777
+	 * Display the Edit Entry form in the original Gravity Forms format
778
+	 *
779
+	 * @since 1.9
780
+	 *
781
+	 * @param $form
782
+	 * @param $lead
783
+	 * @param $view_id
784
+	 *
785
+	 * @return void
786
+	 */
787
+	private function render_edit_form() {
788
+
789
+		add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields'), 5000, 3 );
790
+		add_filter( 'gform_submit_button', array( $this, 'render_form_buttons') );
791
+		add_filter( 'gform_disable_view_counter', '__return_true' );
792
+
793
+		add_filter( 'gform_field_input', array( $this, 'verify_user_can_edit_post' ), 5, 5 );
794
+		add_filter( 'gform_field_input', array( $this, 'modify_edit_field_input' ), 10, 5 );
795
+
796
+		// We need to remove the fake $_GET['page'] arg to avoid rendering form as if in admin.
797
+		unset( $_GET['page'] );
798
+
799
+		// TODO: Make sure validation isn't handled by GF
800
+		// TODO: Include CSS for file upload fields
801
+		// TODO: Verify multiple-page forms
802
+		// TODO: Product fields are not editable
803
+		// TODO: Check Updated and Error messages
804
+
805
+		$html = GFFormDisplay::get_form( $this->form['id'], false, false, true, $this->entry );
806
+
807
+		remove_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields' ), 5000 );
808
+		remove_filter( 'gform_submit_button', array( $this, 'render_form_buttons' ) );
809
+		remove_filter( 'gform_disable_view_counter', '__return_true' );
810
+		remove_filter( 'gform_field_input', array( $this, 'verify_user_can_edit_post' ), 5 );
811
+		remove_filter( 'gform_field_input', array( $this, 'modify_edit_field_input' ), 10 );
812
+
813
+		echo $html;
814
+	}
815
+
816
+	/**
817
+	 * Display the Update/Cancel/Delete buttons for the Edit Entry form
818
+	 * @since 1.8
819
+	 * @return string
820
+	 */
821
+	public function render_form_buttons() {
822
+		return gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/form-buttons.php', $this );
823
+	}
824
+
825
+
826
+	/**
827
+	 * Modify the form fields that are shown when using GFFormDisplay::get_form()
828
+	 *
829
+	 * By default, all fields will be shown. We only want the Edit Tab configured fields to be shown.
830
+	 *
831
+	 * @param array $form
832
+	 * @param boolean $ajax Whether in AJAX mode
833
+	 * @param array|string $field_values Passed parameters to the form
834
+	 *
835
+	 * @since 1.9
836
+	 *
837
+	 * @return array Modified form array
838
+	 */
839
+	public function filter_modify_form_fields( $form, $ajax = false, $field_values = '' ) {
840
+
841
+		// In case we have validated the form, use it to inject the validation results into the form render
842
+		if( isset( $this->form_after_validation ) ) {
843
+			$form = $this->form_after_validation;
844
+		} else {
845
+			$form['fields'] = $this->get_configured_edit_fields( $form, $this->view_id );
846
+		}
847
+
848
+		$form = $this->filter_conditional_logic( $form );
849
+
850
+		// for now we don't support Save and Continue feature.
851
+		if( ! self::$supports_save_and_continue ) {
852
+			unset( $form['save'] );
853
+		}
854
+
855
+		return $form;
856
+	}
857
+
858
+	/**
859
+	 * When displaying a field, check if it's a Post Field, and if so, make sure the post exists and current user has edit rights.
860
+	 *
861
+	 * @since TODO
862
+	 *
863
+	 * @param string $field_content Always empty. Returning not-empty overrides the input.
864
+	 * @param GF_Field $field
865
+	 * @param string|array $value If array, it's a field with multiple inputs. If string, single input.
866
+	 * @param int $lead_id Lead ID. Always 0 for the `gform_field_input` filter.
867
+	 * @param int $form_id Form ID
868
+	 *
869
+	 * @return string If error, the error message. If no error, blank string (modify_edit_field_input() runs next)
870
+	 */
871
+	function verify_user_can_edit_post( $field_content = '', $field, $value, $lead_id = 0, $form_id ) {
872
+
873
+		if( GFCommon::is_post_field( $field ) ) {
874
+
875
+			$message = null;
876
+
877
+			// First, make sure they have the capability to edit the post.
878
+			if( false === current_user_can( 'edit_post', $this->entry['post_id'] ) ) {
879
+
880
+				/**
881
+				 * @filter `gravityview/edit_entry/unsupported_post_field_text` Modify the message when someone isn't able to edit a post
882
+				 * @param string $message The existing "You don't have permission..." text
883
+				 */
884
+				$message = apply_filters('gravityview/edit_entry/unsupported_post_field_text', __('You don&rsquo;t have permission to edit this post.', 'gravityview') );
885
+
886
+			} elseif( null === get_post( $this->entry['post_id'] ) ) {
887
+				/**
888
+				 * @filter `gravityview/edit_entry/no_post_text` Modify the message when someone is editing an entry attached to a post that no longer exists
889
+				 * @param string $message The existing "This field is not editable; the post no longer exists." text
890
+				 */
891
+				$message = apply_filters('gravityview/edit_entry/no_post_text', __('This field is not editable; the post no longer exists.', 'gravityview' ) );
892
+			}
893
+
894
+			if( $message ) {
895
+				$field_content = sprintf('<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
896
+			}
897
+		}
898
+
899
+		return $field_content;
900
+	}
901
+
902
+	/**
903
+	 *
904
+	 * Fill-in the saved values into the form inputs
905
+	 *
906
+	 * @param string $field_content Always empty. Returning not-empty overrides the input.
907
+	 * @param GF_Field $field
908
+	 * @param string|array $value If array, it's a field with multiple inputs. If string, single input.
909
+	 * @param int $lead_id Lead ID. Always 0 for the `gform_field_input` filter.
910
+	 * @param int $form_id Form ID
911
+	 *
912
+	 * @return mixed
913
+	 */
914
+	function modify_edit_field_input( $field_content = '', $field, $value, $lead_id = 0, $form_id ) {
915
+
916
+		$gv_field = GravityView_Fields::get_associated_field( $field );
917
+
918
+		// If the form has been submitted, then we don't need to pre-fill the values,
919
+		// Except for fileupload type and when a field input is overridden- run always!!
920
+		if(
921
+			( $this->is_edit_entry_submission() && !in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
922
+			&& false === ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) )
923
+			|| ! empty( $field_content )
924
+			|| GFCommon::is_product_field( $field->type ) // Prevent product fields from appearing editable
925
+		) {
926
+			return $field_content;
927
+		}
928
+
929
+		// Turn on Admin-style display for file upload fields only
930
+		if( 'fileupload' === $field->type ) {
931
+			$_GET['page'] = 'gf_entries';
932
+		}
933
+
934
+		// SET SOME FIELD DEFAULTS TO PREVENT ISSUES
935
+		$field->adminOnly = false; /** @see GFFormDisplay::get_counter_init_script() need to prevent adminOnly */
936
+
937
+		// add categories as choices for Post Category field
938
+		if ( 'post_category' === $field->type ) {
939
+			$field = GFCommon::add_categories_as_choices( $field, $value );
940
+		}
941
+
942
+		$field_value = $this->get_field_value( $field );
943
+
944
+		/**
945
+		 * @filter `gravityview/edit_entry/field_value` Change the value of an Edit Entry field, if needed
946
+		 * @since 1.11
947
+		 * @param mixed $field_value field value used to populate the input
948
+		 * @param object $field Gravity Forms field object ( Class GF_Field )
949
+		 */
950
+		$field_value = apply_filters( 'gravityview/edit_entry/field_value', $field_value, $field );
951
+
952
+		// Prevent any PHP warnings, like undefined index
953
+		ob_start();
954
+
955
+		if( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
956
+			$return = $gv_field->get_field_input( $this->form, $field_value, $this->entry, $field );
957
+		} else {
958
+			$return = $field->get_field_input( $this->form, $field_value, $this->entry );
959
+		}
960
+
961
+
962
+		// If there was output, it's an error
963
+		$warnings = ob_get_clean();
964
+
965
+		if( !empty( $warnings ) ) {
966
+			do_action( 'gravityview_log_error', __METHOD__ . $warnings, $field_value );
967
+		}
968
+
969
+		/**
970
+		 * Unset hack $_GET['page'] = 'gf_entries'
971
+		 * We need the fileupload html field to render with the proper id
972
+		 *  ( <li id="field_80_16" ... > )
973
+		 */
974
+		unset( $_GET['page'] );
975
+
976
+		return $return;
977
+	}
978
+
979
+	/**
980
+	 * Modify the value for the current field input
981
+	 *
982
+	 * @param GF_Field $field
983
+	 *
984
+	 * @return array|mixed|string|void
985
+	 */
986
+	private function get_field_value( $field ) {
987
+
988
+		/**
989
+		 * @filter `gravityview/edit_entry/pre_populate/override` Allow the pre-populated value to override saved value in Edit Entry form. By default, pre-populate mechanism only kicks on empty fields.
990
+		 * @param boolean True: override saved values; False: don't override (default)
991
+		 * @param $field GF_Field object Gravity Forms field object
992
+		 * @since 1.13
993
+		 */
994
+		$override_saved_value = apply_filters( 'gravityview/edit_entry/pre_populate/override', false, $field );
995
+
996
+		// We're dealing with multiple inputs (e.g. checkbox) but not time or date (as it doesn't store data in input IDs)
997
+		if( isset( $field->inputs ) && is_array( $field->inputs ) && !in_array( $field->type, array( 'time', 'date' ) ) ) {
998
+
999
+			$field_value = array();
1000
+
1001
+			// only accept pre-populated values if the field doesn't have any choice selected.
1002
+			$allow_pre_populated = $field->allowsPrepopulate;
1003
+
1004
+			foreach ( (array)$field->inputs as $input ) {
1005
+
1006
+				$input_id = strval( $input['id'] );
1007 1007
                 
1008
-                if ( isset( $this->entry[ $input_id ] ) && ! gv_empty( $this->entry[ $input_id ], false, false ) ) {
1009
-                    $field_value[ $input_id ] =  'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1010
-                    $allow_pre_populated = false;
1011
-                }
1008
+				if ( isset( $this->entry[ $input_id ] ) && ! gv_empty( $this->entry[ $input_id ], false, false ) ) {
1009
+					$field_value[ $input_id ] =  'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1010
+					$allow_pre_populated = false;
1011
+				}
1012 1012
 
1013
-            }
1013
+			}
1014 1014
 
1015
-            $pre_value = $field->get_value_submission( array(), false );
1015
+			$pre_value = $field->get_value_submission( array(), false );
1016 1016
 
1017
-            $field_value = ! $allow_pre_populated && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
1017
+			$field_value = ! $allow_pre_populated && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
1018 1018
 
1019
-        } else {
1019
+		} else {
1020 1020
 
1021
-            $id = intval( $field->id );
1021
+			$id = intval( $field->id );
1022 1022
 
1023
-            // get pre-populated value if exists
1024
-            $pre_value = $field->allowsPrepopulate ? GFFormsModel::get_parameter_value( $field->inputName, array(), $field ) : '';
1023
+			// get pre-populated value if exists
1024
+			$pre_value = $field->allowsPrepopulate ? GFFormsModel::get_parameter_value( $field->inputName, array(), $field ) : '';
1025 1025
 
1026
-            // saved field entry value (if empty, fallback to the pre-populated value, if exists)
1027
-            // or pre-populated value if not empty and set to override saved value
1028
-            $field_value = !gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
1026
+			// saved field entry value (if empty, fallback to the pre-populated value, if exists)
1027
+			// or pre-populated value if not empty and set to override saved value
1028
+			$field_value = !gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
1029 1029
 
1030
-            // in case field is post_category but inputType is select, multi-select or radio, convert value into array of category IDs.
1031
-            if ( 'post_category' === $field->type && !gv_empty( $field_value, false, false ) ) {
1032
-                $categories = array();
1033
-                foreach ( explode( ',', $field_value ) as $cat_string ) {
1034
-                    $categories[] = GFCommon::format_post_category( $cat_string, true );
1035
-                }
1036
-                $field_value = 'multiselect' === $field->get_input_type() ? $categories : implode( '', $categories );
1037
-            }
1030
+			// in case field is post_category but inputType is select, multi-select or radio, convert value into array of category IDs.
1031
+			if ( 'post_category' === $field->type && !gv_empty( $field_value, false, false ) ) {
1032
+				$categories = array();
1033
+				foreach ( explode( ',', $field_value ) as $cat_string ) {
1034
+					$categories[] = GFCommon::format_post_category( $cat_string, true );
1035
+				}
1036
+				$field_value = 'multiselect' === $field->get_input_type() ? $categories : implode( '', $categories );
1037
+			}
1038 1038
 
1039
-        }
1039
+		}
1040 1040
 
1041
-        // if value is empty get the default value if defined
1042
-        $field_value = $field->get_value_default_if_empty( $field_value );
1041
+		// if value is empty get the default value if defined
1042
+		$field_value = $field->get_value_default_if_empty( $field_value );
1043 1043
 
1044
-        return $field_value;
1045
-    }
1044
+		return $field_value;
1045
+	}
1046 1046
 
1047 1047
 
1048
-    // ---- Entry validation
1048
+	// ---- Entry validation
1049 1049
 
1050
-    /**
1051
-     * Add field keys that Gravity Forms expects.
1052
-     *
1053
-     * @see GFFormDisplay::validate()
1054
-     * @param  array $form GF Form
1055
-     * @return array       Modified GF Form
1056
-     */
1057
-    function gform_pre_validation( $form ) {
1050
+	/**
1051
+	 * Add field keys that Gravity Forms expects.
1052
+	 *
1053
+	 * @see GFFormDisplay::validate()
1054
+	 * @param  array $form GF Form
1055
+	 * @return array       Modified GF Form
1056
+	 */
1057
+	function gform_pre_validation( $form ) {
1058 1058
 
1059
-        if( ! $this->verify_nonce() ) {
1060
-            return $form;
1061
-        }
1059
+		if( ! $this->verify_nonce() ) {
1060
+			return $form;
1061
+		}
1062 1062
 
1063
-        // Fix PHP warning regarding undefined index.
1064
-        foreach ( $form['fields'] as &$field) {
1063
+		// Fix PHP warning regarding undefined index.
1064
+		foreach ( $form['fields'] as &$field) {
1065 1065
 
1066
-            // This is because we're doing admin form pretending to be front-end, so Gravity Forms
1067
-            // expects certain field array items to be set.
1068
-            foreach ( array( 'noDuplicates', 'adminOnly', 'inputType', 'isRequired', 'enablePrice', 'inputs', 'allowedExtensions' ) as $key ) {
1069
-	            $field->{$key} = isset( $field->{$key} ) ? $field->{$key} : NULL;
1070
-            }
1066
+			// This is because we're doing admin form pretending to be front-end, so Gravity Forms
1067
+			// expects certain field array items to be set.
1068
+			foreach ( array( 'noDuplicates', 'adminOnly', 'inputType', 'isRequired', 'enablePrice', 'inputs', 'allowedExtensions' ) as $key ) {
1069
+				$field->{$key} = isset( $field->{$key} ) ? $field->{$key} : NULL;
1070
+			}
1071 1071
 
1072
-            // unset emailConfirmEnabled for email type fields
1073
-           /* if( 'email' === $field['type'] && !empty( $field['emailConfirmEnabled'] ) ) {
1072
+			// unset emailConfirmEnabled for email type fields
1073
+		   /* if( 'email' === $field['type'] && !empty( $field['emailConfirmEnabled'] ) ) {
1074 1074
                 $field['emailConfirmEnabled'] = '';
1075 1075
             }*/
1076 1076
 
1077
-            switch( RGFormsModel::get_input_type( $field ) ) {
1077
+			switch( RGFormsModel::get_input_type( $field ) ) {
1078
+
1079
+				/**
1080
+				 * this whole fileupload hack is because in the admin, Gravity Forms simply doesn't update any fileupload field if it's empty, but it DOES in the frontend.
1081
+				 *
1082
+				 * What we have to do is set the value so that it doesn't get overwritten as empty on save and appears immediately in the Edit Entry screen again.
1083
+				 *
1084
+				 * @hack
1085
+				 */
1086
+				case 'fileupload':
1087
+
1088
+					// Set the previous value
1089
+					$entry = $this->get_entry();
1090
+
1091
+					$input_name = 'input_'.$field->id;
1092
+					$form_id = $form['id'];
1078 1093
 
1079
-                /**
1080
-                 * this whole fileupload hack is because in the admin, Gravity Forms simply doesn't update any fileupload field if it's empty, but it DOES in the frontend.
1081
-                 *
1082
-                 * What we have to do is set the value so that it doesn't get overwritten as empty on save and appears immediately in the Edit Entry screen again.
1083
-                 *
1084
-                 * @hack
1085
-                 */
1086
-                case 'fileupload':
1087
-
1088
-                    // Set the previous value
1089
-                    $entry = $this->get_entry();
1090
-
1091
-                    $input_name = 'input_'.$field->id;
1092
-                    $form_id = $form['id'];
1093
-
1094
-                    $value = NULL;
1095
-
1096
-                    // Use the previous entry value as the default.
1097
-                    if( isset( $entry[ $field->id ] ) ) {
1098
-                        $value = $entry[ $field->id ];
1099
-                    }
1094
+					$value = NULL;
1100 1095
 
1101
-                    // If this is a single upload file
1102
-                    if( !empty( $_FILES[ $input_name ] ) && !empty( $_FILES[ $input_name ]['name'] ) ) {
1103
-                        $file_path = GFFormsModel::get_file_upload_path( $form['id'], $_FILES[ $input_name ]['name'] );
1104
-                        $value = $file_path['url'];
1096
+					// Use the previous entry value as the default.
1097
+					if( isset( $entry[ $field->id ] ) ) {
1098
+						$value = $entry[ $field->id ];
1099
+					}
1105 1100
 
1106
-                    } else {
1107
-
1108
-                        // Fix PHP warning on line 1498 of form_display.php for post_image fields
1109
-                        // Fix PHP Notice:  Undefined index:  size in form_display.php on line 1511
1110
-                        $_FILES[ $input_name ] = array('name' => '', 'size' => '' );
1111
-
1112
-                    }
1113
-
1114
-                    if( rgar($field, "multipleFiles") ) {
1115
-
1116
-                        // If there are fresh uploads, process and merge them.
1117
-                        // Otherwise, use the passed values, which should be json-encoded array of URLs
1118
-                        if( isset( GFFormsModel::$uploaded_files[$form_id][$input_name] ) ) {
1119
-                            $value = empty( $value ) ? '[]' : $value;
1120
-                            $value = stripslashes_deep( $value );
1121
-                            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], array());
1122
-                        }
1101
+					// If this is a single upload file
1102
+					if( !empty( $_FILES[ $input_name ] ) && !empty( $_FILES[ $input_name ]['name'] ) ) {
1103
+						$file_path = GFFormsModel::get_file_upload_path( $form['id'], $_FILES[ $input_name ]['name'] );
1104
+						$value = $file_path['url'];
1123 1105
 
1124
-                    } else {
1106
+					} else {
1125 1107
 
1126
-                        // A file already exists when editing an entry
1127
-                        // We set this to solve issue when file upload fields are required.
1128
-                        GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] = $value;
1108
+						// Fix PHP warning on line 1498 of form_display.php for post_image fields
1109
+						// Fix PHP Notice:  Undefined index:  size in form_display.php on line 1511
1110
+						$_FILES[ $input_name ] = array('name' => '', 'size' => '' );
1129 1111
 
1130
-                    }
1112
+					}
1131 1113
 
1132
-                    $this->entry[ $input_name ] = $value;
1133
-                    $_POST[ $input_name ] = $value;
1114
+					if( rgar($field, "multipleFiles") ) {
1134 1115
 
1135
-                    break;
1116
+						// If there are fresh uploads, process and merge them.
1117
+						// Otherwise, use the passed values, which should be json-encoded array of URLs
1118
+						if( isset( GFFormsModel::$uploaded_files[$form_id][$input_name] ) ) {
1119
+							$value = empty( $value ) ? '[]' : $value;
1120
+							$value = stripslashes_deep( $value );
1121
+							$value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], array());
1122
+						}
1136 1123
 
1137
-                case 'number':
1138
-                    // Fix "undefined index" issue at line 1286 in form_display.php
1139
-                    if( !isset( $_POST['input_'.$field->id ] ) ) {
1140
-                        $_POST['input_'.$field->id ] = NULL;
1141
-                    }
1142
-                    break;
1143
-                case 'captcha':
1144
-                    // Fix issue with recaptcha_check_answer() on line 1458 in form_display.php
1145
-                    $_POST['recaptcha_challenge_field'] = NULL;
1146
-                    $_POST['recaptcha_response_field'] = NULL;
1147
-                    break;
1148
-            }
1124
+					} else {
1149 1125
 
1150
-        }
1126
+						// A file already exists when editing an entry
1127
+						// We set this to solve issue when file upload fields are required.
1128
+						GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] = $value;
1151 1129
 
1152
-        return $form;
1153
-    }
1130
+					}
1154 1131
 
1132
+					$this->entry[ $input_name ] = $value;
1133
+					$_POST[ $input_name ] = $value;
1155 1134
 
1156
-    /**
1157
-     * Process validation for a edit entry submission
1158
-     *
1159
-     * Sets the `is_valid` object var
1160
-     *
1161
-     * @return void
1162
-     */
1163
-    function validate() {
1135
+					break;
1164 1136
 
1165
-        /**
1166
-         * If using GF User Registration Add-on, remove the validation step, otherwise generates error when updating the entry
1167
-         * GF User Registration Add-on version > 3.x has a different class name
1168
-         * @since 1.16.2
1169
-         */
1170
-        if ( class_exists( 'GF_User_Registration' ) ) {
1171
-            remove_filter( 'gform_validation', array( GF_User_Registration::get_instance(), 'validate' ) );
1172
-        } else  if ( class_exists( 'GFUser' ) ) {
1173
-            remove_filter( 'gform_validation', array( 'GFUser', 'user_registration_validation' ) );
1174
-        }
1137
+				case 'number':
1138
+					// Fix "undefined index" issue at line 1286 in form_display.php
1139
+					if( !isset( $_POST['input_'.$field->id ] ) ) {
1140
+						$_POST['input_'.$field->id ] = NULL;
1141
+					}
1142
+					break;
1143
+				case 'captcha':
1144
+					// Fix issue with recaptcha_check_answer() on line 1458 in form_display.php
1145
+					$_POST['recaptcha_challenge_field'] = NULL;
1146
+					$_POST['recaptcha_response_field'] = NULL;
1147
+					break;
1148
+			}
1175 1149
 
1150
+		}
1176 1151
 
1177
-        /**
1178
-         * For some crazy reason, Gravity Forms doesn't validate Edit Entry form submissions.
1179
-         * You can enter whatever you want!
1180
-         * We try validating, and customize the results using `self::custom_validation()`
1181
-         */
1182
-        add_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10, 4);
1152
+		return $form;
1153
+	}
1183 1154
 
1184
-        // Needed by the validate funtion
1185
-        $failed_validation_page = NULL;
1186
-        $field_values = RGForms::post( 'gform_field_values' );
1187 1155
 
1188
-        // Prevent entry limit from running when editing an entry, also
1189
-        // prevent form scheduling from preventing editing
1190
-        unset( $this->form['limitEntries'], $this->form['scheduleForm'] );
1156
+	/**
1157
+	 * Process validation for a edit entry submission
1158
+	 *
1159
+	 * Sets the `is_valid` object var
1160
+	 *
1161
+	 * @return void
1162
+	 */
1163
+	function validate() {
1164
+
1165
+		/**
1166
+		 * If using GF User Registration Add-on, remove the validation step, otherwise generates error when updating the entry
1167
+		 * GF User Registration Add-on version > 3.x has a different class name
1168
+		 * @since 1.16.2
1169
+		 */
1170
+		if ( class_exists( 'GF_User_Registration' ) ) {
1171
+			remove_filter( 'gform_validation', array( GF_User_Registration::get_instance(), 'validate' ) );
1172
+		} else  if ( class_exists( 'GFUser' ) ) {
1173
+			remove_filter( 'gform_validation', array( 'GFUser', 'user_registration_validation' ) );
1174
+		}
1191 1175
 
1192
-        // Hide fields depending on Edit Entry settings
1193
-        $this->form['fields'] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1194 1176
 
1195
-        $this->is_valid = GFFormDisplay::validate( $this->form, $field_values, 1, $failed_validation_page );
1177
+		/**
1178
+		 * For some crazy reason, Gravity Forms doesn't validate Edit Entry form submissions.
1179
+		 * You can enter whatever you want!
1180
+		 * We try validating, and customize the results using `self::custom_validation()`
1181
+		 */
1182
+		add_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10, 4);
1196 1183
 
1197
-        remove_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10 );
1198
-    }
1184
+		// Needed by the validate funtion
1185
+		$failed_validation_page = NULL;
1186
+		$field_values = RGForms::post( 'gform_field_values' );
1199 1187
 
1188
+		// Prevent entry limit from running when editing an entry, also
1189
+		// prevent form scheduling from preventing editing
1190
+		unset( $this->form['limitEntries'], $this->form['scheduleForm'] );
1200 1191
 
1201
-    /**
1202
-     * Make validation work for Edit Entry
1203
-     *
1204
-     * Because we're calling the GFFormDisplay::validate() in an unusual way (as a front-end
1205
-     * form pretending to be a back-end form), validate() doesn't know we _can't_ edit post
1206
-     * fields. This goes through all the fields and if they're an invalid post field, we
1207
-     * set them as valid. If there are still issues, we'll return false.
1208
-     *
1209
-     * @param  [type] $validation_results [description]
1210
-     * @return [type]                     [description]
1211
-     */
1212
-    function custom_validation( $validation_results ) {
1192
+		// Hide fields depending on Edit Entry settings
1193
+		$this->form['fields'] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1213 1194
 
1214
-        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Validation results: ', $validation_results );
1195
+		$this->is_valid = GFFormDisplay::validate( $this->form, $field_values, 1, $failed_validation_page );
1215 1196
 
1216
-        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
1197
+		remove_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10 );
1198
+	}
1217 1199
 
1218
-        $gv_valid = true;
1219 1200
 
1220
-        foreach ( $validation_results['form']['fields'] as $key => &$field ) {
1201
+	/**
1202
+	 * Make validation work for Edit Entry
1203
+	 *
1204
+	 * Because we're calling the GFFormDisplay::validate() in an unusual way (as a front-end
1205
+	 * form pretending to be a back-end form), validate() doesn't know we _can't_ edit post
1206
+	 * fields. This goes through all the fields and if they're an invalid post field, we
1207
+	 * set them as valid. If there are still issues, we'll return false.
1208
+	 *
1209
+	 * @param  [type] $validation_results [description]
1210
+	 * @return [type]                     [description]
1211
+	 */
1212
+	function custom_validation( $validation_results ) {
1221 1213
 
1222
-            $value = RGFormsModel::get_field_value( $field );
1223
-            $field_type = RGFormsModel::get_input_type( $field );
1214
+		do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Validation results: ', $validation_results );
1224 1215
 
1225
-            // Validate always
1226
-            switch ( $field_type ) {
1216
+		do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
1227 1217
 
1218
+		$gv_valid = true;
1228 1219
 
1229
-                case 'fileupload' :
1230
-                case 'post_image':
1220
+		foreach ( $validation_results['form']['fields'] as $key => &$field ) {
1231 1221
 
1232
-                    // in case nothing is uploaded but there are already files saved
1233
-                    if( !empty( $field->failed_validation ) && !empty( $field->isRequired ) && !empty( $value ) ) {
1234
-                        $field->failed_validation = false;
1235
-                        unset( $field->validation_message );
1236
-                    }
1222
+			$value = RGFormsModel::get_field_value( $field );
1223
+			$field_type = RGFormsModel::get_input_type( $field );
1237 1224
 
1238
-                    // validate if multi file upload reached max number of files [maxFiles] => 2
1239
-                    if( rgobj( $field, 'maxFiles') && rgobj( $field, 'multipleFiles') ) {
1225
+			// Validate always
1226
+			switch ( $field_type ) {
1240 1227
 
1241
-                        $input_name = 'input_' . $field->id;
1242
-                        //uploaded
1243
-                        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] : array();
1244 1228
 
1245
-                        //existent
1246
-                        $entry = $this->get_entry();
1247
-                        $value = NULL;
1248
-                        if( isset( $entry[ $field->id ] ) ) {
1249
-                            $value = json_decode( $entry[ $field->id ], true );
1250
-                        }
1229
+				case 'fileupload' :
1230
+				case 'post_image':
1251 1231
 
1252
-                        // count uploaded files and existent entry files
1253
-                        $count_files = count( $file_names ) + count( $value );
1232
+					// in case nothing is uploaded but there are already files saved
1233
+					if( !empty( $field->failed_validation ) && !empty( $field->isRequired ) && !empty( $value ) ) {
1234
+						$field->failed_validation = false;
1235
+						unset( $field->validation_message );
1236
+					}
1254 1237
 
1255
-                        if( $count_files > $field->maxFiles ) {
1256
-                            $field->validation_message = __( 'Maximum number of files reached', 'gravityview' );
1257
-                            $field->failed_validation = 1;
1258
-                            $gv_valid = false;
1238
+					// validate if multi file upload reached max number of files [maxFiles] => 2
1239
+					if( rgobj( $field, 'maxFiles') && rgobj( $field, 'multipleFiles') ) {
1259 1240
 
1260
-                            // in case of error make sure the newest upload files are removed from the upload input
1261
-                            GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ] = null;
1262
-                        }
1241
+						$input_name = 'input_' . $field->id;
1242
+						//uploaded
1243
+						$file_names = isset( GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] : array();
1263 1244
 
1264
-                    }
1245
+						//existent
1246
+						$entry = $this->get_entry();
1247
+						$value = NULL;
1248
+						if( isset( $entry[ $field->id ] ) ) {
1249
+							$value = json_decode( $entry[ $field->id ], true );
1250
+						}
1265 1251
 
1252
+						// count uploaded files and existent entry files
1253
+						$count_files = count( $file_names ) + count( $value );
1266 1254
 
1267
-                    break;
1255
+						if( $count_files > $field->maxFiles ) {
1256
+							$field->validation_message = __( 'Maximum number of files reached', 'gravityview' );
1257
+							$field->failed_validation = 1;
1258
+							$gv_valid = false;
1268 1259
 
1269
-            }
1260
+							// in case of error make sure the newest upload files are removed from the upload input
1261
+							GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ] = null;
1262
+						}
1270 1263
 
1271
-            // This field has failed validation.
1272
-            if( !empty( $field->failed_validation ) ) {
1264
+					}
1273 1265
 
1274
-                do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Field is invalid.', array( 'field' => $field, 'value' => $value ) );
1275 1266
 
1276
-                switch ( $field_type ) {
1267
+					break;
1277 1268
 
1278
-                    // Captchas don't need to be re-entered.
1279
-                    case 'captcha':
1269
+			}
1280 1270
 
1281
-                        // Post Image fields aren't editable, so we un-fail them.
1282
-                    case 'post_image':
1283
-                        $field->failed_validation = false;
1284
-                        unset( $field->validation_message );
1285
-                        break;
1271
+			// This field has failed validation.
1272
+			if( !empty( $field->failed_validation ) ) {
1286 1273
 
1287
-                }
1274
+				do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Field is invalid.', array( 'field' => $field, 'value' => $value ) );
1288 1275
 
1289
-                // You can't continue inside a switch, so we do it after.
1290
-                if( empty( $field->failed_validation ) ) {
1291
-                    continue;
1292
-                }
1276
+				switch ( $field_type ) {
1293 1277
 
1294
-                // checks if the No Duplicates option is not validating entry against itself, since
1295
-                // we're editing a stored entry, it would also assume it's a duplicate.
1296
-                if( !empty( $field->noDuplicates ) ) {
1278
+					// Captchas don't need to be re-entered.
1279
+					case 'captcha':
1297 1280
 
1298
-                    $entry = $this->get_entry();
1281
+						// Post Image fields aren't editable, so we un-fail them.
1282
+					case 'post_image':
1283
+						$field->failed_validation = false;
1284
+						unset( $field->validation_message );
1285
+						break;
1299 1286
 
1300
-                    // If the value of the entry is the same as the stored value
1301
-                    // Then we can assume it's not a duplicate, it's the same.
1302
-                    if( !empty( $entry ) && $value == $entry[ $field->id ] ) {
1303
-                        //if value submitted was not changed, then don't validate
1304
-                        $field->failed_validation = false;
1287
+				}
1305 1288
 
1306
-                        unset( $field->validation_message );
1289
+				// You can't continue inside a switch, so we do it after.
1290
+				if( empty( $field->failed_validation ) ) {
1291
+					continue;
1292
+				}
1307 1293
 
1308
-                        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Field not a duplicate; it is the same entry.', $entry );
1294
+				// checks if the No Duplicates option is not validating entry against itself, since
1295
+				// we're editing a stored entry, it would also assume it's a duplicate.
1296
+				if( !empty( $field->noDuplicates ) ) {
1309 1297
 
1310
-                        continue;
1311
-                    }
1312
-                }
1298
+					$entry = $this->get_entry();
1313 1299
 
1314
-                // if here then probably we are facing the validation 'At least one field must be filled out'
1315
-                if( GFFormDisplay::is_empty( $field, $this->form_id  ) && empty( $field->isRequired ) ) {
1316
-                    unset( $field->validation_message );
1317
-	                $field->validation_message = false;
1318
-                    continue;
1319
-                }
1300
+					// If the value of the entry is the same as the stored value
1301
+					// Then we can assume it's not a duplicate, it's the same.
1302
+					if( !empty( $entry ) && $value == $entry[ $field->id ] ) {
1303
+						//if value submitted was not changed, then don't validate
1304
+						$field->failed_validation = false;
1320 1305
 
1321
-                $gv_valid = false;
1306
+						unset( $field->validation_message );
1322 1307
 
1323
-            }
1308
+						do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Field not a duplicate; it is the same entry.', $entry );
1324 1309
 
1325
-        }
1310
+						continue;
1311
+					}
1312
+				}
1326 1313
 
1327
-        $validation_results['is_valid'] = $gv_valid;
1314
+				// if here then probably we are facing the validation 'At least one field must be filled out'
1315
+				if( GFFormDisplay::is_empty( $field, $this->form_id  ) && empty( $field->isRequired ) ) {
1316
+					unset( $field->validation_message );
1317
+					$field->validation_message = false;
1318
+					continue;
1319
+				}
1328 1320
 
1329
-        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Validation results.', $validation_results );
1321
+				$gv_valid = false;
1330 1322
 
1331
-        // We'll need this result when rendering the form ( on GFFormDisplay::get_form )
1332
-        $this->form_after_validation = $validation_results['form'];
1323
+			}
1333 1324
 
1334
-        return $validation_results;
1335
-    }
1325
+		}
1336 1326
 
1327
+		$validation_results['is_valid'] = $gv_valid;
1337 1328
 
1338
-    /**
1339
-     * TODO: This seems to be hacky... we should remove it. Entry is set when updating the form using setup_vars()!
1340
-     * Get the current entry and set it if it's not yet set.
1341
-     * @return array Gravity Forms entry array
1342
-     */
1343
-    private function get_entry() {
1329
+		do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Validation results.', $validation_results );
1344 1330
 
1345
-        if( empty( $this->entry ) ) {
1346
-            // Get the database value of the entry that's being edited
1347
-            $this->entry = gravityview_get_entry( GravityView_frontend::is_single_entry() );
1348
-        }
1331
+		// We'll need this result when rendering the form ( on GFFormDisplay::get_form )
1332
+		$this->form_after_validation = $validation_results['form'];
1349 1333
 
1350
-        return $this->entry;
1351
-    }
1334
+		return $validation_results;
1335
+	}
1352 1336
 
1353 1337
 
1338
+	/**
1339
+	 * TODO: This seems to be hacky... we should remove it. Entry is set when updating the form using setup_vars()!
1340
+	 * Get the current entry and set it if it's not yet set.
1341
+	 * @return array Gravity Forms entry array
1342
+	 */
1343
+	private function get_entry() {
1354 1344
 
1355
-    // --- Filters
1345
+		if( empty( $this->entry ) ) {
1346
+			// Get the database value of the entry that's being edited
1347
+			$this->entry = gravityview_get_entry( GravityView_frontend::is_single_entry() );
1348
+		}
1356 1349
 
1357
-    /**
1358
-     * Get the Edit Entry fields as configured in the View
1359
-     *
1360
-     * @since 1.8
1361
-     *
1362
-     * @param int $view_id
1363
-     *
1364
-     * @return array Array of fields that are configured in the Edit tab in the Admin
1365
-     */
1366
-    private function get_configured_edit_fields( $form, $view_id ) {
1350
+		return $this->entry;
1351
+	}
1367 1352
 
1368
-        // Get all fields for form
1369
-        $properties = GravityView_View_Data::getInstance()->get_fields( $view_id );
1370 1353
 
1371
-        // If edit tab not yet configured, show all fields
1372
-        $edit_fields = !empty( $properties['edit_edit-fields'] ) ? $properties['edit_edit-fields'] : NULL;
1373 1354
 
1374
-	    // Show hidden fields as text fields
1375
-	    $form = $this->fix_hidden_fields( $form );
1355
+	// --- Filters
1376 1356
 
1377
-        // Hide fields depending on admin settings
1378
-        $fields = $this->filter_fields( $form['fields'], $edit_fields );
1357
+	/**
1358
+	 * Get the Edit Entry fields as configured in the View
1359
+	 *
1360
+	 * @since 1.8
1361
+	 *
1362
+	 * @param int $view_id
1363
+	 *
1364
+	 * @return array Array of fields that are configured in the Edit tab in the Admin
1365
+	 */
1366
+	private function get_configured_edit_fields( $form, $view_id ) {
1379 1367
 
1380
-	    // If Edit Entry fields are configured, remove adminOnly field settings. Otherwise, don't.
1381
-	    $fields = $this->filter_admin_only_fields( $fields, $edit_fields, $form, $view_id );
1368
+		// Get all fields for form
1369
+		$properties = GravityView_View_Data::getInstance()->get_fields( $view_id );
1382 1370
 
1383
-        return $fields;
1384
-    }
1371
+		// If edit tab not yet configured, show all fields
1372
+		$edit_fields = !empty( $properties['edit_edit-fields'] ) ? $properties['edit_edit-fields'] : NULL;
1373
+
1374
+		// Show hidden fields as text fields
1375
+		$form = $this->fix_hidden_fields( $form );
1376
+
1377
+		// Hide fields depending on admin settings
1378
+		$fields = $this->filter_fields( $form['fields'], $edit_fields );
1379
+
1380
+		// If Edit Entry fields are configured, remove adminOnly field settings. Otherwise, don't.
1381
+		$fields = $this->filter_admin_only_fields( $fields, $edit_fields, $form, $view_id );
1382
+
1383
+		return $fields;
1384
+	}
1385 1385
 
1386 1386
 	/**
1387 1387
 	 * @since 1.9.2
@@ -1405,383 +1405,383 @@  discard block
 block discarded – undo
1405 1405
 	}
1406 1406
 
1407 1407
 
1408
-    /**
1409
-     * Filter area fields based on specified conditions
1410
-     *  - This filter removes the fields that have calculation configured
1411
-     *
1412
-     * @uses GravityView_Edit_Entry::user_can_edit_field() Check caps
1413
-     * @access private
1414
-     * @param GF_Field[] $fields
1415
-     * @param array $configured_fields
1416
-     * @since  1.5
1417
-     * @return array $fields
1418
-     */
1419
-    private function filter_fields( $fields, $configured_fields ) {
1420
-
1421
-        if( empty( $fields ) || !is_array( $fields ) ) {
1422
-            return $fields;
1423
-        }
1424
-
1425
-        $edit_fields = array();
1426
-
1427
-        $field_type_blacklist = array(
1428
-            'page',
1429
-        );
1430
-
1431
-	    /**
1432
-	     * @filter `gravityview/edit_entry/hide-product-fields` Hide product fields from being editable.
1433
-	     * @since 1.9.1
1434
-         * @param boolean $hide_product_fields Whether to hide product fields in the editor.  Default: false
1435
-	     */
1436
-	    $hide_product_fields = apply_filters( 'gravityview/edit_entry/hide-product-fields', empty( self::$supports_product_fields ) );
1437
-
1438
-	    if( $hide_product_fields ) {
1439
-		    $field_type_blacklist[] = 'option';
1440
-		    $field_type_blacklist[] = 'quantity';
1441
-            $field_type_blacklist[] = 'product';
1442
-            $field_type_blacklist[] = 'total';
1443
-            $field_type_blacklist[] = 'shipping';
1444
-            $field_type_blacklist[] = 'calculation';
1445
-	    }
1446
-
1447
-        // First, remove blacklist or calculation fields
1448
-        foreach ( $fields as $key => $field ) {
1449
-
1450
-            // Remove the fields that have calculation properties and keep them to be used later
1451
-            // @since 1.16.2
1452
-            if( $field->has_calculation() ) {
1453
-                $this->fields_with_calculation[] = $field;
1454
-                unset( $fields[ $key ] );
1455
-            }
1456
-
1457
-            // process total field after all fields have been saved
1458
-            if ( $field->type == 'total' ) {
1459
-                $this->total_fields[] = $field;
1460
-                unset( $fields[ $key ] );
1461
-            }
1462
-
1463
-            if( in_array( $field->type, $field_type_blacklist ) ) {
1464
-                unset( $fields[ $key ] );
1465
-            }
1466
-        }
1467
-
1468
-        // The Edit tab has not been configured, so we return all fields by default.
1469
-        if( empty( $configured_fields ) ) {
1470
-            return $fields;
1471
-        }
1472
-
1473
-        // The edit tab has been configured, so we loop through to configured settings
1474
-        foreach ( $configured_fields as $configured_field ) {
1475
-
1476
-	        /** @var GF_Field $field */
1477
-	        foreach ( $fields as $field ) {
1478
-
1479
-                if( intval( $configured_field['id'] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1480
-                    $edit_fields[] = $this->merge_field_properties( $field, $configured_field );
1481
-                    break;
1482
-                }
1483
-
1484
-            }
1485
-
1486
-        }
1487
-
1488
-        return $edit_fields;
1489
-
1490
-    }
1491
-
1492
-    /**
1493
-     * Override GF Form field properties with the ones defined on the View
1494
-     * @param  GF_Field $field GF Form field object
1495
-     * @param  array $setting  GV field options
1496
-     * @since  1.5
1497
-     * @return array
1498
-     */
1499
-    private function merge_field_properties( $field, $field_setting ) {
1500
-
1501
-        $return_field = $field;
1502
-
1503
-        if( empty( $field_setting['show_label'] ) ) {
1504
-            $return_field->label = '';
1505
-        } elseif ( !empty( $field_setting['custom_label'] ) ) {
1506
-            $return_field->label = $field_setting['custom_label'];
1507
-        }
1508
-
1509
-        if( !empty( $field_setting['custom_class'] ) ) {
1510
-            $return_field->cssClass .= ' '. gravityview_sanitize_html_class( $field_setting['custom_class'] );
1511
-        }
1512
-
1513
-        /**
1514
-         * Normalize page numbers - avoid conflicts with page validation
1515
-         * @since 1.6
1516
-         */
1517
-        $return_field->pageNumber = 1;
1518
-
1519
-        return $return_field;
1520
-
1521
-    }
1522
-
1523
-    /**
1524
-     * Remove fields that shouldn't be visible based on the Gravity Forms adminOnly field property
1525
-     *
1526
-     * @since 1.9.1
1527
-     *
1528
-     * @param array|GF_Field[] $fields Gravity Forms form fields
1529
-     * @param array|null $edit_fields Fields for the Edit Entry tab configured in the View Configuration
1530
-     * @param array $form GF Form array
1531
-     * @param int $view_id View ID
1532
-     *
1533
-     * @return array Possibly modified form array
1534
-     */
1535
-    function filter_admin_only_fields( $fields = array(), $edit_fields = null, $form = array(), $view_id = 0 ) {
1536
-
1537
-	    /**
1538
-         * @filter `gravityview/edit_entry/use_gf_admin_only_setting` When Edit tab isn't configured, should the Gravity Forms "Admin Only" field settings be used to control field display to non-admins? Default: true
1539
-	     * If the Edit Entry tab is not configured, adminOnly fields will not be shown to non-administrators.
1540
-	     * If the Edit Entry tab *is* configured, adminOnly fields will be shown to non-administrators, using the configured GV permissions
1541
-	     * @since 1.9.1
1542
-	     * @param boolean $use_gf_adminonly_setting True: Hide field if set to Admin Only in GF and the user is not an admin. False: show field based on GV permissions, ignoring GF permissions.
1543
-	     * @param array $form GF Form array
1544
-	     * @param int $view_id View ID
1545
-	     */
1546
-	    $use_gf_adminonly_setting = apply_filters( 'gravityview/edit_entry/use_gf_admin_only_setting', empty( $edit_fields ), $form, $view_id );
1547
-
1548
-	    if( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry['id'] ) ) {
1549
-            foreach( $fields as $k => $field ) {
1550
-                if( $field->adminOnly ) {
1551
-                    unset( $fields[ $k ] );
1552
-                }
1553
-            }
1554
-            return $fields;
1555
-        }
1556
-
1557
-	    foreach( $fields as &$field ) {
1558
-		    $field->adminOnly = false;
1559
-        }
1560
-
1561
-        return $fields;
1562
-    }
1563
-
1564
-    // --- Conditional Logic
1565
-
1566
-    /**
1567
-     * Remove the conditional logic rules from the form button and the form fields, if needed.
1568
-     *
1569
-     * @since 1.9
1570
-     *
1571
-     * @param array $form Gravity Forms form
1572
-     * @return array Modified form, if not using Conditional Logic
1573
-     */
1574
-    function filter_conditional_logic( $form ) {
1575
-
1576
-        /**
1577
-         * @filter `gravityview/edit_entry/conditional_logic` Should the Edit Entry form use Gravity Forms conditional logic showing/hiding of fields?
1578
-         * @since 1.9
1579
-         * @param bool $use_conditional_logic True: Gravity Forms will show/hide fields just like in the original form; False: conditional logic will be disabled and fields will be shown based on configuration. Default: true
1580
-         * @param array $form Gravity Forms form
1581
-         */
1582
-        $use_conditional_logic = apply_filters( 'gravityview/edit_entry/conditional_logic', true, $form );
1583
-
1584
-        if( $use_conditional_logic ) {
1585
-            return $form;
1586
-        }
1587
-
1588
-        foreach( $form['fields'] as &$field ) {
1589
-            /* @var GF_Field $field */
1590
-            $field->conditionalLogic = null;
1591
-        }
1592
-
1593
-        unset( $form['button']['conditionalLogic'] );
1594
-
1595
-        return $form;
1596
-
1597
-    }
1598
-
1599
-    /**
1600
-     * Disable the Gravity Forms conditional logic script and features on the Edit Entry screen
1601
-     *
1602
-     * @since 1.9
1603
-     *
1604
-     * @param $has_conditional_logic
1605
-     * @param $form
1606
-     * @return mixed|void
1607
-     */
1608
-    function manage_conditional_logic( $has_conditional_logic, $form ) {
1609
-
1610
-        if( ! $this->is_edit_entry() ) {
1611
-            return $has_conditional_logic;
1612
-        }
1613
-
1614
-        return apply_filters( 'gravityview/edit_entry/conditional_logic', $has_conditional_logic, $form );
1615
-    }
1616
-
1617
-
1618
-    // --- User checks and nonces
1619
-
1620
-    /**
1621
-     * Check if the user can edit the entry
1622
-     *
1623
-     * - Is the nonce valid?
1624
-     * - Does the user have the right caps for the entry
1625
-     * - Is the entry in the trash?
1626
-     *
1627
-     * @todo Move to GVCommon
1628
-     *
1629
-     * @param  boolean $echo Show error messages in the form?
1630
-     * @return boolean        True: can edit form. False: nope.
1631
-     */
1632
-    function user_can_edit_entry( $echo = false ) {
1633
-
1634
-        $error = NULL;
1635
-
1636
-        /**
1637
-         *  1. Permalinks are turned off
1638
-         *  2. There are two entries embedded using oEmbed
1639
-         *  3. One of the entries has just been saved
1640
-         */
1641
-        if( !empty( $_POST['lid'] ) && !empty( $_GET['entry'] ) && ( $_POST['lid'] !== $_GET['entry'] ) ) {
1642
-
1643
-            $error = true;
1644
-
1645
-        }
1646
-
1647
-        if( !empty( $_GET['entry'] ) && (string)$this->entry['id'] !== $_GET['entry'] ) {
1648
-
1649
-            $error = true;
1650
-
1651
-        } elseif( ! $this->verify_nonce() ) {
1652
-
1653
-            /**
1654
-             * If the Entry is embedded, there may be two entries on the same page.
1655
-             * If that's the case, and one is being edited, the other should fail gracefully and not display an error.
1656
-             */
1657
-            if( GravityView_oEmbed::getInstance()->get_entry_id() ) {
1658
-                $error = true;
1659
-            } else {
1660
-                $error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview');
1661
-            }
1408
+	/**
1409
+	 * Filter area fields based on specified conditions
1410
+	 *  - This filter removes the fields that have calculation configured
1411
+	 *
1412
+	 * @uses GravityView_Edit_Entry::user_can_edit_field() Check caps
1413
+	 * @access private
1414
+	 * @param GF_Field[] $fields
1415
+	 * @param array $configured_fields
1416
+	 * @since  1.5
1417
+	 * @return array $fields
1418
+	 */
1419
+	private function filter_fields( $fields, $configured_fields ) {
1662 1420
 
1663
-        }
1664
-
1665
-        if( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
1666
-            $error = __( 'You do not have permission to edit this entry.', 'gravityview');
1667
-        }
1668
-
1669
-        if( $this->entry['status'] === 'trash' ) {
1670
-            $error = __('You cannot edit the entry; it is in the trash.', 'gravityview' );
1671
-        }
1421
+		if( empty( $fields ) || !is_array( $fields ) ) {
1422
+			return $fields;
1423
+		}
1672 1424
 
1673
-        // No errors; everything's fine here!
1674
-        if( empty( $error ) ) {
1675
-            return true;
1676
-        }
1425
+		$edit_fields = array();
1426
+
1427
+		$field_type_blacklist = array(
1428
+			'page',
1429
+		);
1430
+
1431
+		/**
1432
+		 * @filter `gravityview/edit_entry/hide-product-fields` Hide product fields from being editable.
1433
+		 * @since 1.9.1
1434
+		 * @param boolean $hide_product_fields Whether to hide product fields in the editor.  Default: false
1435
+		 */
1436
+		$hide_product_fields = apply_filters( 'gravityview/edit_entry/hide-product-fields', empty( self::$supports_product_fields ) );
1437
+
1438
+		if( $hide_product_fields ) {
1439
+			$field_type_blacklist[] = 'option';
1440
+			$field_type_blacklist[] = 'quantity';
1441
+			$field_type_blacklist[] = 'product';
1442
+			$field_type_blacklist[] = 'total';
1443
+			$field_type_blacklist[] = 'shipping';
1444
+			$field_type_blacklist[] = 'calculation';
1445
+		}
1677 1446
 
1678
-        if( $echo && $error !== true ) {
1447
+		// First, remove blacklist or calculation fields
1448
+		foreach ( $fields as $key => $field ) {
1679 1449
 
1680
-	        $error = esc_html( $error );
1450
+			// Remove the fields that have calculation properties and keep them to be used later
1451
+			// @since 1.16.2
1452
+			if( $field->has_calculation() ) {
1453
+				$this->fields_with_calculation[] = $field;
1454
+				unset( $fields[ $key ] );
1455
+			}
1681 1456
 
1682
-	        /**
1683
-	         * @since 1.9
1684
-	         */
1685
-	        if ( ! empty( $this->entry ) ) {
1686
-		        $error .= ' ' . gravityview_get_link( '#', _x('Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
1687
-	        }
1457
+			// process total field after all fields have been saved
1458
+			if ( $field->type == 'total' ) {
1459
+				$this->total_fields[] = $field;
1460
+				unset( $fields[ $key ] );
1461
+			}
1688 1462
 
1689
-            echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error');
1690
-        }
1463
+			if( in_array( $field->type, $field_type_blacklist ) ) {
1464
+				unset( $fields[ $key ] );
1465
+			}
1466
+		}
1691 1467
 
1692
-        do_action('gravityview_log_error', 'GravityView_Edit_Entry[user_can_edit_entry]' . $error );
1468
+		// The Edit tab has not been configured, so we return all fields by default.
1469
+		if( empty( $configured_fields ) ) {
1470
+			return $fields;
1471
+		}
1693 1472
 
1694
-        return false;
1695
-    }
1473
+		// The edit tab has been configured, so we loop through to configured settings
1474
+		foreach ( $configured_fields as $configured_field ) {
1696 1475
 
1476
+			/** @var GF_Field $field */
1477
+			foreach ( $fields as $field ) {
1697 1478
 
1698
-    /**
1699
-     * Check whether a field is editable by the current user, and optionally display an error message
1700
-     * @uses  GravityView_Edit_Entry->check_user_cap_edit_field() Check user capabilities
1701
-     * @param  array  $field Field or field settings array
1702
-     * @param  boolean $echo  Whether to show error message telling user they aren't allowed
1703
-     * @return boolean         True: user can edit the current field; False: nope, they can't.
1704
-     */
1705
-    private function user_can_edit_field( $field, $echo = false ) {
1706
-
1707
-        $error = NULL;
1479
+				if( intval( $configured_field['id'] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1480
+					$edit_fields[] = $this->merge_field_properties( $field, $configured_field );
1481
+					break;
1482
+				}
1708 1483
 
1709
-        if( ! $this->check_user_cap_edit_field( $field ) ) {
1710
-            $error = __( 'You do not have permission to edit this field.', 'gravityview');
1711
-        }
1484
+			}
1712 1485
 
1713
-        // No errors; everything's fine here!
1714
-        if( empty( $error ) ) {
1715
-            return true;
1716
-        }
1486
+		}
1717 1487
 
1718
-        if( $echo ) {
1719
-            echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error');
1720
-        }
1721
-
1722
-        do_action('gravityview_log_error', 'GravityView_Edit_Entry[user_can_edit_field]' . $error );
1488
+		return $edit_fields;
1723 1489
 
1724
-        return false;
1490
+	}
1725 1491
 
1726
-    }
1492
+	/**
1493
+	 * Override GF Form field properties with the ones defined on the View
1494
+	 * @param  GF_Field $field GF Form field object
1495
+	 * @param  array $setting  GV field options
1496
+	 * @since  1.5
1497
+	 * @return array
1498
+	 */
1499
+	private function merge_field_properties( $field, $field_setting ) {
1727 1500
 
1501
+		$return_field = $field;
1728 1502
 
1729
-    /**
1730
-     * checks if user has permissions to edit a specific field
1731
-     *
1732
-     * Needs to be used combined with GravityView_Edit_Entry::user_can_edit_field for maximum security!!
1733
-     *
1734
-     * @param  [type] $field [description]
1735
-     * @return bool
1736
-     */
1737
-    private function check_user_cap_edit_field( $field ) {
1503
+		if( empty( $field_setting['show_label'] ) ) {
1504
+			$return_field->label = '';
1505
+		} elseif ( !empty( $field_setting['custom_label'] ) ) {
1506
+			$return_field->label = $field_setting['custom_label'];
1507
+		}
1738 1508
 
1739
-        // If they can edit any entries (as defined in Gravity Forms), we're good.
1740
-        if( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
1741
-            return true;
1742
-        }
1509
+		if( !empty( $field_setting['custom_class'] ) ) {
1510
+			$return_field->cssClass .= ' '. gravityview_sanitize_html_class( $field_setting['custom_class'] );
1511
+		}
1743 1512
 
1744
-        $field_cap = isset( $field['allow_edit_cap'] ) ? $field['allow_edit_cap'] : false;
1513
+		/**
1514
+		 * Normalize page numbers - avoid conflicts with page validation
1515
+		 * @since 1.6
1516
+		 */
1517
+		$return_field->pageNumber = 1;
1745 1518
 
1746
-        // If the field has custom editing capaibilities set, check those
1747
-        if( $field_cap ) {
1748
-            return GVCommon::has_cap( $field['allow_edit_cap'] );
1749
-        }
1750
-
1751
-        return false;
1752
-    }
1519
+		return $return_field;
1753 1520
 
1521
+	}
1754 1522
 
1755
-    /**
1756
-     * Is the current nonce valid for editing the entry?
1757
-     * @return boolean
1758
-     */
1759
-    public function verify_nonce() {
1523
+	/**
1524
+	 * Remove fields that shouldn't be visible based on the Gravity Forms adminOnly field property
1525
+	 *
1526
+	 * @since 1.9.1
1527
+	 *
1528
+	 * @param array|GF_Field[] $fields Gravity Forms form fields
1529
+	 * @param array|null $edit_fields Fields for the Edit Entry tab configured in the View Configuration
1530
+	 * @param array $form GF Form array
1531
+	 * @param int $view_id View ID
1532
+	 *
1533
+	 * @return array Possibly modified form array
1534
+	 */
1535
+	function filter_admin_only_fields( $fields = array(), $edit_fields = null, $form = array(), $view_id = 0 ) {
1536
+
1537
+		/**
1538
+		 * @filter `gravityview/edit_entry/use_gf_admin_only_setting` When Edit tab isn't configured, should the Gravity Forms "Admin Only" field settings be used to control field display to non-admins? Default: true
1539
+		 * If the Edit Entry tab is not configured, adminOnly fields will not be shown to non-administrators.
1540
+		 * If the Edit Entry tab *is* configured, adminOnly fields will be shown to non-administrators, using the configured GV permissions
1541
+		 * @since 1.9.1
1542
+		 * @param boolean $use_gf_adminonly_setting True: Hide field if set to Admin Only in GF and the user is not an admin. False: show field based on GV permissions, ignoring GF permissions.
1543
+		 * @param array $form GF Form array
1544
+		 * @param int $view_id View ID
1545
+		 */
1546
+		$use_gf_adminonly_setting = apply_filters( 'gravityview/edit_entry/use_gf_admin_only_setting', empty( $edit_fields ), $form, $view_id );
1547
+
1548
+		if( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry['id'] ) ) {
1549
+			foreach( $fields as $k => $field ) {
1550
+				if( $field->adminOnly ) {
1551
+					unset( $fields[ $k ] );
1552
+				}
1553
+			}
1554
+			return $fields;
1555
+		}
1760 1556
 
1761
-        // Verify form submitted for editing single
1762
-        if( $this->is_edit_entry_submission() ) {
1763
-            $valid = wp_verify_nonce( $_POST[ self::$nonce_field ], self::$nonce_field );
1764
-        }
1557
+		foreach( $fields as &$field ) {
1558
+			$field->adminOnly = false;
1559
+		}
1560
+
1561
+		return $fields;
1562
+	}
1765 1563
 
1766
-        // Verify
1767
-        else if( ! $this->is_edit_entry() ) {
1768
-            $valid = false;
1769
-        }
1564
+	// --- Conditional Logic
1770 1565
 
1771
-        else {
1772
-            $valid = wp_verify_nonce( $_GET['edit'], self::$nonce_key );
1773
-        }
1566
+	/**
1567
+	 * Remove the conditional logic rules from the form button and the form fields, if needed.
1568
+	 *
1569
+	 * @since 1.9
1570
+	 *
1571
+	 * @param array $form Gravity Forms form
1572
+	 * @return array Modified form, if not using Conditional Logic
1573
+	 */
1574
+	function filter_conditional_logic( $form ) {
1575
+
1576
+		/**
1577
+		 * @filter `gravityview/edit_entry/conditional_logic` Should the Edit Entry form use Gravity Forms conditional logic showing/hiding of fields?
1578
+		 * @since 1.9
1579
+		 * @param bool $use_conditional_logic True: Gravity Forms will show/hide fields just like in the original form; False: conditional logic will be disabled and fields will be shown based on configuration. Default: true
1580
+		 * @param array $form Gravity Forms form
1581
+		 */
1582
+		$use_conditional_logic = apply_filters( 'gravityview/edit_entry/conditional_logic', true, $form );
1583
+
1584
+		if( $use_conditional_logic ) {
1585
+			return $form;
1586
+		}
1774 1587
 
1775
-        /**
1776
-         * @filter `gravityview/edit_entry/verify_nonce` Override Edit Entry nonce validation. Return true to declare nonce valid.
1777
-         * @since 1.13
1778
-         * @param int|boolean $valid False if invalid; 1 or 2 when nonce was generated
1779
-         * @param string $nonce_field Key used when validating submissions. Default: is_gv_edit_entry
1780
-         */
1781
-        $valid = apply_filters( 'gravityview/edit_entry/verify_nonce', $valid, self::$nonce_field );
1588
+		foreach( $form['fields'] as &$field ) {
1589
+			/* @var GF_Field $field */
1590
+			$field->conditionalLogic = null;
1591
+		}
1592
+
1593
+		unset( $form['button']['conditionalLogic'] );
1594
+
1595
+		return $form;
1596
+
1597
+	}
1598
+
1599
+	/**
1600
+	 * Disable the Gravity Forms conditional logic script and features on the Edit Entry screen
1601
+	 *
1602
+	 * @since 1.9
1603
+	 *
1604
+	 * @param $has_conditional_logic
1605
+	 * @param $form
1606
+	 * @return mixed|void
1607
+	 */
1608
+	function manage_conditional_logic( $has_conditional_logic, $form ) {
1609
+
1610
+		if( ! $this->is_edit_entry() ) {
1611
+			return $has_conditional_logic;
1612
+		}
1613
+
1614
+		return apply_filters( 'gravityview/edit_entry/conditional_logic', $has_conditional_logic, $form );
1615
+	}
1616
+
1617
+
1618
+	// --- User checks and nonces
1619
+
1620
+	/**
1621
+	 * Check if the user can edit the entry
1622
+	 *
1623
+	 * - Is the nonce valid?
1624
+	 * - Does the user have the right caps for the entry
1625
+	 * - Is the entry in the trash?
1626
+	 *
1627
+	 * @todo Move to GVCommon
1628
+	 *
1629
+	 * @param  boolean $echo Show error messages in the form?
1630
+	 * @return boolean        True: can edit form. False: nope.
1631
+	 */
1632
+	function user_can_edit_entry( $echo = false ) {
1633
+
1634
+		$error = NULL;
1635
+
1636
+		/**
1637
+		 *  1. Permalinks are turned off
1638
+		 *  2. There are two entries embedded using oEmbed
1639
+		 *  3. One of the entries has just been saved
1640
+		 */
1641
+		if( !empty( $_POST['lid'] ) && !empty( $_GET['entry'] ) && ( $_POST['lid'] !== $_GET['entry'] ) ) {
1642
+
1643
+			$error = true;
1644
+
1645
+		}
1646
+
1647
+		if( !empty( $_GET['entry'] ) && (string)$this->entry['id'] !== $_GET['entry'] ) {
1648
+
1649
+			$error = true;
1650
+
1651
+		} elseif( ! $this->verify_nonce() ) {
1652
+
1653
+			/**
1654
+			 * If the Entry is embedded, there may be two entries on the same page.
1655
+			 * If that's the case, and one is being edited, the other should fail gracefully and not display an error.
1656
+			 */
1657
+			if( GravityView_oEmbed::getInstance()->get_entry_id() ) {
1658
+				$error = true;
1659
+			} else {
1660
+				$error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview');
1661
+			}
1662
+
1663
+		}
1664
+
1665
+		if( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
1666
+			$error = __( 'You do not have permission to edit this entry.', 'gravityview');
1667
+		}
1668
+
1669
+		if( $this->entry['status'] === 'trash' ) {
1670
+			$error = __('You cannot edit the entry; it is in the trash.', 'gravityview' );
1671
+		}
1782 1672
 
1783
-        return $valid;
1784
-    }
1673
+		// No errors; everything's fine here!
1674
+		if( empty( $error ) ) {
1675
+			return true;
1676
+		}
1677
+
1678
+		if( $echo && $error !== true ) {
1679
+
1680
+			$error = esc_html( $error );
1681
+
1682
+			/**
1683
+			 * @since 1.9
1684
+			 */
1685
+			if ( ! empty( $this->entry ) ) {
1686
+				$error .= ' ' . gravityview_get_link( '#', _x('Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
1687
+			}
1688
+
1689
+			echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error');
1690
+		}
1691
+
1692
+		do_action('gravityview_log_error', 'GravityView_Edit_Entry[user_can_edit_entry]' . $error );
1693
+
1694
+		return false;
1695
+	}
1696
+
1697
+
1698
+	/**
1699
+	 * Check whether a field is editable by the current user, and optionally display an error message
1700
+	 * @uses  GravityView_Edit_Entry->check_user_cap_edit_field() Check user capabilities
1701
+	 * @param  array  $field Field or field settings array
1702
+	 * @param  boolean $echo  Whether to show error message telling user they aren't allowed
1703
+	 * @return boolean         True: user can edit the current field; False: nope, they can't.
1704
+	 */
1705
+	private function user_can_edit_field( $field, $echo = false ) {
1706
+
1707
+		$error = NULL;
1708
+
1709
+		if( ! $this->check_user_cap_edit_field( $field ) ) {
1710
+			$error = __( 'You do not have permission to edit this field.', 'gravityview');
1711
+		}
1712
+
1713
+		// No errors; everything's fine here!
1714
+		if( empty( $error ) ) {
1715
+			return true;
1716
+		}
1717
+
1718
+		if( $echo ) {
1719
+			echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error');
1720
+		}
1721
+
1722
+		do_action('gravityview_log_error', 'GravityView_Edit_Entry[user_can_edit_field]' . $error );
1723
+
1724
+		return false;
1725
+
1726
+	}
1727
+
1728
+
1729
+	/**
1730
+	 * checks if user has permissions to edit a specific field
1731
+	 *
1732
+	 * Needs to be used combined with GravityView_Edit_Entry::user_can_edit_field for maximum security!!
1733
+	 *
1734
+	 * @param  [type] $field [description]
1735
+	 * @return bool
1736
+	 */
1737
+	private function check_user_cap_edit_field( $field ) {
1738
+
1739
+		// If they can edit any entries (as defined in Gravity Forms), we're good.
1740
+		if( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
1741
+			return true;
1742
+		}
1743
+
1744
+		$field_cap = isset( $field['allow_edit_cap'] ) ? $field['allow_edit_cap'] : false;
1745
+
1746
+		// If the field has custom editing capaibilities set, check those
1747
+		if( $field_cap ) {
1748
+			return GVCommon::has_cap( $field['allow_edit_cap'] );
1749
+		}
1750
+
1751
+		return false;
1752
+	}
1753
+
1754
+
1755
+	/**
1756
+	 * Is the current nonce valid for editing the entry?
1757
+	 * @return boolean
1758
+	 */
1759
+	public function verify_nonce() {
1760
+
1761
+		// Verify form submitted for editing single
1762
+		if( $this->is_edit_entry_submission() ) {
1763
+			$valid = wp_verify_nonce( $_POST[ self::$nonce_field ], self::$nonce_field );
1764
+		}
1765
+
1766
+		// Verify
1767
+		else if( ! $this->is_edit_entry() ) {
1768
+			$valid = false;
1769
+		}
1770
+
1771
+		else {
1772
+			$valid = wp_verify_nonce( $_GET['edit'], self::$nonce_key );
1773
+		}
1774
+
1775
+		/**
1776
+		 * @filter `gravityview/edit_entry/verify_nonce` Override Edit Entry nonce validation. Return true to declare nonce valid.
1777
+		 * @since 1.13
1778
+		 * @param int|boolean $valid False if invalid; 1 or 2 when nonce was generated
1779
+		 * @param string $nonce_field Key used when validating submissions. Default: is_gv_edit_entry
1780
+		 */
1781
+		$valid = apply_filters( 'gravityview/edit_entry/verify_nonce', $valid, self::$nonce_field );
1782
+
1783
+		return $valid;
1784
+	}
1785 1785
 
1786 1786
 
1787 1787
 
Please login to merge, or discard this patch.
Spacing   +220 added lines, -220 removed lines patch added patch discarded remove patch
@@ -112,16 +112,16 @@  discard block
 block discarded – undo
112 112
     function load() {
113 113
 
114 114
         /** @define "GRAVITYVIEW_DIR" "../../../" */
115
-        include_once( GRAVITYVIEW_DIR .'includes/class-admin-approve-entries.php' );
115
+        include_once( GRAVITYVIEW_DIR . 'includes/class-admin-approve-entries.php' );
116 116
 
117 117
         // Don't display an embedded form when editing an entry
118 118
         add_action( 'wp_head', array( $this, 'prevent_render_form' ) );
119 119
         add_action( 'wp_footer', array( $this, 'prevent_render_form' ) );
120 120
 
121 121
         // Stop Gravity Forms processing what is ours!
122
-        add_filter( 'wp', array( $this, 'prevent_maybe_process_form'), 8 );
122
+        add_filter( 'wp', array( $this, 'prevent_maybe_process_form' ), 8 );
123 123
 
124
-        add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry') );
124
+        add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry' ) );
125 125
 
126 126
         add_action( 'gravityview_edit_entry', array( $this, 'init' ) );
127 127
 
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
         add_filter( 'gform_plupload_settings', array( $this, 'modify_fileupload_settings' ), 10, 3 );
133 133
 
134 134
         // Add fields expected by GFFormDisplay::validate()
135
-        add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation') );
135
+        add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation' ) );
136 136
 
137 137
     }
138 138
 
@@ -147,8 +147,8 @@  discard block
 block discarded – undo
147 147
      * @return void
148 148
      */
149 149
     function prevent_render_form() {
150
-        if( $this->is_edit_entry() ) {
151
-            if( 'wp_head' === current_filter() ) {
150
+        if ( $this->is_edit_entry() ) {
151
+            if ( 'wp_head' === current_filter() ) {
152 152
                 add_filter( 'gform_shortcode_form', '__return_empty_string' );
153 153
             } else {
154 154
                 remove_filter( 'gform_shortcode_form', '__return_empty_string' );
@@ -163,10 +163,10 @@  discard block
 block discarded – undo
163 163
      */
164 164
     function prevent_maybe_process_form() {
165 165
 
166
-        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[prevent_maybe_process_form] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
166
+        do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[prevent_maybe_process_form] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
167 167
 
168
-        if( $this->is_edit_entry_submission() && $this->verify_nonce() ) {
169
-            remove_action( 'wp',  array( 'RGForms', 'maybe_process_form'), 9 );
168
+        if ( $this->is_edit_entry_submission() && $this->verify_nonce() ) {
169
+            remove_action( 'wp', array( 'RGForms', 'maybe_process_form' ), 9 );
170 170
         }
171 171
     }
172 172
 
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
 
179 179
         $gf_page = ( 'entry' === RGForms::get( 'view' ) );
180 180
 
181
-        return ( $gf_page && isset( $_GET['edit'] ) || RGForms::post( 'action' ) === 'update' );
181
+        return ( $gf_page && isset( $_GET[ 'edit' ] ) || RGForms::post( 'action' ) === 'update' );
182 182
     }
183 183
 
184 184
 	/**
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
 	 * @return boolean
188 188
 	 */
189 189
 	public function is_edit_entry_submission() {
190
-		return !empty( $_POST[ self::$nonce_field ] );
190
+		return ! empty( $_POST[ self::$nonce_field ] );
191 191
 	}
192 192
 
193 193
     /**
@@ -198,13 +198,13 @@  discard block
 block discarded – undo
198 198
 
199 199
 
200 200
         $entries = $gravityview_view->getEntries();
201
-        $this->entry = $entries[0];
201
+        $this->entry = $entries[ 0 ];
202 202
 
203 203
         $this->original_form = $this->form = $gravityview_view->getForm();
204 204
         $this->form_id = $gravityview_view->getFormId();
205 205
         $this->view_id = $gravityview_view->getViewId();
206 206
 
207
-        self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry['id'] );
207
+        self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry[ 'id' ] );
208 208
     }
209 209
 
210 210
 
@@ -224,12 +224,12 @@  discard block
 block discarded – undo
224 224
         $this->setup_vars();
225 225
 
226 226
         // Multiple Views embedded, don't proceed if nonce fails
227
-        if( $gv_data->has_multiple_views() && ! wp_verify_nonce( $_GET['edit'], self::$nonce_key ) ) {
227
+        if ( $gv_data->has_multiple_views() && ! wp_verify_nonce( $_GET[ 'edit' ], self::$nonce_key ) ) {
228 228
             return;
229 229
         }
230 230
 
231 231
         // Sorry, you're not allowed here.
232
-        if( false === $this->user_can_edit_entry( true ) ) {
232
+        if ( false === $this->user_can_edit_entry( true ) ) {
233 233
             return;
234 234
         }
235 235
 
@@ -249,9 +249,9 @@  discard block
 block discarded – undo
249 249
     function print_scripts() {
250 250
         $gravityview_view = GravityView_View::getInstance();
251 251
 
252
-        wp_register_script( 'gform_gravityforms', GFCommon::get_base_url().'/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
252
+        wp_register_script( 'gform_gravityforms', GFCommon::get_base_url() . '/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
253 253
 
254
-        GFFormDisplay::enqueue_form_scripts($gravityview_view->getForm(), false);
254
+        GFFormDisplay::enqueue_form_scripts( $gravityview_view->getForm(), false );
255 255
 
256 256
         // Sack is required for images
257 257
         wp_print_scripts( array( 'sack', 'gform_gravityforms' ) );
@@ -263,32 +263,32 @@  discard block
 block discarded – undo
263 263
      */
264 264
     function process_save() {
265 265
 
266
-        if( empty( $_POST ) ) {
266
+        if ( empty( $_POST ) ) {
267 267
             return;
268 268
         }
269 269
 
270 270
         // Make sure the entry, view, and form IDs are all correct
271 271
         $valid = $this->verify_nonce();
272 272
 
273
-        if( !$valid ) {
274
-            do_action('gravityview_log_error', __METHOD__ . ' Nonce validation failed.' );
273
+        if ( ! $valid ) {
274
+            do_action( 'gravityview_log_error', __METHOD__ . ' Nonce validation failed.' );
275 275
             return;
276 276
         }
277 277
 
278
-        if( $this->entry['id'] !== $_POST['lid'] ) {
279
-            do_action('gravityview_log_error', __METHOD__ . ' Entry ID did not match posted entry ID.' );
278
+        if ( $this->entry[ 'id' ] !== $_POST[ 'lid' ] ) {
279
+            do_action( 'gravityview_log_error', __METHOD__ . ' Entry ID did not match posted entry ID.' );
280 280
             return;
281 281
         }
282 282
 
283
-        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[process_save] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
283
+        do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[process_save] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
284 284
 
285 285
         $this->process_save_process_files( $this->form_id );
286 286
 
287 287
         $this->validate();
288 288
 
289
-        if( $this->is_valid ) {
289
+        if ( $this->is_valid ) {
290 290
 
291
-            do_action('gravityview_log_debug', 'GravityView_Edit_Entry[process_save] Submission is valid.' );
291
+            do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[process_save] Submission is valid.' );
292 292
 
293 293
             /**
294 294
              * @hack This step is needed to unset the adminOnly from form fields, to add the calculation fields
@@ -298,12 +298,12 @@  discard block
 block discarded – undo
298 298
             /**
299 299
              * @hack to avoid the capability validation of the method save_lead for GF 1.9+
300 300
              */
301
-            unset( $_GET['page'] );
301
+            unset( $_GET[ 'page' ] );
302 302
 
303 303
             GFFormsModel::save_lead( $form, $this->entry );
304 304
 
305 305
             // If there's a post associated with the entry, process post fields
306
-            if( !empty( $this->entry['post_id'] ) ) {
306
+            if ( ! empty( $this->entry[ 'post_id' ] ) ) {
307 307
                 $this->maybe_update_post_fields( $form );
308 308
             }
309 309
 
@@ -318,7 +318,7 @@  discard block
 block discarded – undo
318 318
              * @param array $form Gravity Forms form array
319 319
              * @param string $entry_id Numeric ID of the entry that was updated
320 320
              */
321
-            do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry['id'] );
321
+            do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry[ 'id' ] );
322 322
         }
323 323
 
324 324
     } // process_save
@@ -352,11 +352,11 @@  discard block
 block discarded – undo
352 352
      * @return mixed
353 353
      */
354 354
     public function modify_fileupload_settings( $plupload_init, $form_id, $instance ) {
355
-        if( ! $this->is_edit_entry() ) {
355
+        if ( ! $this->is_edit_entry() ) {
356 356
             return $plupload_init;
357 357
         }
358 358
 
359
-        $plupload_init['gf_vars']['max_files'] = 0;
359
+        $plupload_init[ 'gf_vars' ][ 'max_files' ] = 0;
360 360
 
361 361
         return $plupload_init;
362 362
     }
@@ -370,13 +370,13 @@  discard block
 block discarded – undo
370 370
 
371 371
         $form = $this->form;
372 372
 
373
-        foreach( $form['fields'] as &$field ) {
373
+        foreach ( $form[ 'fields' ] as &$field ) {
374 374
 
375 375
             $field->adminOnly = false;
376 376
 
377
-            if( isset( $field->inputs ) && is_array( $field->inputs ) ) {
378
-                foreach( $field->inputs as $key => $input ) {
379
-                    $field->inputs[ $key ][ 'id' ] = (string)$input['id'];
377
+            if ( isset( $field->inputs ) && is_array( $field->inputs ) ) {
378
+                foreach ( $field->inputs as $key => $input ) {
379
+                    $field->inputs[ $key ][ 'id' ] = (string)$input[ 'id' ];
380 380
                 }
381 381
             }
382 382
         }
@@ -390,20 +390,20 @@  discard block
 block discarded – undo
390 390
         $update = false;
391 391
 
392 392
         // get the most up to date entry values
393
-        $entry = GFAPI::get_entry( $this->entry['id'] );
393
+        $entry = GFAPI::get_entry( $this->entry[ 'id' ] );
394 394
 
395
-        if( !empty( $this->fields_with_calculation ) ) {
395
+        if ( ! empty( $this->fields_with_calculation ) ) {
396 396
             $update = true;
397 397
             foreach ( $this->fields_with_calculation as $calc_field ) {
398 398
                 $inputs = $calc_field->get_entry_inputs();
399 399
                 if ( is_array( $inputs ) ) {
400 400
                     foreach ( $inputs as $input ) {
401
-                        $input_name = 'input_' . str_replace( '.', '_', $input['id'] );
402
-                        $entry[ strval( $input['id'] ) ] = RGFormsModel::prepare_value( $form, $calc_field, '', $input_name, $entry['id'], $entry );
401
+                        $input_name = 'input_' . str_replace( '.', '_', $input[ 'id' ] );
402
+                        $entry[ strval( $input[ 'id' ] ) ] = RGFormsModel::prepare_value( $form, $calc_field, '', $input_name, $entry[ 'id' ], $entry );
403 403
                     }
404 404
                 } else {
405
-                    $input_name = 'input_' . str_replace( '.', '_', $calc_field->id);
406
-                    $entry[ strval( $calc_field->id ) ] = RGFormsModel::prepare_value( $form, $calc_field, '', $input_name, $entry['id'], $entry );
405
+                    $input_name = 'input_' . str_replace( '.', '_', $calc_field->id );
406
+                    $entry[ strval( $calc_field->id ) ] = RGFormsModel::prepare_value( $form, $calc_field, '', $input_name, $entry[ 'id' ], $entry );
407 407
                 }
408 408
             }
409 409
 
@@ -413,16 +413,16 @@  discard block
 block discarded – undo
413 413
         if ( ! empty( $this->total_fields ) ) {
414 414
             $update = true;
415 415
             foreach ( $this->total_fields as $total_field ) {
416
-                $input_name = 'input_' . str_replace( '.', '_', $total_field->id);
417
-                $entry[ strval( $total_field->id ) ] = RGFormsModel::prepare_value( $form, $total_field, '', $input_name, $entry['id'], $entry );
416
+                $input_name = 'input_' . str_replace( '.', '_', $total_field->id );
417
+                $entry[ strval( $total_field->id ) ] = RGFormsModel::prepare_value( $form, $total_field, '', $input_name, $entry[ 'id' ], $entry );
418 418
             }
419 419
         }
420 420
 
421
-        if( $update ) {
421
+        if ( $update ) {
422 422
 
423 423
             $return_entry = GFAPI::update_entry( $entry );
424 424
 
425
-            if( is_wp_error( $return_entry ) ) {
425
+            if ( is_wp_error( $return_entry ) ) {
426 426
                 do_action( 'gravityview_log_error', 'Updating the entry calculation and total fields failed', $return_entry );
427 427
             } else {
428 428
                 do_action( 'gravityview_log_debug', 'Updating the entry calculation and total fields succeeded' );
@@ -440,11 +440,11 @@  discard block
 block discarded – undo
440 440
      */
441 441
     function maybe_update_post_fields( $form ) {
442 442
 
443
-        $post_id = $this->entry['post_id'];
443
+        $post_id = $this->entry[ 'post_id' ];
444 444
 
445 445
         // Security check
446
-        if( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
447
-            do_action( 'gravityview_log_error', 'The current user does not have the ability to edit Post #'.$post_id );
446
+        if ( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
447
+            do_action( 'gravityview_log_error', 'The current user does not have the ability to edit Post #' . $post_id );
448 448
             return;
449 449
         }
450 450
 
@@ -453,7 +453,7 @@  discard block
 block discarded – undo
453 453
         $updated_post = $original_post = get_post( $post_id );
454 454
 
455 455
         // get the most up to date entry values
456
-        $entry = GFAPI::get_entry( $this->entry['id'] );
456
+        $entry = GFAPI::get_entry( $this->entry[ 'id' ] );
457 457
 
458 458
         foreach ( $entry as $field_id => $value ) {
459 459
 
@@ -461,16 +461,16 @@  discard block
 block discarded – undo
461 461
 
462 462
             $field = RGFormsModel::get_field( $form, $field_id );
463 463
 
464
-            if( class_exists('GF_Fields') ) {
464
+            if ( class_exists( 'GF_Fields' ) ) {
465 465
                 $field = GF_Fields::create( $field );
466 466
             }
467 467
 
468
-            if( GFCommon::is_post_field( $field ) ) {
468
+            if ( GFCommon::is_post_field( $field ) ) {
469 469
 
470 470
                 // Get the value of the field, including $_POSTed value
471 471
                 $value = RGFormsModel::get_field_value( $field );
472 472
 
473
-                switch( $field->type ) {
473
+                switch ( $field->type ) {
474 474
 
475 475
                     case 'post_title':
476 476
                     case 'post_content':
@@ -488,14 +488,14 @@  discard block
 block discarded – undo
488 488
                         wp_set_post_categories( $post_id, $categories, false );
489 489
 
490 490
                         // if post_category is type checkbox, then value is an array of inputs
491
-                        if( isset( $value[ strval( $field_id ) ] ) ) {
492
-                            foreach( $value as $input_id => $val ) {
491
+                        if ( isset( $value[ strval( $field_id ) ] ) ) {
492
+                            foreach ( $value as $input_id => $val ) {
493 493
                                 $input_name = 'input_' . str_replace( '.', '_', $input_id );
494
-                                $entry[ strval( $input_id ) ] = RGFormsModel::prepare_value( $form, $field, $val, $input_name, $entry['id'], $entry );
494
+                                $entry[ strval( $input_id ) ] = RGFormsModel::prepare_value( $form, $field, $val, $input_name, $entry[ 'id' ], $entry );
495 495
                             }
496 496
                         } else {
497 497
                             $input_name = 'input_' . str_replace( '.', '_', $field_id );
498
-                            $entry[ strval( $field_id ) ] = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], $entry );
498
+                            $entry[ strval( $field_id ) ] = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry[ 'id' ], $entry );
499 499
                         }
500 500
 
501 501
                         break;
@@ -505,12 +505,12 @@  discard block
 block discarded – undo
505 505
                         $custom_field_name = $field->postCustomFieldName;
506 506
 
507 507
                         // Only certain custom field types are supported
508
-                        switch( $input_type ) {
508
+                        switch ( $input_type ) {
509 509
                             case 'fileupload':
510 510
                             /** @noinspection PhpMissingBreakStatementInspection */
511 511
                             case 'list':
512
-                                if( ! is_string( $value ) ) {
513
-                                    $value = function_exists('wp_json_encode') ? wp_json_encode( $value ) : json_encode( $value );
512
+                                if ( ! is_string( $value ) ) {
513
+                                    $value = function_exists( 'wp_json_encode' ) ? wp_json_encode( $value ) : json_encode( $value );
514 514
                                 }
515 515
                             // break; left intentionally out
516 516
                             default:
@@ -523,11 +523,11 @@  discard block
 block discarded – undo
523 523
 
524 524
                         $input_name = 'input_' . $field_id;
525 525
 
526
-                        if ( !empty( $_FILES[ $input_name ]['name'] ) ) {
526
+                        if ( ! empty( $_FILES[ $input_name ][ 'name' ] ) ) {
527 527
 
528 528
                             // We have a new image
529 529
 
530
-                            $value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'] );
530
+                            $value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry[ 'id' ] );
531 531
 
532 532
                             // is this field set as featured image, if not, leave
533 533
                             if ( ! $field->postFeaturedImage ) {
@@ -537,9 +537,9 @@  discard block
 block discarded – undo
537 537
                             $ary = ! empty( $value ) ? explode( '|:|', $value ) : array();
538 538
                             $img_url = rgar( $ary, 0 );
539 539
 
540
-                            $img_title       = count( $ary ) > 1 ? $ary[1] : '';
541
-                            $img_caption     = count( $ary ) > 2 ? $ary[2] : '';
542
-                            $img_description = count( $ary ) > 3 ? $ary[3] : '';
540
+                            $img_title       = count( $ary ) > 1 ? $ary[ 1 ] : '';
541
+                            $img_caption     = count( $ary ) > 2 ? $ary[ 2 ] : '';
542
+                            $img_description = count( $ary ) > 3 ? $ary[ 3 ] : '';
543 543
 
544 544
                             $image_meta = array(
545 545
                                 'post_excerpt' => $img_caption,
@@ -548,7 +548,7 @@  discard block
 block discarded – undo
548 548
 
549 549
                             //adding title only if it is not empty. It will default to the file name if it is not in the array
550 550
                             if ( ! empty( $img_title ) ) {
551
-                                $image_meta['post_title'] = $img_title;
551
+                                $image_meta[ 'post_title' ] = $img_title;
552 552
                             }
553 553
 
554 554
                             //todo: As soon as \GFFormsModel::media_handle_upload becomes a public method, move this call to \GFFormsModel::media_handle_upload and remove the hack from this class.
@@ -561,7 +561,7 @@  discard block
 block discarded – undo
561 561
 
562 562
                             break;
563 563
 
564
-                        } elseif ( !empty( $_POST[ $input_name ] ) && is_array( $value ) ) {
564
+                        } elseif ( ! empty( $_POST[ $input_name ] ) && is_array( $value ) ) {
565 565
 
566 566
                             // Same image although the image title, caption or description might have changed
567 567
 
@@ -569,11 +569,11 @@  discard block
 block discarded – undo
569 569
                             $img_url = rgar( $ary, 0 );
570 570
 
571 571
                             // is this really the same image or something went wrong ?
572
-                            if( $img_url === $_POST[ $input_name ] ) {
572
+                            if ( $img_url === $_POST[ $input_name ] ) {
573 573
 
574
-                                $img_title       = isset( $value[ $field_id .'.1' ] ) ? $value[ $field_id .'.1' ] : '';
575
-                                $img_caption     = isset( $value[ $field_id .'.4' ] ) ? $value[ $field_id .'.4' ] : '';
576
-                                $img_description = isset( $value[ $field_id .'.7' ] ) ? $value[ $field_id .'.7' ] : '';
574
+                                $img_title       = isset( $value[ $field_id . '.1' ] ) ? $value[ $field_id . '.1' ] : '';
575
+                                $img_caption     = isset( $value[ $field_id . '.4' ] ) ? $value[ $field_id . '.4' ] : '';
576
+                                $img_description = isset( $value[ $field_id . '.7' ] ) ? $value[ $field_id . '.7' ] : '';
577 577
 
578 578
                                 $value = ! empty( $img_url ) ? $img_url . "|:|" . $img_title . "|:|" . $img_caption . "|:|" . $img_description : '';
579 579
 
@@ -607,12 +607,12 @@  discard block
 block discarded – undo
607 607
                 }
608 608
 
609 609
                 //ignore fields that have not changed
610
-                if ( $value === rgget( (string) $field_id, $entry ) ) {
610
+                if ( $value === rgget( (string)$field_id, $entry ) ) {
611 611
                     continue;
612 612
                 }
613 613
 
614 614
                 // update entry
615
-                if( 'post_category' !== $field->type ) {
615
+                if ( 'post_category' !== $field->type ) {
616 616
                     $entry[ strval( $field_id ) ] = $value;
617 617
                 }
618 618
 
@@ -622,25 +622,25 @@  discard block
 block discarded – undo
622 622
 
623 623
         }
624 624
 
625
-        if( $update_entry ) {
625
+        if ( $update_entry ) {
626 626
 
627 627
             $return_entry = GFAPI::update_entry( $entry );
628 628
 
629
-            if( is_wp_error( $return_entry ) ) {
629
+            if ( is_wp_error( $return_entry ) ) {
630 630
                 do_action( 'gravityview_log_error', 'Updating the entry post fields failed', $return_entry );
631 631
             } else {
632
-                do_action( 'gravityview_log_debug', 'Updating the entry post fields for post #'.$post_id.' succeeded' );
632
+                do_action( 'gravityview_log_debug', 'Updating the entry post fields for post #' . $post_id . ' succeeded' );
633 633
             }
634 634
 
635 635
         }
636 636
 
637 637
         $return_post = wp_update_post( $updated_post, true );
638 638
 
639
-        if( is_wp_error( $return_post ) ) {
639
+        if ( is_wp_error( $return_post ) ) {
640 640
             $return_post->add_data( $updated_post, '$updated_post' );
641 641
             do_action( 'gravityview_log_error', 'Updating the post content failed', $return_post );
642 642
         } else {
643
-            do_action( 'gravityview_log_debug', 'Updating the post content for post #'.$post_id.' succeeded', $updated_post );
643
+            do_action( 'gravityview_log_debug', 'Updating the post content for post #' . $post_id . ' succeeded', $updated_post );
644 644
         }
645 645
 
646 646
     }
@@ -657,18 +657,18 @@  discard block
 block discarded – undo
657 657
      */
658 658
     function after_update() {
659 659
 
660
-        do_action( 'gform_after_update_entry', $this->form, $this->entry['id'] );
661
-        do_action( "gform_after_update_entry_{$this->form['id']}", $this->form, $this->entry['id'] );
660
+        do_action( 'gform_after_update_entry', $this->form, $this->entry[ 'id' ] );
661
+        do_action( "gform_after_update_entry_{$this->form[ 'id' ]}", $this->form, $this->entry[ 'id' ] );
662 662
 
663 663
         // Re-define the entry now that we've updated it.
664
-        $entry = RGFormsModel::get_lead( $this->entry['id'] );
664
+        $entry = RGFormsModel::get_lead( $this->entry[ 'id' ] );
665 665
 
666 666
         $entry = GFFormsModel::set_entry_meta( $entry, $this->form );
667 667
 
668 668
         // We need to clear the cache because Gravity Forms caches the field values, which
669 669
         // we have just updated.
670
-        foreach ($this->form['fields'] as $key => $field) {
671
-            GFFormsModel::refresh_lead_field_value( $entry['id'], $field->id );
670
+        foreach ( $this->form[ 'fields' ] as $key => $field ) {
671
+            GFFormsModel::refresh_lead_field_value( $entry[ 'id' ], $field->id );
672 672
         }
673 673
 
674 674
         $this->entry = $entry;
@@ -686,7 +686,7 @@  discard block
 block discarded – undo
686 686
 
687 687
         <div class="gv-edit-entry-wrapper"><?php
688 688
 
689
-            $javascript = gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/inline-javascript.php', $this );
689
+            $javascript = gravityview_ob_include( GravityView_Edit_Entry::$file . '/partials/inline-javascript.php', $this );
690 690
 
691 691
             /**
692 692
              * Fixes weird wpautop() issue
@@ -702,7 +702,7 @@  discard block
 block discarded – undo
702 702
                      * @param string $edit_entry_title Modify the "Edit Entry" title
703 703
                      * @param GravityView_Edit_Entry_Render $this This object
704 704
                      */
705
-                    $edit_entry_title = apply_filters('gravityview_edit_entry_title', __('Edit Entry', 'gravityview'), $this );
705
+                    $edit_entry_title = apply_filters( 'gravityview_edit_entry_title', __( 'Edit Entry', 'gravityview' ), $this );
706 706
 
707 707
                     echo esc_attr( $edit_entry_title );
708 708
             ?></span>
@@ -742,20 +742,20 @@  discard block
 block discarded – undo
742 742
      */
743 743
     private function maybe_print_message() {
744 744
 
745
-        if( rgpost('action') === 'update' ) {
745
+        if ( rgpost( 'action' ) === 'update' ) {
746 746
 
747 747
             $back_link = esc_url( remove_query_arg( array( 'page', 'view', 'edit' ) ) );
748 748
 
749
-            if( ! $this->is_valid ){
749
+            if ( ! $this->is_valid ) {
750 750
 
751 751
                 // Keeping this compatible with Gravity Forms.
752
-                $validation_message = "<div class='validation_error'>" . __('There was a problem with your submission.', 'gravityview') . " " . __('Errors have been highlighted below.', 'gravityview') . "</div>";
753
-                $message = apply_filters("gform_validation_message_{$this->form['id']}", apply_filters("gform_validation_message", $validation_message, $this->form), $this->form);
752
+                $validation_message = "<div class='validation_error'>" . __( 'There was a problem with your submission.', 'gravityview' ) . " " . __( 'Errors have been highlighted below.', 'gravityview' ) . "</div>";
753
+                $message = apply_filters( "gform_validation_message_{$this->form[ 'id' ]}", apply_filters( "gform_validation_message", $validation_message, $this->form ), $this->form );
754 754
 
755
-                echo GVCommon::generate_notice( $message , 'gv-error' );
755
+                echo GVCommon::generate_notice( $message, 'gv-error' );
756 756
 
757 757
             } else {
758
-                $entry_updated_message = sprintf( esc_attr__('Entry Updated. %sReturn to Entry%s', 'gravityview'), '<a href="'. $back_link .'">', '</a>' );
758
+                $entry_updated_message = sprintf( esc_attr__( 'Entry Updated. %sReturn to Entry%s', 'gravityview' ), '<a href="' . $back_link . '">', '</a>' );
759 759
 
760 760
                 /**
761 761
                  * @filter `gravityview/edit_entry/success` Modify the edit entry success message (including the anchor link)
@@ -765,7 +765,7 @@  discard block
 block discarded – undo
765 765
                  * @param array $entry Gravity Forms entry array
766 766
                  * @param string $back_link URL to return to the original entry. @since 1.6
767 767
                  */
768
-                $message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message , $this->view_id, $this->entry, $back_link );
768
+                $message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message, $this->view_id, $this->entry, $back_link );
769 769
 
770 770
                 echo GVCommon::generate_notice( $message );
771 771
             }
@@ -786,15 +786,15 @@  discard block
 block discarded – undo
786 786
      */
787 787
     private function render_edit_form() {
788 788
 
789
-        add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields'), 5000, 3 );
790
-        add_filter( 'gform_submit_button', array( $this, 'render_form_buttons') );
789
+        add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields' ), 5000, 3 );
790
+        add_filter( 'gform_submit_button', array( $this, 'render_form_buttons' ) );
791 791
         add_filter( 'gform_disable_view_counter', '__return_true' );
792 792
 
793 793
         add_filter( 'gform_field_input', array( $this, 'verify_user_can_edit_post' ), 5, 5 );
794 794
         add_filter( 'gform_field_input', array( $this, 'modify_edit_field_input' ), 10, 5 );
795 795
 
796 796
         // We need to remove the fake $_GET['page'] arg to avoid rendering form as if in admin.
797
-        unset( $_GET['page'] );
797
+        unset( $_GET[ 'page' ] );
798 798
 
799 799
         // TODO: Make sure validation isn't handled by GF
800 800
         // TODO: Include CSS for file upload fields
@@ -802,7 +802,7 @@  discard block
 block discarded – undo
802 802
         // TODO: Product fields are not editable
803 803
         // TODO: Check Updated and Error messages
804 804
 
805
-        $html = GFFormDisplay::get_form( $this->form['id'], false, false, true, $this->entry );
805
+        $html = GFFormDisplay::get_form( $this->form[ 'id' ], false, false, true, $this->entry );
806 806
 
807 807
 	    remove_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields' ), 5000 );
808 808
         remove_filter( 'gform_submit_button', array( $this, 'render_form_buttons' ) );
@@ -819,7 +819,7 @@  discard block
 block discarded – undo
819 819
      * @return string
820 820
      */
821 821
     public function render_form_buttons() {
822
-        return gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/form-buttons.php', $this );
822
+        return gravityview_ob_include( GravityView_Edit_Entry::$file . '/partials/form-buttons.php', $this );
823 823
     }
824 824
 
825 825
 
@@ -839,17 +839,17 @@  discard block
 block discarded – undo
839 839
     public function filter_modify_form_fields( $form, $ajax = false, $field_values = '' ) {
840 840
 
841 841
         // In case we have validated the form, use it to inject the validation results into the form render
842
-        if( isset( $this->form_after_validation ) ) {
842
+        if ( isset( $this->form_after_validation ) ) {
843 843
             $form = $this->form_after_validation;
844 844
         } else {
845
-            $form['fields'] = $this->get_configured_edit_fields( $form, $this->view_id );
845
+            $form[ 'fields' ] = $this->get_configured_edit_fields( $form, $this->view_id );
846 846
         }
847 847
 
848 848
         $form = $this->filter_conditional_logic( $form );
849 849
 
850 850
         // for now we don't support Save and Continue feature.
851
-        if( ! self::$supports_save_and_continue ) {
852
-	        unset( $form['save'] );
851
+        if ( ! self::$supports_save_and_continue ) {
852
+	        unset( $form[ 'save' ] );
853 853
         }
854 854
 
855 855
         return $form;
@@ -870,29 +870,29 @@  discard block
 block discarded – undo
870 870
      */
871 871
     function verify_user_can_edit_post( $field_content = '', $field, $value, $lead_id = 0, $form_id ) {
872 872
 
873
-        if( GFCommon::is_post_field( $field ) ) {
873
+        if ( GFCommon::is_post_field( $field ) ) {
874 874
 
875 875
             $message = null;
876 876
 
877 877
             // First, make sure they have the capability to edit the post.
878
-            if( false === current_user_can( 'edit_post', $this->entry['post_id'] ) ) {
878
+            if ( false === current_user_can( 'edit_post', $this->entry[ 'post_id' ] ) ) {
879 879
 
880 880
                 /**
881 881
                  * @filter `gravityview/edit_entry/unsupported_post_field_text` Modify the message when someone isn't able to edit a post
882 882
                  * @param string $message The existing "You don't have permission..." text
883 883
                  */
884
-                $message = apply_filters('gravityview/edit_entry/unsupported_post_field_text', __('You don&rsquo;t have permission to edit this post.', 'gravityview') );
884
+                $message = apply_filters( 'gravityview/edit_entry/unsupported_post_field_text', __( 'You don&rsquo;t have permission to edit this post.', 'gravityview' ) );
885 885
 
886
-            } elseif( null === get_post( $this->entry['post_id'] ) ) {
886
+            } elseif ( null === get_post( $this->entry[ 'post_id' ] ) ) {
887 887
                 /**
888 888
                  * @filter `gravityview/edit_entry/no_post_text` Modify the message when someone is editing an entry attached to a post that no longer exists
889 889
                  * @param string $message The existing "This field is not editable; the post no longer exists." text
890 890
                  */
891
-                $message = apply_filters('gravityview/edit_entry/no_post_text', __('This field is not editable; the post no longer exists.', 'gravityview' ) );
891
+                $message = apply_filters( 'gravityview/edit_entry/no_post_text', __( 'This field is not editable; the post no longer exists.', 'gravityview' ) );
892 892
             }
893 893
 
894
-            if( $message ) {
895
-                $field_content = sprintf('<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
894
+            if ( $message ) {
895
+                $field_content = sprintf( '<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
896 896
             }
897 897
         }
898 898
 
@@ -917,8 +917,8 @@  discard block
 block discarded – undo
917 917
 
918 918
         // If the form has been submitted, then we don't need to pre-fill the values,
919 919
         // Except for fileupload type and when a field input is overridden- run always!!
920
-        if(
921
-            ( $this->is_edit_entry_submission() && !in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
920
+        if (
921
+            ( $this->is_edit_entry_submission() && ! in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
922 922
             && false === ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) )
923 923
             || ! empty( $field_content )
924 924
             || GFCommon::is_product_field( $field->type ) // Prevent product fields from appearing editable
@@ -927,8 +927,8 @@  discard block
 block discarded – undo
927 927
         }
928 928
 
929 929
         // Turn on Admin-style display for file upload fields only
930
-        if( 'fileupload' === $field->type ) {
931
-            $_GET['page'] = 'gf_entries';
930
+        if ( 'fileupload' === $field->type ) {
931
+            $_GET[ 'page' ] = 'gf_entries';
932 932
         }
933 933
 
934 934
         // SET SOME FIELD DEFAULTS TO PREVENT ISSUES
@@ -952,7 +952,7 @@  discard block
 block discarded – undo
952 952
 	    // Prevent any PHP warnings, like undefined index
953 953
 	    ob_start();
954 954
 
955
-        if( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
955
+        if ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
956 956
             $return = $gv_field->get_field_input( $this->form, $field_value, $this->entry, $field );
957 957
         } else {
958 958
 	        $return = $field->get_field_input( $this->form, $field_value, $this->entry );
@@ -962,7 +962,7 @@  discard block
 block discarded – undo
962 962
 	    // If there was output, it's an error
963 963
 	    $warnings = ob_get_clean();
964 964
 
965
-	    if( !empty( $warnings ) ) {
965
+	    if ( ! empty( $warnings ) ) {
966 966
 		    do_action( 'gravityview_log_error', __METHOD__ . $warnings, $field_value );
967 967
 	    }
968 968
 
@@ -971,7 +971,7 @@  discard block
 block discarded – undo
971 971
          * We need the fileupload html field to render with the proper id
972 972
          *  ( <li id="field_80_16" ... > )
973 973
          */
974
-        unset( $_GET['page'] );
974
+        unset( $_GET[ 'page' ] );
975 975
 
976 976
         return $return;
977 977
     }
@@ -994,7 +994,7 @@  discard block
 block discarded – undo
994 994
         $override_saved_value = apply_filters( 'gravityview/edit_entry/pre_populate/override', false, $field );
995 995
 
996 996
         // We're dealing with multiple inputs (e.g. checkbox) but not time or date (as it doesn't store data in input IDs)
997
-        if( isset( $field->inputs ) && is_array( $field->inputs ) && !in_array( $field->type, array( 'time', 'date' ) ) ) {
997
+        if ( isset( $field->inputs ) && is_array( $field->inputs ) && ! in_array( $field->type, array( 'time', 'date' ) ) ) {
998 998
 
999 999
             $field_value = array();
1000 1000
 
@@ -1003,10 +1003,10 @@  discard block
 block discarded – undo
1003 1003
 
1004 1004
             foreach ( (array)$field->inputs as $input ) {
1005 1005
 
1006
-                $input_id = strval( $input['id'] );
1006
+                $input_id = strval( $input[ 'id' ] );
1007 1007
                 
1008 1008
                 if ( isset( $this->entry[ $input_id ] ) && ! gv_empty( $this->entry[ $input_id ], false, false ) ) {
1009
-                    $field_value[ $input_id ] =  'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1009
+                    $field_value[ $input_id ] = 'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1010 1010
                     $allow_pre_populated = false;
1011 1011
                 }
1012 1012
 
@@ -1014,7 +1014,7 @@  discard block
 block discarded – undo
1014 1014
 
1015 1015
             $pre_value = $field->get_value_submission( array(), false );
1016 1016
 
1017
-            $field_value = ! $allow_pre_populated && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
1017
+            $field_value = ! $allow_pre_populated && ! ( $override_saved_value && ! gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
1018 1018
 
1019 1019
         } else {
1020 1020
 
@@ -1025,13 +1025,13 @@  discard block
 block discarded – undo
1025 1025
 
1026 1026
             // saved field entry value (if empty, fallback to the pre-populated value, if exists)
1027 1027
             // or pre-populated value if not empty and set to override saved value
1028
-            $field_value = !gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
1028
+            $field_value = ! gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && ! gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
1029 1029
 
1030 1030
             // in case field is post_category but inputType is select, multi-select or radio, convert value into array of category IDs.
1031
-            if ( 'post_category' === $field->type && !gv_empty( $field_value, false, false ) ) {
1031
+            if ( 'post_category' === $field->type && ! gv_empty( $field_value, false, false ) ) {
1032 1032
                 $categories = array();
1033 1033
                 foreach ( explode( ',', $field_value ) as $cat_string ) {
1034
-                    $categories[] = GFCommon::format_post_category( $cat_string, true );
1034
+                    $categories[ ] = GFCommon::format_post_category( $cat_string, true );
1035 1035
                 }
1036 1036
                 $field_value = 'multiselect' === $field->get_input_type() ? $categories : implode( '', $categories );
1037 1037
             }
@@ -1056,12 +1056,12 @@  discard block
 block discarded – undo
1056 1056
      */
1057 1057
     function gform_pre_validation( $form ) {
1058 1058
 
1059
-        if( ! $this->verify_nonce() ) {
1059
+        if ( ! $this->verify_nonce() ) {
1060 1060
             return $form;
1061 1061
         }
1062 1062
 
1063 1063
         // Fix PHP warning regarding undefined index.
1064
-        foreach ( $form['fields'] as &$field) {
1064
+        foreach ( $form[ 'fields' ] as &$field ) {
1065 1065
 
1066 1066
             // This is because we're doing admin form pretending to be front-end, so Gravity Forms
1067 1067
             // expects certain field array items to be set.
@@ -1074,7 +1074,7 @@  discard block
 block discarded – undo
1074 1074
                 $field['emailConfirmEnabled'] = '';
1075 1075
             }*/
1076 1076
 
1077
-            switch( RGFormsModel::get_input_type( $field ) ) {
1077
+            switch ( RGFormsModel::get_input_type( $field ) ) {
1078 1078
 
1079 1079
                 /**
1080 1080
                  * this whole fileupload hack is because in the admin, Gravity Forms simply doesn't update any fileupload field if it's empty, but it DOES in the frontend.
@@ -1088,37 +1088,37 @@  discard block
 block discarded – undo
1088 1088
                     // Set the previous value
1089 1089
                     $entry = $this->get_entry();
1090 1090
 
1091
-                    $input_name = 'input_'.$field->id;
1092
-                    $form_id = $form['id'];
1091
+                    $input_name = 'input_' . $field->id;
1092
+                    $form_id = $form[ 'id' ];
1093 1093
 
1094 1094
                     $value = NULL;
1095 1095
 
1096 1096
                     // Use the previous entry value as the default.
1097
-                    if( isset( $entry[ $field->id ] ) ) {
1097
+                    if ( isset( $entry[ $field->id ] ) ) {
1098 1098
                         $value = $entry[ $field->id ];
1099 1099
                     }
1100 1100
 
1101 1101
                     // If this is a single upload file
1102
-                    if( !empty( $_FILES[ $input_name ] ) && !empty( $_FILES[ $input_name ]['name'] ) ) {
1103
-                        $file_path = GFFormsModel::get_file_upload_path( $form['id'], $_FILES[ $input_name ]['name'] );
1104
-                        $value = $file_path['url'];
1102
+                    if ( ! empty( $_FILES[ $input_name ] ) && ! empty( $_FILES[ $input_name ][ 'name' ] ) ) {
1103
+                        $file_path = GFFormsModel::get_file_upload_path( $form[ 'id' ], $_FILES[ $input_name ][ 'name' ] );
1104
+                        $value = $file_path[ 'url' ];
1105 1105
 
1106 1106
                     } else {
1107 1107
 
1108 1108
                         // Fix PHP warning on line 1498 of form_display.php for post_image fields
1109 1109
                         // Fix PHP Notice:  Undefined index:  size in form_display.php on line 1511
1110
-                        $_FILES[ $input_name ] = array('name' => '', 'size' => '' );
1110
+                        $_FILES[ $input_name ] = array( 'name' => '', 'size' => '' );
1111 1111
 
1112 1112
                     }
1113 1113
 
1114
-                    if( rgar($field, "multipleFiles") ) {
1114
+                    if ( rgar( $field, "multipleFiles" ) ) {
1115 1115
 
1116 1116
                         // If there are fresh uploads, process and merge them.
1117 1117
                         // Otherwise, use the passed values, which should be json-encoded array of URLs
1118
-                        if( isset( GFFormsModel::$uploaded_files[$form_id][$input_name] ) ) {
1118
+                        if ( isset( GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] ) ) {
1119 1119
                             $value = empty( $value ) ? '[]' : $value;
1120 1120
                             $value = stripslashes_deep( $value );
1121
-                            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], array());
1121
+                            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry[ 'id' ], array() );
1122 1122
                         }
1123 1123
 
1124 1124
                     } else {
@@ -1136,14 +1136,14 @@  discard block
 block discarded – undo
1136 1136
 
1137 1137
                 case 'number':
1138 1138
                     // Fix "undefined index" issue at line 1286 in form_display.php
1139
-                    if( !isset( $_POST['input_'.$field->id ] ) ) {
1140
-                        $_POST['input_'.$field->id ] = NULL;
1139
+                    if ( ! isset( $_POST[ 'input_' . $field->id ] ) ) {
1140
+                        $_POST[ 'input_' . $field->id ] = NULL;
1141 1141
                     }
1142 1142
                     break;
1143 1143
                 case 'captcha':
1144 1144
                     // Fix issue with recaptcha_check_answer() on line 1458 in form_display.php
1145
-                    $_POST['recaptcha_challenge_field'] = NULL;
1146
-                    $_POST['recaptcha_response_field'] = NULL;
1145
+                    $_POST[ 'recaptcha_challenge_field' ] = NULL;
1146
+                    $_POST[ 'recaptcha_response_field' ] = NULL;
1147 1147
                     break;
1148 1148
             }
1149 1149
 
@@ -1179,7 +1179,7 @@  discard block
 block discarded – undo
1179 1179
          * You can enter whatever you want!
1180 1180
          * We try validating, and customize the results using `self::custom_validation()`
1181 1181
          */
1182
-        add_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10, 4);
1182
+        add_filter( 'gform_validation_' . $this->form_id, array( $this, 'custom_validation' ), 10, 4 );
1183 1183
 
1184 1184
         // Needed by the validate funtion
1185 1185
         $failed_validation_page = NULL;
@@ -1187,14 +1187,14 @@  discard block
 block discarded – undo
1187 1187
 
1188 1188
         // Prevent entry limit from running when editing an entry, also
1189 1189
         // prevent form scheduling from preventing editing
1190
-        unset( $this->form['limitEntries'], $this->form['scheduleForm'] );
1190
+        unset( $this->form[ 'limitEntries' ], $this->form[ 'scheduleForm' ] );
1191 1191
 
1192 1192
         // Hide fields depending on Edit Entry settings
1193
-        $this->form['fields'] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1193
+        $this->form[ 'fields' ] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1194 1194
 
1195 1195
         $this->is_valid = GFFormDisplay::validate( $this->form, $field_values, 1, $failed_validation_page );
1196 1196
 
1197
-        remove_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10 );
1197
+        remove_filter( 'gform_validation_' . $this->form_id, array( $this, 'custom_validation' ), 10 );
1198 1198
     }
1199 1199
 
1200 1200
 
@@ -1211,13 +1211,13 @@  discard block
 block discarded – undo
1211 1211
      */
1212 1212
     function custom_validation( $validation_results ) {
1213 1213
 
1214
-        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Validation results: ', $validation_results );
1214
+        do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Validation results: ', $validation_results );
1215 1215
 
1216
-        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
1216
+        do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] $_POSTed data (sanitized): ', esc_html( print_r( $_POST, true ) ) );
1217 1217
 
1218 1218
         $gv_valid = true;
1219 1219
 
1220
-        foreach ( $validation_results['form']['fields'] as $key => &$field ) {
1220
+        foreach ( $validation_results[ 'form' ][ 'fields' ] as $key => &$field ) {
1221 1221
 
1222 1222
             $value = RGFormsModel::get_field_value( $field );
1223 1223
             $field_type = RGFormsModel::get_input_type( $field );
@@ -1230,35 +1230,35 @@  discard block
 block discarded – undo
1230 1230
                 case 'post_image':
1231 1231
 
1232 1232
                     // in case nothing is uploaded but there are already files saved
1233
-                    if( !empty( $field->failed_validation ) && !empty( $field->isRequired ) && !empty( $value ) ) {
1233
+                    if ( ! empty( $field->failed_validation ) && ! empty( $field->isRequired ) && ! empty( $value ) ) {
1234 1234
                         $field->failed_validation = false;
1235 1235
                         unset( $field->validation_message );
1236 1236
                     }
1237 1237
 
1238 1238
                     // validate if multi file upload reached max number of files [maxFiles] => 2
1239
-                    if( rgobj( $field, 'maxFiles') && rgobj( $field, 'multipleFiles') ) {
1239
+                    if ( rgobj( $field, 'maxFiles' ) && rgobj( $field, 'multipleFiles' ) ) {
1240 1240
 
1241 1241
                         $input_name = 'input_' . $field->id;
1242 1242
                         //uploaded
1243
-                        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] : array();
1243
+                        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ][ $input_name ] : array();
1244 1244
 
1245 1245
                         //existent
1246 1246
                         $entry = $this->get_entry();
1247 1247
                         $value = NULL;
1248
-                        if( isset( $entry[ $field->id ] ) ) {
1248
+                        if ( isset( $entry[ $field->id ] ) ) {
1249 1249
                             $value = json_decode( $entry[ $field->id ], true );
1250 1250
                         }
1251 1251
 
1252 1252
                         // count uploaded files and existent entry files
1253 1253
                         $count_files = count( $file_names ) + count( $value );
1254 1254
 
1255
-                        if( $count_files > $field->maxFiles ) {
1255
+                        if ( $count_files > $field->maxFiles ) {
1256 1256
                             $field->validation_message = __( 'Maximum number of files reached', 'gravityview' );
1257 1257
                             $field->failed_validation = 1;
1258 1258
                             $gv_valid = false;
1259 1259
 
1260 1260
                             // in case of error make sure the newest upload files are removed from the upload input
1261
-                            GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ] = null;
1261
+                            GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ] = null;
1262 1262
                         }
1263 1263
 
1264 1264
                     }
@@ -1269,7 +1269,7 @@  discard block
 block discarded – undo
1269 1269
             }
1270 1270
 
1271 1271
             // This field has failed validation.
1272
-            if( !empty( $field->failed_validation ) ) {
1272
+            if ( ! empty( $field->failed_validation ) ) {
1273 1273
 
1274 1274
                 do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Field is invalid.', array( 'field' => $field, 'value' => $value ) );
1275 1275
 
@@ -1287,32 +1287,32 @@  discard block
 block discarded – undo
1287 1287
                 }
1288 1288
 
1289 1289
                 // You can't continue inside a switch, so we do it after.
1290
-                if( empty( $field->failed_validation ) ) {
1290
+                if ( empty( $field->failed_validation ) ) {
1291 1291
                     continue;
1292 1292
                 }
1293 1293
 
1294 1294
                 // checks if the No Duplicates option is not validating entry against itself, since
1295 1295
                 // we're editing a stored entry, it would also assume it's a duplicate.
1296
-                if( !empty( $field->noDuplicates ) ) {
1296
+                if ( ! empty( $field->noDuplicates ) ) {
1297 1297
 
1298 1298
                     $entry = $this->get_entry();
1299 1299
 
1300 1300
                     // If the value of the entry is the same as the stored value
1301 1301
                     // Then we can assume it's not a duplicate, it's the same.
1302
-                    if( !empty( $entry ) && $value == $entry[ $field->id ] ) {
1302
+                    if ( ! empty( $entry ) && $value == $entry[ $field->id ] ) {
1303 1303
                         //if value submitted was not changed, then don't validate
1304 1304
                         $field->failed_validation = false;
1305 1305
 
1306 1306
                         unset( $field->validation_message );
1307 1307
 
1308
-                        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Field not a duplicate; it is the same entry.', $entry );
1308
+                        do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Field not a duplicate; it is the same entry.', $entry );
1309 1309
 
1310 1310
                         continue;
1311 1311
                     }
1312 1312
                 }
1313 1313
 
1314 1314
                 // if here then probably we are facing the validation 'At least one field must be filled out'
1315
-                if( GFFormDisplay::is_empty( $field, $this->form_id  ) && empty( $field->isRequired ) ) {
1315
+                if ( GFFormDisplay::is_empty( $field, $this->form_id ) && empty( $field->isRequired ) ) {
1316 1316
                     unset( $field->validation_message );
1317 1317
 	                $field->validation_message = false;
1318 1318
                     continue;
@@ -1324,12 +1324,12 @@  discard block
 block discarded – undo
1324 1324
 
1325 1325
         }
1326 1326
 
1327
-        $validation_results['is_valid'] = $gv_valid;
1327
+        $validation_results[ 'is_valid' ] = $gv_valid;
1328 1328
 
1329
-        do_action('gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Validation results.', $validation_results );
1329
+        do_action( 'gravityview_log_debug', 'GravityView_Edit_Entry[custom_validation] Validation results.', $validation_results );
1330 1330
 
1331 1331
         // We'll need this result when rendering the form ( on GFFormDisplay::get_form )
1332
-        $this->form_after_validation = $validation_results['form'];
1332
+        $this->form_after_validation = $validation_results[ 'form' ];
1333 1333
 
1334 1334
         return $validation_results;
1335 1335
     }
@@ -1342,7 +1342,7 @@  discard block
 block discarded – undo
1342 1342
      */
1343 1343
     private function get_entry() {
1344 1344
 
1345
-        if( empty( $this->entry ) ) {
1345
+        if ( empty( $this->entry ) ) {
1346 1346
             // Get the database value of the entry that's being edited
1347 1347
             $this->entry = gravityview_get_entry( GravityView_frontend::is_single_entry() );
1348 1348
         }
@@ -1369,13 +1369,13 @@  discard block
 block discarded – undo
1369 1369
         $properties = GravityView_View_Data::getInstance()->get_fields( $view_id );
1370 1370
 
1371 1371
         // If edit tab not yet configured, show all fields
1372
-        $edit_fields = !empty( $properties['edit_edit-fields'] ) ? $properties['edit_edit-fields'] : NULL;
1372
+        $edit_fields = ! empty( $properties[ 'edit_edit-fields' ] ) ? $properties[ 'edit_edit-fields' ] : NULL;
1373 1373
 
1374 1374
 	    // Show hidden fields as text fields
1375 1375
 	    $form = $this->fix_hidden_fields( $form );
1376 1376
 
1377 1377
         // Hide fields depending on admin settings
1378
-        $fields = $this->filter_fields( $form['fields'], $edit_fields );
1378
+        $fields = $this->filter_fields( $form[ 'fields' ], $edit_fields );
1379 1379
 
1380 1380
 	    // If Edit Entry fields are configured, remove adminOnly field settings. Otherwise, don't.
1381 1381
 	    $fields = $this->filter_admin_only_fields( $fields, $edit_fields, $form, $view_id );
@@ -1393,11 +1393,11 @@  discard block
 block discarded – undo
1393 1393
 	private function fix_hidden_fields( $form ) {
1394 1394
 
1395 1395
 		/** @var GF_Field $field */
1396
-		foreach( $form['fields'] as $key => $field ) {
1397
-			if( 'hidden' === $field->type ) {
1396
+		foreach ( $form[ 'fields' ] as $key => $field ) {
1397
+			if ( 'hidden' === $field->type ) {
1398 1398
 				$text_field = new GF_Field_Text( $field );
1399 1399
 				$text_field->type = 'text';
1400
-				$form['fields'][ $key ] = $text_field;
1400
+				$form[ 'fields' ][ $key ] = $text_field;
1401 1401
 			}
1402 1402
 		}
1403 1403
 
@@ -1418,7 +1418,7 @@  discard block
 block discarded – undo
1418 1418
      */
1419 1419
     private function filter_fields( $fields, $configured_fields ) {
1420 1420
 
1421
-        if( empty( $fields ) || !is_array( $fields ) ) {
1421
+        if ( empty( $fields ) || ! is_array( $fields ) ) {
1422 1422
             return $fields;
1423 1423
         }
1424 1424
 
@@ -1435,13 +1435,13 @@  discard block
 block discarded – undo
1435 1435
 	     */
1436 1436
 	    $hide_product_fields = apply_filters( 'gravityview/edit_entry/hide-product-fields', empty( self::$supports_product_fields ) );
1437 1437
 
1438
-	    if( $hide_product_fields ) {
1439
-		    $field_type_blacklist[] = 'option';
1440
-		    $field_type_blacklist[] = 'quantity';
1441
-            $field_type_blacklist[] = 'product';
1442
-            $field_type_blacklist[] = 'total';
1443
-            $field_type_blacklist[] = 'shipping';
1444
-            $field_type_blacklist[] = 'calculation';
1438
+	    if ( $hide_product_fields ) {
1439
+		    $field_type_blacklist[ ] = 'option';
1440
+		    $field_type_blacklist[ ] = 'quantity';
1441
+            $field_type_blacklist[ ] = 'product';
1442
+            $field_type_blacklist[ ] = 'total';
1443
+            $field_type_blacklist[ ] = 'shipping';
1444
+            $field_type_blacklist[ ] = 'calculation';
1445 1445
 	    }
1446 1446
 
1447 1447
         // First, remove blacklist or calculation fields
@@ -1449,24 +1449,24 @@  discard block
 block discarded – undo
1449 1449
 
1450 1450
             // Remove the fields that have calculation properties and keep them to be used later
1451 1451
             // @since 1.16.2
1452
-            if( $field->has_calculation() ) {
1453
-                $this->fields_with_calculation[] = $field;
1452
+            if ( $field->has_calculation() ) {
1453
+                $this->fields_with_calculation[ ] = $field;
1454 1454
                 unset( $fields[ $key ] );
1455 1455
             }
1456 1456
 
1457 1457
             // process total field after all fields have been saved
1458 1458
             if ( $field->type == 'total' ) {
1459
-                $this->total_fields[] = $field;
1459
+                $this->total_fields[ ] = $field;
1460 1460
                 unset( $fields[ $key ] );
1461 1461
             }
1462 1462
 
1463
-            if( in_array( $field->type, $field_type_blacklist ) ) {
1463
+            if ( in_array( $field->type, $field_type_blacklist ) ) {
1464 1464
                 unset( $fields[ $key ] );
1465 1465
             }
1466 1466
         }
1467 1467
 
1468 1468
         // The Edit tab has not been configured, so we return all fields by default.
1469
-        if( empty( $configured_fields ) ) {
1469
+        if ( empty( $configured_fields ) ) {
1470 1470
             return $fields;
1471 1471
         }
1472 1472
 
@@ -1476,8 +1476,8 @@  discard block
 block discarded – undo
1476 1476
 	        /** @var GF_Field $field */
1477 1477
 	        foreach ( $fields as $field ) {
1478 1478
 
1479
-                if( intval( $configured_field['id'] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1480
-                    $edit_fields[] = $this->merge_field_properties( $field, $configured_field );
1479
+                if ( intval( $configured_field[ 'id' ] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1480
+                    $edit_fields[ ] = $this->merge_field_properties( $field, $configured_field );
1481 1481
                     break;
1482 1482
                 }
1483 1483
 
@@ -1500,14 +1500,14 @@  discard block
 block discarded – undo
1500 1500
 
1501 1501
         $return_field = $field;
1502 1502
 
1503
-        if( empty( $field_setting['show_label'] ) ) {
1503
+        if ( empty( $field_setting[ 'show_label' ] ) ) {
1504 1504
             $return_field->label = '';
1505
-        } elseif ( !empty( $field_setting['custom_label'] ) ) {
1506
-            $return_field->label = $field_setting['custom_label'];
1505
+        } elseif ( ! empty( $field_setting[ 'custom_label' ] ) ) {
1506
+            $return_field->label = $field_setting[ 'custom_label' ];
1507 1507
         }
1508 1508
 
1509
-        if( !empty( $field_setting['custom_class'] ) ) {
1510
-            $return_field->cssClass .= ' '. gravityview_sanitize_html_class( $field_setting['custom_class'] );
1509
+        if ( ! empty( $field_setting[ 'custom_class' ] ) ) {
1510
+            $return_field->cssClass .= ' ' . gravityview_sanitize_html_class( $field_setting[ 'custom_class' ] );
1511 1511
         }
1512 1512
 
1513 1513
         /**
@@ -1545,16 +1545,16 @@  discard block
 block discarded – undo
1545 1545
 	     */
1546 1546
 	    $use_gf_adminonly_setting = apply_filters( 'gravityview/edit_entry/use_gf_admin_only_setting', empty( $edit_fields ), $form, $view_id );
1547 1547
 
1548
-	    if( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry['id'] ) ) {
1549
-            foreach( $fields as $k => $field ) {
1550
-                if( $field->adminOnly ) {
1548
+	    if ( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry[ 'id' ] ) ) {
1549
+            foreach ( $fields as $k => $field ) {
1550
+                if ( $field->adminOnly ) {
1551 1551
                     unset( $fields[ $k ] );
1552 1552
                 }
1553 1553
             }
1554 1554
             return $fields;
1555 1555
         }
1556 1556
 
1557
-	    foreach( $fields as &$field ) {
1557
+	    foreach ( $fields as &$field ) {
1558 1558
 		    $field->adminOnly = false;
1559 1559
         }
1560 1560
 
@@ -1581,16 +1581,16 @@  discard block
 block discarded – undo
1581 1581
          */
1582 1582
         $use_conditional_logic = apply_filters( 'gravityview/edit_entry/conditional_logic', true, $form );
1583 1583
 
1584
-        if( $use_conditional_logic ) {
1584
+        if ( $use_conditional_logic ) {
1585 1585
             return $form;
1586 1586
         }
1587 1587
 
1588
-        foreach( $form['fields'] as &$field ) {
1588
+        foreach ( $form[ 'fields' ] as &$field ) {
1589 1589
             /* @var GF_Field $field */
1590 1590
             $field->conditionalLogic = null;
1591 1591
         }
1592 1592
 
1593
-        unset( $form['button']['conditionalLogic'] );
1593
+        unset( $form[ 'button' ][ 'conditionalLogic' ] );
1594 1594
 
1595 1595
         return $form;
1596 1596
 
@@ -1607,7 +1607,7 @@  discard block
 block discarded – undo
1607 1607
      */
1608 1608
     function manage_conditional_logic( $has_conditional_logic, $form ) {
1609 1609
 
1610
-        if( ! $this->is_edit_entry() ) {
1610
+        if ( ! $this->is_edit_entry() ) {
1611 1611
             return $has_conditional_logic;
1612 1612
         }
1613 1613
 
@@ -1638,44 +1638,44 @@  discard block
 block discarded – undo
1638 1638
          *  2. There are two entries embedded using oEmbed
1639 1639
          *  3. One of the entries has just been saved
1640 1640
          */
1641
-        if( !empty( $_POST['lid'] ) && !empty( $_GET['entry'] ) && ( $_POST['lid'] !== $_GET['entry'] ) ) {
1641
+        if ( ! empty( $_POST[ 'lid' ] ) && ! empty( $_GET[ 'entry' ] ) && ( $_POST[ 'lid' ] !== $_GET[ 'entry' ] ) ) {
1642 1642
 
1643 1643
             $error = true;
1644 1644
 
1645 1645
         }
1646 1646
 
1647
-        if( !empty( $_GET['entry'] ) && (string)$this->entry['id'] !== $_GET['entry'] ) {
1647
+        if ( ! empty( $_GET[ 'entry' ] ) && (string)$this->entry[ 'id' ] !== $_GET[ 'entry' ] ) {
1648 1648
 
1649 1649
             $error = true;
1650 1650
 
1651
-        } elseif( ! $this->verify_nonce() ) {
1651
+        } elseif ( ! $this->verify_nonce() ) {
1652 1652
 
1653 1653
             /**
1654 1654
              * If the Entry is embedded, there may be two entries on the same page.
1655 1655
              * If that's the case, and one is being edited, the other should fail gracefully and not display an error.
1656 1656
              */
1657
-            if( GravityView_oEmbed::getInstance()->get_entry_id() ) {
1657
+            if ( GravityView_oEmbed::getInstance()->get_entry_id() ) {
1658 1658
                 $error = true;
1659 1659
             } else {
1660
-                $error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview');
1660
+                $error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview' );
1661 1661
             }
1662 1662
 
1663 1663
         }
1664 1664
 
1665
-        if( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
1666
-            $error = __( 'You do not have permission to edit this entry.', 'gravityview');
1665
+        if ( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
1666
+            $error = __( 'You do not have permission to edit this entry.', 'gravityview' );
1667 1667
         }
1668 1668
 
1669
-        if( $this->entry['status'] === 'trash' ) {
1670
-            $error = __('You cannot edit the entry; it is in the trash.', 'gravityview' );
1669
+        if ( $this->entry[ 'status' ] === 'trash' ) {
1670
+            $error = __( 'You cannot edit the entry; it is in the trash.', 'gravityview' );
1671 1671
         }
1672 1672
 
1673 1673
         // No errors; everything's fine here!
1674
-        if( empty( $error ) ) {
1674
+        if ( empty( $error ) ) {
1675 1675
             return true;
1676 1676
         }
1677 1677
 
1678
-        if( $echo && $error !== true ) {
1678
+        if ( $echo && $error !== true ) {
1679 1679
 
1680 1680
 	        $error = esc_html( $error );
1681 1681
 
@@ -1683,13 +1683,13 @@  discard block
 block discarded – undo
1683 1683
 	         * @since 1.9
1684 1684
 	         */
1685 1685
 	        if ( ! empty( $this->entry ) ) {
1686
-		        $error .= ' ' . gravityview_get_link( '#', _x('Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
1686
+		        $error .= ' ' . gravityview_get_link( '#', _x( 'Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
1687 1687
 	        }
1688 1688
 
1689
-            echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error');
1689
+            echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error' );
1690 1690
         }
1691 1691
 
1692
-        do_action('gravityview_log_error', 'GravityView_Edit_Entry[user_can_edit_entry]' . $error );
1692
+        do_action( 'gravityview_log_error', 'GravityView_Edit_Entry[user_can_edit_entry]' . $error );
1693 1693
 
1694 1694
         return false;
1695 1695
     }
@@ -1706,20 +1706,20 @@  discard block
 block discarded – undo
1706 1706
 
1707 1707
         $error = NULL;
1708 1708
 
1709
-        if( ! $this->check_user_cap_edit_field( $field ) ) {
1710
-            $error = __( 'You do not have permission to edit this field.', 'gravityview');
1709
+        if ( ! $this->check_user_cap_edit_field( $field ) ) {
1710
+            $error = __( 'You do not have permission to edit this field.', 'gravityview' );
1711 1711
         }
1712 1712
 
1713 1713
         // No errors; everything's fine here!
1714
-        if( empty( $error ) ) {
1714
+        if ( empty( $error ) ) {
1715 1715
             return true;
1716 1716
         }
1717 1717
 
1718
-        if( $echo ) {
1719
-            echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error');
1718
+        if ( $echo ) {
1719
+            echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error' );
1720 1720
         }
1721 1721
 
1722
-        do_action('gravityview_log_error', 'GravityView_Edit_Entry[user_can_edit_field]' . $error );
1722
+        do_action( 'gravityview_log_error', 'GravityView_Edit_Entry[user_can_edit_field]' . $error );
1723 1723
 
1724 1724
         return false;
1725 1725
 
@@ -1737,15 +1737,15 @@  discard block
 block discarded – undo
1737 1737
     private function check_user_cap_edit_field( $field ) {
1738 1738
 
1739 1739
         // If they can edit any entries (as defined in Gravity Forms), we're good.
1740
-        if( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
1740
+        if ( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
1741 1741
             return true;
1742 1742
         }
1743 1743
 
1744
-        $field_cap = isset( $field['allow_edit_cap'] ) ? $field['allow_edit_cap'] : false;
1744
+        $field_cap = isset( $field[ 'allow_edit_cap' ] ) ? $field[ 'allow_edit_cap' ] : false;
1745 1745
 
1746 1746
         // If the field has custom editing capaibilities set, check those
1747
-        if( $field_cap ) {
1748
-            return GVCommon::has_cap( $field['allow_edit_cap'] );
1747
+        if ( $field_cap ) {
1748
+            return GVCommon::has_cap( $field[ 'allow_edit_cap' ] );
1749 1749
         }
1750 1750
 
1751 1751
         return false;
@@ -1759,17 +1759,17 @@  discard block
 block discarded – undo
1759 1759
     public function verify_nonce() {
1760 1760
 
1761 1761
         // Verify form submitted for editing single
1762
-        if( $this->is_edit_entry_submission() ) {
1762
+        if ( $this->is_edit_entry_submission() ) {
1763 1763
             $valid = wp_verify_nonce( $_POST[ self::$nonce_field ], self::$nonce_field );
1764 1764
         }
1765 1765
 
1766 1766
         // Verify
1767
-        else if( ! $this->is_edit_entry() ) {
1767
+        else if ( ! $this->is_edit_entry() ) {
1768 1768
             $valid = false;
1769 1769
         }
1770 1770
 
1771 1771
         else {
1772
-            $valid = wp_verify_nonce( $_GET['edit'], self::$nonce_key );
1772
+            $valid = wp_verify_nonce( $_GET[ 'edit' ], self::$nonce_key );
1773 1773
         }
1774 1774
 
1775 1775
         /**
Please login to merge, or discard this patch.
includes/extensions/edit-entry/partials/form-buttons.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 
30 30
 	$labels = array(
31 31
 		'cancel' => __( 'Cancel', 'gravityview' ),
32
-		'submit' => __( 'Update', 'gravityview')
32
+		'submit' => __( 'Update', 'gravityview' )
33 33
 	);
34 34
 
35 35
 	/**
@@ -43,9 +43,9 @@  discard block
 block discarded – undo
43 43
 	$labels = apply_filters( 'gravityview/edit_entry/button_labels', $labels, $object->form, $object->entry, $object->view_id );
44 44
 
45 45
 	?>
46
-	<input id="gform_submit_button_<?php echo esc_attr( $object->form['id'] ); ?>" class="btn btn-lg button button-large gform_button button-primary gv-button-update" type="submit" tabindex="4" value="<?php echo esc_attr( $labels['submit'] ); ?>" name="save" />
46
+	<input id="gform_submit_button_<?php echo esc_attr( $object->form[ 'id' ] ); ?>" class="btn btn-lg button button-large gform_button button-primary gv-button-update" type="submit" tabindex="4" value="<?php echo esc_attr( $labels[ 'submit' ] ); ?>" name="save" />
47 47
 
48
-	<a class="btn btn-sm button button-small gv-button-cancel" tabindex="5" href="<?php echo esc_url( $back_link ); ?>"><?php echo esc_attr( $labels['cancel'] ); ?></a>
48
+	<a class="btn btn-sm button button-small gv-button-cancel" tabindex="5" href="<?php echo esc_url( $back_link ); ?>"><?php echo esc_attr( $labels[ 'cancel' ] ); ?></a>
49 49
 	<?php
50 50
 
51 51
 	/**
@@ -59,5 +59,5 @@  discard block
 block discarded – undo
59 59
 
60 60
 	?>
61 61
 	<input type="hidden" name="action" value="update" />
62
-	<input type="hidden" name="lid" value="<?php echo esc_attr( $object->entry['id'] ); ?>" />
62
+	<input type="hidden" name="lid" value="<?php echo esc_attr( $object->entry[ 'id' ] ); ?>" />
63 63
 </div>
Please login to merge, or discard this patch.
includes/class-api.php 1 patch
Spacing   +146 added lines, -146 removed lines patch added patch discarded remove patch
@@ -30,29 +30,29 @@  discard block
 block discarded – undo
30 30
 
31 31
 		$label = '';
32 32
 
33
-		if( !empty( $field['show_label'] ) || $force_show_label ) {
33
+		if ( ! empty( $field[ 'show_label' ] ) || $force_show_label ) {
34 34
 
35
-			$label = $field['label'];
35
+			$label = $field[ 'label' ];
36 36
 
37 37
 			// Support Gravity Forms 1.9+
38
-			if( class_exists( 'GF_Field' ) ) {
38
+			if ( class_exists( 'GF_Field' ) ) {
39 39
 
40
-				$field_object = RGFormsModel::get_field( $form, $field['id'] );
40
+				$field_object = RGFormsModel::get_field( $form, $field[ 'id' ] );
41 41
 
42
-				if( $field_object ) {
42
+				if ( $field_object ) {
43 43
 
44
-					$input = GFFormsModel::get_input( $field_object, $field['id'] );
44
+					$input = GFFormsModel::get_input( $field_object, $field[ 'id' ] );
45 45
 
46 46
 					// This is a complex field, with labels on a per-input basis
47
-					if( $input ) {
47
+					if ( $input ) {
48 48
 
49 49
 						// Does the input have a custom label on a per-input basis? Otherwise, default label.
50
-						$label = ! empty( $input['customLabel'] ) ? $input['customLabel'] : $input['label'];
50
+						$label = ! empty( $input[ 'customLabel' ] ) ? $input[ 'customLabel' ] : $input[ 'label' ];
51 51
 
52 52
 					} else {
53 53
 
54 54
 						// This is a field with one label
55
-						$label = $field_object->get_field_label( true, $field['label'] );
55
+						$label = $field_object->get_field_label( true, $field[ 'label' ] );
56 56
 
57 57
 					}
58 58
 
@@ -61,9 +61,9 @@  discard block
 block discarded – undo
61 61
 			}
62 62
 
63 63
 			// Use Gravity Forms label by default, but if a custom label is defined in GV, use it.
64
-			if ( !empty( $field['custom_label'] ) ) {
64
+			if ( ! empty( $field[ 'custom_label' ] ) ) {
65 65
 
66
-				$label = self::replace_variables( $field['custom_label'], $form, $entry );
66
+				$label = self::replace_variables( $field[ 'custom_label' ], $form, $entry );
67 67
 
68 68
 			}
69 69
 
@@ -117,11 +117,11 @@  discard block
 block discarded – undo
117 117
 
118 118
 		$width = NULL;
119 119
 
120
-		if( !empty( $field['width'] ) ) {
121
-			$width = absint( $field['width'] );
120
+		if ( ! empty( $field[ 'width' ] ) ) {
121
+			$width = absint( $field[ 'width' ] );
122 122
 
123 123
 			// If using percentages, limit to 100%
124
-			if( '%d%%' === $format && $width > 100 ) {
124
+			if ( '%d%%' === $format && $width > 100 ) {
125 125
 				$width = 100;
126 126
 			}
127 127
 
@@ -144,39 +144,39 @@  discard block
 block discarded – undo
144 144
 
145 145
 		$classes = array();
146 146
 
147
-		if( !empty( $field['custom_class'] ) ) {
147
+		if ( ! empty( $field[ 'custom_class' ] ) ) {
148 148
 
149
-            $custom_class = $field['custom_class'];
149
+            $custom_class = $field[ 'custom_class' ];
150 150
 
151
-            if( !empty( $entry ) ) {
151
+            if ( ! empty( $entry ) ) {
152 152
 
153 153
                 // We want the merge tag to be formatted as a class. The merge tag may be
154 154
                 // replaced by a multiple-word value that should be output as a single class.
155 155
                 // "Office Manager" will be formatted as `.OfficeManager`, not `.Office` and `.Manager`
156
-                add_filter('gform_merge_tag_filter', 'sanitize_html_class');
156
+                add_filter( 'gform_merge_tag_filter', 'sanitize_html_class' );
157 157
 
158
-                $custom_class = self::replace_variables( $custom_class, $form, $entry);
158
+                $custom_class = self::replace_variables( $custom_class, $form, $entry );
159 159
 
160 160
                 // And then we want life to return to normal
161
-                remove_filter('gform_merge_tag_filter', 'sanitize_html_class');
161
+                remove_filter( 'gform_merge_tag_filter', 'sanitize_html_class' );
162 162
             }
163 163
 
164 164
 			// And now we want the spaces to be handled nicely.
165
-			$classes[] = gravityview_sanitize_html_class( $custom_class );
165
+			$classes[ ] = gravityview_sanitize_html_class( $custom_class );
166 166
 
167 167
 		}
168 168
 
169
-		if(!empty($field['id'])) {
170
-			if( !empty( $form ) && !empty( $form['id'] ) ) {
171
-				$form_id = '-'.$form['id'];
169
+		if ( ! empty( $field[ 'id' ] ) ) {
170
+			if ( ! empty( $form ) && ! empty( $form[ 'id' ] ) ) {
171
+				$form_id = '-' . $form[ 'id' ];
172 172
 			} else {
173
-				$form_id = $gravityview_view->getFormId() ? '-'. $gravityview_view->getFormId() : '';
173
+				$form_id = $gravityview_view->getFormId() ? '-' . $gravityview_view->getFormId() : '';
174 174
 			}
175 175
 
176
-			$classes[] = 'gv-field'.$form_id.'-'.$field['id'];
176
+			$classes[ ] = 'gv-field' . $form_id . '-' . $field[ 'id' ];
177 177
 		}
178 178
 
179
-		return esc_attr(implode(' ', $classes));
179
+		return esc_attr( implode( ' ', $classes ) );
180 180
 	}
181 181
 
182 182
 	/**
@@ -193,16 +193,16 @@  discard block
 block discarded – undo
193 193
 	 */
194 194
 	public static function field_html_attr_id( $field, $form = array(), $entry = array() ) {
195 195
 		$gravityview_view = GravityView_View::getInstance();
196
-		$id = $field['id'];
196
+		$id = $field[ 'id' ];
197 197
 
198 198
 		if ( ! empty( $id ) ) {
199
-			if ( ! empty( $form ) && ! empty( $form['id'] ) ) {
200
-				$form_id = '-' . $form['id'];
199
+			if ( ! empty( $form ) && ! empty( $form[ 'id' ] ) ) {
200
+				$form_id = '-' . $form[ 'id' ];
201 201
 			} else {
202 202
 				$form_id = $gravityview_view->getFormId() ? '-' . $gravityview_view->getFormId() : '';
203 203
 			}
204 204
 
205
-			$id = 'gv-field' . $form_id . '-' . $field['id'];
205
+			$id = 'gv-field' . $form_id . '-' . $field[ 'id' ];
206 206
 		}
207 207
 
208 208
 		return esc_attr( $id );
@@ -219,13 +219,13 @@  discard block
 block discarded – undo
219 219
 	 */
220 220
 	public static function field_value( $entry, $field_settings, $format = 'html' ) {
221 221
 
222
-		if( empty( $entry['form_id'] ) || empty( $field_settings['id'] ) ) {
222
+		if ( empty( $entry[ 'form_id' ] ) || empty( $field_settings[ 'id' ] ) ) {
223 223
 			return NULL;
224 224
 		}
225 225
 
226 226
 		$gravityview_view = GravityView_View::getInstance();
227 227
 
228
-		if( class_exists( 'GFCache' ) ) {
228
+		if ( class_exists( 'GFCache' ) ) {
229 229
 			/**
230 230
 			 * Gravity Forms' GFCache function was thrashing the database, causing double the amount of time for the field_value() method to run.
231 231
 			 *
@@ -240,46 +240,46 @@  discard block
 block discarded – undo
240 240
 			 * @param boolean false Tell Gravity Forms not to store this as a transient
241 241
 			 * @param  int 0 Time to store the value. 0 is maximum amount of time possible.
242 242
 			 */
243
-			GFCache::set( "GFFormsModel::get_lead_field_value_" . $entry["id"] . "_" . $field_settings["id"], false, false, 0 );
243
+			GFCache::set( "GFFormsModel::get_lead_field_value_" . $entry[ "id" ] . "_" . $field_settings[ "id" ], false, false, 0 );
244 244
 		}
245 245
 
246
-		$field_id = $field_settings['id'];
246
+		$field_id = $field_settings[ 'id' ];
247 247
 
248 248
 		$form = $gravityview_view->getForm();
249 249
 
250 250
 		$field = gravityview_get_field( $form, $field_id );
251 251
 
252
-		$field_type = RGFormsModel::get_input_type($field);
252
+		$field_type = RGFormsModel::get_input_type( $field );
253 253
 
254
-		if( $field_type ) {
255
-			$field_type = $field['type'];
256
-			$value = RGFormsModel::get_lead_field_value($entry, $field);
254
+		if ( $field_type ) {
255
+			$field_type = $field[ 'type' ];
256
+			$value = RGFormsModel::get_lead_field_value( $entry, $field );
257 257
 		} else {
258 258
 			// For non-integer field types (`id`, `date_created`, etc.)
259 259
 			$field_type = $field_id;
260
-			$field['type'] = $field_id;
261
-			$value = isset($entry[$field_type]) ? $entry[$field_type] : NULL;
260
+			$field[ 'type' ] = $field_id;
261
+			$value = isset( $entry[ $field_type ] ) ? $entry[ $field_type ] : NULL;
262 262
 		}
263 263
 
264 264
 		// Prevent any PHP warnings that may be generated
265 265
 		ob_start();
266 266
 
267
-		$display_value = GFCommon::get_lead_field_display($field, $value, $entry["currency"], false, $format);
267
+		$display_value = GFCommon::get_lead_field_display( $field, $value, $entry[ "currency" ], false, $format );
268 268
 
269
-		if( $errors = ob_get_clean() ) {
269
+		if ( $errors = ob_get_clean() ) {
270 270
 			do_action( 'gravityview_log_error', 'GravityView_API[field_value] Errors when calling GFCommon::get_lead_field_display()', $errors );
271 271
 		}
272 272
 
273
-		$display_value = apply_filters("gform_entry_field_value", $display_value, $field, $entry, $form);
273
+		$display_value = apply_filters( "gform_entry_field_value", $display_value, $field, $entry, $form );
274 274
 
275 275
 		// prevent the use of merge_tags for non-admin fields
276
-		if( !empty( $field['adminOnly'] ) ) {
276
+		if ( ! empty( $field[ 'adminOnly' ] ) ) {
277 277
 			$display_value = self::replace_variables( $display_value, $form, $entry );
278 278
 		}
279 279
 
280 280
 		// Check whether the field exists in /includes/fields/{$field_type}.php
281 281
 		// This can be overridden by user template files.
282
-		$field_path = $gravityview_view->locate_template("fields/{$field_type}.php");
282
+		$field_path = $gravityview_view->locate_template( "fields/{$field_type}.php" );
283 283
 
284 284
 		// Set the field data to be available in the templates
285 285
 		$gravityview_view->setCurrentField( array(
@@ -293,11 +293,11 @@  discard block
 block discarded – undo
293 293
 			'entry' => $entry,
294 294
 			'field_type' => $field_type, /** {@since 1.6} */
295 295
 		    'field_path' => $field_path, /** {@since 1.16} */
296
-		));
296
+		) );
297 297
 
298
-		if( ! empty( $field_path ) ) {
298
+		if ( ! empty( $field_path ) ) {
299 299
 
300
-			do_action( 'gravityview_log_debug', sprintf('[field_value] Rendering %s', $field_path ) );
300
+			do_action( 'gravityview_log_debug', sprintf( '[field_value] Rendering %s', $field_path ) );
301 301
 
302 302
 			ob_start();
303 303
 
@@ -312,7 +312,7 @@  discard block
 block discarded – undo
312 312
 
313 313
 		}
314 314
 
315
-		$field_settings = $gravityview_view->getCurrentField('field_settings');
315
+		$field_settings = $gravityview_view->getCurrentField( 'field_settings' );
316 316
 
317 317
 		/**
318 318
 		 * @filter `gravityview_field_entry_value_{$field_type}_pre_link` Modify the field value output for a field type before Show As Link setting is applied. Example: `gravityview_field_entry_value_number_pre_link`
@@ -330,9 +330,9 @@  discard block
 block discarded – undo
330 330
 		 * Fields can override this by modifying the field data variable inside the field. See /templates/fields/post_image.php for an example.
331 331
 		 *
332 332
 		 */
333
-		if( !empty( $field_settings['show_as_link'] ) && ! gv_empty( $output, false, false ) ) {
333
+		if ( ! empty( $field_settings[ 'show_as_link' ] ) && ! gv_empty( $output, false, false ) ) {
334 334
 
335
-			$link_atts = empty( $field_settings['new_window'] ) ? array() : array( 'target' => '_blank' );
335
+			$link_atts = empty( $field_settings[ 'new_window' ] ) ? array() : array( 'target' => '_blank' );
336 336
 
337 337
 			$output = self::entry_link_html( $entry, $output, $link_atts, $field_settings );
338 338
 
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
 		 * @param  array $field_settings Settings for the particular GV field
347 347
 		 * @param array $field Current field being displayed
348 348
 		 */
349
-		$output = apply_filters( 'gravityview_field_entry_value_'.$field_type, $output, $entry, $field_settings, $gravityview_view->getCurrentField() );
349
+		$output = apply_filters( 'gravityview_field_entry_value_' . $field_type, $output, $entry, $field_settings, $gravityview_view->getCurrentField() );
350 350
 
351 351
 		/**
352 352
 		 * @filter `gravityview_field_entry_value` Modify the field value output for all field types
@@ -375,14 +375,14 @@  discard block
 block discarded – undo
375 375
 	 */
376 376
 	public static function entry_link_html( $entry = array(), $anchor_text = '', $passed_tag_atts = array(), $field_settings = array() ) {
377 377
 
378
-		if ( empty( $entry ) || ! is_array( $entry ) || ! isset( $entry['id'] ) ) {
378
+		if ( empty( $entry ) || ! is_array( $entry ) || ! isset( $entry[ 'id' ] ) ) {
379 379
 			do_action( 'gravityview_log_debug', 'GravityView_API[entry_link_tag] Entry not defined; returning null', $entry );
380 380
 			return NULL;
381 381
 		}
382 382
 
383 383
 		$href = self::entry_link( $entry );
384 384
 
385
-		if( '' === $href ) {
385
+		if ( '' === $href ) {
386 386
 			return NULL;
387 387
 		}
388 388
 
@@ -405,19 +405,19 @@  discard block
 block discarded – undo
405 405
 	 * @param  boolean     $wpautop Apply wpautop() to the output?
406 406
 	 * @return string               HTML of "no results" text
407 407
 	 */
408
-	public static function no_results($wpautop = true) {
408
+	public static function no_results( $wpautop = true ) {
409 409
 		$gravityview_view = GravityView_View::getInstance();
410 410
 
411 411
 		$is_search = false;
412 412
 
413
-		if( $gravityview_view && ( $gravityview_view->curr_start || $gravityview_view->curr_end || $gravityview_view->curr_search ) ) {
413
+		if ( $gravityview_view && ( $gravityview_view->curr_start || $gravityview_view->curr_end || $gravityview_view->curr_search ) ) {
414 414
 			$is_search = true;
415 415
 		}
416 416
 
417
-		if($is_search) {
418
-			$output = __('This search returned no results.', 'gravityview');
417
+		if ( $is_search ) {
418
+			$output = __( 'This search returned no results.', 'gravityview' );
419 419
 		} else {
420
-			$output = __('No entries match your request.', 'gravityview');
420
+			$output = __( 'No entries match your request.', 'gravityview' );
421 421
 		}
422 422
 
423 423
 		/**
@@ -425,9 +425,9 @@  discard block
 block discarded – undo
425 425
 		 * @param string $output The existing "No Entries" text
426 426
 		 * @param boolean $is_search Is the current page a search result, or just a multiple entries screen?
427 427
 		 */
428
-		$output = apply_filters( 'gravitview_no_entries_text', $output, $is_search);
428
+		$output = apply_filters( 'gravitview_no_entries_text', $output, $is_search );
429 429
 
430
-		return $wpautop ? wpautop($output) : $output;
430
+		return $wpautop ? wpautop( $output ) : $output;
431 431
 	}
432 432
 
433 433
 	/**
@@ -444,37 +444,37 @@  discard block
 block discarded – undo
444 444
 
445 445
 		$gravityview_view = GravityView_View::getInstance();
446 446
 
447
-		if( empty( $post_id ) ) {
447
+		if ( empty( $post_id ) ) {
448 448
 
449 449
 			$post_id = false;
450 450
 
451 451
 			// DataTables passes the Post ID
452
-			if( defined('DOING_AJAX') && DOING_AJAX ) {
452
+			if ( defined( 'DOING_AJAX' ) && DOING_AJAX ) {
453 453
 
454
-				$post_id = isset( $_POST['post_id'] ) ? (int)$_POST['post_id'] : false;
454
+				$post_id = isset( $_POST[ 'post_id' ] ) ? (int)$_POST[ 'post_id' ] : false;
455 455
 
456 456
 			} else {
457 457
 
458 458
 				// The Post ID has been passed via the shortcode
459
-				if( !empty( $gravityview_view ) && $gravityview_view->getPostId() ) {
459
+				if ( ! empty( $gravityview_view ) && $gravityview_view->getPostId() ) {
460 460
 
461 461
 					$post_id = $gravityview_view->getPostId();
462 462
 
463 463
 				} else {
464 464
 
465 465
 					// This is a GravityView post type
466
-					if( GravityView_frontend::getInstance()->isGravityviewPostType() ) {
466
+					if ( GravityView_frontend::getInstance()->isGravityviewPostType() ) {
467 467
 
468 468
 						$post_id = isset( $gravityview_view ) ? $gravityview_view->getViewId() : $post->ID;
469 469
 
470 470
 					} else {
471 471
 
472 472
 						// This is an embedded GravityView; use the embedded post's ID as the base.
473
-						if( GravityView_frontend::getInstance()->isPostHasShortcode() && is_a( $post, 'WP_Post' ) ) {
473
+						if ( GravityView_frontend::getInstance()->isPostHasShortcode() && is_a( $post, 'WP_Post' ) ) {
474 474
 
475 475
 							$post_id = $post->ID;
476 476
 
477
-						} elseif( $gravityview_view->getViewId() ) {
477
+						} elseif ( $gravityview_view->getViewId() ) {
478 478
 
479 479
 							// The GravityView has been embedded in a widget or in a template, and
480 480
 							// is not in the current content. Thus, we defer to the View's own ID.
@@ -489,36 +489,36 @@  discard block
 block discarded – undo
489 489
 		}
490 490
 
491 491
 		// No post ID, get outta here.
492
-		if( empty( $post_id ) ) {
492
+		if ( empty( $post_id ) ) {
493 493
 			return NULL;
494 494
 		}
495 495
 
496 496
 		// If we've saved the permalink in memory, use it
497 497
 		// @since 1.3
498
-		$link = wp_cache_get( 'gv_directory_link_'.$post_id );
498
+		$link = wp_cache_get( 'gv_directory_link_' . $post_id );
499 499
 
500
-		if( empty( $link ) ) {
500
+		if ( empty( $link ) ) {
501 501
 
502 502
 			$link = get_permalink( $post_id );
503 503
 
504 504
 			// If not yet saved, cache the permalink.
505 505
 			// @since 1.3
506
-			wp_cache_set( 'gv_directory_link_'.$post_id, $link );
506
+			wp_cache_set( 'gv_directory_link_' . $post_id, $link );
507 507
 
508 508
 		}
509 509
 
510 510
 		// Deal with returning to proper pagination for embedded views
511
-		if( $link && $add_query_args ) {
511
+		if ( $link && $add_query_args ) {
512 512
 
513 513
 			$args = array();
514 514
 
515
-			if( $pagenum = rgget('pagenum') ) {
516
-				$args['pagenum'] = intval( $pagenum );
515
+			if ( $pagenum = rgget( 'pagenum' ) ) {
516
+				$args[ 'pagenum' ] = intval( $pagenum );
517 517
 			}
518 518
 
519
-			if( $sort = rgget('sort') ) {
520
-				$args['sort'] = $sort;
521
-				$args['dir'] = rgget('dir');
519
+			if ( $sort = rgget( 'sort' ) ) {
520
+				$args[ 'sort' ] = $sort;
521
+				$args[ 'dir' ] = rgget( 'dir' );
522 522
 			}
523 523
 
524 524
 			$link = add_query_arg( $args, $link );
@@ -541,7 +541,7 @@  discard block
 block discarded – undo
541 541
 	private static function get_custom_entry_slug( $id, $entry = array() ) {
542 542
 
543 543
 		// Generate an unique hash to use as the default value
544
-		$slug = substr( wp_hash( $id, 'gravityview'.$id ), 0, 8 );
544
+		$slug = substr( wp_hash( $id, 'gravityview' . $id ), 0, 8 );
545 545
 
546 546
 		/**
547 547
 		 * @filter `gravityview_entry_slug` Modify the unique hash ID generated, if you want to improve usability or change the format. This will allow for custom URLs, such as `{entryid}-{first-name}` or even, if unique, `{first-name}-{last-name}`
@@ -552,7 +552,7 @@  discard block
 block discarded – undo
552 552
 		$slug = apply_filters( 'gravityview_entry_slug', $slug, $id, $entry );
553 553
 
554 554
 		// Make sure we have something - use the original ID as backup.
555
-		if( empty( $slug ) ) {
555
+		if ( empty( $slug ) ) {
556 556
 			$slug = $id;
557 557
 		}
558 558
 
@@ -581,7 +581,7 @@  discard block
 block discarded – undo
581 581
 		 * @filter `gravityview_custom_entry_slug` Whether to enable and use custom entry slugs.
582 582
 		 * @param boolean True: Allow for slugs based on entry values. False: always use entry IDs (default)
583 583
 		 */
584
-		$custom = apply_filters('gravityview_custom_entry_slug', false );
584
+		$custom = apply_filters( 'gravityview_custom_entry_slug', false );
585 585
 
586 586
 		// If we're using custom slug...
587 587
 		if ( $custom ) {
@@ -595,7 +595,7 @@  discard block
 block discarded – undo
595 595
 			// If it does have a hash set, and the hash is expected, use it.
596 596
 			// This check allows users to change the hash structure using the
597 597
 			// gravityview_entry_hash filter and have the old hashes expire.
598
-			if( empty( $value ) || $value !== $hash ) {
598
+			if ( empty( $value ) || $value !== $hash ) {
599 599
 
600 600
 				gform_update_meta( $id_or_string, 'gravityview_unique_id', $hash );
601 601
 
@@ -623,12 +623,12 @@  discard block
 block discarded – undo
623 623
          * @param boolean $custom Should we process the custom entry slug?
624 624
          */
625 625
         $custom = apply_filters( 'gravityview_custom_entry_slug', false );
626
-        if( $custom ) {
626
+        if ( $custom ) {
627 627
             // create the gravityview_unique_id and save it
628 628
 
629 629
             // Get the entry hash
630
-            $hash = self::get_custom_entry_slug( $entry['id'], $entry );
631
-            gform_update_meta( $entry['id'], 'gravityview_unique_id', $hash );
630
+            $hash = self::get_custom_entry_slug( $entry[ 'id' ], $entry );
631
+            gform_update_meta( $entry[ 'id' ], 'gravityview_unique_id', $hash );
632 632
 
633 633
         }
634 634
     }
@@ -645,14 +645,14 @@  discard block
 block discarded – undo
645 645
 	 */
646 646
 	public static function entry_link( $entry, $post_id = NULL, $add_directory_args = true ) {
647 647
 
648
-		if( ! empty( $entry ) && ! is_array( $entry ) ) {
648
+		if ( ! empty( $entry ) && ! is_array( $entry ) ) {
649 649
 			$entry = GVCommon::get_entry( $entry );
650
-		} else if( empty( $entry ) ) {
650
+		} else if ( empty( $entry ) ) {
651 651
 			$entry = GravityView_frontend::getInstance()->getEntry();
652 652
 		}
653 653
 
654 654
 		// Second parameter used to be passed as $field; this makes sure it's not an array
655
-		if( !is_numeric( $post_id ) ) {
655
+		if ( ! is_numeric( $post_id ) ) {
656 656
 			$post_id = NULL;
657 657
 		}
658 658
 
@@ -660,19 +660,19 @@  discard block
 block discarded – undo
660 660
 		$directory_link = self::directory_link( $post_id, false );
661 661
 
662 662
 		// No post ID? Get outta here.
663
-		if( empty( $directory_link ) ) {
663
+		if ( empty( $directory_link ) ) {
664 664
 			return '';
665 665
 		}
666 666
 
667 667
 		$query_arg_name = GravityView_Post_Types::get_entry_var_name();
668 668
 
669
-		$entry_slug = self::get_entry_slug( $entry['id'], $entry );
669
+		$entry_slug = self::get_entry_slug( $entry[ 'id' ], $entry );
670 670
 
671
-		if( get_option('permalink_structure') && !is_preview() ) {
671
+		if ( get_option( 'permalink_structure' ) && ! is_preview() ) {
672 672
 
673 673
 			$args = array();
674 674
 
675
-			$directory_link = trailingslashit( $directory_link ) . $query_arg_name . '/'. $entry_slug .'/';
675
+			$directory_link = trailingslashit( $directory_link ) . $query_arg_name . '/' . $entry_slug . '/';
676 676
 
677 677
 		} else {
678 678
 
@@ -682,18 +682,18 @@  discard block
 block discarded – undo
682 682
 		/**
683 683
 		 * @since 1.7.3
684 684
 		 */
685
-		if( $add_directory_args ) {
685
+		if ( $add_directory_args ) {
686 686
 
687
-			if( !empty( $_GET['pagenum'] ) ) {
688
-				$args['pagenum'] = intval( $_GET['pagenum'] );
687
+			if ( ! empty( $_GET[ 'pagenum' ] ) ) {
688
+				$args[ 'pagenum' ] = intval( $_GET[ 'pagenum' ] );
689 689
 			}
690 690
 
691 691
 			/**
692 692
 			 * @since 1.7
693 693
 			 */
694
-			if( $sort = rgget('sort') ) {
695
-				$args['sort'] = $sort;
696
-				$args['dir'] = rgget('dir');
694
+			if ( $sort = rgget( 'sort' ) ) {
695
+				$args[ 'sort' ] = $sort;
696
+				$args[ 'dir' ] = rgget( 'dir' );
697 697
 			}
698 698
 
699 699
 		}
@@ -703,8 +703,8 @@  discard block
 block discarded – undo
703 703
 		 * has the view id so that Advanced Filters can be applied correctly when rendering the single view
704 704
 		 * @see GravityView_frontend::get_context_view_id()
705 705
 		 */
706
-		if( class_exists( 'GravityView_View_Data' ) && GravityView_View_Data::getInstance()->has_multiple_views() ) {
707
-			$args['gvid'] = gravityview_get_view_id();
706
+		if ( class_exists( 'GravityView_View_Data' ) && GravityView_View_Data::getInstance()->has_multiple_views() ) {
707
+			$args[ 'gvid' ] = gravityview_get_view_id();
708 708
 		}
709 709
 
710 710
 		return add_query_arg( $args, $directory_link );
@@ -722,7 +722,7 @@  discard block
 block discarded – undo
722 722
 }
723 723
 
724 724
 function gv_class( $field, $form = NULL, $entry = array() ) {
725
-	return GravityView_API::field_class( $field, $form, $entry  );
725
+	return GravityView_API::field_class( $field, $form, $entry );
726 726
 }
727 727
 
728 728
 /**
@@ -744,11 +744,11 @@  discard block
 block discarded – undo
744 744
 
745 745
 	$default_css_class = ! empty( $view_id ) ? sprintf( 'gv-container gv-container-%d', $view_id ) : 'gv-container';
746 746
 
747
-	if( GravityView_View::getInstance()->isHideUntilSearched() ) {
747
+	if ( GravityView_View::getInstance()->isHideUntilSearched() ) {
748 748
 		$default_css_class .= ' hidden';
749 749
 	}
750 750
 
751
-	$css_class = trim( $passed_css_class . ' '. $default_css_class );
751
+	$css_class = trim( $passed_css_class . ' ' . $default_css_class );
752 752
 
753 753
 	/**
754 754
 	 * @filter `gravityview/render/container/class` Modify the CSS class to be added to the wrapper <div> of a View
@@ -759,7 +759,7 @@  discard block
 block discarded – undo
759 759
 
760 760
 	$css_class = gravityview_sanitize_html_class( $css_class );
761 761
 
762
-	if( $echo ) {
762
+	if ( $echo ) {
763 763
 		echo $css_class;
764 764
 	}
765 765
 
@@ -770,7 +770,7 @@  discard block
 block discarded – undo
770 770
 
771 771
 	$value = GravityView_API::field_value( $entry, $field );
772 772
 
773
-	if( $value === '') {
773
+	if ( $value === '' ) {
774 774
 		/**
775 775
 		 * @filter `gravityview_empty_value` What to display when a field is empty
776 776
 		 * @param string $value (empty string)
@@ -789,7 +789,7 @@  discard block
 block discarded – undo
789 789
 	return GravityView_API::entry_link( $entry, $post_id );
790 790
 }
791 791
 
792
-function gv_no_results($wpautop = true) {
792
+function gv_no_results( $wpautop = true ) {
793 793
 	return GravityView_API::no_results( $wpautop );
794 794
 }
795 795
 
@@ -802,7 +802,7 @@  discard block
 block discarded – undo
802 802
 
803 803
 	$href = gv_directory_link();
804 804
 
805
-	if( empty( $href ) ) { return NULL; }
805
+	if ( empty( $href ) ) { return NULL; }
806 806
 
807 807
 	// calculate link label
808 808
 	$gravityview_view = GravityView_View::getInstance();
@@ -818,7 +818,7 @@  discard block
 block discarded – undo
818 818
 
819 819
 	$link = gravityview_get_link( $href, esc_html( $label ), array(
820 820
 		'data-viewid' => $gravityview_view->getViewId()
821
-	));
821
+	) );
822 822
 
823 823
 	return $link;
824 824
 }
@@ -837,7 +837,7 @@  discard block
 block discarded – undo
837 837
  */
838 838
 function gravityview_get_field_value( $entry, $field_id, $display_value ) {
839 839
 
840
-	if( floatval( $field_id ) === floor( floatval( $field_id ) ) ) {
840
+	if ( floatval( $field_id ) === floor( floatval( $field_id ) ) ) {
841 841
 
842 842
 		// For the complete field value as generated by Gravity Forms
843 843
 		return $display_value;
@@ -867,16 +867,16 @@  discard block
 block discarded – undo
867 867
 
868 868
 	$terms = explode( ', ', $value );
869 869
 
870
-	foreach ($terms as $term_name ) {
870
+	foreach ( $terms as $term_name ) {
871 871
 
872 872
 		// If we're processing a category,
873
-		if( $taxonomy === 'category' ) {
873
+		if ( $taxonomy === 'category' ) {
874 874
 
875 875
 			// Use rgexplode to prevent errors if : doesn't exist
876 876
 			list( $term_name, $term_id ) = rgexplode( ':', $value, 2 );
877 877
 
878 878
 			// The explode was succesful; we have the category ID
879
-			if( !empty( $term_id )) {
879
+			if ( ! empty( $term_id ) ) {
880 880
 				$term = get_term_by( 'id', $term_id, $taxonomy );
881 881
 			} else {
882 882
 			// We have to fall back to the name
@@ -889,7 +889,7 @@  discard block
 block discarded – undo
889 889
 		}
890 890
 
891 891
 		// There's still a tag/category here.
892
-		if( $term ) {
892
+		if ( $term ) {
893 893
 
894 894
 			$term_link = get_term_link( $term, $taxonomy );
895 895
 
@@ -898,11 +898,11 @@  discard block
 block discarded – undo
898 898
 			    continue;
899 899
 			}
900 900
 
901
-			$output[] = gravityview_get_link( $term_link, esc_html( $term->name ) );
901
+			$output[ ] = gravityview_get_link( $term_link, esc_html( $term->name ) );
902 902
 		}
903 903
 	}
904 904
 
905
-	return implode(', ', $output );
905
+	return implode( ', ', $output );
906 906
 }
907 907
 
908 908
 /**
@@ -916,8 +916,8 @@  discard block
 block discarded – undo
916 916
 
917 917
 	$output = get_the_term_list( $post_id, $taxonomy, NULL, ', ' );
918 918
 
919
-	if( empty( $link ) ) {
920
-		return strip_tags( $output);
919
+	if ( empty( $link ) ) {
920
+		return strip_tags( $output );
921 921
 	}
922 922
 
923 923
 	return $output;
@@ -936,7 +936,7 @@  discard block
 block discarded – undo
936 936
 	$fe = GravityView_frontend::getInstance();
937 937
 
938 938
 	// Solve problem when loading content via admin-ajax.php
939
-	if( ! $fe->getGvOutputData() ) {
939
+	if ( ! $fe->getGvOutputData() ) {
940 940
 
941 941
 		do_action( 'gravityview_log_debug', '[gravityview_get_current_views] gv_output_data not defined; parsing content.' );
942 942
 
@@ -944,7 +944,7 @@  discard block
 block discarded – undo
944 944
 	}
945 945
 
946 946
 	// Make 100% sure that we're dealing with a properly called situation
947
-	if( !is_a( $fe->getGvOutputData(), 'GravityView_View_Data' ) ) {
947
+	if ( ! is_a( $fe->getGvOutputData(), 'GravityView_View_Data' ) ) {
948 948
 
949 949
 		do_action( 'gravityview_log_debug', '[gravityview_get_current_views] gv_output_data not an object or get_view not callable.', $fe->getGvOutputData() );
950 950
 
@@ -964,10 +964,10 @@  discard block
 block discarded – undo
964 964
 
965 965
 	$fe = GravityView_frontend::getInstance();
966 966
 
967
-	if( ! $fe->getGvOutputData() ) { return array(); }
967
+	if ( ! $fe->getGvOutputData() ) { return array(); }
968 968
 
969 969
 	// If not set, grab the current view ID
970
-	if( empty( $view_id ) ) {
970
+	if ( empty( $view_id ) ) {
971 971
 		$view_id = $fe->get_context_view_id();
972 972
 	}
973 973
 
@@ -1032,11 +1032,11 @@  discard block
 block discarded – undo
1032 1032
 	 */
1033 1033
 	$is_edit_entry = apply_filters( 'gravityview_is_edit_entry', false );
1034 1034
 
1035
-	if( $is_edit_entry ) {
1035
+	if ( $is_edit_entry ) {
1036 1036
 		$context = 'edit';
1037
-	} else if( class_exists( 'GravityView_frontend' ) && $single = GravityView_frontend::is_single_entry() ) {
1037
+	} else if ( class_exists( 'GravityView_frontend' ) && $single = GravityView_frontend::is_single_entry() ) {
1038 1038
 		$context = 'single';
1039
-	} else if( class_exists( 'GravityView_View' ) ) {
1039
+	} else if ( class_exists( 'GravityView_View' ) ) {
1040 1040
 		$context = GravityView_View::getInstance()->getContext();
1041 1041
 	}
1042 1042
 
@@ -1064,12 +1064,12 @@  discard block
 block discarded – undo
1064 1064
 function gravityview_get_files_array( $value, $gv_class = '' ) {
1065 1065
 	/** @define "GRAVITYVIEW_DIR" "../" */
1066 1066
 
1067
-	if( !class_exists( 'GravityView_Field' ) ) {
1068
-		include_once( GRAVITYVIEW_DIR .'includes/fields/class-gravityview-field.php' );
1067
+	if ( ! class_exists( 'GravityView_Field' ) ) {
1068
+		include_once( GRAVITYVIEW_DIR . 'includes/fields/class-gravityview-field.php' );
1069 1069
 	}
1070 1070
 
1071
-	if( !class_exists( 'GravityView_Field_FileUpload' ) ) {
1072
-		include_once( GRAVITYVIEW_DIR .'includes/fields/fileupload.php' );
1071
+	if ( ! class_exists( 'GravityView_Field_FileUpload' ) ) {
1072
+		include_once( GRAVITYVIEW_DIR . 'includes/fields/fileupload.php' );
1073 1073
 	}
1074 1074
 
1075 1075
 	return GravityView_Field_FileUpload::get_files_array( $value, $gv_class );
@@ -1147,12 +1147,12 @@  discard block
 block discarded – undo
1147 1147
 	$args = apply_filters( 'gravityview/field_output/args', $args, $passed_args );
1148 1148
 
1149 1149
 	// Required fields.
1150
-	if ( empty( $args['field'] ) || empty( $args['form'] ) ) {
1150
+	if ( empty( $args[ 'field' ] ) || empty( $args[ 'form' ] ) ) {
1151 1151
 		do_action( 'gravityview_log_error', '[gravityview_field_output] Field or form are empty.', $args );
1152 1152
 		return '';
1153 1153
 	}
1154 1154
 
1155
-	$entry = empty( $args['entry'] ) ? array() : $args['entry'];
1155
+	$entry = empty( $args[ 'entry' ] ) ? array() : $args[ 'entry' ];
1156 1156
 
1157 1157
 	/**
1158 1158
 	 * Create the content variables for replacing.
@@ -1168,37 +1168,37 @@  discard block
 block discarded – undo
1168 1168
 		'field_id' => '',
1169 1169
 	);
1170 1170
 
1171
-	$context['value'] = gv_value( $entry, $args['field'] );
1171
+	$context[ 'value' ] = gv_value( $entry, $args[ 'field' ] );
1172 1172
 
1173 1173
 	// If the value is empty and we're hiding empty, return empty.
1174
-	if ( $context['value'] === '' && ! empty( $args['hide_empty'] ) ) {
1174
+	if ( $context[ 'value' ] === '' && ! empty( $args[ 'hide_empty' ] ) ) {
1175 1175
 		return '';
1176 1176
 	}
1177 1177
 
1178
-	if ( $context['value'] !== '' && ! empty( $args['wpautop'] ) ) {
1179
-		$context['value'] = wpautop( $context['value'] );
1178
+	if ( $context[ 'value' ] !== '' && ! empty( $args[ 'wpautop' ] ) ) {
1179
+		$context[ 'value' ] = wpautop( $context[ 'value' ] );
1180 1180
 	}
1181 1181
 
1182 1182
 	// Get width setting, if exists
1183
-	$context['width'] = GravityView_API::field_width( $args['field'] );
1183
+	$context[ 'width' ] = GravityView_API::field_width( $args[ 'field' ] );
1184 1184
 
1185 1185
 	// If replacing with CSS inline formatting, let's do it.
1186
-	$context['width:style'] = GravityView_API::field_width( $args['field'], 'width:' . $context['width'] . '%;' );
1186
+	$context[ 'width:style' ] = GravityView_API::field_width( $args[ 'field' ], 'width:' . $context[ 'width' ] . '%;' );
1187 1187
 
1188 1188
 	// Grab the Class using `gv_class`
1189
-	$context['class'] = gv_class( $args['field'], $args['form'], $entry );
1190
-	$context['field_id'] = GravityView_API::field_html_attr_id( $args['field'], $args['form'], $entry );
1189
+	$context[ 'class' ] = gv_class( $args[ 'field' ], $args[ 'form' ], $entry );
1190
+	$context[ 'field_id' ] = GravityView_API::field_html_attr_id( $args[ 'field' ], $args[ 'form' ], $entry );
1191 1191
 
1192 1192
 	// Get field label if needed
1193
-	if ( ! empty( $args['label_markup'] ) && ! empty( $args['field']['show_label'] ) ) {
1194
-		$context['label'] = str_replace( array( '{{label}}', '{{ label }}' ), '<span class="gv-field-label">{{ label_value }}</span>', $args['label_markup'] );
1193
+	if ( ! empty( $args[ 'label_markup' ] ) && ! empty( $args[ 'field' ][ 'show_label' ] ) ) {
1194
+		$context[ 'label' ] = str_replace( array( '{{label}}', '{{ label }}' ), '<span class="gv-field-label">{{ label_value }}</span>', $args[ 'label_markup' ] );
1195 1195
 	}
1196 1196
 
1197 1197
 	// Default Label value
1198
-	$context['label_value'] = gv_label( $args['field'], $entry );
1198
+	$context[ 'label_value' ] = gv_label( $args[ 'field' ], $entry );
1199 1199
 
1200
-	if ( empty( $context['label'] ) && ! empty( $context['label_value'] ) ){
1201
-		$context['label'] = '<span class="gv-field-label">{{ label_value }}</span>';
1200
+	if ( empty( $context[ 'label' ] ) && ! empty( $context[ 'label_value' ] ) ) {
1201
+		$context[ 'label' ] = '<span class="gv-field-label">{{ label_value }}</span>';
1202 1202
 	}
1203 1203
 
1204 1204
 	/**
@@ -1207,7 +1207,7 @@  discard block
 block discarded – undo
1207 1207
 	 * @param string $markup The HTML for the markup
1208 1208
 	 * @param array $args All args for the field output
1209 1209
 	 */
1210
-	$html = apply_filters( 'gravityview/field_output/pre_html', $args['markup'], $args );
1210
+	$html = apply_filters( 'gravityview/field_output/pre_html', $args[ 'markup' ], $args );
1211 1211
 
1212 1212
 	/**
1213 1213
 	 * @filter `gravityview/field_output/open_tag` Modify the opening tags for the template content placeholders
@@ -1230,7 +1230,7 @@  discard block
 block discarded – undo
1230 1230
 	foreach ( $context as $tag => $value ) {
1231 1231
 
1232 1232
 		// If the tag doesn't exist just skip it
1233
-		if ( false === strpos( $html, $open_tag . $tag . $close_tag ) && false === strpos( $html, $open_tag . ' ' . $tag . ' ' . $close_tag ) ){
1233
+		if ( false === strpos( $html, $open_tag . $tag . $close_tag ) && false === strpos( $html, $open_tag . ' ' . $tag . ' ' . $close_tag ) ) {
1234 1234
 			continue;
1235 1235
 		}
1236 1236
 
Please login to merge, or discard this patch.
includes/class-common.php 1 patch
Spacing   +107 added lines, -107 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
 
125 125
 		$entry = self::get_entry( $entry_slug, true );
126 126
 
127
-		$form = self::get_form( $entry['form_id'] );
127
+		$form = self::get_form( $entry[ 'form_id' ] );
128 128
 
129 129
 		return $form;
130 130
 	}
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
 
176 176
 		$results = GFAPI::get_entries( 0, $search_criteria, null, $paging );
177 177
 
178
-		$result = ( ! empty( $results ) && ! empty( $results[0]['id'] ) ) ? $results[0]['id'] : null;
178
+		$result = ( ! empty( $results ) && ! empty( $results[ 0 ][ 'id' ] ) ) ? $results[ 0 ][ 'id' ] : null;
179 179
 
180 180
 		return $result;
181 181
 	}
@@ -193,9 +193,9 @@  discard block
 block discarded – undo
193 193
 		if ( class_exists( 'GFAPI' ) ) {
194 194
 			$gf_forms = GFAPI::get_forms();
195 195
 			foreach ( $gf_forms as $form ) {
196
-				$forms[] = array(
197
-					'id' => $form['id'],
198
-					'title' => $form['title'],
196
+				$forms[ ] = array(
197
+					'id' => $form[ 'id' ],
198
+					'title' => $form[ 'title' ],
199 199
 				);
200 200
 			}
201 201
 		}
@@ -227,9 +227,9 @@  discard block
 block discarded – undo
227 227
 		}
228 228
 
229 229
 		if ( $form ) {
230
-			foreach ( $form['fields'] as $field ) {
231
-				if ( $include_parent_field || empty( $field['inputs'] ) ) {
232
-					$fields[ $field['id'] ] = array(
230
+			foreach ( $form[ 'fields' ] as $field ) {
231
+				if ( $include_parent_field || empty( $field[ 'inputs' ] ) ) {
232
+					$fields[ $field[ 'id' ] ] = array(
233 233
 						'label' => rgar( $field, 'label' ),
234 234
 						'parent' => null,
235 235
 						'type' => rgar( $field, 'type' ),
@@ -238,16 +238,16 @@  discard block
 block discarded – undo
238 238
 					);
239 239
 				}
240 240
 
241
-				if ( $add_default_properties && ! empty( $field['inputs'] ) ) {
242
-					foreach ( $field['inputs'] as $input ) {
241
+				if ( $add_default_properties && ! empty( $field[ 'inputs' ] ) ) {
242
+					foreach ( $field[ 'inputs' ] as $input ) {
243 243
                         /**
244 244
                          * @hack
245 245
                          * In case of email/email confirmation, the input for email has the same id as the parent field
246 246
                          */
247
-                        if( 'email' == rgar( $field, 'type' ) && false === strpos( $input['id'], '.' ) ) {
247
+                        if ( 'email' == rgar( $field, 'type' ) && false === strpos( $input[ 'id' ], '.' ) ) {
248 248
                             continue;
249 249
                         }
250
-						$fields[ (string)$input['id'] ] = array(
250
+						$fields[ (string)$input[ 'id' ] ] = array(
251 251
 							'label' => rgar( $input, 'label' ),
252 252
 							'customLabel' => rgar( $input, 'customLabel' ),
253 253
 							'parent' => $field,
@@ -259,11 +259,11 @@  discard block
 block discarded – undo
259 259
 				}
260 260
 
261 261
 				/** @since 1.14 */
262
-				if( 'list' === $field['type'] && !empty( $field['enableColumns'] ) ) {
262
+				if ( 'list' === $field[ 'type' ] && ! empty( $field[ 'enableColumns' ] ) ) {
263 263
 
264
-					foreach ( (array)$field['choices'] as $key => $input ) {
264
+					foreach ( (array)$field[ 'choices' ] as $key => $input ) {
265 265
 
266
-						$input_id = sprintf( '%d.%d', $field['id'], $key ); // {field_id}.{column_key}
266
+						$input_id = sprintf( '%d.%d', $field[ 'id' ], $key ); // {field_id}.{column_key}
267 267
 
268 268
 						$fields[ $input_id ] = array(
269 269
 							'label'       => rgar( $input, 'text' ),
@@ -279,25 +279,25 @@  discard block
 block discarded – undo
279 279
 				/**
280 280
 				 * @since 1.8
281 281
 				 */
282
-				if( 'quiz' === $field['type'] ) {
282
+				if ( 'quiz' === $field[ 'type' ] ) {
283 283
 					$has_quiz_fields = true;
284 284
 				}
285 285
 
286 286
 				/**
287 287
 				 * @since 1.8
288 288
 				 */
289
-				if( 'poll' === $field['type'] ) {
289
+				if ( 'poll' === $field[ 'type' ] ) {
290 290
 					$has_poll_fields = true;
291 291
 				}
292 292
 
293
-				if( GFCommon::is_product_field( $field['type'] ) ){
293
+				if ( GFCommon::is_product_field( $field[ 'type' ] ) ) {
294 294
 					$has_product_fields = true;
295 295
 				}
296 296
 
297 297
 				/**
298 298
 				 * @hack Version 1.9
299 299
 				 */
300
-				$field_for_is_post_field = class_exists( 'GF_Fields' ) ? (object) $field : (array) $field;
300
+				$field_for_is_post_field = class_exists( 'GF_Fields' ) ? (object)$field : (array)$field;
301 301
 
302 302
 				if ( GFCommon::is_post_field( $field_for_is_post_field ) ) {
303 303
 					$has_post_fields = true;
@@ -309,7 +309,7 @@  discard block
 block discarded – undo
309 309
 		 * @since 1.7
310 310
 		 */
311 311
 		if ( $has_post_fields ) {
312
-			$fields['post_id'] = array(
312
+			$fields[ 'post_id' ] = array(
313 313
 				'label' => __( 'Post ID', 'gravityview' ),
314 314
 				'type' => 'post_id',
315 315
 			);
@@ -320,10 +320,10 @@  discard block
 block discarded – undo
320 320
 			$payment_fields = GravityView_Fields::get_all( 'pricing' );
321 321
 
322 322
 			foreach ( $payment_fields as $payment_field ) {
323
-				if( isset( $fields["{$payment_field->name}"] ) ) {
323
+				if ( isset( $fields[ "{$payment_field->name}" ] ) ) {
324 324
 					continue;
325 325
 				}
326
-				$fields["{$payment_field->name}"] = array(
326
+				$fields[ "{$payment_field->name}" ] = array(
327 327
 					'label' => $payment_field->label,
328 328
 					'desc' => $payment_field->description,
329 329
 					'type' => $payment_field->name,
@@ -334,24 +334,24 @@  discard block
 block discarded – undo
334 334
 		/**
335 335
 		 * @since 1.8
336 336
 		 */
337
-		if( $has_quiz_fields ) {
337
+		if ( $has_quiz_fields ) {
338 338
 
339
-			$fields['gquiz_score']   = array(
339
+			$fields[ 'gquiz_score' ] = array(
340 340
 				'label' => __( 'Quiz Score Total', 'gravityview' ),
341 341
 				'type'  => 'quiz_score',
342 342
 				'desc'  => __( 'Displays the number of correct Quiz answers the user submitted.', 'gravityview' ),
343 343
 			);
344
-			$fields['gquiz_percent'] = array(
344
+			$fields[ 'gquiz_percent' ] = array(
345 345
 				'label' => __( 'Quiz Percentage Grade', 'gravityview' ),
346 346
 				'type'  => 'quiz_percent',
347 347
 				'desc'  => __( 'Displays the percentage of correct Quiz answers the user submitted.', 'gravityview' ),
348 348
 			);
349
-			$fields['gquiz_grade']   = array(
349
+			$fields[ 'gquiz_grade' ] = array(
350 350
 				'label' => __( 'Quiz Letter Grade', 'gravityview' ),
351 351
 				'type'  => 'quiz_grade',
352 352
 				'desc'  => __( 'Displays the Grade the user achieved based on Letter Grading configured in the Quiz Settings.', 'gravityview' ),
353 353
 			);
354
-			$fields['gquiz_is_pass'] = array(
354
+			$fields[ 'gquiz_is_pass' ] = array(
355 355
 				'label' => __( 'Quiz Pass/Fail', 'gravityview' ),
356 356
 				'type'  => 'quiz_is_pass',
357 357
 				'desc'  => __( 'Displays either Passed or Failed based on the Pass/Fail settings configured in the Quiz Settings.', 'gravityview' ),
@@ -373,9 +373,9 @@  discard block
 block discarded – undo
373 373
 
374 374
 		$fields = array();
375 375
 
376
-		foreach ( $extra_fields as $key => $field ){
377
-			if ( ! empty( $only_default_column ) && ! empty( $field['is_default_column'] ) ) {
378
-				$fields[ $key ] = array( 'label' => $field['label'], 'type' => 'entry_meta' );
376
+		foreach ( $extra_fields as $key => $field ) {
377
+			if ( ! empty( $only_default_column ) && ! empty( $field[ 'is_default_column' ] ) ) {
378
+				$fields[ $key ] = array( 'label' => $field[ 'label' ], 'type' => 'entry_meta' );
379 379
 			}
380 380
 		}
381 381
 
@@ -415,32 +415,32 @@  discard block
 block discarded – undo
415 415
 			'search_criteria' => null,
416 416
 			'sorting' => null,
417 417
 			'paging' => null,
418
-			'cache' => (isset( $passed_criteria['cache'] ) ? $passed_criteria['cache'] : true),
418
+			'cache' => ( isset( $passed_criteria[ 'cache' ] ) ? $passed_criteria[ 'cache' ] : true ),
419 419
 		);
420 420
 
421 421
 		$criteria = wp_parse_args( $passed_criteria, $search_criteria_defaults );
422 422
 
423
-		if ( ! empty( $criteria['search_criteria']['field_filters'] ) ) {
424
-			foreach ( $criteria['search_criteria']['field_filters'] as &$filter ) {
423
+		if ( ! empty( $criteria[ 'search_criteria' ][ 'field_filters' ] ) ) {
424
+			foreach ( $criteria[ 'search_criteria' ][ 'field_filters' ] as &$filter ) {
425 425
 
426 426
 				if ( ! is_array( $filter ) ) {
427 427
 					continue;
428 428
 				}
429 429
 
430 430
 				// By default, we want searches to be wildcard for each field.
431
-				$filter['operator'] = empty( $filter['operator'] ) ? 'contains' : $filter['operator'];
431
+				$filter[ 'operator' ] = empty( $filter[ 'operator' ] ) ? 'contains' : $filter[ 'operator' ];
432 432
 
433 433
 				/**
434 434
 				 * @filter `gravityview_search_operator` Modify the search operator for the field (contains, is, isnot, etc)
435 435
 				 * @param string $operator Existing search operator
436 436
 				 * @param array $filter array with `key`, `value`, `operator`, `type` keys
437 437
 				 */
438
-				$filter['operator'] = apply_filters( 'gravityview_search_operator', $filter['operator'], $filter );
438
+				$filter[ 'operator' ] = apply_filters( 'gravityview_search_operator', $filter[ 'operator' ], $filter );
439 439
 			}
440 440
 
441 441
 			// don't send just the [mode] without any field filter.
442
-			if( count( $criteria['search_criteria']['field_filters'] ) === 1 && array_key_exists( 'mode' , $criteria['search_criteria']['field_filters'] ) ) {
443
-				unset( $criteria['search_criteria']['field_filters']['mode'] );
442
+			if ( count( $criteria[ 'search_criteria' ][ 'field_filters' ] ) === 1 && array_key_exists( 'mode', $criteria[ 'search_criteria' ][ 'field_filters' ] ) ) {
443
+				unset( $criteria[ 'search_criteria' ][ 'field_filters' ][ 'mode' ] );
444 444
 			}
445 445
 
446 446
 		}
@@ -451,21 +451,21 @@  discard block
 block discarded – undo
451 451
 		 * Prepare date formats to be in Gravity Forms DB format;
452 452
 		 * $passed_criteria may include date formats incompatible with Gravity Forms.
453 453
 		 */
454
-		foreach ( array('start_date', 'end_date' ) as $key ) {
454
+		foreach ( array( 'start_date', 'end_date' ) as $key ) {
455 455
 
456
-			if ( ! empty( $criteria['search_criteria'][ $key ] ) ) {
456
+			if ( ! empty( $criteria[ 'search_criteria' ][ $key ] ) ) {
457 457
 
458 458
 				// Use date_create instead of new DateTime so it returns false if invalid date format.
459
-				$date = date_create( $criteria['search_criteria'][ $key ] );
459
+				$date = date_create( $criteria[ 'search_criteria' ][ $key ] );
460 460
 
461 461
 				if ( $date ) {
462 462
 					// Gravity Forms wants dates in the `Y-m-d H:i:s` format.
463
-					$criteria['search_criteria'][ $key ] = $date->format( 'Y-m-d H:i:s' );
463
+					$criteria[ 'search_criteria' ][ $key ] = $date->format( 'Y-m-d H:i:s' );
464 464
 				} else {
465 465
 					// If it's an invalid date, unset it. Gravity Forms freaks out otherwise.
466
-					unset( $criteria['search_criteria'][ $key ] );
466
+					unset( $criteria[ 'search_criteria' ][ $key ] );
467 467
 
468
-					do_action( 'gravityview_log_error', '[filter_get_entries_criteria] '.$key.' Date format not valid:', $criteria['search_criteria'][ $key ] );
468
+					do_action( 'gravityview_log_error', '[filter_get_entries_criteria] ' . $key . ' Date format not valid:', $criteria[ 'search_criteria' ][ $key ] );
469 469
 				}
470 470
 			}
471 471
 		}
@@ -473,12 +473,12 @@  discard block
 block discarded – undo
473 473
 
474 474
 		// When multiple views are embedded, OR single entry, calculate the context view id and send it to the advanced filter
475 475
 		if ( class_exists( 'GravityView_View_Data' ) && GravityView_View_Data::getInstance()->has_multiple_views() || GravityView_frontend::getInstance()->getSingleEntry() ) {
476
-			$criteria['context_view_id'] = GravityView_frontend::getInstance()->get_context_view_id();
476
+			$criteria[ 'context_view_id' ] = GravityView_frontend::getInstance()->get_context_view_id();
477 477
 		} elseif ( 'delete' === RGForms::get( 'action' ) ) {
478
-			$criteria['context_view_id'] = isset( $_GET['view_id'] ) ? $_GET['view_id'] : null;
479
-		} elseif( !isset( $criteria['context_view_id'] ) ) {
478
+			$criteria[ 'context_view_id' ] = isset( $_GET[ 'view_id' ] ) ? $_GET[ 'view_id' ] : null;
479
+		} elseif ( ! isset( $criteria[ 'context_view_id' ] ) ) {
480 480
             // Prevent overriding the Context View ID: Some widgets could set the context_view_id (e.g. Recent Entries widget)
481
-			$criteria['context_view_id'] = null;
481
+			$criteria[ 'context_view_id' ] = null;
482 482
 		}
483 483
 
484 484
 		/**
@@ -487,7 +487,7 @@  discard block
 block discarded – undo
487 487
 		 * @param array $form_ids Forms to search
488 488
 		 * @param int $view_id ID of the view being used to search
489 489
 		 */
490
-		$criteria = apply_filters( 'gravityview_search_criteria', $criteria, $form_ids, $criteria['context_view_id'] );
490
+		$criteria = apply_filters( 'gravityview_search_criteria', $criteria, $form_ids, $criteria[ 'context_view_id' ] );
491 491
 
492 492
 		return (array)$criteria;
493 493
 
@@ -518,7 +518,7 @@  discard block
 block discarded – undo
518 518
 		/** Reduce # of database calls */
519 519
 		add_filter( 'gform_is_encrypted_field', '__return_false' );
520 520
 
521
-		if ( ! empty( $criteria['cache'] ) ) {
521
+		if ( ! empty( $criteria[ 'cache' ] ) ) {
522 522
 
523 523
 			$Cache = new GravityView_Cache( $form_ids, $criteria );
524 524
 
@@ -526,7 +526,7 @@  discard block
 block discarded – undo
526 526
 
527 527
 				// Still update the total count when using cached results
528 528
 				if ( ! is_null( $total ) ) {
529
-					$total = GFAPI::count_entries( $form_ids, $criteria['search_criteria'] );
529
+					$total = GFAPI::count_entries( $form_ids, $criteria[ 'search_criteria' ] );
530 530
 				}
531 531
 
532 532
 				$return = $entries;
@@ -546,9 +546,9 @@  discard block
 block discarded – undo
546 546
 			$entries = apply_filters( 'gravityview_before_get_entries', null, $criteria, $passed_criteria, $total );
547 547
 
548 548
 			// No entries returned from gravityview_before_get_entries
549
-			if( is_null( $entries ) ) {
549
+			if ( is_null( $entries ) ) {
550 550
 
551
-				$entries = GFAPI::get_entries( $form_ids, $criteria['search_criteria'], $criteria['sorting'], $criteria['paging'], $total );
551
+				$entries = GFAPI::get_entries( $form_ids, $criteria[ 'search_criteria' ], $criteria[ 'sorting' ], $criteria[ 'paging' ], $total );
552 552
 
553 553
 				if ( is_wp_error( $entries ) ) {
554 554
 					do_action( 'gravityview_log_error', $entries->get_error_message(), $entries );
@@ -557,7 +557,7 @@  discard block
 block discarded – undo
557 557
 				}
558 558
 			}
559 559
 
560
-			if ( ! empty( $criteria['cache'] ) && isset( $Cache ) ) {
560
+			if ( ! empty( $criteria[ 'cache' ] ) && isset( $Cache ) ) {
561 561
 
562 562
 				// Cache results
563 563
 				$Cache->set( $entries, 'entries' );
@@ -644,7 +644,7 @@  discard block
 block discarded – undo
644 644
 			 */
645 645
 			$check_entry_display = apply_filters( 'gravityview/common/get_entry/check_entry_display', $check_entry_display, $entry );
646 646
 
647
-			if( $check_entry_display ) {
647
+			if ( $check_entry_display ) {
648 648
 				// Is the entry allowed
649 649
 				$entry = self::check_entry_display( $entry );
650 650
 			}
@@ -677,12 +677,12 @@  discard block
 block discarded – undo
677 677
 
678 678
 		$value = false;
679 679
 
680
-		if( 'context' === $val1 ) {
680
+		if ( 'context' === $val1 ) {
681 681
 
682 682
 			$matching_contexts = array( $val2 );
683 683
 
684 684
 			// We allow for non-standard contexts.
685
-			switch( $val2 ) {
685
+			switch ( $val2 ) {
686 686
 				// Check for either single or edit
687 687
 				case 'singular':
688 688
 					$matching_contexts = array( 'single', 'edit' );
@@ -742,7 +742,7 @@  discard block
 block discarded – undo
742 742
 			return false;
743 743
 		}
744 744
 
745
-		if ( empty( $entry['form_id'] ) ) {
745
+		if ( empty( $entry[ 'form_id' ] ) ) {
746 746
 			do_action( 'gravityview_log_debug', '[apply_filters_to_entry] Entry is empty! Entry:', $entry );
747 747
 			return false;
748 748
 		}
@@ -750,26 +750,26 @@  discard block
 block discarded – undo
750 750
 		$criteria = self::calculate_get_entries_criteria();
751 751
 
752 752
 		// Make sure the current View is connected to the same form as the Entry
753
-		if( ! empty( $criteria['context_view_id'] ) ) {
754
-			$context_view_id = intval( $criteria['context_view_id'] );
753
+		if ( ! empty( $criteria[ 'context_view_id' ] ) ) {
754
+			$context_view_id = intval( $criteria[ 'context_view_id' ] );
755 755
 			$context_form_id = gravityview_get_form_id( $context_view_id );
756
-			if( intval( $context_form_id ) !== intval( $entry['form_id'] ) ) {
757
-				do_action( 'gravityview_log_debug', sprintf( '[apply_filters_to_entry] Entry form ID does not match current View connected form ID:', $entry['form_id'] ), $criteria['context_view_id'] );
756
+			if ( intval( $context_form_id ) !== intval( $entry[ 'form_id' ] ) ) {
757
+				do_action( 'gravityview_log_debug', sprintf( '[apply_filters_to_entry] Entry form ID does not match current View connected form ID:', $entry[ 'form_id' ] ), $criteria[ 'context_view_id' ] );
758 758
 				return false;
759 759
 			}
760 760
 		}
761 761
 
762
-		if ( empty( $criteria['search_criteria'] ) || ! is_array( $criteria['search_criteria'] ) ) {
762
+		if ( empty( $criteria[ 'search_criteria' ] ) || ! is_array( $criteria[ 'search_criteria' ] ) ) {
763 763
 			do_action( 'gravityview_log_debug', '[apply_filters_to_entry] Entry approved! No search criteria found:', $criteria );
764 764
 			return $entry;
765 765
 		}
766 766
 
767
-		$search_criteria = $criteria['search_criteria'];
767
+		$search_criteria = $criteria[ 'search_criteria' ];
768 768
 		unset( $criteria );
769 769
 
770 770
 		// check entry status
771
-		if ( array_key_exists( 'status', $search_criteria ) && $search_criteria['status'] != $entry['status'] ) {
772
-			do_action( 'gravityview_log_debug', sprintf( '[apply_filters_to_entry] Entry status - %s - is not valid according to filter:', $entry['status'] ), $search_criteria );
771
+		if ( array_key_exists( 'status', $search_criteria ) && $search_criteria[ 'status' ] != $entry[ 'status' ] ) {
772
+			do_action( 'gravityview_log_debug', sprintf( '[apply_filters_to_entry] Entry status - %s - is not valid according to filter:', $entry[ 'status' ] ), $search_criteria );
773 773
 			return false;
774 774
 		}
775 775
 
@@ -777,37 +777,37 @@  discard block
 block discarded – undo
777 777
 		// @todo: Does it make sense to apply the Date create filters to the single entry?
778 778
 
779 779
 		// field_filters
780
-		if ( empty( $search_criteria['field_filters'] ) || ! is_array( $search_criteria['field_filters'] ) ) {
780
+		if ( empty( $search_criteria[ 'field_filters' ] ) || ! is_array( $search_criteria[ 'field_filters' ] ) ) {
781 781
 			do_action( 'gravityview_log_debug', '[apply_filters_to_entry] Entry approved! No field filters criteria found:', $search_criteria );
782 782
 			return $entry;
783 783
 		}
784 784
 
785
-		$filters = $search_criteria['field_filters'];
785
+		$filters = $search_criteria[ 'field_filters' ];
786 786
 		unset( $search_criteria );
787 787
 
788
-		$mode = array_key_exists( 'mode', $filters ) ? strtolower( $filters['mode'] ) : 'all';
789
-		unset( $filters['mode'] );
788
+		$mode = array_key_exists( 'mode', $filters ) ? strtolower( $filters[ 'mode' ] ) : 'all';
789
+		unset( $filters[ 'mode' ] );
790 790
 
791
-		$form = self::get_form( $entry['form_id'] );
791
+		$form = self::get_form( $entry[ 'form_id' ] );
792 792
 
793 793
 		foreach ( $filters as $filter ) {
794 794
 
795
-			if ( ! isset( $filter['key'] ) ) {
795
+			if ( ! isset( $filter[ 'key' ] ) ) {
796 796
 				continue;
797 797
 			}
798 798
 
799
-			$k = $filter['key'];
799
+			$k = $filter[ 'key' ];
800 800
 
801 801
 			if ( in_array( $k, array( 'created_by', 'payment_status' ) ) ) {
802 802
 				$field_value = $entry[ $k ];
803 803
 				$field = null;
804 804
 			} else {
805 805
 				$field = self::get_field( $form, $k );
806
-				$field_value  = GFFormsModel::get_lead_field_value( $entry, $field );
806
+				$field_value = GFFormsModel::get_lead_field_value( $entry, $field );
807 807
 			}
808 808
 
809
-			$operator = isset( $filter['operator'] ) ? strtolower( $filter['operator'] ) : 'is';
810
-			$is_value_match = GFFormsModel::is_value_match( $field_value, $filter['value'], $operator, $field );
809
+			$operator = isset( $filter[ 'operator' ] ) ? strtolower( $filter[ 'operator' ] ) : 'is';
810
+			$is_value_match = GFFormsModel::is_value_match( $field_value, $filter[ 'value' ], $operator, $field );
811 811
 
812 812
 			// verify if we are already free to go!
813 813
 			if ( ! $is_value_match && 'all' === $mode ) {
@@ -865,25 +865,25 @@  discard block
 block discarded – undo
865 865
 		 * Gravity Forms code to adjust date to locally-configured Time Zone
866 866
 		 * @see GFCommon::format_date() for original code
867 867
 		 */
868
-		$date_gmt_time   = mysql2date( 'G', $date_string );
868
+		$date_gmt_time = mysql2date( 'G', $date_string );
869 869
 		$date_local_timestamp = GFCommon::get_local_timestamp( $date_gmt_time );
870 870
 
871
-		$format  = rgar( $atts, 'format' );
872
-		$is_human  = ! empty( $atts['human'] );
873
-		$is_diff  = ! empty( $atts['diff'] );
874
-		$is_raw = ! empty( $atts['raw'] );
875
-		$is_timestamp = ! empty( $atts['timestamp'] );
876
-		$include_time = ! empty( $atts['time'] );
871
+		$format = rgar( $atts, 'format' );
872
+		$is_human = ! empty( $atts[ 'human' ] );
873
+		$is_diff = ! empty( $atts[ 'diff' ] );
874
+		$is_raw = ! empty( $atts[ 'raw' ] );
875
+		$is_timestamp = ! empty( $atts[ 'timestamp' ] );
876
+		$include_time = ! empty( $atts[ 'time' ] );
877 877
 
878 878
 		// If we're using time diff, we want to have a different default format
879
-		if( empty( $format ) ) {
879
+		if ( empty( $format ) ) {
880 880
 			$format = $is_diff ? esc_html__( '%s ago', 'gravityview' ) : get_option( 'date_format' );
881 881
 		}
882 882
 
883 883
 		// If raw was specified, don't modify the stored value
884 884
 		if ( $is_raw ) {
885 885
 			$formatted_date = $date_string;
886
-		} elseif( $is_timestamp ) {
886
+		} elseif ( $is_timestamp ) {
887 887
 			$formatted_date = $date_local_timestamp;
888 888
 		} elseif ( $is_diff ) {
889 889
 			$formatted_date = sprintf( $format, human_time_diff( $date_gmt_time ) );
@@ -911,7 +911,7 @@  discard block
 block discarded – undo
911 911
 		}
912 912
 
913 913
 		$field = self::get_field( $form, $field_id );
914
-		return isset( $field['label'] ) ?  $field['label'] : '';
914
+		return isset( $field[ 'label' ] ) ? $field[ 'label' ] : '';
915 915
 
916 916
 	}
917 917
 
@@ -929,7 +929,7 @@  discard block
 block discarded – undo
929 929
 	 * @return array|null Array: Gravity Forms field array; NULL: Gravity Forms GFFormsModel does not exist
930 930
 	 */
931 931
 	public static function get_field( $form, $field_id ) {
932
-		if ( class_exists( 'GFFormsModel' ) ){
932
+		if ( class_exists( 'GFFormsModel' ) ) {
933 933
 			return GFFormsModel::get_field( $form, $field_id );
934 934
 		} else {
935 935
 			return null;
@@ -976,17 +976,17 @@  discard block
 block discarded – undo
976 976
 			$shortcodes = array();
977 977
 
978 978
 			preg_match_all( '/' . get_shortcode_regex() . '/s', $content, $matches, PREG_SET_ORDER );
979
-			if ( empty( $matches ) ){
979
+			if ( empty( $matches ) ) {
980 980
 				return false;
981 981
 			}
982 982
 
983 983
 			foreach ( $matches as $shortcode ) {
984
-				if ( $tag === $shortcode[2] ) {
984
+				if ( $tag === $shortcode[ 2 ] ) {
985 985
 
986 986
 					// Changed this to $shortcode instead of true so we get the parsed atts.
987
-					$shortcodes[] = $shortcode;
987
+					$shortcodes[ ] = $shortcode;
988 988
 
989
-				} else if ( isset( $shortcode[5] ) && $result = self::has_shortcode_r( $shortcode[5], $tag ) ) {
989
+				} else if ( isset( $shortcode[ 5 ] ) && $result = self::has_shortcode_r( $shortcode[ 5 ], $tag ) ) {
990 990
 					$shortcodes = $result;
991 991
 				}
992 992
 			}
@@ -1137,7 +1137,7 @@  discard block
 block discarded – undo
1137 1137
 	 * @return string         html
1138 1138
 	 */
1139 1139
 	public static function get_sortable_fields( $formid, $current = '' ) {
1140
-		$output = '<option value="" ' . selected( '', $current, false ).'>' . esc_html__( 'Default', 'gravityview' ) .'</option>';
1140
+		$output = '<option value="" ' . selected( '', $current, false ) . '>' . esc_html__( 'Default', 'gravityview' ) . '</option>';
1141 1141
 
1142 1142
 		if ( empty( $formid ) ) {
1143 1143
 			return $output;
@@ -1150,11 +1150,11 @@  discard block
 block discarded – undo
1150 1150
 			$blacklist_field_types = apply_filters( 'gravityview_blacklist_field_types', array( 'list', 'textarea' ), null );
1151 1151
 
1152 1152
 			foreach ( $fields as $id => $field ) {
1153
-				if ( in_array( $field['type'], $blacklist_field_types ) ) {
1153
+				if ( in_array( $field[ 'type' ], $blacklist_field_types ) ) {
1154 1154
 					continue;
1155 1155
 				}
1156 1156
 
1157
-				$output .= '<option value="'. $id .'" '. selected( $id, $current, false ).'>'. esc_attr( $field['label'] ) .'</option>';
1157
+				$output .= '<option value="' . $id . '" ' . selected( $id, $current, false ) . '>' . esc_attr( $field[ 'label' ] ) . '</option>';
1158 1158
 			}
1159 1159
 		}
1160 1160
 
@@ -1189,9 +1189,9 @@  discard block
 block discarded – undo
1189 1189
 		$blacklist_field_types = apply_filters( 'gravityview_blacklist_field_types', $blacklist, NULL );
1190 1190
 
1191 1191
 		// TODO: Convert to using array_filter
1192
-		foreach( $fields as $id => $field ) {
1192
+		foreach ( $fields as $id => $field ) {
1193 1193
 
1194
-			if( in_array( $field['type'], $blacklist_field_types ) ) {
1194
+			if ( in_array( $field[ 'type' ], $blacklist_field_types ) ) {
1195 1195
 				unset( $fields[ $id ] );
1196 1196
 			}
1197 1197
 		}
@@ -1232,14 +1232,14 @@  discard block
 block discarded – undo
1232 1232
 	 * @param  int|array  $field field key or field array
1233 1233
 	 * @return boolean
1234 1234
 	 */
1235
-	public static function is_field_numeric(  $form = null, $field = '' ) {
1235
+	public static function is_field_numeric( $form = null, $field = '' ) {
1236 1236
 
1237 1237
 		if ( ! is_array( $form ) && ! is_array( $field ) ) {
1238 1238
 			$form = self::get_form( $form );
1239 1239
 		}
1240 1240
 
1241 1241
 		// If entry meta, it's a string. Otherwise, numeric
1242
-		if( ! is_numeric( $field ) && is_string( $field ) ) {
1242
+		if ( ! is_numeric( $field ) && is_string( $field ) ) {
1243 1243
 			$type = $field;
1244 1244
 		} else {
1245 1245
 			$type = self::get_field_type( $form, $field );
@@ -1253,9 +1253,9 @@  discard block
 block discarded – undo
1253 1253
 		$numeric_types = apply_filters( 'gravityview/common/numeric_types', array( 'number', 'time' ) );
1254 1254
 
1255 1255
 		// Defer to GravityView_Field setting, if the field type is registered and `is_numeric` is true
1256
-		if( $gv_field = GravityView_Fields::get( $type ) ) {
1257
-			if( true === $gv_field->is_numeric ) {
1258
-				$numeric_types[] = $gv_field->is_numeric;
1256
+		if ( $gv_field = GravityView_Fields::get( $type ) ) {
1257
+			if ( true === $gv_field->is_numeric ) {
1258
+				$numeric_types[ ] = $gv_field->is_numeric;
1259 1259
 			}
1260 1260
 		}
1261 1261
 
@@ -1405,11 +1405,11 @@  discard block
 block discarded – undo
1405 1405
 		$final_atts = array_filter( $final_atts );
1406 1406
 
1407 1407
 		// If the href wasn't passed as an attribute, use the value passed to the function
1408
-		if ( empty( $final_atts['href'] ) && ! empty( $href ) ) {
1409
-			$final_atts['href'] = $href;
1408
+		if ( empty( $final_atts[ 'href' ] ) && ! empty( $href ) ) {
1409
+			$final_atts[ 'href' ] = $href;
1410 1410
 		}
1411 1411
 
1412
-		$final_atts['href'] = esc_url_raw( $href );
1412
+		$final_atts[ 'href' ] = esc_url_raw( $href );
1413 1413
 
1414 1414
 		// Sort the attributes alphabetically, to help testing
1415 1415
 		ksort( $final_atts );
@@ -1420,7 +1420,7 @@  discard block
 block discarded – undo
1420 1420
 			$output .= sprintf( ' %s="%s"', $attr, esc_attr( $value ) );
1421 1421
 		}
1422 1422
 
1423
-		if( '' !== $output ) {
1423
+		if ( '' !== $output ) {
1424 1424
 			$output = '<a' . $output . '>' . $anchor_text . '</a>';
1425 1425
 		}
1426 1426
 
@@ -1444,7 +1444,7 @@  discard block
 block discarded – undo
1444 1444
 	public static function array_merge_recursive_distinct( array &$array1, array &$array2 ) {
1445 1445
 		$merged = $array1;
1446 1446
 
1447
-		foreach ( $array2 as $key => &$value )  {
1447
+		foreach ( $array2 as $key => &$value ) {
1448 1448
 			if ( is_array( $value ) && isset( $merged[ $key ] ) && is_array( $merged[ $key ] ) ) {
1449 1449
 				$merged[ $key ] = self::array_merge_recursive_distinct( $merged[ $key ], $value );
1450 1450
 			} else {
@@ -1479,7 +1479,7 @@  discard block
 block discarded – undo
1479 1479
 		 * `$context` is where are we using this information (e.g. change_entry_creator, search_widget ..)
1480 1480
 		 * @param array $settings Settings array, with `number` key defining the # of users to display
1481 1481
 		 */
1482
-		$get_users_settings = apply_filters( 'gravityview/get_users/'. $context, apply_filters( 'gravityview_change_entry_creator_user_parameters', $get_users_settings ) );
1482
+		$get_users_settings = apply_filters( 'gravityview/get_users/' . $context, apply_filters( 'gravityview_change_entry_creator_user_parameters', $get_users_settings ) );
1483 1483
 
1484 1484
 		return get_users( $get_users_settings );
1485 1485
 	}
@@ -1494,7 +1494,7 @@  discard block
 block discarded – undo
1494 1494
      * @return string
1495 1495
      */
1496 1496
     public static function generate_notice( $notice, $class = '' ) {
1497
-        return '<div class="gv-notice '.gravityview_sanitize_html_class( $class ) .'">'. $notice .'</div>';
1497
+        return '<div class="gv-notice ' . gravityview_sanitize_html_class( $class ) . '">' . $notice . '</div>';
1498 1498
     }
1499 1499
 
1500 1500
 
Please login to merge, or discard this patch.
includes/class-admin-approve-entries.php 1 patch
Spacing   +72 added lines, -72 removed lines patch added patch discarded remove patch
@@ -34,19 +34,19 @@  discard block
 block discarded – undo
34 34
 		/** gf_entries page - entries table screen */
35 35
 
36 36
 		// capture bulk actions
37
-		add_action( 'init', array( $this, 'process_bulk_action') );
37
+		add_action( 'init', array( $this, 'process_bulk_action' ) );
38 38
 		// add hidden field with approve status
39 39
 		add_action( 'gform_entries_first_column', array( $this, 'add_entry_approved_hidden_input' ), 1, 5 );
40 40
 		// process ajax approve entry requests
41
-		add_action('wp_ajax_gv_update_approved', array( $this, 'ajax_update_approved'));
41
+		add_action( 'wp_ajax_gv_update_approved', array( $this, 'ajax_update_approved' ) );
42 42
 
43 43
 		// in case entry is edited (on admin or frontend)
44
-		add_action( 'gform_after_update_entry', array( $this, 'after_update_entry_update_approved_meta' ), 10, 2);
44
+		add_action( 'gform_after_update_entry', array( $this, 'after_update_entry_update_approved_meta' ), 10, 2 );
45 45
 
46 46
 		add_filter( 'gravityview_tooltips', array( $this, 'tooltips' ) );
47 47
 
48 48
 		// adding styles and scripts
49
-		add_action( 'admin_enqueue_scripts', array( $this, 'add_scripts_and_styles') );
49
+		add_action( 'admin_enqueue_scripts', array( $this, 'add_scripts_and_styles' ) );
50 50
 		// bypass Gravity Forms no-conflict mode
51 51
 		add_filter( 'gform_noconflict_scripts', array( $this, 'register_gform_noconflict_script' ) );
52 52
 		add_filter( 'gform_noconflict_styles', array( $this, 'register_gform_noconflict_style' ) );
@@ -61,9 +61,9 @@  discard block
 block discarded – undo
61 61
 	 */
62 62
 	function tooltips( $tooltips ) {
63 63
 
64
-		$tooltips['form_gravityview_fields'] = array(
65
-			'title' => __('GravityView Fields', 'gravityview'),
66
-			'value' => __( 'Allow administrators to approve or reject entries and users to opt-in or opt-out of their entries being displayed.', 'gravityview'),
64
+		$tooltips[ 'form_gravityview_fields' ] = array(
65
+			'title' => __( 'GravityView Fields', 'gravityview' ),
66
+			'value' => __( 'Allow administrators to approve or reject entries and users to opt-in or opt-out of their entries being displayed.', 'gravityview' ),
67 67
 		);
68 68
 
69 69
 		return $tooltips;
@@ -178,12 +178,12 @@  discard block
 block discarded – undo
178 178
 		}
179 179
 
180 180
 		// gforms_update_note is sent when bulk editing entry notes. We don't want to process then.
181
-		if ( 'bulk' === RGForms::post( 'action' ) && empty( $_POST['gforms_update_note'] ) ) {
181
+		if ( 'bulk' === RGForms::post( 'action' ) && empty( $_POST[ 'gforms_update_note' ] ) ) {
182 182
 
183 183
 			check_admin_referer( 'gforms_entry_list', 'gforms_entry_list' );
184 184
 
185 185
 			// The action is formatted like: approve-16 or disapprove-16, where the first word is the name of the action and the second is the ID of the form. Bulk action 2 is the bottom bulk action select form.
186
-			$bulk_action = ! empty( $_POST['bulk_action'] ) ? $_POST['bulk_action'] : $_POST['bulk_action2'];
186
+			$bulk_action = ! empty( $_POST[ 'bulk_action' ] ) ? $_POST[ 'bulk_action' ] : $_POST[ 'bulk_action2' ];
187 187
 
188 188
 			/**
189 189
 			 * The extra '-' is to make sure that there are at *least* two items in array.
@@ -199,13 +199,13 @@  discard block
 block discarded – undo
199 199
 			}
200 200
 
201 201
 			// All entries are set to be updated, not just the visible ones
202
-			if ( ! empty( $_POST['all_entries'] ) ) {
202
+			if ( ! empty( $_POST[ 'all_entries' ] ) ) {
203 203
 
204 204
 				// Convert the current entry search into GF-formatted search criteria
205 205
 				$search = array(
206
-					'search_field' => isset( $_POST['f'] ) ? $_POST['f'][0] : 0,
207
-					'search_value' => isset( $_POST['v'][0] ) ? $_POST['v'][0] : '',
208
-					'search_operator' => isset( $_POST['o'][0] ) ? $_POST['o'][0] : 'contains',
206
+					'search_field' => isset( $_POST[ 'f' ] ) ? $_POST[ 'f' ][ 0 ] : 0,
207
+					'search_value' => isset( $_POST[ 'v' ][ 0 ] ) ? $_POST[ 'v' ][ 0 ] : '',
208
+					'search_operator' => isset( $_POST[ 'o' ][ 0 ] ) ? $_POST[ 'o' ][ 0 ] : 'contains',
209 209
 				);
210 210
 
211 211
 				$search_criteria = GravityView_frontend::get_search_criteria( $search, $form_id );
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
 
216 216
 			} else {
217 217
 
218
-				$entries = $_POST['lead'];
218
+				$entries = $_POST[ 'lead' ];
219 219
 
220 220
 			}
221 221
 
@@ -256,12 +256,12 @@  discard block
 block discarded – undo
256 256
 	 */
257 257
 	private static function update_bulk( $entries, $approved, $form_id ) {
258 258
 
259
-		if( empty($entries) || ( $entries !== true && !is_array($entries) ) ) {
259
+		if ( empty( $entries ) || ( $entries !== true && ! is_array( $entries ) ) ) {
260 260
 			do_action( 'gravityview_log_error', __METHOD__ . ' Entries were empty or malformed.', $entries );
261 261
 			return false;
262 262
 		}
263 263
 
264
-		if( ! GVCommon::has_cap( 'gravityview_moderate_entries' ) ) {
264
+		if ( ! GVCommon::has_cap( 'gravityview_moderate_entries' ) ) {
265 265
 			do_action( 'gravityview_log_error', __METHOD__ . ' User does not have the `gravityview_moderate_entries` capability.' );
266 266
 			return false;
267 267
 		}
@@ -271,7 +271,7 @@  discard block
 block discarded – undo
271 271
 		// calculate approved field id
272 272
 		$approved_column_id = self::get_approved_column( $form_id );
273 273
 
274
-		foreach( $entries as $entry_id ) {
274
+		foreach ( $entries as $entry_id ) {
275 275
 			self::update_approved( (int)$entry_id, $approved, $form_id, $approved_column_id );
276 276
 		}
277 277
 	}
@@ -290,14 +290,14 @@  discard block
 block discarded – undo
290 290
 	 * @param int $approvedcolumn (default: 0)
291 291
 	 * @return boolean True: It worked; False: it failed
292 292
 	 */
293
-	public static function update_approved( $entry_id = 0, $approved = 0, $form_id = 0, $approvedcolumn = 0) {
293
+	public static function update_approved( $entry_id = 0, $approved = 0, $form_id = 0, $approvedcolumn = 0 ) {
294 294
 
295
-		if( !class_exists( 'GFAPI' ) ) {
295
+		if ( ! class_exists( 'GFAPI' ) ) {
296 296
 			do_action( 'gravityview_log_error', __METHOD__ . 'GFAPI does not exist' );
297 297
 			return false;
298 298
 		}
299 299
 
300
-		if( empty( $approvedcolumn ) ) {
300
+		if ( empty( $approvedcolumn ) ) {
301 301
 			$approvedcolumn = self::get_approved_column( $form_id );
302 302
 		}
303 303
 
@@ -316,10 +316,10 @@  discard block
 block discarded – undo
316 316
 		self::update_approved_meta( $entry_id, $approved );
317 317
 
318 318
 		// add note to entry
319
-		if( $result === true ) {
319
+		if ( $result === true ) {
320 320
 			$note = empty( $approved ) ? __( 'Disapproved the Entry for GravityView', 'gravityview' ) : __( 'Approved the Entry for GravityView', 'gravityview' );
321 321
 
322
-			if( class_exists( 'GravityView_Entry_Notes' ) ){
322
+			if ( class_exists( 'GravityView_Entry_Notes' ) ) {
323 323
 				global $current_user;
324 324
       			get_currentuserinfo();
325 325
 				GravityView_Entry_Notes::add_note( $entry_id, $current_user->ID, $current_user->display_name, $note );
@@ -332,7 +332,7 @@  discard block
 block discarded – undo
332 332
 			 */
333 333
 			do_action( 'gravityview_clear_form_cache', $form_id );
334 334
 
335
-		} else if( is_wp_error( $result ) ) {
335
+		} else if ( is_wp_error( $result ) ) {
336 336
 
337 337
 			do_action( 'gravityview_log_error', __METHOD__ . sprintf( ' - Entry approval not updated: %s', $result->get_error_message() ) );
338 338
 
@@ -354,12 +354,12 @@  discard block
 block discarded – undo
354 354
 	 */
355 355
 	public static function after_update_entry_update_approved_meta( $form, $entry_id = NULL ) {
356 356
 
357
-		$approvedcolumn = self::get_approved_column( $form['id'] );
357
+		$approvedcolumn = self::get_approved_column( $form[ 'id' ] );
358 358
 
359 359
         /**
360 360
          * If the form doesn't contain the approve field, don't assume anything.
361 361
          */
362
-        if( empty( $approvedcolumn ) ) {
362
+        if ( empty( $approvedcolumn ) ) {
363 363
             return;
364 364
         }
365 365
 
@@ -381,7 +381,7 @@  discard block
 block discarded – undo
381 381
 	private static function update_approved_meta( $entry_id, $is_approved ) {
382 382
 
383 383
 		// update entry meta
384
-		if( function_exists('gform_update_meta') ) {
384
+		if ( function_exists( 'gform_update_meta' ) ) {
385 385
 
386 386
 			gform_update_meta( $entry_id, 'is_approved', $is_approved );
387 387
 
@@ -393,7 +393,7 @@  discard block
 block discarded – undo
393 393
 			 */
394 394
 			do_action( 'gravityview/approve_entries/updated', $entry_id, $is_approved );
395 395
 
396
-			if( empty( $is_approved ) ) {
396
+			if ( empty( $is_approved ) ) {
397 397
 
398 398
 				/**
399 399
 				 * @action `gravityview/approve_entries/disapproved` Triggered when an entry is rejected
@@ -415,7 +415,7 @@  discard block
 block discarded – undo
415 415
 
416 416
 		} else {
417 417
 
418
-			do_action('gravityview_log_error', __METHOD__ . ' - `gform_update_meta` does not exist.' );
418
+			do_action( 'gravityview_log_error', __METHOD__ . ' - `gform_update_meta` does not exist.' );
419 419
 
420 420
 		}
421 421
 	}
@@ -427,21 +427,21 @@  discard block
 block discarded – undo
427 427
 	 */
428 428
 	public function ajax_update_approved() {
429 429
 
430
-		if( empty( $_POST['entry_id'] ) || empty( $_POST['form_id'] ) ) {
430
+		if ( empty( $_POST[ 'entry_id' ] ) || empty( $_POST[ 'form_id' ] ) ) {
431 431
 
432 432
 			do_action( 'gravityview_log_error', __METHOD__ . ' entry_id or form_id are empty.', $_POST );
433 433
 
434 434
 			$result = false;
435 435
 		}
436 436
 
437
-		else if ( ! isset( $_POST['nonce'] ) || ! wp_verify_nonce( $_POST['nonce'], 'gravityview_ajaxgfentries' ) ) {
437
+		else if ( ! isset( $_POST[ 'nonce' ] ) || ! wp_verify_nonce( $_POST[ 'nonce' ], 'gravityview_ajaxgfentries' ) ) {
438 438
 
439 439
 			do_action( 'gravityview_log_error', __METHOD__ . ' Security check failed.', $_POST );
440 440
 
441 441
 			$result = false;
442 442
 		}
443 443
 
444
-		else if( ! GVCommon::has_cap( 'gravityview_moderate_entries', $_POST['entry_id'] ) ) {
444
+		else if ( ! GVCommon::has_cap( 'gravityview_moderate_entries', $_POST[ 'entry_id' ] ) ) {
445 445
 
446 446
 			do_action( 'gravityview_log_error', __METHOD__ . ' User does not have the `gravityview_moderate_entries` capability.' );
447 447
 
@@ -450,11 +450,11 @@  discard block
 block discarded – undo
450 450
 
451 451
 		else {
452 452
 
453
-			$result = self::update_approved( $_POST['entry_id'], $_POST['approved'], $_POST['form_id'] );
453
+			$result = self::update_approved( $_POST[ 'entry_id' ], $_POST[ 'approved' ], $_POST[ 'form_id' ] );
454 454
 
455
-			if( is_wp_error( $result ) ) {
455
+			if ( is_wp_error( $result ) ) {
456 456
 				/** @var WP_Error $result */
457
-				do_action( 'gravityview_log_error', __METHOD__ .' Error updating approval: ' . $result->get_error_message() );
457
+				do_action( 'gravityview_log_error', __METHOD__ . ' Error updating approval: ' . $result->get_error_message() );
458 458
 				$result = false;
459 459
 			}
460 460
 
@@ -474,29 +474,29 @@  discard block
 block discarded – undo
474 474
 	 */
475 475
 	static public function get_approved_column( $form ) {
476 476
 
477
-        if( empty( $form ) ) {
477
+        if ( empty( $form ) ) {
478 478
             return null;
479 479
         }
480 480
 
481
-        if( !is_array( $form ) ) {
481
+        if ( ! is_array( $form ) ) {
482 482
             $form = GVCommon::get_form( $form );
483 483
         }
484 484
 
485
-		foreach( $form['fields'] as $key => $field ) {
485
+		foreach ( $form[ 'fields' ] as $key => $field ) {
486 486
 
487
-            $field = (array) $field;
487
+            $field = (array)$field;
488 488
 
489
-			if( !empty( $field['gravityview_approved'] ) ) {
490
-				if( !empty($field['inputs'][0]['id']) ) {
491
-					return $field['inputs'][0]['id'];
489
+			if ( ! empty( $field[ 'gravityview_approved' ] ) ) {
490
+				if ( ! empty( $field[ 'inputs' ][ 0 ][ 'id' ] ) ) {
491
+					return $field[ 'inputs' ][ 0 ][ 'id' ];
492 492
 				}
493 493
 			}
494 494
 
495 495
             // Note: This is just for backward compatibility from GF Directory plugin and old GV versions - when using i18n it may not work..
496
-            if( 'checkbox' == $field['type'] && isset( $field['inputs'] ) && is_array( $field['inputs'] ) ) {
497
-                foreach ( $field['inputs'] as $key2 => $input ) {
498
-                    if ( strtolower( $input['label'] ) == 'approved' ) {
499
-                        return $input['id'];
496
+            if ( 'checkbox' == $field[ 'type' ] && isset( $field[ 'inputs' ] ) && is_array( $field[ 'inputs' ] ) ) {
497
+                foreach ( $field[ 'inputs' ] as $key2 => $input ) {
498
+                    if ( strtolower( $input[ 'label' ] ) == 'approved' ) {
499
+                        return $input[ 'id' ];
500 500
                     }
501 501
                 }
502 502
             }
@@ -507,18 +507,18 @@  discard block
 block discarded – undo
507 507
 
508 508
 
509 509
 
510
-	static public function add_entry_approved_hidden_input(  $form_id, $field_id, $value, $entry, $query_string ) {
510
+	static public function add_entry_approved_hidden_input( $form_id, $field_id, $value, $entry, $query_string ) {
511 511
 
512
-		if( ! GVCommon::has_cap( 'gravityview_moderate_entries', $entry['id'] ) ) {
512
+		if ( ! GVCommon::has_cap( 'gravityview_moderate_entries', $entry[ 'id' ] ) ) {
513 513
 			return;
514 514
 		}
515 515
 
516
-		if( empty( $entry['id'] ) ) {
516
+		if ( empty( $entry[ 'id' ] ) ) {
517 517
 			return;
518 518
 		}
519 519
 
520
-		if( gform_get_meta( $entry['id'], 'is_approved' ) ) {
521
-			echo '<input type="hidden" class="entry_approved" id="entry_approved_'. $entry['id'] .'" value="true" />';
520
+		if ( gform_get_meta( $entry[ 'id' ], 'is_approved' ) ) {
521
+			echo '<input type="hidden" class="entry_approved" id="entry_approved_' . $entry[ 'id' ] . '" value="true" />';
522 522
 		}
523 523
 	}
524 524
 
@@ -527,7 +527,7 @@  discard block
 block discarded – undo
527 527
 
528 528
 	function add_scripts_and_styles( $hook ) {
529 529
 
530
-		if( !class_exists( 'RGForms' ) ) {
530
+		if ( ! class_exists( 'RGForms' ) ) {
531 531
 
532 532
 			do_action( 'gravityview_log_error', 'GravityView_Admin_ApproveEntries[add_scripts_and_styles] RGForms does not exist.' );
533 533
 
@@ -536,39 +536,39 @@  discard block
 block discarded – undo
536 536
 
537 537
 		// enqueue styles & scripts gf_entries
538 538
 		// But only if we're on the main Entries page, not on reports pages
539
-		if( RGForms::get_page() === 'entry_list' ) {
539
+		if ( RGForms::get_page() === 'entry_list' ) {
540 540
 
541
-			$form_id = RGForms::get('id');
541
+			$form_id = RGForms::get( 'id' );
542 542
 
543 543
 			// If there are no forms identified, use the first form. That's how GF does it.
544
-			if( empty( $form_id ) && class_exists('RGFormsModel') ) {
544
+			if ( empty( $form_id ) && class_exists( 'RGFormsModel' ) ) {
545 545
 				$forms = gravityview_get_forms();
546
-				if( !empty( $forms ) ) {
547
-					$form_id = $forms[0]['id'];
546
+				if ( ! empty( $forms ) ) {
547
+					$form_id = $forms[ 0 ][ 'id' ];
548 548
 				}
549 549
 			}
550 550
 
551 551
 			$approvedcolumn = self::get_approved_column( $form_id );
552 552
 
553
-			wp_register_style( 'gravityview_entries_list', plugins_url('assets/css/admin-entries-list.css', GRAVITYVIEW_FILE), array(), GravityView_Plugin::version );
553
+			wp_register_style( 'gravityview_entries_list', plugins_url( 'assets/css/admin-entries-list.css', GRAVITYVIEW_FILE ), array(), GravityView_Plugin::version );
554 554
 			wp_enqueue_style( 'gravityview_entries_list' );
555 555
 
556
-			$script_debug = (defined('SCRIPT_DEBUG') && SCRIPT_DEBUG) ? '' : '.min';
556
+			$script_debug = ( defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ) ? '' : '.min';
557 557
 
558
-			wp_register_script( 'gravityview_gf_entries_scripts', plugins_url('assets/js/admin-entries-list'.$script_debug.'.js', GRAVITYVIEW_FILE), array( 'jquery' ), GravityView_Plugin::version );
558
+			wp_register_script( 'gravityview_gf_entries_scripts', plugins_url( 'assets/js/admin-entries-list' . $script_debug . '.js', GRAVITYVIEW_FILE ), array( 'jquery' ), GravityView_Plugin::version );
559 559
 			wp_enqueue_script( 'gravityview_gf_entries_scripts' );
560 560
 
561 561
 			wp_localize_script( 'gravityview_gf_entries_scripts', 'gvGlobals', array(
562
-				'nonce' => wp_create_nonce( 'gravityview_ajaxgfentries'),
562
+				'nonce' => wp_create_nonce( 'gravityview_ajaxgfentries' ),
563 563
 				'form_id' => $form_id,
564 564
 				'show_column' => (int)$this->show_approve_entry_column( $form_id ),
565 565
 				'add_bulk_action' => (int)GVCommon::has_cap( 'gravityview_moderate_entries' ),
566 566
 				'bulk_actions' => $this->get_bulk_actions( $form_id ),
567 567
 				'bulk_message' => $this->bulk_update_message,
568
-				'approve_title' => __( 'Entry not approved for directory viewing. Click to approve this entry.', 'gravityview'),
569
-				'unapprove_title' => __( 'Entry approved for directory viewing. Click to disapprove this entry.', 'gravityview'),
570
-				'column_title' => __( 'Show entry in directory view?', 'gravityview'),
571
-				'column_link' => esc_url( add_query_arg( array('sort' => $approvedcolumn) ) ),
568
+				'approve_title' => __( 'Entry not approved for directory viewing. Click to approve this entry.', 'gravityview' ),
569
+				'unapprove_title' => __( 'Entry approved for directory viewing. Click to disapprove this entry.', 'gravityview' ),
570
+				'column_title' => __( 'Show entry in directory view?', 'gravityview' ),
571
+				'column_link' => esc_url( add_query_arg( array( 'sort' => $approvedcolumn ) ) ),
572 572
 			) );
573 573
 
574 574
 		}
@@ -611,8 +611,8 @@  discard block
 block discarded – undo
611 611
 		// Sanitize the values, just to be sure.
612 612
 		foreach ( $bulk_actions as $key => $group ) {
613 613
 			foreach ( $group as $i => $action ) {
614
-				$bulk_actions[ $key ][ $i ]['label'] = esc_html( $bulk_actions[ $key ][ $i ]['label'] );
615
-				$bulk_actions[ $key ][ $i ]['value'] = esc_attr( $bulk_actions[ $key ][ $i ]['value'] );
614
+				$bulk_actions[ $key ][ $i ][ 'label' ] = esc_html( $bulk_actions[ $key ][ $i ][ 'label' ] );
615
+				$bulk_actions[ $key ][ $i ][ 'value' ] = esc_attr( $bulk_actions[ $key ][ $i ][ 'value' ] );
616 616
 			}
617 617
 		}
618 618
 
@@ -637,13 +637,13 @@  discard block
 block discarded – undo
637 637
 		 * @since 1.7.2
638 638
 		 * @param boolean $hide_if_no_connections
639 639
 		 */
640
-		$hide_if_no_connections = apply_filters('gravityview/approve_entries/hide-if-no-connections', false );
640
+		$hide_if_no_connections = apply_filters( 'gravityview/approve_entries/hide-if-no-connections', false );
641 641
 
642
-		if( $hide_if_no_connections ) {
642
+		if ( $hide_if_no_connections ) {
643 643
 
644 644
 			$connected_views = gravityview_get_connected_views( $form_id );
645 645
 
646
-			if( empty( $connected_views ) ) {
646
+			if ( empty( $connected_views ) ) {
647 647
 				$show_approve_column = false;
648 648
 			}
649 649
 		}
@@ -653,18 +653,18 @@  discard block
 block discarded – undo
653 653
 		 * @param boolean $show_approve_column Whether the column will be shown
654 654
 		 * @param int $form_id The ID of the Gravity Forms form for which entries are being shown
655 655
 		 */
656
-		$show_approve_column = apply_filters('gravityview/approve_entries/show-column', $show_approve_column, $form_id );
656
+		$show_approve_column = apply_filters( 'gravityview/approve_entries/show-column', $show_approve_column, $form_id );
657 657
 
658 658
 		return $show_approve_column;
659 659
 	}
660 660
 
661 661
 	function register_gform_noconflict_script( $scripts ) {
662
-		$scripts[] = 'gravityview_gf_entries_scripts';
662
+		$scripts[ ] = 'gravityview_gf_entries_scripts';
663 663
 		return $scripts;
664 664
 	}
665 665
 
666 666
 	function register_gform_noconflict_style( $styles ) {
667
-		$styles[] = 'gravityview_entries_list';
667
+		$styles[ ] = 'gravityview_entries_list';
668 668
 		return $styles;
669 669
 	}
670 670
 
Please login to merge, or discard this patch.