gravityview / GravityView

includes/class-common.php

Spacing +82 added lines, -82 removed lines

@@ -146,7 +146,7 @@ 
 		$form = false;
 
 		if ( $entry ) {
-			$form = GFAPI::get_form( $entry['form_id'] );
+			$form = GFAPI::get_form( $entry[ 'form_id' ] );
 		}
 
 		return $form;
@@ -222,7 +222,7 @@ 
 			}
 		}
 
-		return (bool) $has_transaction_data;
+		return (bool)$has_transaction_data;
 	}
 
 	/**
@@ -260,7 +260,7 @@ 
 
 		$results = GFAPI::get_entries( intval( $form_id ), $search_criteria, null, $paging );
 
-		$result = ( ! empty( $results ) && ! empty( $results[0]['id'] ) ) ? $results[0]['id'] : null;
+		$result = ( ! empty( $results ) && ! empty( $results[ 0 ][ 'id' ] ) ) ? $results[ 0 ][ 'id' ] : null;
 
 		return $result;
 	}
@@ -295,11 +295,11 @@ 
 		foreach ( $forms as $form ) {
 
 			// Catch if the form is false, if GFFormsModel::get_form_ids() returns a form ID that doesn't exist.
-			if ( ! isset( $form['id'], $form['title'] ) ) {
+			if ( ! isset( $form[ 'id' ], $form[ 'title' ] ) ) {
 				continue;
 			}
 
-			$options[ (int) $form['id'] ] = esc_html( $form['title'] );
+			$options[ (int)$form[ 'id' ] ] = esc_html( $form[ 'title' ] );
 		}
 
 		return $options;
@@ -358,9 +358,9 @@ 
 		$has_post_fields    = false;
 
 		if ( $form ) {
-			foreach ( $form['fields'] as $field ) {
-				if ( $include_parent_field || empty( $field['inputs'] ) ) {
-					$fields[ "{$field['id']}" ] = array(
+			foreach ( $form[ 'fields' ] as $field ) {
+				if ( $include_parent_field || empty( $field[ 'inputs' ] ) ) {
+					$fields[ "{$field[ 'id' ]}" ] = array(
 						'label'      => \GV\Utils::get( $field, 'label' ),
 						'parent'     => null,
 						'type'       => \GV\Utils::get( $field, 'type' ),
@@ -369,10 +369,10 @@ 
 					);
 				}
 
-				if ( $add_default_properties && ! empty( $field['inputs'] ) ) {
-					foreach ( $field['inputs'] as $input ) {
+				if ( $add_default_properties && ! empty( $field[ 'inputs' ] ) ) {
+					foreach ( $field[ 'inputs' ] as $input ) {
 
-						if ( ! empty( $input['isHidden'] ) ) {
+						if ( ! empty( $input[ 'isHidden' ] ) ) {
 							continue;
 						}
 
@@ -380,10 +380,10 @@ 
 						 * @hack
 						 * In case of email/email confirmation, the input for email has the same id as the parent field
 						 */
-						if ( 'email' === $field['type'] && false === strpos( $input['id'], '.' ) ) {
+						if ( 'email' === $field[ 'type' ] && false === strpos( $input[ 'id' ], '.' ) ) {
 							continue;
 						}
-						$fields[ "{$input['id']}" ] = array(
+						$fields[ "{$input[ 'id' ]}" ] = array(
 							'label'       => \GV\Utils::get( $input, 'label' ),
 							'customLabel' => \GV\Utils::get( $input, 'customLabel' ),
 							'parent'      => $field,
@@ -394,7 +394,7 @@ 
 					}
 				}
 
-				if ( GFCommon::is_product_field( $field['type'] ) ) {
+				if ( GFCommon::is_product_field( $field[ 'type' ] ) ) {
 					$has_product_fields = true;
 				}
 
@@ -408,7 +408,7 @@ 
 		 * @since 1.7
 		 */
 		if ( $has_post_fields ) {
-			$fields['post_id'] = array(
+			$fields[ 'post_id' ] = array(
 				'label' => __( 'Post ID', 'gk-gravityview' ),
 				'type'  => 'post_id',
 			);
@@ -459,9 +459,9 @@ 
 		$fields = array();
 
 		foreach ( $extra_fields as $key => $field ) {
-			if ( ! empty( $only_default_column ) && ! empty( $field['is_default_column'] ) ) {
+			if ( ! empty( $only_default_column ) && ! empty( $field[ 'is_default_column' ] ) ) {
 				$fields[ $key ] = array(
-					'label' => $field['label'],
+					'label' => $field[ 'label' ],
 					'type'  => 'entry_meta',
 				);
 			}
@@ -503,33 +503,33 @@ 
 			'search_criteria' => null,
 			'sorting'         => null,
 			'paging'          => null,
-			'cache'           => ( isset( $passed_criteria['cache'] ) ? (bool) $passed_criteria['cache'] : true ),
+			'cache'           => ( isset( $passed_criteria[ 'cache' ] ) ? (bool)$passed_criteria[ 'cache' ] : true ),
 			'context_view_id' => null,
 		);
 
 		$criteria = wp_parse_args( $passed_criteria, $search_criteria_defaults );
 
-		if ( ! empty( $criteria['search_criteria']['field_filters'] ) && is_array( $criteria['search_criteria']['field_filters'] ) ) {
-			foreach ( $criteria['search_criteria']['field_filters'] as &$filter ) {
+		if ( ! empty( $criteria[ 'search_criteria' ][ 'field_filters' ] ) && is_array( $criteria[ 'search_criteria' ][ 'field_filters' ] ) ) {
+			foreach ( $criteria[ 'search_criteria' ][ 'field_filters' ] as &$filter ) {
 
 				if ( ! is_array( $filter ) ) {
 					continue;
 				}
 
 				// By default, we want searches to be wildcard for each field.
-				$filter['operator'] = empty( $filter['operator'] ) ? 'contains' : $filter['operator'];
+				$filter[ 'operator' ] = empty( $filter[ 'operator' ] ) ? 'contains' : $filter[ 'operator' ];
 
 				/**
 				 * @filter `gravityview_search_operator` Modify the search operator for the field (contains, is, isnot, etc)
 				 * @param string $operator Existing search operator
 				 * @param array $filter array with `key`, `value`, `operator`, `type` keys
 				 */
-				$filter['operator'] = apply_filters( 'gravityview_search_operator', $filter['operator'], $filter );
+				$filter[ 'operator' ] = apply_filters( 'gravityview_search_operator', $filter[ 'operator' ], $filter );
 			}
 
 			// don't send just the [mode] without any field filter.
-			if ( count( $criteria['search_criteria']['field_filters'] ) === 1 && array_key_exists( 'mode', $criteria['search_criteria']['field_filters'] ) ) {
-				unset( $criteria['search_criteria']['field_filters']['mode'] );
+			if ( count( $criteria[ 'search_criteria' ][ 'field_filters' ] ) === 1 && array_key_exists( 'mode', $criteria[ 'search_criteria' ][ 'field_filters' ] ) ) {
+				unset( $criteria[ 'search_criteria' ][ 'field_filters' ][ 'mode' ] );
 			}
 		}
 
@@ -539,37 +539,37 @@ 
 		 */
 		foreach ( array( 'start_date', 'end_date' ) as $key ) {
 
-			if ( ! empty( $criteria['search_criteria'][ $key ] ) ) {
+			if ( ! empty( $criteria[ 'search_criteria' ][ $key ] ) ) {
 
 				// Use date_create instead of new DateTime so it returns false if invalid date format.
-				$date = date_create( $criteria['search_criteria'][ $key ] );
+				$date = date_create( $criteria[ 'search_criteria' ][ $key ] );
 
 				if ( $date ) {
 					// Gravity Forms wants dates in the `Y-m-d H:i:s` format.
-					$criteria['search_criteria'][ $key ] = $date->format( 'Y-m-d H:i:s' );
+					$criteria[ 'search_criteria' ][ $key ] = $date->format( 'Y-m-d H:i:s' );
 				} else {
 					gravityview()->log->error(
 						'{key} Date format not valid:',
 						array(
 							'key' => $key,
-							$criteria['search_criteria'][ $key ],
+							$criteria[ 'search_criteria' ][ $key ],
 						)
 					);
 
 					// If it's an invalid date, unset it. Gravity Forms freaks out otherwise.
-					unset( $criteria['search_criteria'][ $key ] );
+					unset( $criteria[ 'search_criteria' ][ $key ] );
 				}
 			}
 		}
 
-		if ( empty( $criteria['context_view_id'] ) ) {
+		if ( empty( $criteria[ 'context_view_id' ] ) ) {
 			// Calculate the context view id and send it to the advanced filter
 			if ( GravityView_frontend::getInstance()->getSingleEntry() ) {
-				$criteria['context_view_id'] = GravityView_frontend::getInstance()->get_context_view_id();
+				$criteria[ 'context_view_id' ] = GravityView_frontend::getInstance()->get_context_view_id();
 			} elseif ( class_exists( 'GravityView_View_Data' ) && GravityView_View_Data::getInstance() && GravityView_View_Data::getInstance()->has_multiple_views() ) {
-				$criteria['context_view_id'] = GravityView_frontend::getInstance()->get_context_view_id();
+				$criteria[ 'context_view_id' ] = GravityView_frontend::getInstance()->get_context_view_id();
 			} elseif ( 'delete' === GFForms::get( 'action' ) ) {
-				$criteria['context_view_id'] = isset( $_GET['view_id'] ) ? intval( $_GET['view_id'] ) : null;
+				$criteria[ 'context_view_id' ] = isset( $_GET[ 'view_id' ] ) ? intval( $_GET[ 'view_id' ] ) : null;
 			}
 		}
 
@@ -579,9 +579,9 @@ 
 		 * @param array $form_ids Forms to search
 		 * @param int $view_id ID of the view being used to search
 		 */
-		$criteria = apply_filters( 'gravityview_search_criteria', $criteria, $form_ids, $criteria['context_view_id'] );
+		$criteria = apply_filters( 'gravityview_search_criteria', $criteria, $form_ids, $criteria[ 'context_view_id' ] );
 
-		return (array) $criteria;
+		return (array)$criteria;
 	}
 
 
@@ -613,7 +613,7 @@ 
 		/** Reduce # of database calls */
 		add_filter( 'gform_is_encrypted_field', '__return_false' );
 
-		if ( ! empty( $criteria['cache'] ) ) {
+		if ( ! empty( $criteria[ 'cache' ] ) ) {
 
 			$Cache = new GravityView_Cache( $form_ids, $criteria );
 
@@ -621,7 +621,7 @@ 
 
 				// Still update the total count when using cached results
 				if ( ! is_null( $total ) ) {
-					$total = GFAPI::count_entries( $form_ids, $criteria['search_criteria'] );
+					$total = GFAPI::count_entries( $form_ids, $criteria[ 'search_criteria' ] );
 				}
 
 				$return = $entries;
@@ -645,7 +645,7 @@ 
 			// No entries returned from gravityview_before_get_entries
 			if ( is_null( $entries ) ) {
 
-				$entries = GFAPI::get_entries( $form_ids, $criteria['search_criteria'], $criteria['sorting'], $criteria['paging'], $total );
+				$entries = GFAPI::get_entries( $form_ids, $criteria[ 'search_criteria' ], $criteria[ 'sorting' ], $criteria[ 'paging' ], $total );
 
 				if ( is_wp_error( $entries ) ) {
 					gravityview()->log->error(
@@ -662,7 +662,7 @@ 
 				}
 			}
 
-			if ( ! empty( $criteria['cache'] ) && isset( $Cache ) ) {
+			if ( ! empty( $criteria[ 'cache' ] ) && isset( $Cache ) ) {
 
 				// Cache results
 				$Cache->set( $entries, 'entries' );
@@ -848,8 +848,8 @@ 
 
 		// If both are timestamps, cast to string so we can use the > and < comparisons below.
 		if ( $timestamp_1 && $timestamp_2 ) {
-			$val1 = (string) $timestamp_1;
-			$val2 = (string) $timestamp_2;
+			$val1 = (string)$timestamp_1;
+			$val2 = (string)$timestamp_2;
 		}
 
 		switch ( $operation ) {
@@ -883,8 +883,8 @@ 
 				if ( ! empty( $json_val_1 ) || ! empty( $json_val_2 ) ) {
 
 					$json_in    = false;
-					$json_val_1 = $json_val_1 ? (array) $json_val_1 : array( $val1 );
-					$json_val_2 = $json_val_2 ? (array) $json_val_2 : array( $val2 );
+					$json_val_1 = $json_val_1 ? (array)$json_val_1 : array( $val1 );
+					$json_val_2 = $json_val_2 ? (array)$json_val_2 : array( $val2 );
 
 					// For JSON, we want to compare as "in" or "not in" rather than "contains"
 					foreach ( $json_val_1 as $item_1 ) {
@@ -945,7 +945,7 @@ 
 			return new WP_Error( 'entry_not_found', 'Entry was not found.', $entry );
 		}
 
-		if ( empty( $entry['form_id'] ) ) {
+		if ( empty( $entry[ 'form_id' ] ) ) {
 			return new WP_Error( 'form_id_not_set', '[apply_filters_to_entry] Entry is empty!', $entry );
 		}
 
@@ -960,19 +960,19 @@ 
 
 		$_gvid = \GV\Utils::_GET( 'gvid' );
 
-		if ( $_gvid && $view->ID !== (int) $_gvid ) {
+		if ( $_gvid && $view->ID !== (int)$_gvid ) {
 			return new WP_Error( 'view_id_not_match_gvid', 'View does not match passed $_GET["gvid"].', $view->ID );
 		}
 
 		$view_form_id = $view->form->ID;
 
 		if ( $view->joins ) {
-			if ( in_array( (int) $entry['form_id'], array_keys( $view::get_joined_forms( $view->ID ) ), true ) ) {
-				$view_form_id = $entry['form_id'];
+			if ( in_array( (int)$entry[ 'form_id' ], array_keys( $view::get_joined_forms( $view->ID ) ), true ) ) {
+				$view_form_id = $entry[ 'form_id' ];
 			}
 		}
 
-		if ( (int) $view_form_id !== (int) $entry['form_id'] ) {
+		if ( (int)$view_form_id !== (int)$entry[ 'form_id' ] ) {
 			return new WP_Error( 'view_id_not_match', 'View form source does not match entry form source ID.', $entry );
 		}
 
@@ -990,7 +990,7 @@ 
 							array(
 								'key'       => 'id',
 								'operation' => 'is',
-								'value'     => $entry['id'],
+								'value'     => $entry[ 'id' ],
 							),
 						),
 					)
@@ -1001,7 +1001,7 @@ 
 				/** @type \GF_Query $query */
 				$query_parts = $query->_introspect();
 
-				$query->where( \GF_Query_Condition::_and( $_tmp_query_parts['where'], $query_parts['where'] ) );
+				$query->where( \GF_Query_Condition::_and( $_tmp_query_parts[ 'where' ], $query_parts[ 'where' ] ) );
 
 			},
 			10,
@@ -1013,7 +1013,7 @@ 
 			'gravityview_search_criteria',
 			$remove_pagenum = function( $criteria ) {
 
-				$criteria['paging'] = array(
+				$criteria[ 'paging' ] = array(
 					'offset'    => 0,
 					'page_size' => 25,
 				);
@@ -1033,19 +1033,19 @@ 
 		}
 
 		// This entry is on a View with joins
-		if ( $entries[0]->is_multi() ) {
+		if ( $entries[ 0 ]->is_multi() ) {
 
 			$multi_entry_ids = array();
 
-			foreach ( $entries[0]->entries as $multi_entry ) {
-				$multi_entry_ids[] = (int) $multi_entry->ID;
+			foreach ( $entries[ 0 ]->entries as $multi_entry ) {
+				$multi_entry_ids[ ] = (int)$multi_entry->ID;
 			}
 
-			if ( ! in_array( (int) $entry['id'], $multi_entry_ids, true ) ) {
+			if ( ! in_array( (int)$entry[ 'id' ], $multi_entry_ids, true ) ) {
 				remove_action( 'gravityview/view/query', $entry_subset_callback );
 				return new \WP_Error( 'failed_criteria', 'Entry failed search_criteria and field_filters' );
 			}
-		} elseif ( (int) $entries[0]->ID !== (int) $entry['id'] ) {
+		} elseif ( (int)$entries[ 0 ]->ID !== (int)$entry[ 'id' ] ) {
 			remove_action( 'gravityview/view/query', $entry_subset_callback );
 			return new \WP_Error( 'failed_criteria', 'Entry failed search_criteria and field_filters' );
 		}
@@ -1095,11 +1095,11 @@ 
 		$date_local_timestamp = GFCommon::get_local_timestamp( $date_gmt_time );
 
 		$format       = \GV\Utils::get( $atts, 'format' );
-		$is_human     = ! empty( $atts['human'] );
-		$is_diff      = ! empty( $atts['diff'] );
-		$is_raw       = ! empty( $atts['raw'] );
-		$is_timestamp = ! empty( $atts['timestamp'] );
-		$include_time = ! empty( $atts['time'] );
+		$is_human     = ! empty( $atts[ 'human' ] );
+		$is_diff      = ! empty( $atts[ 'diff' ] );
+		$is_raw       = ! empty( $atts[ 'raw' ] );
+		$is_timestamp = ! empty( $atts[ 'timestamp' ] );
+		$include_time = ! empty( $atts[ 'time' ] );
 
 		// If we're using time diff, we want to have a different default format
 		if ( empty( $format ) ) {
@@ -1217,14 +1217,14 @@ 
 			}
 
 			foreach ( $matches as $shortcode ) {
-				if ( $tag === $shortcode[2] ) {
+				if ( $tag === $shortcode[ 2 ] ) {
 
 					// Changed this to $shortcode instead of true so we get the parsed atts.
-					$shortcodes[] = $shortcode;
+					$shortcodes[ ] = $shortcode;
 
-				} elseif ( isset( $shortcode[5] ) && $results = self::has_shortcode_r( $shortcode[5], $tag ) ) {
+				} elseif ( isset( $shortcode[ 5 ] ) && $results = self::has_shortcode_r( $shortcode[ 5 ], $tag ) ) {
 					foreach ( $results as $result ) {
-						$shortcodes[] = $result;
+						$shortcodes[ ] = $result;
 					}
 				}
 			}
@@ -1256,7 +1256,7 @@ 
 			'post_type'      => 'gravityview',
 			'posts_per_page' => 100,
 			'meta_key'       => '_gravityview_form_id',
-			'meta_value'     => (int) $form_id,
+			'meta_value'     => (int)$form_id,
 		);
 		$args     = wp_parse_args( $args, $defaults );
 		$views    = get_posts( $args );
@@ -1273,8 +1273,8 @@ 
 			}
 
 			foreach ( $data as $datum ) {
-				if ( ! empty( $datum[2] ) && (int) $datum[2] === (int) $form_id ) {
-					$joined_forms[] = $view->post_id;
+				if ( ! empty( $datum[ 2 ] ) && (int)$datum[ 2 ] === (int)$form_id ) {
+					$joined_forms[ ] = $view->post_id;
 				}
 			}
 		}
@@ -1282,10 +1282,10 @@ 
 		if ( $joined_forms ) {
 			$joined_args = array(
 				'post_type'      => 'gravityview',
-				'posts_per_page' => $args['posts_per_page'],
+				'posts_per_page' => $args[ 'posts_per_page' ],
 				'post__in'       => $joined_forms,
 			);
-			$views       = array_merge( $views, get_posts( $joined_args ) );
+			$views = array_merge( $views, get_posts( $joined_args ) );
 		}
 
 		return $views;
@@ -1329,7 +1329,7 @@ 
 
 		if ( class_exists( '\GV\View_Settings' ) ) {
 
-			return wp_parse_args( (array) $settings, \GV\View_Settings::defaults() );
+			return wp_parse_args( (array)$settings, \GV\View_Settings::defaults() );
 
 		}
 
@@ -1475,11 +1475,11 @@ 
 			$blocklist_field_types = apply_filters( 'gravityview_blocklist_field_types', $blocklist_field_types, null );
 
 			foreach ( $fields as $id => $field ) {
-				if ( in_array( $field['type'], $blocklist_field_types ) ) {
+				if ( in_array( $field[ 'type' ], $blocklist_field_types ) ) {
 					continue;
 				}
 
-				$output .= '<option value="' . $id . '" ' . selected( $id, $current, false ) . '>' . esc_attr( $field['label'] ) . '</option>';
+				$output .= '<option value="' . $id . '" ' . selected( $id, $current, false ) . '>' . esc_attr( $field[ 'label' ] ) . '</option>';
 			}
 		}
 
@@ -1524,14 +1524,14 @@ 
 		// TODO: Convert to using array_filter
 		foreach ( $fields as $id => $field ) {
 
-			if ( in_array( $field['type'], $blocklist_field_types ) ) {
+			if ( in_array( $field[ 'type' ], $blocklist_field_types ) ) {
 				unset( $fields[ $id ] );
 			}
 
 			/**
 			 * Merge date and time subfields.
 			 */
-			if ( in_array( $field['type'], array( 'date', 'time' ) ) && ! empty( $field['parent'] ) ) {
+			if ( in_array( $field[ 'type' ], array( 'date', 'time' ) ) && ! empty( $field[ 'parent' ] ) ) {
 				$fields[ intval( $id ) ] = array(
 					'label'      => \GV\Utils::get( $field, 'parent/label' ),
 					'parent'     => null,
@@ -1605,7 +1605,7 @@ 
 		// Defer to GravityView_Field setting, if the field type is registered and `is_numeric` is true
 		if ( $gv_field = GravityView_Fields::get( $type ) ) {
 			if ( true === $gv_field->is_numeric ) {
-				$numeric_types[] = $gv_field->is_numeric;
+				$numeric_types[ ] = $gv_field->is_numeric;
 			}
 		}
 
@@ -1757,12 +1757,12 @@ 
 		$final_atts = array_filter( $final_atts );
 
 		// If the href wasn't passed as an attribute, use the value passed to the function
-		if ( empty( $final_atts['href'] ) && ! empty( $href ) ) {
-			$final_atts['href'] = $href;
+		if ( empty( $final_atts[ 'href' ] ) && ! empty( $href ) ) {
+			$final_atts[ 'href' ] = $href;
 		}
 
-		if ( isset( $final_atts['href'] ) ) {
-			$final_atts['href'] = esc_url_raw( $final_atts['href'] );
+		if ( isset( $final_atts[ 'href' ] ) ) {
+			$final_atts[ 'href' ] = esc_url_raw( $final_atts[ 'href' ] );
 		}
 
 		/**
@@ -1771,7 +1771,7 @@ 
 		 * @see https://dev.to/ben/the-targetblank-vulnerability-by-example
 		 */
 		if ( '_blank' === \GV\Utils::get( $final_atts, 'target' ) ) {
-			$final_atts['rel'] = trim( \GV\Utils::get( $final_atts, 'rel', '' ) . ' noopener noreferrer' );
+			$final_atts[ 'rel' ] = trim( \GV\Utils::get( $final_atts, 'rel', '' ) . ' noopener noreferrer' );
 		}
 
 		// Sort the attributes alphabetically, to help testing
@@ -1810,7 +1810,7 @@ 
 			if ( is_array( $value ) && isset( $merged[ $key ] ) && is_array( $merged[ $key ] ) ) {
 				$merged[ $key ] = self::array_merge_recursive_distinct( $merged[ $key ], $value );
 			} elseif ( is_numeric( $key ) && isset( $merged[ $key ] ) ) {
-				$merged[] = $value;
+				$merged[ ] = $value;
 			} else {
 				$merged[ $key ] = $value;
 			}