Completed
Push — develop ( cef228...0db488 )
by Zack
07:44
created
includes/class-api.php 1 patch
Spacing   +112 added lines, -112 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
 
32 32
 		$form = $gravityview_view->getForm();
33 33
 
34
-		if ( defined( 'DOING_GRAVITYVIEW_TESTS' ) && ! empty( $GLOBALS['GravityView_API_field_label_override'] ) ) {
34
+		if ( defined( 'DOING_GRAVITYVIEW_TESTS' ) && ! empty( $GLOBALS[ 'GravityView_API_field_label_override' ] ) ) {
35 35
 			/** Allow to fall through for back compatibility testing purposes. */
36 36
 		} else {
37 37
 			return \GV\Mocks\GravityView_API_field_label( $form, $field, $entry, $force_show_label );
@@ -39,29 +39,29 @@  discard block
 block discarded – undo
39 39
 
40 40
 		$label = '';
41 41
 
42
-		if( !empty( $field['show_label'] ) || $force_show_label ) {
42
+		if ( ! empty( $field[ 'show_label' ] ) || $force_show_label ) {
43 43
 
44
-			$label = $field['label'];
44
+			$label = $field[ 'label' ];
45 45
 
46 46
 			// Support Gravity Forms 1.9+
47
-			if( class_exists( 'GF_Field' ) ) {
47
+			if ( class_exists( 'GF_Field' ) ) {
48 48
 
49
-				$field_object = RGFormsModel::get_field( $form, $field['id'] );
49
+				$field_object = RGFormsModel::get_field( $form, $field[ 'id' ] );
50 50
 
51
-				if( $field_object ) {
51
+				if ( $field_object ) {
52 52
 
53
-					$input = GFFormsModel::get_input( $field_object, $field['id'] );
53
+					$input = GFFormsModel::get_input( $field_object, $field[ 'id' ] );
54 54
 
55 55
 					// This is a complex field, with labels on a per-input basis
56
-					if( $input ) {
56
+					if ( $input ) {
57 57
 
58 58
 						// Does the input have a custom label on a per-input basis? Otherwise, default label.
59
-						$label = ! empty( $input['customLabel'] ) ? $input['customLabel'] : $input['label'];
59
+						$label = ! empty( $input[ 'customLabel' ] ) ? $input[ 'customLabel' ] : $input[ 'label' ];
60 60
 
61 61
 					} else {
62 62
 
63 63
 						// This is a field with one label
64
-						$label = $field_object->get_field_label( true, $field['label'] );
64
+						$label = $field_object->get_field_label( true, $field[ 'label' ] );
65 65
 
66 66
 					}
67 67
 
@@ -70,9 +70,9 @@  discard block
 block discarded – undo
70 70
 			}
71 71
 
72 72
 			// Use Gravity Forms label by default, but if a custom label is defined in GV, use it.
73
-			if ( !empty( $field['custom_label'] ) ) {
73
+			if ( ! empty( $field[ 'custom_label' ] ) ) {
74 74
 
75
-				$label = self::replace_variables( $field['custom_label'], $form, $entry );
75
+				$label = self::replace_variables( $field[ 'custom_label' ], $form, $entry );
76 76
 
77 77
 			}
78 78
 
@@ -134,11 +134,11 @@  discard block
 block discarded – undo
134 134
 
135 135
 		$width = NULL;
136 136
 
137
-		if( !empty( $field['width'] ) ) {
138
-			$width = absint( $field['width'] );
137
+		if ( ! empty( $field[ 'width' ] ) ) {
138
+			$width = absint( $field[ 'width' ] );
139 139
 
140 140
 			// If using percentages, limit to 100%
141
-			if( '%d%%' === $format && $width > 100 ) {
141
+			if ( '%d%%' === $format && $width > 100 ) {
142 142
 				$width = 100;
143 143
 			}
144 144
 
@@ -159,42 +159,42 @@  discard block
 block discarded – undo
159 159
 	public static function field_class( $field, $form = NULL, $entry = NULL ) {
160 160
 		$classes = array();
161 161
 
162
-		if( !empty( $field['custom_class'] ) ) {
162
+		if ( ! empty( $field[ 'custom_class' ] ) ) {
163 163
 
164
-            $custom_class = $field['custom_class'];
164
+            $custom_class = $field[ 'custom_class' ];
165 165
 
166
-            if( !empty( $entry ) ) {
166
+            if ( ! empty( $entry ) ) {
167 167
 
168 168
                 // We want the merge tag to be formatted as a class. The merge tag may be
169 169
                 // replaced by a multiple-word value that should be output as a single class.
170 170
                 // "Office Manager" will be formatted as `.OfficeManager`, not `.Office` and `.Manager`
171
-                add_filter('gform_merge_tag_filter', 'sanitize_html_class');
171
+                add_filter( 'gform_merge_tag_filter', 'sanitize_html_class' );
172 172
 
173
-                $custom_class = self::replace_variables( $custom_class, $form, $entry);
173
+                $custom_class = self::replace_variables( $custom_class, $form, $entry );
174 174
 
175 175
                 // And then we want life to return to normal
176
-                remove_filter('gform_merge_tag_filter', 'sanitize_html_class');
176
+                remove_filter( 'gform_merge_tag_filter', 'sanitize_html_class' );
177 177
             }
178 178
 
179 179
 			// And now we want the spaces to be handled nicely.
180
-			$classes[] = gravityview_sanitize_html_class( $custom_class );
180
+			$classes[ ] = gravityview_sanitize_html_class( $custom_class );
181 181
 
182 182
 		}
183 183
 
184
-		if(!empty($field['id'])) {
185
-			if( !empty( $form ) && !empty( $form['id'] ) ) {
186
-				$form_id = '-'.$form['id'];
184
+		if ( ! empty( $field[ 'id' ] ) ) {
185
+			if ( ! empty( $form ) && ! empty( $form[ 'id' ] ) ) {
186
+				$form_id = '-' . $form[ 'id' ];
187 187
 			} else {
188 188
 				// @deprecated path. Form should always be given.
189 189
 				gravityview()->log->warning( 'GravityView_View::getInstance() legacy API called' );
190 190
 				$gravityview_view = GravityView_View::getInstance();
191
-				$form_id = $gravityview_view->getFormId() ? '-'. $gravityview_view->getFormId() : '';
191
+				$form_id = $gravityview_view->getFormId() ? '-' . $gravityview_view->getFormId() : '';
192 192
 			}
193 193
 
194
-			$classes[] = 'gv-field'.$form_id.'-'.$field['id'];
194
+			$classes[ ] = 'gv-field' . $form_id . '-' . $field[ 'id' ];
195 195
 		}
196 196
 
197
-		return esc_attr(implode(' ', $classes));
197
+		return esc_attr( implode( ' ', $classes ) );
198 198
 	}
199 199
 
200 200
 	/**
@@ -210,11 +210,11 @@  discard block
 block discarded – undo
210 210
 	 * @return string Sanitized unique HTML `id` attribute for the field
211 211
 	 */
212 212
 	public static function field_html_attr_id( $field, $form = array(), $entry = array() ) {
213
-		$id = $field['id'];
213
+		$id = $field[ 'id' ];
214 214
 
215 215
 		if ( ! empty( $id ) ) {
216
-			if ( ! empty( $form ) && ! empty( $form['id'] ) ) {
217
-				$form_id = '-' . $form['id'];
216
+			if ( ! empty( $form ) && ! empty( $form[ 'id' ] ) ) {
217
+				$form_id = '-' . $form[ 'id' ];
218 218
 			} else {
219 219
 				// @deprecated path. Form should always be given.
220 220
 				gravityview()->log->warning( 'GravityView_View::getInstance() legacy API called' );
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
 				$form_id = $gravityview_view->getFormId() ? '-' . $gravityview_view->getFormId() : '';
223 223
 			}
224 224
 
225
-			$id = 'gv-field' . $form_id . '-' . $field['id'];
225
+			$id = 'gv-field' . $form_id . '-' . $field[ 'id' ];
226 226
 		}
227 227
 
228 228
 		return esc_attr( $id );
@@ -262,14 +262,14 @@  discard block
 block discarded – undo
262 262
 	 */
263 263
 	public static function entry_link_html( $entry = array(), $anchor_text = '', $passed_tag_atts = array(), $field_settings = array(), $base_id = null ) {
264 264
 
265
-		if ( empty( $entry ) || ! is_array( $entry ) || ! isset( $entry['id'] ) ) {
265
+		if ( empty( $entry ) || ! is_array( $entry ) || ! isset( $entry[ 'id' ] ) ) {
266 266
 			gravityview()->log->debug( 'Entry not defined; returning null', array( 'data' => $entry ) );
267 267
 			return NULL;
268 268
 		}
269 269
 
270 270
 		$href = self::entry_link( $entry, $base_id );
271 271
 
272
-		if( '' === $href ) {
272
+		if ( '' === $href ) {
273 273
 			return NULL;
274 274
 		}
275 275
 
@@ -306,7 +306,7 @@  discard block
 block discarded – undo
306 306
 		} else {
307 307
 			$gravityview_view = GravityView_View::getInstance();
308 308
 
309
-			if( $gravityview_view && ( $gravityview_view->curr_start || $gravityview_view->curr_end || $gravityview_view->curr_search ) ) {
309
+			if ( $gravityview_view && ( $gravityview_view->curr_start || $gravityview_view->curr_end || $gravityview_view->curr_search ) ) {
310 310
 				$is_search = true;
311 311
 			}
312 312
 		}
@@ -317,7 +317,7 @@  discard block
 block discarded – undo
317 317
 
318 318
 			$output = esc_html__( 'This search returned no results.', 'gravityview' );
319 319
 
320
-			if( $context ) {
320
+			if ( $context ) {
321 321
 				$setting = $context->view->settings->get( 'no_search_results_text', $output );
322 322
 			}
323 323
 
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
325 325
 
326 326
 			$output = esc_html__( 'No entries match your request.', 'gravityview' );
327 327
 
328
-			if( $context ) {
328
+			if ( $context ) {
329 329
 				$setting = $context->view->settings->get( 'no_results_text', $output );
330 330
 			}
331 331
 		}
@@ -443,9 +443,9 @@  discard block
 block discarded – undo
443 443
 
444 444
 		// If we've saved the permalink in memory, use it
445 445
 		// @since 1.3
446
-		$link = wp_cache_get( 'gv_directory_link_'.$post_id );
446
+		$link = wp_cache_get( 'gv_directory_link_' . $post_id );
447 447
 
448
-		if ( (int) $post_id === (int) get_option( 'page_on_front' ) ) {
448
+		if ( (int)$post_id === (int)get_option( 'page_on_front' ) ) {
449 449
 			$link = home_url();
450 450
 		}
451 451
 
@@ -454,7 +454,7 @@  discard block
 block discarded – undo
454 454
 
455 455
 			// If not yet saved, cache the permalink.
456 456
 			// @since 1.3
457
-			wp_cache_set( 'gv_directory_link_'.$post_id, $link );
457
+			wp_cache_set( 'gv_directory_link_' . $post_id, $link );
458 458
 		}
459 459
 
460 460
 		// Deal with returning to proper pagination for embedded views
@@ -462,13 +462,13 @@  discard block
 block discarded – undo
462 462
 
463 463
 			$args = array();
464 464
 
465
-			if( $pagenum = \GV\Utils::_GET( 'pagenum' ) ) {
466
-				$args['pagenum'] = intval( $pagenum );
465
+			if ( $pagenum = \GV\Utils::_GET( 'pagenum' ) ) {
466
+				$args[ 'pagenum' ] = intval( $pagenum );
467 467
 			}
468 468
 
469
-			if( $sort = \GV\Utils::_GET( 'sort' ) ) {
470
-				$args['sort'] = $sort;
471
-				$args['dir'] = \GV\Utils::_GET( 'dir' );
469
+			if ( $sort = \GV\Utils::_GET( 'sort' ) ) {
470
+				$args[ 'sort' ] = $sort;
471
+				$args[ 'dir' ] = \GV\Utils::_GET( 'dir' );
472 472
 			}
473 473
 
474 474
 			$link = add_query_arg( $args, $link );
@@ -505,7 +505,7 @@  discard block
 block discarded – undo
505 505
 	private static function get_custom_entry_slug( $id, $entry = array() ) {
506 506
 
507 507
 		// Generate an unique hash to use as the default value
508
-		$slug = substr( wp_hash( $id, 'gravityview'.$id ), 0, 8 );
508
+		$slug = substr( wp_hash( $id, 'gravityview' . $id ), 0, 8 );
509 509
 
510 510
 		/**
511 511
 		 * @filter `gravityview_entry_slug` Modify the unique hash ID generated, if you want to improve usability or change the format. This will allow for custom URLs, such as `{entryid}-{first-name}` or even, if unique, `{first-name}-{last-name}`
@@ -516,7 +516,7 @@  discard block
 block discarded – undo
516 516
 		$slug = apply_filters( 'gravityview_entry_slug', $slug, $id, $entry );
517 517
 
518 518
 		// Make sure we have something - use the original ID as backup.
519
-		if( empty( $slug ) ) {
519
+		if ( empty( $slug ) ) {
520 520
 			$slug = $id;
521 521
 		}
522 522
 
@@ -610,15 +610,15 @@  discard block
 block discarded – undo
610 610
          * @param boolean $custom Should we process the custom entry slug?
611 611
          */
612 612
         $custom = apply_filters( 'gravityview_custom_entry_slug', false );
613
-        if( $custom ) {
613
+        if ( $custom ) {
614 614
             // create the gravityview_unique_id and save it
615 615
 
616 616
             // Get the entry hash
617
-            $hash = self::get_custom_entry_slug( $entry['id'], $entry );
617
+            $hash = self::get_custom_entry_slug( $entry[ 'id' ], $entry );
618 618
 
619
-	        gravityview()->log->debug( 'Setting hash for entry {entry_id}: {hash}', array( 'entry_id' => $entry['id'], 'hash' => $hash ) );
619
+	        gravityview()->log->debug( 'Setting hash for entry {entry_id}: {hash}', array( 'entry_id' => $entry[ 'id' ], 'hash' => $hash ) );
620 620
 
621
-            gform_update_meta( $entry['id'], 'gravityview_unique_id', $hash, \GV\Utils::get( $entry, 'form_id' ) );
621
+            gform_update_meta( $entry[ 'id' ], 'gravityview_unique_id', $hash, \GV\Utils::get( $entry, 'form_id' ) );
622 622
 
623 623
         }
624 624
     }
@@ -643,7 +643,7 @@  discard block
 block discarded – undo
643 643
 
644 644
 		if ( ! empty( $entry ) && ! is_array( $entry ) ) {
645 645
 			$entry = GVCommon::get_entry( $entry );
646
-		} else if( empty( $entry ) ) {
646
+		} else if ( empty( $entry ) ) {
647 647
 			// @deprecated path
648 648
 			$entry = GravityView_frontend::getInstance()->getEntry();
649 649
 		}
@@ -663,38 +663,38 @@  discard block
 block discarded – undo
663 663
 
664 664
 		$query_arg_name = \GV\Entry::get_endpoint_name();
665 665
 
666
-		if ( ! empty( $entry['_multi'] ) ) {
666
+		if ( ! empty( $entry[ '_multi' ] ) ) {
667 667
 			$entry_slugs = array();
668 668
 
669
-			foreach ( $entry['_multi'] as $_multi ) {
669
+			foreach ( $entry[ '_multi' ] as $_multi ) {
670 670
 
671
-				if( $gv_multi = \GV\GF_Entry::from_entry( $_multi ) ) {
672
-					$entry_slugs[] = $gv_multi->get_slug();
671
+				if ( $gv_multi = \GV\GF_Entry::from_entry( $_multi ) ) {
672
+					$entry_slugs[ ] = $gv_multi->get_slug();
673 673
 				} else {
674 674
 					// TODO: This path isn't covered by unit tests
675
-					$entry_slugs[] = \GravityView_API::get_entry_slug( $_multi['id'], $_multi );
675
+					$entry_slugs[ ] = \GravityView_API::get_entry_slug( $_multi[ 'id' ], $_multi );
676 676
 				}
677 677
 
678 678
 				unset( $gv_multi );
679 679
 
680
-				$forms[] = $_multi['form_id'];
680
+				$forms[ ] = $_multi[ 'form_id' ];
681 681
 			}
682 682
 
683 683
 			$entry_slug = implode( ',', $entry_slugs );
684 684
 		} else {
685 685
 
686 686
 			// Fallback when
687
-			if( $gv_entry = \GV\GF_Entry::from_entry( $entry ) ) {
687
+			if ( $gv_entry = \GV\GF_Entry::from_entry( $entry ) ) {
688 688
 				$entry_slug = $gv_entry->get_slug();
689 689
 			} else {
690 690
 				// TODO: This path isn't covered by unit tests
691
-				$entry_slug = \GravityView_API::get_entry_slug( $entry['id'], $entry );
691
+				$entry_slug = \GravityView_API::get_entry_slug( $entry[ 'id' ], $entry );
692 692
 			}
693 693
 
694 694
 			unset( $gv_entry );
695 695
 		}
696 696
 
697
-		if ( get_option('permalink_structure') && !is_preview() ) {
697
+		if ( get_option( 'permalink_structure' ) && ! is_preview() ) {
698 698
 
699 699
 			$args = array();
700 700
 
@@ -704,9 +704,9 @@  discard block
 block discarded – undo
704 704
 			 */
705 705
 			$link_parts = explode( '?', $directory_link );
706 706
 
707
-			$query = !empty( $link_parts[1] ) ? '?'.$link_parts[1] : '';
707
+			$query = ! empty( $link_parts[ 1 ] ) ? '?' . $link_parts[ 1 ] : '';
708 708
 
709
-			$directory_link = trailingslashit( $link_parts[0] ) . $query_arg_name . '/'. $entry_slug .'/' . $query;
709
+			$directory_link = trailingslashit( $link_parts[ 0 ] ) . $query_arg_name . '/' . $entry_slug . '/' . $query;
710 710
 
711 711
 		} else {
712 712
 
@@ -718,21 +718,21 @@  discard block
 block discarded – undo
718 718
 		 */
719 719
 		if ( $add_directory_args ) {
720 720
 
721
-			if ( ! empty( $_GET['pagenum'] ) ) {
722
-				$args['pagenum'] = intval( $_GET['pagenum'] );
721
+			if ( ! empty( $_GET[ 'pagenum' ] ) ) {
722
+				$args[ 'pagenum' ] = intval( $_GET[ 'pagenum' ] );
723 723
 			}
724 724
 
725 725
 			/**
726 726
 			 * @since 1.7
727 727
 			 */
728 728
 			if ( $sort = \GV\Utils::_GET( 'sort' ) ) {
729
-				$args['sort'] = $sort;
730
-				$args['dir'] = \GV\Utils::_GET( 'dir' );
729
+				$args[ 'sort' ] = $sort;
730
+				$args[ 'dir' ] = \GV\Utils::_GET( 'dir' );
731 731
 			}
732 732
 
733 733
 		}
734 734
 
735
-		if( $post_id ) {
735
+		if ( $post_id ) {
736 736
 			$passed_post = get_post( $post_id );
737 737
 			$views       = \GV\View_Collection::from_post( $passed_post );
738 738
 			$has_multiple_views = $views->count() > 1;
@@ -741,7 +741,7 @@  discard block
 block discarded – undo
741 741
 		}
742 742
 
743 743
 		if ( $has_multiple_views ) {
744
-			$args['gvid'] = $view_id ? $view_id : gravityview_get_view_id();
744
+			$args[ 'gvid' ] = $view_id ? $view_id : gravityview_get_view_id();
745 745
 		}
746 746
 
747 747
 		return add_query_arg( $args, $directory_link );
@@ -762,7 +762,7 @@  discard block
 block discarded – undo
762 762
 }
763 763
 
764 764
 function gv_class( $field, $form = NULL, $entry = array() ) {
765
-	return GravityView_API::field_class( $field, $form, $entry  );
765
+	return GravityView_API::field_class( $field, $form, $entry );
766 766
 }
767 767
 
768 768
 /**
@@ -785,7 +785,7 @@  discard block
 block discarded – undo
785 785
 		$view_id = 0;
786 786
 		if ( $context->view ) {
787 787
 			$view_id = $context->view->ID;
788
-			if( $context->view->settings->get( 'hide_until_searched' ) ) {
788
+			if ( $context->view->settings->get( 'hide_until_searched' ) ) {
789 789
 				$hide_until_searched = ( empty( $context->entry ) && ! $context->request->is_search() );
790 790
 			}
791 791
 		}
@@ -817,7 +817,7 @@  discard block
 block discarded – undo
817 817
 		$default_css_class .= ' ' . $context->view->settings->get( 'class', '' );
818 818
 	}
819 819
 
820
-	$css_class = trim( $passed_css_class . ' '. $default_css_class );
820
+	$css_class = trim( $passed_css_class . ' ' . $default_css_class );
821 821
 
822 822
 	/**
823 823
 	 * @filter `gravityview/render/container/class` Modify the CSS class to be added to the wrapper <div> of a View
@@ -844,7 +844,7 @@  discard block
 block discarded – undo
844 844
 
845 845
 	$value = GravityView_API::field_value( $entry, $field );
846 846
 
847
-	if( $value === '' ) {
847
+	if ( $value === '' ) {
848 848
 		/**
849 849
 		 * @filter `gravityview_empty_value` What to display when a field is empty
850 850
 		 * @param string $value (empty string)
@@ -957,7 +957,7 @@  discard block
 block discarded – undo
957 957
  */
958 958
 function gravityview_get_field_value( $entry, $field_id, $display_value ) {
959 959
 
960
-	if( floatval( $field_id ) === floor( floatval( $field_id ) ) ) {
960
+	if ( floatval( $field_id ) === floor( floatval( $field_id ) ) ) {
961 961
 
962 962
 		// For the complete field value as generated by Gravity Forms
963 963
 		return $display_value;
@@ -991,16 +991,16 @@  discard block
 block discarded – undo
991 991
 		$terms = explode( ', ', $value );
992 992
 	}
993 993
 
994
-	foreach ($terms as $term_name ) {
994
+	foreach ( $terms as $term_name ) {
995 995
 
996 996
 		// If we're processing a category,
997
-		if( $taxonomy === 'category' ) {
997
+		if ( $taxonomy === 'category' ) {
998 998
 
999 999
 			// Use rgexplode to prevent errors if : doesn't exist
1000 1000
 			list( $term_name, $term_id ) = rgexplode( ':', $term_name, 2 );
1001 1001
 
1002 1002
 			// The explode was succesful; we have the category ID
1003
-			if( !empty( $term_id )) {
1003
+			if ( ! empty( $term_id ) ) {
1004 1004
 				$term = get_term_by( 'id', $term_id, $taxonomy );
1005 1005
 			} else {
1006 1006
 			// We have to fall back to the name
@@ -1013,7 +1013,7 @@  discard block
 block discarded – undo
1013 1013
 		}
1014 1014
 
1015 1015
 		// There's still a tag/category here.
1016
-		if( $term ) {
1016
+		if ( $term ) {
1017 1017
 
1018 1018
 			$term_link = get_term_link( $term, $taxonomy );
1019 1019
 
@@ -1022,11 +1022,11 @@  discard block
 block discarded – undo
1022 1022
 			    continue;
1023 1023
 			}
1024 1024
 
1025
-			$output[] = gravityview_get_link( $term_link, esc_html( $term->name ) );
1025
+			$output[ ] = gravityview_get_link( $term_link, esc_html( $term->name ) );
1026 1026
 		}
1027 1027
 	}
1028 1028
 
1029
-	return implode(', ', $output );
1029
+	return implode( ', ', $output );
1030 1030
 }
1031 1031
 
1032 1032
 /**
@@ -1040,8 +1040,8 @@  discard block
 block discarded – undo
1040 1040
 
1041 1041
 	$output = get_the_term_list( $post_id, $taxonomy, NULL, ', ' );
1042 1042
 
1043
-	if( empty( $link ) ) {
1044
-		return strip_tags( $output);
1043
+	if ( empty( $link ) ) {
1044
+		return strip_tags( $output );
1045 1045
 	}
1046 1046
 
1047 1047
 	return $output;
@@ -1060,7 +1060,7 @@  discard block
 block discarded – undo
1060 1060
 	$fe = GravityView_frontend::getInstance();
1061 1061
 
1062 1062
 	// Solve problem when loading content via admin-ajax.php
1063
-	if( ! $fe->getGvOutputData() ) {
1063
+	if ( ! $fe->getGvOutputData() ) {
1064 1064
 
1065 1065
 		gravityview()->log->debug( 'gv_output_data not defined; parsing content.' );
1066 1066
 
@@ -1068,7 +1068,7 @@  discard block
 block discarded – undo
1068 1068
 	}
1069 1069
 
1070 1070
 	// Make 100% sure that we're dealing with a properly called situation
1071
-	if( !is_a( $fe->getGvOutputData(), 'GravityView_View_Data' ) ) {
1071
+	if ( ! is_a( $fe->getGvOutputData(), 'GravityView_View_Data' ) ) {
1072 1072
 
1073 1073
 		gravityview()->log->debug( 'gv_output_data not an object or get_view not callable.', array( 'data' => $fe->getGvOutputData() ) );
1074 1074
 
@@ -1299,12 +1299,12 @@  discard block
 block discarded – undo
1299 1299
 function gravityview_get_files_array( $value, $gv_class = '', $context = null ) {
1300 1300
 	/** @define "GRAVITYVIEW_DIR" "../" */
1301 1301
 
1302
-	if( !class_exists( 'GravityView_Field' ) ) {
1303
-		include_once( GRAVITYVIEW_DIR .'includes/fields/class-gravityview-field.php' );
1302
+	if ( ! class_exists( 'GravityView_Field' ) ) {
1303
+		include_once( GRAVITYVIEW_DIR . 'includes/fields/class-gravityview-field.php' );
1304 1304
 	}
1305 1305
 
1306
-	if( !class_exists( 'GravityView_Field_FileUpload' ) ) {
1307
-		include_once( GRAVITYVIEW_DIR .'includes/fields/class-gravityview-field-fileupload.php' );
1306
+	if ( ! class_exists( 'GravityView_Field_FileUpload' ) ) {
1307
+		include_once( GRAVITYVIEW_DIR . 'includes/fields/class-gravityview-field-fileupload.php' );
1308 1308
 	}
1309 1309
 
1310 1310
 	if ( is_null( $context ) ) {
@@ -1407,21 +1407,21 @@  discard block
 block discarded – undo
1407 1407
 	} else {
1408 1408
 		// @deprecated path
1409 1409
 		// Required fields.
1410
-		if ( empty( $args['field'] ) || empty( $args['form'] ) ) {
1410
+		if ( empty( $args[ 'field' ] ) || empty( $args[ 'form' ] ) ) {
1411 1411
 			gravityview()->log->error( 'Field or form are empty.', array( 'data' => $args ) );
1412 1412
 			return '';
1413 1413
 		}
1414 1414
 	}
1415 1415
 
1416 1416
 	if ( $context instanceof \GV\Template_Context ) {
1417
-		$entry = $args['entry'] ? : ( $context->entry ? $context->entry->as_entry() : array() );
1418
-		$field = $args['field'] ? : ( $context->field ? $context->field->as_configuration() : array() );
1419
-		$form = $args['form'] ? : ( $context->view->form ? $context->view->form->form : array() );
1417
+		$entry = $args[ 'entry' ] ?: ( $context->entry ? $context->entry->as_entry() : array() );
1418
+		$field = $args[ 'field' ] ?: ( $context->field ? $context->field->as_configuration() : array() );
1419
+		$form = $args[ 'form' ] ?: ( $context->view->form ? $context->view->form->form : array() );
1420 1420
 	} else {
1421 1421
 		// @deprecated path
1422
-		$entry = empty( $args['entry'] ) ? array() : $args['entry'];
1423
-		$field = $args['field'];
1424
-		$form = $args['form'];
1422
+		$entry = empty( $args[ 'entry' ] ) ? array() : $args[ 'entry' ];
1423
+		$field = $args[ 'field' ];
1424
+		$form = $args[ 'form' ];
1425 1425
 	}
1426 1426
 
1427 1427
 	/**
@@ -1441,43 +1441,43 @@  discard block
 block discarded – undo
1441 1441
 	);
1442 1442
 
1443 1443
 	if ( $context instanceof \GV\Template_Context ) {
1444
-		$placeholders['value'] = \GV\Utils::get( $args, 'value', '' );
1444
+		$placeholders[ 'value' ] = \GV\Utils::get( $args, 'value', '' );
1445 1445
 	} else {
1446 1446
 		// @deprecated path
1447
-		$placeholders['value'] = gv_value( $entry, $field );
1447
+		$placeholders[ 'value' ] = gv_value( $entry, $field );
1448 1448
 	}
1449 1449
 
1450 1450
 	// If the value is empty and we're hiding empty, return empty.
1451
-	if ( $placeholders['value'] === '' && ! empty( $args['hide_empty'] ) ) {
1451
+	if ( $placeholders[ 'value' ] === '' && ! empty( $args[ 'hide_empty' ] ) ) {
1452 1452
 		return '';
1453 1453
 	}
1454 1454
 
1455
-	if ( $placeholders['value'] !== '' && ! empty( $args['wpautop'] ) ) {
1456
-		$placeholders['value'] = wpautop( $placeholders['value'] );
1455
+	if ( $placeholders[ 'value' ] !== '' && ! empty( $args[ 'wpautop' ] ) ) {
1456
+		$placeholders[ 'value' ] = wpautop( $placeholders[ 'value' ] );
1457 1457
 	}
1458 1458
 
1459 1459
 	// Get width setting, if exists
1460
-	$placeholders['width'] = GravityView_API::field_width( $field );
1460
+	$placeholders[ 'width' ] = GravityView_API::field_width( $field );
1461 1461
 
1462 1462
 	// If replacing with CSS inline formatting, let's do it.
1463
-	$placeholders['width:style'] = GravityView_API::field_width( $field, 'width:' . $placeholders['width'] . '%;' );
1463
+	$placeholders[ 'width:style' ] = GravityView_API::field_width( $field, 'width:' . $placeholders[ 'width' ] . '%;' );
1464 1464
 
1465 1465
 	// Grab the Class using `gv_class`
1466
-	$placeholders['class'] = gv_class( $field, $form, $entry );
1467
-	$placeholders['field_id'] = GravityView_API::field_html_attr_id( $field, $form, $entry );
1466
+	$placeholders[ 'class' ] = gv_class( $field, $form, $entry );
1467
+	$placeholders[ 'field_id' ] = GravityView_API::field_html_attr_id( $field, $form, $entry );
1468 1468
 
1469 1469
 	if ( $context instanceof \GV\Template_Context ) {
1470
-		$placeholders['label_value'] = \GV\Utils::get( $args, 'label' );
1470
+		$placeholders[ 'label_value' ] = \GV\Utils::get( $args, 'label' );
1471 1471
 	} else {
1472 1472
 		// Default Label value
1473
-		$placeholders['label_value'] = gv_label( $field, $entry );
1473
+		$placeholders[ 'label_value' ] = gv_label( $field, $entry );
1474 1474
 	}
1475 1475
 
1476
-	$placeholders['label_value:data-label'] = trim( esc_attr( strip_tags( str_replace( '>&nbsp;', '>', $placeholders['label_value'] ) ) ) );
1477
-	$placeholders['label_value:esc_attr'] = esc_attr( $placeholders['label_value'] );
1476
+	$placeholders[ 'label_value:data-label' ] = trim( esc_attr( strip_tags( str_replace( '>&nbsp;', '>', $placeholders[ 'label_value' ] ) ) ) );
1477
+	$placeholders[ 'label_value:esc_attr' ] = esc_attr( $placeholders[ 'label_value' ] );
1478 1478
 
1479
-	if ( empty( $placeholders['label'] ) && ! empty( $placeholders['label_value'] ) ){
1480
-		$placeholders['label'] = '<span class="gv-field-label">{{ label_value }}</span>';
1479
+	if ( empty( $placeholders[ 'label' ] ) && ! empty( $placeholders[ 'label_value' ] ) ) {
1480
+		$placeholders[ 'label' ] = '<span class="gv-field-label">{{ label_value }}</span>';
1481 1481
 	}
1482 1482
 
1483 1483
 	/**
@@ -1488,7 +1488,7 @@  discard block
 block discarded – undo
1488 1488
 	 * @since 2.0
1489 1489
 	 * @param \GV\Template_Context $context The context.
1490 1490
 	 */
1491
-	$html = apply_filters( 'gravityview/field_output/pre_html', $args['markup'], $args, $context );
1491
+	$html = apply_filters( 'gravityview/field_output/pre_html', $args[ 'markup' ], $args, $context );
1492 1492
 
1493 1493
 	/**
1494 1494
 	 * @filter `gravityview/field_output/open_tag` Modify the opening tags for the template content placeholders
@@ -1515,7 +1515,7 @@  discard block
 block discarded – undo
1515 1515
 	foreach ( $placeholders as $tag => $value ) {
1516 1516
 
1517 1517
 		// If the tag doesn't exist just skip it
1518
-		if ( false === strpos( $html, $open_tag . $tag . $close_tag ) && false === strpos( $html, $open_tag . ' ' . $tag . ' ' . $close_tag ) ){
1518
+		if ( false === strpos( $html, $open_tag . $tag . $close_tag ) && false === strpos( $html, $open_tag . ' ' . $tag . ' ' . $close_tag ) ) {
1519 1519
 			continue;
1520 1520
 		}
1521 1521
 
Please login to merge, or discard this patch.
future/includes/class-gv-shortcode-gravityview.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -43,8 +43,8 @@  discard block
 block discarded – undo
43 43
 			'class' => '',
44 44
 		) );
45 45
 
46
-		if ( ! $view_id = $atts['id'] ? : $atts['view_id'] ) {
47
-			if ( $atts['detail'] && $view = $request->is_view() ) {
46
+		if ( ! $view_id = $atts[ 'id' ] ?: $atts[ 'view_id' ] ) {
47
+			if ( $atts[ 'detail' ] && $view = $request->is_view() ) {
48 48
 				$view_id = $view->ID;
49 49
 			}
50 50
 		}
@@ -114,12 +114,12 @@  discard block
 block discarded – undo
114 114
 			}
115 115
 		}
116 116
 
117
-		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap('gravityview_moderate_entries', $view->ID );
117
+		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap( 'gravityview_moderate_entries', $view->ID );
118 118
 
119 119
 		/**
120 120
 		 * View details.
121 121
 		 */
122
-		if ( $atts['detail'] ) {
122
+		if ( $atts[ 'detail' ] ) {
123 123
 			$entries = $view->get_entries( $request );
124 124
 			return self::_return( $this->detail( $view, $entries, $atts ) );
125 125
 
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
 				return self::_return( '' );
137 137
 			}
138 138
 
139
-			if ( $entry['status'] != 'active' ) {
139
+			if ( $entry[ 'status' ] != 'active' ) {
140 140
 				gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
141 141
 				return self::_return( __( 'You are not allowed to view this content.', 'gravityview' ) );
142 142
 			}
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
 			}
148 148
 
149 149
 			if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
150
-				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
150
+				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
151 151
 					gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
152 152
 					return self::_return( __( 'You are not allowed to view this content.', 'gravityview' ) );
153 153
 				}
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
 			$entryset = $entry->is_multi() ? $entry->entries : array( $entry );
171 171
 
172 172
 			foreach ( $entryset as $e ) {
173
-				if ( $e['status'] != 'active' ) {
173
+				if ( $e[ 'status' ] != 'active' ) {
174 174
 					gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $e->ID ) );
175 175
 					return self::_return( __( 'You are not allowed to view this content.', 'gravityview' ) );
176 176
 				}
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
 				}
182 182
 
183 183
 				if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
184
-					if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $e->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
184
+					if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $e->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
185 185
 						gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $e->ID ) );
186 186
 						return self::_return( __( 'You are not allowed to view this content.', 'gravityview' ) );
187 187
 					}
@@ -206,10 +206,10 @@  discard block
 block discarded – undo
206 206
 
207 207
 				// Mock the request with the actual View, not the global one
208 208
 				$mock_request = new \GV\Mock_Request();
209
-				$mock_request->returns['is_view'] = $view;
210
-				$mock_request->returns['is_entry'] = $request->is_entry( $view->form ? $view->form->ID : 0 );
211
-				$mock_request->returns['is_edit_entry'] = $request->is_edit_entry( $view->form ? $view->form->ID : 0 );
212
-				$mock_request->returns['is_search'] = $request->is_search();
209
+				$mock_request->returns[ 'is_view' ] = $view;
210
+				$mock_request->returns[ 'is_entry' ] = $request->is_entry( $view->form ? $view->form->ID : 0 );
211
+				$mock_request->returns[ 'is_edit_entry' ] = $request->is_edit_entry( $view->form ? $view->form->ID : 0 );
212
+				$mock_request->returns[ 'is_search' ] = $request->is_search();
213 213
 
214 214
 				$request = $mock_request;
215 215
 			}
@@ -245,16 +245,16 @@  discard block
 block discarded – undo
245 245
 		$filtered_atts = shortcode_atts( $supported_atts, $passed_atts, 'gravityview' );
246 246
 
247 247
 		// Only keep the passed attributes after making sure that they're valid pairs
248
-		$filtered_atts = array_intersect_key( (array) $passed_atts, $filtered_atts );
248
+		$filtered_atts = array_intersect_key( (array)$passed_atts, $filtered_atts );
249 249
 
250 250
 		$atts = array();
251 251
 
252
-		foreach( $filtered_atts as $key => $passed_value ) {
252
+		foreach ( $filtered_atts as $key => $passed_value ) {
253 253
 
254 254
 			// Allow using GravityView merge tags in shortcode attributes, like {get} and {created_by}
255 255
 			$passed_value = \GravityView_Merge_Tags::replace_variables( $passed_value );
256 256
 
257
-			switch( $defaults[ $key ]['type'] ) {
257
+			switch ( $defaults[ $key ][ 'type' ] ) {
258 258
 
259 259
 				/**
260 260
 				 * Make sure number fields are numeric.
@@ -262,7 +262,7 @@  discard block
 block discarded – undo
262 262
 				 * @see http://php.net/manual/en/function.is-numeric.php#107326
263 263
 				 */
264 264
 				case 'number':
265
-					if( is_numeric( $passed_value ) ) {
265
+					if ( is_numeric( $passed_value ) ) {
266 266
 						$atts[ $key ] = ( $passed_value + 0 );
267 267
 					}
268 268
 					break;
@@ -277,8 +277,8 @@  discard block
 block discarded – undo
277 277
 				 */
278 278
 				case 'select':
279 279
 				case 'radio':
280
-					$options = isset( $defaults[ $key ]['choices'] ) ? $defaults[ $key ]['choices'] : $defaults[ $key ]['options'];
281
-					if( in_array( $passed_value, array_keys( $options ) ) ) {
280
+					$options = isset( $defaults[ $key ][ 'choices' ] ) ? $defaults[ $key ][ 'choices' ] : $defaults[ $key ][ 'options' ];
281
+					if ( in_array( $passed_value, array_keys( $options ) ) ) {
282 282
 						$atts[ $key ] = $passed_value;
283 283
 					}
284 284
 					break;
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
 			}
291 291
 		}
292 292
 
293
-		$atts['detail'] = \GV\Utils::get( $passed_atts, 'detail', null );
293
+		$atts[ 'detail' ] = \GV\Utils::get( $passed_atts, 'detail', null );
294 294
 
295 295
 		return $atts;
296 296
 	}
@@ -307,7 +307,7 @@  discard block
 block discarded – undo
307 307
 	private function detail( $view, $entries, $atts ) {
308 308
 		$output = '';
309 309
 
310
-		switch ( $key = $atts['detail'] ):
310
+		switch ( $key = $atts[ 'detail' ] ):
311 311
 			case 'total_entries':
312 312
 				$output = number_format_i18n( $entries->total() );
313 313
 				break;
Please login to merge, or discard this patch.