Completed
Pull Request — master (#1461)
by Zack
17:37 queued 14:56
created
future/includes/class-gv-form-gravityforms.php 3 patches
Doc Comments   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -84,6 +84,7 @@  discard block
 block discarded – undo
84 84
 	/**
85 85
 	 * Return the query class for this View.
86 86
 	 *
87
+	 * @param View $view
87 88
 	 * @return string The class name.
88 89
 	 */
89 90
 	public function get_query_class( $view ) {
@@ -575,10 +576,8 @@  discard block
 block discarded – undo
575 576
 	/**
576 577
 	 * Get a \GV\Field by Form and Field ID for this data source.
577 578
 	 *
578
-	 * @param \GV\GF_Form $form The Gravity Form form ID.
579
-	 * @param int $field_id The Gravity Form field ID for the $form_id.
580 579
 	 *
581
-	 * @return \GV\Field|null The requested field or null if not found.
580
+	 * @return null|GF_Field The requested field or null if not found.
582 581
 	 */
583 582
 	public static function get_field( /** varargs */ ) {
584 583
 		$args = func_get_args();
Please login to merge, or discard this patch.
Spacing   +47 added lines, -47 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 		$self = new self();
56 56
 		$self->form = $form;
57 57
 
58
-		$self->ID = intval( $self->form['id'] );
58
+		$self->ID = intval( $self->form[ 'id' ] );
59 59
 
60 60
 		return $self;
61 61
 	}
@@ -70,13 +70,13 @@  discard block
 block discarded – undo
70 70
 	 * @return \GV\GF_Form|null An instance of this form or null if not found.
71 71
 	 */
72 72
 	public static function from_form( $form ) {
73
-		if ( empty( $form['id'] ) ) {
73
+		if ( empty( $form[ 'id' ] ) ) {
74 74
 			return null;
75 75
 		}
76 76
 
77 77
 		$self = new self();
78 78
 		$self->form = $form;
79
-		$self->ID = $self->form['id'];
79
+		$self->ID = $self->form[ 'id' ];
80 80
 
81 81
 		return $self;
82 82
 	}
@@ -138,11 +138,11 @@  discard block
 block discarded – undo
138 138
 
139 139
 				/** The offset and limit */
140 140
 				if ( ! empty( $offset->limit ) ) {
141
-					$paging['page_size'] = $offset->limit;
141
+					$paging[ 'page_size' ] = $offset->limit;
142 142
 				}
143 143
 
144 144
 				if ( ! empty( $offset->offset ) ) {
145
-					$paging['offset'] = $offset->offset;
145
+					$paging[ 'offset' ] = $offset->offset;
146 146
 				}
147 147
 				
148 148
 				$query_class = $form->get_query_class( $view );
@@ -157,15 +157,15 @@  discard block
 block discarded – undo
157 157
 					$view_setting_sort_field_ids = \GV\Utils::get( $atts, 'sort_field', array() );
158 158
 					$view_setting_sort_directions = \GV\Utils::get( $atts, 'sort_direction', array() );
159 159
 
160
-					$has_sort_query_param = ! empty( $_GET['sort'] ) && is_array( $_GET['sort'] );
160
+					$has_sort_query_param = ! empty( $_GET[ 'sort' ] ) && is_array( $_GET[ 'sort' ] );
161 161
 
162
-					if( $has_sort_query_param ) {
163
-						$has_sort_query_param = array_filter( array_values( $_GET['sort'] ) );
162
+					if ( $has_sort_query_param ) {
163
+						$has_sort_query_param = array_filter( array_values( $_GET[ 'sort' ] ) );
164 164
 					}
165 165
 
166 166
 					if ( $view->settings->get( 'sort_columns' ) && $has_sort_query_param ) {
167
-						$sort_field_ids = array_keys( $_GET['sort'] );
168
-						$sort_directions = array_values( $_GET['sort'] );
167
+						$sort_field_ids = array_keys( $_GET[ 'sort' ] );
168
+						$sort_directions = array_values( $_GET[ 'sort' ] );
169 169
 					} else {
170 170
 						$sort_field_ids = $view_setting_sort_field_ids;
171 171
 						$sort_directions = $view_setting_sort_directions;
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
 
174 174
 					$skip_first = false;
175 175
 
176
-					foreach ( (array) $sort_field_ids as $key => $sort_field_id ) {
176
+					foreach ( (array)$sort_field_ids as $key => $sort_field_id ) {
177 177
 
178 178
 						if ( ! $skip_first && ! $has_sort_query_param ) {
179 179
 							$skip_first = true; // Skip the first one, it's already in the query
@@ -203,15 +203,15 @@  discard block
 block discarded – undo
203 203
 
204 204
 					$merged_time = false;
205 205
 
206
-					foreach ( $q['order'] as $oid => $order ) {
207
-						if ( $order[0] instanceof \GF_Query_Column ) {
208
-							$column = $order[0];
209
-						} else if ( $order[0] instanceof \GF_Query_Call ) {
210
-							if ( count( $order[0]->columns ) != 1 || ! $order[0]->columns[0] instanceof \GF_Query_Column ) {
206
+					foreach ( $q[ 'order' ] as $oid => $order ) {
207
+						if ( $order[ 0 ] instanceof \GF_Query_Column ) {
208
+							$column = $order[ 0 ];
209
+						} else if ( $order[ 0 ] instanceof \GF_Query_Call ) {
210
+							if ( count( $order[ 0 ]->columns ) != 1 || ! $order[ 0 ]->columns[ 0 ] instanceof \GF_Query_Column ) {
211 211
 								$orders[ $oid ] = $order;
212 212
 								continue; // Need something that resembles a single sort
213 213
 							}
214
-							$column = $order[0]->columns[0];
214
+							$column = $order[ 0 ]->columns[ 0 ];
215 215
 						}
216 216
 
217 217
 						if ( ( ! $field = \GFAPI::get_field( $column->source, $column->field_id ) ) || $field->type !== 'time' ) {
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
 
226 226
 						$orders[ $oid ] = array(
227 227
 							new \GV\Mocks\GF_Query_Call_TIMESORT( 'timesort', array( $column, $sql ) ),
228
-							$order[1] // Mock it!
228
+							$order[ 1 ] // Mock it!
229 229
 						);
230 230
 
231 231
 						$merged_time = true;
@@ -236,7 +236,7 @@  discard block
 block discarded – undo
236 236
 						 * ORDER again.
237 237
 						 */
238 238
 						if ( ! empty( $orders ) && $_orders = $query->_order_generate( $orders ) ) {
239
-							$sql['order'] = 'ORDER BY ' . implode( ', ', $_orders );
239
+							$sql[ 'order' ] = 'ORDER BY ' . implode( ', ', $_orders );
240 240
 						}
241 241
 					}
242 242
 
@@ -264,7 +264,7 @@  discard block
 block discarded – undo
264 264
 
265 265
 							$query_parameters = $query->_introspect();
266 266
 
267
-							$query->where( \GF_Query_Condition::_and( $query_parameters['where'], $condition ) );
267
+							$query->where( \GF_Query_Condition::_and( $query_parameters[ 'where' ], $condition ) );
268 268
 						}
269 269
 
270 270
 						/**
@@ -298,7 +298,7 @@  discard block
 block discarded – undo
298 298
 						}
299 299
 
300 300
 						$q = $query->_introspect();
301
-						$query->where( \GF_Query_Condition::_and( $q['where'], $condition ) );
301
+						$query->where( \GF_Query_Condition::_and( $q[ 'where' ], $condition ) );
302 302
 
303 303
 						if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
304 304
 
@@ -323,7 +323,7 @@  discard block
 block discarded – undo
323 323
 
324 324
 							$query_parameters = $query->_introspect();
325 325
 
326
-							$query->where( \GF_Query_Condition::_and( $query_parameters['where'], $condition ) );
326
+							$query->where( \GF_Query_Condition::_and( $query_parameters[ 'where' ], $condition ) );
327 327
 						}
328 328
 					}
329 329
 				/**
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
 							$conditions = array();
347 347
 
348 348
 							foreach ( $condition->expressions as $_condition ) {
349
-								$conditions[] = $recurse( $_condition, $fields, $recurse );
349
+								$conditions[ ] = $recurse( $_condition, $fields, $recurse );
350 350
 							}
351 351
 
352 352
 							return call_user_func_array(
@@ -374,10 +374,10 @@  discard block
 block discarded – undo
374 374
 						$q = new $query_class( $form_id );
375 375
 
376 376
 						// Copy the WHERE clauses but substitute the field_ids to the respective ones
377
-						$q->where( $where_union_substitute( $query_parameters['where'], $fields, $where_union_substitute ) );
377
+						$q->where( $where_union_substitute( $query_parameters[ 'where' ], $fields, $where_union_substitute ) );
378 378
 
379 379
 						// Copy the ORDER clause and substitute the field_ids to the respective ones
380
-						foreach ( $query_parameters['order'] as $order ) {
380
+						foreach ( $query_parameters[ 'order' ] as $order ) {
381 381
 							list( $column, $_order ) = $order;
382 382
 
383 383
 							if ( $column && $column instanceof \GF_Query_Column ) {
@@ -391,15 +391,15 @@  discard block
 block discarded – undo
391 391
 
392 392
 						add_filter( 'gform_gf_query_sql', $gf_query_sql_callback = function( $sql ) use ( &$unions_sql ) {
393 393
 							// Remove SQL_CALC_FOUND_ROWS as it's not needed in UNION clauses
394
-							$select = 'UNION ALL ' . str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql['select'] );
394
+							$select = 'UNION ALL ' . str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql[ 'select' ] );
395 395
 
396 396
 							// Record the SQL
397
-							$unions_sql[] = array(
397
+							$unions_sql[ ] = array(
398 398
 								// Remove columns, we'll rebuild them
399 399
 								'select'  => preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $select ),
400
-								'from'    => $sql['from'],
401
-								'join'    => $sql['join'],
402
-								'where'   => $sql['where'],
400
+								'from'    => $sql[ 'from' ],
401
+								'join'    => $sql[ 'join' ],
402
+								'where'   => $sql[ 'where' ],
403 403
 								// Remove order and limit
404 404
 							);
405 405
 
@@ -416,11 +416,11 @@  discard block
 block discarded – undo
416 416
 
417 417
 					add_filter( 'gform_gf_query_sql', $gf_query_sql_callback = function( $sql ) use ( $unions_sql ) {
418 418
 						// Remove SQL_CALC_FOUND_ROWS as it's not needed in UNION clauses
419
-						$sql['select'] = str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql['select'] );
419
+						$sql[ 'select' ] = str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql[ 'select' ] );
420 420
 
421 421
 						// Remove columns, we'll rebuild them
422
-						preg_match( '#DISTINCT (`[motc]\d+`.`.*?`)#', $sql['select'], $select_match );
423
-						$sql['select'] = preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $sql['select'] );
422
+						preg_match( '#DISTINCT (`[motc]\d+`.`.*?`)#', $sql[ 'select' ], $select_match );
423
+						$sql[ 'select' ] = preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $sql[ 'select' ] );
424 424
 
425 425
 						$unions = array();
426 426
 
@@ -431,30 +431,30 @@  discard block
 block discarded – undo
431 431
 						};
432 432
 
433 433
 						// Add all the order columns into the selects, so we can order by the whole union group
434
-						preg_match_all( '#(`[motc]\d+`.`.*?`)#', $sql['order'], $order_matches );
434
+						preg_match_all( '#(`[motc]\d+`.`.*?`)#', $sql[ 'order' ], $order_matches );
435 435
 						
436 436
 						$columns = array(
437
-							sprintf( '%s AS %s', $select_match[1], $column_to_alias( $select_match[1] ) )
437
+							sprintf( '%s AS %s', $select_match[ 1 ], $column_to_alias( $select_match[ 1 ] ) )
438 438
 						);
439 439
 
440 440
 						foreach ( array_slice( $order_matches, 1 ) as $match ) {
441
-							$columns[] = sprintf( '%s AS %s', $match[0], $column_to_alias( $match[0] ) );
441
+							$columns[ ] = sprintf( '%s AS %s', $match[ 0 ], $column_to_alias( $match[ 0 ] ) );
442 442
 
443 443
 							// Rewrite the order columns to the shared aliases
444
-							$sql['order'] = str_replace( $match[0], $column_to_alias( $match[0] ), $sql['order'] );
444
+							$sql[ 'order' ] = str_replace( $match[ 0 ], $column_to_alias( $match[ 0 ] ), $sql[ 'order' ] );
445 445
 						}
446 446
 
447 447
 						$columns = array_unique( $columns );
448 448
 
449 449
 						// Add the columns to every UNION
450 450
 						foreach ( $unions_sql as $union_sql ) {
451
-							$union_sql['select'] .= implode( ', ', $columns );
452
-							$unions []= implode( ' ', $union_sql );
451
+							$union_sql[ 'select' ] .= implode( ', ', $columns );
452
+							$unions [ ] = implode( ' ', $union_sql );
453 453
 						}
454 454
 
455 455
 						// Add the columns to the main SELECT, but only grab the entry id column
456
-						$sql['select'] = 'SELECT SQL_CALC_FOUND_ROWS t1_id FROM (' . $sql['select'] . implode( ', ', $columns );
457
-						$sql['order'] = implode( ' ', $unions ) . ') AS u ' . $sql['order'];
456
+						$sql[ 'select' ] = 'SELECT SQL_CALC_FOUND_ROWS t1_id FROM (' . $sql[ 'select' ] . implode( ', ', $columns );
457
+						$sql[ 'order' ] = implode( ' ', $unions ) . ') AS u ' . $sql[ 'order' ];
458 458
 
459 459
 						return $sql;
460 460
 					} );
@@ -540,11 +540,11 @@  discard block
 block discarded – undo
540 540
 
541 541
 				/** The offset and limit */
542 542
 				if ( ! empty( $offset->limit ) ) {
543
-					$paging['page_size'] = $offset->limit;
543
+					$paging[ 'page_size' ] = $offset->limit;
544 544
 				}
545 545
 
546 546
 				if ( ! empty( $offset->offset ) ) {
547
-					$paging['offset'] = $offset->offset;
547
+					$paging[ 'offset' ] = $offset->offset;
548 548
 				}
549 549
 
550 550
 				foreach ( \GFAPI::get_entries( $form->ID, $search_criteria, $sorting, $paging ) as $entry ) {
@@ -602,8 +602,8 @@  discard block
 block discarded – undo
602 602
 	 */
603 603
 	public function get_fields() {
604 604
 		$fields = array();
605
-		foreach ( $this['fields'] as $field ) {
606
-			foreach ( empty( $field['inputs'] ) ? array( $field['id'] ) : wp_list_pluck( $field['inputs'], 'id' ) as $id ) {
605
+		foreach ( $this[ 'fields' ] as $field ) {
606
+			foreach ( empty( $field[ 'inputs' ] ) ? array( $field[ 'id' ] ) : wp_list_pluck( $field[ 'inputs' ], 'id' ) as $id ) {
607 607
 				if ( is_numeric( $id ) ) {
608 608
 					$fields[ $id ] = self::get_field( $this, $id );
609 609
 				} else {
@@ -640,7 +640,7 @@  discard block
 block discarded – undo
640 640
 	 * @return bool Whether the offset exists or not.
641 641
 	 */
642 642
 	public function offsetExists( $offset ) {
643
-		return isset( $this->form[$offset] );
643
+		return isset( $this->form[ $offset ] );
644 644
 	}
645 645
 
646 646
 	/**
@@ -655,7 +655,7 @@  discard block
 block discarded – undo
655 655
 	 * @return mixed The value of the requested form data.
656 656
 	 */
657 657
 	public function offsetGet( $offset ) {
658
-		return $this->form[$offset];
658
+		return $this->form[ $offset ];
659 659
 	}
660 660
 
661 661
 	/**
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -111,7 +111,8 @@
 block discarded – undo
111 111
 
112 112
 		$form = &$this;
113 113
 
114
-		if ( gravityview()->plugin->supports( Plugin::FEATURE_GFQUERY ) ) { // @todo switch to GFAPI:: once they start supporting nested and joins stuff
114
+		if ( gravityview()->plugin->supports( Plugin::FEATURE_GFQUERY ) ) {
115
+// @todo switch to GFAPI:: once they start supporting nested and joins stuff
115 116
 			$entries->add_fetch_callback( function( $filters, $sorts, $offset ) use ( $view, &$form ) {
116 117
 				$atts = $view->settings->as_atts();
117 118
 
Please login to merge, or discard this patch.
future/includes/class-gv-form.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -55,6 +55,7 @@
 block discarded – undo
55 55
 	 * Magic shortcuts.
56 56
 	 *
57 57
 	 * - `entries` -> `$this->get_entries()`
58
+	 * @param string $key
58 59
 	 */
59 60
 	public function __get( $key ) {
60 61
 		switch ( $key ):
Please login to merge, or discard this patch.
future/includes/class-gv-shortcode-gvfield.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -46,19 +46,19 @@  discard block
 block discarded – undo
46 46
 		 */
47 47
 		$atts = apply_filters( 'gravityview/shortcodes/gvfield/atts', $atts );
48 48
 
49
-		if ( ! $view = \GV\View::by_id( $atts['view_id'] ) ) {
50
-			gravityview()->log->error( 'View #{view_id} not found', array( 'view_id' => $atts['view_id'] ) );
49
+		if ( ! $view = \GV\View::by_id( $atts[ 'view_id' ] ) ) {
50
+			gravityview()->log->error( 'View #{view_id} not found', array( 'view_id' => $atts[ 'view_id' ] ) );
51 51
 			return apply_filters( 'gravityview/shortcodes/gvfield/output', '', $view, null, null, $atts );
52 52
 		}
53 53
 
54
-		switch( $atts['entry_id'] ):
54
+		switch ( $atts[ 'entry_id' ] ):
55 55
 			case 'last':
56 56
 				$entries = $view->get_entries();
57 57
 
58 58
 				/** If a sort already exists, reverse it. */
59 59
 				if ( $sort = end( $entries->sorts ) ) {
60 60
 					// @todo For multisorts we need to do this for each sort
61
-					$entries = $entries->sort( new \GV\Entry_Sort( $sort->field, $sort->direction == \GV\Entry_Sort::RAND ? : ( $sort->direction == \GV\Entry_Sort::ASC ? \GV\Entry_Sort::DESC : \GV\Entry_Sort::ASC ) ), $sort->mode );
61
+					$entries = $entries->sort( new \GV\Entry_Sort( $sort->field, $sort->direction == \GV\Entry_Sort::RAND ?: ( $sort->direction == \GV\Entry_Sort::ASC ? \GV\Entry_Sort::DESC : \GV\Entry_Sort::ASC ) ), $sort->mode );
62 62
 				} else {
63 63
 					/** Otherwise, sort by date_created */
64 64
 					$entries = $entries->sort( new \GV\Entry_Sort( \GV\Internal_Field::by_id( 'id' ), \GV\Entry_Sort::ASC ), \GV\Entry_Sort::NUMERIC );
@@ -74,20 +74,20 @@  discard block
 block discarded – undo
74 74
 				}
75 75
 				break;
76 76
 			default:
77
-				if ( ! $entry = \GV\GF_Entry::by_id( $atts['entry_id'] ) ) {
78
-					gravityview()->log->error( 'Entry #{entry_id} not found', array( 'view_id' => $atts['view_id'] ) );
77
+				if ( ! $entry = \GV\GF_Entry::by_id( $atts[ 'entry_id' ] ) ) {
78
+					gravityview()->log->error( 'Entry #{entry_id} not found', array( 'view_id' => $atts[ 'view_id' ] ) );
79 79
 					return apply_filters( 'gravityview/shortcodes/gvfield/output', '', $view, $entry, null, $atts );
80 80
 				}
81 81
 		endswitch;
82 82
 
83
-		$field = is_numeric( $atts['field_id'] ) ? \GV\GF_Field::by_id( $view->form, $atts['field_id'] ) : \GV\Internal_Field::by_id( $atts['field_id'] );
83
+		$field = is_numeric( $atts[ 'field_id' ] ) ? \GV\GF_Field::by_id( $view->form, $atts[ 'field_id' ] ) : \GV\Internal_Field::by_id( $atts[ 'field_id' ] );
84 84
 
85 85
 		if ( ! $field ) {
86
-			gravityview()->log->error( 'Field #{field_id} not found', array( 'view_id' => $atts['field_id'] ) );
86
+			gravityview()->log->error( 'Field #{field_id} not found', array( 'view_id' => $atts[ 'field_id' ] ) );
87 87
 			return apply_filters( 'gravityview/shortcodes/gvfield/output', '', $view, $entry, $field, $atts );
88 88
 		}
89 89
 
90
-		if ( $view->form->ID != $entry['form_id'] ) {
90
+		if ( $view->form->ID != $entry[ 'form_id' ] ) {
91 91
 			gravityview()->log->error( 'Entry does not belong to view (form mismatch)' );
92 92
 			return apply_filters( 'gravityview/shortcodes/gvfield/output', '', $view, $entry, $atts );
93 93
 		}
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
 			return apply_filters( 'gravityview/shortcodes/gvfield/output', get_the_password_form( $view->ID ), $view, $entry, $atts );
98 98
 		}
99 99
 
100
-		if ( ! $view->form  ) {
100
+		if ( ! $view->form ) {
101 101
 			gravityview()->log->notice( 'View #{id} has no form attached to it.', array( 'id' => $view->ID ) );
102 102
 
103 103
 			/**
@@ -120,13 +120,13 @@  discard block
 block discarded – undo
120 120
 		}
121 121
 
122 122
 		/** Unapproved entries. */
123
-		if ( $entry['status'] != 'active' ) {
123
+		if ( $entry[ 'status' ] != 'active' ) {
124 124
 			gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
125 125
 			return apply_filters( 'gravityview/shortcodes/gvfield/output', '', $view, $entry, $atts );
126 126
 		}
127 127
 
128 128
 		if ( $view->settings->get( 'show_only_approved' ) ) {
129
-			if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
129
+			if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
130 130
 				gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
131 131
 				return apply_filters( 'gravityview/shortcodes/gvfield/output', '', $view, $entry, $atts );
132 132
 			}
Please login to merge, or discard this patch.
future/includes/class-gv-view.php 1 patch
Spacing   +38 added lines, -39 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
 		$supports = array( 'title', 'revisions' );
126 126
 
127 127
 		if ( $is_hierarchical ) {
128
-			$supports[] = 'page-attributes';
128
+			$supports[ ] = 'page-attributes';
129 129
 		}
130 130
 
131 131
 		/**
@@ -227,11 +227,11 @@  discard block
 block discarded – undo
227 227
 		$rule = array( sprintf( '%s/([^/]+)/csv/?', $slug ), 'index.php?gravityview=$matches[1]&csv=1', 'top' );
228 228
 
229 229
 		add_filter( 'query_vars', function( $query_vars ) {
230
-			$query_vars[] = 'csv';
230
+			$query_vars[ ] = 'csv';
231 231
 			return $query_vars;
232 232
 		} );
233 233
 
234
-		if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[0] ] ) ) {
234
+		if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[ 0 ] ] ) ) {
235 235
 			call_user_func_array( 'add_rewrite_rule', $rule );
236 236
 		}
237 237
 	}
@@ -308,13 +308,13 @@  discard block
 block discarded – undo
308 308
 			return $content;
309 309
 		}
310 310
 
311
-		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap('gravityview_moderate_entries', $view->ID );
311
+		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap( 'gravityview_moderate_entries', $view->ID );
312 312
 
313 313
 		/**
314 314
 		 * Editing a single entry.
315 315
 		 */
316 316
 		if ( $entry = $request->is_edit_entry( $view->form ? $view->form->ID : 0 ) ) {
317
-			if ( $entry['status'] != 'active' ) {
317
+			if ( $entry[ 'status' ] != 'active' ) {
318 318
 				gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
319 319
 				return __( 'You are not allowed to view this content.', 'gravityview' );
320 320
 			}
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
325 325
 			}
326 326
 
327 327
 			if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
328
-				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
328
+				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
329 329
 					gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
330 330
 					return __( 'You are not allowed to view this content.', 'gravityview' );
331 331
 				}
@@ -348,7 +348,7 @@  discard block
 block discarded – undo
348 348
 
349 349
 			foreach ( $entryset as $e ) {
350 350
 
351
-				if ( 'active' !== $e['status'] ) {
351
+				if ( 'active' !== $e[ 'status' ] ) {
352 352
 					gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $e->ID ) );
353 353
 					return __( 'You are not allowed to view this content.', 'gravityview' );
354 354
 				}
@@ -359,7 +359,7 @@  discard block
 block discarded – undo
359 359
 				}
360 360
 
361 361
 				if ( $show_only_approved && ! $is_admin_and_can_view ) {
362
-					if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $e->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
362
+					if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $e->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
363 363
 						gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $e->ID ) );
364 364
 						return __( 'You are not allowed to view this content.', 'gravityview' );
365 365
 					}
@@ -534,7 +534,7 @@  discard block
 block discarded – undo
534 534
 			$join_column    = is_numeric( $join_column ) ? GF_Field::by_id( $join, $join_column ) : Internal_Field::by_id( $join_column );
535 535
 			$join_on_column = is_numeric( $join_on_column ) ? GF_Field::by_id( $join_on, $join_on_column ) : Internal_Field::by_id( $join_on_column );
536 536
 
537
-			$joins [] = new Join( $join, $join_column, $join_on, $join_on_column );
537
+			$joins [ ] = new Join( $join, $join_column, $join_on, $join_on_column );
538 538
 		}
539 539
 
540 540
 		return $joins;
@@ -624,13 +624,13 @@  discard block
 block discarded – undo
624 624
 			}
625 625
 
626 626
 			foreach ( $_fields as $field ) {
627
-				if ( ! empty( $field['unions'] ) ) {
628
-					foreach ( $field['unions'] as $form_id => $field_id ) {
627
+				if ( ! empty( $field[ 'unions' ] ) ) {
628
+					foreach ( $field[ 'unions' ] as $form_id => $field_id ) {
629 629
 						if ( ! isset( $unions[ $form_id ] ) ) {
630 630
 							$unions[ $form_id ] = array();
631 631
 						}
632 632
 
633
-						$unions[ $form_id ][ $field['id'] ] =
633
+						$unions[ $form_id ][ $field[ 'id' ] ] =
634 634
 							is_numeric( $field_id ) ? \GV\GF_Field::by_id( \GV\GF_Form::by_id( $form_id ), $field_id ) : \GV\Internal_Field::by_id( $field_id );
635 635
 					}
636 636
 				}
@@ -685,7 +685,7 @@  discard block
 block discarded – undo
685 685
 		if ( ! $view->form ) {
686 686
 			gravityview()->log->error( 'View #{view_id} tried attaching non-existent Form #{form_id} to it.', array(
687 687
 				'view_id' => $view->ID,
688
-				'form_id' => $view->_gravityview_form_id ? : 0,
688
+				'form_id' => $view->_gravityview_form_id ?: 0,
689 689
 			) );
690 690
 		}
691 691
 
@@ -925,10 +925,10 @@  discard block
 block discarded – undo
925 925
 			 * Remove multiple sorting before calling legacy filters.
926 926
 			 * This allows us to fake it till we make it.
927 927
 			 */
928
-			if ( ! empty( $parameters['sort_field'] ) && is_array( $parameters['sort_field'] ) ) {
929
-				$parameters['sort_field'] = reset( $parameters['sort_field'] );
930
-				if ( ! empty( $parameters['sort_direction'] ) && is_array( $parameters['sort_direction'] ) ) {
931
-					$parameters['sort_direction'] = reset( $parameters['sort_direction'] );
928
+			if ( ! empty( $parameters[ 'sort_field' ] ) && is_array( $parameters[ 'sort_field' ] ) ) {
929
+				$parameters[ 'sort_field' ] = reset( $parameters[ 'sort_field' ] );
930
+				if ( ! empty( $parameters[ 'sort_direction' ] ) && is_array( $parameters[ 'sort_direction' ] ) ) {
931
+					$parameters[ 'sort_direction' ] = reset( $parameters[ 'sort_direction' ] );
932 932
 				}
933 933
 			}
934 934
 
@@ -937,31 +937,30 @@  discard block
 block discarded – undo
937 937
 			 */
938 938
 			$parameters = \GravityView_frontend::get_view_entries_parameters( $parameters, $this->form->ID );
939 939
 
940
-			$parameters['context_view_id'] = $this->ID;
940
+			$parameters[ 'context_view_id' ] = $this->ID;
941 941
 			$parameters = \GVCommon::calculate_get_entries_criteria( $parameters, $this->form->ID );
942 942
 
943 943
 			if ( ! is_array( $parameters ) ) {
944 944
 				$parameters = array();
945 945
 			}
946 946
 
947
-			if ( ! is_array( $parameters['search_criteria'] ) ) {
948
-				$parameters['search_criteria'] = array();
947
+			if ( ! is_array( $parameters[ 'search_criteria' ] ) ) {
948
+				$parameters[ 'search_criteria' ] = array();
949 949
 			}
950 950
 
951
-			if ( ( ! isset( $parameters['search_criteria']['field_filters'] ) ) || ( ! is_array( $parameters['search_criteria']['field_filters'] ) ) ) {
952
-				$parameters['search_criteria']['field_filters'] = array();
951
+			if ( ( ! isset( $parameters[ 'search_criteria' ][ 'field_filters' ] ) ) || ( ! is_array( $parameters[ 'search_criteria' ][ 'field_filters' ] ) ) ) {
952
+				$parameters[ 'search_criteria' ][ 'field_filters' ] = array();
953 953
 			}
954 954
 
955 955
 			if ( $request instanceof REST\Request ) {
956 956
 				$atts = $this->settings->as_atts();
957 957
 				$paging_parameters = wp_parse_args( $request->get_paging(), array(
958
-						'paging' => array( 'page_size' => $atts['page_size'] ),
958
+						'paging' => array( 'page_size' => $atts[ 'page_size' ] ),
959 959
 					) );
960
-				$parameters['paging'] = $paging_parameters['paging'];
960
+				$parameters[ 'paging' ] = $paging_parameters[ 'paging' ];
961 961
 			}
962 962
 
963
-			$page = Utils::get( $parameters['paging'], 'current_page' ) ?
964
-				: ( ( ( $parameters['paging']['offset'] - $this->settings->get( 'offset' ) ) / \GV\Utils::get( $parameters, 'paging/page_size', 25 ) ) + 1 );
963
+			$page = Utils::get( $parameters[ 'paging' ], 'current_page' ) ?: ( ( ( $parameters[ 'paging' ][ 'offset' ] - $this->settings->get( 'offset' ) ) / \GV\Utils::get( $parameters, 'paging/page_size', 25 ) ) + 1 );
965 964
 
966 965
 			/**
967 966
 			 * Cleanup duplicate field_filter parameters to simplify the query.
@@ -969,28 +968,28 @@  discard block
 block discarded – undo
969 968
 			$unique_field_filters = array();
970 969
 			foreach ( Utils::get( $parameters, 'search_criteria/field_filters', array() ) as $key => $filter ) {
971 970
 				if ( 'mode' === $key ) {
972
-					$unique_field_filters['mode'] = $filter;
971
+					$unique_field_filters[ 'mode' ] = $filter;
973 972
 				} else if ( ! in_array( $filter, $unique_field_filters ) ) {
974
-					$unique_field_filters[] = $filter;
973
+					$unique_field_filters[ ] = $filter;
975 974
 				}
976 975
 			}
977
-			$parameters['search_criteria']['field_filters'] = $unique_field_filters;
976
+			$parameters[ 'search_criteria' ][ 'field_filters' ] = $unique_field_filters;
978 977
 
979
-			if ( ! empty( $parameters['search_criteria']['field_filters'] ) ) {
978
+			if ( ! empty( $parameters[ 'search_criteria' ][ 'field_filters' ] ) ) {
980 979
 				gravityview()->log->notice( 'search_criteria/field_filters is not empty, third-party code may be using legacy search_criteria filters.' );
981 980
 			}
982 981
 
983 982
 			$entries = $this->form->get_entries( $this )
984
-				->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters['search_criteria'] ) )
983
+				->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters[ 'search_criteria' ] ) )
985 984
 				->offset( $this->settings->get( 'offset' ) )
986
-				->limit( $parameters['paging']['page_size'] )
985
+				->limit( $parameters[ 'paging' ][ 'page_size' ] )
987 986
 				->page( $page );
988 987
 
989 988
 
990
-			if ( ! empty( $parameters['sorting'] ) && ! empty( $parameters['sorting']['key'] ) ) {
989
+			if ( ! empty( $parameters[ 'sorting' ] ) && ! empty( $parameters[ 'sorting' ][ 'key' ] ) ) {
991 990
 				$field = new \GV\Field();
992
-				$field->ID = $parameters['sorting']['key'];
993
-				$direction = strtolower( $parameters['sorting']['direction'] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
991
+				$field->ID = $parameters[ 'sorting' ][ 'key' ];
992
+				$direction = strtolower( $parameters[ 'sorting' ][ 'direction' ] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
994 993
 				$entries = $entries->sort( new \GV\Entry_Sort( $field, $direction ) );
995 994
 			}
996 995
 		}
@@ -1064,7 +1063,7 @@  discard block
 block discarded – undo
1064 1063
 		$allowed = $headers = array();
1065 1064
 
1066 1065
 		foreach ( $view->fields->by_position( "directory_*" )->by_visible( $view )->all() as $id => $field ) {
1067
-			$allowed[] = $field;
1066
+			$allowed[ ] = $field;
1068 1067
 		}
1069 1068
 
1070 1069
 		$renderer = new Field_Renderer();
@@ -1086,17 +1085,17 @@  discard block
 block discarded – undo
1086 1085
 			} );
1087 1086
 
1088 1087
 			foreach ( array_diff( $allowed_field_ids, wp_list_pluck( $allowed, 'ID' ) ) as $field_id ) {
1089
-				$allowed[] = is_numeric( $field_id ) ? \GV\GF_Field::by_id( $view->form, $field_id ) : \GV\Internal_Field::by_id( $field_id );
1088
+				$allowed[ ] = is_numeric( $field_id ) ? \GV\GF_Field::by_id( $view->form, $field_id ) : \GV\Internal_Field::by_id( $field_id );
1090 1089
 			}
1091 1090
 
1092 1091
 			foreach ( $allowed as $field ) {
1093 1092
 				$source = is_numeric( $field->ID ) ? $view->form : new \GV\Internal_Source();
1094 1093
 
1095
-				$return[] = $renderer->render( $field, $view, $source, $entry, gravityview()->request, '\GV\Field_CSV_Template' );
1094
+				$return[ ] = $renderer->render( $field, $view, $source, $entry, gravityview()->request, '\GV\Field_CSV_Template' );
1096 1095
 
1097 1096
 				if ( ! $headers_done ) {
1098 1097
 					$label = $field->get_label( $view, $source, $entry );
1099
-					$headers[] = $label ? $label : $field->ID;
1098
+					$headers[ ] = $label ? $label : $field->ID;
1100 1099
 				}
1101 1100
 			}
1102 1101
 
Please login to merge, or discard this patch.
future/includes/class-gv-shortcode-gventry.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -47,22 +47,22 @@  discard block
 block discarded – undo
47 47
 		 */
48 48
 		$atts = apply_filters( 'gravityview/shortcodes/gventry/atts', $atts );
49 49
 
50
-		$view = \GV\View::by_id( $atts['view_id'] );
50
+		$view = \GV\View::by_id( $atts[ 'view_id' ] );
51 51
 
52 52
 		if ( ! $view ) {
53
-			gravityview()->log->error( 'View does not exist #{view_id}', array( 'view_id' => $atts['view_id'] ) );
53
+			gravityview()->log->error( 'View does not exist #{view_id}', array( 'view_id' => $atts[ 'view_id' ] ) );
54 54
 			return apply_filters( 'gravityview/shortcodes/gventry/output', '', null, null, $atts );
55 55
 		}
56 56
 
57
-		$entry_id = ! empty( $atts['entry_id'] ) ? $atts['entry_id'] : $atts['id'];
57
+		$entry_id = ! empty( $atts[ 'entry_id' ] ) ? $atts[ 'entry_id' ] : $atts[ 'id' ];
58 58
 
59
-		switch( $entry_id ):
59
+		switch ( $entry_id ):
60 60
 			case 'last':
61 61
 				$entries = $view->get_entries( null );
62 62
 
63 63
 				/** If a sort already exists, reverse it. */
64 64
 				if ( $sort = end( $entries->sorts ) ) {
65
-					$entries = $entries->sort( new \GV\Entry_Sort( $sort->field, $sort->direction == \GV\Entry_Sort::RAND ? : ( $sort->direction == \GV\Entry_Sort::ASC ? \GV\Entry_Sort::DESC : \GV\Entry_Sort::ASC ) ), $sort->mode );
65
+					$entries = $entries->sort( new \GV\Entry_Sort( $sort->field, $sort->direction == \GV\Entry_Sort::RAND ?: ( $sort->direction == \GV\Entry_Sort::ASC ? \GV\Entry_Sort::DESC : \GV\Entry_Sort::ASC ) ), $sort->mode );
66 66
 				} else {
67 67
 					/** Otherwise, sort by date_created */
68 68
 					$entries = $entries->sort( new \GV\Entry_Sort( \GV\Internal_Field::by_id( 'id' ), \GV\Entry_Sort::ASC ), \GV\Entry_Sort::NUMERIC );
@@ -79,12 +79,12 @@  discard block
 block discarded – undo
79 79
 				break;
80 80
 			default:
81 81
 				if ( ! $entry = \GV\GF_Entry::by_id( $entry_id ) ) {
82
-					gravityview()->log->error( 'Entry #{entry_id} not found', array( 'view_id' => $atts['view_id'] ) );
82
+					gravityview()->log->error( 'Entry #{entry_id} not found', array( 'view_id' => $atts[ 'view_id' ] ) );
83 83
 					return apply_filters( 'gravityview/shortcodes/gventry/output', '', $view, null, $atts );
84 84
 				}
85 85
 		endswitch;
86 86
 
87
-		if ( $view->form->ID != $entry['form_id'] ) {
87
+		if ( $view->form->ID != $entry[ 'form_id' ] ) {
88 88
 			gravityview()->log->error( 'Entry does not belong to view (form mismatch)' );
89 89
 			return apply_filters( 'gravityview/shortcodes/gventry/output', '', $view, $entry, $atts );
90 90
 		}
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 			return apply_filters( 'gravityview/shortcodes/gventry/output', get_the_password_form( $view->ID ), $view, $entry, $atts );
95 95
 		}
96 96
 
97
-		if ( ! $view->form  ) {
97
+		if ( ! $view->form ) {
98 98
 			gravityview()->log->notice( 'View #{id} has no form attached to it.', array( 'id' => $view->ID ) );
99 99
 
100 100
 			/**
@@ -117,43 +117,43 @@  discard block
 block discarded – undo
117 117
 		}
118 118
 
119 119
 		/** Unapproved entries. */
120
-		if ( $entry['status'] != 'active' ) {
120
+		if ( $entry[ 'status' ] != 'active' ) {
121 121
 			gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
122 122
 			return apply_filters( 'gravityview/shortcodes/gventry/output', '', $view, $entry, $atts );
123 123
 		}
124 124
 
125
-		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap('gravityview_moderate_entries', $view->ID );
125
+		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap( 'gravityview_moderate_entries', $view->ID );
126 126
 
127 127
 		if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
128
-			if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
128
+			if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
129 129
 				gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
130 130
 				return apply_filters( 'gravityview/shortcodes/gventry/output', '', $view, $entry, $atts );
131 131
 			}
132 132
 		}
133 133
 
134
-		if ( $atts['edit'] ) {
134
+		if ( $atts[ 'edit' ] ) {
135 135
 			/**
136 136
 			 * Based on code in our unit-tests.
137 137
 			 * Mocks old context, etc.
138 138
 			 */
139 139
 			$loader = \GravityView_Edit_Entry::getInstance();
140
-			$render = $loader->instances['render'];
140
+			$render = $loader->instances[ 'render' ];
141 141
 
142 142
 			add_filter( 'gravityview/is_single_entry', '__return_true' );
143 143
 
144
-			$form = \GFAPI::get_form( $entry['form_id'] );
144
+			$form = \GFAPI::get_form( $entry[ 'form_id' ] );
145 145
 
146 146
 			$data = \GravityView_View_Data::getInstance( $view );
147 147
 			$template = \GravityView_View::getInstance( array(
148 148
 				'form' => $form,
149
-				'form_id' => $form['id'],
149
+				'form_id' => $form[ 'id' ],
150 150
 				'view_id' => $view->ID,
151 151
 				'entries' => array( $entry ),
152 152
 				'atts' => \GVCommon::get_template_settings( $view->ID ),
153 153
 			) );
154 154
 
155
-			$_GET['edit'] = wp_create_nonce(
156
-				\GravityView_Edit_Entry::get_nonce_key( $view->ID, $form['id'], $entry['id'] )
155
+			$_GET[ 'edit' ] = wp_create_nonce(
156
+				\GravityView_Edit_Entry::get_nonce_key( $view->ID, $form[ 'id' ], $entry[ 'id' ] )
157 157
 			);
158 158
 
159 159
 			add_filter( 'gravityview/edit_entry/success', $callback = function( $message ) use ( $view, $entry, $atts ) {
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
 				return apply_filters( 'gravityview/shortcodes/gventry/edit/success', $message, $view, $entry, $atts );
171 171
 			} );
172 172
 
173
-			ob_start() && $render->init( $data, \GV\Entry::by_id( $entry['id'] ), $view );
173
+			ob_start() && $render->init( $data, \GV\Entry::by_id( $entry[ 'id' ] ), $view );
174 174
 			$output = ob_get_clean(); // Render :)
175 175
 
176 176
 			remove_filter( 'gravityview/is_single_entry', '__return_true' );
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
 			$renderer = new \GV\Entry_Renderer();
183 183
 
184 184
 			$request = new \GV\Mock_Request();
185
-			$request->returns['is_entry'] = $entry;
185
+			$request->returns[ 'is_entry' ] = $entry;
186 186
 
187 187
 			$output = $renderer->render( $entry, $view, $request );
188 188
 
Please login to merge, or discard this patch.
includes/widgets/search-widget/class-search-widget.php 1 patch
Spacing   +172 added lines, -172 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 				'type' => 'radio',
65 65
 				'full_width' => true,
66 66
 				'label' => esc_html__( 'Search Mode', 'gravityview' ),
67
-				'desc' => __('Should search results match all search fields, or any?', 'gravityview'),
67
+				'desc' => __( 'Should search results match all search fields, or any?', 'gravityview' ),
68 68
 				'value' => 'any',
69 69
 				'class' => 'hide-if-js',
70 70
 				'options' => array(
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 
84 84
 			// admin - add scripts - run at 1100 to make sure GravityView_Admin_Views::add_scripts_and_styles() runs first at 999
85 85
 			add_action( 'admin_enqueue_scripts', array( $this, 'add_scripts_and_styles' ), 1100 );
86
-			add_action( 'wp_enqueue_scripts', array( $this, 'register_scripts') );
86
+			add_action( 'wp_enqueue_scripts', array( $this, 'register_scripts' ) );
87 87
 			add_filter( 'gravityview_noconflict_scripts', array( $this, 'register_no_conflict' ) );
88 88
 
89 89
 			// ajax - get the searchable fields
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
 		$script_min = ( defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ) ? '' : '.min';
228 228
 		$script_source = empty( $script_min ) ? '/source' : '';
229 229
 
230
-		wp_enqueue_script( 'gravityview_searchwidget_admin', plugins_url( 'assets/js'.$script_source.'/admin-search-widget'.$script_min.'.js', __FILE__ ), array( 'jquery', 'gravityview_views_scripts' ), \GV\Plugin::$version );
230
+		wp_enqueue_script( 'gravityview_searchwidget_admin', plugins_url( 'assets/js' . $script_source . '/admin-search-widget' . $script_min . '.js', __FILE__ ), array( 'jquery', 'gravityview_views_scripts' ), \GV\Plugin::$version );
231 231
 
232 232
 		wp_localize_script( 'gravityview_searchwidget_admin', 'gvSearchVar', array(
233 233
 			'nonce' => wp_create_nonce( 'gravityview_ajaxsearchwidget' ),
@@ -249,7 +249,7 @@  discard block
 block discarded – undo
249 249
 	 * @return array Scripts allowed in no-conflict mode, plus the search widget script
250 250
 	 */
251 251
 	public function register_no_conflict( $allowed ) {
252
-		$allowed[] = 'gravityview_searchwidget_admin';
252
+		$allowed[ ] = 'gravityview_searchwidget_admin';
253 253
 		return $allowed;
254 254
 	}
255 255
 
@@ -262,24 +262,24 @@  discard block
 block discarded – undo
262 262
 	 */
263 263
 	public static function get_searchable_fields() {
264 264
 
265
-		if ( ! isset( $_POST['nonce'] ) || ! wp_verify_nonce( $_POST['nonce'], 'gravityview_ajaxsearchwidget' ) ) {
265
+		if ( ! isset( $_POST[ 'nonce' ] ) || ! wp_verify_nonce( $_POST[ 'nonce' ], 'gravityview_ajaxsearchwidget' ) ) {
266 266
 			exit( '0' );
267 267
 		}
268 268
 
269 269
 		$form = '';
270 270
 
271 271
 		// Fetch the form for the current View
272
-		if ( ! empty( $_POST['view_id'] ) ) {
272
+		if ( ! empty( $_POST[ 'view_id' ] ) ) {
273 273
 
274
-			$form = gravityview_get_form_id( $_POST['view_id'] );
274
+			$form = gravityview_get_form_id( $_POST[ 'view_id' ] );
275 275
 
276
-		} elseif ( ! empty( $_POST['formid'] ) ) {
276
+		} elseif ( ! empty( $_POST[ 'formid' ] ) ) {
277 277
 
278
-			$form = (int) $_POST['formid'];
278
+			$form = (int)$_POST[ 'formid' ];
279 279
 
280
-		} elseif ( ! empty( $_POST['template_id'] ) && class_exists( 'GravityView_Ajax' ) ) {
280
+		} elseif ( ! empty( $_POST[ 'template_id' ] ) && class_exists( 'GravityView_Ajax' ) ) {
281 281
 
282
-			$form = GravityView_Ajax::pre_get_form_fields( $_POST['template_id'] );
282
+			$form = GravityView_Ajax::pre_get_form_fields( $_POST[ 'template_id' ] );
283 283
 
284 284
 		}
285 285
 
@@ -329,14 +329,14 @@  discard block
 block discarded – undo
329 329
 		);
330 330
 
331 331
 		if ( gravityview()->plugin->supports( \GV\Plugin::FEATURE_GFQUERY ) ) {
332
-			$custom_fields['is_approved'] = array(
332
+			$custom_fields[ 'is_approved' ] = array(
333 333
 				'text' => esc_html__( 'Approval Status', 'gravityview' ),
334 334
 				'type' => 'multi',
335 335
 			);
336 336
 		}
337 337
 
338
-		foreach( $custom_fields as $custom_field_key => $custom_field ) {
339
-			$output .= sprintf( '<option value="%s" %s data-inputtypes="%s" data-placeholder="%s">%s</option>', $custom_field_key, selected( $custom_field_key, $current, false ), $custom_field['type'], self::get_field_label( array('field' => $custom_field_key ) ), $custom_field['text'] );
338
+		foreach ( $custom_fields as $custom_field_key => $custom_field ) {
339
+			$output .= sprintf( '<option value="%s" %s data-inputtypes="%s" data-placeholder="%s">%s</option>', $custom_field_key, selected( $custom_field_key, $current, false ), $custom_field[ 'type' ], self::get_field_label( array( 'field' => $custom_field_key ) ), $custom_field[ 'text' ] );
340 340
 		}
341 341
 
342 342
 		// Get fields with sub-inputs and no parent
@@ -358,13 +358,13 @@  discard block
 block discarded – undo
358 358
 
359 359
 			foreach ( $fields as $id => $field ) {
360 360
 
361
-				if ( in_array( $field['type'], $blacklist_field_types ) ) {
361
+				if ( in_array( $field[ 'type' ], $blacklist_field_types ) ) {
362 362
 					continue;
363 363
 				}
364 364
 
365
-				$types = self::get_search_input_types( $id, $field['type'] );
365
+				$types = self::get_search_input_types( $id, $field[ 'type' ] );
366 366
 
367
-				$output .= '<option value="'. $id .'" '. selected( $id, $current, false ).'data-inputtypes="'. esc_attr( $types ) .'">'. esc_html( $field['label'] ) .'</option>';
367
+				$output .= '<option value="' . $id . '" ' . selected( $id, $current, false ) . 'data-inputtypes="' . esc_attr( $types ) . '">' . esc_html( $field[ 'label' ] ) . '</option>';
368 368
 			}
369 369
 		}
370 370
 
@@ -387,7 +387,7 @@  discard block
 block discarded – undo
387 387
 	public static function get_search_input_types( $field_id = '', $field_type = null ) {
388 388
 
389 389
 		// @todo - This needs to be improved - many fields have . including products and addresses
390
-		if ( false !== strpos( (string) $field_id, '.' ) && in_array( $field_type, array( 'checkbox' ) ) || in_array( $field_id, array( 'is_fulfilled' ) ) ) {
390
+		if ( false !== strpos( (string)$field_id, '.' ) && in_array( $field_type, array( 'checkbox' ) ) || in_array( $field_id, array( 'is_fulfilled' ) ) ) {
391 391
 			$input_type = 'boolean'; // on/off checkbox
392 392
 		} elseif ( in_array( $field_type, array( 'checkbox', 'post_category', 'multiselect' ) ) ) {
393 393
 			$input_type = 'multi'; //multiselect
@@ -433,19 +433,19 @@  discard block
 block discarded – undo
433 433
 			$post_id = 0;
434 434
 
435 435
 			// We're in the WordPress Widget context, and an overriding post ID has been set.
436
-			if ( ! empty( $widget_args['post_id'] ) ) {
437
-				$post_id = absint( $widget_args['post_id'] );
436
+			if ( ! empty( $widget_args[ 'post_id' ] ) ) {
437
+				$post_id = absint( $widget_args[ 'post_id' ] );
438 438
 			}
439 439
 			// We're in the WordPress Widget context, and the base View ID should be used
440
-			else if ( ! empty( $widget_args['view_id'] ) ) {
441
-				$post_id = absint( $widget_args['view_id'] );
440
+			else if ( ! empty( $widget_args[ 'view_id' ] ) ) {
441
+				$post_id = absint( $widget_args[ 'view_id' ] );
442 442
 			}
443 443
 
444 444
 			$args = gravityview_get_permalink_query_args( $post_id );
445 445
 
446 446
 			// Add hidden fields to the search form
447 447
 			foreach ( $args as $key => $value ) {
448
-				$search_fields[] = array(
448
+				$search_fields[ ] = array(
449 449
 					'name'  => $key,
450 450
 					'input' => 'hidden',
451 451
 					'value' => $value,
@@ -484,28 +484,28 @@  discard block
 block discarded – undo
484 484
 		/**
485 485
 		 * Include the sidebar Widgets.
486 486
 		 */
487
-		$widgets = (array) get_option( 'widget_gravityview_search', array() );
487
+		$widgets = (array)get_option( 'widget_gravityview_search', array() );
488 488
 
489 489
 		foreach ( $widgets as $widget ) {
490
-			if ( ! empty( $widget['view_id'] ) && $widget['view_id'] == $view->ID ) {
491
-				if( $_fields = json_decode( $widget['search_fields'], true ) ) {
490
+			if ( ! empty( $widget[ 'view_id' ] ) && $widget[ 'view_id' ] == $view->ID ) {
491
+				if ( $_fields = json_decode( $widget[ 'search_fields' ], true ) ) {
492 492
 					foreach ( $_fields as $field ) {
493
-						if ( empty( $field['form_id'] ) ) {
494
-							$field['form_id'] = $view->form ? $view->form->ID : 0;
493
+						if ( empty( $field[ 'form_id' ] ) ) {
494
+							$field[ 'form_id' ] = $view->form ? $view->form->ID : 0;
495 495
 						}
496
-						$searchable_fields[] = $with_full_field ? $field : $field['field'];
496
+						$searchable_fields[ ] = $with_full_field ? $field : $field[ 'field' ];
497 497
 					}
498 498
 				}
499 499
 			}
500 500
 		}
501 501
 
502 502
 		foreach ( $view->widgets->by_id( $this->get_widget_id() )->all() as $widget ) {
503
-			if( $_fields = json_decode( $widget->configuration->get( 'search_fields' ), true ) ) {
503
+			if ( $_fields = json_decode( $widget->configuration->get( 'search_fields' ), true ) ) {
504 504
 				foreach ( $_fields as $field ) {
505
-					if ( empty( $field['form_id'] ) ) {
506
-						$field['form_id'] = $view->form ? $view->form->ID : 0;
505
+					if ( empty( $field[ 'form_id' ] ) ) {
506
+						$field[ 'form_id' ] = $view->form ? $view->form->ID : 0;
507 507
 					}
508
-					$searchable_fields[] = $with_full_field ? $field : $field['field'];
508
+					$searchable_fields[ ] = $with_full_field ? $field : $field[ 'field' ];
509 509
 				}
510 510
 			}
511 511
 		}
@@ -543,7 +543,7 @@  discard block
 block discarded – undo
543 543
 			return $search_criteria; // Return the original criteria, GF_Query modification kicks in later
544 544
 		}
545 545
 
546
-		if( 'post' === $this->search_method ) {
546
+		if ( 'post' === $this->search_method ) {
547 547
 			$get = $_POST;
548 548
 		} else {
549 549
 			$get = $_GET;
@@ -562,15 +562,15 @@  discard block
 block discarded – undo
562 562
 		$get = gv_map_deep( $get, 'rawurldecode' );
563 563
 
564 564
 		// Make sure array key is set up
565
-		$search_criteria['field_filters'] = \GV\Utils::get( $search_criteria, 'field_filters', array() );
565
+		$search_criteria[ 'field_filters' ] = \GV\Utils::get( $search_criteria, 'field_filters', array() );
566 566
 
567 567
 		$searchable_fields = $this->get_view_searchable_fields( $view );
568 568
 		$searchable_field_objects = $this->get_view_searchable_fields( $view, true );
569 569
 
570 570
 		// add free search
571
-		if ( isset( $get['gv_search'] ) && '' !== $get['gv_search'] && in_array( 'search_all', $searchable_fields ) ) {
571
+		if ( isset( $get[ 'gv_search' ] ) && '' !== $get[ 'gv_search' ] && in_array( 'search_all', $searchable_fields ) ) {
572 572
 
573
-			$search_all_value = trim( $get['gv_search'] );
573
+			$search_all_value = trim( $get[ 'gv_search' ] );
574 574
 
575 575
 			/**
576 576
 			 * @filter `gravityview/search-all-split-words` Search for each word separately or the whole phrase?
@@ -595,7 +595,7 @@  discard block
 block discarded – undo
595 595
 			}
596 596
 
597 597
 			foreach ( $words as $word ) {
598
-				$search_criteria['field_filters'][] = array(
598
+				$search_criteria[ 'field_filters' ][ ] = array(
599 599
 					'key' => null, // The field ID to search
600 600
 					'value' => $word, // The value to search
601 601
 					'operator' => 'contains', // What to search in. Options: `is` or `contains`
@@ -608,14 +608,14 @@  discard block
 block discarded – undo
608 608
 			/**
609 609
 			 * Get and normalize the dates according to the input format.
610 610
 			 */
611
-			if ( $curr_start = ! empty( $get['gv_start'] ) ? $get['gv_start'] : '' ) {
612
-				if( $curr_start_date = date_create_from_format( $this->get_datepicker_format( true ), $curr_start ) ) {
611
+			if ( $curr_start = ! empty( $get[ 'gv_start' ] ) ? $get[ 'gv_start' ] : '' ) {
612
+				if ( $curr_start_date = date_create_from_format( $this->get_datepicker_format( true ), $curr_start ) ) {
613 613
 					$curr_start = $curr_start_date->format( 'Y-m-d' );
614 614
 				}
615 615
 			}
616 616
 
617
-			if ( $curr_end = ! empty( $get['gv_start'] ) ? ( ! empty( $get['gv_end'] ) ? $get['gv_end'] : '' ) : '' ) {
618
-				if( $curr_end_date = date_create_from_format( $this->get_datepicker_format( true ), $curr_end ) ) {
617
+			if ( $curr_end = ! empty( $get[ 'gv_start' ] ) ? ( ! empty( $get[ 'gv_end' ] ) ? $get[ 'gv_end' ] : '' ) : '' ) {
618
+				if ( $curr_end_date = date_create_from_format( $this->get_datepicker_format( true ), $curr_end ) ) {
619 619
 					$curr_end = $curr_end_date->format( 'Y-m-d' );
620 620
 				}
621 621
 			}
@@ -650,22 +650,22 @@  discard block
 block discarded – undo
650 650
 			 */
651 651
 			if ( ! empty( $curr_start ) ) {
652 652
 				$curr_start = date( 'Y-m-d H:i:s', strtotime( $curr_start ) );
653
-				$search_criteria['start_date'] = $adjust_tz ? get_gmt_from_date( $curr_start ) : $curr_start;
653
+				$search_criteria[ 'start_date' ] = $adjust_tz ? get_gmt_from_date( $curr_start ) : $curr_start;
654 654
 			}
655 655
 
656 656
 			if ( ! empty( $curr_end ) ) {
657 657
 				// Fast-forward 24 hour on the end time
658 658
 				$curr_end = date( 'Y-m-d H:i:s', strtotime( $curr_end ) + DAY_IN_SECONDS );
659
-				$search_criteria['end_date'] = $adjust_tz ? get_gmt_from_date( $curr_end ) : $curr_end;
660
-				if ( strpos( $search_criteria['end_date'], '00:00:00' ) ) { // See https://github.com/gravityview/GravityView/issues/1056
661
-					$search_criteria['end_date'] = date( 'Y-m-d H:i:s', strtotime( $search_criteria['end_date'] ) - 1 );
659
+				$search_criteria[ 'end_date' ] = $adjust_tz ? get_gmt_from_date( $curr_end ) : $curr_end;
660
+				if ( strpos( $search_criteria[ 'end_date' ], '00:00:00' ) ) { // See https://github.com/gravityview/GravityView/issues/1056
661
+					$search_criteria[ 'end_date' ] = date( 'Y-m-d H:i:s', strtotime( $search_criteria[ 'end_date' ] ) - 1 );
662 662
 				}
663 663
 			}
664 664
 		}
665 665
 
666 666
 		// search for a specific entry ID
667 667
 		if ( ! empty( $get[ 'gv_id' ] ) && in_array( 'entry_id', $searchable_fields ) ) {
668
-			$search_criteria['field_filters'][] = array(
668
+			$search_criteria[ 'field_filters' ][ ] = array(
669 669
 				'key' => 'id',
670 670
 				'value' => absint( $get[ 'gv_id' ] ),
671 671
 				'operator' => $this->get_operator( $get, 'gv_id', array( '=' ), '=' ),
@@ -674,20 +674,20 @@  discard block
 block discarded – undo
674 674
 
675 675
 		// search for a specific Created_by ID
676 676
 		if ( ! empty( $get[ 'gv_by' ] ) && in_array( 'created_by', $searchable_fields ) ) {
677
-			$search_criteria['field_filters'][] = array(
677
+			$search_criteria[ 'field_filters' ][ ] = array(
678 678
 				'key' => 'created_by',
679
-				'value' => $get['gv_by'],
679
+				'value' => $get[ 'gv_by' ],
680 680
 				'operator' => $this->get_operator( $get, 'gv_by', array( '=' ), '=' ),
681 681
 			);
682 682
 		}
683 683
 
684 684
 		// Get search mode passed in URL
685
-		$mode = isset( $get['mode'] ) && in_array( $get['mode'], array( 'any', 'all' ) ) ?  $get['mode'] : 'any';
685
+		$mode = isset( $get[ 'mode' ] ) && in_array( $get[ 'mode' ], array( 'any', 'all' ) ) ? $get[ 'mode' ] : 'any';
686 686
 
687 687
 		// get the other search filters
688 688
 		foreach ( $get as $key => $value ) {
689 689
 
690
-			if ( 0 !== strpos( $key, 'filter_' ) || gv_empty( $value, false, false ) || ( is_array( $value ) && count( $value ) === 1 && gv_empty( $value[0], false, false ) ) ) {
690
+			if ( 0 !== strpos( $key, 'filter_' ) || gv_empty( $value, false, false ) || ( is_array( $value ) && count( $value ) === 1 && gv_empty( $value[ 0 ], false, false ) ) ) {
691 691
 				continue; // Not a filter, or empty
692 692
 			}
693 693
 
@@ -701,19 +701,19 @@  discard block
 block discarded – undo
701 701
 				continue;
702 702
 			}
703 703
 
704
-			if ( ! isset( $filter['operator'] ) ) {
705
-				$filter['operator'] = $this->get_operator( $get, $key, array( 'contains' ), 'contains' );
704
+			if ( ! isset( $filter[ 'operator' ] ) ) {
705
+				$filter[ 'operator' ] = $this->get_operator( $get, $key, array( 'contains' ), 'contains' );
706 706
 			}
707 707
 
708
-			if ( isset( $filter[0]['value'] ) ) {
709
-				$search_criteria['field_filters'] = array_merge( $search_criteria['field_filters'], $filter );
708
+			if ( isset( $filter[ 0 ][ 'value' ] ) ) {
709
+				$search_criteria[ 'field_filters' ] = array_merge( $search_criteria[ 'field_filters' ], $filter );
710 710
 
711 711
 				// if date range type, set search mode to ALL
712
-				if ( ! empty( $filter[0]['operator'] ) && in_array( $filter[0]['operator'], array( '>=', '<=', '>', '<' ) ) ) {
712
+				if ( ! empty( $filter[ 0 ][ 'operator' ] ) && in_array( $filter[ 0 ][ 'operator' ], array( '>=', '<=', '>', '<' ) ) ) {
713 713
 					$mode = 'all';
714 714
 				}
715
-			} elseif( !empty( $filter ) ) {
716
-				$search_criteria['field_filters'][] = $filter;
715
+			} elseif ( ! empty( $filter ) ) {
716
+				$search_criteria[ 'field_filters' ][ ] = $filter;
717 717
 			}
718 718
 		}
719 719
 
@@ -722,7 +722,7 @@  discard block
 block discarded – undo
722 722
 		 * @since 1.5.1
723 723
 		 * @param[out,in] string $mode Search mode (`any` vs `all`)
724 724
 		 */
725
-		$search_criteria['field_filters']['mode'] = apply_filters( 'gravityview/search/mode', $mode );
725
+		$search_criteria[ 'field_filters' ][ 'mode' ] = apply_filters( 'gravityview/search/mode', $mode );
726 726
 
727 727
 		gravityview()->log->debug( 'Returned Search Criteria: ', array( 'data' => $search_criteria ) );
728 728
 
@@ -756,19 +756,19 @@  discard block
 block discarded – undo
756 756
 
757 757
 		$query_class = $view->form->get_query_class( $view );
758 758
 
759
-		if ( empty( $search_criteria['field_filters'] ) ) {
759
+		if ( empty( $search_criteria[ 'field_filters' ] ) ) {
760 760
 			return;
761 761
 		}
762 762
 
763 763
 		$widgets = $view->widgets->by_id( $this->widget_id );
764 764
 		if ( $widgets->count() ) {
765 765
 			$widgets = $widgets->all();
766
-			$widget  = $widgets[0];
766
+			$widget  = $widgets[ 0 ];
767 767
 
768 768
 			$search_fields = json_decode( $widget->configuration->get( 'search_fields' ), true );
769 769
 
770
-			foreach ( (array) $search_fields as $search_field ) {
771
-				if ( 'created_by' === $search_field['field'] && 'input_text' === $search_field['input'] ) {
770
+			foreach ( (array)$search_fields as $search_field ) {
771
+				if ( 'created_by' === $search_field[ 'field' ] && 'input_text' === $search_field[ 'input' ] ) {
772 772
 					$created_by_text_mode = true;
773 773
 				}
774 774
 			}
@@ -777,7 +777,7 @@  discard block
 block discarded – undo
777 777
 		$extra_conditions = array();
778 778
 		$mode = 'any';
779 779
 
780
-		foreach ( $search_criteria['field_filters'] as &$filter ) {
780
+		foreach ( $search_criteria[ 'field_filters' ] as &$filter ) {
781 781
 			if ( ! is_array( $filter ) ) {
782 782
 				if ( in_array( strtolower( $filter ), array( 'any', 'all' ) ) ) {
783 783
 					$mode = $filter;
@@ -786,13 +786,13 @@  discard block
 block discarded – undo
786 786
 			}
787 787
 
788 788
 			// Construct a manual query for unapproved statuses
789
-			if ( 'is_approved' === $filter['key'] && in_array( \GravityView_Entry_Approval_Status::UNAPPROVED, (array) $filter['value'] ) ) {
790
-				$_tmp_query       = new $query_class( $view->form->ID, array(
789
+			if ( 'is_approved' === $filter[ 'key' ] && in_array( \GravityView_Entry_Approval_Status::UNAPPROVED, (array)$filter[ 'value' ] ) ) {
790
+				$_tmp_query = new $query_class( $view->form->ID, array(
791 791
 					'field_filters' => array(
792 792
 						array(
793 793
 							'operator' => 'in',
794 794
 							'key'      => 'is_approved',
795
-							'value'    => (array) $filter['value'],
795
+							'value'    => (array)$filter[ 'value' ],
796 796
 						),
797 797
 						array(
798 798
 							'operator' => 'is',
@@ -804,30 +804,30 @@  discard block
 block discarded – undo
804 804
 				) );
805 805
 				$_tmp_query_parts = $_tmp_query->_introspect();
806 806
 
807
-				$extra_conditions[] = $_tmp_query_parts['where'];
807
+				$extra_conditions[ ] = $_tmp_query_parts[ 'where' ];
808 808
 
809 809
 				$filter = false;
810 810
 				continue;
811 811
 			}
812 812
 
813 813
 			// Construct manual query for text mode creator search
814
-			if ( 'created_by' === $filter['key'] && ! empty( $created_by_text_mode ) ) {
815
-				$extra_conditions[] = new GravityView_Widget_Search_Author_GF_Query_Condition( $filter, $view );
814
+			if ( 'created_by' === $filter[ 'key' ] && ! empty( $created_by_text_mode ) ) {
815
+				$extra_conditions[ ] = new GravityView_Widget_Search_Author_GF_Query_Condition( $filter, $view );
816 816
 				$filter = false;
817 817
 				continue;
818 818
 			}
819 819
 
820 820
 			// By default, we want searches to be wildcard for each field.
821
-			$filter['operator'] = empty( $filter['operator'] ) ? 'contains' : $filter['operator'];
821
+			$filter[ 'operator' ] = empty( $filter[ 'operator' ] ) ? 'contains' : $filter[ 'operator' ];
822 822
 
823 823
 			// For multichoice, let's have an in (OR) search.
824
-			if ( is_array( $filter['value'] ) ) {
825
-				$filter['operator'] = 'in'; // @todo what about in contains (OR LIKE chains)?
824
+			if ( is_array( $filter[ 'value' ] ) ) {
825
+				$filter[ 'operator' ] = 'in'; // @todo what about in contains (OR LIKE chains)?
826 826
 			}
827 827
 
828 828
 			// Default form with joins functionality
829
-			if ( empty( $filter['form_id'] ) ) {
830
-				$filter['form_id'] = $view->form ? $view->form->ID : 0;
829
+			if ( empty( $filter[ 'form_id' ] ) ) {
830
+				$filter[ 'form_id' ] = $view->form ? $view->form->ID : 0;
831 831
 			}
832 832
 
833 833
 			/**
@@ -837,28 +837,28 @@  discard block
 block discarded – undo
837 837
 			 * @since develop
838 838
 			 * @param \GV\View $view The View we're operating on.
839 839
 			 */
840
-			$filter['operator'] = apply_filters( 'gravityview_search_operator', $filter['operator'], $filter, $view );
840
+			$filter[ 'operator' ] = apply_filters( 'gravityview_search_operator', $filter[ 'operator' ], $filter, $view );
841 841
 		}
842 842
 
843
-		if ( ! empty( $search_criteria['start_date'] ) || ! empty( $search_criteria['end_date'] ) ) {
843
+		if ( ! empty( $search_criteria[ 'start_date' ] ) || ! empty( $search_criteria[ 'end_date' ] ) ) {
844 844
 			$date_criteria = array();
845 845
 
846
-			if ( isset( $search_criteria['start_date'] ) ) {
847
-				$date_criteria['start_date'] = $search_criteria['start_date'];
846
+			if ( isset( $search_criteria[ 'start_date' ] ) ) {
847
+				$date_criteria[ 'start_date' ] = $search_criteria[ 'start_date' ];
848 848
 			}
849 849
 
850
-			if ( isset( $search_criteria['end_date'] ) ) {
851
-				$date_criteria['end_date'] = $search_criteria['end_date'];
850
+			if ( isset( $search_criteria[ 'end_date' ] ) ) {
851
+				$date_criteria[ 'end_date' ] = $search_criteria[ 'end_date' ];
852 852
 			}
853 853
 
854 854
 			$_tmp_query         = new $query_class( $view->form->ID, $date_criteria );
855 855
 			$_tmp_query_parts   = $_tmp_query->_introspect();
856
-			$extra_conditions[] = $_tmp_query_parts['where'];
856
+			$extra_conditions[ ] = $_tmp_query_parts[ 'where' ];
857 857
 		}
858 858
 
859 859
 		$search_conditions = array();
860 860
 
861
-		if ( $filters = array_filter( $search_criteria['field_filters'] ) ) {
861
+		if ( $filters = array_filter( $search_criteria[ 'field_filters' ] ) ) {
862 862
 			foreach ( $filters as &$filter ) {
863 863
 				if ( ! is_array( $filter ) ) {
864 864
 					continue;
@@ -870,12 +870,12 @@  discard block
 block discarded – undo
870 870
 				 * code by reusing what's inside GF_Query already as they
871 871
 				 * take care of many small things like forcing numeric, etc.
872 872
 				 */
873
-				$_tmp_query       = new $query_class( $filter['form_id'], array( 'mode' => 'any', 'field_filters' => array( $filter ) ) );
873
+				$_tmp_query       = new $query_class( $filter[ 'form_id' ], array( 'mode' => 'any', 'field_filters' => array( $filter ) ) );
874 874
 				$_tmp_query_parts = $_tmp_query->_introspect();
875
-				$search_condition = $_tmp_query_parts['where'];
875
+				$search_condition = $_tmp_query_parts[ 'where' ];
876 876
 
877
-				if ( empty( $filter['key'] ) && $search_condition->expressions ) {
878
-					$search_conditions[] = $search_condition;
877
+				if ( empty( $filter[ 'key' ] ) && $search_condition->expressions ) {
878
+					$search_conditions[ ] = $search_condition;
879 879
 				} else {
880 880
 					$left = $search_condition->left;
881 881
 					$alias = $query->_alias( $left->field_id, $left->source, $left->is_entry_column() ? 't' : 'm' );
@@ -885,7 +885,7 @@  discard block
 block discarded – undo
885 885
 							$on = $_join->join_on;
886 886
 							$join = $_join->join;
887 887
 
888
-							$search_conditions[] = GF_Query_Condition::_or(
888
+							$search_conditions[ ] = GF_Query_Condition::_or(
889 889
 								// Join
890 890
 								new GF_Query_Condition(
891 891
 									new GF_Query_Column( GF_Query_Column::META, $join->ID, $query->_alias( GF_Query_Column::META, $join->ID, 'm' ) ),
@@ -901,7 +901,7 @@  discard block
 block discarded – undo
901 901
 							);
902 902
 						}
903 903
 					} else {
904
-						$search_conditions[] = new GF_Query_Condition(
904
+						$search_conditions[ ] = new GF_Query_Condition(
905 905
 							new GF_Query_Column( $left->field_id, $left->source, $alias ),
906 906
 							$search_condition->operator,
907 907
 							$search_condition->right
@@ -923,7 +923,7 @@  discard block
 block discarded – undo
923 923
 		/**
924 924
 		 * Combine the parts as a new WHERE clause.
925 925
 		 */
926
-		$where = call_user_func_array( '\GF_Query_Condition::_and', array_merge( array( $query_parts['where'] ), $search_conditions, $extra_conditions ) );
926
+		$where = call_user_func_array( '\GF_Query_Condition::_and', array_merge( array( $query_parts[ 'where' ] ), $search_conditions, $extra_conditions ) );
927 927
 		$query->where( $where );
928 928
 	}
929 929
 
@@ -946,7 +946,7 @@  discard block
 block discarded – undo
946 946
 		$field_id = str_replace( 'filter_', '', $key );
947 947
 
948 948
 		// calculates field_id, removing 'filter_' and for '_' for advanced fields ( like name or checkbox )
949
-		if ( preg_match('/^[0-9_]+$/ism', $field_id ) ) {
949
+		if ( preg_match( '/^[0-9_]+$/ism', $field_id ) ) {
950 950
 			$field_id = str_replace( '_', '.', $field_id );
951 951
 		}
952 952
 
@@ -1003,7 +1003,7 @@  discard block
 block discarded – undo
1003 1003
 			// form is in searchable fields
1004 1004
 			$found = false;
1005 1005
 			foreach ( $searchable_fields as $field ) {
1006
-				if ( $field_id == $field['field'] && $form->ID == $field['form_id'] ) {
1006
+				if ( $field_id == $field[ 'field' ] && $form->ID == $field[ 'form_id' ] ) {
1007 1007
 					$found = true;
1008 1008
 					break;
1009 1009
 				}
@@ -1043,7 +1043,7 @@  discard block
 block discarded – undo
1043 1043
 
1044 1044
 			case 'select':
1045 1045
 			case 'radio':
1046
-				$filter['operator'] = $this->get_operator( $get, $key, array( 'is' ), 'is' );
1046
+				$filter[ 'operator' ] = $this->get_operator( $get, $key, array( 'is' ), 'is' );
1047 1047
 				break;
1048 1048
 
1049 1049
 			case 'post_category':
@@ -1057,7 +1057,7 @@  discard block
 block discarded – undo
1057 1057
 
1058 1058
 				foreach ( $value as $val ) {
1059 1059
 					$cat = get_term( $val, 'category' );
1060
-					$filter[] = array(
1060
+					$filter[ ] = array(
1061 1061
 						'key'      => $field_id,
1062 1062
 						'value'    => esc_attr( $cat->name ) . ':' . $val,
1063 1063
 						'operator' => $this->get_operator( $get, $key, array( 'is' ), 'is' ),
@@ -1076,7 +1076,7 @@  discard block
 block discarded – undo
1076 1076
 				$filter = array();
1077 1077
 
1078 1078
 				foreach ( $value as $val ) {
1079
-					$filter[] = array( 'key' => $field_id, 'value' => $val );
1079
+					$filter[ ] = array( 'key' => $field_id, 'value' => $val );
1080 1080
 				}
1081 1081
 
1082 1082
 				break;
@@ -1085,9 +1085,9 @@  discard block
 block discarded – undo
1085 1085
 				// convert checkbox on/off into the correct search filter
1086 1086
 				if ( false !== strpos( $field_id, '.' ) && ! empty( $form_field->inputs ) && ! empty( $form_field->choices ) ) {
1087 1087
 					foreach ( $form_field->inputs as $k => $input ) {
1088
-						if ( $input['id'] == $field_id ) {
1089
-							$filter['value'] = $form_field->choices[ $k ]['value'];
1090
-							$filter['operator'] = $this->get_operator( $get, $key, array( 'is' ), 'is' );
1088
+						if ( $input[ 'id' ] == $field_id ) {
1089
+							$filter[ 'value' ] = $form_field->choices[ $k ][ 'value' ];
1090
+							$filter[ 'operator' ] = $this->get_operator( $get, $key, array( 'is' ), 'is' );
1091 1091
 							break;
1092 1092
 						}
1093 1093
 					}
@@ -1097,7 +1097,7 @@  discard block
 block discarded – undo
1097 1097
 					$filter = array();
1098 1098
 
1099 1099
 					foreach ( $value as $val ) {
1100
-						$filter[] = array(
1100
+						$filter[ ] = array(
1101 1101
 							'key'      => $field_id,
1102 1102
 							'value'    => $val,
1103 1103
 							'operator' => $this->get_operator( $get, $key, array( 'is' ), 'is' ),
@@ -1118,9 +1118,9 @@  discard block
 block discarded – undo
1118 1118
 					foreach ( $words as $word ) {
1119 1119
 						if ( ! empty( $word ) && strlen( $word ) > 1 ) {
1120 1120
 							// Keep the same key for each filter
1121
-							$filter['value'] = $word;
1121
+							$filter[ 'value' ] = $word;
1122 1122
 							// Add a search for the value
1123
-							$filters[] = $filter;
1123
+							$filters[ ] = $filter;
1124 1124
 						}
1125 1125
 					}
1126 1126
 
@@ -1134,19 +1134,19 @@  discard block
 block discarded – undo
1134 1134
 
1135 1135
 					foreach ( $searchable_fields as $searchable_field ) {
1136 1136
 
1137
-						if( $form_field->ID !== $searchable_field['field'] ) {
1137
+						if ( $form_field->ID !== $searchable_field[ 'field' ] ) {
1138 1138
 							continue;
1139 1139
 						}
1140 1140
 
1141 1141
 						// Only exact-match dropdowns, not text search
1142
-						if( in_array( $searchable_field['input'], array( 'text', 'search' ), true ) ) {
1142
+						if ( in_array( $searchable_field[ 'input' ], array( 'text', 'search' ), true ) ) {
1143 1143
 							continue;
1144 1144
 						}
1145 1145
 
1146 1146
 						$input_id = gravityview_get_input_id_from_id( $form_field->ID );
1147 1147
 
1148 1148
 						if ( 4 === $input_id ) {
1149
-							$filter['operator'] = $this->get_operator( $get, $key, array( 'is' ), 'is' );
1149
+							$filter[ 'operator' ] = $this->get_operator( $get, $key, array( 'is' ), 'is' );
1150 1150
 						};
1151 1151
 					}
1152 1152
 				}
@@ -1173,12 +1173,12 @@  discard block
 block discarded – undo
1173 1173
 						 * @since 1.16.3
1174 1174
 						 * Safeguard until GF implements '<=' operator
1175 1175
 						 */
1176
-						if( !GFFormsModel::is_valid_operator( $operator ) && $operator === '<=' ) {
1176
+						if ( ! GFFormsModel::is_valid_operator( $operator ) && $operator === '<=' ) {
1177 1177
 							$operator = '<';
1178 1178
 							$date = date( 'Y-m-d', strtotime( self::get_formatted_date( $date, 'Y-m-d', $date_format ) . ' +1 day' ) );
1179 1179
 						}
1180 1180
 
1181
-						$filter[] = array(
1181
+						$filter[ ] = array(
1182 1182
 							'key'      => $field_id,
1183 1183
 							'value'    => self::get_formatted_date( $date, 'Y-m-d', $date_format ),
1184 1184
 							'operator' => $this->get_operator( $get, $key, array( $operator ), $operator ),
@@ -1186,8 +1186,8 @@  discard block
 block discarded – undo
1186 1186
 					}
1187 1187
 				} else {
1188 1188
 					$date = $value;
1189
-					$filter['value'] = self::get_formatted_date( $date, 'Y-m-d', $date_format );
1190
-					$filter['operator'] = $this->get_operator( $get, $key, array( 'is' ), 'is' );
1189
+					$filter[ 'value' ] = self::get_formatted_date( $date, 'Y-m-d', $date_format );
1190
+					$filter[ 'operator' ] = $this->get_operator( $get, $key, array( 'is' ), 'is' );
1191 1191
 				}
1192 1192
 
1193 1193
 				break;
@@ -1218,7 +1218,7 @@  discard block
 block discarded – undo
1218 1218
 			'ymd_dot' => 'Y.m.d',
1219 1219
 		);
1220 1220
 
1221
-		if ( ! empty( $field->dateFormat ) && isset( $datepicker[ $field->dateFormat ] ) ){
1221
+		if ( ! empty( $field->dateFormat ) && isset( $datepicker[ $field->dateFormat ] ) ) {
1222 1222
 			$format = $datepicker[ $field->dateFormat ];
1223 1223
 		}
1224 1224
 
@@ -1255,7 +1255,7 @@  discard block
 block discarded – undo
1255 1255
 	public function add_template_path( $file_paths ) {
1256 1256
 
1257 1257
 		// Index 100 is the default GravityView template path.
1258
-		$file_paths[102] = self::$file . 'templates/';
1258
+		$file_paths[ 102 ] = self::$file . 'templates/';
1259 1259
 
1260 1260
 		return $file_paths;
1261 1261
 	}
@@ -1274,7 +1274,7 @@  discard block
 block discarded – undo
1274 1274
 		$has_date = false;
1275 1275
 
1276 1276
 		foreach ( $search_fields as $k => $field ) {
1277
-			if ( in_array( $field['input'], array( 'date', 'date_range', 'entry_date' ) ) ) {
1277
+			if ( in_array( $field[ 'input' ], array( 'date', 'date_range', 'entry_date' ) ) ) {
1278 1278
 				$has_date = true;
1279 1279
 				break;
1280 1280
 			}
@@ -1304,7 +1304,7 @@  discard block
 block discarded – undo
1304 1304
 		$view = \GV\View::by_id( $gravityview_view->view_id );
1305 1305
 
1306 1306
 		// get configured search fields
1307
-		$search_fields = ! empty( $widget_args['search_fields'] ) ? json_decode( $widget_args['search_fields'], true ) : '';
1307
+		$search_fields = ! empty( $widget_args[ 'search_fields' ] ) ? json_decode( $widget_args[ 'search_fields' ], true ) : '';
1308 1308
 
1309 1309
 		if ( empty( $search_fields ) || ! is_array( $search_fields ) ) {
1310 1310
 			gravityview()->log->debug( 'No search fields configured for widget:', array( 'data' => $widget_args ) );
@@ -1318,40 +1318,40 @@  discard block
 block discarded – undo
1318 1318
 
1319 1319
 			$updated_field = $this->get_search_filter_details( $updated_field, $context );
1320 1320
 
1321
-			switch ( $field['field'] ) {
1321
+			switch ( $field[ 'field' ] ) {
1322 1322
 
1323 1323
 				case 'search_all':
1324
-					$updated_field['key'] = 'search_all';
1325
-					$updated_field['input'] = 'search_all';
1326
-					$updated_field['value'] = $this->rgget_or_rgpost( 'gv_search' );
1324
+					$updated_field[ 'key' ] = 'search_all';
1325
+					$updated_field[ 'input' ] = 'search_all';
1326
+					$updated_field[ 'value' ] = $this->rgget_or_rgpost( 'gv_search' );
1327 1327
 					break;
1328 1328
 
1329 1329
 				case 'entry_date':
1330
-					$updated_field['key'] = 'entry_date';
1331
-					$updated_field['input'] = 'entry_date';
1332
-					$updated_field['value'] = array(
1330
+					$updated_field[ 'key' ] = 'entry_date';
1331
+					$updated_field[ 'input' ] = 'entry_date';
1332
+					$updated_field[ 'value' ] = array(
1333 1333
 						'start' => $this->rgget_or_rgpost( 'gv_start' ),
1334 1334
 						'end' => $this->rgget_or_rgpost( 'gv_end' ),
1335 1335
 					);
1336 1336
 					break;
1337 1337
 
1338 1338
 				case 'entry_id':
1339
-					$updated_field['key'] = 'entry_id';
1340
-					$updated_field['input'] = 'entry_id';
1341
-					$updated_field['value'] = $this->rgget_or_rgpost( 'gv_id' );
1339
+					$updated_field[ 'key' ] = 'entry_id';
1340
+					$updated_field[ 'input' ] = 'entry_id';
1341
+					$updated_field[ 'value' ] = $this->rgget_or_rgpost( 'gv_id' );
1342 1342
 					break;
1343 1343
 
1344 1344
 				case 'created_by':
1345
-					$updated_field['key'] = 'created_by';
1346
-					$updated_field['name'] = 'gv_by';
1347
-					$updated_field['value'] = $this->rgget_or_rgpost( 'gv_by' );
1348
-					$updated_field['choices'] = self::get_created_by_choices( $view );
1345
+					$updated_field[ 'key' ] = 'created_by';
1346
+					$updated_field[ 'name' ] = 'gv_by';
1347
+					$updated_field[ 'value' ] = $this->rgget_or_rgpost( 'gv_by' );
1348
+					$updated_field[ 'choices' ] = self::get_created_by_choices( $view );
1349 1349
 					break;
1350 1350
 
1351 1351
 				case 'is_approved':
1352
-					$updated_field['key'] = 'is_approved';
1353
-					$updated_field['value'] = $this->rgget_or_rgpost( 'filter_is_approved' );
1354
-					$updated_field['choices'] = self::get_is_approved_choices();
1352
+					$updated_field[ 'key' ] = 'is_approved';
1353
+					$updated_field[ 'value' ] = $this->rgget_or_rgpost( 'filter_is_approved' );
1354
+					$updated_field[ 'choices' ] = self::get_is_approved_choices();
1355 1355
 					break;
1356 1356
 			}
1357 1357
 
@@ -1372,16 +1372,16 @@  discard block
 block discarded – undo
1372 1372
 
1373 1373
 		$gravityview_view->permalink_fields = $this->add_no_permalink_fields( array(), $this, $widget_args );
1374 1374
 
1375
-		$gravityview_view->search_layout = ! empty( $widget_args['search_layout'] ) ? $widget_args['search_layout'] : 'horizontal';
1375
+		$gravityview_view->search_layout = ! empty( $widget_args[ 'search_layout' ] ) ? $widget_args[ 'search_layout' ] : 'horizontal';
1376 1376
 
1377 1377
 		/** @since 1.14 */
1378
-		$gravityview_view->search_mode = ! empty( $widget_args['search_mode'] ) ? $widget_args['search_mode'] : 'any';
1378
+		$gravityview_view->search_mode = ! empty( $widget_args[ 'search_mode' ] ) ? $widget_args[ 'search_mode' ] : 'any';
1379 1379
 
1380
-		$custom_class = ! empty( $widget_args['custom_class'] ) ? $widget_args['custom_class'] : '';
1380
+		$custom_class = ! empty( $widget_args[ 'custom_class' ] ) ? $widget_args[ 'custom_class' ] : '';
1381 1381
 
1382 1382
 		$gravityview_view->search_class = self::get_search_class( $custom_class );
1383 1383
 
1384
-		$gravityview_view->search_clear = ! empty( $widget_args['search_clear'] ) ? $widget_args['search_clear'] : false;
1384
+		$gravityview_view->search_clear = ! empty( $widget_args[ 'search_clear' ] ) ? $widget_args[ 'search_clear' ] : false;
1385 1385
 
1386 1386
 		if ( $this->has_date_field( $search_fields ) ) {
1387 1387
 			// enqueue datepicker stuff only if needed!
@@ -1403,10 +1403,10 @@  discard block
 block discarded – undo
1403 1403
 	public static function get_search_class( $custom_class = '' ) {
1404 1404
 		$gravityview_view = GravityView_View::getInstance();
1405 1405
 
1406
-		$search_class = 'gv-search-'.$gravityview_view->search_layout;
1406
+		$search_class = 'gv-search-' . $gravityview_view->search_layout;
1407 1407
 
1408
-		if ( ! empty( $custom_class )  ) {
1409
-			$search_class .= ' '.$custom_class;
1408
+		if ( ! empty( $custom_class ) ) {
1409
+			$search_class .= ' ' . $custom_class;
1410 1410
 		}
1411 1411
 
1412 1412
 		/**
@@ -1457,9 +1457,9 @@  discard block
 block discarded – undo
1457 1457
 
1458 1458
 		if ( ! $label ) {
1459 1459
 
1460
-			$label = isset( $form_field['label'] ) ? $form_field['label'] : '';
1460
+			$label = isset( $form_field[ 'label' ] ) ? $form_field[ 'label' ] : '';
1461 1461
 
1462
-			switch( $field['field'] ) {
1462
+			switch ( $field[ 'field' ] ) {
1463 1463
 				case 'search_all':
1464 1464
 					$label = __( 'Search Entries:', 'gravityview' );
1465 1465
 					break;
@@ -1471,10 +1471,10 @@  discard block
 block discarded – undo
1471 1471
 					break;
1472 1472
 				default:
1473 1473
 					// If this is a field input, not a field
1474
-					if ( strpos( $field['field'], '.' ) > 0 && ! empty( $form_field['inputs'] ) ) {
1474
+					if ( strpos( $field[ 'field' ], '.' ) > 0 && ! empty( $form_field[ 'inputs' ] ) ) {
1475 1475
 
1476 1476
 						// Get the label for the field in question, which returns an array
1477
-						$items = wp_list_filter( $form_field['inputs'], array( 'id' => $field['field'] ) );
1477
+						$items = wp_list_filter( $form_field[ 'inputs' ], array( 'id' => $field[ 'field' ] ) );
1478 1478
 
1479 1479
 						// Get the item with the `label` key
1480 1480
 						$values = wp_list_pluck( $items, 'label' );
@@ -1515,13 +1515,13 @@  discard block
 block discarded – undo
1515 1515
 		$form = $gravityview_view->getForm();
1516 1516
 
1517 1517
 		// for advanced field ids (eg, first name / last name )
1518
-		$name = 'filter_' . str_replace( '.', '_', $field['field'] );
1518
+		$name = 'filter_' . str_replace( '.', '_', $field[ 'field' ] );
1519 1519
 
1520 1520
 		// get searched value from $_GET/$_POST (string or array)
1521 1521
 		$value = $this->rgget_or_rgpost( $name );
1522 1522
 
1523 1523
 		// get form field details
1524
-		$form_field = gravityview_get_field( $form, $field['field'] );
1524
+		$form_field = gravityview_get_field( $form, $field[ 'field' ] );
1525 1525
 
1526 1526
 		$form_field_type = \GV\Utils::get( $form_field, 'type' );
1527 1527
 
@@ -1535,17 +1535,17 @@  discard block
 block discarded – undo
1535 1535
 		);
1536 1536
 
1537 1537
 		// collect choices
1538
-		if ( 'post_category' === $form_field_type && ! empty( $form_field['displayAllCategories'] ) && empty( $form_field['choices'] ) ) {
1539
-			$filter['choices'] = gravityview_get_terms_choices();
1540
-		} elseif ( ! empty( $form_field['choices'] ) ) {
1541
-			$filter['choices'] = $form_field['choices'];
1538
+		if ( 'post_category' === $form_field_type && ! empty( $form_field[ 'displayAllCategories' ] ) && empty( $form_field[ 'choices' ] ) ) {
1539
+			$filter[ 'choices' ] = gravityview_get_terms_choices();
1540
+		} elseif ( ! empty( $form_field[ 'choices' ] ) ) {
1541
+			$filter[ 'choices' ] = $form_field[ 'choices' ];
1542 1542
 		}
1543 1543
 
1544
-		if ( 'date_range' === $field['input'] && empty( $value ) ) {
1545
-			$filter['value'] = array( 'start' => '', 'end' => '' );
1544
+		if ( 'date_range' === $field[ 'input' ] && empty( $value ) ) {
1545
+			$filter[ 'value' ] = array( 'start' => '', 'end' => '' );
1546 1546
 		}
1547 1547
 
1548
-		if ( ! empty( $filter['choices'] ) ) {
1548
+		if ( ! empty( $filter[ 'choices' ] ) ) {
1549 1549
 			/**
1550 1550
 			 * @filter `gravityview/search/sieve_choices` Only output used choices for this field.
1551 1551
 			 * @param[in,out] bool Yes or no.
@@ -1553,7 +1553,7 @@  discard block
 block discarded – undo
1553 1553
 			 * @param \GV\Context The context.
1554 1554
 			 */
1555 1555
 			if ( apply_filters( 'gravityview/search/sieve_choices', false, $field, $context ) ) {
1556
-				$filter['choices'] = $this->sieve_filter_choices( $filter, $context );
1556
+				$filter[ 'choices' ] = $this->sieve_filter_choices( $filter, $context );
1557 1557
 			}
1558 1558
 		}
1559 1559
 
@@ -1582,11 +1582,11 @@  discard block
 block discarded – undo
1582 1582
 	 * @return array The filter choices.
1583 1583
 	 */
1584 1584
 	private function sieve_filter_choices( $filter, $context ) {
1585
-		if ( empty( $filter['key'] ) || empty( $filter['choices'] ) ) {
1585
+		if ( empty( $filter[ 'key' ] ) || empty( $filter[ 'choices' ] ) ) {
1586 1586
 			return $filter; // @todo Populate plugins might give us empty choices
1587 1587
 		}
1588 1588
 
1589
-		if ( ! is_numeric( $filter['key'] ) ) {
1589
+		if ( ! is_numeric( $filter[ 'key' ] ) ) {
1590 1590
 			return $filter;
1591 1591
 		}
1592 1592
 
@@ -1596,29 +1596,29 @@  discard block
 block discarded – undo
1596 1596
 
1597 1597
 		$table = GFFormsModel::get_entry_meta_table_name();
1598 1598
 
1599
-		$key_like = $wpdb->esc_like( $filter['key'] ) . '.%';
1599
+		$key_like = $wpdb->esc_like( $filter[ 'key' ] ) . '.%';
1600 1600
 
1601 1601
 		switch ( \GV\Utils::get( $filter, 'type' ) ):
1602 1602
 			case 'post_category':
1603 1603
 				$choices = $wpdb->get_col( $wpdb->prepare(
1604 1604
 					"SELECT DISTINCT SUBSTRING_INDEX(meta_value, ':', 1) FROM $table WHERE (meta_key LIKE %s OR meta_key = %d) AND form_id = %d",
1605
-					$key_like, $filter['key'], $form_id
1605
+					$key_like, $filter[ 'key' ], $form_id
1606 1606
 				) );
1607 1607
 				break;
1608 1608
 			default:
1609 1609
 				$choices = $wpdb->get_col( $wpdb->prepare(
1610 1610
 					"SELECT DISTINCT meta_value FROM $table WHERE (meta_key LIKE %s OR meta_key = %d) AND form_id = %d",
1611
-					$key_like, $filter['key'], $form_id
1611
+					$key_like, $filter[ 'key' ], $form_id
1612 1612
 				) );
1613 1613
 
1614
-				if ( ( $field = gravityview_get_field( $form_id, $filter['key'] ) ) && 'json' === $field->storageType ) {
1614
+				if ( ( $field = gravityview_get_field( $form_id, $filter[ 'key' ] ) ) && 'json' === $field->storageType ) {
1615 1615
 					$choices = array_map( 'json_decode', $choices );
1616 1616
 					$_choices_array = array();
1617 1617
 					foreach ( $choices as $choice ) {
1618 1618
 						if ( is_array( $choice ) ) {
1619 1619
 							$_choices_array = array_merge( $_choices_array, $choice );
1620 1620
 						} else {
1621
-							$_choices_array []= $choice;
1621
+							$_choices_array [ ] = $choice;
1622 1622
 						}
1623 1623
 					}
1624 1624
 					$choices = array_unique( $_choices_array );
@@ -1628,9 +1628,9 @@  discard block
 block discarded – undo
1628 1628
 		endswitch;
1629 1629
 
1630 1630
 		$filter_choices = array();
1631
-		foreach ( $filter['choices'] as $choice ) {
1632
-			if ( in_array( $choice['text'], $choices, true ) || in_array( $choice['value'], $choices, true ) ) {
1633
-				$filter_choices[] = $choice;
1631
+		foreach ( $filter[ 'choices' ] as $choice ) {
1632
+			if ( in_array( $choice[ 'text' ], $choices, true ) || in_array( $choice[ 'value' ], $choices, true ) ) {
1633
+				$filter_choices[ ] = $choice;
1634 1634
 			}
1635 1635
 		}
1636 1636
 
@@ -1665,7 +1665,7 @@  discard block
 block discarded – undo
1665 1665
 			 * @param \GV\View $view The view.
1666 1666
 			 */
1667 1667
 			$text = apply_filters( 'gravityview/search/created_by/text', $user->display_name, $user, $view );
1668
-			$choices[] = array(
1668
+			$choices[ ] = array(
1669 1669
 				'value' => $user->ID,
1670 1670
 				'text' => $text,
1671 1671
 			);
@@ -1685,9 +1685,9 @@  discard block
 block discarded – undo
1685 1685
 
1686 1686
 		$choices = array();
1687 1687
 		foreach ( GravityView_Entry_Approval_Status::get_all() as $status ) {
1688
-			$choices[] = array(
1689
-				'value' => $status['value'],
1690
-				'text' => $status['label'],
1688
+			$choices[ ] = array(
1689
+				'value' => $status[ 'value' ],
1690
+				'text' => $status[ 'label' ],
1691 1691
 			);
1692 1692
 		}
1693 1693
 
@@ -1739,7 +1739,7 @@  discard block
 block discarded – undo
1739 1739
 	 */
1740 1740
 	public function add_datepicker_js_dependency( $js_dependencies ) {
1741 1741
 
1742
-		$js_dependencies[] = 'jquery-ui-datepicker';
1742
+		$js_dependencies[ ] = 'jquery-ui-datepicker';
1743 1743
 
1744 1744
 		return $js_dependencies;
1745 1745
 	}
@@ -1783,7 +1783,7 @@  discard block
 block discarded – undo
1783 1783
 			'isRTL'             => is_rtl(),
1784 1784
 		), $view_data );
1785 1785
 
1786
-		$localizations['datepicker'] = $datepicker_settings;
1786
+		$localizations[ 'datepicker' ] = $datepicker_settings;
1787 1787
 
1788 1788
 		return $localizations;
1789 1789
 
@@ -1810,7 +1810,7 @@  discard block
 block discarded – undo
1810 1810
 	 * @return void
1811 1811
 	 */
1812 1812
 	private function maybe_enqueue_flexibility() {
1813
-		if ( isset( $_SERVER['HTTP_USER_AGENT'] ) && preg_match( '/MSIE [8-9]/', $_SERVER['HTTP_USER_AGENT'] ) ) {
1813
+		if ( isset( $_SERVER[ 'HTTP_USER_AGENT' ] ) && preg_match( '/MSIE [8-9]/', $_SERVER[ 'HTTP_USER_AGENT' ] ) ) {
1814 1814
 			wp_enqueue_script( 'gv-flexibility' );
1815 1815
 		}
1816 1816
 	}
@@ -1832,7 +1832,7 @@  discard block
 block discarded – undo
1832 1832
 		add_filter( 'gravityview_js_localization', array( $this, 'add_datepicker_localization' ), 10, 2 );
1833 1833
 
1834 1834
 		$scheme = is_ssl() ? 'https://' : 'http://';
1835
-		wp_enqueue_style( 'jquery-ui-datepicker', $scheme.'ajax.googleapis.com/ajax/libs/jqueryui/1.8.18/themes/smoothness/jquery-ui.css' );
1835
+		wp_enqueue_style( 'jquery-ui-datepicker', $scheme . 'ajax.googleapis.com/ajax/libs/jqueryui/1.8.18/themes/smoothness/jquery-ui.css' );
1836 1836
 
1837 1837
 		/**
1838 1838
 		 * @filter `gravityview_search_datepicker_class`
@@ -1911,7 +1911,7 @@  discard block
 block discarded – undo
1911 1911
 	public function add_preview_inputs() {
1912 1912
 		global $wp;
1913 1913
 
1914
-		if ( ! is_preview() || ! current_user_can( 'publish_gravityviews') ) {
1914
+		if ( ! is_preview() || ! current_user_can( 'publish_gravityviews' ) ) {
1915 1915
 			return;
1916 1916
 		}
1917 1917
 
@@ -1963,7 +1963,7 @@  discard block
 block discarded – undo
1963 1963
  */
1964 1964
 class GravityView_Widget_Search_Author_GF_Query_Condition extends \GF_Query_Condition {
1965 1965
 	public function __construct( $filter, $view ) {
1966
-		$this->value = $filter['value'];
1966
+		$this->value = $filter[ 'value' ];
1967 1967
 		$this->view = $view;
1968 1968
 	}
1969 1969
 
@@ -1995,11 +1995,11 @@  discard block
 block discarded – undo
1995 1995
 		$conditions = array();
1996 1996
 
1997 1997
 		foreach ( $user_fields as $user_field ) {
1998
-			$conditions[] = $wpdb->prepare( "`u`.`$user_field` LIKE %s", '%' . $wpdb->esc_like( $this->value ) .  '%' );
1998
+			$conditions[ ] = $wpdb->prepare( "`u`.`$user_field` LIKE %s", '%' . $wpdb->esc_like( $this->value ) . '%' );
1999 1999
 		}
2000 2000
 
2001 2001
 		foreach ( $user_meta_fields as $meta_field ) {
2002
-			$conditions[] = $wpdb->prepare( "(`um`.`meta_key` = %s AND `um`.`meta_value` LIKE %s)", $meta_field, '%' . $wpdb->esc_like( $this->value ) .  '%' );
2002
+			$conditions[ ] = $wpdb->prepare( "(`um`.`meta_key` = %s AND `um`.`meta_value` LIKE %s)", $meta_field, '%' . $wpdb->esc_like( $this->value ) . '%' );
2003 2003
 		}
2004 2004
 
2005 2005
 		$conditions = '(' . implode( ' OR ', $conditions ) . ')';
Please login to merge, or discard this patch.
includes/extensions/duplicate-entry/class-duplicate-entry.php 2 patches
Doc Comments   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 	 *
91 91
 	 * @param array $fields Array of field types not editable by users
92 92
 	 *
93
-	 * @return array
93
+	 * @return string[]
94 94
 	 */
95 95
 	public function _filter_sortable_fields( $fields ) {
96 96
 
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 	 *
109 109
 	 * @param array $file_paths List of template paths ordered
110 110
 	 *
111
-	 * @return array File paths, with duplicate field path added at index 117
111
+	 * @return string[] File paths, with duplicate field path added at index 117
112 112
 	 */
113 113
 	public function add_template_path( $file_paths ) {
114 114
 
@@ -213,7 +213,6 @@  discard block
 block discarded – undo
213 213
 	 * @since 2.5
214 214
 	 *
215 215
 	 * @param  array 	    $visibility_caps        Array of capabilities to display in field dropdown.
216
-	 * @param  string       $field_type  Type of field options to render (`field` or `widget`)
217 216
 	 * @param  string       $template_id Table slug
218 217
 	 * @param  float|string $field_id    GF Field ID - Example: `3`, `5.2`, `entry_link`, `created_by`
219 218
 	 * @param  string       $context     What context are we in? Example: `single` or `directory`
Please login to merge, or discard this patch.
Spacing   +54 added lines, -54 removed lines patch added patch discarded remove patch
@@ -94,9 +94,9 @@  discard block
 block discarded – undo
94 94
 	 */
95 95
 	public function _filter_sortable_fields( $fields ) {
96 96
 
97
-		$fields = (array) $fields;
97
+		$fields = (array)$fields;
98 98
 
99
-		$fields[] = 'duplicate_link';
99
+		$fields[ ] = 'duplicate_link';
100 100
 
101 101
 		return $fields;
102 102
 	}
@@ -135,12 +135,12 @@  discard block
 block discarded – undo
135 135
 	public function duplicate_link_field_options( $field_options, $template_id, $field_id, $context, $input_type ) {
136 136
 
137 137
 		// Always a link, never a filter, always same window
138
-		unset( $field_options['show_as_link'], $field_options['search_filter'], $field_options['new_window'] );
138
+		unset( $field_options[ 'show_as_link' ], $field_options[ 'search_filter' ], $field_options[ 'new_window' ] );
139 139
 
140 140
 		// Duplicate Entry link should only appear to visitors capable of editing entries
141
-		unset( $field_options['only_loggedin'], $field_options['only_loggedin_cap'] );
141
+		unset( $field_options[ 'only_loggedin' ], $field_options[ 'only_loggedin_cap' ] );
142 142
 
143
-		$add_option['duplicate_link'] = array(
143
+		$add_option[ 'duplicate_link' ] = array(
144 144
 			'type' => 'text',
145 145
 			'label' => __( 'Duplicate Link Text', 'gravityview' ),
146 146
 			'desc' => NULL,
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
 			'merge_tags' => true,
149 149
 		);
150 150
 
151
-		$field_options['allow_duplicate_cap'] = array(
151
+		$field_options[ 'allow_duplicate_cap' ] = array(
152 152
 			'type' => 'select',
153 153
 			'label' => __( 'Allow the following users to duplicate the entry:', 'gravityview' ),
154 154
 			'choices' => GravityView_Render_Settings::get_cap_choices( $template_id, $field_id, $context, $input_type ),
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
 	public function add_default_field( $entry_default_fields, $form = array(), $zone = '' ) {
176 176
 
177 177
 		if ( 'edit' !== $zone ) {
178
-			$entry_default_fields['duplicate_link'] = array(
178
+			$entry_default_fields[ 'duplicate_link' ] = array(
179 179
 				'label' => __( 'Duplicate Entry', 'gravityview' ),
180 180
 				'type'  => 'duplicate_link',
181 181
 				'desc'  => __( 'A link to duplicate the entry. Respects the Duplicate Entry permissions.', 'gravityview' ),
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
 	 */
197 197
 	public function add_available_field( $available_fields = array() ) {
198 198
 
199
-		$available_fields['duplicate_link'] = array(
199
+		$available_fields[ 'duplicate_link' ] = array(
200 200
 			'label_text' => __( 'Duplicate Entry', 'gravityview' ),
201 201
 			'field_id' => 'duplicate_link',
202 202
 			'label_type' => 'field',
@@ -229,9 +229,9 @@  discard block
 block discarded – undo
229 229
 		if ( 'duplicate_link' === $field_id ) {
230 230
 
231 231
 			// Remove other built-in caps.
232
-			unset( $caps['publish_posts'], $caps['gravityforms_view_entries'], $caps['duplicate_others_posts'] );
232
+			unset( $caps[ 'publish_posts' ], $caps[ 'gravityforms_view_entries' ], $caps[ 'duplicate_others_posts' ] );
233 233
 
234
-			$caps['read'] = _x( 'Entry Creator', 'User capability', 'gravityview' );
234
+			$caps[ 'read' ] = _x( 'Entry Creator', 'User capability', 'gravityview' );
235 235
 		}
236 236
 
237 237
 		return $caps;
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
266 266
 	 */
267 267
 	public static function get_duplicate_link( $entry, $view_id, $post_id = null ) {
268 268
 
269
-        $base = GravityView_API::directory_link( $post_id ? : $view_id, true );
269
+        $base = GravityView_API::directory_link( $post_id ?: $view_id, true );
270 270
 
271 271
 		if ( empty( $base ) ) {
272 272
 			gravityview()->log->error( 'Post ID does not exist: {post_id}', array( 'post_id' => $post_id ) );
@@ -275,12 +275,12 @@  discard block
 block discarded – undo
275 275
 
276 276
 		$actionurl = add_query_arg( array(
277 277
 			'action'	=> 'duplicate',
278
-			'entry_id'	=> $entry['id'],
278
+			'entry_id'	=> $entry[ 'id' ],
279 279
 			'gvid' => $view_id,
280 280
             'view_id' => $view_id,
281 281
 		), $base );
282 282
 
283
-		return add_query_arg( 'duplicate', wp_create_nonce( self::get_nonce_key( $entry['id'] ) ), $actionurl );
283
+		return add_query_arg( 'duplicate', wp_create_nonce( self::get_nonce_key( $entry[ 'id' ] ) ), $actionurl );
284 284
 	}
285 285
 
286 286
 	/**
@@ -301,12 +301,12 @@  discard block
 block discarded – undo
301 301
 	public function process_duplicate() {
302 302
 
303 303
 		// If the form is submitted
304
-		if ( ( ! isset( $_GET['action'] ) ) || 'duplicate' !== $_GET['action'] || ( ! isset( $_GET['entry_id'] ) ) ) {
304
+		if ( ( ! isset( $_GET[ 'action' ] ) ) || 'duplicate' !== $_GET[ 'action' ] || ( ! isset( $_GET[ 'entry_id' ] ) ) ) {
305 305
 			return;
306 306
 		}
307 307
 
308 308
 		// Make sure it's a GravityView request
309
-		$valid_nonce_key = wp_verify_nonce( \GV\Utils::_GET( 'duplicate' ), self::get_nonce_key( $_GET['entry_id'] ) );
309
+		$valid_nonce_key = wp_verify_nonce( \GV\Utils::_GET( 'duplicate' ), self::get_nonce_key( $_GET[ 'entry_id' ] ) );
310 310
 
311 311
 		if ( ! $valid_nonce_key ) {
312 312
 			gravityview()->log->debug( 'Duplicate entry not processed: nonce validation failed.' );
@@ -314,7 +314,7 @@  discard block
 block discarded – undo
314 314
 		}
315 315
 
316 316
 		// Get the entry slug
317
-		$entry_slug = esc_attr( $_GET['entry_id'] );
317
+		$entry_slug = esc_attr( $_GET[ 'entry_id' ] );
318 318
 
319 319
 		// See if there's an entry there
320 320
 		$entry = gravityview_get_entry( $entry_slug, true, false );
@@ -408,17 +408,17 @@  discard block
 block discarded – undo
408 408
 			return new WP_Error( 'gravityview-duplicate-entry-missing', __( 'The entry does not exist.', 'gravityview' ) );
409 409
 		}
410 410
 
411
-		$form = GFAPI::get_form( $entry['form_id'] );
411
+		$form = GFAPI::get_form( $entry[ 'form_id' ] );
412 412
 
413
-		$row['id'] = null;
414
-		$row['date_created'] = date( 'Y-m-d H:i:s', time() );
415
-		$row['date_updated'] = $row['date_created'];
416
-		$row['is_starred'] = false;
417
-		$row['is_read'] = false;
418
-		$row['ip'] = rgars( $form, 'personalData/preventIP' ) ? '' : GFFormsModel::get_ip();
419
-		$row['source_url'] = esc_url_raw( remove_query_arg( array( 'action', 'gvid', 'result', 'duplicate', 'entry_id' ) ) );
420
-		$row['user_agent'] = \GV\Utils::_SERVER( 'HTTP_USER_AGENT' );
421
-		$row['created_by'] = wp_get_current_user()->ID;
413
+		$row[ 'id' ] = null;
414
+		$row[ 'date_created' ] = date( 'Y-m-d H:i:s', time() );
415
+		$row[ 'date_updated' ] = $row[ 'date_created' ];
416
+		$row[ 'is_starred' ] = false;
417
+		$row[ 'is_read' ] = false;
418
+		$row[ 'ip' ] = rgars( $form, 'personalData/preventIP' ) ? '' : GFFormsModel::get_ip();
419
+		$row[ 'source_url' ] = esc_url_raw( remove_query_arg( array( 'action', 'gvid', 'result', 'duplicate', 'entry_id' ) ) );
420
+		$row[ 'user_agent' ] = \GV\Utils::_SERVER( 'HTTP_USER_AGENT' );
421
+		$row[ 'created_by' ] = wp_get_current_user()->ID;
422 422
 
423 423
 		/**
424 424
 		 * @filter `gravityview/entry/duplicate/details` Modify the new entry details before it's created.
@@ -446,15 +446,15 @@  discard block
 block discarded – undo
446 446
 
447 447
 		$save_this_meta = array();
448 448
 		foreach ( $duplicate_meta->get_output() as $m ) {
449
-			$save_this_meta[] = array(
450
-				'meta_key' => $m['meta_key'],
451
-				'meta_value' => $m['meta_value'],
452
-				'item_index' => $m['item_index'],
449
+			$save_this_meta[ ] = array(
450
+				'meta_key' => $m[ 'meta_key' ],
451
+				'meta_value' => $m[ 'meta_value' ],
452
+				'item_index' => $m[ 'item_index' ],
453 453
 			);
454 454
 		}
455 455
 
456 456
 		// Update the row ID for later usage
457
-		$row['id'] = $duplicated_id;
457
+		$row[ 'id' ] = $duplicated_id;
458 458
 
459 459
 		/**
460 460
 		 * @filter `gravityview/entry/duplicate/meta` Modify the new entry meta details.
@@ -465,8 +465,8 @@  discard block
 block discarded – undo
465 465
 		$save_this_meta = apply_filters( 'gravityview/entry/duplicate/meta', $save_this_meta, $row, $entry );
466 466
 
467 467
 		foreach ( $save_this_meta as $data ) {
468
-			$data['form_id'] = $entry['form_id'];
469
-			$data['entry_id'] = $duplicated_id;
468
+			$data[ 'form_id' ] = $entry[ 'form_id' ];
469
+			$data[ 'entry_id' ] = $duplicated_id;
470 470
 
471 471
 			if ( ! $wpdb->insert( $entry_meta_table, $data ) ) {
472 472
 				return new WP_Error( 'gravityview-duplicate-entry-db-meta', __( 'There was an error duplicating the entry.', 'gravityview' ) );
@@ -500,13 +500,13 @@  discard block
 block discarded – undo
500 500
 	public function verify_nonce() {
501 501
 
502 502
 		// No duplicate entry request was made
503
-		if ( empty( $_GET['entry_id'] ) || empty( $_GET['duplicate'] ) ) {
503
+		if ( empty( $_GET[ 'entry_id' ] ) || empty( $_GET[ 'duplicate' ] ) ) {
504 504
 			return false;
505 505
 		}
506 506
 
507
-		$nonce_key = self::get_nonce_key( $_GET['entry_id'] );
507
+		$nonce_key = self::get_nonce_key( $_GET[ 'entry_id' ] );
508 508
 
509
-		$valid = wp_verify_nonce( $_GET['duplicate'], $nonce_key );
509
+		$valid = wp_verify_nonce( $_GET[ 'duplicate' ], $nonce_key );
510 510
 
511 511
 		/**
512 512
 		 * @filter `gravityview/duplicate-entry/verify_nonce` Override Duplicate Entry nonce validation. Return true to declare nonce valid.
@@ -542,7 +542,7 @@  discard block
 block discarded – undo
542 542
 			return '';
543 543
 		}
544 544
 
545
-		return 'return window.confirm(\''. esc_js( $confirm ) .'\');';
545
+		return 'return window.confirm(\'' . esc_js( $confirm ) . '\');';
546 546
 	}
547 547
 
548 548
 	/**
@@ -596,7 +596,7 @@  discard block
 block discarded – undo
596 596
 	public static function check_user_cap_duplicate_entry( $entry, $field = array(), $view_id = 0 ) {
597 597
 		$current_user = wp_get_current_user();
598 598
 
599
-		$entry_id = isset( $entry['id'] ) ? $entry['id'] : null;
599
+		$entry_id = isset( $entry[ 'id' ] ) ? $entry[ 'id' ] : null;
600 600
 
601 601
 		// Or if they can duplicate any entries (as defined in Gravity Forms), we're good.
602 602
 		if ( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gform_full_access', 'gravityview_full_access' ), $entry_id ) ) {
@@ -611,17 +611,17 @@  discard block
 block discarded – undo
611 611
 		if ( ! empty( $field ) ) {
612 612
 
613 613
 			// If capability is not defined, something is not right!
614
-			if ( empty( $field['allow_duplicate_cap'] ) ) {
614
+			if ( empty( $field[ 'allow_duplicate_cap' ] ) ) {
615 615
 
616 616
 				gravityview()->log->error( 'Cannot read duplicate entry field caps', array( 'data' => $field ) );
617 617
 
618 618
 				return false;
619 619
 			}
620 620
 
621
-			if ( GVCommon::has_cap( $field['allow_duplicate_cap'] ) ) {
621
+			if ( GVCommon::has_cap( $field[ 'allow_duplicate_cap' ] ) ) {
622 622
 
623 623
 				// Do not return true if cap is read, as we need to check if the current user created the entry
624
-				if ( 'read' !== $field['allow_duplicate_cap'] ) {
624
+				if ( 'read' !== $field[ 'allow_duplicate_cap' ] ) {
625 625
 					return true;
626 626
 				}
627 627
 
@@ -634,7 +634,7 @@  discard block
 block discarded – undo
634 634
 
635 635
 		}
636 636
 
637
-		if ( ! isset( $entry['created_by'] ) ) {
637
+		if ( ! isset( $entry[ 'created_by' ] ) ) {
638 638
 
639 639
 			gravityview()->log->error( 'Cannot duplicate entry; entry `created_by` doesn\'t exist.' );
640 640
 
@@ -659,7 +659,7 @@  discard block
 block discarded – undo
659 659
 		}
660 660
 
661 661
 		// If the logged-in user is the same as the user who created the entry, we're good.
662
-		if ( is_user_logged_in() && intval( $current_user->ID ) === intval( $entry['created_by'] ) ) {
662
+		if ( is_user_logged_in() && intval( $current_user->ID ) === intval( $entry[ 'created_by' ] ) ) {
663 663
 
664 664
 			gravityview()->log->debug( 'User {user_id} created the entry.', array( 'user_id' => $current_user->ID ) );
665 665
 
@@ -683,12 +683,12 @@  discard block
 block discarded – undo
683 683
 	 * @return void
684 684
 	 */
685 685
 	public function maybe_display_message( $current_view_id = 0 ) {
686
-		if ( empty( $_GET['status'] ) || ! self::verify_nonce() ) {
686
+		if ( empty( $_GET[ 'status' ] ) || ! self::verify_nonce() ) {
687 687
 			return;
688 688
 		}
689 689
 
690 690
 		// Entry wasn't duplicated from current View
691
-		if ( isset( $_GET['view_id'] ) && ( intval( $_GET['view_id'] ) !== intval( $current_view_id ) ) ) {
691
+		if ( isset( $_GET[ 'view_id' ] ) && ( intval( $_GET[ 'view_id' ] ) !== intval( $current_view_id ) ) ) {
692 692
 			return;
693 693
 		}
694 694
 
@@ -696,11 +696,11 @@  discard block
 block discarded – undo
696 696
 	}
697 697
 
698 698
 	public function display_message() {
699
-		if ( empty( $_GET['status'] ) || empty( $_GET['duplicate'] ) ) {
699
+		if ( empty( $_GET[ 'status' ] ) || empty( $_GET[ 'duplicate' ] ) ) {
700 700
 			return;
701 701
 		}
702 702
 
703
-		$status = esc_attr( $_GET['status'] );
703
+		$status = esc_attr( $_GET[ 'status' ] );
704 704
 		$message_from_url = \GV\Utils::_GET( 'message' );
705 705
 		$message_from_url = rawurldecode( stripslashes_deep( $message_from_url ) );
706 706
 		$class = '';
@@ -726,7 +726,7 @@  discard block
 block discarded – undo
726 726
 		$message = apply_filters( 'gravityview/duplicate-entry/message', esc_attr( $message ), $status, $message_from_url );
727 727
 
728 728
 		// DISPLAY ERROR/SUCCESS MESSAGE
729
-		echo '<div class="gv-notice' . esc_attr( $class ) .'">'. $message .'</div>';
729
+		echo '<div class="gv-notice' . esc_attr( $class ) . '">' . $message . '</div>';
730 730
 	}
731 731
 
732 732
 	/**
@@ -756,7 +756,7 @@  discard block
 block discarded – undo
756 756
 		?>
757 757
 		<span class="gv-duplicate">
758 758
 			|
759
-			<a href="<?php echo wp_nonce_url( add_query_arg( 'entry_id', $entry['id'] ), self::get_nonce_key( $entry['id'] ), 'duplicate' ); ?>"><?php esc_html_e( 'Duplicate', 'gravityview' ); ?></a>
759
+			<a href="<?php echo wp_nonce_url( add_query_arg( 'entry_id', $entry[ 'id' ] ), self::get_nonce_key( $entry[ 'id' ] ), 'duplicate' ); ?>"><?php esc_html_e( 'Duplicate', 'gravityview' ); ?></a>
760 760
 		</span>
761 761
 		<?php
762 762
 	}
@@ -778,9 +778,9 @@  discard block
 block discarded – undo
778 778
 
779 779
 		if ( 'success' === \GV\Utils::_GET( 'result' ) ) {
780 780
 			add_filter( 'gform_admin_messages', function( $messages ) {
781
-				$messages = (array) $messages;
781
+				$messages = (array)$messages;
782 782
 
783
-				$messages[] = esc_html__( 'Entry duplicated.', 'gravityview' );
783
+				$messages[ ] = esc_html__( 'Entry duplicated.', 'gravityview' );
784 784
 				return $messages;
785 785
 			} );
786 786
 		}
@@ -791,7 +791,7 @@  discard block
 block discarded – undo
791 791
 
792 792
 			$check_logs_message = '';
793 793
 
794
-			if( $is_logging_active ) {
794
+			if ( $is_logging_active ) {
795 795
 				$check_logs_message = sprintf( ' <a href="%s">%s</a>',
796 796
 					esc_url( admin_url( 'admin.php?page=gf_settings&subview=gravityformslogging' ) ),
797 797
 					esc_html_x( 'Check the GravityView logs for more information.', 'Error message links to logging page', 'gravityview' )
@@ -799,9 +799,9 @@  discard block
 block discarded – undo
799 799
 			}
800 800
 
801 801
 			add_filter( 'gform_admin_error_messages', function( $messages ) use ( $check_logs_message ) {
802
-				$messages = (array) $messages;
802
+				$messages = (array)$messages;
803 803
 
804
-				$messages[] = esc_html__( 'There was an error duplicating the entry.', 'gravityview' ) . $check_logs_message;
804
+				$messages[ ] = esc_html__( 'There was an error duplicating the entry.', 'gravityview' ) . $check_logs_message;
805 805
 
806 806
 				return $messages;
807 807
 			} );
Please login to merge, or discard this patch.
includes/extensions/edit-entry/class-edit-entry-admin.php 1 patch
Indentation   +155 added lines, -155 removed lines patch added patch discarded remove patch
@@ -10,42 +10,42 @@  discard block
 block discarded – undo
10 10
  */
11 11
 
12 12
 if ( ! defined( 'WPINC' ) ) {
13
-    die;
13
+	die;
14 14
 }
15 15
 
16 16
 
17 17
 class GravityView_Edit_Entry_Admin {
18 18
 
19
-    protected $loader;
19
+	protected $loader;
20 20
 
21
-    function __construct( GravityView_Edit_Entry $loader ) {
22
-        $this->loader = $loader;
23
-    }
21
+	function __construct( GravityView_Edit_Entry $loader ) {
22
+		$this->loader = $loader;
23
+	}
24 24
 
25
-    function load() {
25
+	function load() {
26 26
 
27
-        if( !is_admin() ) {
28
-            return;
29
-        }
27
+		if( !is_admin() ) {
28
+			return;
29
+		}
30 30
 
31
-        // Add Edit Link as a default field, outside those set in the Gravity Form form
32
-        add_filter( 'gravityview_entry_default_fields', array( $this, 'add_default_field' ), 10, 3 );
31
+		// Add Edit Link as a default field, outside those set in the Gravity Form form
32
+		add_filter( 'gravityview_entry_default_fields', array( $this, 'add_default_field' ), 10, 3 );
33 33
 
34
-        // For the Edit Entry Link, you don't want visible to all users.
35
-        add_filter( 'gravityview_field_visibility_caps', array( $this, 'modify_visibility_caps' ), 10, 5 );
34
+		// For the Edit Entry Link, you don't want visible to all users.
35
+		add_filter( 'gravityview_field_visibility_caps', array( $this, 'modify_visibility_caps' ), 10, 5 );
36 36
 
37
-        // Modify the field options based on the name of the field type
38
-        add_filter( 'gravityview_template_edit_link_options', array( $this, 'edit_link_field_options' ), 10, 5 );
37
+		// Modify the field options based on the name of the field type
38
+		add_filter( 'gravityview_template_edit_link_options', array( $this, 'edit_link_field_options' ), 10, 5 );
39 39
 
40
-        // add tooltips
41
-        add_filter( 'gravityview/metaboxes/tooltips', array( $this, 'tooltips') );
40
+		// add tooltips
41
+		add_filter( 'gravityview/metaboxes/tooltips', array( $this, 'tooltips') );
42 42
 
43
-        // custom fields' options for zone EDIT
44
-        add_filter( 'gravityview_template_field_options', array( $this, 'field_options' ), 10, 6 );
43
+		// custom fields' options for zone EDIT
44
+		add_filter( 'gravityview_template_field_options', array( $this, 'field_options' ), 10, 6 );
45 45
 
46
-        // Add Edit Entry settings to View Settings
47
-        add_action( 'gravityview/metaboxes/edit_entry', array( $this, 'view_settings_metabox' ) );
48
-    }
46
+		// Add Edit Entry settings to View Settings
47
+		add_action( 'gravityview/metaboxes/edit_entry', array( $this, 'view_settings_metabox' ) );
48
+	}
49 49
 
50 50
 	/**
51 51
 	 * Render Edit Entry View metabox settings
@@ -69,141 +69,141 @@  discard block
 block discarded – undo
69 69
 		GravityView_Render_Settings::render_setting_row( 'edit_redirect_url', $current_settings );
70 70
 	}
71 71
 
72
-    /**
73
-     * Add Edit Link as a default field, outside those set in the Gravity Form form
74
-     * @param array $entry_default_fields Existing fields
75
-     * @param  string|array $form form_ID or form object
76
-     * @param  string $zone   Either 'single', 'directory', 'header', 'footer'
77
-     */
78
-    function add_default_field( $entry_default_fields, $form = array(), $zone = '' ) {
79
-
80
-        if( $zone !== 'edit' ) {
81
-
82
-            $entry_default_fields['edit_link'] = array(
83
-                'label' => __('Edit Entry', 'gravityview'),
84
-                'type' => 'edit_link',
85
-                'desc'	=> __('A link to edit the entry. Visible based on View settings.', 'gravityview'),
86
-            );
87
-
88
-        }
89
-
90
-        return $entry_default_fields;
91
-    }
92
-
93
-    /**
94
-     * Change wording for the Edit context to read Entry Creator
95
-     *
96
-     * @param  array 	   $visibility_caps        Array of capabilities to display in field dropdown.
97
-     * @param  string      $field_type  Type of field options to render (`field` or `widget`)
98
-     * @param  string      $template_id Table slug
99
-     * @param  float       $field_id    GF Field ID - Example: `3`, `5.2`, `entry_link`, `created_by`
100
-     * @param  string      $context     What context are we in? Example: `single` or `directory`
101
-     * @param  string      $input_type  (textarea, list, select, etc.)
102
-     * @return array                   Array of field options with `label`, `value`, `type`, `default` keys
103
-     */
104
-    function modify_visibility_caps( $visibility_caps = array(), $template_id = '', $field_id = '', $context = '', $input_type = '' ) {
105
-
106
-        $caps = $visibility_caps;
107
-
108
-        // If we're configuring fields in the edit context, we want a limited selection
109
-        if( $context === 'edit' ) {
110
-
111
-            // Remove other built-in caps.
112
-            unset( $caps['publish_posts'], $caps['gravityforms_view_entries'], $caps['delete_others_posts'] );
113
-
114
-            $caps['read'] = _x('Entry Creator','User capability', 'gravityview');
115
-        }
116
-
117
-        return $caps;
118
-    }
119
-
120
-    /**
121
-     * Add "Edit Link Text" setting to the edit_link field settings
122
-     * @param  [type] $field_options [description]
123
-     * @param  [type] $template_id   [description]
124
-     * @param  [type] $field_id      [description]
125
-     * @param  [type] $context       [description]
126
-     * @param  [type] $input_type    [description]
127
-     * @return [type]                [description]
128
-     */
129
-    function edit_link_field_options( $field_options, $template_id, $field_id, $context, $input_type ) {
130
-
131
-        // Always a link, never a filter
132
-        unset( $field_options['show_as_link'], $field_options['search_filter'] );
133
-
134
-        // Edit Entry link should only appear to visitors capable of editing entries
135
-        unset( $field_options['only_loggedin'], $field_options['only_loggedin_cap'] );
136
-
137
-        $add_option['edit_link'] = array(
138
-            'type' => 'text',
139
-            'label' => __( 'Edit Link Text', 'gravityview' ),
140
-            'desc' => NULL,
141
-            'value' => __('Edit Entry', 'gravityview'),
142
-            'merge_tags' => true,
143
-        );
144
-
145
-        return array_merge( $add_option, $field_options );
146
-    }
147
-
148
-    /**
149
-     * Add tooltips
150
-     * @param  array $tooltips Existing tooltips
151
-     * @return array           Modified tooltips
152
-     */
153
-    function tooltips( $tooltips ) {
154
-
155
-        $return = $tooltips;
156
-
157
-        $return['allow_edit_cap'] = array(
158
-            'title' => __('Limiting Edit Access', 'gravityview'),
159
-            'value' => __('Change this setting if you don\'t want the user who created the entry to be able to edit this field.', 'gravityview'),
160
-        );
161
-
162
-        return $return;
163
-    }
164
-
165
-    /**
166
-     * Manipulate the fields' options for the EDIT ENTRY screen
167
-     * @param  [type] $field_options [description]
168
-     * @param  [type] $template_id   [description]
169
-     * @param  [type] $field_id      [description]
170
-     * @param  [type] $context       [description]
171
-     * @param  [type] $input_type    [description]
172
-     * @return [type]                [description]
173
-     */
72
+	/**
73
+	 * Add Edit Link as a default field, outside those set in the Gravity Form form
74
+	 * @param array $entry_default_fields Existing fields
75
+	 * @param  string|array $form form_ID or form object
76
+	 * @param  string $zone   Either 'single', 'directory', 'header', 'footer'
77
+	 */
78
+	function add_default_field( $entry_default_fields, $form = array(), $zone = '' ) {
79
+
80
+		if( $zone !== 'edit' ) {
81
+
82
+			$entry_default_fields['edit_link'] = array(
83
+				'label' => __('Edit Entry', 'gravityview'),
84
+				'type' => 'edit_link',
85
+				'desc'	=> __('A link to edit the entry. Visible based on View settings.', 'gravityview'),
86
+			);
87
+
88
+		}
89
+
90
+		return $entry_default_fields;
91
+	}
92
+
93
+	/**
94
+	 * Change wording for the Edit context to read Entry Creator
95
+	 *
96
+	 * @param  array 	   $visibility_caps        Array of capabilities to display in field dropdown.
97
+	 * @param  string      $field_type  Type of field options to render (`field` or `widget`)
98
+	 * @param  string      $template_id Table slug
99
+	 * @param  float       $field_id    GF Field ID - Example: `3`, `5.2`, `entry_link`, `created_by`
100
+	 * @param  string      $context     What context are we in? Example: `single` or `directory`
101
+	 * @param  string      $input_type  (textarea, list, select, etc.)
102
+	 * @return array                   Array of field options with `label`, `value`, `type`, `default` keys
103
+	 */
104
+	function modify_visibility_caps( $visibility_caps = array(), $template_id = '', $field_id = '', $context = '', $input_type = '' ) {
105
+
106
+		$caps = $visibility_caps;
107
+
108
+		// If we're configuring fields in the edit context, we want a limited selection
109
+		if( $context === 'edit' ) {
110
+
111
+			// Remove other built-in caps.
112
+			unset( $caps['publish_posts'], $caps['gravityforms_view_entries'], $caps['delete_others_posts'] );
113
+
114
+			$caps['read'] = _x('Entry Creator','User capability', 'gravityview');
115
+		}
116
+
117
+		return $caps;
118
+	}
119
+
120
+	/**
121
+	 * Add "Edit Link Text" setting to the edit_link field settings
122
+	 * @param  [type] $field_options [description]
123
+	 * @param  [type] $template_id   [description]
124
+	 * @param  [type] $field_id      [description]
125
+	 * @param  [type] $context       [description]
126
+	 * @param  [type] $input_type    [description]
127
+	 * @return [type]                [description]
128
+	 */
129
+	function edit_link_field_options( $field_options, $template_id, $field_id, $context, $input_type ) {
130
+
131
+		// Always a link, never a filter
132
+		unset( $field_options['show_as_link'], $field_options['search_filter'] );
133
+
134
+		// Edit Entry link should only appear to visitors capable of editing entries
135
+		unset( $field_options['only_loggedin'], $field_options['only_loggedin_cap'] );
136
+
137
+		$add_option['edit_link'] = array(
138
+			'type' => 'text',
139
+			'label' => __( 'Edit Link Text', 'gravityview' ),
140
+			'desc' => NULL,
141
+			'value' => __('Edit Entry', 'gravityview'),
142
+			'merge_tags' => true,
143
+		);
144
+
145
+		return array_merge( $add_option, $field_options );
146
+	}
147
+
148
+	/**
149
+	 * Add tooltips
150
+	 * @param  array $tooltips Existing tooltips
151
+	 * @return array           Modified tooltips
152
+	 */
153
+	function tooltips( $tooltips ) {
154
+
155
+		$return = $tooltips;
156
+
157
+		$return['allow_edit_cap'] = array(
158
+			'title' => __('Limiting Edit Access', 'gravityview'),
159
+			'value' => __('Change this setting if you don\'t want the user who created the entry to be able to edit this field.', 'gravityview'),
160
+		);
161
+
162
+		return $return;
163
+	}
164
+
165
+	/**
166
+	 * Manipulate the fields' options for the EDIT ENTRY screen
167
+	 * @param  [type] $field_options [description]
168
+	 * @param  [type] $template_id   [description]
169
+	 * @param  [type] $field_id      [description]
170
+	 * @param  [type] $context       [description]
171
+	 * @param  [type] $input_type    [description]
172
+	 * @return [type]                [description]
173
+	 */
174 174
 	public function field_options( $field_options, $template_id, $field_id, $context, $input_type, $form_id ) {
175 175
 
176
-        // We only want to modify the settings for the edit context
177
-        if( 'edit' !== $context ) {
178
-
179
-            /**
180
-             * @since 1.8.4
181
-             */
182
-            $field_options['new_window'] = array(
183
-                'type' => 'checkbox',
184
-                'label' => __( 'Open link in a new tab or window?', 'gravityview' ),
185
-                'value' => false,
186
-            );
187
-
188
-            return $field_options;
189
-        }
190
-
191
-        //  Entry field is only for logged in users
192
-        unset( $field_options['only_loggedin'], $field_options['only_loggedin_cap'] );
193
-
194
-        $add_options = array(
195
-            'allow_edit_cap' => array(
196
-                'type' => 'select',
197
-                'label' => __( 'Make field editable to:', 'gravityview' ),
198
-                'choices' => GravityView_Render_Settings::get_cap_choices( $template_id, $field_id, $context, $input_type ),
199
-                'tooltip' => 'allow_edit_cap',
200
-                'class' => 'widefat',
201
-                'value' => 'read', // Default: entry creator
202
-            ),
203
-        );
204
-
205
-        return array_merge( $field_options, $add_options );
206
-    }
176
+		// We only want to modify the settings for the edit context
177
+		if( 'edit' !== $context ) {
178
+
179
+			/**
180
+			 * @since 1.8.4
181
+			 */
182
+			$field_options['new_window'] = array(
183
+				'type' => 'checkbox',
184
+				'label' => __( 'Open link in a new tab or window?', 'gravityview' ),
185
+				'value' => false,
186
+			);
187
+
188
+			return $field_options;
189
+		}
190
+
191
+		//  Entry field is only for logged in users
192
+		unset( $field_options['only_loggedin'], $field_options['only_loggedin_cap'] );
193
+
194
+		$add_options = array(
195
+			'allow_edit_cap' => array(
196
+				'type' => 'select',
197
+				'label' => __( 'Make field editable to:', 'gravityview' ),
198
+				'choices' => GravityView_Render_Settings::get_cap_choices( $template_id, $field_id, $context, $input_type ),
199
+				'tooltip' => 'allow_edit_cap',
200
+				'class' => 'widefat',
201
+				'value' => 'read', // Default: entry creator
202
+			),
203
+		);
204
+
205
+		return array_merge( $field_options, $add_options );
206
+	}
207 207
 
208 208
 
209 209
 } // end class
Please login to merge, or discard this patch.
includes/extensions/delete-entry/class-delete-entry.php 1 patch
Spacing   +72 added lines, -72 removed lines patch added patch discarded remove patch
@@ -42,12 +42,12 @@  discard block
 block discarded – undo
42 42
 
43 43
 		add_action( 'wp', array( $this, 'process_delete' ), 10000 );
44 44
 
45
-		add_filter( 'gravityview_entry_default_fields', array( $this, 'add_default_field'), 10, 3 );
45
+		add_filter( 'gravityview_entry_default_fields', array( $this, 'add_default_field' ), 10, 3 );
46 46
 
47 47
 		add_action( 'gravityview_before', array( $this, 'maybe_display_message' ) );
48 48
 
49 49
 		// For the Delete Entry Link, you don't want visible to all users.
50
-		add_filter( 'gravityview_field_visibility_caps', array( $this, 'modify_visibility_caps'), 10, 5 );
50
+		add_filter( 'gravityview_field_visibility_caps', array( $this, 'modify_visibility_caps' ), 10, 5 );
51 51
 
52 52
 		// Modify the field options based on the name of the field type
53 53
 		add_filter( 'gravityview_template_delete_link_options', array( $this, 'delete_link_field_options' ), 10, 5 );
@@ -55,10 +55,10 @@  discard block
 block discarded – undo
55 55
 		// add template path to check for field
56 56
 		add_filter( 'gravityview_template_paths', array( $this, 'add_template_path' ) );
57 57
 
58
-		add_action( 'gravityview/edit-entry/publishing-action/after', array( $this, 'add_delete_button'), 10, 4 );
58
+		add_action( 'gravityview/edit-entry/publishing-action/after', array( $this, 'add_delete_button' ), 10, 4 );
59 59
 
60
-		add_action ( 'gravityview/delete-entry/deleted', array( $this, 'process_connected_posts' ), 10, 2 );
61
-		add_action ( 'gravityview/delete-entry/trashed', array( $this, 'process_connected_posts' ), 10, 2 );
60
+		add_action( 'gravityview/delete-entry/deleted', array( $this, 'process_connected_posts' ), 10, 2 );
61
+		add_action( 'gravityview/delete-entry/trashed', array( $this, 'process_connected_posts' ), 10, 2 );
62 62
 
63 63
 		add_filter( 'gravityview/field/is_visible', array( $this, 'maybe_not_visible' ), 10, 3 );
64 64
 
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 	 */
74 74
 	static function getInstance() {
75 75
 
76
-		if( empty( self::$instance ) ) {
76
+		if ( empty( self::$instance ) ) {
77 77
 			self::$instance = new self;
78 78
 		}
79 79
 
@@ -149,20 +149,20 @@  discard block
 block discarded – undo
149 149
 	function delete_link_field_options( $field_options, $template_id, $field_id, $context, $input_type ) {
150 150
 
151 151
 		// Always a link, never a filter
152
-		unset( $field_options['show_as_link'], $field_options['search_filter'] );
152
+		unset( $field_options[ 'show_as_link' ], $field_options[ 'search_filter' ] );
153 153
 
154 154
 		// Delete Entry link should only appear to visitors capable of editing entries
155
-		unset( $field_options['only_loggedin'], $field_options['only_loggedin_cap'] );
155
+		unset( $field_options[ 'only_loggedin' ], $field_options[ 'only_loggedin_cap' ] );
156 156
 
157
-		$add_option['delete_link'] = array(
157
+		$add_option[ 'delete_link' ] = array(
158 158
 			'type' => 'text',
159 159
 			'label' => __( 'Delete Link Text', 'gravityview' ),
160 160
 			'desc' => NULL,
161
-			'value' => __('Delete Entry', 'gravityview'),
161
+			'value' => __( 'Delete Entry', 'gravityview' ),
162 162
 			'merge_tags' => true,
163 163
 		);
164 164
 
165
-		$field_options['allow_edit_cap'] = array(
165
+		$field_options[ 'allow_edit_cap' ] = array(
166 166
 			'type' => 'select',
167 167
 			'label' => __( 'Allow the following users to delete the entry:', 'gravityview' ),
168 168
 			'choices' => GravityView_Render_Settings::get_cap_choices( $template_id, $field_id, $context, $input_type ),
@@ -186,8 +186,8 @@  discard block
 block discarded – undo
186 186
 	 */
187 187
 	function add_default_field( $entry_default_fields, $form = array(), $zone = '' ) {
188 188
 
189
-		if( 'edit' !== $zone ) {
190
-			$entry_default_fields['delete_link'] = array(
189
+		if ( 'edit' !== $zone ) {
190
+			$entry_default_fields[ 'delete_link' ] = array(
191 191
 				'label' => __( 'Delete Entry', 'gravityview' ),
192 192
 				'type'  => 'delete_link',
193 193
 				'desc'  => __( 'A link to delete the entry. Respects the Delete Entry permissions.', 'gravityview' ),
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
 	 */
205 205
 	function add_available_field( $available_fields = array() ) {
206 206
 
207
-		$available_fields['delete_link'] = array(
207
+		$available_fields[ 'delete_link' ] = array(
208 208
 			'label_text' => __( 'Delete Entry', 'gravityview' ),
209 209
 			'field_id' => 'delete_link',
210 210
 			'label_type' => 'field',
@@ -247,12 +247,12 @@  discard block
 block discarded – undo
247 247
 		$caps = $visibility_caps;
248 248
 
249 249
 		// If we're configuring fields in the edit context, we want a limited selection
250
-		if( $field_id === 'delete_link' ) {
250
+		if ( $field_id === 'delete_link' ) {
251 251
 
252 252
 			// Remove other built-in caps.
253
-			unset( $caps['publish_posts'], $caps['gravityforms_view_entries'], $caps['delete_others_posts'] );
253
+			unset( $caps[ 'publish_posts' ], $caps[ 'gravityforms_view_entries' ], $caps[ 'delete_others_posts' ] );
254 254
 
255
-			$caps['read'] = _x('Entry Creator', 'User capability', 'gravityview');
255
+			$caps[ 'read' ] = _x( 'Entry Creator', 'User capability', 'gravityview' );
256 256
 		}
257 257
 
258 258
 		return $caps;
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
 	 * @param [type] $entry [description]
266 266
 	 */
267 267
 	function set_entry( $entry = null ) {
268
-		$this->entry = empty( $entry ) ? GravityView_View::getInstance()->entries[0] : $entry;
268
+		$this->entry = empty( $entry ) ? GravityView_View::getInstance()->entries[ 0 ] : $entry;
269 269
 	}
270 270
 
271 271
 	/**
@@ -298,7 +298,7 @@  discard block
 block discarded – undo
298 298
 
299 299
 		self::getInstance()->set_entry( $entry );
300 300
 
301
-        $base = GravityView_API::directory_link( $post_id ? : $view_id, true );
301
+        $base = GravityView_API::directory_link( $post_id ?: $view_id, true );
302 302
 
303 303
 		if ( empty( $base ) ) {
304 304
 			gravityview()->log->error( 'Post ID does not exist: {post_id}', array( 'post_id' => $post_id ) );
@@ -317,7 +317,7 @@  discard block
 block discarded – undo
317 317
             'view_id' => $view_id,
318 318
 		), $base );
319 319
 
320
-		$url = wp_nonce_url( $actionurl, 'delete_'.$entry_slug, 'delete' );
320
+		$url = wp_nonce_url( $actionurl, 'delete_' . $entry_slug, 'delete' );
321 321
 
322 322
 		return $url;
323 323
 	}
@@ -339,7 +339,7 @@  discard block
 block discarded – undo
339 339
 	public function add_delete_button( $form = array(), $entry = array(), $view_id = null, $post_id = null ) {
340 340
 
341 341
 		// Only show the link to those who are allowed to see it.
342
-		if( !self::check_user_cap_delete_entry( $entry, array(), $view_id ) ) {
342
+		if ( ! self::check_user_cap_delete_entry( $entry, array(), $view_id ) ) {
343 343
 			return;
344 344
 		}
345 345
 
@@ -350,13 +350,13 @@  discard block
 block discarded – undo
350 350
 		$show_delete_button = apply_filters( 'gravityview/delete-entry/show-delete-button', true );
351 351
 
352 352
 		// If the button is hidden by the filter, don't show.
353
-		if( !$show_delete_button ) {
353
+		if ( ! $show_delete_button ) {
354 354
 			return;
355 355
 		}
356 356
 
357 357
 		$attributes = array(
358 358
 			'class' => 'btn btn-sm button button-small alignright pull-right btn-danger gv-button-delete',
359
-			'tabindex' => ( GFCommon::$tab_index ++ ),
359
+			'tabindex' => ( GFCommon::$tab_index++ ),
360 360
 			'onclick' => self::get_confirm_dialog(),
361 361
 		);
362 362
 
@@ -380,27 +380,27 @@  discard block
 block discarded – undo
380 380
 	function process_delete() {
381 381
 
382 382
 		// If the form is submitted
383
-		if( isset( $_GET['action'] ) && 'delete' === $_GET['action'] && isset( $_GET['entry_id'] ) ) {
383
+		if ( isset( $_GET[ 'action' ] ) && 'delete' === $_GET[ 'action' ] && isset( $_GET[ 'entry_id' ] ) ) {
384 384
 
385 385
 			// Make sure it's a GravityView request
386
-			$valid_nonce_key = wp_verify_nonce( $_GET['delete'], self::get_nonce_key( $_GET['entry_id'] ) );
386
+			$valid_nonce_key = wp_verify_nonce( $_GET[ 'delete' ], self::get_nonce_key( $_GET[ 'entry_id' ] ) );
387 387
 
388
-			if( ! $valid_nonce_key ) {
388
+			if ( ! $valid_nonce_key ) {
389 389
 				gravityview()->log->debug( 'Delete entry not processed: nonce validation failed.' );
390 390
 				return;
391 391
 			}
392 392
 
393 393
 			// Get the entry slug
394
-			$entry_slug = esc_attr( $_GET['entry_id'] );
394
+			$entry_slug = esc_attr( $_GET[ 'entry_id' ] );
395 395
 
396 396
 			// See if there's an entry there
397 397
 			$entry = gravityview_get_entry( $entry_slug, true, false );
398 398
 
399
-			if( $entry ) {
399
+			if ( $entry ) {
400 400
 
401 401
 				$has_permission = $this->user_can_delete_entry( $entry, \GV\Utils::_GET( 'gvid', \GV\Utils::_GET( 'view_id' ) ) );
402 402
 
403
-				if( is_wp_error( $has_permission ) ) {
403
+				if ( is_wp_error( $has_permission ) ) {
404 404
 
405 405
 					$messages = array(
406 406
 						'message' => urlencode( $has_permission->get_error_message() ),
@@ -412,7 +412,7 @@  discard block
 block discarded – undo
412 412
 					// Delete the entry
413 413
 					$delete_response = $this->delete_or_trash_entry( $entry );
414 414
 
415
-					if( is_wp_error( $delete_response ) ) {
415
+					if ( is_wp_error( $delete_response ) ) {
416 416
 
417 417
 						$messages = array(
418 418
 							'message' => urlencode( $delete_response->get_error_message() ),
@@ -434,7 +434,7 @@  discard block
 block discarded – undo
434 434
 				gravityview()->log->debug( 'Delete entry failed: there was no entry with the entry slug {entry_slug}', array( 'entry_slug' => $entry_slug ) );
435 435
 
436 436
 				$messages = array(
437
-					'message' => urlencode( __('The entry does not exist.', 'gravityview') ),
437
+					'message' => urlencode( __( 'The entry does not exist.', 'gravityview' ) ),
438 438
 					'status' => 'error',
439 439
 				);
440 440
 			}
@@ -474,18 +474,18 @@  discard block
 block discarded – undo
474 474
 	 */
475 475
 	private function delete_or_trash_entry( $entry ) {
476 476
 
477
-		$entry_id = $entry['id'];
477
+		$entry_id = $entry[ 'id' ];
478 478
 
479 479
 		$mode = $this->get_delete_mode();
480 480
 
481
-		if( 'delete' === $mode ) {
481
+		if ( 'delete' === $mode ) {
482 482
 
483 483
 			gravityview()->log->debug( 'Starting delete entry: {entry_id}', array( 'entry_id' => $entry_id ) );
484 484
 
485 485
 			// Delete the entry
486 486
 			$delete_response = GFAPI::delete_entry( $entry_id );
487 487
 
488
-			if( ! is_wp_error( $delete_response ) ) {
488
+			if ( ! is_wp_error( $delete_response ) ) {
489 489
 				$delete_response = 'deleted';
490 490
 
491 491
 				/**
@@ -506,8 +506,8 @@  discard block
 block discarded – undo
506 506
 			$trashed = GFAPI::update_entry_property( $entry_id, 'status', 'trash' );
507 507
 			new GravityView_Cache;
508 508
 
509
-			if( ! $trashed ) {
510
-				$delete_response = new WP_Error( 'trash_entry_failed', __('Moving the entry to the trash failed.', 'gravityview' ) );
509
+			if ( ! $trashed ) {
510
+				$delete_response = new WP_Error( 'trash_entry_failed', __( 'Moving the entry to the trash failed.', 'gravityview' ) );
511 511
 			} else {
512 512
 
513 513
 				/**
@@ -538,7 +538,7 @@  discard block
 block discarded – undo
538 538
 	public function process_connected_posts( $entry_id = 0, $entry = array() ) {
539 539
 
540 540
 		// The entry had no connected post
541
-		if( empty( $entry['post_id'] ) ) {
541
+		if ( empty( $entry[ 'post_id' ] ) ) {
542 542
 			return;
543 543
 		}
544 544
 
@@ -549,19 +549,19 @@  discard block
 block discarded – undo
549 549
 		 */
550 550
 		$delete_post = apply_filters( 'gravityview/delete-entry/delete-connected-post', true );
551 551
 
552
-		if( false === $delete_post ) {
552
+		if ( false === $delete_post ) {
553 553
 			return;
554 554
 		}
555 555
 
556 556
 		$action = current_action();
557 557
 
558
-		if( 'gravityview/delete-entry/deleted' === $action ) {
559
-			$result = wp_delete_post( $entry['post_id'], true );
558
+		if ( 'gravityview/delete-entry/deleted' === $action ) {
559
+			$result = wp_delete_post( $entry[ 'post_id' ], true );
560 560
 		} else {
561
-			$result = wp_trash_post( $entry['post_id'] );
561
+			$result = wp_trash_post( $entry[ 'post_id' ] );
562 562
 		}
563 563
 
564
-		if( false === $result ) {
564
+		if ( false === $result ) {
565 565
 			gravityview()->log->error( '(called by {action}): Error processing the Post connected to the entry.', array( 'action' => $action, 'data' => $entry ) );
566 566
 		} else {
567 567
 			gravityview()->log->debug( '(called by {action}): Successfully processed Post connected to the entry.', array( 'action' => $action, 'data' => $entry ) );
@@ -577,13 +577,13 @@  discard block
 block discarded – undo
577 577
 	public function verify_nonce() {
578 578
 
579 579
 		// No delete entry request was made
580
-		if( empty( $_GET['entry_id'] ) || empty( $_GET['delete'] ) ) {
580
+		if ( empty( $_GET[ 'entry_id' ] ) || empty( $_GET[ 'delete' ] ) ) {
581 581
 			return false;
582 582
 		}
583 583
 
584
-		$nonce_key = self::get_nonce_key( $_GET['entry_id'] );
584
+		$nonce_key = self::get_nonce_key( $_GET[ 'entry_id' ] );
585 585
 
586
-		$valid = wp_verify_nonce( $_GET['delete'], $nonce_key );
586
+		$valid = wp_verify_nonce( $_GET[ 'delete' ], $nonce_key );
587 587
 
588 588
 		/**
589 589
 		 * @filter `gravityview/delete-entry/verify_nonce` Override Delete Entry nonce validation. Return true to declare nonce valid.
@@ -605,7 +605,7 @@  discard block
 block discarded – undo
605 605
 	 */
606 606
 	public static function get_confirm_dialog() {
607 607
 
608
-		$confirm = __('Are you sure you want to delete this entry? This cannot be undone.', 'gravityview');
608
+		$confirm = __( 'Are you sure you want to delete this entry? This cannot be undone.', 'gravityview' );
609 609
 
610 610
 		/**
611 611
 		 * @filter `gravityview/delete-entry/confirm-text` Modify the Delete Entry Javascript confirmation text
@@ -613,7 +613,7 @@  discard block
 block discarded – undo
613 613
 		 */
614 614
 		$confirm = apply_filters( 'gravityview/delete-entry/confirm-text', $confirm );
615 615
 
616
-		return 'return window.confirm(\''. esc_js( $confirm ) .'\');';
616
+		return 'return window.confirm(\'' . esc_js( $confirm ) . '\');';
617 617
 	}
618 618
 
619 619
 	/**
@@ -631,16 +631,16 @@  discard block
 block discarded – undo
631 631
 
632 632
 		$error = NULL;
633 633
 
634
-		if( ! $this->verify_nonce() ) {
635
-			$error = __( 'The link to delete this entry is not valid; it may have expired.', 'gravityview');
634
+		if ( ! $this->verify_nonce() ) {
635
+			$error = __( 'The link to delete this entry is not valid; it may have expired.', 'gravityview' );
636 636
 		}
637 637
 
638
-		if( ! self::check_user_cap_delete_entry( $entry, array(), $view_id ) ) {
639
-			$error = __( 'You do not have permission to delete this entry.', 'gravityview');
638
+		if ( ! self::check_user_cap_delete_entry( $entry, array(), $view_id ) ) {
639
+			$error = __( 'You do not have permission to delete this entry.', 'gravityview' );
640 640
 		}
641 641
 
642
-		if( $entry['status'] === 'trash' ) {
643
-			if( 'trash' === $this->get_delete_mode() ) {
642
+		if ( $entry[ 'status' ] === 'trash' ) {
643
+			if ( 'trash' === $this->get_delete_mode() ) {
644 644
 				$error = __( 'The entry is already in the trash.', 'gravityview' );
645 645
 			} else {
646 646
 				$error = __( 'You cannot delete the entry; it is already in the trash.', 'gravityview' );
@@ -648,7 +648,7 @@  discard block
 block discarded – undo
648 648
 		}
649 649
 
650 650
 		// No errors; everything's fine here!
651
-		if( empty( $error ) ) {
651
+		if ( empty( $error ) ) {
652 652
 			return true;
653 653
 		}
654 654
 
@@ -676,17 +676,17 @@  discard block
 block discarded – undo
676 676
 			$view = \GV\View::by_id( $view_id );
677 677
 		} else {
678 678
 			if ( ! $view instanceof \GV\View ) {
679
-				$view = \GV\View::by_id ( $view );
679
+				$view = \GV\View::by_id( $view );
680 680
 			}
681 681
 			$view_id = $view->ID;
682 682
 		}
683 683
 
684 684
 		$current_user = wp_get_current_user();
685 685
 
686
-		$entry_id = isset( $entry['id'] ) ? $entry['id'] : NULL;
686
+		$entry_id = isset( $entry[ 'id' ] ) ? $entry[ 'id' ] : NULL;
687 687
 
688 688
 		// Or if they can delete any entries (as defined in Gravity Forms), we're good.
689
-		if( GVCommon::has_cap( array( 'gravityforms_delete_entries', 'gravityview_delete_others_entries' ), $entry_id ) ) {
689
+		if ( GVCommon::has_cap( array( 'gravityforms_delete_entries', 'gravityview_delete_others_entries' ), $entry_id ) ) {
690 690
 
691 691
 			gravityview()->log->debug( 'Current user has `gravityforms_delete_entries` or `gravityview_delete_others_entries` capability.' );
692 692
 
@@ -695,20 +695,20 @@  discard block
 block discarded – undo
695 695
 
696 696
 
697 697
 		// If field options are passed, check if current user can view the link
698
-		if( !empty( $field ) ) {
698
+		if ( ! empty( $field ) ) {
699 699
 
700 700
 			// If capability is not defined, something is not right!
701
-			if( empty( $field['allow_edit_cap'] ) ) {
701
+			if ( empty( $field[ 'allow_edit_cap' ] ) ) {
702 702
 
703 703
 				gravityview()->log->error( 'Cannot read delete entry field caps', array( 'data' => $field ) );
704 704
 
705 705
 				return false;
706 706
 			}
707 707
 
708
-			if( GVCommon::has_cap( $field['allow_edit_cap'] ) ) {
708
+			if ( GVCommon::has_cap( $field[ 'allow_edit_cap' ] ) ) {
709 709
 
710 710
 				// Do not return true if cap is read, as we need to check if the current user created the entry
711
-				if( $field['allow_edit_cap'] !== 'read' ) {
711
+				if ( $field[ 'allow_edit_cap' ] !== 'read' ) {
712 712
 					return true;
713 713
 				}
714 714
 
@@ -721,9 +721,9 @@  discard block
 block discarded – undo
721 721
 
722 722
 		}
723 723
 
724
-		if( !isset( $entry['created_by'] ) ) {
724
+		if ( ! isset( $entry[ 'created_by' ] ) ) {
725 725
 
726
-			gravityview()->log->error( 'Entry `created_by` doesn\'t exist.');
726
+			gravityview()->log->error( 'Entry `created_by` doesn\'t exist.' );
727 727
 
728 728
 			return false;
729 729
 		}
@@ -737,7 +737,7 @@  discard block
 block discarded – undo
737 737
 		}
738 738
 
739 739
 		// If the logged-in user is the same as the user who created the entry, we're good.
740
-		if( is_user_logged_in() && intval( $current_user->ID ) === intval( $entry['created_by'] ) ) {
740
+		if ( is_user_logged_in() && intval( $current_user->ID ) === intval( $entry[ 'created_by' ] ) ) {
741 741
 
742 742
 			gravityview()->log->debug( 'User {user_id} created the entry.', array( 'user_id' => $current_user->ID ) );
743 743
 
@@ -761,12 +761,12 @@  discard block
 block discarded – undo
761 761
 	 * @return void
762 762
 	 */
763 763
 	public function maybe_display_message( $current_view_id = 0 ) {
764
-		if( empty( $_GET['status'] ) || ! self::verify_nonce() ) {
764
+		if ( empty( $_GET[ 'status' ] ) || ! self::verify_nonce() ) {
765 765
 			return;
766 766
 		}
767 767
 
768 768
 		// Entry wasn't deleted from current View
769
-		if( isset( $_GET['view_id'] ) && intval( $_GET['view_id'] ) !== intval( $current_view_id ) ) {
769
+		if ( isset( $_GET[ 'view_id' ] ) && intval( $_GET[ 'view_id' ] ) !== intval( $current_view_id ) ) {
770 770
 			return;
771 771
 		}
772 772
 
@@ -775,11 +775,11 @@  discard block
 block discarded – undo
775 775
 
776 776
 	public function display_message() {
777 777
 
778
-		if ( empty( $_GET['status'] ) || empty( $_GET['delete'] ) ) {
778
+		if ( empty( $_GET[ 'status' ] ) || empty( $_GET[ 'delete' ] ) ) {
779 779
 			return;
780 780
 		}
781 781
 
782
-		$status = esc_attr( $_GET['status'] );
782
+		$status = esc_attr( $_GET[ 'status' ] );
783 783
 		$message_from_url = \GV\Utils::_GET( 'message' );
784 784
 		$message_from_url = rawurldecode( stripslashes_deep( $message_from_url ) );
785 785
 		$class = '';
@@ -787,14 +787,14 @@  discard block
 block discarded – undo
787 787
 		switch ( $status ) {
788 788
 			case 'error':
789 789
 				$class = ' gv-error error';
790
-				$error_message = __('There was an error deleting the entry: %s', 'gravityview');
790
+				$error_message = __( 'There was an error deleting the entry: %s', 'gravityview' );
791 791
 				$message = sprintf( $error_message, $message_from_url );
792 792
 				break;
793 793
 			case 'trashed':
794
-				$message = __('The entry was successfully moved to the trash.', 'gravityview');
794
+				$message = __( 'The entry was successfully moved to the trash.', 'gravityview' );
795 795
 				break;
796 796
 			default:
797
-				$message = __('The entry was successfully deleted.', 'gravityview');
797
+				$message = __( 'The entry was successfully deleted.', 'gravityview' );
798 798
 				break;
799 799
 		}
800 800
 
@@ -808,7 +808,7 @@  discard block
 block discarded – undo
808 808
 		$message = apply_filters( 'gravityview/delete-entry/message', esc_attr( $message ), $status, $message_from_url );
809 809
 
810 810
 		// DISPLAY ERROR/SUCCESS MESSAGE
811
-		echo '<div class="gv-notice' . esc_attr( $class ) .'">'. $message .'</div>';
811
+		echo '<div class="gv-notice' . esc_attr( $class ) . '">' . $message . '</div>';
812 812
 	}
813 813
 
814 814
 
Please login to merge, or discard this patch.