Completed
Pull Request — develop (#1143)
by Zack
15:48
created
future/includes/class-gv-view.php 2 patches
Spacing   +26 added lines, -27 removed lines patch added patch discarded remove patch
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 		$supports = array( 'title', 'revisions' );
109 109
 
110 110
 		if ( $is_hierarchical ) {
111
-			$supports[] = 'page-attributes';
111
+			$supports[ ] = 'page-attributes';
112 112
 		}
113 113
 
114 114
 		/**
@@ -210,11 +210,11 @@  discard block
 block discarded – undo
210 210
 		$rule = array( sprintf( '%s/([^/]+)/csv/?', $slug ), 'index.php?gravityview=$matches[1]&csv=1', 'top' );
211 211
 
212 212
 		add_filter( 'query_vars', function( $query_vars ) { 
213
-			$query_vars[] = 'csv';
213
+			$query_vars[ ] = 'csv';
214 214
 			return $query_vars;
215 215
 		} );
216 216
 
217
-		if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[0] ] ) ) {
217
+		if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[ 0 ] ] ) ) {
218 218
 			call_user_func_array( 'add_rewrite_rule', $rule );
219 219
 		}
220 220
 	}
@@ -278,13 +278,13 @@  discard block
 block discarded – undo
278 278
 			return $content;
279 279
 		}
280 280
 
281
-		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap('gravityview_moderate_entries', $view->ID );
281
+		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap( 'gravityview_moderate_entries', $view->ID );
282 282
 
283 283
 		/**
284 284
 		 * Editing a single entry.
285 285
 		 */
286 286
 		if ( $entry = $request->is_edit_entry() ) {
287
-			if ( $entry['status'] != 'active' ) {
287
+			if ( $entry[ 'status' ] != 'active' ) {
288 288
 				gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
289 289
 				return __( 'You are not allowed to view this content.', 'gravityview' );
290 290
 			}
@@ -295,7 +295,7 @@  discard block
 block discarded – undo
295 295
 			}
296 296
 
297 297
 			if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
298
-				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
298
+				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
299 299
 					gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
300 300
 					return __( 'You are not allowed to view this content.', 'gravityview' );
301 301
 				}
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
308 308
 		 * Viewing a single entry.
309 309
 		 */
310 310
 		} else if ( $entry = $request->is_entry() ) {
311
-			if ( $entry['status'] != 'active' ) {
311
+			if ( $entry[ 'status' ] != 'active' ) {
312 312
 				gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
313 313
 				return __( 'You are not allowed to view this content.', 'gravityview' );
314 314
 			}
@@ -319,7 +319,7 @@  discard block
 block discarded – undo
319 319
 			}
320 320
 
321 321
 			if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
322
-				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
322
+				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
323 323
 					gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
324 324
 					return __( 'You are not allowed to view this content.', 'gravityview' );
325 325
 				}
@@ -327,7 +327,7 @@  discard block
 block discarded – undo
327 327
 
328 328
 			$error = \GVCommon::check_entry_display( $entry->as_entry() );
329 329
 
330
-			if( is_wp_error( $error ) ) {
330
+			if ( is_wp_error( $error ) ) {
331 331
 				gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing: {message}', array( 'entry_id' => $entry->ID, 'message' => $error->get_error_message() ) );
332 332
 				return __( 'You are not allowed to view this content.', 'gravityview' );
333 333
 			}
@@ -483,7 +483,7 @@  discard block
 block discarded – undo
483 483
 			$join_column    = is_numeric( $join_column ) ? GF_Field::by_id( $join, $join_column ) : Internal_Field( $join_column );
484 484
 			$join_on_column = is_numeric( $join_on_column ) ? GF_Field::by_id( $join_on, $join_on_column ) : Internal_Field( $join_on_column );
485 485
 
486
-			$joins [] = new Join( $join, $join_column, $join_on, $join_on_column );
486
+			$joins [ ] = new Join( $join, $join_column, $join_on, $join_on_column );
487 487
 		}
488 488
 
489 489
 		return $joins;
@@ -525,10 +525,10 @@  discard block
 block discarded – undo
525 525
 
526 526
 			list( $join, $join_column, $join_on, $join_on_column ) = $meta;
527 527
 
528
-			$forms_ids [] = GF_Form::by_id( $join_on );
528
+			$forms_ids [ ] = GF_Form::by_id( $join_on );
529 529
 		}
530 530
 
531
-		return ( !empty( $forms_ids) ) ? $forms_ids : null;
531
+		return ( ! empty( $forms_ids ) ) ? $forms_ids : null;
532 532
 	}
533 533
 
534 534
 	/**
@@ -559,7 +559,7 @@  discard block
 block discarded – undo
559 559
 		if ( ! $view->form ) {
560 560
 			gravityview()->log->error( 'View #{view_id} tried attaching non-existent Form #{form_id} to it.', array(
561 561
 				'view_id' => $view->ID,
562
-				'form_id' => $view->_gravityview_form_id ? : 0,
562
+				'form_id' => $view->_gravityview_form_id ?: 0,
563 563
 			) );
564 564
 		}
565 565
 
@@ -785,28 +785,27 @@  discard block
 block discarded – undo
785 785
 			 * @todo: Stop using _frontend and use something like $request->get_search_criteria() instead
786 786
 			 */
787 787
 			$parameters = \GravityView_frontend::get_view_entries_parameters( $this->settings->as_atts(), $this->form->ID );
788
-			$parameters['context_view_id'] = $this->ID;
788
+			$parameters[ 'context_view_id' ] = $this->ID;
789 789
 			$parameters = \GVCommon::calculate_get_entries_criteria( $parameters, $this->form->ID );
790 790
 
791 791
 			if ( $request instanceof REST\Request ) {
792 792
 				$atts = $this->settings->as_atts();
793 793
 				$paging_parameters = wp_parse_args( $request->get_paging(), array(
794
-						'paging' => array( 'page_size' => $atts['page_size'] ),
794
+						'paging' => array( 'page_size' => $atts[ 'page_size' ] ),
795 795
 					) );
796
-				$parameters['paging'] = $paging_parameters['paging'];
796
+				$parameters[ 'paging' ] = $paging_parameters[ 'paging' ];
797 797
 			}
798 798
 
799
-			$page = Utils::get( $parameters['paging'], 'current_page' ) ?
800
-				: ( ( ( $parameters['paging']['offset'] - $this->settings->get( 'offset' ) ) / $parameters['paging']['page_size'] ) + 1 );
799
+			$page = Utils::get( $parameters[ 'paging' ], 'current_page' ) ?: ( ( ( $parameters[ 'paging' ][ 'offset' ] - $this->settings->get( 'offset' ) ) / $parameters[ 'paging' ][ 'page_size' ] ) + 1 );
801 800
 
802 801
 			if ( gravityview()->plugin->supports( Plugin::FEATURE_GFQUERY ) ) {
803 802
 				/**
804 803
 				 * New \GF_Query stuff :)
805 804
 				 */
806
-				$query = new \GF_Query( $this->form->ID, $parameters['search_criteria'], $parameters['sorting'] );
805
+				$query = new \GF_Query( $this->form->ID, $parameters[ 'search_criteria' ], $parameters[ 'sorting' ] );
807 806
 
808
-				$query->limit( $parameters['paging']['page_size'] )
809
-					->offset( ( ( $page - 1 ) * $parameters['paging']['page_size'] ) + $this->settings->get( 'offset' ) );
807
+				$query->limit( $parameters[ 'paging' ][ 'page_size' ] )
808
+					->offset( ( ( $page - 1 ) * $parameters[ 'paging' ][ 'page_size' ] ) + $this->settings->get( 'offset' ) );
810 809
 
811 810
 				/**
812 811
 				 * Any joins?
@@ -846,15 +845,15 @@  discard block
 block discarded – undo
846 845
 				} );
847 846
 			} else {
848 847
 				$entries = $this->form->entries
849
-					->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters['search_criteria'] ) )
848
+					->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters[ 'search_criteria' ] ) )
850 849
 					->offset( $this->settings->get( 'offset' ) )
851
-					->limit( $parameters['paging']['page_size'] )
850
+					->limit( $parameters[ 'paging' ][ 'page_size' ] )
852 851
 					->page( $page );
853 852
 
854
-				if ( ! empty( $parameters['sorting'] ) && ! empty( $parameters['sorting']['key'] ) ) {
853
+				if ( ! empty( $parameters[ 'sorting' ] ) && ! empty( $parameters[ 'sorting' ][ 'key' ] ) ) {
855 854
 					$field = new \GV\Field();
856
-					$field->ID = $parameters['sorting']['key'];
857
-					$direction = strtolower( $parameters['sorting']['direction'] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
855
+					$field->ID = $parameters[ 'sorting' ][ 'key' ];
856
+					$direction = strtolower( $parameters[ 'sorting' ][ 'direction' ] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
858 857
 					$entries = $entries->sort( new \GV\Entry_Sort( $field, $direction ) );
859 858
 				}
860 859
 			}
@@ -912,7 +911,7 @@  discard block
 block discarded – undo
912 911
 		 * @todo Maybe create a CSV_Renderer?
913 912
 		 */
914 913
 		foreach ( $view->fields->by_position( "directory_*" )->by_visible()->all() as $field ) {
915
-			$allowed[] = $field->ID;
914
+			$allowed[ ] = $field->ID;
916 915
 		}
917 916
 
918 917
 		foreach ( $entries->all() as $entry ) {
Please login to merge, or discard this patch.
Braces   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
 		$slug = apply_filters( 'gravityview_slug', 'view' );
210 210
 		$rule = array( sprintf( '%s/([^/]+)/csv/?', $slug ), 'index.php?gravityview=$matches[1]&csv=1', 'top' );
211 211
 
212
-		add_filter( 'query_vars', function( $query_vars ) { 
212
+		add_filter( 'query_vars', function( $query_vars ) {
213 213
 			$query_vars[] = 'csv';
214 214
 			return $query_vars;
215 215
 		} );
@@ -254,8 +254,9 @@  discard block
 block discarded – undo
254 254
 		 * Check permissions.
255 255
 		 */
256 256
 		while ( $error = $view->can_render( null, $request ) ) {
257
-			if ( ! is_wp_error( $error ) )
258
-				break;
257
+			if ( ! is_wp_error( $error ) ) {
258
+							break;
259
+			}
259 260
 
260 261
 			switch ( str_replace( 'gravityview/', '', $error->get_error_code() ) ) {
261 262
 				case 'post_password_required':
Please login to merge, or discard this patch.
future/includes/rest/class-gv-rest-route.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
 
133 133
 		$format = '(?:\.(?P<format>html|json))?';
134 134
 
135
-		register_rest_route( $namespace, sprintf( '/%s/(?P<id>[\d]+)/%s/(?P<s_id>[\w-]+)%s', $base, $sub_type, $format ) , array(
135
+		register_rest_route( $namespace, sprintf( '/%s/(?P<id>[\d]+)/%s/(?P<s_id>[\w-]+)%s', $base, $sub_type, $format ), array(
136 136
 			array(
137 137
 				'methods'         => \WP_REST_Server::READABLE,
138 138
 				'callback'        => array( $this, 'get_sub_item' ),
@@ -383,7 +383,7 @@  discard block
 block discarded – undo
383 383
 	 * @return \WP_REST_Response
384 384
 	 */
385 385
 	protected function not_implemented(  ) {
386
-		$error = new \WP_Error( 'not-implemented-yet', __( 'Endpoint Not Yet Implemented.', 'gravityview' )  );
386
+		$error = new \WP_Error( 'not-implemented-yet', __( 'Endpoint Not Yet Implemented.', 'gravityview' ) );
387 387
 		return new \WP_REST_Response( $error, 501 );
388 388
 	}
389 389
 
Please login to merge, or discard this patch.