Completed
Push — master ( 7ba298...2ce894 )
by Zack
38:21 queued 18:44
created
includes/admin/metaboxes/views/view-configuration.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -10,33 +10,33 @@  discard block
 block discarded – undo
10 10
 
11 11
 		<div id="directory-fields" class="gv-section">
12 12
 
13
-			<h4><?php esc_html_e( 'Above Entries Widgets', 'gravityview'); ?> <span><?php esc_html_e( 'These widgets will be shown above entries.', 'gravityview'); ?></span></h4>
13
+			<h4><?php esc_html_e( 'Above Entries Widgets', 'gravityview' ); ?> <span><?php esc_html_e( 'These widgets will be shown above entries.', 'gravityview' ); ?></span></h4>
14 14
 
15
-			<?php do_action('gravityview_render_widgets_active_areas', $curr_template, 'header', $post->ID ); ?>
15
+			<?php do_action( 'gravityview_render_widgets_active_areas', $curr_template, 'header', $post->ID ); ?>
16 16
 
17
-			<h4><?php esc_html_e( 'Entries Fields', 'gravityview'); ?> <span><?php esc_html_e( 'These fields will be shown for each entry.', 'gravityview'); ?></span></h4>
17
+			<h4><?php esc_html_e( 'Entries Fields', 'gravityview' ); ?> <span><?php esc_html_e( 'These fields will be shown for each entry.', 'gravityview' ); ?></span></h4>
18 18
 
19 19
 			<div id="directory-active-fields" class="gv-grid gv-grid-pad gv-grid-border">
20
-				<?php if(!empty( $curr_template ) ) {
21
-					do_action('gravityview_render_directory_active_areas', $curr_template, 'directory', $post->ID, true );
20
+				<?php if ( ! empty( $curr_template ) ) {
21
+					do_action( 'gravityview_render_directory_active_areas', $curr_template, 'directory', $post->ID, true );
22 22
 				} ?>
23 23
 			</div>
24 24
 
25
-			<h4><?php esc_html_e( 'Below Entries Widgets', 'gravityview'); ?> <span><?php esc_html_e( 'These widgets will be shown below entries.', 'gravityview'); ?></span></h4>
25
+			<h4><?php esc_html_e( 'Below Entries Widgets', 'gravityview' ); ?> <span><?php esc_html_e( 'These widgets will be shown below entries.', 'gravityview' ); ?></span></h4>
26 26
 
27
-			<?php do_action('gravityview_render_widgets_active_areas', $curr_template, 'footer', $post->ID ); ?>
27
+			<?php do_action( 'gravityview_render_widgets_active_areas', $curr_template, 'footer', $post->ID ); ?>
28 28
 
29 29
 
30 30
 			<?php // list of available fields to be shown in the popup ?>
31 31
 			<div id="directory-available-fields" class="hide-if-js gv-tooltip">
32 32
 				<span class="close"><i class="dashicons dashicons-dismiss"></i></span>
33
-				<?php do_action('gravityview_render_available_fields', $curr_form, 'directory' ); ?>
33
+				<?php do_action( 'gravityview_render_available_fields', $curr_form, 'directory' ); ?>
34 34
 			</div>
35 35
 
36 36
 			<?php // list of available widgets to be shown in the popup ?>
37 37
 			<div id="directory-available-widgets" class="hide-if-js gv-tooltip">
38 38
 				<span class="close"><i class="dashicons dashicons-dismiss"></i></span>
39
-				<?php do_action('gravityview_render_available_widgets' ); ?>
39
+				<?php do_action( 'gravityview_render_available_widgets' ); ?>
40 40
 			</div>
41 41
 
42 42
 		</div>
@@ -52,17 +52,17 @@  discard block
 block discarded – undo
52 52
 
53 53
 		<div id="single-fields" class="gv-section">
54 54
 
55
-			<h4><?php esc_html_e( 'These fields will be shown in Single Entry view.', 'gravityview'); ?></h4>
55
+			<h4><?php esc_html_e( 'These fields will be shown in Single Entry view.', 'gravityview' ); ?></h4>
56 56
 
57 57
 			<div id="single-active-fields" class="gv-grid gv-grid-pad gv-grid-border">
58
-				<?php if(!empty( $curr_template ) ) {
59
-					do_action('gravityview_render_directory_active_areas', $curr_template, 'single', $post->ID, true );
58
+				<?php if ( ! empty( $curr_template ) ) {
59
+					do_action( 'gravityview_render_directory_active_areas', $curr_template, 'single', $post->ID, true );
60 60
 				} ?>
61 61
 			</div>
62 62
 
63 63
 			<div id="single-available-fields" class="hide-if-js gv-tooltip">
64 64
 				<span class="close"><i class="dashicons dashicons-dismiss"></i></span>
65
-				<?php do_action('gravityview_render_available_fields', $curr_form, 'single' ); ?>
65
+				<?php do_action( 'gravityview_render_available_fields', $curr_form, 'single' ); ?>
66 66
 			</div>
67 67
 
68 68
 		</div>
@@ -73,17 +73,17 @@  discard block
 block discarded – undo
73 73
 
74 74
 		<div id="edit-fields" class="gv-section">
75 75
 
76
-			<h4><?php esc_html_e( 'Fields shown when editing an entry.', 'gravityview'); ?> <span><?php esc_html_e('If not configured, all form fields will be displayed.', 'gravityview'); ?></span></h4>
76
+			<h4><?php esc_html_e( 'Fields shown when editing an entry.', 'gravityview' ); ?> <span><?php esc_html_e( 'If not configured, all form fields will be displayed.', 'gravityview' ); ?></span></h4>
77 77
 
78 78
 			<div id="edit-active-fields" class="gv-grid gv-grid-pad gv-grid-border">
79 79
 				<?php
80
-				do_action('gravityview_render_directory_active_areas', apply_filters( 'gravityview/template/edit', 'default_table_edit' ), 'edit', $post->ID, true );
80
+				do_action( 'gravityview_render_directory_active_areas', apply_filters( 'gravityview/template/edit', 'default_table_edit' ), 'edit', $post->ID, true );
81 81
 				?>
82 82
 			</div>
83 83
 
84 84
 			<div id="edit-available-fields" class="hide-if-js gv-tooltip">
85 85
 				<span class="close"><i class="dashicons dashicons-dismiss"></i></span>
86
-				<?php do_action('gravityview_render_available_fields', $curr_form, 'edit' ); ?>
86
+				<?php do_action( 'gravityview_render_available_fields', $curr_form, 'edit' ); ?>
87 87
 			</div>
88 88
 
89 89
 		</div>
Please login to merge, or discard this patch.
includes/admin/class-gravityview-admin-view-item.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -42,9 +42,9 @@  discard block
 block discarded – undo
42 42
 	function __construct( $title = '', $item_id, $item = array(), $settings = array() ) {
43 43
 
44 44
 		// Backward compat
45
-		if ( ! empty( $item['type'] ) ) {
46
-			$item['input_type'] = $item['type'];
47
-			unset( $item['type'] );
45
+		if ( ! empty( $item[ 'type' ] ) ) {
46
+			$item[ 'input_type' ] = $item[ 'type' ];
47
+			unset( $item[ 'type' ] );
48 48
 		}
49 49
 
50 50
 		// Prevent items from not having index set
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 		$this->item       = $item;
65 65
 		$this->id         = $item_id;
66 66
 		$this->settings   = $settings;
67
-		$this->label_type = $item['label_type'];
67
+		$this->label_type = $item[ 'label_type' ];
68 68
 	}
69 69
 
70 70
 	/**
@@ -107,10 +107,10 @@  discard block
 block discarded – undo
107 107
 		if ( $html ) {
108 108
 
109 109
 			foreach ( $field_info_items as $item ) {
110
-				$class = isset( $item['class'] ) ? sanitize_html_class( $item['class'] ) . ' description' : 'description';
110
+				$class = isset( $item[ 'class' ] ) ? sanitize_html_class( $item[ 'class' ] ) . ' description' : 'description';
111 111
 				// Add the title in case the value's long, in which case, it'll be truncated by CSS.
112 112
 				$output .= '<span class="' . $class . '">';
113
-				$output .= esc_html( $item['value'] );
113
+				$output .= esc_html( $item[ 'value' ] );
114 114
 				$output .= '</span>';
115 115
 			}
116 116
 
@@ -138,29 +138,29 @@  discard block
 block discarded – undo
138 138
 
139 139
 		// $settings_html will just be hidden inputs if empty. Otherwise, it'll have an <ul>. Ugly hack, I know.
140 140
 		// TODO: Un-hack this
141
-		$hide_settings_link = ( empty( $this->item['settings_html'] ) || strpos( $this->item['settings_html'], '<!-- No Options -->' ) > 0 ) ? 'hide-if-js' : '';
141
+		$hide_settings_link = ( empty( $this->item[ 'settings_html' ] ) || strpos( $this->item[ 'settings_html' ], '<!-- No Options -->' ) > 0 ) ? 'hide-if-js' : '';
142 142
 		$settings_link      = sprintf( '<a href="#settings" class="dashicons-admin-generic dashicons %s" title="%s"></a>', $hide_settings_link, esc_attr( $settings_title ) );
143 143
 
144 144
 		// Should we show the icon that the field is being used as a link to single entry?
145
-		$hide_show_as_link_class = empty( $this->settings['show_as_link'] ) ? 'hide-if-js' : '';
145
+		$hide_show_as_link_class = empty( $this->settings[ 'show_as_link' ] ) ? 'hide-if-js' : '';
146 146
 		$show_as_link            = '<span class="dashicons dashicons-admin-links ' . $hide_show_as_link_class . '" title="' . esc_attr( $single_link_title ) . '"></span>';
147 147
 
148 148
 		// When a field label is empty, use the Field ID
149 149
 		$label = empty( $this->title ) ? sprintf( _x( 'Field #%s (No Label)', 'Label in field picker for empty label', 'gravityview' ), $this->id ) : $this->title;
150 150
 
151 151
 		// If there's a custom label, and show label is checked, use that as the field heading
152
-		if ( ! empty( $this->settings['custom_label'] ) && ! empty( $this->settings['show_label'] ) ) {
153
-			$label = $this->settings['custom_label'];
154
-		} else if ( ! empty( $this->item['customLabel'] ) ) {
155
-			$label = $this->item['customLabel'];
152
+		if ( ! empty( $this->settings[ 'custom_label' ] ) && ! empty( $this->settings[ 'show_label' ] ) ) {
153
+			$label = $this->settings[ 'custom_label' ];
154
+		} else if ( ! empty( $this->item[ 'customLabel' ] ) ) {
155
+			$label = $this->item[ 'customLabel' ];
156 156
 		}
157 157
 
158 158
 		$output = '<h5 class="selectable gfield field-id-' . esc_attr( $this->id ) . '">';
159 159
 
160 160
 		$label = esc_attr( $label );
161 161
 
162
-		if ( ! empty( $this->item['parent'] ) ) {
163
-			$label .= ' <small>(' . esc_attr( $this->item['parent']['label'] ) . ')</small>';
162
+		if ( ! empty( $this->item[ 'parent' ] ) ) {
163
+			$label .= ' <small>(' . esc_attr( $this->item[ 'parent' ][ 'label' ] ) . ')</small>';
164 164
 		}
165 165
 
166 166
 		// Name of field / widget
@@ -176,9 +176,9 @@  discard block
 block discarded – undo
176 176
 
177 177
 		$output .= '</h5>';
178 178
 
179
-		$container_class = ! empty( $this->item['parent'] ) ? ' gv-child-field' : '';
179
+		$container_class = ! empty( $this->item[ 'parent' ] ) ? ' gv-child-field' : '';
180 180
 
181
-		$output = '<div data-fieldid="' . esc_attr( $this->id ) . '" data-inputtype="' . esc_attr( $this->item['input_type'] ) . '" class="gv-fields' . $container_class . '">' . $output . $this->item['settings_html'] . '</div>';
181
+		$output = '<div data-fieldid="' . esc_attr( $this->id ) . '" data-inputtype="' . esc_attr( $this->item[ 'input_type' ] ) . '" class="gv-fields' . $container_class . '">' . $output . $this->item[ 'settings_html' ] . '</div>';
182 182
 
183 183
 		return $output;
184 184
 	}
Please login to merge, or discard this patch.
includes/class-admin-views.php 2 patches
Indentation   +71 added lines, -71 removed lines patch added patch discarded remove patch
@@ -62,28 +62,28 @@  discard block
 block discarded – undo
62 62
 	}
63 63
 
64 64
 	/**
65
-     * When on the Add/Edit View screen, suggest most popular articles related to that
66
-     *
65
+	 * When on the Add/Edit View screen, suggest most popular articles related to that
66
+	 *
67 67
 	 * @param array $localization_data Data to be passed to the Support Port JS
68 68
 	 *
69 69
 	 * @return array
70 70
 	 */
71 71
 	function suggest_support_articles( $localization_data = array() ) {
72 72
 
73
-	    if( ! gravityview()->request->is_view() ) {
74
-	        return $localization_data;
75
-        }
73
+		if( ! gravityview()->request->is_view() ) {
74
+			return $localization_data;
75
+		}
76 76
 
77 77
 		$localization_data['suggest'] = array(
78
-            '57ef23539033602e61d4a560',
79
-            '54c67bb9e4b0512429885513',
80
-            '54c67bb9e4b0512429885512',
81
-            '54c67bbbe4b07997ea3f3f6b',
82
-            '54d1a33ae4b086c0c0964ce9',
83
-            '57ef253c9033602e61d4a563',
84
-            '552355bfe4b0221aadf2572b',
85
-            '54c67bcde4b051242988553e',
86
-        );
78
+			'57ef23539033602e61d4a560',
79
+			'54c67bb9e4b0512429885513',
80
+			'54c67bb9e4b0512429885512',
81
+			'54c67bbbe4b07997ea3f3f6b',
82
+			'54d1a33ae4b086c0c0964ce9',
83
+			'57ef253c9033602e61d4a563',
84
+			'552355bfe4b0221aadf2572b',
85
+			'54c67bcde4b051242988553e',
86
+		);
87 87
 
88 88
 		return $localization_data;
89 89
 	}
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
 
168 168
 		if( empty( $connected_views ) ) {
169 169
 
170
-		    $menu_items['gravityview'] = array(
170
+			$menu_items['gravityview'] = array(
171 171
 				'label'          => esc_attr__( 'Create a View', 'gravityview' ),
172 172
 				'icon'           => '<i class="fa fa-lg gv-icon-astronaut-head gv-icon"></i>',
173 173
 				'title'          => esc_attr__( 'Create a View using this form as a data source', 'gravityview' ),
@@ -198,13 +198,13 @@  discard block
 block discarded – undo
198 198
 		// If there were no items added, then let's create the parent menu
199 199
 		if( $sub_menu_items ) {
200 200
 
201
-		    $sub_menu_items[] = array(
202
-			    'label' => esc_attr__( 'Create a View', 'gravityview' ),
203
-                'link_class' => 'gv-create-view',
204
-			    'title' => esc_attr__( 'Create a View using this form as a data source', 'gravityview' ),
205
-			    'url'   => admin_url( 'post-new.php?post_type=gravityview&form_id=' . $id ),
206
-			    'capabilities'   => array( 'edit_gravityviews' ),
207
-            );
201
+			$sub_menu_items[] = array(
202
+				'label' => esc_attr__( 'Create a View', 'gravityview' ),
203
+				'link_class' => 'gv-create-view',
204
+				'title' => esc_attr__( 'Create a View using this form as a data source', 'gravityview' ),
205
+				'url'   => admin_url( 'post-new.php?post_type=gravityview&form_id=' . $id ),
206
+				'capabilities'   => array( 'edit_gravityviews' ),
207
+			);
208 208
 
209 209
 			// Make sure Gravity Forms uses the submenu; if there's only one item, it uses a link instead of a dropdown
210 210
 			$sub_menu_items[] = array(
@@ -587,12 +587,12 @@  discard block
 block discarded – undo
587 587
 	 * Render html for displaying available fields based on a Form ID
588 588
 	 * $blacklist_field_types - contains the field types which are not proper to be shown in a directory.
589 589
 	 *
590
-     * @see GravityView_Ajax::get_available_fields_html() Triggers `gravityview_render_available_fields` action
590
+	 * @see GravityView_Ajax::get_available_fields_html() Triggers `gravityview_render_available_fields` action
591 591
 	 * @access public
592
-     *
592
+	 *
593 593
 	 * @param int $form Gravity Forms Form ID (default: '')
594 594
 	 * @param string $context (default: 'single')
595
-     *
595
+	 *
596 596
 	 * @return void
597 597
 	 */
598 598
 	function render_available_fields( $form = 0, $context = 'single' ) {
@@ -606,7 +606,7 @@  discard block
 block discarded – undo
606 606
 
607 607
 		if ( ! is_array( $blacklist_field_types ) ) {
608 608
 
609
-		    gravityview()->log->error( '$blacklist_field_types is not an array', array( 'data' => print_r( $blacklist_field_types, true ) ) );
609
+			gravityview()->log->error( '$blacklist_field_types is not an array', array( 'data' => print_r( $blacklist_field_types, true ) ) );
610 610
 
611 611
 			$blacklist_field_types = array();
612 612
 		}
@@ -738,12 +738,12 @@  discard block
 block discarded – undo
738 738
 				/**
739 739
 				 * @since 1.7.2
740 740
 				 */
741
-			    'other_entries' => array(
742
-				    'label'	=> __('Other Entries', 'gravityview'),
743
-				    'type'	=> 'other_entries',
744
-				    'desc'	=> __('Display other entries created by the entry creator.', 'gravityview'),
745
-			    ),
746
-	        );
741
+				'other_entries' => array(
742
+					'label'	=> __('Other Entries', 'gravityview'),
743
+					'type'	=> 'other_entries',
744
+					'desc'	=> __('Display other entries created by the entry creator.', 'gravityview'),
745
+				),
746
+			);
747 747
 
748 748
 			if( 'single' !== $zone) {
749 749
 
@@ -1084,59 +1084,59 @@  discard block
 block discarded – undo
1084 1084
 
1085 1085
 		// Don't process any scripts below here if it's not a GravityView page.
1086 1086
 		if( ! gravityview_is_admin_page( $hook, 'single' ) && ! $is_widgets_page ) {
1087
-		    return;
1087
+			return;
1088 1088
 		}
1089 1089
 
1090
-        wp_enqueue_script( 'jquery-ui-datepicker' );
1091
-        wp_enqueue_style( 'gravityview_views_datepicker', plugins_url('assets/css/admin-datepicker.css', GRAVITYVIEW_FILE), GravityView_Plugin::version );
1092
-
1093
-        $script_debug = (defined('SCRIPT_DEBUG') && SCRIPT_DEBUG) ? '' : '.min';
1094
-
1095
-        //enqueue scripts
1096
-        wp_enqueue_script( 'gravityview_views_scripts', plugins_url( 'assets/js/admin-views' . $script_debug . '.js', GRAVITYVIEW_FILE ), array( 'jquery-ui-tabs', 'jquery-ui-draggable', 'jquery-ui-droppable', 'jquery-ui-sortable', 'jquery-ui-tooltip', 'jquery-ui-dialog', 'gravityview-jquery-cookie', 'jquery-ui-datepicker', 'underscore' ), GravityView_Plugin::version );
1097
-
1098
-        wp_localize_script('gravityview_views_scripts', 'gvGlobals', array(
1099
-            'cookiepath' => COOKIEPATH,
1100
-            'passed_form_id' => (bool) \GV\Utils::_GET( 'form_id' ),
1101
-            'nonce' => wp_create_nonce( 'gravityview_ajaxviews' ),
1102
-            'label_viewname' => __( 'Enter View name here', 'gravityview' ),
1103
-            'label_close' => __( 'Close', 'gravityview' ),
1104
-            'label_cancel' => __( 'Cancel', 'gravityview' ),
1105
-            'label_continue' => __( 'Continue', 'gravityview' ),
1106
-            'label_ok' => __( 'Ok', 'gravityview' ),
1107
-            'label_publisherror' => __( 'Error while creating the View for you. Check the settings or contact GravityView support.', 'gravityview' ),
1108
-            'loading_text' => esc_html__( 'Loading&hellip;', 'gravityview' ),
1109
-            'loading_error' => esc_html__( 'There was an error loading dynamic content.', 'gravityview' ),
1110
-            'field_loaderror' => __( 'Error while adding the field. Please try again or contact GravityView support.', 'gravityview' ),
1111
-            'remove_all_fields' => __( 'Would you like to remove all fields in this zone? (You are seeing this message because you were holding down the ALT key)', 'gravityview' ),
1112
-        ));
1113
-
1114
-        wp_enqueue_style( 'gravityview_views_styles', plugins_url( 'assets/css/admin-views.css', GRAVITYVIEW_FILE ), array('dashicons', 'wp-jquery-ui-dialog' ), GravityView_Plugin::version );
1115
-
1116
-        // Enqueue scripts needed for merge tags
1117
-        self::enqueue_gravity_forms_scripts();
1090
+		wp_enqueue_script( 'jquery-ui-datepicker' );
1091
+		wp_enqueue_style( 'gravityview_views_datepicker', plugins_url('assets/css/admin-datepicker.css', GRAVITYVIEW_FILE), GravityView_Plugin::version );
1092
+
1093
+		$script_debug = (defined('SCRIPT_DEBUG') && SCRIPT_DEBUG) ? '' : '.min';
1094
+
1095
+		//enqueue scripts
1096
+		wp_enqueue_script( 'gravityview_views_scripts', plugins_url( 'assets/js/admin-views' . $script_debug . '.js', GRAVITYVIEW_FILE ), array( 'jquery-ui-tabs', 'jquery-ui-draggable', 'jquery-ui-droppable', 'jquery-ui-sortable', 'jquery-ui-tooltip', 'jquery-ui-dialog', 'gravityview-jquery-cookie', 'jquery-ui-datepicker', 'underscore' ), GravityView_Plugin::version );
1097
+
1098
+		wp_localize_script('gravityview_views_scripts', 'gvGlobals', array(
1099
+			'cookiepath' => COOKIEPATH,
1100
+			'passed_form_id' => (bool) \GV\Utils::_GET( 'form_id' ),
1101
+			'nonce' => wp_create_nonce( 'gravityview_ajaxviews' ),
1102
+			'label_viewname' => __( 'Enter View name here', 'gravityview' ),
1103
+			'label_close' => __( 'Close', 'gravityview' ),
1104
+			'label_cancel' => __( 'Cancel', 'gravityview' ),
1105
+			'label_continue' => __( 'Continue', 'gravityview' ),
1106
+			'label_ok' => __( 'Ok', 'gravityview' ),
1107
+			'label_publisherror' => __( 'Error while creating the View for you. Check the settings or contact GravityView support.', 'gravityview' ),
1108
+			'loading_text' => esc_html__( 'Loading&hellip;', 'gravityview' ),
1109
+			'loading_error' => esc_html__( 'There was an error loading dynamic content.', 'gravityview' ),
1110
+			'field_loaderror' => __( 'Error while adding the field. Please try again or contact GravityView support.', 'gravityview' ),
1111
+			'remove_all_fields' => __( 'Would you like to remove all fields in this zone? (You are seeing this message because you were holding down the ALT key)', 'gravityview' ),
1112
+		));
1113
+
1114
+		wp_enqueue_style( 'gravityview_views_styles', plugins_url( 'assets/css/admin-views.css', GRAVITYVIEW_FILE ), array('dashicons', 'wp-jquery-ui-dialog' ), GravityView_Plugin::version );
1115
+
1116
+		// Enqueue scripts needed for merge tags
1117
+		self::enqueue_gravity_forms_scripts();
1118 1118
 	}
1119 1119
 
1120 1120
 	/**
1121 1121
 	 * Enqueue Gravity Forms scripts, needed for Merge Tags
1122
-     *
1123
-     * @since 1.0.5-beta
1124
-     *
1125
-     * @return void
1122
+	 *
1123
+	 * @since 1.0.5-beta
1124
+	 *
1125
+	 * @return void
1126 1126
 	 */
1127 1127
 	static function enqueue_gravity_forms_scripts() {
1128 1128
 		GFForms::register_scripts();
1129 1129
 
1130 1130
 		$scripts = array(
1131
-		    'sack',
1132
-		    'gform_gravityforms',
1133
-		    'gform_forms',
1134
-		    'gform_form_admin',
1135
-		    'jquery-ui-autocomplete'
1131
+			'sack',
1132
+			'gform_gravityforms',
1133
+			'gform_forms',
1134
+			'gform_form_admin',
1135
+			'jquery-ui-autocomplete'
1136 1136
 		);
1137 1137
 
1138 1138
 		if ( wp_is_mobile() ) {
1139
-		    $scripts[] = 'jquery-touch-punch';
1139
+			$scripts[] = 'jquery-touch-punch';
1140 1140
 		}
1141 1141
 
1142 1142
 		wp_enqueue_script( $scripts );
Please login to merge, or discard this patch.
Spacing   +176 added lines, -176 removed lines patch added patch discarded remove patch
@@ -28,30 +28,30 @@  discard block
 block discarded – undo
28 28
 		add_filter( 'gravityview_blacklist_field_types', array( $this, 'default_field_blacklist' ), 10, 2 );
29 29
 
30 30
 		// Tooltips
31
-		add_filter( 'gform_tooltips', array( $this, 'tooltips') );
31
+		add_filter( 'gform_tooltips', array( $this, 'tooltips' ) );
32 32
 
33 33
 		// adding styles and scripts
34
-		add_action( 'admin_enqueue_scripts', array( 'GravityView_Admin_Views', 'add_scripts_and_styles'), 999 );
35
-		add_filter( 'gform_noconflict_styles', array( $this, 'register_no_conflict') );
36
-		add_filter( 'gform_noconflict_scripts', array( $this, 'register_no_conflict') );
37
-		add_filter( 'gravityview_noconflict_styles', array( $this, 'register_no_conflict') );
38
-		add_filter( 'gravityview_noconflict_scripts', array( $this, 'register_no_conflict') );
39
-
40
-		add_action( 'gravityview_render_directory_active_areas', array( $this, 'render_directory_active_areas'), 10, 4 );
41
-		add_action( 'gravityview_render_widgets_active_areas', array( $this, 'render_widgets_active_areas'), 10, 3 );
42
-		add_action( 'gravityview_render_available_fields', array( $this, 'render_available_fields'), 10, 2 );
43
-		add_action( 'gravityview_render_available_widgets', array( $this, 'render_available_widgets') );
44
-		add_action( 'gravityview_render_active_areas', array( $this, 'render_active_areas'), 10, 5 );
34
+		add_action( 'admin_enqueue_scripts', array( 'GravityView_Admin_Views', 'add_scripts_and_styles' ), 999 );
35
+		add_filter( 'gform_noconflict_styles', array( $this, 'register_no_conflict' ) );
36
+		add_filter( 'gform_noconflict_scripts', array( $this, 'register_no_conflict' ) );
37
+		add_filter( 'gravityview_noconflict_styles', array( $this, 'register_no_conflict' ) );
38
+		add_filter( 'gravityview_noconflict_scripts', array( $this, 'register_no_conflict' ) );
39
+
40
+		add_action( 'gravityview_render_directory_active_areas', array( $this, 'render_directory_active_areas' ), 10, 4 );
41
+		add_action( 'gravityview_render_widgets_active_areas', array( $this, 'render_widgets_active_areas' ), 10, 3 );
42
+		add_action( 'gravityview_render_available_fields', array( $this, 'render_available_fields' ), 10, 2 );
43
+		add_action( 'gravityview_render_available_widgets', array( $this, 'render_available_widgets' ) );
44
+		add_action( 'gravityview_render_active_areas', array( $this, 'render_active_areas' ), 10, 5 );
45 45
 
46 46
 		// @todo check if this hook is needed..
47 47
 		//add_action( 'gravityview_render_field_options', array( $this, 'render_field_options'), 10, 9 );
48 48
 
49 49
 		// Add Connected Form column
50
-		add_filter('manage_gravityview_posts_columns' , array( $this, 'add_post_type_columns' ) );
50
+		add_filter( 'manage_gravityview_posts_columns', array( $this, 'add_post_type_columns' ) );
51 51
 
52 52
 		add_filter( 'gform_toolbar_menu', array( 'GravityView_Admin_Views', 'gform_toolbar_menu' ), 10, 2 );
53 53
 
54
-		add_action( 'manage_gravityview_posts_custom_column', array( $this, 'add_custom_column_content'), 10, 2 );
54
+		add_action( 'manage_gravityview_posts_custom_column', array( $this, 'add_custom_column_content' ), 10, 2 );
55 55
 
56 56
 		add_action( 'restrict_manage_posts', array( $this, 'add_view_dropdown' ) );
57 57
 
@@ -70,11 +70,11 @@  discard block
 block discarded – undo
70 70
 	 */
71 71
 	function suggest_support_articles( $localization_data = array() ) {
72 72
 
73
-	    if( ! gravityview()->request->is_view() ) {
73
+	    if ( ! gravityview()->request->is_view() ) {
74 74
 	        return $localization_data;
75 75
         }
76 76
 
77
-		$localization_data['suggest'] = array(
77
+		$localization_data[ 'suggest' ] = array(
78 78
             '57ef23539033602e61d4a560',
79 79
             '54c67bb9e4b0512429885513',
80 80
             '54c67bb9e4b0512429885512',
@@ -95,13 +95,13 @@  discard block
 block discarded – undo
95 95
 	public function filter_pre_get_posts_by_gravityview_form_id( &$query ) {
96 96
 		global $pagenow;
97 97
 
98
-		if ( !is_admin() ) {
98
+		if ( ! is_admin() ) {
99 99
 			return;
100 100
 		}
101 101
 
102
-		$form_id = isset( $_GET['gravityview_form_id'] ) ? (int) $_GET['gravityview_form_id'] : false;
102
+		$form_id = isset( $_GET[ 'gravityview_form_id' ] ) ? (int)$_GET[ 'gravityview_form_id' ] : false;
103 103
 
104
-		if( 'edit.php' !== $pagenow || ! $form_id || ! isset( $query->query_vars[ 'post_type' ] ) ) {
104
+		if ( 'edit.php' !== $pagenow || ! $form_id || ! isset( $query->query_vars[ 'post_type' ] ) ) {
105 105
 			return;
106 106
 		}
107 107
 
@@ -118,18 +118,18 @@  discard block
 block discarded – undo
118 118
 	function add_view_dropdown() {
119 119
 		$current_screen = get_current_screen();
120 120
 
121
-		if( 'gravityview' !== $current_screen->post_type ) {
121
+		if ( 'gravityview' !== $current_screen->post_type ) {
122 122
 			return;
123 123
 		}
124 124
 
125 125
 		$forms = gravityview_get_forms();
126 126
 		$current_form = \GV\Utils::_GET( 'gravityview_form_id' );
127 127
 		// If there are no forms to select, show no forms.
128
-		if( !empty( $forms ) ) { ?>
128
+		if ( ! empty( $forms ) ) { ?>
129 129
 			<select name="gravityview_form_id" id="gravityview_form_id">
130 130
 				<option value="" <?php selected( '', $current_form, true ); ?>><?php esc_html_e( 'All forms', 'gravityview' ); ?></option>
131
-				<?php foreach( $forms as $form ) { ?>
132
-					<option value="<?php echo $form['id']; ?>" <?php selected( $form['id'], $current_form, true ); ?>><?php echo esc_html( $form['title'] ); ?></option>
131
+				<?php foreach ( $forms as $form ) { ?>
132
+					<option value="<?php echo $form[ 'id' ]; ?>" <?php selected( $form[ 'id' ], $current_form, true ); ?>><?php echo esc_html( $form[ 'title' ] ); ?></option>
133 133
 				<?php } ?>
134 134
 			</select>
135 135
 		<?php }
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
 	 */
143 143
 	public static function render_setting_row( $key = '', $current_settings = array(), $override_input = null, $name = 'template_settings[%s]', $id = 'gravityview_se_%s' ) {
144 144
 		_deprecated_function( 'GravityView_Admin_Views::render_setting_row', '1.1.7', 'GravityView_Render_Settings::render_setting_row' );
145
-		GravityView_Render_Settings::render_setting_row( $key, $current_settings, $override_input, $name , $id );
145
+		GravityView_Render_Settings::render_setting_row( $key, $current_settings, $override_input, $name, $id );
146 146
 	}
147 147
 
148 148
 	/**
@@ -165,9 +165,9 @@  discard block
 block discarded – undo
165 165
 
166 166
 		$connected_views = gravityview_get_connected_views( $id, array( 'post_status' => 'any' ) );
167 167
 
168
-		if( empty( $connected_views ) ) {
168
+		if ( empty( $connected_views ) ) {
169 169
 
170
-		    $menu_items['gravityview'] = array(
170
+		    $menu_items[ 'gravityview' ] = array(
171 171
 				'label'          => esc_attr__( 'Create a View', 'gravityview' ),
172 172
 				'icon'           => '<i class="fa fa-lg gv-icon-astronaut-head gv-icon"></i>',
173 173
 				'title'          => esc_attr__( 'Create a View using this form as a data source', 'gravityview' ),
@@ -183,22 +183,22 @@  discard block
 block discarded – undo
183 183
 		$sub_menu_items = array();
184 184
 		foreach ( (array)$connected_views as $view ) {
185 185
 
186
-			if( ! GVCommon::has_cap( 'edit_gravityview', $view->ID ) ) {
186
+			if ( ! GVCommon::has_cap( 'edit_gravityview', $view->ID ) ) {
187 187
 				continue;
188 188
 			}
189 189
 
190
-			$label = empty( $view->post_title ) ? sprintf( __('No Title (View #%d)', 'gravityview' ), $view->ID ) : $view->post_title;
190
+			$label = empty( $view->post_title ) ? sprintf( __( 'No Title (View #%d)', 'gravityview' ), $view->ID ) : $view->post_title;
191 191
 
192
-			$sub_menu_items[] = array(
192
+			$sub_menu_items[ ] = array(
193 193
 				'label' => esc_attr( $label ),
194
-				'url' => admin_url( 'post.php?action=edit&post='.$view->ID ),
194
+				'url' => admin_url( 'post.php?action=edit&post=' . $view->ID ),
195 195
 			);
196 196
 		}
197 197
 
198 198
 		// If there were no items added, then let's create the parent menu
199
-		if( $sub_menu_items ) {
199
+		if ( $sub_menu_items ) {
200 200
 
201
-		    $sub_menu_items[] = array(
201
+		    $sub_menu_items[ ] = array(
202 202
 			    'label' => esc_attr__( 'Create a View', 'gravityview' ),
203 203
                 'link_class' => 'gv-create-view',
204 204
 			    'title' => esc_attr__( 'Create a View using this form as a data source', 'gravityview' ),
@@ -207,14 +207,14 @@  discard block
 block discarded – undo
207 207
             );
208 208
 
209 209
 			// Make sure Gravity Forms uses the submenu; if there's only one item, it uses a link instead of a dropdown
210
-			$sub_menu_items[] = array(
210
+			$sub_menu_items[ ] = array(
211 211
 				'url' => '#',
212 212
 				'label' => '',
213 213
 				'menu_class' => 'hidden',
214 214
 				'capabilities' => '',
215 215
 			);
216 216
 
217
-			$menu_items['gravityview'] = array(
217
+			$menu_items[ 'gravityview' ] = array(
218 218
 				'label'          => __( 'Connected Views', 'gravityview' ),
219 219
 				'icon'           => '<i class="fa fa-lg gv-icon-astronaut-head gv-icon"></i>',
220 220
 				'title'          => __( 'GravityView Views using this form as a data source', 'gravityview' ),
@@ -243,8 +243,8 @@  discard block
 block discarded – undo
243 243
 		$add = array( 'captcha', 'page' );
244 244
 
245 245
 		// Don't allowing editing the following values:
246
-		if( $context === 'edit' ) {
247
-			$add[] = 'post_id';
246
+		if ( $context === 'edit' ) {
247
+			$add[ ] = 'post_id';
248 248
 		}
249 249
 
250 250
 		$return = array_merge( $array, $add );
@@ -267,32 +267,32 @@  discard block
 block discarded – undo
267 267
 		foreach ( $default_args as $key => $arg ) {
268 268
 
269 269
 			// If an arg has `tooltip` defined, but it's false, don't display a tooltip
270
-			if( isset( $arg['tooltip'] ) && empty( $arg['tooltip'] ) ) { continue; }
270
+			if ( isset( $arg[ 'tooltip' ] ) && empty( $arg[ 'tooltip' ] ) ) { continue; }
271 271
 
272 272
 			// By default, use `tooltip` if defined.
273
-			$tooltip = empty( $arg['tooltip'] ) ? NULL : $arg['tooltip'];
273
+			$tooltip = empty( $arg[ 'tooltip' ] ) ? NULL : $arg[ 'tooltip' ];
274 274
 
275 275
 			// Otherwise, use the description as a tooltip.
276
-			if( empty( $tooltip ) && !empty( $arg['desc'] ) ) {
277
-				$tooltip = $arg['desc'];
276
+			if ( empty( $tooltip ) && ! empty( $arg[ 'desc' ] ) ) {
277
+				$tooltip = $arg[ 'desc' ];
278 278
 			}
279 279
 
280 280
 			// If there's no tooltip set, continue
281
-			if( empty( $tooltip ) ) {
281
+			if ( empty( $tooltip ) ) {
282 282
 				continue;
283 283
 			}
284 284
 
285 285
 			// Add the tooltip
286
-			$gv_tooltips[ 'gv_'.$key ] = array(
287
-				'title'	=> $arg['label'],
286
+			$gv_tooltips[ 'gv_' . $key ] = array(
287
+				'title'	=> $arg[ 'label' ],
288 288
 				'value'	=> $tooltip,
289 289
 			);
290 290
 
291 291
 		}
292 292
 
293
-		$gv_tooltips['gv_css_merge_tags'] = array(
294
-			'title' => __('CSS Merge Tags', 'gravityview'),
295
-			'value' => sprintf( __( 'Developers: The CSS classes will be sanitized using the %ssanitize_title_with_dashes()%s function.', 'gravityview'), '<code>', '</code>' )
293
+		$gv_tooltips[ 'gv_css_merge_tags' ] = array(
294
+			'title' => __( 'CSS Merge Tags', 'gravityview' ),
295
+			'value' => sprintf( __( 'Developers: The CSS classes will be sanitized using the %ssanitize_title_with_dashes()%s function.', 'gravityview' ), '<code>', '</code>' )
296 296
 		);
297 297
 
298 298
 		/**
@@ -310,9 +310,9 @@  discard block
 block discarded – undo
310 310
 
311 311
 		foreach ( $gv_tooltips as $key => $tooltip ) {
312 312
 
313
-			$title = empty( $tooltip['title'] ) ? '' : '<h6>'.esc_html( $tooltip['title'] ) .'</h6>';
313
+			$title = empty( $tooltip[ 'title' ] ) ? '' : '<h6>' . esc_html( $tooltip[ 'title' ] ) . '</h6>';
314 314
 
315
-			$tooltips[ $key ] = $title . wpautop( esc_html( $tooltip['value'] ) );
315
+			$tooltips[ $key ] = $title . wpautop( esc_html( $tooltip[ 'value' ] ) );
316 316
 		}
317 317
 
318 318
 		return $tooltips;
@@ -326,7 +326,7 @@  discard block
 block discarded – undo
326 326
 	 *
327 327
 	 * @return void
328 328
 	 */
329
-	public function add_custom_column_content( $column_name = NULL, $post_id )	{
329
+	public function add_custom_column_content( $column_name = NULL, $post_id ) {
330 330
 
331 331
 		$output = '';
332 332
 
@@ -348,7 +348,7 @@  discard block
 block discarded – undo
348 348
 				// Generate backup if label doesn't exist: `example_name` => `Example Name`
349 349
 				$template_id_pretty = ucwords( implode( ' ', explode( '_', $template_id ) ) );
350 350
 
351
-				$output = $template ? $template['label'] : $template_id_pretty;
351
+				$output = $template ? $template[ 'label' ] : $template_id_pretty;
352 352
 
353 353
 				break;
354 354
 
@@ -389,44 +389,44 @@  discard block
 block discarded – undo
389 389
 	static public function get_connected_form_links( $form, $include_form_link = true ) {
390 390
 
391 391
 		// Either the form is empty or the form ID is 0, not yet set.
392
-		if( empty( $form ) ) {
392
+		if ( empty( $form ) ) {
393 393
 			return '';
394 394
 		}
395 395
 
396 396
 		// The $form is passed as the form ID
397
-		if( !is_array( $form ) ) {
397
+		if ( ! is_array( $form ) ) {
398 398
 			$form = gravityview_get_form( $form );
399 399
 		}
400 400
 
401
-		$form_id = $form['id'];
401
+		$form_id = $form[ 'id' ];
402 402
 		$links = array();
403 403
 
404
-		if( GVCommon::has_cap( 'gravityforms_edit_forms' ) ) {
404
+		if ( GVCommon::has_cap( 'gravityforms_edit_forms' ) ) {
405 405
 			$form_url = admin_url( sprintf( 'admin.php?page=gf_edit_forms&amp;id=%d', $form_id ) );
406
-			$form_link = '<strong class="gv-form-title">'.gravityview_get_link( $form_url, $form['title'], 'class=row-title' ).'</strong>';
407
-			$links[] = '<span>'.gravityview_get_link( $form_url, __('Edit Form', 'gravityview') ).'</span>';
406
+			$form_link = '<strong class="gv-form-title">' . gravityview_get_link( $form_url, $form[ 'title' ], 'class=row-title' ) . '</strong>';
407
+			$links[ ] = '<span>' . gravityview_get_link( $form_url, __( 'Edit Form', 'gravityview' ) ) . '</span>';
408 408
 		} else {
409
-			$form_link = '<strong class="gv-form-title">'. esc_html( $form['title'] ). '</strong>';
409
+			$form_link = '<strong class="gv-form-title">' . esc_html( $form[ 'title' ] ) . '</strong>';
410 410
 		}
411 411
 
412
-		if( GVCommon::has_cap( 'gravityforms_view_entries' ) ) {
412
+		if ( GVCommon::has_cap( 'gravityforms_view_entries' ) ) {
413 413
 			$entries_url = admin_url( sprintf( 'admin.php?page=gf_entries&amp;id=%d', $form_id ) );
414
-			$links[] = '<span>'.gravityview_get_link( $entries_url, __('Entries', 'gravityview') ).'</span>';
414
+			$links[ ] = '<span>' . gravityview_get_link( $entries_url, __( 'Entries', 'gravityview' ) ) . '</span>';
415 415
 		}
416 416
 
417
-		if( GVCommon::has_cap( array( 'gravityforms_edit_settings', 'gravityview_view_settings' ) ) ) {
417
+		if ( GVCommon::has_cap( array( 'gravityforms_edit_settings', 'gravityview_view_settings' ) ) ) {
418 418
 			$settings_url = admin_url( sprintf( 'admin.php?page=gf_edit_forms&amp;view=settings&amp;id=%d', $form_id ) );
419
-			$links[] = '<span>'.gravityview_get_link( $settings_url, __('Settings', 'gravityview'), 'title='.__('Edit settings for this form', 'gravityview') ).'</span>';
419
+			$links[ ] = '<span>' . gravityview_get_link( $settings_url, __( 'Settings', 'gravityview' ), 'title=' . __( 'Edit settings for this form', 'gravityview' ) ) . '</span>';
420 420
 		}
421 421
 
422
-		if( GVCommon::has_cap( array("gravityforms_edit_forms", "gravityforms_create_form", "gravityforms_preview_forms") ) ) {
422
+		if ( GVCommon::has_cap( array( "gravityforms_edit_forms", "gravityforms_create_form", "gravityforms_preview_forms" ) ) ) {
423 423
 			$preview_url = site_url( sprintf( '?gf_page=preview&amp;id=%d', $form_id ) );
424
-			$links[] = '<span>'.gravityview_get_link( $preview_url, __('Preview Form', 'gravityview'), 'title='.__('Preview this form', 'gravityview') ).'</span>';
424
+			$links[ ] = '<span>' . gravityview_get_link( $preview_url, __( 'Preview Form', 'gravityview' ), 'title=' . __( 'Preview this form', 'gravityview' ) ) . '</span>';
425 425
 		}
426 426
 
427 427
 		$output = '';
428 428
 
429
-		if( !empty( $include_form_link ) ) {
429
+		if ( ! empty( $include_form_link ) ) {
430 430
 			$output .= $form_link;
431 431
 		}
432 432
 
@@ -438,7 +438,7 @@  discard block
 block discarded – undo
438 438
 		 */
439 439
 		$links = apply_filters( 'gravityview_connected_form_links', $links, $form );
440 440
 
441
-		$output .= '<div class="row-actions">'. implode( ' | ', $links ) .'</div>';
441
+		$output .= '<div class="row-actions">' . implode( ' | ', $links ) . '</div>';
442 442
 
443 443
 		return $output;
444 444
 	}
@@ -452,8 +452,8 @@  discard block
 block discarded – undo
452 452
 		// Get the date column and save it for later to add back in.
453 453
 		// This adds it after the Data Source column.
454 454
 		// This way, we don't need to do array_slice, array_merge, etc.
455
-		$date = $columns['date'];
456
-		unset( $columns['date'] );
455
+		$date = $columns[ 'date' ];
456
+		unset( $columns[ 'date' ] );
457 457
 
458 458
 		$data_source_required_caps = array(
459 459
 			'gravityforms_edit_forms',
@@ -464,14 +464,14 @@  discard block
 block discarded – undo
464 464
 			'gravityforms_preview_forms',
465 465
 		);
466 466
 
467
-		if( GVCommon::has_cap( $data_source_required_caps ) ) {
468
-			$columns['gv_connected_form'] = __( 'Data Source', 'gravityview' );
467
+		if ( GVCommon::has_cap( $data_source_required_caps ) ) {
468
+			$columns[ 'gv_connected_form' ] = __( 'Data Source', 'gravityview' );
469 469
 		}
470 470
 
471
-		$columns['gv_template'] = _x( 'Template', 'Column title that shows what template is being used for Views', 'gravityview' );
471
+		$columns[ 'gv_template' ] = _x( 'Template', 'Column title that shows what template is being used for Views', 'gravityview' );
472 472
 
473 473
 		// Add the date back in.
474
-		$columns['date'] = $date;
474
+		$columns[ 'date' ] = $date;
475 475
 
476 476
 		return $columns;
477 477
 	}
@@ -485,12 +485,12 @@  discard block
 block discarded – undo
485 485
 	 */
486 486
 	function save_postdata( $post_id ) {
487 487
 
488
-		if( defined( 'DOING_AUTOSAVE' ) && DOING_AUTOSAVE ){
488
+		if ( defined( 'DOING_AUTOSAVE' ) && DOING_AUTOSAVE ) {
489 489
 			return;
490 490
 		}
491 491
 
492 492
 		// validate post_type
493
-		if ( ! isset( $_POST['post_type'] ) || 'gravityview' != $_POST['post_type'] ) {
493
+		if ( ! isset( $_POST[ 'post_type' ] ) || 'gravityview' != $_POST[ 'post_type' ] ) {
494 494
 			return;
495 495
 		}
496 496
 
@@ -505,63 +505,63 @@  discard block
 block discarded – undo
505 505
 		$statii = array();
506 506
 
507 507
 		// check if this is a start fresh View
508
-		if ( isset( $_POST['gravityview_select_form_nonce'] ) && wp_verify_nonce( $_POST['gravityview_select_form_nonce'], 'gravityview_select_form' ) ) {
508
+		if ( isset( $_POST[ 'gravityview_select_form_nonce' ] ) && wp_verify_nonce( $_POST[ 'gravityview_select_form_nonce' ], 'gravityview_select_form' ) ) {
509 509
 
510
-			$form_id = !empty( $_POST['gravityview_form_id'] ) ? $_POST['gravityview_form_id'] : '';
510
+			$form_id = ! empty( $_POST[ 'gravityview_form_id' ] ) ? $_POST[ 'gravityview_form_id' ] : '';
511 511
 			// save form id
512
-			$statii['form_id'] = update_post_meta( $post_id, '_gravityview_form_id', $form_id );
512
+			$statii[ 'form_id' ] = update_post_meta( $post_id, '_gravityview_form_id', $form_id );
513 513
 
514 514
 		}
515 515
 
516
-		if( false === GVCommon::has_cap( 'gravityforms_create_form' ) && empty( $statii['form_id'] ) ) {
516
+		if ( false === GVCommon::has_cap( 'gravityforms_create_form' ) && empty( $statii[ 'form_id' ] ) ) {
517 517
 			gravityview()->log->error( 'Current user does not have the capability to create a new Form.', array( 'data' => wp_get_current_user() ) );
518 518
 			return;
519 519
 		}
520 520
 
521 521
 		// Was this a start fresh?
522
-		if ( ! empty( $_POST['gravityview_form_id_start_fresh'] ) ) {
523
-			$statii['start_fresh'] = add_post_meta( $post_id, '_gravityview_start_fresh', 1 );
522
+		if ( ! empty( $_POST[ 'gravityview_form_id_start_fresh' ] ) ) {
523
+			$statii[ 'start_fresh' ] = add_post_meta( $post_id, '_gravityview_start_fresh', 1 );
524 524
 		} else {
525
-			$statii['start_fresh'] = delete_post_meta( $post_id, '_gravityview_start_fresh' );
525
+			$statii[ 'start_fresh' ] = delete_post_meta( $post_id, '_gravityview_start_fresh' );
526 526
 		}
527 527
 
528 528
 		// Check if we have a template id
529
-		if ( isset( $_POST['gravityview_select_template_nonce'] ) && wp_verify_nonce( $_POST['gravityview_select_template_nonce'], 'gravityview_select_template' ) ) {
529
+		if ( isset( $_POST[ 'gravityview_select_template_nonce' ] ) && wp_verify_nonce( $_POST[ 'gravityview_select_template_nonce' ], 'gravityview_select_template' ) ) {
530 530
 
531
-			$template_id = !empty( $_POST['gravityview_directory_template'] ) ? $_POST['gravityview_directory_template'] : '';
531
+			$template_id = ! empty( $_POST[ 'gravityview_directory_template' ] ) ? $_POST[ 'gravityview_directory_template' ] : '';
532 532
 
533 533
 			// now save template id
534
-			$statii['directory_template'] = update_post_meta( $post_id, '_gravityview_directory_template', $template_id );
534
+			$statii[ 'directory_template' ] = update_post_meta( $post_id, '_gravityview_directory_template', $template_id );
535 535
 		}
536 536
 
537 537
 
538 538
 		// save View Configuration metabox
539
-		if ( isset( $_POST['gravityview_view_configuration_nonce'] ) && wp_verify_nonce( $_POST['gravityview_view_configuration_nonce'], 'gravityview_view_configuration' ) ) {
539
+		if ( isset( $_POST[ 'gravityview_view_configuration_nonce' ] ) && wp_verify_nonce( $_POST[ 'gravityview_view_configuration_nonce' ], 'gravityview_view_configuration' ) ) {
540 540
 
541 541
 			// template settings
542
-			if( empty( $_POST['template_settings'] ) ) {
543
-				$_POST['template_settings'] = array();
542
+			if ( empty( $_POST[ 'template_settings' ] ) ) {
543
+				$_POST[ 'template_settings' ] = array();
544 544
 			}
545
-			$statii['template_settings'] = update_post_meta( $post_id, '_gravityview_template_settings', $_POST['template_settings'] );
545
+			$statii[ 'template_settings' ] = update_post_meta( $post_id, '_gravityview_template_settings', $_POST[ 'template_settings' ] );
546 546
 
547 547
 			$fields = array();
548 548
 
549 549
 			// Directory&single Visible Fields
550
-			if( !empty( $preset_fields ) ) {
550
+			if ( ! empty( $preset_fields ) ) {
551 551
 
552 552
 				$fields = $preset_fields;
553 553
 
554
-			} elseif( !empty( $_POST['gv_fields'] ) ) {
554
+			} elseif ( ! empty( $_POST[ 'gv_fields' ] ) ) {
555 555
 				$fields = _gravityview_process_posted_fields();
556 556
 			}
557 557
 
558
-			$statii['directory_fields'] = update_post_meta( $post_id, '_gravityview_directory_fields', $fields );
558
+			$statii[ 'directory_fields' ] = update_post_meta( $post_id, '_gravityview_directory_fields', $fields );
559 559
 
560 560
 			// Directory Visible Widgets
561
-			if( empty( $_POST['widgets'] ) ) {
562
-				$_POST['widgets'] = array();
561
+			if ( empty( $_POST[ 'widgets' ] ) ) {
562
+				$_POST[ 'widgets' ] = array();
563 563
 			}
564
-			$statii['directory_widgets'] = gravityview_set_directory_widgets( $post_id, $_POST['widgets'] );
564
+			$statii[ 'directory_widgets' ] = gravityview_set_directory_widgets( $post_id, $_POST[ 'widgets' ] );
565 565
 
566 566
 		} // end save view configuration
567 567
 
@@ -571,7 +571,7 @@  discard block
 block discarded – undo
571 571
 		 * @param array $statii Array of statuses of the post meta saving processes. If saving worked, each key should be mapped to a value of the post ID (`directory_widgets` => `124`). If failed (or didn't change), the value will be false.
572 572
 		 * @since 1.17.2
573 573
 		 */
574
-		do_action('gravityview_view_saved', $post_id, $statii );
574
+		do_action( 'gravityview_view_saved', $post_id, $statii );
575 575
 
576 576
 		gravityview()->log->debug( '[save_postdata] Update Post Meta Statuses (also returns false if nothing changed)', array( 'data' => array_map( 'intval', $statii ) ) );
577 577
 	}
@@ -615,20 +615,20 @@  discard block
 block discarded – undo
615 615
 
616 616
 		$output = '';
617 617
 
618
-		if( !empty( $fields ) ) {
618
+		if ( ! empty( $fields ) ) {
619 619
 
620
-			foreach( $fields as $id => $details ) {
620
+			foreach ( $fields as $id => $details ) {
621 621
 
622
-				if( in_array( $details['type'], (array) $blacklist_field_types ) ) {
622
+				if ( in_array( $details[ 'type' ], (array)$blacklist_field_types ) ) {
623 623
 					continue;
624 624
 				}
625 625
 
626 626
 				// Edit mode only allows editing the parent fields, not single inputs.
627
-				if( $context === 'edit' && !empty( $details['parent'] ) ) {
627
+				if ( $context === 'edit' && ! empty( $details[ 'parent' ] ) ) {
628 628
 					continue;
629 629
 				}
630 630
 
631
-				$output .= new GravityView_Admin_View_Field( $details['label'], $id, $details );
631
+				$output .= new GravityView_Admin_View_Field( $details[ 'label' ], $id, $details );
632 632
 
633 633
 			} // End foreach
634 634
 		}
@@ -636,7 +636,7 @@  discard block
 block discarded – undo
636 636
 		echo $output;
637 637
 
638 638
 		// For the EDIT view we only want to allow the form fields.
639
-		if( $context === 'edit' ) {
639
+		if ( $context === 'edit' ) {
640 640
 			return;
641 641
 		}
642 642
 
@@ -660,16 +660,16 @@  discard block
 block discarded – undo
660 660
 		$additional_fields = apply_filters( 'gravityview_additional_fields', array(
661 661
 			array(
662 662
 				'label_text' => __( '+ Add All Fields', 'gravityview' ),
663
-				'desc' => __('Add all the available fields at once.', 'gravityview'),
663
+				'desc' => __( 'Add all the available fields at once.', 'gravityview' ),
664 664
 				'field_id' => 'all-fields',
665 665
 				'label_type' => 'field',
666 666
 				'input_type' => NULL,
667 667
 				'field_options' => NULL,
668 668
 				'settings_html'	=> NULL,
669 669
 			)
670
-		));
670
+		) );
671 671
 
672
-		if( !empty( $additional_fields )) {
672
+		if ( ! empty( $additional_fields ) ) {
673 673
 			foreach ( (array)$additional_fields as $item ) {
674 674
 
675 675
 				// Prevent items from not having index set
@@ -680,16 +680,16 @@  discard block
 block discarded – undo
680 680
 					'input_type' => NULL,
681 681
 					'field_options' => NULL,
682 682
 					'settings_html'	=> NULL,
683
-				));
683
+				) );
684 684
 
685 685
 				// Backward compat.
686
-				if( !empty( $item['field_options'] ) ) {
686
+				if ( ! empty( $item[ 'field_options' ] ) ) {
687 687
 					// Use settings_html from now on.
688
-					$item['settings_html'] = $item['field_options'];
688
+					$item[ 'settings_html' ] = $item[ 'field_options' ];
689 689
 				}
690 690
 
691 691
 				// Render a label for each of them
692
-				echo new GravityView_Admin_View_Field( $item['label_text'], $item['field_id'], $item );
692
+				echo new GravityView_Admin_View_Field( $item[ 'label_text' ], $item[ 'field_id' ], $item );
693 693
 
694 694
 			}
695 695
 		}
@@ -702,54 +702,54 @@  discard block
 block discarded – undo
702 702
 	 * @param  string $zone   Either 'single', 'directory', 'header', 'footer'
703 703
 	 * @return array
704 704
 	 */
705
-	function get_entry_default_fields($form, $zone) {
705
+	function get_entry_default_fields( $form, $zone ) {
706 706
 
707 707
 		$entry_default_fields = array();
708 708
 
709
-		if( in_array( $zone, array( 'directory', 'single' ) ) ) {
709
+		if ( in_array( $zone, array( 'directory', 'single' ) ) ) {
710 710
 
711 711
 			$entry_default_fields = array(
712 712
 				'id' => array(
713
-					'label' => __('Entry ID', 'gravityview'),
713
+					'label' => __( 'Entry ID', 'gravityview' ),
714 714
 					'type' => 'id',
715
-					'desc'	=> __('The unique ID of the entry.', 'gravityview'),
715
+					'desc'	=> __( 'The unique ID of the entry.', 'gravityview' ),
716 716
 				),
717 717
 				'date_created' => array(
718
-					'label' => __('Entry Date', 'gravityview'),
719
-					'desc'	=> __('The date the entry was created.', 'gravityview'),
718
+					'label' => __( 'Entry Date', 'gravityview' ),
719
+					'desc'	=> __( 'The date the entry was created.', 'gravityview' ),
720 720
 					'type' => 'date_created',
721 721
 				),
722 722
 				'source_url' => array(
723
-					'label' => __('Source URL', 'gravityview'),
723
+					'label' => __( 'Source URL', 'gravityview' ),
724 724
 					'type' => 'source_url',
725
-					'desc'	=> __('The URL of the page where the form was submitted.', 'gravityview'),
725
+					'desc'	=> __( 'The URL of the page where the form was submitted.', 'gravityview' ),
726 726
 				),
727 727
 				'ip' => array(
728
-					'label' => __('User IP', 'gravityview'),
728
+					'label' => __( 'User IP', 'gravityview' ),
729 729
 					'type' => 'ip',
730
-					'desc'	=> __('The IP Address of the user who created the entry.', 'gravityview'),
730
+					'desc'	=> __( 'The IP Address of the user who created the entry.', 'gravityview' ),
731 731
 				),
732 732
 				'created_by' => array(
733
-					'label' => __('User', 'gravityview'),
733
+					'label' => __( 'User', 'gravityview' ),
734 734
 					'type' => 'created_by',
735
-					'desc'	=> __('Details of the logged-in user who created the entry (if any).', 'gravityview'),
735
+					'desc'	=> __( 'Details of the logged-in user who created the entry (if any).', 'gravityview' ),
736 736
 				),
737 737
 
738 738
 				/**
739 739
 				 * @since 1.7.2
740 740
 				 */
741 741
 			    'other_entries' => array(
742
-				    'label'	=> __('Other Entries', 'gravityview'),
742
+				    'label'	=> __( 'Other Entries', 'gravityview' ),
743 743
 				    'type'	=> 'other_entries',
744
-				    'desc'	=> __('Display other entries created by the entry creator.', 'gravityview'),
744
+				    'desc'	=> __( 'Display other entries created by the entry creator.', 'gravityview' ),
745 745
 			    ),
746 746
 	        );
747 747
 
748
-			if( 'single' !== $zone) {
748
+			if ( 'single' !== $zone ) {
749 749
 
750
-				$entry_default_fields['entry_link'] = array(
751
-					'label' => __('Link to Entry', 'gravityview'),
752
-					'desc'	=> __('A dedicated link to the single entry with customizable text.', 'gravityview'),
750
+				$entry_default_fields[ 'entry_link' ] = array(
751
+					'label' => __( 'Link to Entry', 'gravityview' ),
752
+					'desc'	=> __( 'A dedicated link to the single entry with customizable text.', 'gravityview' ),
753 753
 					'type' => 'entry_link',
754 754
 				);
755 755
 			}
@@ -759,10 +759,10 @@  discard block
 block discarded – undo
759 759
 		/**
760 760
 		 * @since  1.2
761 761
 		 */
762
-		$entry_default_fields['custom']	= array(
763
-			'label'	=> __('Custom Content', 'gravityview'),
762
+		$entry_default_fields[ 'custom' ] = array(
763
+			'label'	=> __( 'Custom Content', 'gravityview' ),
764 764
 			'type'	=> 'custom',
765
-			'desc'	=> __('Insert custom text or HTML.', 'gravityview'),
765
+			'desc'	=> __( 'Insert custom text or HTML.', 'gravityview' ),
766 766
 		);
767 767
 
768 768
 		/**
@@ -771,7 +771,7 @@  discard block
 block discarded – undo
771 771
 		 * @param  string|array $form form_ID or form object
772 772
 		 * @param  string $zone   Either 'single', 'directory', 'header', 'footer'
773 773
 		 */
774
-		return apply_filters( 'gravityview_entry_default_fields', $entry_default_fields, $form, $zone);
774
+		return apply_filters( 'gravityview_entry_default_fields', $entry_default_fields, $form, $zone );
775 775
 	}
776 776
 
777 777
 	/**
@@ -782,7 +782,7 @@  discard block
 block discarded – undo
782 782
 	 */
783 783
 	function get_available_fields( $form = '', $zone = NULL ) {
784 784
 
785
-		if( empty( $form ) ) {
785
+		if ( empty( $form ) ) {
786 786
 			gravityview()->log->error( '$form is empty' );
787 787
 			return array();
788 788
 		}
@@ -791,7 +791,7 @@  discard block
 block discarded – undo
791 791
 		$fields = gravityview_get_form_fields( $form, true );
792 792
 
793 793
 		// get meta fields ( only if form was already created )
794
-		if( !is_array( $form ) ) {
794
+		if ( ! is_array( $form ) ) {
795 795
 			$meta_fields = gravityview_get_entry_meta( $form );
796 796
 		} else {
797 797
 			$meta_fields = array();
@@ -804,7 +804,7 @@  discard block
 block discarded – undo
804 804
 		$fields = $fields + $meta_fields + $default_fields;
805 805
 
806 806
 		// Move Custom Content to top
807
-		$fields = array( 'custom' => $fields['custom'] ) + $fields;
807
+		$fields = array( 'custom' => $fields[ 'custom' ] ) + $fields;
808 808
 
809 809
 		return $fields;
810 810
 	}
@@ -818,11 +818,11 @@  discard block
 block discarded – undo
818 818
 
819 819
 		$widgets = $this->get_registered_widgets();
820 820
 
821
-		if( !empty( $widgets ) ) {
821
+		if ( ! empty( $widgets ) ) {
822 822
 
823
-			foreach( $widgets as $id => $details ) {
823
+			foreach ( $widgets as $id => $details ) {
824 824
 
825
-				echo new GravityView_Admin_View_Widget( $details['label'], $id, $details );
825
+				echo new GravityView_Admin_View_Widget( $details[ 'label' ], $id, $details );
826 826
 
827 827
 			}
828 828
 		}
@@ -851,7 +851,7 @@  discard block
 block discarded – undo
851 851
 	function render_active_areas( $template_id, $type, $zone, $rows, $values ) {
852 852
 		global $post;
853 853
 
854
-		if( $type === 'widget' ) {
854
+		if ( $type === 'widget' ) {
855 855
 			$button_label = __( 'Add Widget', 'gravityview' );
856 856
 		} else {
857 857
 			$button_label = __( 'Add Field', 'gravityview' );
@@ -862,15 +862,15 @@  discard block
 block discarded – undo
862 862
 		$view = \GV\View::from_post( $post );
863 863
 
864 864
 		// if saved values, get available fields to label everyone
865
-		if( !empty( $values ) && ( !empty( $post->ID ) || !empty( $_POST['template_id'] ) ) ) {
865
+		if ( ! empty( $values ) && ( ! empty( $post->ID ) || ! empty( $_POST[ 'template_id' ] ) ) ) {
866 866
 
867
-			if( !empty( $_POST['template_id'] ) ) {
868
-				$form = GravityView_Ajax::pre_get_form_fields( $_POST['template_id'] );
867
+			if ( ! empty( $_POST[ 'template_id' ] ) ) {
868
+				$form = GravityView_Ajax::pre_get_form_fields( $_POST[ 'template_id' ] );
869 869
 			} else {
870 870
 				$form = gravityview_get_form_id( $post->ID );
871 871
 			}
872 872
 
873
-			if( 'field' === $type ) {
873
+			if ( 'field' === $type ) {
874 874
 				$available_items = $this->get_available_fields( $form, $zone );
875 875
 			} else {
876 876
 				$available_items = $this->get_registered_widgets();
@@ -878,42 +878,42 @@  discard block
 block discarded – undo
878 878
 
879 879
 		}
880 880
 
881
-		foreach( $rows as $row ) :
882
-			foreach( $row as $col => $areas ) :
883
-				$column = ($col == '2-2') ? '1-2' : $col; ?>
881
+		foreach ( $rows as $row ) :
882
+			foreach ( $row as $col => $areas ) :
883
+				$column = ( $col == '2-2' ) ? '1-2' : $col; ?>
884 884
 
885 885
 				<div class="gv-grid-col-<?php echo esc_attr( $column ); ?>">
886 886
 
887
-					<?php foreach( $areas as $area ) : 	?>
887
+					<?php foreach ( $areas as $area ) : 	?>
888 888
 
889 889
 						<div class="gv-droppable-area">
890
-							<div class="active-drop active-drop-<?php echo esc_attr( $type ); ?>" data-areaid="<?php echo esc_attr( $zone .'_'. $area['areaid'] ); ?>">
890
+							<div class="active-drop active-drop-<?php echo esc_attr( $type ); ?>" data-areaid="<?php echo esc_attr( $zone . '_' . $area[ 'areaid' ] ); ?>">
891 891
 
892 892
 								<?php // render saved fields
893 893
 
894
-								if( !empty( $values[ $zone .'_'. $area['areaid'] ] ) ) {
894
+								if ( ! empty( $values[ $zone . '_' . $area[ 'areaid' ] ] ) ) {
895 895
 
896
-									foreach( $values[ $zone .'_'. $area['areaid'] ] as $uniqid => $field ) {
896
+									foreach ( $values[ $zone . '_' . $area[ 'areaid' ] ] as $uniqid => $field ) {
897 897
 
898 898
 										$input_type = NULL;
899
-										$original_item = isset( $available_items[ $field['id'] ] ) ? $available_items[ $field['id'] ] : false ;
899
+										$original_item = isset( $available_items[ $field[ 'id' ] ] ) ? $available_items[ $field[ 'id' ] ] : false;
900 900
 
901
-										if( !$original_item ) {
901
+										if ( ! $original_item ) {
902 902
 
903
-											gravityview()->log->error( 'An item was not available when rendering the output; maybe it was added by a plugin that is now de-activated.', array(' data' => array('available_items' => $available_items, 'field' => $field ) ) );
903
+											gravityview()->log->error( 'An item was not available when rendering the output; maybe it was added by a plugin that is now de-activated.', array( ' data' => array( 'available_items' => $available_items, 'field' => $field ) ) );
904 904
 
905 905
 											$original_item = $field;
906 906
 										} else {
907 907
 
908
-											$input_type = isset( $original_item['type'] ) ? $original_item['type'] : NULL;
908
+											$input_type = isset( $original_item[ 'type' ] ) ? $original_item[ 'type' ] : NULL;
909 909
 
910 910
 										}
911 911
 
912 912
 										// Maybe has a form ID
913
-										$form_id = empty( $field['form_id'] ) ? null : $field['form_id'];
913
+										$form_id = empty( $field[ 'form_id' ] ) ? null : $field[ 'form_id' ];
914 914
 
915 915
 										// Field options dialog box
916
-										$field_options = GravityView_Render_Settings::render_field_options( $form_id, $type, $template_id, $field['id'], $original_item['label'], $zone .'_'. $area['areaid'], $input_type, $uniqid, $field, $zone, $original_item );
916
+										$field_options = GravityView_Render_Settings::render_field_options( $form_id, $type, $template_id, $field[ 'id' ], $original_item[ 'label' ], $zone . '_' . $area[ 'areaid' ], $input_type, $uniqid, $field, $zone, $original_item );
917 917
 
918 918
 										$item = array(
919 919
 											'input_type' => $input_type,
@@ -922,16 +922,16 @@  discard block
 block discarded – undo
922 922
 										);
923 923
 
924 924
 										// Merge the values with the current item to pass things like widget descriptions and original field names
925
-										if( $original_item ) {
925
+										if ( $original_item ) {
926 926
 											$item = wp_parse_args( $item, $original_item );
927 927
 										}
928 928
 
929
-										switch( $type ) {
929
+										switch ( $type ) {
930 930
 											case 'widget':
931
-												echo new GravityView_Admin_View_Widget( $item['label'], $field['id'], $item, $field );
931
+												echo new GravityView_Admin_View_Widget( $item[ 'label' ], $field[ 'id' ], $item, $field );
932 932
 												break;
933 933
 											default:
934
-												echo new GravityView_Admin_View_Field( $item['label'], $field['id'], $item, $field );
934
+												echo new GravityView_Admin_View_Field( $item[ 'label' ], $field[ 'id' ], $item, $field );
935 935
 										}
936 936
 
937 937
 
@@ -941,12 +941,12 @@  discard block
 block discarded – undo
941 941
 
942 942
 								} // End if zone is not empty ?>
943 943
 
944
-								<span class="drop-message"><?php echo sprintf(esc_attr__('"+ %s" or drag existing %ss here.', 'gravityview'), $button_label, $type ); ?></span>
944
+								<span class="drop-message"><?php echo sprintf( esc_attr__( '"+ %s" or drag existing %ss here.', 'gravityview' ), $button_label, $type ); ?></span>
945 945
 							</div>
946 946
 							<div class="gv-droppable-area-action">
947
-								<a href="#" class="gv-add-field button-secondary" title="" data-objecttype="<?php echo esc_attr( $type ); ?>" data-areaid="<?php echo esc_attr( $zone .'_'. $area['areaid'] ); ?>" data-context="<?php echo esc_attr( $zone ); ?>" data-formid="<?php echo $view ? esc_attr( $view->form ? $view->form->ID : '' ) : ''; ?>"><?php echo '+ '.esc_html( $button_label ); ?></a>
947
+								<a href="#" class="gv-add-field button-secondary" title="" data-objecttype="<?php echo esc_attr( $type ); ?>" data-areaid="<?php echo esc_attr( $zone . '_' . $area[ 'areaid' ] ); ?>" data-context="<?php echo esc_attr( $zone ); ?>" data-formid="<?php echo $view ? esc_attr( $view->form ? $view->form->ID : '' ) : ''; ?>"><?php echo '+ ' . esc_html( $button_label ); ?></a>
948 948
 
949
-								<p class="gv-droppable-area-title"><strong><?php echo esc_html( $area['title'] ); ?></strong><?php if( !empty( $area['subtitle'] ) ) { ?><span class="gv-droppable-area-subtitle"> &ndash; <?php echo esc_html( $area['subtitle'] ); ?></span><?php } ?></p>
949
+								<p class="gv-droppable-area-title"><strong><?php echo esc_html( $area[ 'title' ] ); ?></strong><?php if ( ! empty( $area[ 'subtitle' ] ) ) { ?><span class="gv-droppable-area-subtitle"> &ndash; <?php echo esc_html( $area[ 'subtitle' ] ); ?></span><?php } ?></p>
950 950
 							</div>
951 951
 						</div>
952 952
 
@@ -968,7 +968,7 @@  discard block
 block discarded – undo
968 968
 		$default_widget_areas = GravityView_Widget::get_default_widget_areas();
969 969
 
970 970
 		$widgets = array();
971
-		if( !empty( $post_id ) ) {
971
+		if ( ! empty( $post_id ) ) {
972 972
 			$widgets = gravityview_get_directory_widgets( $post_id );
973 973
 		}
974 974
 
@@ -997,7 +997,7 @@  discard block
 block discarded – undo
997 997
 	 * @return string HTML of the active areas
998 998
 	 */
999 999
 	function render_directory_active_areas( $template_id = '', $context = 'single', $post_id = '', $echo = false ) {
1000
-		if( empty( $template_id ) ) {
1000
+		if ( empty( $template_id ) ) {
1001 1001
 			gravityview()->log->debug( '[render_directory_active_areas] {template_id} is empty', array( 'template_id' => $template_id ) );
1002 1002
 			return '';
1003 1003
 		}
@@ -1011,12 +1011,12 @@  discard block
 block discarded – undo
1011 1011
 		 */
1012 1012
 		$template_areas = apply_filters( 'gravityview_template_active_areas', array(), $template_id, $context );
1013 1013
 
1014
-		if( empty( $template_areas ) ) {
1014
+		if ( empty( $template_areas ) ) {
1015 1015
 
1016 1016
 			gravityview()->log->debug( '[render_directory_active_areas] No areas defined. Maybe template {template_id} is disabled.', array( 'data' => $template_id ) );
1017 1017
 			$output = '<div>';
1018
-			$output .= '<h2 class="description" style="font-size: 16px; margin:0">'. sprintf( esc_html__( 'This View is configured using the %s View type, which is disabled.', 'gravityview' ), '<em>'.$template_id.'</em>' ) .'</h2>';
1019
-			$output .= '<p class="description" style="font-size: 14px; margin:0 0 1em 0;padding:0">'.esc_html__('The data is not lost; re-activate the associated plugin and the configuration will re-appear.', 'gravityview').'</p>';
1018
+			$output .= '<h2 class="description" style="font-size: 16px; margin:0">' . sprintf( esc_html__( 'This View is configured using the %s View type, which is disabled.', 'gravityview' ), '<em>' . $template_id . '</em>' ) . '</h2>';
1019
+			$output .= '<p class="description" style="font-size: 14px; margin:0 0 1em 0;padding:0">' . esc_html__( 'The data is not lost; re-activate the associated plugin and the configuration will re-appear.', 'gravityview' ) . '</p>';
1020 1020
 			$output .= '</div>';
1021 1021
 		} else {
1022 1022
 
@@ -1031,7 +1031,7 @@  discard block
 block discarded – undo
1031 1031
 
1032 1032
 		}
1033 1033
 
1034
-		if( $echo ) {
1034
+		if ( $echo ) {
1035 1035
 			echo $output;
1036 1036
 		}
1037 1037
 
@@ -1051,26 +1051,26 @@  discard block
 block discarded – undo
1051 1051
 		$is_widgets_page = ( $pagenow === 'widgets.php' );
1052 1052
 
1053 1053
 		// Add the GV font (with the Astronaut)
1054
-		wp_enqueue_style( 'gravityview_global', plugins_url('assets/css/admin-global.css', GRAVITYVIEW_FILE), array(), GravityView_Plugin::version );
1054
+		wp_enqueue_style( 'gravityview_global', plugins_url( 'assets/css/admin-global.css', GRAVITYVIEW_FILE ), array(), GravityView_Plugin::version );
1055 1055
 
1056
-		wp_register_script( 'gravityview-jquery-cookie', plugins_url('assets/lib/jquery.cookie/jquery.cookie.min.js', GRAVITYVIEW_FILE), array( 'jquery' ), GravityView_Plugin::version, true );
1056
+		wp_register_script( 'gravityview-jquery-cookie', plugins_url( 'assets/lib/jquery.cookie/jquery.cookie.min.js', GRAVITYVIEW_FILE ), array( 'jquery' ), GravityView_Plugin::version, true );
1057 1057
 
1058 1058
 		// Don't process any scripts below here if it's not a GravityView page.
1059
-		if( ! gravityview_is_admin_page( $hook, 'single' ) && ! $is_widgets_page ) {
1059
+		if ( ! gravityview_is_admin_page( $hook, 'single' ) && ! $is_widgets_page ) {
1060 1060
 		    return;
1061 1061
 		}
1062 1062
 
1063 1063
         wp_enqueue_script( 'jquery-ui-datepicker' );
1064
-        wp_enqueue_style( 'gravityview_views_datepicker', plugins_url('assets/css/admin-datepicker.css', GRAVITYVIEW_FILE), GravityView_Plugin::version );
1064
+        wp_enqueue_style( 'gravityview_views_datepicker', plugins_url( 'assets/css/admin-datepicker.css', GRAVITYVIEW_FILE ), GravityView_Plugin::version );
1065 1065
 
1066
-        $script_debug = (defined('SCRIPT_DEBUG') && SCRIPT_DEBUG) ? '' : '.min';
1066
+        $script_debug = ( defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ) ? '' : '.min';
1067 1067
 
1068 1068
         //enqueue scripts
1069 1069
         wp_enqueue_script( 'gravityview_views_scripts', plugins_url( 'assets/js/admin-views' . $script_debug . '.js', GRAVITYVIEW_FILE ), array( 'jquery-ui-tabs', 'jquery-ui-draggable', 'jquery-ui-droppable', 'jquery-ui-sortable', 'jquery-ui-tooltip', 'jquery-ui-dialog', 'gravityview-jquery-cookie', 'jquery-ui-datepicker', 'underscore' ), GravityView_Plugin::version );
1070 1070
 
1071
-        wp_localize_script('gravityview_views_scripts', 'gvGlobals', array(
1071
+        wp_localize_script( 'gravityview_views_scripts', 'gvGlobals', array(
1072 1072
             'cookiepath' => COOKIEPATH,
1073
-            'passed_form_id' => (bool) \GV\Utils::_GET( 'form_id' ),
1073
+            'passed_form_id' => (bool)\GV\Utils::_GET( 'form_id' ),
1074 1074
             'nonce' => wp_create_nonce( 'gravityview_ajaxviews' ),
1075 1075
             'label_viewname' => __( 'Enter View name here', 'gravityview' ),
1076 1076
             'label_close' => __( 'Close', 'gravityview' ),
@@ -1082,9 +1082,9 @@  discard block
 block discarded – undo
1082 1082
             'loading_error' => esc_html__( 'There was an error loading dynamic content.', 'gravityview' ),
1083 1083
             'field_loaderror' => __( 'Error while adding the field. Please try again or contact GravityView support.', 'gravityview' ),
1084 1084
             'remove_all_fields' => __( 'Would you like to remove all fields in this zone? (You are seeing this message because you were holding down the ALT key)', 'gravityview' ),
1085
-        ));
1085
+        ) );
1086 1086
 
1087
-        wp_enqueue_style( 'gravityview_views_styles', plugins_url( 'assets/css/admin-views.css', GRAVITYVIEW_FILE ), array('dashicons', 'wp-jquery-ui-dialog' ), GravityView_Plugin::version );
1087
+        wp_enqueue_style( 'gravityview_views_styles', plugins_url( 'assets/css/admin-views.css', GRAVITYVIEW_FILE ), array( 'dashicons', 'wp-jquery-ui-dialog' ), GravityView_Plugin::version );
1088 1088
 
1089 1089
         // Enqueue scripts needed for merge tags
1090 1090
         self::enqueue_gravity_forms_scripts();
@@ -1109,7 +1109,7 @@  discard block
 block discarded – undo
1109 1109
 		);
1110 1110
 
1111 1111
 		if ( wp_is_mobile() ) {
1112
-		    $scripts[] = 'jquery-touch-punch';
1112
+		    $scripts[ ] = 'jquery-touch-punch';
1113 1113
 		}
1114 1114
 
1115 1115
 		wp_enqueue_script( $scripts );
Please login to merge, or discard this patch.
includes/class-common.php 1 patch
Spacing   +112 added lines, -112 removed lines patch added patch discarded remove patch
@@ -125,8 +125,8 @@  discard block
 block discarded – undo
125 125
 
126 126
 		$form = false;
127 127
 
128
-		if( $entry ) {
129
-			$form = GFAPI::get_form( $entry['form_id'] );
128
+		if ( $entry ) {
129
+			$form = GFAPI::get_form( $entry[ 'form_id' ] );
130 130
 		}
131 131
 
132 132
 		return $form;
@@ -192,12 +192,12 @@  discard block
 block discarded – undo
192 192
 
193 193
 			$has_transaction_data = \GV\Utils::get( $entry, $meta, false );
194 194
 
195
-			if( ! empty( $has_transaction_data ) ) {
195
+			if ( ! empty( $has_transaction_data ) ) {
196 196
 				break;
197 197
 			}
198 198
 		}
199 199
 
200
-		return (bool) $has_transaction_data;
200
+		return (bool)$has_transaction_data;
201 201
 	}
202 202
 
203 203
 	/**
@@ -235,7 +235,7 @@  discard block
 block discarded – undo
235 235
 
236 236
 		$results = GFAPI::get_entries( intval( $form_id ), $search_criteria, null, $paging );
237 237
 
238
-		$result = ( ! empty( $results ) && ! empty( $results[0]['id'] ) ) ? $results[0]['id'] : null;
238
+		$result = ( ! empty( $results ) && ! empty( $results[ 0 ][ 'id' ] ) ) ? $results[ 0 ][ 'id' ] : null;
239 239
 
240 240
 		return $result;
241 241
 	}
@@ -252,10 +252,10 @@  discard block
 block discarded – undo
252 252
 	 *
253 253
 	 * @return array Empty array if GFAPI class isn't available or no forms. Otherwise, the array of Forms
254 254
 	 */
255
-	public static function get_forms(  $active = true, $trash = false ) {
255
+	public static function get_forms( $active = true, $trash = false ) {
256 256
 		$forms = array();
257 257
 		if ( class_exists( 'GFAPI' ) ) {
258
-			if( 'any' === $active ) {
258
+			if ( 'any' === $active ) {
259 259
 				$active_forms = GFAPI::get_forms( true, $trash );
260 260
 				$inactive_forms = GFAPI::get_forms( false, $trash );
261 261
 				$forms = array_merge( array_filter( $active_forms ), array_filter( $inactive_forms ) );
@@ -286,9 +286,9 @@  discard block
 block discarded – undo
286 286
 		$has_post_fields = false;
287 287
 
288 288
 		if ( $form ) {
289
-			foreach ( $form['fields'] as $field ) {
290
-				if ( $include_parent_field || empty( $field['inputs'] ) ) {
291
-					$fields["{$field['id']}"] = array(
289
+			foreach ( $form[ 'fields' ] as $field ) {
290
+				if ( $include_parent_field || empty( $field[ 'inputs' ] ) ) {
291
+					$fields[ "{$field[ 'id' ]}" ] = array(
292 292
 						'label' => \GV\Utils::get( $field, 'label' ),
293 293
 						'parent' => null,
294 294
 						'type' => \GV\Utils::get( $field, 'type' ),
@@ -297,10 +297,10 @@  discard block
 block discarded – undo
297 297
 					);
298 298
 				}
299 299
 
300
-				if ( $add_default_properties && ! empty( $field['inputs'] ) ) {
301
-					foreach ( $field['inputs'] as $input ) {
300
+				if ( $add_default_properties && ! empty( $field[ 'inputs' ] ) ) {
301
+					foreach ( $field[ 'inputs' ] as $input ) {
302 302
 
303
-						if( ! empty( $input['isHidden'] ) ) {
303
+						if ( ! empty( $input[ 'isHidden' ] ) ) {
304 304
 							continue;
305 305
 						}
306 306
 
@@ -308,10 +308,10 @@  discard block
 block discarded – undo
308 308
                          * @hack
309 309
                          * In case of email/email confirmation, the input for email has the same id as the parent field
310 310
                          */
311
-						if( 'email' === $field['type'] && false === strpos( $input['id'], '.' ) ) {
311
+						if ( 'email' === $field[ 'type' ] && false === strpos( $input[ 'id' ], '.' ) ) {
312 312
                             continue;
313 313
                         }
314
-						$fields["{$input['id']}"] = array(
314
+						$fields[ "{$input[ 'id' ]}" ] = array(
315 315
 							'label' => \GV\Utils::get( $input, 'label' ),
316 316
 							'customLabel' => \GV\Utils::get( $input, 'customLabel' ),
317 317
 							'parent' => $field,
@@ -323,7 +323,7 @@  discard block
 block discarded – undo
323 323
 				}
324 324
 
325 325
 
326
-				if( GFCommon::is_product_field( $field['type'] ) ){
326
+				if ( GFCommon::is_product_field( $field[ 'type' ] ) ) {
327 327
 					$has_product_fields = true;
328 328
 				}
329 329
 
@@ -337,7 +337,7 @@  discard block
 block discarded – undo
337 337
 		 * @since 1.7
338 338
 		 */
339 339
 		if ( $has_post_fields ) {
340
-			$fields['post_id'] = array(
340
+			$fields[ 'post_id' ] = array(
341 341
 				'label' => __( 'Post ID', 'gravityview' ),
342 342
 				'type' => 'post_id',
343 343
 			);
@@ -350,11 +350,11 @@  discard block
 block discarded – undo
350 350
 			foreach ( $payment_fields as $payment_field ) {
351 351
 
352 352
 				// Either the field exists ($fields['shipping']) or the form explicitly contains a `shipping` field with numeric key
353
-				if( isset( $fields["{$payment_field->name}"] ) || GFCommon::get_fields_by_type( $form, $payment_field->name ) ) {
353
+				if ( isset( $fields[ "{$payment_field->name}" ] ) || GFCommon::get_fields_by_type( $form, $payment_field->name ) ) {
354 354
 					continue;
355 355
 				}
356 356
 
357
-				$fields["{$payment_field->name}"] = array(
357
+				$fields[ "{$payment_field->name}" ] = array(
358 358
 					'label' => $payment_field->label,
359 359
 					'desc' => $payment_field->description,
360 360
 					'type' => $payment_field->name,
@@ -386,9 +386,9 @@  discard block
 block discarded – undo
386 386
 
387 387
 		$fields = array();
388 388
 
389
-		foreach ( $extra_fields as $key => $field ){
390
-			if ( ! empty( $only_default_column ) && ! empty( $field['is_default_column'] ) ) {
391
-				$fields[ $key ] = array( 'label' => $field['label'], 'type' => 'entry_meta' );
389
+		foreach ( $extra_fields as $key => $field ) {
390
+			if ( ! empty( $only_default_column ) && ! empty( $field[ 'is_default_column' ] ) ) {
391
+				$fields[ $key ] = array( 'label' => $field[ 'label' ], 'type' => 'entry_meta' );
392 392
 			}
393 393
 		}
394 394
 
@@ -428,33 +428,33 @@  discard block
 block discarded – undo
428 428
 			'search_criteria' => null,
429 429
 			'sorting' => null,
430 430
 			'paging' => null,
431
-			'cache' => (isset( $passed_criteria['cache'] ) ? (bool) $passed_criteria['cache'] : true),
431
+			'cache' => ( isset( $passed_criteria[ 'cache' ] ) ? (bool)$passed_criteria[ 'cache' ] : true ),
432 432
 			'context_view_id' => null,
433 433
 		);
434 434
 
435 435
 		$criteria = wp_parse_args( $passed_criteria, $search_criteria_defaults );
436 436
 
437
-		if ( ! empty( $criteria['search_criteria']['field_filters'] ) ) {
438
-			foreach ( $criteria['search_criteria']['field_filters'] as &$filter ) {
437
+		if ( ! empty( $criteria[ 'search_criteria' ][ 'field_filters' ] ) ) {
438
+			foreach ( $criteria[ 'search_criteria' ][ 'field_filters' ] as &$filter ) {
439 439
 
440 440
 				if ( ! is_array( $filter ) ) {
441 441
 					continue;
442 442
 				}
443 443
 
444 444
 				// By default, we want searches to be wildcard for each field.
445
-				$filter['operator'] = empty( $filter['operator'] ) ? 'contains' : $filter['operator'];
445
+				$filter[ 'operator' ] = empty( $filter[ 'operator' ] ) ? 'contains' : $filter[ 'operator' ];
446 446
 
447 447
 				/**
448 448
 				 * @filter `gravityview_search_operator` Modify the search operator for the field (contains, is, isnot, etc)
449 449
 				 * @param string $operator Existing search operator
450 450
 				 * @param array $filter array with `key`, `value`, `operator`, `type` keys
451 451
 				 */
452
-				$filter['operator'] = apply_filters( 'gravityview_search_operator', $filter['operator'], $filter );
452
+				$filter[ 'operator' ] = apply_filters( 'gravityview_search_operator', $filter[ 'operator' ], $filter );
453 453
 			}
454 454
 
455 455
 			// don't send just the [mode] without any field filter.
456
-			if( count( $criteria['search_criteria']['field_filters'] ) === 1 && array_key_exists( 'mode' , $criteria['search_criteria']['field_filters'] ) ) {
457
-				unset( $criteria['search_criteria']['field_filters']['mode'] );
456
+			if ( count( $criteria[ 'search_criteria' ][ 'field_filters' ] ) === 1 && array_key_exists( 'mode', $criteria[ 'search_criteria' ][ 'field_filters' ] ) ) {
457
+				unset( $criteria[ 'search_criteria' ][ 'field_filters' ][ 'mode' ] );
458 458
 			}
459 459
 
460 460
 		}
@@ -465,33 +465,33 @@  discard block
 block discarded – undo
465 465
 		 * Prepare date formats to be in Gravity Forms DB format;
466 466
 		 * $passed_criteria may include date formats incompatible with Gravity Forms.
467 467
 		 */
468
-		foreach ( array('start_date', 'end_date' ) as $key ) {
468
+		foreach ( array( 'start_date', 'end_date' ) as $key ) {
469 469
 
470
-			if ( ! empty( $criteria['search_criteria'][ $key ] ) ) {
470
+			if ( ! empty( $criteria[ 'search_criteria' ][ $key ] ) ) {
471 471
 
472 472
 				// Use date_create instead of new DateTime so it returns false if invalid date format.
473
-				$date = date_create( $criteria['search_criteria'][ $key ] );
473
+				$date = date_create( $criteria[ 'search_criteria' ][ $key ] );
474 474
 
475 475
 				if ( $date ) {
476 476
 					// Gravity Forms wants dates in the `Y-m-d H:i:s` format.
477
-					$criteria['search_criteria'][ $key ] = $date->format( 'Y-m-d H:i:s' );
477
+					$criteria[ 'search_criteria' ][ $key ] = $date->format( 'Y-m-d H:i:s' );
478 478
 				} else {
479
-					gravityview()->log->error( '{key} Date format not valid:', array( 'key' => $key, $criteria['search_criteria'][ $key ] ) );
479
+					gravityview()->log->error( '{key} Date format not valid:', array( 'key' => $key, $criteria[ 'search_criteria' ][ $key ] ) );
480 480
 
481 481
 					// If it's an invalid date, unset it. Gravity Forms freaks out otherwise.
482
-					unset( $criteria['search_criteria'][ $key ] );
482
+					unset( $criteria[ 'search_criteria' ][ $key ] );
483 483
 				}
484 484
 			}
485 485
 		}
486 486
 
487
-		if ( empty( $criteria['context_view_id'] ) ) {
487
+		if ( empty( $criteria[ 'context_view_id' ] ) ) {
488 488
 			// Calculate the context view id and send it to the advanced filter
489 489
 			if ( GravityView_frontend::getInstance()->getSingleEntry() ) {
490
-				$criteria['context_view_id'] = GravityView_frontend::getInstance()->get_context_view_id();
490
+				$criteria[ 'context_view_id' ] = GravityView_frontend::getInstance()->get_context_view_id();
491 491
 			} else if ( class_exists( 'GravityView_View_Data' ) && GravityView_View_Data::getInstance() && GravityView_View_Data::getInstance()->has_multiple_views() ) {
492
-				$criteria['context_view_id'] = GravityView_frontend::getInstance()->get_context_view_id();
492
+				$criteria[ 'context_view_id' ] = GravityView_frontend::getInstance()->get_context_view_id();
493 493
 			} else if ( 'delete' === GFForms::get( 'action' ) ) {
494
-				$criteria['context_view_id'] = isset( $_GET['view_id'] ) ? intval( $_GET['view_id'] ) : null;
494
+				$criteria[ 'context_view_id' ] = isset( $_GET[ 'view_id' ] ) ? intval( $_GET[ 'view_id' ] ) : null;
495 495
 			}
496 496
 		}
497 497
 
@@ -501,7 +501,7 @@  discard block
 block discarded – undo
501 501
 		 * @param array $form_ids Forms to search
502 502
 		 * @param int $view_id ID of the view being used to search
503 503
 		 */
504
-		$criteria = apply_filters( 'gravityview_search_criteria', $criteria, $form_ids, $criteria['context_view_id'] );
504
+		$criteria = apply_filters( 'gravityview_search_criteria', $criteria, $form_ids, $criteria[ 'context_view_id' ] );
505 505
 
506 506
 		return (array)$criteria;
507 507
 	}
@@ -531,7 +531,7 @@  discard block
 block discarded – undo
531 531
 		/** Reduce # of database calls */
532 532
 		add_filter( 'gform_is_encrypted_field', '__return_false' );
533 533
 
534
-		if ( ! empty( $criteria['cache'] ) ) {
534
+		if ( ! empty( $criteria[ 'cache' ] ) ) {
535 535
 
536 536
 			$Cache = new GravityView_Cache( $form_ids, $criteria );
537 537
 
@@ -539,7 +539,7 @@  discard block
 block discarded – undo
539 539
 
540 540
 				// Still update the total count when using cached results
541 541
 				if ( ! is_null( $total ) ) {
542
-					$total = GFAPI::count_entries( $form_ids, $criteria['search_criteria'] );
542
+					$total = GFAPI::count_entries( $form_ids, $criteria[ 'search_criteria' ] );
543 543
 				}
544 544
 
545 545
 				$return = $entries;
@@ -560,9 +560,9 @@  discard block
 block discarded – undo
560 560
 			$entries = apply_filters( 'gravityview_before_get_entries', null, $criteria, $passed_criteria, $total );
561 561
 
562 562
 			// No entries returned from gravityview_before_get_entries
563
-			if( is_null( $entries ) ) {
563
+			if ( is_null( $entries ) ) {
564 564
 
565
-				$entries = GFAPI::get_entries( $form_ids, $criteria['search_criteria'], $criteria['sorting'], $criteria['paging'], $total );
565
+				$entries = GFAPI::get_entries( $form_ids, $criteria[ 'search_criteria' ], $criteria[ 'sorting' ], $criteria[ 'paging' ], $total );
566 566
 
567 567
 				if ( is_wp_error( $entries ) ) {
568 568
 					gravityview()->log->error( '{error}', array( 'error' => $entries->get_error_message(), 'data' => $entries ) );
@@ -573,7 +573,7 @@  discard block
 block discarded – undo
573 573
 				}
574 574
 			}
575 575
 
576
-			if ( ! empty( $criteria['cache'] ) && isset( $Cache ) ) {
576
+			if ( ! empty( $criteria[ 'cache' ] ) && isset( $Cache ) ) {
577 577
 
578 578
 				// Cache results
579 579
 				$Cache->set( $entries, 'entries' );
@@ -680,12 +680,12 @@  discard block
 block discarded – undo
680 680
 		 */
681 681
 		$check_entry_display = apply_filters( 'gravityview/common/get_entry/check_entry_display', $check_entry_display, $entry );
682 682
 
683
-		if( $check_entry_display ) {
683
+		if ( $check_entry_display ) {
684 684
 			// Is the entry allowed
685 685
 			$entry = self::check_entry_display( $entry );
686 686
 		}
687 687
 
688
-		if( is_wp_error( $entry ) ) {
688
+		if ( is_wp_error( $entry ) ) {
689 689
 			gravityview()->log->error( '{error}', array( 'error' => $entry->get_error_message() ) );
690 690
 			return false;
691 691
 		}
@@ -713,7 +713,7 @@  discard block
 block discarded – undo
713 713
 	 */
714 714
 	public static function matches_operation( $val1, $val2, $operation ) {
715 715
 
716
-		$json_function = function_exists('wp_json_encode') ? 'wp_json_encode' : 'json_encode';
716
+		$json_function = function_exists( 'wp_json_encode' ) ? 'wp_json_encode' : 'json_encode';
717 717
 
718 718
 		// Only process strings
719 719
 		$val1 = ! is_string( $val1 ) ? $json_function( $val1 ) : $val1;
@@ -721,12 +721,12 @@  discard block
 block discarded – undo
721 721
 
722 722
 		$value = false;
723 723
 
724
-		if( 'context' === $val1 ) {
724
+		if ( 'context' === $val1 ) {
725 725
 
726 726
 			$matching_contexts = array( $val2 );
727 727
 
728 728
 			// We allow for non-standard contexts.
729
-			switch( $val2 ) {
729
+			switch ( $val2 ) {
730 730
 				// Check for either single or edit
731 731
 				case 'singular':
732 732
 					$matching_contexts = array( 'single', 'edit' );
@@ -769,7 +769,7 @@  discard block
 block discarded – undo
769 769
 				$json_val_1 = json_decode( $val1, true );
770 770
 				$json_val_2 = json_decode( $val2, true );
771 771
 
772
-				if( ! empty( $json_val_1 ) || ! empty( $json_val_2 ) ) {
772
+				if ( ! empty( $json_val_1 ) || ! empty( $json_val_2 ) ) {
773 773
 
774 774
 					$json_in = false;
775 775
 					$json_val_1 = $json_val_1 ? $json_val_1 : array( $val1 );
@@ -780,7 +780,7 @@  discard block
 block discarded – undo
780 780
 						foreach ( $json_val_2 as $item_2 ) {
781 781
 							$json_in = self::matches_operation( $item_1, $item_2, 'is' );
782 782
 
783
-							if( $json_in ) {
783
+							if ( $json_in ) {
784 784
 								break 2;
785 785
 							}
786 786
 						}
@@ -828,62 +828,62 @@  discard block
 block discarded – undo
828 828
 	public static function check_entry_display( $entry ) {
829 829
 
830 830
 		if ( ! $entry || is_wp_error( $entry ) ) {
831
-			return new WP_Error('entry_not_found', 'Entry was not found.', $entry );
831
+			return new WP_Error( 'entry_not_found', 'Entry was not found.', $entry );
832 832
 		}
833 833
 
834
-		if ( empty( $entry['form_id'] ) ) {
834
+		if ( empty( $entry[ 'form_id' ] ) ) {
835 835
 			return new WP_Error( 'form_id_not_set', '[apply_filters_to_entry] Entry is empty!', $entry );
836 836
 		}
837 837
 
838 838
 		$criteria = self::calculate_get_entries_criteria();
839 839
 
840
-		if ( empty( $criteria['search_criteria'] ) || ! is_array( $criteria['search_criteria'] ) ) {
840
+		if ( empty( $criteria[ 'search_criteria' ] ) || ! is_array( $criteria[ 'search_criteria' ] ) ) {
841 841
 			gravityview()->log->debug( '[apply_filters_to_entry] Entry approved! No search criteria found:', array( 'data' => $criteria ) );
842 842
 			return $entry;
843 843
 		}
844 844
 
845 845
 		// Make sure the current View is connected to the same form as the Entry
846
-		if( ! empty( $criteria['context_view_id'] ) ) {
847
-			$context_view_id = intval( $criteria['context_view_id'] );
846
+		if ( ! empty( $criteria[ 'context_view_id' ] ) ) {
847
+			$context_view_id = intval( $criteria[ 'context_view_id' ] );
848 848
 			$context_form_id = gravityview_get_form_id( $context_view_id );
849
-			if( intval( $context_form_id ) !== intval( $entry['form_id'] ) ) {
850
-				return new WP_Error( 'view_id_not_match', sprintf( '[apply_filters_to_entry] Entry form ID does not match current View connected form ID:', $entry['form_id'] ), $criteria['context_view_id'] );
849
+			if ( intval( $context_form_id ) !== intval( $entry[ 'form_id' ] ) ) {
850
+				return new WP_Error( 'view_id_not_match', sprintf( '[apply_filters_to_entry] Entry form ID does not match current View connected form ID:', $entry[ 'form_id' ] ), $criteria[ 'context_view_id' ] );
851 851
 			}
852 852
 		}
853 853
 
854
-		$search_criteria = $criteria['search_criteria'];
854
+		$search_criteria = $criteria[ 'search_criteria' ];
855 855
 
856 856
 		// check entry status
857
-		if ( array_key_exists( 'status', $search_criteria ) && $search_criteria['status'] != $entry['status'] ) {
858
-			return new WP_Error( 'status_not_valid', sprintf( '[apply_filters_to_entry] Entry status - %s - is not valid according to filter:', $entry['status'] ), $search_criteria );
857
+		if ( array_key_exists( 'status', $search_criteria ) && $search_criteria[ 'status' ] != $entry[ 'status' ] ) {
858
+			return new WP_Error( 'status_not_valid', sprintf( '[apply_filters_to_entry] Entry status - %s - is not valid according to filter:', $entry[ 'status' ] ), $search_criteria );
859 859
 		}
860 860
 
861 861
 		// check entry date
862 862
 		// @todo: Does it make sense to apply the Date create filters to the single entry?
863 863
 
864 864
 		// field_filters
865
-		if ( empty( $search_criteria['field_filters'] ) || ! is_array( $search_criteria['field_filters'] ) ) {
865
+		if ( empty( $search_criteria[ 'field_filters' ] ) || ! is_array( $search_criteria[ 'field_filters' ] ) ) {
866 866
 			gravityview()->log->debug( '[apply_filters_to_entry] Entry approved! No field filters criteria found:', array( 'data' => $search_criteria ) );
867 867
 			return $entry;
868 868
 		}
869 869
 
870
-		$filters = $search_criteria['field_filters'];
870
+		$filters = $search_criteria[ 'field_filters' ];
871 871
 
872
-		$mode = array_key_exists( 'mode', $filters ) ? strtolower( $filters['mode'] ) : 'all';
872
+		$mode = array_key_exists( 'mode', $filters ) ? strtolower( $filters[ 'mode' ] ) : 'all';
873 873
 
874 874
 		// Prevent the mode from being processed below
875
-		unset( $filters['mode'] );
875
+		unset( $filters[ 'mode' ] );
876 876
 
877
-		$form = self::get_form( $entry['form_id'] );
877
+		$form = self::get_form( $entry[ 'form_id' ] );
878 878
 
879 879
 		foreach ( $filters as $filter ) {
880 880
 
881
-			if ( ! isset( $filter['key'] ) ) {
881
+			if ( ! isset( $filter[ 'key' ] ) ) {
882 882
 				gravityview()->log->debug( '[apply_filters_to_entry] Filter key not set: {filter}', array( 'filter' => $filter ) );
883 883
 				continue;
884 884
 			}
885 885
 
886
-			$k = $filter['key'];
886
+			$k = $filter[ 'key' ];
887 887
 
888 888
 			$field = self::get_field( $form, $k );
889 889
 
@@ -891,14 +891,14 @@  discard block
 block discarded – undo
891 891
 				$field_value = isset( $entry[ $k ] ) ? $entry[ $k ] : null;
892 892
 				$field = $k;
893 893
 			} else {
894
-				$field_value  = GFFormsModel::get_lead_field_value( $entry, $field );
894
+				$field_value = GFFormsModel::get_lead_field_value( $entry, $field );
895 895
 				 // If it's a complex field, then fetch the input's value, if exists at the current key. Otherwise, let GF handle it
896 896
 				$field_value = ( is_array( $field_value ) && isset( $field_value[ $k ] ) ) ? \GV\Utils::get( $field_value, $k ) : $field_value;
897 897
 			}
898 898
 
899
-			$operator = isset( $filter['operator'] ) ? strtolower( $filter['operator'] ) : 'is';
899
+			$operator = isset( $filter[ 'operator' ] ) ? strtolower( $filter[ 'operator' ] ) : 'is';
900 900
 
901
-			$is_value_match = GravityView_GFFormsModel::is_value_match( $field_value, $filter['value'], $operator, $field );
901
+			$is_value_match = GravityView_GFFormsModel::is_value_match( $field_value, $filter[ 'value' ], $operator, $field );
902 902
 
903 903
 			// Any match is all we need to know
904 904
 			if ( $is_value_match && 'any' === $mode ) {
@@ -907,7 +907,7 @@  discard block
 block discarded – undo
907 907
 
908 908
 			// Any failed match is a total fail
909 909
 			if ( ! $is_value_match && 'all' === $mode ) {
910
-				return new WP_Error('failed_criteria', '[apply_filters_to_entry] Entry cannot be displayed. Failed a criterium for ALL mode', $filter );
910
+				return new WP_Error( 'failed_criteria', '[apply_filters_to_entry] Entry cannot be displayed. Failed a criterium for ALL mode', $filter );
911 911
 			}
912 912
 		}
913 913
 
@@ -917,7 +917,7 @@  discard block
 block discarded – undo
917 917
 			gravityview()->log->debug( '[apply_filters_to_entry] Entry approved: all conditions were met' );
918 918
 			return $entry;
919 919
 		} else {
920
-			return new WP_Error('failed_any_criteria', '[apply_filters_to_entry] Entry cannot be displayed. Failed all the criteria for ANY mode', $filters );
920
+			return new WP_Error( 'failed_any_criteria', '[apply_filters_to_entry] Entry cannot be displayed. Failed all the criteria for ANY mode', $filters );
921 921
 		}
922 922
 
923 923
 	}
@@ -958,18 +958,18 @@  discard block
 block discarded – undo
958 958
 		 * Gravity Forms code to adjust date to locally-configured Time Zone
959 959
 		 * @see GFCommon::format_date() for original code
960 960
 		 */
961
-		$date_gmt_time   = mysql2date( 'G', $date_string );
961
+		$date_gmt_time = mysql2date( 'G', $date_string );
962 962
 		$date_local_timestamp = GFCommon::get_local_timestamp( $date_gmt_time );
963 963
 
964
-		$format  = \GV\Utils::get( $atts, 'format' );
965
-		$is_human  = ! empty( $atts['human'] );
966
-		$is_diff  = ! empty( $atts['diff'] );
967
-		$is_raw = ! empty( $atts['raw'] );
968
-		$is_timestamp = ! empty( $atts['timestamp'] );
969
-		$include_time = ! empty( $atts['time'] );
964
+		$format = \GV\Utils::get( $atts, 'format' );
965
+		$is_human = ! empty( $atts[ 'human' ] );
966
+		$is_diff = ! empty( $atts[ 'diff' ] );
967
+		$is_raw = ! empty( $atts[ 'raw' ] );
968
+		$is_timestamp = ! empty( $atts[ 'timestamp' ] );
969
+		$include_time = ! empty( $atts[ 'time' ] );
970 970
 
971 971
 		// If we're using time diff, we want to have a different default format
972
-		if( empty( $format ) ) {
972
+		if ( empty( $format ) ) {
973 973
 			/* translators: %s: relative time from now, used for generic date comparisons. "1 day ago", or "20 seconds ago" */
974 974
 			$format = $is_diff ? esc_html__( '%s ago', 'gravityview' ) : get_option( 'date_format' );
975 975
 		}
@@ -977,7 +977,7 @@  discard block
 block discarded – undo
977 977
 		// If raw was specified, don't modify the stored value
978 978
 		if ( $is_raw ) {
979 979
 			$formatted_date = $date_string;
980
-		} elseif( $is_timestamp ) {
980
+		} elseif ( $is_timestamp ) {
981 981
 			$formatted_date = $date_local_timestamp;
982 982
 		} elseif ( $is_diff ) {
983 983
 			$formatted_date = sprintf( $format, human_time_diff( $date_gmt_time ) );
@@ -1011,7 +1011,7 @@  discard block
 block discarded – undo
1011 1011
 
1012 1012
 		$label = \GV\Utils::get( $field, 'label' );
1013 1013
 
1014
-		if( floor( $field_id ) !== floatval( $field_id ) ) {
1014
+		if ( floor( $field_id ) !== floatval( $field_id ) ) {
1015 1015
 			$label = GFFormsModel::get_choice_text( $field, $field_value, $field_id );
1016 1016
 		}
1017 1017
 
@@ -1039,7 +1039,7 @@  discard block
 block discarded – undo
1039 1039
 			$form = GFAPI::get_form( $form );
1040 1040
 		}
1041 1041
 
1042
-		if ( class_exists( 'GFFormsModel' ) ){
1042
+		if ( class_exists( 'GFFormsModel' ) ) {
1043 1043
 			return GFFormsModel::get_field( $form, $field_id );
1044 1044
 		} else {
1045 1045
 			return null;
@@ -1086,19 +1086,19 @@  discard block
 block discarded – undo
1086 1086
 			$shortcodes = array();
1087 1087
 
1088 1088
 			preg_match_all( '/' . get_shortcode_regex() . '/s', $content, $matches, PREG_SET_ORDER );
1089
-			if ( empty( $matches ) ){
1089
+			if ( empty( $matches ) ) {
1090 1090
 				return false;
1091 1091
 			}
1092 1092
 
1093 1093
 			foreach ( $matches as $shortcode ) {
1094
-				if ( $tag === $shortcode[2] ) {
1094
+				if ( $tag === $shortcode[ 2 ] ) {
1095 1095
 
1096 1096
 					// Changed this to $shortcode instead of true so we get the parsed atts.
1097
-					$shortcodes[] = $shortcode;
1097
+					$shortcodes[ ] = $shortcode;
1098 1098
 
1099
-				} else if ( isset( $shortcode[5] ) && $results = self::has_shortcode_r( $shortcode[5], $tag ) ) {
1100
-					foreach( $results as $result ) {
1101
-						$shortcodes[] = $result;
1099
+				} else if ( isset( $shortcode[ 5 ] ) && $results = self::has_shortcode_r( $shortcode[ 5 ], $tag ) ) {
1100
+					foreach ( $results as $result ) {
1101
+						$shortcodes[ ] = $result;
1102 1102
 					}
1103 1103
 				}
1104 1104
 			}
@@ -1285,7 +1285,7 @@  discard block
 block discarded – undo
1285 1285
 
1286 1286
 		$directory_widgets = wp_parse_args( $view_widgets, $defaults );
1287 1287
 
1288
-		if( $json_decode ) {
1288
+		if ( $json_decode ) {
1289 1289
 			$directory_widgets = gv_map_deep( $directory_widgets, 'gv_maybe_json_decode' );
1290 1290
 		}
1291 1291
 
@@ -1301,7 +1301,7 @@  discard block
 block discarded – undo
1301 1301
 	 * @return string         html
1302 1302
 	 */
1303 1303
 	public static function get_sortable_fields( $formid, $current = '' ) {
1304
-		$output = '<option value="" ' . selected( '', $current, false ).'>' . esc_html__( 'Default', 'gravityview' ) .'</option>';
1304
+		$output = '<option value="" ' . selected( '', $current, false ) . '>' . esc_html__( 'Default', 'gravityview' ) . '</option>';
1305 1305
 
1306 1306
 		if ( empty( $formid ) ) {
1307 1307
 			return $output;
@@ -1314,11 +1314,11 @@  discard block
 block discarded – undo
1314 1314
 			$blacklist_field_types = apply_filters( 'gravityview_blacklist_field_types', array( 'list', 'textarea' ), null );
1315 1315
 
1316 1316
 			foreach ( $fields as $id => $field ) {
1317
-				if ( in_array( $field['type'], $blacklist_field_types ) ) {
1317
+				if ( in_array( $field[ 'type' ], $blacklist_field_types ) ) {
1318 1318
 					continue;
1319 1319
 				}
1320 1320
 
1321
-				$output .= '<option value="'. $id .'" '. selected( $id, $current, false ).'>'. esc_attr( $field['label'] ) .'</option>';
1321
+				$output .= '<option value="' . $id . '" ' . selected( $id, $current, false ) . '>' . esc_attr( $field[ 'label' ] ) . '</option>';
1322 1322
 			}
1323 1323
 		}
1324 1324
 
@@ -1353,9 +1353,9 @@  discard block
 block discarded – undo
1353 1353
 		$blacklist_field_types = apply_filters( 'gravityview_blacklist_field_types', $blacklist, NULL );
1354 1354
 
1355 1355
 		// TODO: Convert to using array_filter
1356
-		foreach( $fields as $id => $field ) {
1356
+		foreach ( $fields as $id => $field ) {
1357 1357
 
1358
-			if( in_array( $field['type'], $blacklist_field_types ) ) {
1358
+			if ( in_array( $field[ 'type' ], $blacklist_field_types ) ) {
1359 1359
 				unset( $fields[ $id ] );
1360 1360
 			}
1361 1361
 		}
@@ -1396,14 +1396,14 @@  discard block
 block discarded – undo
1396 1396
 	 * @param  int|array  $field field key or field array
1397 1397
 	 * @return boolean
1398 1398
 	 */
1399
-	public static function is_field_numeric(  $form = null, $field = '' ) {
1399
+	public static function is_field_numeric( $form = null, $field = '' ) {
1400 1400
 
1401 1401
 		if ( ! is_array( $form ) && ! is_array( $field ) ) {
1402 1402
 			$form = self::get_form( $form );
1403 1403
 		}
1404 1404
 
1405 1405
 		// If entry meta, it's a string. Otherwise, numeric
1406
-		if( ! is_numeric( $field ) && is_string( $field ) ) {
1406
+		if ( ! is_numeric( $field ) && is_string( $field ) ) {
1407 1407
 			$type = $field;
1408 1408
 		} else {
1409 1409
 			$type = self::get_field_type( $form, $field );
@@ -1417,9 +1417,9 @@  discard block
 block discarded – undo
1417 1417
 		$numeric_types = apply_filters( 'gravityview/common/numeric_types', array( 'number', 'time' ) );
1418 1418
 
1419 1419
 		// Defer to GravityView_Field setting, if the field type is registered and `is_numeric` is true
1420
-		if( $gv_field = GravityView_Fields::get( $type ) ) {
1421
-			if( true === $gv_field->is_numeric ) {
1422
-				$numeric_types[] = $gv_field->is_numeric;
1420
+		if ( $gv_field = GravityView_Fields::get( $type ) ) {
1421
+			if ( true === $gv_field->is_numeric ) {
1422
+				$numeric_types[ ] = $gv_field->is_numeric;
1423 1423
 			}
1424 1424
 		}
1425 1425
 
@@ -1569,18 +1569,18 @@  discard block
 block discarded – undo
1569 1569
 		$final_atts = array_filter( $final_atts );
1570 1570
 
1571 1571
 		// If the href wasn't passed as an attribute, use the value passed to the function
1572
-		if ( empty( $final_atts['href'] ) && ! empty( $href ) ) {
1573
-			$final_atts['href'] = $href;
1572
+		if ( empty( $final_atts[ 'href' ] ) && ! empty( $href ) ) {
1573
+			$final_atts[ 'href' ] = $href;
1574 1574
 		}
1575 1575
 
1576
-		$final_atts['href'] = esc_url_raw( $href );
1576
+		$final_atts[ 'href' ] = esc_url_raw( $href );
1577 1577
 
1578 1578
 		/**
1579 1579
 		 * Fix potential security issue with target=_blank
1580 1580
 		 * @see https://dev.to/ben/the-targetblank-vulnerability-by-example
1581 1581
 		 */
1582
-		if( '_blank' === \GV\Utils::get( $final_atts, 'target' ) ) {
1583
-			$final_atts['rel'] = trim( \GV\Utils::get( $final_atts, 'rel', '' ) . ' noopener noreferrer' );
1582
+		if ( '_blank' === \GV\Utils::get( $final_atts, 'target' ) ) {
1583
+			$final_atts[ 'rel' ] = trim( \GV\Utils::get( $final_atts, 'rel', '' ) . ' noopener noreferrer' );
1584 1584
 		}
1585 1585
 
1586 1586
 		// Sort the attributes alphabetically, to help testing
@@ -1592,7 +1592,7 @@  discard block
 block discarded – undo
1592 1592
 			$output .= sprintf( ' %s="%s"', $attr, esc_attr( $value ) );
1593 1593
 		}
1594 1594
 
1595
-		if( '' !== $output ) {
1595
+		if ( '' !== $output ) {
1596 1596
 			$output = '<a' . $output . '>' . $anchor_text . '</a>';
1597 1597
 		}
1598 1598
 
@@ -1619,7 +1619,7 @@  discard block
 block discarded – undo
1619 1619
 			if ( is_array( $value ) && isset( $merged[ $key ] ) && is_array( $merged[ $key ] ) ) {
1620 1620
 				$merged[ $key ] = self::array_merge_recursive_distinct( $merged[ $key ], $value );
1621 1621
 			} else if ( is_numeric( $key ) && isset( $merged[ $key ] ) ) {
1622
-				$merged[] = $value;
1622
+				$merged[ ] = $value;
1623 1623
 			} else {
1624 1624
 				$merged[ $key ] = $value;
1625 1625
 			}
@@ -1652,7 +1652,7 @@  discard block
 block discarded – undo
1652 1652
 		 * `$context` is where are we using this information (e.g. change_entry_creator, search_widget ..)
1653 1653
 		 * @param array $settings Settings array, with `number` key defining the # of users to display
1654 1654
 		 */
1655
-		$get_users_settings = apply_filters( 'gravityview/get_users/'. $context, apply_filters( 'gravityview_change_entry_creator_user_parameters', $get_users_settings ) );
1655
+		$get_users_settings = apply_filters( 'gravityview/get_users/' . $context, apply_filters( 'gravityview_change_entry_creator_user_parameters', $get_users_settings ) );
1656 1656
 
1657 1657
 		return get_users( $get_users_settings );
1658 1658
 	}
@@ -1672,11 +1672,11 @@  discard block
 block discarded – undo
1672 1672
     public static function generate_notice( $notice, $class = '', $cap = '', $object_id = null ) {
1673 1673
 
1674 1674
     	// If $cap is defined, only show notice if user has capability
1675
-    	if( $cap && ! GVCommon::has_cap( $cap, $object_id ) ) {
1675
+    	if ( $cap && ! GVCommon::has_cap( $cap, $object_id ) ) {
1676 1676
     		return '';
1677 1677
 	    }
1678 1678
 
1679
-        return '<div class="gv-notice '.gravityview_sanitize_html_class( $class ) .'">'. $notice .'</div>';
1679
+        return '<div class="gv-notice ' . gravityview_sanitize_html_class( $class ) . '">' . $notice . '</div>';
1680 1680
     }
1681 1681
 
1682 1682
 	/**
Please login to merge, or discard this patch.
future/includes/class-gv-view.php 1 patch
Spacing   +21 added lines, -22 removed lines patch added patch discarded remove patch
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 		$supports = array( 'title', 'revisions' );
109 109
 
110 110
 		if ( $is_hierarchical ) {
111
-			$supports[] = 'page-attributes';
111
+			$supports[ ] = 'page-attributes';
112 112
 		}
113 113
 
114 114
 		/**
@@ -289,13 +289,13 @@  discard block
 block discarded – undo
289 289
 			return __( 'You are not allowed to view this content.', 'gravityview' );
290 290
 		}
291 291
 
292
-		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap('gravityview_moderate_entries', $view->ID );
292
+		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap( 'gravityview_moderate_entries', $view->ID );
293 293
 
294 294
 		/**
295 295
 		 * Editing a single entry.
296 296
 		 */
297 297
 		if ( $entry = $request->is_edit_entry() ) {
298
-			if ( $entry['status'] != 'active' ) {
298
+			if ( $entry[ 'status' ] != 'active' ) {
299 299
 				gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
300 300
 				return __( 'You are not allowed to view this content.', 'gravityview' );
301 301
 			}
@@ -306,7 +306,7 @@  discard block
 block discarded – undo
306 306
 			}
307 307
 
308 308
 			if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
309
-				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
309
+				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
310 310
 					gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
311 311
 					return __( 'You are not allowed to view this content.', 'gravityview' );
312 312
 				}
@@ -319,7 +319,7 @@  discard block
 block discarded – undo
319 319
 		 * Viewing a single entry.
320 320
 		 */
321 321
 		} else if ( $entry = $request->is_entry() ) {
322
-			if ( $entry['status'] != 'active' ) {
322
+			if ( $entry[ 'status' ] != 'active' ) {
323 323
 				gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
324 324
 				return __( 'You are not allowed to view this content.', 'gravityview' );
325 325
 			}
@@ -330,7 +330,7 @@  discard block
 block discarded – undo
330 330
 			}
331 331
 
332 332
 			if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
333
-				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
333
+				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
334 334
 					gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
335 335
 					return __( 'You are not allowed to view this content.', 'gravityview' );
336 336
 				}
@@ -378,11 +378,11 @@  discard block
 block discarded – undo
378 378
 		if ( ! $view->form ) {
379 379
 			gravityview()->log->error( 'View #{view_id} tried attaching non-existent Form #{form_id} to it.', array(
380 380
 				'view_id' => $view->ID,
381
-				'form_id' => $view->_gravityview_form_id ? : 0,
381
+				'form_id' => $view->_gravityview_form_id ?: 0,
382 382
 			) );
383 383
 		} else if ( gravityview()->plugin->supports( Plugin::FEATURE_JOINS ) ) {
384 384
 			/** And the connected joins. */
385
-			foreach( (array)get_post_meta( $view->ID, '_gravityview_form_joins', true ) as $_join ) {
385
+			foreach ( (array)get_post_meta( $view->ID, '_gravityview_form_joins', true ) as $_join ) {
386 386
 				if ( ! is_array( $_join ) || count( $_join ) != 4 ) {
387 387
 					continue;
388 388
 				}
@@ -394,7 +394,7 @@  discard block
 block discarded – undo
394 394
 				$join_column = is_numeric( $join_column ) ? GF_Field::by_id( $join, $join_column ) : Internal_Field( $join_column );
395 395
 				$join_on_column = is_numeric( $join_on_column ) ? GF_Field::by_id( $join_on, $join_on_column ) : Internal_Field( $join_on_column );
396 396
 
397
-				$view->joins []= new Join( $join, $join_column, $join_on, $join_on_column );
397
+				$view->joins [ ] = new Join( $join, $join_column, $join_on, $join_on_column );
398 398
 			}
399 399
 		}
400 400
 
@@ -618,28 +618,27 @@  discard block
 block discarded – undo
618 618
 			 * @todo: Stop using _frontend and use something like $request->get_search_criteria() instead
619 619
 			 */
620 620
 			$parameters = \GravityView_frontend::get_view_entries_parameters( $this->settings->as_atts(), $this->form->ID );
621
-			$parameters['context_view_id'] = $this->ID;
621
+			$parameters[ 'context_view_id' ] = $this->ID;
622 622
 			$parameters = \GVCommon::calculate_get_entries_criteria( $parameters, $this->form->ID );
623 623
 
624 624
 			if ( $request instanceof REST\Request ) {
625 625
 				$atts = $this->settings->as_atts();
626 626
 				$paging_parameters = wp_parse_args( $request->get_paging(), array(
627
-						'paging' => array( 'page_size' => $atts['page_size'] ),
627
+						'paging' => array( 'page_size' => $atts[ 'page_size' ] ),
628 628
 					) );
629
-				$parameters['paging'] = $paging_parameters['paging'];
629
+				$parameters[ 'paging' ] = $paging_parameters[ 'paging' ];
630 630
 			}
631 631
 
632
-			$page = Utils::get( $parameters['paging'], 'current_page' ) ?
633
-				: ( ( ( $parameters['paging']['offset'] - $this->settings->get( 'offset' ) ) / $parameters['paging']['page_size'] ) + 1 );
632
+			$page = Utils::get( $parameters[ 'paging' ], 'current_page' ) ?: ( ( ( $parameters[ 'paging' ][ 'offset' ] - $this->settings->get( 'offset' ) ) / $parameters[ 'paging' ][ 'page_size' ] ) + 1 );
634 633
 
635 634
 			if ( gravityview()->plugin->supports( Plugin::FEATURE_GFQUERY ) ) {
636 635
 				/**
637 636
 				 * New \GF_Query stuff :)
638 637
 				 */
639
-				$query = new \GF_Query( $this->form->ID, $parameters['search_criteria'], $parameters['sorting'] );
638
+				$query = new \GF_Query( $this->form->ID, $parameters[ 'search_criteria' ], $parameters[ 'sorting' ] );
640 639
 
641
-				$query->limit( $parameters['paging']['page_size'] )
642
-					->offset( ( ( $page - 1 ) * $parameters['paging']['page_size'] ) + $this->settings->get( 'offset' ) );
640
+				$query->limit( $parameters[ 'paging' ][ 'page_size' ] )
641
+					->offset( ( ( $page - 1 ) * $parameters[ 'paging' ][ 'page_size' ] ) + $this->settings->get( 'offset' ) );
643 642
 
644 643
 				/**
645 644
 				 * Any joins?
@@ -679,15 +678,15 @@  discard block
 block discarded – undo
679 678
 				} );
680 679
 			} else {
681 680
 				$entries = $this->form->entries
682
-					->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters['search_criteria'] ) )
681
+					->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters[ 'search_criteria' ] ) )
683 682
 					->offset( $this->settings->get( 'offset' ) )
684
-					->limit( $parameters['paging']['page_size'] )
683
+					->limit( $parameters[ 'paging' ][ 'page_size' ] )
685 684
 					->page( $page );
686 685
 				
687
-				if ( ! empty( $parameters['sorting'] ) && ! empty( $parameters['sorting']['key'] ) ) {
686
+				if ( ! empty( $parameters[ 'sorting' ] ) && ! empty( $parameters[ 'sorting' ][ 'key' ] ) ) {
688 687
 					$field = new \GV\Field();
689
-					$field->ID = $parameters['sorting']['key'];
690
-					$direction = strtolower( $parameters['sorting']['direction'] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
688
+					$field->ID = $parameters[ 'sorting' ][ 'key' ];
689
+					$direction = strtolower( $parameters[ 'sorting' ][ 'direction' ] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
691 690
 					$entries = $entries->sort( new \GV\Entry_Sort( $field, $direction ) );
692 691
 				}
693 692
 			}
Please login to merge, or discard this patch.