Completed
Push — develop ( 6d1660...ace222 )
by Zack
16:17
created
includes/class-gravityview-admin-notices.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -60,21 +60,21 @@  discard block
 block discarded – undo
60 60
 	public function dismiss_notice() {
61 61
 
62 62
 		// No dismiss sent
63
-		if( empty( $_GET['gv-dismiss'] ) || empty( $_GET['notice'] ) ) {
63
+		if ( empty( $_GET[ 'gv-dismiss' ] ) || empty( $_GET[ 'notice' ] ) ) {
64 64
 			return;
65 65
 		}
66 66
 
67 67
 		// Invalid nonce
68
-		if( !wp_verify_nonce( $_GET['gv-dismiss'], 'dismiss' ) ) {
68
+		if ( ! wp_verify_nonce( $_GET[ 'gv-dismiss' ], 'dismiss' ) ) {
69 69
 			return;
70 70
 		}
71 71
 
72
-		$notice_id = esc_attr( $_GET['notice'] );
72
+		$notice_id = esc_attr( $_GET[ 'notice' ] );
73 73
 
74 74
 		//don't display a message if use has dismissed the message for this version
75 75
 		$dismissed_notices = (array)get_transient( 'gravityview_dismissed_notices' );
76 76
 
77
-		$dismissed_notices[] = $notice_id;
77
+		$dismissed_notices[ ] = $notice_id;
78 78
 
79 79
 		$dismissed_notices = array_unique( $dismissed_notices );
80 80
 
@@ -97,12 +97,12 @@  discard block
 block discarded – undo
97 97
 	private function is_notice_dismissed( $notice ) {
98 98
 
99 99
 		// There are no dismissed notices.
100
-		if( empty( self::$dismissed_notices ) ) {
100
+		if ( empty( self::$dismissed_notices ) ) {
101 101
 			return false;
102 102
 		}
103 103
 
104 104
 		// Has the
105
-		$is_dismissed = !empty( $notice['dismiss'] ) && in_array( $notice['dismiss'], self::$dismissed_notices );
105
+		$is_dismissed = ! empty( $notice[ 'dismiss' ] ) && in_array( $notice[ 'dismiss' ], self::$dismissed_notices );
106 106
 
107 107
 		return $is_dismissed ? true : false;
108 108
 	}
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
 	 */
128 128
 	private function check_show_multisite_notices() {
129 129
 
130
-		if( ! is_multisite() ) {
130
+		if ( ! is_multisite() ) {
131 131
 			return true;
132 132
 		}
133 133
 
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
 		}
138 138
 
139 139
 		// or they don't have admin capabilities
140
-		if( ! is_super_admin() ) {
140
+		if ( ! is_super_admin() ) {
141 141
 			return false;
142 142
 		}
143 143
 
@@ -160,48 +160,48 @@  discard block
 block discarded – undo
160 160
 		 */
161 161
 		$notices = apply_filters( 'gravityview/admin/notices', self::$admin_notices );
162 162
 
163
-		if( empty( $notices ) || ! $this->check_show_multisite_notices() ) {
163
+		if ( empty( $notices ) || ! $this->check_show_multisite_notices() ) {
164 164
 			return;
165 165
 		}
166 166
 
167 167
 		//don't display a message if use has dismissed the message for this version
168 168
 		// TODO: Use get_user_meta instead of get_transient
169
-		self::$dismissed_notices = isset( $_GET['show-dismissed-notices'] ) ? array() : (array)get_transient( 'gravityview_dismissed_notices' );
169
+		self::$dismissed_notices = isset( $_GET[ 'show-dismissed-notices' ] ) ? array() : (array)get_transient( 'gravityview_dismissed_notices' );
170 170
 
171 171
 		$output = '';
172 172
 
173
-		foreach( $notices as $notice ) {
173
+		foreach ( $notices as $notice ) {
174 174
 
175 175
 			// If the user doesn't have the capability to see the warning
176
-			if( isset( $notice['cap'] ) && false === GVCommon::has_cap( $notice['cap'] ) ) {
176
+			if ( isset( $notice[ 'cap' ] ) && false === GVCommon::has_cap( $notice[ 'cap' ] ) ) {
177 177
 				gravityview()->log->debug( 'Notice not shown because user does not have the capability to view it.', array( 'data' => $notice ) );
178 178
 				continue;
179 179
 			}
180 180
 
181
-			if( true === $this->is_notice_dismissed( $notice ) ) {
181
+			if ( true === $this->is_notice_dismissed( $notice ) ) {
182 182
 				gravityview()->log->debug( 'Notice not shown because the notice has already been dismissed.', array( 'data' => $notice ) );
183 183
 				continue;
184 184
 			}
185 185
 
186
-			$output .= '<div id="message" style="position:relative" class="notice '. gravityview_sanitize_html_class( $notice['class'] ).'">';
186
+			$output .= '<div id="message" style="position:relative" class="notice ' . gravityview_sanitize_html_class( $notice[ 'class' ] ) . '">';
187 187
 
188 188
 			// Too cute to leave out.
189 189
 			$output .= gravityview_get_floaty();
190 190
 
191
-			if( !empty( $notice['title'] ) ) {
192
-				$output .= '<h3>'.esc_html( $notice['title'] ) .'</h3>';
191
+			if ( ! empty( $notice[ 'title' ] ) ) {
192
+				$output .= '<h3>' . esc_html( $notice[ 'title' ] ) . '</h3>';
193 193
 			}
194 194
 
195
-			$message = isset( $notice['message'] ) ? $notice['message'] : '';
195
+			$message = isset( $notice[ 'message' ] ) ? $notice[ 'message' ] : '';
196 196
 
197
-			if( !empty( $notice['dismiss'] ) ) {
197
+			if ( ! empty( $notice[ 'dismiss' ] ) ) {
198 198
 
199
-				$dismiss = esc_attr($notice['dismiss']);
199
+				$dismiss = esc_attr( $notice[ 'dismiss' ] );
200 200
 
201 201
 				$url = esc_url( add_query_arg( array( 'gv-dismiss' => wp_create_nonce( 'dismiss' ), 'notice' => $dismiss ) ) );
202 202
 
203 203
 				$align = is_rtl() ? 'alignleft' : 'alignright';
204
-				$message .= '<a href="'.$url.'" data-notice="'.$dismiss.'" class="' . $align . ' button button-link">'.esc_html__('Dismiss', 'gravityview' ).'</a></p>';
204
+				$message .= '<a href="' . $url . '" data-notice="' . $dismiss . '" class="' . $align . ' button button-link">' . esc_html__( 'Dismiss', 'gravityview' ) . '</a></p>';
205 205
 			}
206 206
 
207 207
 			$output .= wpautop( $message );
@@ -233,14 +233,14 @@  discard block
 block discarded – undo
233 233
 	 */
234 234
 	public static function add_notice( $notice = array() ) {
235 235
 
236
-		if( !isset( $notice['message'] ) ) {
236
+		if ( ! isset( $notice[ 'message' ] ) ) {
237 237
 			gravityview()->log->error( 'Notice not set', array( 'data' => $notice ) );
238 238
 			return;
239 239
 		}
240 240
 
241
-		$notice['class'] = empty( $notice['class'] ) ? 'error' : $notice['class'];
241
+		$notice[ 'class' ] = empty( $notice[ 'class' ] ) ? 'error' : $notice[ 'class' ];
242 242
 
243
-		self::$admin_notices[] = $notice;
243
+		self::$admin_notices[ ] = $notice;
244 244
 	}
245 245
 }
246 246
 
Please login to merge, or discard this patch.
future/includes/class-gv-renderer.php 1 patch
Spacing   +4 added lines, -5 removed lines patch added patch discarded remove patch
@@ -58,8 +58,7 @@  discard block
 block discarded – undo
58 58
 				$tab = __( 'Edit Entry', 'gravityview' );
59 59
 				$context = 'edit';
60 60
 				break;
61
-			case ( $gravityview->request->is_entry( $gravityview->view->form ? $gravityview->view->form->ID : 0 ) ):
62
-				$tab = __( 'Single Entry', 'gravityview' );
61
+			case ( $gravityview->request->is_entry( $gravityview->view->form ? $gravityview->view->form->ID : 0 ) ) : $tab = __( 'Single Entry', 'gravityview' );
63 62
 				$context = 'single';
64 63
 				break;
65 64
 			default:
@@ -81,7 +80,7 @@  discard block
 block discarded – undo
81 80
 		$action_text = sprintf( esc_html__( 'Add fields to %s', 'gravityview' ), $tab );
82 81
 		$message = esc_html__( 'You can only see this message because you are able to edit this View.', 'gravityview' );
83 82
 
84
-		$image =  sprintf( '<img alt="%s" src="%s" style="margin-top: 10px;" />', $tab, esc_url( plugins_url( sprintf( 'assets/images/tab-%s.png', $context ), GRAVITYVIEW_FILE ) ) );
83
+		$image = sprintf( '<img alt="%s" src="%s" style="margin-top: 10px;" />', $tab, esc_url( plugins_url( sprintf( 'assets/images/tab-%s.png', $context ), GRAVITYVIEW_FILE ) ) );
85 84
 		$output = sprintf( '<h3>%s <strong><a href="%s">%s</a></strong></h3><p>%s</p>', $title, esc_url( $edit_link ), $action_text, $message );
86 85
 
87 86
 		echo \GVCommon::generate_notice( $output . $image, 'gv-warning warning', 'edit_gravityview', $gravityview->view->ID );
@@ -107,11 +106,11 @@  discard block
 block discarded – undo
107 106
 
108 107
 		$post_types = get_post_types();
109 108
 
110
-		foreach( $post_types as $post_type ) {
109
+		foreach ( $post_types as $post_type ) {
111 110
 			$post_type_rewrite = get_post_type_object( $post_type )->rewrite;
112 111
 
113 112
 			if ( $slug = \GV\Utils::get( $post_type_rewrite, 'slug' ) ) {
114
-				$reserved_slugs[] = $slug;
113
+				$reserved_slugs[ ] = $slug;
115 114
 			}
116 115
 		}
117 116
 
Please login to merge, or discard this patch.
future/includes/class-gv-view.php 1 patch
Spacing   +80 added lines, -81 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
 		$supports = array( 'title', 'revisions' );
126 126
 
127 127
 		if ( $is_hierarchical ) {
128
-			$supports[] = 'page-attributes';
128
+			$supports[ ] = 'page-attributes';
129 129
 		}
130 130
 
131 131
 		/**
@@ -228,11 +228,11 @@  discard block
 block discarded – undo
228 228
 		$rule = array( sprintf( '%s/([^/]+)/csv/?', $slug ), 'index.php?gravityview=$matches[1]&csv=1', 'top' );
229 229
 
230 230
 		add_filter( 'query_vars', function( $query_vars ) {
231
-			$query_vars[] = 'csv';
231
+			$query_vars[ ] = 'csv';
232 232
 			return $query_vars;
233 233
 		} );
234 234
 
235
-		if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[0] ] ) ) {
235
+		if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[ 0 ] ] ) ) {
236 236
 			call_user_func_array( 'add_rewrite_rule', $rule );
237 237
 		}
238 238
 	}
@@ -292,7 +292,7 @@  discard block
 block discarded – undo
292 292
 
293 293
 						$message = esc_html__( 'You can only see this message because you are able to edit this View.', 'gravityview' );
294 294
 
295
-						$image =  sprintf( '<img alt="%s" src="%s" style="margin-top: 10px;" />', esc_attr__( 'Data Source', 'gravityview' ), esc_url( plugins_url( 'assets/images/screenshots/data-source.png', GRAVITYVIEW_FILE ) ) );
295
+						$image = sprintf( '<img alt="%s" src="%s" style="margin-top: 10px;" />', esc_attr__( 'Data Source', 'gravityview' ), esc_url( plugins_url( 'assets/images/screenshots/data-source.png', GRAVITYVIEW_FILE ) ) );
296 296
 
297 297
 						return \GVCommon::generate_notice( '<h3>' . $title . '</h3>' . wpautop( $message . $image ), 'notice' );
298 298
 					}
@@ -318,13 +318,13 @@  discard block
 block discarded – undo
318 318
 			return $content;
319 319
 		}
320 320
 
321
-		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap('gravityview_moderate_entries', $view->ID );
321
+		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap( 'gravityview_moderate_entries', $view->ID );
322 322
 
323 323
 		/**
324 324
 		 * Editing a single entry.
325 325
 		 */
326 326
 		if ( $entry = $request->is_edit_entry( $view->form ? $view->form->ID : 0 ) ) {
327
-			if ( $entry['status'] != 'active' ) {
327
+			if ( $entry[ 'status' ] != 'active' ) {
328 328
 				gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
329 329
 				return __( 'You are not allowed to view this content.', 'gravityview' );
330 330
 			}
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
 			}
336 336
 
337 337
 			if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
338
-				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
338
+				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
339 339
 					gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
340 340
 					return __( 'You are not allowed to view this content.', 'gravityview' );
341 341
 				}
@@ -358,7 +358,7 @@  discard block
 block discarded – undo
358 358
 
359 359
 			foreach ( $entryset as $e ) {
360 360
 
361
-				if ( 'active' !== $e['status'] ) {
361
+				if ( 'active' !== $e[ 'status' ] ) {
362 362
 					gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $e->ID ) );
363 363
 					return __( 'You are not allowed to view this content.', 'gravityview' );
364 364
 				}
@@ -369,7 +369,7 @@  discard block
 block discarded – undo
369 369
 				}
370 370
 
371 371
 				if ( $show_only_approved && ! $is_admin_and_can_view ) {
372
-					if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $e->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
372
+					if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $e->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
373 373
 						gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $e->ID ) );
374 374
 						return __( 'You are not allowed to view this content.', 'gravityview' );
375 375
 					}
@@ -544,7 +544,7 @@  discard block
 block discarded – undo
544 544
 			$join_column    = is_numeric( $join_column ) ? GF_Field::by_id( $join, $join_column ) : Internal_Field::by_id( $join_column );
545 545
 			$join_on_column = is_numeric( $join_on_column ) ? GF_Field::by_id( $join_on, $join_on_column ) : Internal_Field::by_id( $join_on_column );
546 546
 
547
-			$joins [] = new Join( $join, $join_column, $join_on, $join_on_column );
547
+			$joins [ ] = new Join( $join, $join_column, $join_on, $join_on_column );
548 548
 		}
549 549
 
550 550
 		return $joins;
@@ -634,13 +634,13 @@  discard block
 block discarded – undo
634 634
 			}
635 635
 
636 636
 			foreach ( $_fields as $field ) {
637
-				if ( ! empty( $field['unions'] ) ) {
638
-					foreach ( $field['unions'] as $form_id => $field_id ) {
637
+				if ( ! empty( $field[ 'unions' ] ) ) {
638
+					foreach ( $field[ 'unions' ] as $form_id => $field_id ) {
639 639
 						if ( ! isset( $unions[ $form_id ] ) ) {
640 640
 							$unions[ $form_id ] = array();
641 641
 						}
642 642
 
643
-						$unions[ $form_id ][ $field['id'] ] =
643
+						$unions[ $form_id ][ $field[ 'id' ] ] =
644 644
 							is_numeric( $field_id ) ? \GV\GF_Field::by_id( \GV\GF_Form::by_id( $form_id ), $field_id ) : \GV\Internal_Field::by_id( $field_id );
645 645
 					}
646 646
 				}
@@ -695,7 +695,7 @@  discard block
 block discarded – undo
695 695
 		if ( ! $view->form ) {
696 696
 			gravityview()->log->error( 'View #{view_id} tried attaching non-existent Form #{form_id} to it.', array(
697 697
 				'view_id' => $view->ID,
698
-				'form_id' => $view->_gravityview_form_id ? : 0,
698
+				'form_id' => $view->_gravityview_form_id ?: 0,
699 699
 			) );
700 700
 		}
701 701
 
@@ -934,11 +934,11 @@  discard block
 block discarded – undo
934 934
 			 * Remove multiple sorting before calling legacy filters.
935 935
 			 * This allows us to fake it till we make it.
936 936
 			 */
937
-			if ( ! empty( $parameters['sort_field'] ) && is_array( $parameters['sort_field'] ) ) {
937
+			if ( ! empty( $parameters[ 'sort_field' ] ) && is_array( $parameters[ 'sort_field' ] ) ) {
938 938
 				$has_multisort = true;
939
-				$parameters['sort_field'] = reset( $parameters['sort_field'] );
940
-				if ( ! empty( $parameters['sort_direction'] ) && is_array( $parameters['sort_direction'] ) ) {
941
-					$parameters['sort_direction'] = reset( $parameters['sort_direction'] );
939
+				$parameters[ 'sort_field' ] = reset( $parameters[ 'sort_field' ] );
940
+				if ( ! empty( $parameters[ 'sort_direction' ] ) && is_array( $parameters[ 'sort_direction' ] ) ) {
941
+					$parameters[ 'sort_direction' ] = reset( $parameters[ 'sort_direction' ] );
942 942
 				}
943 943
 			}
944 944
 
@@ -947,31 +947,30 @@  discard block
 block discarded – undo
947 947
 			 */
948 948
 			$parameters = \GravityView_frontend::get_view_entries_parameters( $parameters, $this->form->ID );
949 949
 
950
-			$parameters['context_view_id'] = $this->ID;
950
+			$parameters[ 'context_view_id' ] = $this->ID;
951 951
 			$parameters = \GVCommon::calculate_get_entries_criteria( $parameters, $this->form->ID );
952 952
 
953 953
 			if ( ! is_array( $parameters ) ) {
954 954
 				$parameters = array();
955 955
 			}
956 956
 
957
-			if ( ! is_array( $parameters['search_criteria'] ) ) {
958
-				$parameters['search_criteria'] = array();
957
+			if ( ! is_array( $parameters[ 'search_criteria' ] ) ) {
958
+				$parameters[ 'search_criteria' ] = array();
959 959
 			}
960 960
 
961
-			if ( ( ! isset( $parameters['search_criteria']['field_filters'] ) ) || ( ! is_array( $parameters['search_criteria']['field_filters'] ) ) ) {
962
-				$parameters['search_criteria']['field_filters'] = array();
961
+			if ( ( ! isset( $parameters[ 'search_criteria' ][ 'field_filters' ] ) ) || ( ! is_array( $parameters[ 'search_criteria' ][ 'field_filters' ] ) ) ) {
962
+				$parameters[ 'search_criteria' ][ 'field_filters' ] = array();
963 963
 			}
964 964
 
965 965
 			if ( $request instanceof REST\Request ) {
966 966
 				$atts = $this->settings->as_atts();
967 967
 				$paging_parameters = wp_parse_args( $request->get_paging(), array(
968
-						'paging' => array( 'page_size' => $atts['page_size'] ),
968
+						'paging' => array( 'page_size' => $atts[ 'page_size' ] ),
969 969
 					) );
970
-				$parameters['paging'] = $paging_parameters['paging'];
970
+				$parameters[ 'paging' ] = $paging_parameters[ 'paging' ];
971 971
 			}
972 972
 
973
-			$page = Utils::get( $parameters['paging'], 'current_page' ) ?
974
-				: ( ( ( $parameters['paging']['offset'] - $this->settings->get( 'offset' ) ) / \GV\Utils::get( $parameters, 'paging/page_size', 25 ) ) + 1 );
973
+			$page = Utils::get( $parameters[ 'paging' ], 'current_page' ) ?: ( ( ( $parameters[ 'paging' ][ 'offset' ] - $this->settings->get( 'offset' ) ) / \GV\Utils::get( $parameters, 'paging/page_size', 25 ) ) + 1 );
975 974
 
976 975
 			/**
977 976
 			 * Cleanup duplicate field_filter parameters to simplify the query.
@@ -979,14 +978,14 @@  discard block
 block discarded – undo
979 978
 			$unique_field_filters = array();
980 979
 			foreach ( Utils::get( $parameters, 'search_criteria/field_filters', array() ) as $key => $filter ) {
981 980
 				if ( 'mode' === $key ) {
982
-					$unique_field_filters['mode'] = $filter;
981
+					$unique_field_filters[ 'mode' ] = $filter;
983 982
 				} else if ( ! in_array( $filter, $unique_field_filters ) ) {
984
-					$unique_field_filters[] = $filter;
983
+					$unique_field_filters[ ] = $filter;
985 984
 				}
986 985
 			}
987
-			$parameters['search_criteria']['field_filters'] = $unique_field_filters;
986
+			$parameters[ 'search_criteria' ][ 'field_filters' ] = $unique_field_filters;
988 987
 
989
-			if ( ! empty( $parameters['search_criteria']['field_filters'] ) ) {
988
+			if ( ! empty( $parameters[ 'search_criteria' ][ 'field_filters' ] ) ) {
990 989
 				gravityview()->log->notice( 'search_criteria/field_filters is not empty, third-party code may be using legacy search_criteria filters.' );
991 990
 			}
992 991
 
@@ -995,7 +994,7 @@  discard block
 block discarded – undo
995 994
 				$query_class = $this->get_query_class();
996 995
 
997 996
 				/** @type \GF_Query $query */
998
-				$query = new $query_class( $this->form->ID, $parameters['search_criteria'], Utils::get( $parameters, 'sorting' ) );
997
+				$query = new $query_class( $this->form->ID, $parameters[ 'search_criteria' ], Utils::get( $parameters, 'sorting' ) );
999 998
 
1000 999
 				/**
1001 1000
 				 * Apply multisort.
@@ -1006,15 +1005,15 @@  discard block
 block discarded – undo
1006 1005
 					$view_setting_sort_field_ids = \GV\Utils::get( $atts, 'sort_field', array() );
1007 1006
 					$view_setting_sort_directions = \GV\Utils::get( $atts, 'sort_direction', array() );
1008 1007
 
1009
-					$has_sort_query_param = ! empty( $_GET['sort'] ) && is_array( $_GET['sort'] );
1008
+					$has_sort_query_param = ! empty( $_GET[ 'sort' ] ) && is_array( $_GET[ 'sort' ] );
1010 1009
 
1011
-					if( $has_sort_query_param ) {
1012
-						$has_sort_query_param = array_filter( array_values( $_GET['sort'] ) );
1010
+					if ( $has_sort_query_param ) {
1011
+						$has_sort_query_param = array_filter( array_values( $_GET[ 'sort' ] ) );
1013 1012
 					}
1014 1013
 
1015 1014
 					if ( $this->settings->get( 'sort_columns' ) && $has_sort_query_param ) {
1016
-						$sort_field_ids = array_keys( $_GET['sort'] );
1017
-						$sort_directions = array_values( $_GET['sort'] );
1015
+						$sort_field_ids = array_keys( $_GET[ 'sort' ] );
1016
+						$sort_directions = array_values( $_GET[ 'sort' ] );
1018 1017
 					} else {
1019 1018
 						$sort_field_ids = $view_setting_sort_field_ids;
1020 1019
 						$sort_directions = $view_setting_sort_directions;
@@ -1022,7 +1021,7 @@  discard block
 block discarded – undo
1022 1021
 
1023 1022
 					$skip_first = false;
1024 1023
 
1025
-					foreach ( (array) $sort_field_ids as $key => $sort_field_id ) {
1024
+					foreach ( (array)$sort_field_ids as $key => $sort_field_id ) {
1026 1025
 
1027 1026
 						if ( ! $skip_first && ! $has_sort_query_param ) {
1028 1027
 							$skip_first = true; // Skip the first one, it's already in the query
@@ -1052,15 +1051,15 @@  discard block
 block discarded – undo
1052 1051
 
1053 1052
 					$merged_time = false;
1054 1053
 
1055
-					foreach ( $q['order'] as $oid => $order ) {
1056
-						if ( $order[0] instanceof \GF_Query_Column ) {
1057
-							$column = $order[0];
1058
-						} else if ( $order[0] instanceof \GF_Query_Call ) {
1059
-							if ( count( $order[0]->columns ) != 1 || ! $order[0]->columns[0] instanceof \GF_Query_Column ) {
1054
+					foreach ( $q[ 'order' ] as $oid => $order ) {
1055
+						if ( $order[ 0 ] instanceof \GF_Query_Column ) {
1056
+							$column = $order[ 0 ];
1057
+						} else if ( $order[ 0 ] instanceof \GF_Query_Call ) {
1058
+							if ( count( $order[ 0 ]->columns ) != 1 || ! $order[ 0 ]->columns[ 0 ] instanceof \GF_Query_Column ) {
1060 1059
 								$orders[ $oid ] = $order;
1061 1060
 								continue; // Need something that resembles a single sort
1062 1061
 							}
1063
-							$column = $order[0]->columns[0];
1062
+							$column = $order[ 0 ]->columns[ 0 ];
1064 1063
 						}
1065 1064
 
1066 1065
 						if ( ( ! $field = \GFAPI::get_field( $column->source, $column->field_id ) ) || $field->type !== 'time' ) {
@@ -1074,7 +1073,7 @@  discard block
 block discarded – undo
1074 1073
 
1075 1074
 						$orders[ $oid ] = array(
1076 1075
 							new \GV\Mocks\GF_Query_Call_TIMESORT( 'timesort', array( $column, $sql ) ),
1077
-							$order[1] // Mock it!
1076
+							$order[ 1 ] // Mock it!
1078 1077
 						);
1079 1078
 
1080 1079
 						$merged_time = true;
@@ -1085,15 +1084,15 @@  discard block
 block discarded – undo
1085 1084
 						 * ORDER again.
1086 1085
 						 */
1087 1086
 						if ( ! empty( $orders ) && $_orders = $query->_order_generate( $orders ) ) {
1088
-							$sql['order'] = 'ORDER BY ' . implode( ', ', $_orders );
1087
+							$sql[ 'order' ] = 'ORDER BY ' . implode( ', ', $_orders );
1089 1088
 						}
1090 1089
 					}
1091 1090
 
1092 1091
 					return $sql;
1093 1092
 				} );
1094 1093
 
1095
-				$query->limit( $parameters['paging']['page_size'] )
1096
-					->offset( ( ( $page - 1 ) * $parameters['paging']['page_size'] ) + $this->settings->get( 'offset' ) );
1094
+				$query->limit( $parameters[ 'paging' ][ 'page_size' ] )
1095
+					->offset( ( ( $page - 1 ) * $parameters[ 'paging' ][ 'page_size' ] ) + $this->settings->get( 'offset' ) );
1097 1096
 
1098 1097
 				/**
1099 1098
 				 * Any joins?
@@ -1116,7 +1115,7 @@  discard block
 block discarded – undo
1116 1115
 
1117 1116
 							$query_parameters = $query->_introspect();
1118 1117
 
1119
-							$query->where( \GF_Query_Condition::_and( $query_parameters['where'], $condition ) );
1118
+							$query->where( \GF_Query_Condition::_and( $query_parameters[ 'where' ], $condition ) );
1120 1119
 						}
1121 1120
 
1122 1121
 						/**
@@ -1150,7 +1149,7 @@  discard block
 block discarded – undo
1150 1149
 						}
1151 1150
 
1152 1151
 						$q = $query->_introspect();
1153
-						$query->where( \GF_Query_Condition::_and( $q['where'], $condition ) );
1152
+						$query->where( \GF_Query_Condition::_and( $q[ 'where' ], $condition ) );
1154 1153
 
1155 1154
 						if ( $this->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
1156 1155
 
@@ -1175,7 +1174,7 @@  discard block
 block discarded – undo
1175 1174
 
1176 1175
 							$query_parameters = $query->_introspect();
1177 1176
 
1178
-							$query->where( \GF_Query_Condition::_and( $query_parameters['where'], $condition ) );
1177
+							$query->where( \GF_Query_Condition::_and( $query_parameters[ 'where' ], $condition ) );
1179 1178
 						}
1180 1179
 					}
1181 1180
 
@@ -1199,7 +1198,7 @@  discard block
 block discarded – undo
1199 1198
 							$conditions = array();
1200 1199
 
1201 1200
 							foreach ( $condition->expressions as $_condition ) {
1202
-								$conditions[] = $recurse( $_condition, $fields, $recurse );
1201
+								$conditions[ ] = $recurse( $_condition, $fields, $recurse );
1203 1202
 							}
1204 1203
 
1205 1204
 							return call_user_func_array(
@@ -1228,10 +1227,10 @@  discard block
 block discarded – undo
1228 1227
 						$q = new $query_class( $form_id );
1229 1228
 
1230 1229
 						// Copy the WHERE clauses but substitute the field_ids to the respective ones
1231
-						$q->where( $where_union_substitute( $query_parameters['where'], $fields, $where_union_substitute ) );
1230
+						$q->where( $where_union_substitute( $query_parameters[ 'where' ], $fields, $where_union_substitute ) );
1232 1231
 
1233 1232
 						// Copy the ORDER clause and substitute the field_ids to the respective ones
1234
-						foreach ( $query_parameters['order'] as $order ) {
1233
+						foreach ( $query_parameters[ 'order' ] as $order ) {
1235 1234
 							list( $column, $_order ) = $order;
1236 1235
 
1237 1236
 							if ( $column && $column instanceof \GF_Query_Column ) {
@@ -1245,15 +1244,15 @@  discard block
 block discarded – undo
1245 1244
 
1246 1245
 						add_filter( 'gform_gf_query_sql', $gf_query_sql_callback = function( $sql ) use ( &$unions_sql ) {
1247 1246
 							// Remove SQL_CALC_FOUND_ROWS as it's not needed in UNION clauses
1248
-							$select = 'UNION ALL ' . str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql['select'] );
1247
+							$select = 'UNION ALL ' . str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql[ 'select' ] );
1249 1248
 
1250 1249
 							// Record the SQL
1251
-							$unions_sql[] = array(
1250
+							$unions_sql[ ] = array(
1252 1251
 								// Remove columns, we'll rebuild them
1253 1252
 								'select'  => preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $select ),
1254
-								'from'    => $sql['from'],
1255
-								'join'    => $sql['join'],
1256
-								'where'   => $sql['where'],
1253
+								'from'    => $sql[ 'from' ],
1254
+								'join'    => $sql[ 'join' ],
1255
+								'where'   => $sql[ 'where' ],
1257 1256
 								// Remove order and limit
1258 1257
 							);
1259 1258
 
@@ -1270,11 +1269,11 @@  discard block
 block discarded – undo
1270 1269
 
1271 1270
 					add_filter( 'gform_gf_query_sql', $gf_query_sql_callback = function( $sql ) use ( $unions_sql ) {
1272 1271
 						// Remove SQL_CALC_FOUND_ROWS as it's not needed in UNION clauses
1273
-						$sql['select'] = str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql['select'] );
1272
+						$sql[ 'select' ] = str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql[ 'select' ] );
1274 1273
 
1275 1274
 						// Remove columns, we'll rebuild them
1276
-						preg_match( '#DISTINCT (`[motc]\d+`.`.*?`)#', $sql['select'], $select_match );
1277
-						$sql['select'] = preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $sql['select'] );
1275
+						preg_match( '#DISTINCT (`[motc]\d+`.`.*?`)#', $sql[ 'select' ], $select_match );
1276
+						$sql[ 'select' ] = preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $sql[ 'select' ] );
1278 1277
 
1279 1278
 						$unions = array();
1280 1279
 
@@ -1285,30 +1284,30 @@  discard block
 block discarded – undo
1285 1284
 						};
1286 1285
 
1287 1286
 						// Add all the order columns into the selects, so we can order by the whole union group
1288
-						preg_match_all( '#(`[motc]\d+`.`.*?`)#', $sql['order'], $order_matches );
1287
+						preg_match_all( '#(`[motc]\d+`.`.*?`)#', $sql[ 'order' ], $order_matches );
1289 1288
 
1290 1289
 						$columns = array(
1291
-							sprintf( '%s AS %s', $select_match[1], $column_to_alias( $select_match[1] ) )
1290
+							sprintf( '%s AS %s', $select_match[ 1 ], $column_to_alias( $select_match[ 1 ] ) )
1292 1291
 						);
1293 1292
 
1294 1293
 						foreach ( array_slice( $order_matches, 1 ) as $match ) {
1295
-							$columns[] = sprintf( '%s AS %s', $match[0], $column_to_alias( $match[0] ) );
1294
+							$columns[ ] = sprintf( '%s AS %s', $match[ 0 ], $column_to_alias( $match[ 0 ] ) );
1296 1295
 
1297 1296
 							// Rewrite the order columns to the shared aliases
1298
-							$sql['order'] = str_replace( $match[0], $column_to_alias( $match[0] ), $sql['order'] );
1297
+							$sql[ 'order' ] = str_replace( $match[ 0 ], $column_to_alias( $match[ 0 ] ), $sql[ 'order' ] );
1299 1298
 						}
1300 1299
 
1301 1300
 						$columns = array_unique( $columns );
1302 1301
 
1303 1302
 						// Add the columns to every UNION
1304 1303
 						foreach ( $unions_sql as $union_sql ) {
1305
-							$union_sql['select'] .= implode( ', ', $columns );
1306
-							$unions []= implode( ' ', $union_sql );
1304
+							$union_sql[ 'select' ] .= implode( ', ', $columns );
1305
+							$unions [ ] = implode( ' ', $union_sql );
1307 1306
 						}
1308 1307
 
1309 1308
 						// Add the columns to the main SELECT, but only grab the entry id column
1310
-						$sql['select'] = 'SELECT SQL_CALC_FOUND_ROWS t1_id FROM (' . $sql['select'] . implode( ', ', $columns );
1311
-						$sql['order'] = implode( ' ', $unions ) . ') AS u ' . $sql['order'];
1309
+						$sql[ 'select' ] = 'SELECT SQL_CALC_FOUND_ROWS t1_id FROM (' . $sql[ 'select' ] . implode( ', ', $columns );
1310
+						$sql[ 'order' ] = implode( ' ', $unions ) . ') AS u ' . $sql[ 'order' ];
1312 1311
 
1313 1312
 						return $sql;
1314 1313
 					} );
@@ -1353,20 +1352,20 @@  discard block
 block discarded – undo
1353 1352
 				} );
1354 1353
 			} else {
1355 1354
 				$entries = $this->form->entries
1356
-					->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters['search_criteria'] ) )
1355
+					->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters[ 'search_criteria' ] ) )
1357 1356
 					->offset( $this->settings->get( 'offset' ) )
1358
-					->limit( $parameters['paging']['page_size'] )
1357
+					->limit( $parameters[ 'paging' ][ 'page_size' ] )
1359 1358
 					->page( $page );
1360 1359
 
1361
-				if ( ! empty( $parameters['sorting'] ) && is_array( $parameters['sorting'] && ! isset( $parameters['sorting']['key'] ) ) ) {
1360
+				if ( ! empty( $parameters[ 'sorting' ] ) && is_array( $parameters[ 'sorting' ] && ! isset( $parameters[ 'sorting' ][ 'key' ] ) ) ) {
1362 1361
 					// Pluck off multisort arrays
1363
-					$parameters['sorting'] = $parameters['sorting'][0];
1362
+					$parameters[ 'sorting' ] = $parameters[ 'sorting' ][ 0 ];
1364 1363
 				}
1365 1364
 
1366
-				if ( ! empty( $parameters['sorting'] ) && ! empty( $parameters['sorting']['key'] ) ) {
1365
+				if ( ! empty( $parameters[ 'sorting' ] ) && ! empty( $parameters[ 'sorting' ][ 'key' ] ) ) {
1367 1366
 					$field = new \GV\Field();
1368
-					$field->ID = $parameters['sorting']['key'];
1369
-					$direction = strtolower( $parameters['sorting']['direction'] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
1367
+					$field->ID = $parameters[ 'sorting' ][ 'key' ];
1368
+					$direction = strtolower( $parameters[ 'sorting' ][ 'direction' ] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
1370 1369
 					$entries = $entries->sort( new \GV\Entry_Sort( $field, $direction ) );
1371 1370
 				}
1372 1371
 			}
@@ -1441,7 +1440,7 @@  discard block
 block discarded – undo
1441 1440
 		$allowed = $headers = array();
1442 1441
 
1443 1442
 		foreach ( $view->fields->by_position( "directory_*" )->by_visible( $view )->all() as $id => $field ) {
1444
-			$allowed[] = $field;
1443
+			$allowed[ ] = $field;
1445 1444
 		}
1446 1445
 
1447 1446
 		$renderer = new Field_Renderer();
@@ -1463,17 +1462,17 @@  discard block
 block discarded – undo
1463 1462
 			} );
1464 1463
 
1465 1464
 			foreach ( array_diff( $allowed_field_ids, wp_list_pluck( $allowed, 'ID' ) ) as $field_id ) {
1466
-				$allowed[] = is_numeric( $field_id ) ? \GV\GF_Field::by_id( $view->form, $field_id ) : \GV\Internal_Field::by_id( $field_id );
1465
+				$allowed[ ] = is_numeric( $field_id ) ? \GV\GF_Field::by_id( $view->form, $field_id ) : \GV\Internal_Field::by_id( $field_id );
1467 1466
 			}
1468 1467
 
1469 1468
 			foreach ( $allowed as $field ) {
1470 1469
 				$source = is_numeric( $field->ID ) ? $view->form : new \GV\Internal_Source();
1471 1470
 
1472
-				$return[] = $renderer->render( $field, $view, $source, $entry, gravityview()->request, '\GV\Field_CSV_Template' );
1471
+				$return[ ] = $renderer->render( $field, $view, $source, $entry, gravityview()->request, '\GV\Field_CSV_Template' );
1473 1472
 
1474 1473
 				if ( ! $headers_done ) {
1475 1474
 					$label = $field->get_label( $view, $source, $entry );
1476
-					$headers[] = $label ? $label : $field->ID;
1475
+					$headers[ ] = $label ? $label : $field->ID;
1477 1476
 				}
1478 1477
 			}
1479 1478
 
Please login to merge, or discard this patch.