Completed
Pull Request — master (#1409)
by
unknown
19:34
created
includes/extensions/edit-entry/class-edit-entry-locking.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
 			return;
57 57
 		}
58 58
 
59
-		$min = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG || isset( $_GET['gform_debug'] ) ? '' : '.min';
59
+		$min = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG || isset( $_GET[ 'gform_debug' ] ) ? '' : '.min';
60 60
 		$locking_path = GFCommon::get_base_url() . '/includes/locking/';
61 61
 
62 62
 		wp_enqueue_script( 'gforms_locking', $locking_path . "js/locking{$min}.js", array( 'jquery', 'heartbeat' ), GFCommon::$version );
@@ -65,20 +65,20 @@  discard block
 block discarded – undo
65 65
 		$translations = array_map( 'wp_strip_all_tags', $this->get_strings() );
66 66
 
67 67
 		$strings = array(
68
-			'noResponse'    => $translations['no_response'],
69
-			'requestAgain'  => $translations['request_again'],
70
-			'requestError'  => $translations['request_error'],
71
-			'gainedControl' => $translations['gained_control'],
72
-			'rejected'      => $translations['request_rejected'],
73
-			'pending'       => $translations['request_pending'],
68
+			'noResponse'    => $translations[ 'no_response' ],
69
+			'requestAgain'  => $translations[ 'request_again' ],
70
+			'requestError'  => $translations[ 'request_error' ],
71
+			'gainedControl' => $translations[ 'gained_control' ],
72
+			'rejected'      => $translations[ 'request_rejected' ],
73
+			'pending'       => $translations[ 'request_pending' ],
74 74
 		);
75 75
 
76
-		$lock_user_id = $this->check_lock( $entry['id'] );
76
+		$lock_user_id = $this->check_lock( $entry[ 'id' ] );
77 77
 
78 78
 		$vars = array(
79 79
 			'hasLock'    => ! $lock_user_id ? 1 : 0,
80 80
 			'lockUI'     => $this->get_lock_ui( $lock_user_id ),
81
-			'objectID'   => $entry['id'],
81
+			'objectID'   => $entry[ 'id' ],
82 82
 			'objectType' => 'entry',
83 83
 			'strings'    => $strings,
84 84
 		);
@@ -206,11 +206,11 @@  discard block
 block discarded – undo
206 206
 
207 207
 		$current_url = add_query_arg( $wp->query_string, '', home_url( $wp->request ) );
208 208
 
209
-		if ( isset( $_GET['get-edit-lock'] ) ) {
209
+		if ( isset( $_GET[ 'get-edit-lock' ] ) ) {
210 210
 			$this->set_lock( $entry_id );
211 211
 			echo '<script>window.location = ' . json_encode( remove_query_arg( 'get-edit-lock', $current_url ) ) . ';</script>';
212 212
 			exit();
213
-		} else if ( isset( $_GET['release-edit-lock'] ) ) {
213
+		} else if ( isset( $_GET[ 'release-edit-lock' ] ) ) {
214 214
 			$this->delete_lock_meta( $entry_id );
215 215
 			$current_url = remove_query_arg( 'edit', $current_url );
216 216
 			echo '<script>window.location = ' . json_encode( remove_query_arg( 'release-edit-lock', $current_url ) ) . ';</script>';
Please login to merge, or discard this patch.
includes/class-gravityview-logging.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -7,9 +7,9 @@  discard block
 block discarded – undo
7 7
 
8 8
 	function __construct() {
9 9
 
10
-		add_action( 'gravityview_log_error', array( $this, 'log_error'), 10, 2 );
10
+		add_action( 'gravityview_log_error', array( $this, 'log_error' ), 10, 2 );
11 11
 
12
-		add_action( 'gravityview_log_debug', array( $this, 'log_debug'), 10, 2 );
12
+		add_action( 'gravityview_log_debug', array( $this, 'log_debug' ), 10, 2 );
13 13
 
14 14
 		// Enable debug with Gravity Forms Logging Add-on
15 15
 	    add_filter( 'gform_logging_supported', array( $this, 'enable_gform_logging' ) );
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 			include_once( GRAVITYVIEW_DIR . 'includes/class-debug-bar.php' );
35 35
 		}
36 36
 
37
-		$panels[] = new GravityView_Debug_Bar;
37
+		$panels[ ] = new GravityView_Debug_Bar;
38 38
 
39 39
 		return $panels;
40 40
 	}
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
 	 * @param array $supported_plugins List of plugins
45 45
 	 */
46 46
 	public function enable_gform_logging( $supported_plugins ) {
47
-	    $supported_plugins['gravityview'] = 'GravityView';
47
+	    $supported_plugins[ 'gravityview' ] = 'GravityView';
48 48
 	    return $supported_plugins;
49 49
 	}
50 50
 
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 	 * @return string "print_r" or "var_export"
73 73
 	 */
74 74
 	static function get_print_function() {
75
-		if( ob_get_level() > 0 ) {
75
+		if ( ob_get_level() > 0 ) {
76 76
 			$function = 'var_export';
77 77
 		} else {
78 78
 			$function = 'print_r';
@@ -90,17 +90,17 @@  discard block
 block discarded – undo
90 90
 			'data' => $data,
91 91
 		);
92 92
 
93
-		if( !in_array( $notice, self::$notices ) ) {
94
-			self::$notices[] = $notice;
93
+		if ( ! in_array( $notice, self::$notices ) ) {
94
+			self::$notices[ ] = $notice;
95 95
 		}
96 96
 
97
-		if ( class_exists("GFLogging") ) {
97
+		if ( class_exists( "GFLogging" ) ) {
98 98
 			GFLogging::include_logger();
99
-	        GFLogging::log_message( 'gravityview', $function( $message, true ) . $function($data, true), KLogger::DEBUG );
99
+	        GFLogging::log_message( 'gravityview', $function( $message, true ) . $function( $data, true ), KLogger::DEBUG );
100 100
 	    }
101 101
 	}
102 102
 
103
-	static function log_error( $message = '', $data = null  ) {
103
+	static function log_error( $message = '', $data = null ) {
104 104
 
105 105
 		$function = self::get_print_function();
106 106
 
@@ -110,13 +110,13 @@  discard block
 block discarded – undo
110 110
 			'backtrace' => function_exists( 'wp_debug_backtrace_summary' ) ? wp_debug_backtrace_summary( null, 3 ) : '',
111 111
 		);
112 112
 
113
-		if( !in_array( $error, self::$errors ) ) {
114
-			self::$errors[] = $error;
113
+		if ( ! in_array( $error, self::$errors ) ) {
114
+			self::$errors[ ] = $error;
115 115
 		}
116 116
 
117
-		if ( class_exists("GFLogging") ) {
117
+		if ( class_exists( "GFLogging" ) ) {
118 118
 		    GFLogging::include_logger();
119
-		    GFLogging::log_message( 'gravityview', $function ( $message, true ) . $function ( $error, true), KLogger::ERROR );
119
+		    GFLogging::log_message( 'gravityview', $function( $message, true ) . $function( $error, true ), KLogger::ERROR );
120 120
 		}
121 121
 	}
122 122
 
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
 	 */
134 134
 	static function is_logging_active( $plugin = 'gravityview' ) {
135 135
 
136
-		if( ! class_exists( 'GFLogging') ) {
136
+		if ( ! class_exists( 'GFLogging' ) ) {
137 137
 			return false;
138 138
 		}
139 139
 
Please login to merge, or discard this patch.
includes/extensions/duplicate-entry/class-duplicate-entry.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
 	 */
247 247
 	public static function get_duplicate_link( $entry, $view_id, $post_id = null ) {
248 248
 
249
-        $base = GravityView_API::directory_link( $post_id ? : $view_id, true );
249
+		$base = GravityView_API::directory_link( $post_id ? : $view_id, true );
250 250
 
251 251
 		if ( empty( $base ) ) {
252 252
 			gravityview()->log->error( 'Post ID does not exist: {post_id}', array( 'post_id' => $post_id ) );
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
 			'action'	=> 'duplicate',
258 258
 			'entry_id'	=> $entry['id'],
259 259
 			'gvid' => $view_id,
260
-            'view_id' => $view_id,
260
+			'view_id' => $view_id,
261 261
 		), $base );
262 262
 
263 263
 		return add_query_arg( 'duplicate', wp_create_nonce( self::get_nonce_key( $entry['id'] ) ), $actionurl );
@@ -460,7 +460,7 @@  discard block
 block discarded – undo
460 460
 		 * @since 2.5
461 461
 		 * @param  array $duplicated_entry The duplicated entry
462 462
 		 * @param  array $entry The original entry
463
-		*/
463
+		 */
464 464
 		do_action( 'gravityview/duplicate-entry/duplicated', $duplicated_entry, $entry );
465 465
 
466 466
 		gravityview()->log->debug( 'Duplicate response: {duplicate_response}', array( 'duplicate_response' => $duplicate_response ) );
Please login to merge, or discard this patch.
Spacing   +51 added lines, -51 removed lines patch added patch discarded remove patch
@@ -115,12 +115,12 @@  discard block
 block discarded – undo
115 115
 	public function duplicate_link_field_options( $field_options, $template_id, $field_id, $context, $input_type ) {
116 116
 
117 117
 		// Always a link, never a filter, always same window
118
-		unset( $field_options['show_as_link'], $field_options['search_filter'], $field_options['new_window'] );
118
+		unset( $field_options[ 'show_as_link' ], $field_options[ 'search_filter' ], $field_options[ 'new_window' ] );
119 119
 
120 120
 		// Duplicate Entry link should only appear to visitors capable of editing entries
121
-		unset( $field_options['only_loggedin'], $field_options['only_loggedin_cap'] );
121
+		unset( $field_options[ 'only_loggedin' ], $field_options[ 'only_loggedin_cap' ] );
122 122
 
123
-		$add_option['duplicate_link'] = array(
123
+		$add_option[ 'duplicate_link' ] = array(
124 124
 			'type' => 'text',
125 125
 			'label' => __( 'Duplicate Link Text', 'gravityview' ),
126 126
 			'desc' => NULL,
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
 			'merge_tags' => true,
129 129
 		);
130 130
 
131
-		$field_options['allow_duplicate_cap'] = array(
131
+		$field_options[ 'allow_duplicate_cap' ] = array(
132 132
 			'type' => 'select',
133 133
 			'label' => __( 'Allow the following users to duplicate the entry:', 'gravityview' ),
134 134
 			'choices' => GravityView_Render_Settings::get_cap_choices( $template_id, $field_id, $context, $input_type ),
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
 	public function add_default_field( $entry_default_fields, $form = array(), $zone = '' ) {
156 156
 
157 157
 		if ( 'edit' !== $zone ) {
158
-			$entry_default_fields['duplicate_link'] = array(
158
+			$entry_default_fields[ 'duplicate_link' ] = array(
159 159
 				'label' => __( 'Duplicate Entry', 'gravityview' ),
160 160
 				'type'  => 'duplicate_link',
161 161
 				'desc'  => __( 'A link to duplicate the entry. Respects the Duplicate Entry permissions.', 'gravityview' ),
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
 	 */
177 177
 	public function add_available_field( $available_fields = array() ) {
178 178
 
179
-		$available_fields['duplicate_link'] = array(
179
+		$available_fields[ 'duplicate_link' ] = array(
180 180
 			'label_text' => __( 'Duplicate Entry', 'gravityview' ),
181 181
 			'field_id' => 'duplicate_link',
182 182
 			'label_type' => 'field',
@@ -209,9 +209,9 @@  discard block
 block discarded – undo
209 209
 		if ( 'duplicate_link' === $field_id ) {
210 210
 
211 211
 			// Remove other built-in caps.
212
-			unset( $caps['publish_posts'], $caps['gravityforms_view_entries'], $caps['duplicate_others_posts'] );
212
+			unset( $caps[ 'publish_posts' ], $caps[ 'gravityforms_view_entries' ], $caps[ 'duplicate_others_posts' ] );
213 213
 
214
-			$caps['read'] = _x( 'Entry Creator', 'User capability', 'gravityview' );
214
+			$caps[ 'read' ] = _x( 'Entry Creator', 'User capability', 'gravityview' );
215 215
 		}
216 216
 
217 217
 		return $caps;
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
 	 */
247 247
 	public static function get_duplicate_link( $entry, $view_id, $post_id = null ) {
248 248
 
249
-        $base = GravityView_API::directory_link( $post_id ? : $view_id, true );
249
+        $base = GravityView_API::directory_link( $post_id ?: $view_id, true );
250 250
 
251 251
 		if ( empty( $base ) ) {
252 252
 			gravityview()->log->error( 'Post ID does not exist: {post_id}', array( 'post_id' => $post_id ) );
@@ -255,12 +255,12 @@  discard block
 block discarded – undo
255 255
 
256 256
 		$actionurl = add_query_arg( array(
257 257
 			'action'	=> 'duplicate',
258
-			'entry_id'	=> $entry['id'],
258
+			'entry_id'	=> $entry[ 'id' ],
259 259
 			'gvid' => $view_id,
260 260
             'view_id' => $view_id,
261 261
 		), $base );
262 262
 
263
-		return add_query_arg( 'duplicate', wp_create_nonce( self::get_nonce_key( $entry['id'] ) ), $actionurl );
263
+		return add_query_arg( 'duplicate', wp_create_nonce( self::get_nonce_key( $entry[ 'id' ] ) ), $actionurl );
264 264
 	}
265 265
 
266 266
 	/**
@@ -281,12 +281,12 @@  discard block
 block discarded – undo
281 281
 	public function process_duplicate() {
282 282
 
283 283
 		// If the form is submitted
284
-		if ( ! isset( $_GET['action'] ) || 'duplicate' !== $_GET['action'] || ! isset( $_GET['entry_id'] ) ) {
284
+		if ( ! isset( $_GET[ 'action' ] ) || 'duplicate' !== $_GET[ 'action' ] || ! isset( $_GET[ 'entry_id' ] ) ) {
285 285
 			return;
286 286
 		}
287 287
 
288 288
 		// Make sure it's a GravityView request
289
-		$valid_nonce_key = wp_verify_nonce( \GV\Utils::_GET( 'duplicate' ), self::get_nonce_key( $_GET['entry_id'] ) );
289
+		$valid_nonce_key = wp_verify_nonce( \GV\Utils::_GET( 'duplicate' ), self::get_nonce_key( $_GET[ 'entry_id' ] ) );
290 290
 
291 291
 		if ( ! $valid_nonce_key ) {
292 292
 			gravityview()->log->debug( 'Duplicate entry not processed: nonce validation failed.' );
@@ -294,7 +294,7 @@  discard block
 block discarded – undo
294 294
 		}
295 295
 
296 296
 		// Get the entry slug
297
-		$entry_slug = esc_attr( $_GET['entry_id'] );
297
+		$entry_slug = esc_attr( $_GET[ 'entry_id' ] );
298 298
 
299 299
 		// See if there's an entry there
300 300
 		$entry = gravityview_get_entry( $entry_slug, true, false );
@@ -388,15 +388,15 @@  discard block
 block discarded – undo
388 388
 			return new WP_Error( 'gravityview-duplicate-entry-missing', __( 'The entry does not exist.', 'gravityview' ) );
389 389
 		}
390 390
 
391
-		$row['id'] = null;
392
-		$row['date_created'] = date( 'Y-m-d H:i:s', time() );
393
-		$row['date_updated'] = $row['date_created'];
394
-		$row['is_starred'] = false;
395
-		$row['is_read'] = false;
396
-		$row['ip'] = GFFormsModel::get_ip();
397
-		$row['source_url'] = esc_url_raw( remove_query_arg( array( 'action', 'gvid' ) ) );
398
-		$row['user_agent'] = \GV\Utils::_SERVER( 'HTTP_USER_AGENT' );
399
-		$row['created_by'] = wp_get_current_user()->ID;
391
+		$row[ 'id' ] = null;
392
+		$row[ 'date_created' ] = date( 'Y-m-d H:i:s', time() );
393
+		$row[ 'date_updated' ] = $row[ 'date_created' ];
394
+		$row[ 'is_starred' ] = false;
395
+		$row[ 'is_read' ] = false;
396
+		$row[ 'ip' ] = GFFormsModel::get_ip();
397
+		$row[ 'source_url' ] = esc_url_raw( remove_query_arg( array( 'action', 'gvid' ) ) );
398
+		$row[ 'user_agent' ] = \GV\Utils::_SERVER( 'HTTP_USER_AGENT' );
399
+		$row[ 'created_by' ] = wp_get_current_user()->ID;
400 400
 
401 401
 		/**
402 402
 		 * @filter `gravityview/entry/duplicate/details` Modify the new entry details before it's created.
@@ -424,15 +424,15 @@  discard block
 block discarded – undo
424 424
 
425 425
 		$save_this_meta = array();
426 426
 		foreach ( $duplicate_meta->get_output() as $m ) {
427
-			$save_this_meta[] = array(
428
-				'meta_key' => $m['meta_key'],
429
-				'meta_value' => $m['meta_value'],
430
-				'item_index' => $m['item_index'],
427
+			$save_this_meta[ ] = array(
428
+				'meta_key' => $m[ 'meta_key' ],
429
+				'meta_value' => $m[ 'meta_value' ],
430
+				'item_index' => $m[ 'item_index' ],
431 431
 			);
432 432
 		}
433 433
 
434 434
 		// Update the row ID for later usage
435
-		$row['id'] = $duplicated_id;
435
+		$row[ 'id' ] = $duplicated_id;
436 436
 
437 437
 		/**
438 438
 		 * @filter `gravityview/entry/duplicate/meta` Modify the new entry meta details.
@@ -443,8 +443,8 @@  discard block
 block discarded – undo
443 443
 		$save_this_meta = apply_filters( 'gravityview/entry/duplicate/meta', $save_this_meta, $row, $entry );
444 444
 
445 445
 		foreach ( $save_this_meta as $data ) {
446
-			$data['form_id'] = $entry['form_id'];
447
-			$data['entry_id'] = $duplicated_id;
446
+			$data[ 'form_id' ] = $entry[ 'form_id' ];
447
+			$data[ 'entry_id' ] = $duplicated_id;
448 448
 
449 449
 			if ( ! $wpdb->insert( $entry_meta_table, $data ) ) {
450 450
 				return new WP_Error( 'gravityview-duplicate-entry-db-meta', __( 'There was an error duplicating the entry.', 'gravityview' ) );
@@ -478,13 +478,13 @@  discard block
 block discarded – undo
478 478
 	public function verify_nonce() {
479 479
 
480 480
 		// No duplicate entry request was made
481
-		if ( empty( $_GET['entry_id'] ) || empty( $_GET['duplicate'] ) ) {
481
+		if ( empty( $_GET[ 'entry_id' ] ) || empty( $_GET[ 'duplicate' ] ) ) {
482 482
 			return false;
483 483
 		}
484 484
 
485
-		$nonce_key = self::get_nonce_key( $_GET['entry_id'] );
485
+		$nonce_key = self::get_nonce_key( $_GET[ 'entry_id' ] );
486 486
 
487
-		$valid = wp_verify_nonce( $_GET['duplicate'], $nonce_key );
487
+		$valid = wp_verify_nonce( $_GET[ 'duplicate' ], $nonce_key );
488 488
 
489 489
 		/**
490 490
 		 * @filter `gravityview/duplicate-entry/verify_nonce` Override Duplicate Entry nonce validation. Return true to declare nonce valid.
@@ -520,7 +520,7 @@  discard block
 block discarded – undo
520 520
 			return '';
521 521
 		}
522 522
 
523
-		return 'return window.confirm(\''. esc_js( $confirm ) .'\');';
523
+		return 'return window.confirm(\'' . esc_js( $confirm ) . '\');';
524 524
 	}
525 525
 
526 526
 	/**
@@ -574,7 +574,7 @@  discard block
 block discarded – undo
574 574
 	public static function check_user_cap_duplicate_entry( $entry, $field = array(), $view_id = 0 ) {
575 575
 		$current_user = wp_get_current_user();
576 576
 
577
-		$entry_id = isset( $entry['id'] ) ? $entry['id'] : null;
577
+		$entry_id = isset( $entry[ 'id' ] ) ? $entry[ 'id' ] : null;
578 578
 
579 579
 		// Or if they can duplicate any entries (as defined in Gravity Forms), we're good.
580 580
 		if ( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gform_full_access', 'gravityview_full_access' ), $entry_id ) ) {
@@ -589,17 +589,17 @@  discard block
 block discarded – undo
589 589
 		if ( ! empty( $field ) ) {
590 590
 
591 591
 			// If capability is not defined, something is not right!
592
-			if ( empty( $field['allow_duplicate_cap'] ) ) {
592
+			if ( empty( $field[ 'allow_duplicate_cap' ] ) ) {
593 593
 
594 594
 				gravityview()->log->error( 'Cannot read duplicate entry field caps', array( 'data' => $field ) );
595 595
 
596 596
 				return false;
597 597
 			}
598 598
 
599
-			if ( GVCommon::has_cap( $field['allow_duplicate_cap'] ) ) {
599
+			if ( GVCommon::has_cap( $field[ 'allow_duplicate_cap' ] ) ) {
600 600
 
601 601
 				// Do not return true if cap is read, as we need to check if the current user created the entry
602
-				if ( 'read' !== $field['allow_duplicate_cap'] ) {
602
+				if ( 'read' !== $field[ 'allow_duplicate_cap' ] ) {
603 603
 					return true;
604 604
 				}
605 605
 
@@ -612,7 +612,7 @@  discard block
 block discarded – undo
612 612
 
613 613
 		}
614 614
 
615
-		if ( ! isset( $entry['created_by'] ) ) {
615
+		if ( ! isset( $entry[ 'created_by' ] ) ) {
616 616
 
617 617
 			gravityview()->log->error( 'Cannot duplicate entry; entry `created_by` doesn\'t exist.' );
618 618
 
@@ -637,7 +637,7 @@  discard block
 block discarded – undo
637 637
 		}
638 638
 
639 639
 		// If the logged-in user is the same as the user who created the entry, we're good.
640
-		if ( is_user_logged_in() && intval( $current_user->ID ) === intval( $entry['created_by'] ) ) {
640
+		if ( is_user_logged_in() && intval( $current_user->ID ) === intval( $entry[ 'created_by' ] ) ) {
641 641
 
642 642
 			gravityview()->log->debug( 'User {user_id} created the entry.', array( 'user_id' => $current_user->ID ) );
643 643
 
@@ -661,12 +661,12 @@  discard block
 block discarded – undo
661 661
 	 * @return void
662 662
 	 */
663 663
 	public function maybe_display_message( $current_view_id = 0 ) {
664
-		if ( empty( $_GET['status'] ) || ! self::verify_nonce() ) {
664
+		if ( empty( $_GET[ 'status' ] ) || ! self::verify_nonce() ) {
665 665
 			return;
666 666
 		}
667 667
 
668 668
 		// Entry wasn't duplicated from current View
669
-		if ( isset( $_GET['view_id'] ) && ( intval( $_GET['view_id'] ) !== intval( $current_view_id ) ) ) {
669
+		if ( isset( $_GET[ 'view_id' ] ) && ( intval( $_GET[ 'view_id' ] ) !== intval( $current_view_id ) ) ) {
670 670
 			return;
671 671
 		}
672 672
 
@@ -674,11 +674,11 @@  discard block
 block discarded – undo
674 674
 	}
675 675
 
676 676
 	public function display_message() {
677
-		if ( empty( $_GET['status'] ) || empty( $_GET['duplicate'] ) ) {
677
+		if ( empty( $_GET[ 'status' ] ) || empty( $_GET[ 'duplicate' ] ) ) {
678 678
 			return;
679 679
 		}
680 680
 
681
-		$status = esc_attr( $_GET['status'] );
681
+		$status = esc_attr( $_GET[ 'status' ] );
682 682
 		$message_from_url = \GV\Utils::_GET( 'message' );
683 683
 		$message_from_url = rawurldecode( stripslashes_deep( $message_from_url ) );
684 684
 		$class = '';
@@ -704,7 +704,7 @@  discard block
 block discarded – undo
704 704
 		$message = apply_filters( 'gravityview/duplicate-entry/message', esc_attr( $message ), $status, $message_from_url );
705 705
 
706 706
 		// DISPLAY ERROR/SUCCESS MESSAGE
707
-		echo '<div class="gv-notice' . esc_attr( $class ) .'">'. $message .'</div>';
707
+		echo '<div class="gv-notice' . esc_attr( $class ) . '">' . $message . '</div>';
708 708
 	}
709 709
 
710 710
 	/**
@@ -735,7 +735,7 @@  discard block
 block discarded – undo
735 735
 		?>
736 736
 		<span class="duplicate">
737 737
 			|
738
-			<a href="<?php echo wp_nonce_url( add_query_arg( 'entry_id', $entry['id'] ), self::get_nonce_key( $entry['id'] ), 'duplicate' ); ?>"><?php esc_html_e( 'Duplicate', 'gravityview' ); ?></a>
738
+			<a href="<?php echo wp_nonce_url( add_query_arg( 'entry_id', $entry[ 'id' ] ), self::get_nonce_key( $entry[ 'id' ] ), 'duplicate' ); ?>"><?php esc_html_e( 'Duplicate', 'gravityview' ); ?></a>
739 739
 		</span>
740 740
 		<?php
741 741
 	}
@@ -757,9 +757,9 @@  discard block
 block discarded – undo
757 757
 
758 758
 		if ( 'success' === \GV\Utils::_GET( 'result' ) ) {
759 759
 			add_filter( 'gform_admin_messages', function( $messages ) {
760
-				$messages = (array) $messages;
760
+				$messages = (array)$messages;
761 761
 
762
-				$messages[] = esc_html__( 'Entry duplicated.', 'gravityview' );
762
+				$messages[ ] = esc_html__( 'Entry duplicated.', 'gravityview' );
763 763
 				return $messages;
764 764
 			} );
765 765
 		}
@@ -770,7 +770,7 @@  discard block
 block discarded – undo
770 770
 
771 771
 			$check_logs_message = '';
772 772
 
773
-			if( $is_logging_active ) {
773
+			if ( $is_logging_active ) {
774 774
 				$check_logs_message = sprintf( ' <a href="%s">%s</a>',
775 775
 					esc_url( admin_url( 'admin.php?page=gf_settings&subview=gravityformslogging' ) ),
776 776
 					esc_html_x( 'Check the GravityView logs for more information.', 'Error message links to logging page', 'gravityview' )
@@ -778,9 +778,9 @@  discard block
 block discarded – undo
778 778
 			}
779 779
 
780 780
 			add_filter( 'gform_admin_error_messages', function( $messages ) use ( $check_logs_message ) {
781
-				$messages = (array) $messages;
781
+				$messages = (array)$messages;
782 782
 
783
-				$messages[] = esc_html__( 'There was an error duplicating the entry.', 'gravityview' ) . $check_logs_message;
783
+				$messages[ ] = esc_html__( 'There was an error duplicating the entry.', 'gravityview' ) . $check_logs_message;
784 784
 
785 785
 				return $messages;
786 786
 			} );
Please login to merge, or discard this patch.
includes/extensions/delete-entry/class-delete-entry.php 1 patch
Spacing   +73 added lines, -73 removed lines patch added patch discarded remove patch
@@ -42,12 +42,12 @@  discard block
 block discarded – undo
42 42
 
43 43
 		add_action( 'wp', array( $this, 'process_delete' ), 10000 );
44 44
 
45
-		add_filter( 'gravityview_entry_default_fields', array( $this, 'add_default_field'), 10, 3 );
45
+		add_filter( 'gravityview_entry_default_fields', array( $this, 'add_default_field' ), 10, 3 );
46 46
 
47 47
 		add_action( 'gravityview_before', array( $this, 'maybe_display_message' ) );
48 48
 
49 49
 		// For the Delete Entry Link, you don't want visible to all users.
50
-		add_filter( 'gravityview_field_visibility_caps', array( $this, 'modify_visibility_caps'), 10, 5 );
50
+		add_filter( 'gravityview_field_visibility_caps', array( $this, 'modify_visibility_caps' ), 10, 5 );
51 51
 
52 52
 		// Modify the field options based on the name of the field type
53 53
 		add_filter( 'gravityview_template_delete_link_options', array( $this, 'delete_link_field_options' ), 10, 5 );
@@ -55,10 +55,10 @@  discard block
 block discarded – undo
55 55
 		// add template path to check for field
56 56
 		add_filter( 'gravityview_template_paths', array( $this, 'add_template_path' ) );
57 57
 
58
-		add_action( 'gravityview/edit-entry/publishing-action/after', array( $this, 'add_delete_button'), 10, 4 );
58
+		add_action( 'gravityview/edit-entry/publishing-action/after', array( $this, 'add_delete_button' ), 10, 4 );
59 59
 
60
-		add_action ( 'gravityview/delete-entry/deleted', array( $this, 'process_connected_posts' ), 10, 2 );
61
-		add_action ( 'gravityview/delete-entry/trashed', array( $this, 'process_connected_posts' ), 10, 2 );
60
+		add_action( 'gravityview/delete-entry/deleted', array( $this, 'process_connected_posts' ), 10, 2 );
61
+		add_action( 'gravityview/delete-entry/trashed', array( $this, 'process_connected_posts' ), 10, 2 );
62 62
 
63 63
 		add_filter( 'gravityview/field/is_visible', array( $this, 'maybe_not_visible' ), 10, 3 );
64 64
 	}
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 	 */
72 72
 	static function getInstance() {
73 73
 
74
-		if( empty( self::$instance ) ) {
74
+		if ( empty( self::$instance ) ) {
75 75
 			self::$instance = new self;
76 76
 		}
77 77
 
@@ -151,20 +151,20 @@  discard block
 block discarded – undo
151 151
 	function delete_link_field_options( $field_options, $template_id, $field_id, $context, $input_type ) {
152 152
 
153 153
 		// Always a link, never a filter
154
-		unset( $field_options['show_as_link'], $field_options['search_filter'] );
154
+		unset( $field_options[ 'show_as_link' ], $field_options[ 'search_filter' ] );
155 155
 
156 156
 		// Delete Entry link should only appear to visitors capable of editing entries
157
-		unset( $field_options['only_loggedin'], $field_options['only_loggedin_cap'] );
157
+		unset( $field_options[ 'only_loggedin' ], $field_options[ 'only_loggedin_cap' ] );
158 158
 
159
-		$add_option['delete_link'] = array(
159
+		$add_option[ 'delete_link' ] = array(
160 160
 			'type' => 'text',
161 161
 			'label' => __( 'Delete Link Text', 'gravityview' ),
162 162
 			'desc' => NULL,
163
-			'value' => __('Delete Entry', 'gravityview'),
163
+			'value' => __( 'Delete Entry', 'gravityview' ),
164 164
 			'merge_tags' => true,
165 165
 		);
166 166
 
167
-		$field_options['allow_edit_cap'] = array(
167
+		$field_options[ 'allow_edit_cap' ] = array(
168 168
 			'type' => 'select',
169 169
 			'label' => __( 'Allow the following users to delete the entry:', 'gravityview' ),
170 170
 			'choices' => GravityView_Render_Settings::get_cap_choices( $template_id, $field_id, $context, $input_type ),
@@ -188,8 +188,8 @@  discard block
 block discarded – undo
188 188
 	 */
189 189
 	function add_default_field( $entry_default_fields, $form = array(), $zone = '' ) {
190 190
 
191
-		if( 'edit' !== $zone ) {
192
-			$entry_default_fields['delete_link'] = array(
191
+		if ( 'edit' !== $zone ) {
192
+			$entry_default_fields[ 'delete_link' ] = array(
193 193
 				'label' => __( 'Delete Entry', 'gravityview' ),
194 194
 				'type'  => 'delete_link',
195 195
 				'desc'  => __( 'A link to delete the entry. Respects the Delete Entry permissions.', 'gravityview' ),
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 	 */
207 207
 	function add_available_field( $available_fields = array() ) {
208 208
 
209
-		$available_fields['delete_link'] = array(
209
+		$available_fields[ 'delete_link' ] = array(
210 210
 			'label_text' => __( 'Delete Entry', 'gravityview' ),
211 211
 			'field_id' => 'delete_link',
212 212
 			'label_type' => 'field',
@@ -234,12 +234,12 @@  discard block
 block discarded – undo
234 234
 		$caps = $visibility_caps;
235 235
 
236 236
 		// If we're configuring fields in the edit context, we want a limited selection
237
-		if( $field_id === 'delete_link' ) {
237
+		if ( $field_id === 'delete_link' ) {
238 238
 
239 239
 			// Remove other built-in caps.
240
-			unset( $caps['publish_posts'], $caps['gravityforms_view_entries'], $caps['delete_others_posts'] );
240
+			unset( $caps[ 'publish_posts' ], $caps[ 'gravityforms_view_entries' ], $caps[ 'delete_others_posts' ] );
241 241
 
242
-			$caps['read'] = _x('Entry Creator', 'User capability', 'gravityview');
242
+			$caps[ 'read' ] = _x( 'Entry Creator', 'User capability', 'gravityview' );
243 243
 		}
244 244
 
245 245
 		return $caps;
@@ -252,7 +252,7 @@  discard block
 block discarded – undo
252 252
 	 * @param [type] $entry [description]
253 253
 	 */
254 254
 	function set_entry( $entry = null ) {
255
-		$this->entry = empty( $entry ) ? GravityView_View::getInstance()->entries[0] : $entry;
255
+		$this->entry = empty( $entry ) ? GravityView_View::getInstance()->entries[ 0 ] : $entry;
256 256
 	}
257 257
 
258 258
 	/**
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
285 285
 
286 286
 		self::getInstance()->set_entry( $entry );
287 287
 
288
-        $base = GravityView_API::directory_link( $post_id ? : $view_id, true );
288
+        $base = GravityView_API::directory_link( $post_id ?: $view_id, true );
289 289
 
290 290
 		if ( empty( $base ) ) {
291 291
 			gravityview()->log->error( 'Post ID does not exist: {post_id}', array( 'post_id' => $post_id ) );
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
 		}
294 294
 
295 295
 		// Use the slug instead of the ID for consistent security
296
-		$entry_slug = GravityView_API::get_entry_slug( $entry['id'], $entry );
296
+		$entry_slug = GravityView_API::get_entry_slug( $entry[ 'id' ], $entry );
297 297
 
298 298
 		$actionurl = add_query_arg( array(
299 299
 			'action'	=> 'delete',
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
             'view_id' => $view_id,
303 303
 		), $base );
304 304
 
305
-		$url = wp_nonce_url( $actionurl, 'delete_'.$entry_slug, 'delete' );
305
+		$url = wp_nonce_url( $actionurl, 'delete_' . $entry_slug, 'delete' );
306 306
 
307 307
 		return $url;
308 308
 	}
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
 	public function add_delete_button( $form = array(), $entry = array(), $view_id = null, $post_id = null ) {
325 325
 
326 326
 		// Only show the link to those who are allowed to see it.
327
-		if( !self::check_user_cap_delete_entry( $entry, array(), $view_id ) ) {
327
+		if ( ! self::check_user_cap_delete_entry( $entry, array(), $view_id ) ) {
328 328
 			return;
329 329
 		}
330 330
 
@@ -335,13 +335,13 @@  discard block
 block discarded – undo
335 335
 		$show_delete_button = apply_filters( 'gravityview/delete-entry/show-delete-button', true );
336 336
 
337 337
 		// If the button is hidden by the filter, don't show.
338
-		if( !$show_delete_button ) {
338
+		if ( ! $show_delete_button ) {
339 339
 			return;
340 340
 		}
341 341
 
342 342
 		$attributes = array(
343 343
 			'class' => 'btn btn-sm button button-small alignright pull-right btn-danger gv-button-delete',
344
-			'tabindex' => ( GFCommon::$tab_index ++ ),
344
+			'tabindex' => ( GFCommon::$tab_index++ ),
345 345
 			'onclick' => self::get_confirm_dialog(),
346 346
 		);
347 347
 
@@ -365,27 +365,27 @@  discard block
 block discarded – undo
365 365
 	function process_delete() {
366 366
 
367 367
 		// If the form is submitted
368
-		if( isset( $_GET['action'] ) && 'delete' === $_GET['action'] && isset( $_GET['entry_id'] ) ) {
368
+		if ( isset( $_GET[ 'action' ] ) && 'delete' === $_GET[ 'action' ] && isset( $_GET[ 'entry_id' ] ) ) {
369 369
 
370 370
 			// Make sure it's a GravityView request
371
-			$valid_nonce_key = wp_verify_nonce( $_GET['delete'], self::get_nonce_key( $_GET['entry_id'] ) );
371
+			$valid_nonce_key = wp_verify_nonce( $_GET[ 'delete' ], self::get_nonce_key( $_GET[ 'entry_id' ] ) );
372 372
 
373
-			if( ! $valid_nonce_key ) {
373
+			if ( ! $valid_nonce_key ) {
374 374
 				gravityview()->log->debug( 'Delete entry not processed: nonce validation failed.' );
375 375
 				return;
376 376
 			}
377 377
 
378 378
 			// Get the entry slug
379
-			$entry_slug = esc_attr( $_GET['entry_id'] );
379
+			$entry_slug = esc_attr( $_GET[ 'entry_id' ] );
380 380
 
381 381
 			// See if there's an entry there
382 382
 			$entry = gravityview_get_entry( $entry_slug, true, false );
383 383
 
384
-			if( $entry ) {
384
+			if ( $entry ) {
385 385
 
386 386
 				$has_permission = $this->user_can_delete_entry( $entry, \GV\Utils::_GET( 'gvid', \GV\Utils::_GET( 'view_id' ) ) );
387 387
 
388
-				if( is_wp_error( $has_permission ) ) {
388
+				if ( is_wp_error( $has_permission ) ) {
389 389
 
390 390
 					$messages = array(
391 391
 						'message' => urlencode( $has_permission->get_error_message() ),
@@ -397,7 +397,7 @@  discard block
 block discarded – undo
397 397
 					// Delete the entry
398 398
 					$delete_response = $this->delete_or_trash_entry( $entry );
399 399
 
400
-					if( is_wp_error( $delete_response ) ) {
400
+					if ( is_wp_error( $delete_response ) ) {
401 401
 
402 402
 						$messages = array(
403 403
 							'message' => urlencode( $delete_response->get_error_message() ),
@@ -419,7 +419,7 @@  discard block
 block discarded – undo
419 419
 				gravityview()->log->debug( 'Delete entry failed: there was no entry with the entry slug {entry_slug}', array( 'entry_slug' => $entry_slug ) );
420 420
 
421 421
 				$messages = array(
422
-					'message' => urlencode( __('The entry does not exist.', 'gravityview') ),
422
+					'message' => urlencode( __( 'The entry does not exist.', 'gravityview' ) ),
423 423
 					'status' => 'error',
424 424
 				);
425 425
 			}
@@ -459,18 +459,18 @@  discard block
 block discarded – undo
459 459
 	 */
460 460
 	private function delete_or_trash_entry( $entry ) {
461 461
 
462
-		$entry_id = $entry['id'];
462
+		$entry_id = $entry[ 'id' ];
463 463
 		
464 464
 		$mode = $this->get_delete_mode();
465 465
 
466
-		if( 'delete' === $mode ) {
466
+		if ( 'delete' === $mode ) {
467 467
 
468 468
 			gravityview()->log->debug( 'Starting delete entry: {entry_id}', array( 'entry_id' => $entry_id ) );
469 469
 
470 470
 			// Delete the entry
471 471
 			$delete_response = GFAPI::delete_entry( $entry_id );
472 472
 
473
-			if( ! is_wp_error( $delete_response ) ) {
473
+			if ( ! is_wp_error( $delete_response ) ) {
474 474
 				$delete_response = 'deleted';
475 475
 
476 476
 				/**
@@ -491,8 +491,8 @@  discard block
 block discarded – undo
491 491
 			$trashed = GFAPI::update_entry_property( $entry_id, 'status', 'trash' );
492 492
 			new GravityView_Cache;
493 493
 
494
-			if( ! $trashed ) {
495
-				$delete_response = new WP_Error( 'trash_entry_failed', __('Moving the entry to the trash failed.', 'gravityview' ) );
494
+			if ( ! $trashed ) {
495
+				$delete_response = new WP_Error( 'trash_entry_failed', __( 'Moving the entry to the trash failed.', 'gravityview' ) );
496 496
 			} else {
497 497
 
498 498
 				/**
@@ -523,7 +523,7 @@  discard block
 block discarded – undo
523 523
 	public function process_connected_posts( $entry_id = 0, $entry = array() ) {
524 524
 
525 525
 		// The entry had no connected post
526
-		if( empty( $entry['post_id'] ) ) {
526
+		if ( empty( $entry[ 'post_id' ] ) ) {
527 527
 			return;
528 528
 		}
529 529
 
@@ -534,19 +534,19 @@  discard block
 block discarded – undo
534 534
 		 */
535 535
 		$delete_post = apply_filters( 'gravityview/delete-entry/delete-connected-post', true );
536 536
 		
537
-		if( false === $delete_post ) {
537
+		if ( false === $delete_post ) {
538 538
 			return;
539 539
 		}
540 540
 
541 541
 		$action = current_action();
542 542
 
543
-		if( 'gravityview/delete-entry/deleted' === $action ) {
544
-			$result = wp_delete_post( $entry['post_id'], true );
543
+		if ( 'gravityview/delete-entry/deleted' === $action ) {
544
+			$result = wp_delete_post( $entry[ 'post_id' ], true );
545 545
 		} else {
546
-			$result = wp_trash_post( $entry['post_id'] );
546
+			$result = wp_trash_post( $entry[ 'post_id' ] );
547 547
 		}
548 548
 
549
-		if( false === $result ) {
549
+		if ( false === $result ) {
550 550
 			gravityview()->log->error( '(called by {action}): Error processing the Post connected to the entry.', array( 'action' => $action, 'data' => $entry ) );
551 551
 		} else {
552 552
 			gravityview()->log->debug( '(called by {action}): Successfully processed Post connected to the entry.', array( 'action' => $action, 'data' => $entry ) );
@@ -562,13 +562,13 @@  discard block
 block discarded – undo
562 562
 	public function verify_nonce() {
563 563
 
564 564
 		// No delete entry request was made
565
-		if( empty( $_GET['entry_id'] ) || empty( $_GET['delete'] ) ) {
565
+		if ( empty( $_GET[ 'entry_id' ] ) || empty( $_GET[ 'delete' ] ) ) {
566 566
 			return false;
567 567
 		}
568 568
 
569
-		$nonce_key = self::get_nonce_key( $_GET['entry_id'] );
569
+		$nonce_key = self::get_nonce_key( $_GET[ 'entry_id' ] );
570 570
 
571
-		$valid = wp_verify_nonce( $_GET['delete'], $nonce_key );
571
+		$valid = wp_verify_nonce( $_GET[ 'delete' ], $nonce_key );
572 572
 
573 573
 		/**
574 574
 		 * @filter `gravityview/delete-entry/verify_nonce` Override Delete Entry nonce validation. Return true to declare nonce valid.
@@ -590,7 +590,7 @@  discard block
 block discarded – undo
590 590
 	 */
591 591
 	public static function get_confirm_dialog() {
592 592
 
593
-		$confirm = __('Are you sure you want to delete this entry? This cannot be undone.', 'gravityview');
593
+		$confirm = __( 'Are you sure you want to delete this entry? This cannot be undone.', 'gravityview' );
594 594
 
595 595
 		/**
596 596
 		 * @filter `gravityview/delete-entry/confirm-text` Modify the Delete Entry Javascript confirmation text
@@ -598,7 +598,7 @@  discard block
 block discarded – undo
598 598
 		 */
599 599
 		$confirm = apply_filters( 'gravityview/delete-entry/confirm-text', $confirm );
600 600
 
601
-		return 'return window.confirm(\''. esc_js( $confirm ) .'\');';
601
+		return 'return window.confirm(\'' . esc_js( $confirm ) . '\');';
602 602
 	}
603 603
 
604 604
 	/**
@@ -616,16 +616,16 @@  discard block
 block discarded – undo
616 616
 
617 617
 		$error = NULL;
618 618
 
619
-		if( ! $this->verify_nonce() ) {
620
-			$error = __( 'The link to delete this entry is not valid; it may have expired.', 'gravityview');
619
+		if ( ! $this->verify_nonce() ) {
620
+			$error = __( 'The link to delete this entry is not valid; it may have expired.', 'gravityview' );
621 621
 		}
622 622
 
623
-		if( ! self::check_user_cap_delete_entry( $entry, array(), $view_id ) ) {
624
-			$error = __( 'You do not have permission to delete this entry.', 'gravityview');
623
+		if ( ! self::check_user_cap_delete_entry( $entry, array(), $view_id ) ) {
624
+			$error = __( 'You do not have permission to delete this entry.', 'gravityview' );
625 625
 		}
626 626
 
627
-		if( $entry['status'] === 'trash' ) {
628
-			if( 'trash' === $this->get_delete_mode() ) {
627
+		if ( $entry[ 'status' ] === 'trash' ) {
628
+			if ( 'trash' === $this->get_delete_mode() ) {
629 629
 				$error = __( 'The entry is already in the trash.', 'gravityview' );
630 630
 			} else {
631 631
 				$error = __( 'You cannot delete the entry; it is already in the trash.', 'gravityview' );
@@ -633,7 +633,7 @@  discard block
 block discarded – undo
633 633
 		}
634 634
 
635 635
 		// No errors; everything's fine here!
636
-		if( empty( $error ) ) {
636
+		if ( empty( $error ) ) {
637 637
 			return true;
638 638
 		}
639 639
 
@@ -661,17 +661,17 @@  discard block
 block discarded – undo
661 661
 			$view = \GV\View::by_id( $view_id );
662 662
 		} else {
663 663
 			if ( ! $view instanceof \GV\View ) {
664
-				$view = \GV\View::by_id ( $view );
664
+				$view = \GV\View::by_id( $view );
665 665
 			}
666 666
 			$view_id = $view->ID;
667 667
 		}
668 668
 
669 669
 		$current_user = wp_get_current_user();
670 670
 
671
-		$entry_id = isset( $entry['id'] ) ? $entry['id'] : NULL;
671
+		$entry_id = isset( $entry[ 'id' ] ) ? $entry[ 'id' ] : NULL;
672 672
 
673 673
 		// Or if they can delete any entries (as defined in Gravity Forms), we're good.
674
-		if( GVCommon::has_cap( array( 'gravityforms_delete_entries', 'gravityview_delete_others_entries' ), $entry_id ) ) {
674
+		if ( GVCommon::has_cap( array( 'gravityforms_delete_entries', 'gravityview_delete_others_entries' ), $entry_id ) ) {
675 675
 
676 676
 			gravityview()->log->debug( 'Current user has `gravityforms_delete_entries` or `gravityview_delete_others_entries` capability.' );
677 677
 
@@ -680,20 +680,20 @@  discard block
 block discarded – undo
680 680
 
681 681
 
682 682
 		// If field options are passed, check if current user can view the link
683
-		if( !empty( $field ) ) {
683
+		if ( ! empty( $field ) ) {
684 684
 
685 685
 			// If capability is not defined, something is not right!
686
-			if( empty( $field['allow_edit_cap'] ) ) {
686
+			if ( empty( $field[ 'allow_edit_cap' ] ) ) {
687 687
 
688 688
 				gravityview()->log->error( 'Cannot read delete entry field caps', array( 'data' => $field ) );
689 689
 
690 690
 				return false;
691 691
 			}
692 692
 
693
-			if( GVCommon::has_cap( $field['allow_edit_cap'] ) ) {
693
+			if ( GVCommon::has_cap( $field[ 'allow_edit_cap' ] ) ) {
694 694
 
695 695
 				// Do not return true if cap is read, as we need to check if the current user created the entry
696
-				if( $field['allow_edit_cap'] !== 'read' ) {
696
+				if ( $field[ 'allow_edit_cap' ] !== 'read' ) {
697 697
 					return true;
698 698
 				}
699 699
 
@@ -706,9 +706,9 @@  discard block
 block discarded – undo
706 706
 
707 707
 		}
708 708
 
709
-		if( !isset( $entry['created_by'] ) ) {
709
+		if ( ! isset( $entry[ 'created_by' ] ) ) {
710 710
 
711
-			gravityview()->log->error( 'Entry `created_by` doesn\'t exist.');
711
+			gravityview()->log->error( 'Entry `created_by` doesn\'t exist.' );
712 712
 
713 713
 			return false;
714 714
 		}
@@ -722,7 +722,7 @@  discard block
 block discarded – undo
722 722
 		}
723 723
 
724 724
 		// If the logged-in user is the same as the user who created the entry, we're good.
725
-		if( is_user_logged_in() && intval( $current_user->ID ) === intval( $entry['created_by'] ) ) {
725
+		if ( is_user_logged_in() && intval( $current_user->ID ) === intval( $entry[ 'created_by' ] ) ) {
726 726
 
727 727
 			gravityview()->log->debug( 'User {user_id} created the entry.', array( 'user_id' => $current_user->ID ) );
728 728
 
@@ -746,12 +746,12 @@  discard block
 block discarded – undo
746 746
 	 * @return void
747 747
 	 */
748 748
 	public function maybe_display_message( $current_view_id = 0 ) {
749
-		if( empty( $_GET['status'] ) || ! self::verify_nonce() ) {
749
+		if ( empty( $_GET[ 'status' ] ) || ! self::verify_nonce() ) {
750 750
 			return;
751 751
 		}
752 752
 
753 753
 		// Entry wasn't deleted from current View
754
-		if( isset( $_GET['view_id'] ) && intval( $_GET['view_id'] ) !== intval( $current_view_id ) ) {
754
+		if ( isset( $_GET[ 'view_id' ] ) && intval( $_GET[ 'view_id' ] ) !== intval( $current_view_id ) ) {
755 755
 			return;
756 756
 		}
757 757
 
@@ -760,11 +760,11 @@  discard block
 block discarded – undo
760 760
 
761 761
 	public function display_message() {
762 762
 
763
-		if ( empty( $_GET['status'] ) || empty( $_GET['delete'] ) ) {
763
+		if ( empty( $_GET[ 'status' ] ) || empty( $_GET[ 'delete' ] ) ) {
764 764
 			return;
765 765
 		}
766 766
 
767
-		$status = esc_attr( $_GET['status'] );
767
+		$status = esc_attr( $_GET[ 'status' ] );
768 768
 		$message_from_url = \GV\Utils::_GET( 'message' );
769 769
 		$message_from_url = rawurldecode( stripslashes_deep( $message_from_url ) );
770 770
 		$class = '';
@@ -772,14 +772,14 @@  discard block
 block discarded – undo
772 772
 		switch ( $status ) {
773 773
 			case 'error':
774 774
 				$class = ' gv-error error';
775
-				$error_message = __('There was an error deleting the entry: %s', 'gravityview');
775
+				$error_message = __( 'There was an error deleting the entry: %s', 'gravityview' );
776 776
 				$message = sprintf( $error_message, $message_from_url );
777 777
 				break;
778 778
 			case 'trashed':
779
-				$message = __('The entry was successfully moved to the trash.', 'gravityview');
779
+				$message = __( 'The entry was successfully moved to the trash.', 'gravityview' );
780 780
 				break;
781 781
 			default:
782
-				$message = __('The entry was successfully deleted.', 'gravityview');
782
+				$message = __( 'The entry was successfully deleted.', 'gravityview' );
783 783
 				break;
784 784
 		}
785 785
 
@@ -793,7 +793,7 @@  discard block
 block discarded – undo
793 793
 		$message = apply_filters( 'gravityview/delete-entry/message', esc_attr( $message ), $status, $message_from_url );
794 794
 
795 795
 		// DISPLAY ERROR/SUCCESS MESSAGE
796
-		echo '<div class="gv-notice' . esc_attr( $class ) .'">'. $message .'</div>';
796
+		echo '<div class="gv-notice' . esc_attr( $class ) . '">' . $message . '</div>';
797 797
 	}
798 798
 
799 799
 
Please login to merge, or discard this patch.
includes/extensions/edit-entry/class-edit-entry.php 2 patches
Indentation   +156 added lines, -156 removed lines patch added patch discarded remove patch
@@ -18,82 +18,82 @@  discard block
 block discarded – undo
18 18
 
19 19
 class GravityView_Edit_Entry {
20 20
 
21
-    /**
22
-     * @var string
23
-     */
21
+	/**
22
+	 * @var string
23
+	 */
24 24
 	static $file;
25 25
 
26 26
 	static $instance;
27 27
 
28
-    /**
29
-     * Component instances.
30
-     * @var array
31
-     */
32
-    public $instances = array();
28
+	/**
29
+	 * Component instances.
30
+	 * @var array
31
+	 */
32
+	public $instances = array();
33 33
 
34 34
 
35 35
 	function __construct() {
36 36
 
37
-        self::$file = plugin_dir_path( __FILE__ );
37
+		self::$file = plugin_dir_path( __FILE__ );
38 38
 
39
-        if( is_admin() ) {
40
-            $this->load_components( 'admin' );
41
-        }
39
+		if( is_admin() ) {
40
+			$this->load_components( 'admin' );
41
+		}
42 42
 
43 43
 
44
-        $this->load_components( 'render' );
44
+		$this->load_components( 'render' );
45 45
 
46
-        // If GF User Registration Add-on exists
47
-        $this->load_components( 'user-registration' );
46
+		// If GF User Registration Add-on exists
47
+		$this->load_components( 'user-registration' );
48 48
 
49
-        $this->add_hooks();
49
+		$this->add_hooks();
50 50
 
51 51
 		// Process hooks for addons that may or may not be present
52 52
 		$this->addon_specific_hooks();
53 53
 	}
54 54
 
55 55
 
56
-    static function getInstance() {
56
+	static function getInstance() {
57 57
 
58
-        if( empty( self::$instance ) ) {
59
-            self::$instance = new GravityView_Edit_Entry;
60
-        }
58
+		if( empty( self::$instance ) ) {
59
+			self::$instance = new GravityView_Edit_Entry;
60
+		}
61 61
 
62
-        return self::$instance;
63
-    }
62
+		return self::$instance;
63
+	}
64 64
 
65 65
 
66
-    private function load_components( $component ) {
66
+	private function load_components( $component ) {
67 67
 
68
-        $dir = trailingslashit( self::$file );
68
+		$dir = trailingslashit( self::$file );
69 69
 
70
-        $filename  = $dir . 'class-edit-entry-' . $component . '.php';
71
-        $classname = 'GravityView_Edit_Entry_' . str_replace( ' ', '_', ucwords( str_replace( '-', ' ', $component ) ) );
70
+		$filename  = $dir . 'class-edit-entry-' . $component . '.php';
71
+		$classname = 'GravityView_Edit_Entry_' . str_replace( ' ', '_', ucwords( str_replace( '-', ' ', $component ) ) );
72 72
 
73
-        // Loads component and pass extension's instance so that component can
74
-        // talk each other.
75
-        require_once $filename;
76
-        $this->instances[ $component ] = new $classname( $this );
77
-        $this->instances[ $component ]->load();
73
+		// Loads component and pass extension's instance so that component can
74
+		// talk each other.
75
+		require_once $filename;
76
+		$this->instances[ $component ] = new $classname( $this );
77
+		$this->instances[ $component ]->load();
78 78
 
79
-    }
79
+	}
80 80
 
81
-    private function add_hooks() {
81
+	private function add_hooks() {
82 82
 
83
-        // Add front-end access to Gravity Forms delete file action
84
-        add_action( 'wp_ajax_nopriv_rg_delete_file', array( 'GFForms', 'delete_file') );
83
+		// Add front-end access to Gravity Forms delete file action
84
+		add_action( 'wp_ajax_nopriv_rg_delete_file', array( 'GFForms', 'delete_file') );
85 85
 
86
-        // Make sure this hook is run for non-admins
87
-        add_action( 'wp_ajax_rg_delete_file', array( 'GFForms', 'delete_file') );
86
+		// Make sure this hook is run for non-admins
87
+		add_action( 'wp_ajax_rg_delete_file', array( 'GFForms', 'delete_file') );
88 88
 
89
-        add_filter( 'gravityview_blacklist_field_types', array( $this, 'modify_field_blacklist' ), 10, 2 );
89
+		add_filter( 'gravityview_blacklist_field_types', array( $this, 'modify_field_blacklist' ), 10, 2 );
90 90
 
91
-        // add template path to check for field
92
-        add_filter( 'gravityview_template_paths', array( $this, 'add_template_path' ) );
91
+		// add template path to check for field
92
+		add_filter( 'gravityview_template_paths', array( $this, 'add_template_path' ) );
93 93
 
94 94
 		add_filter( 'gravityview/field/is_visible', array( $this, 'maybe_not_visible' ), 10, 3 );
95 95
 
96
-    }
96
+	}
97 97
 
98 98
 	/**
99 99
 	 * Trigger hooks that are normally run in the admin for Addons, but need to be triggered manually because we're not in the admin
@@ -151,74 +151,74 @@  discard block
 block discarded – undo
151 151
 		return false;
152 152
 	}
153 153
 
154
-    /**
155
-     * Include this extension templates path
156
-     * @param array $file_paths List of template paths ordered
157
-     */
158
-    public function add_template_path( $file_paths ) {
159
-
160
-        // Index 100 is the default GravityView template path.
161
-        $file_paths[ 110 ] = self::$file;
162
-
163
-        return $file_paths;
164
-    }
165
-
166
-    /**
167
-     *
168
-     * Return a well formatted nonce key according to GravityView Edit Entry protocol
169
-     *
170
-     * @param $view_id int GravityView view id
171
-     * @param $form_id int Gravity Forms form id
172
-     * @param $entry_id int Gravity Forms entry id
173
-     * @return string
174
-     */
175
-    public static function get_nonce_key( $view_id, $form_id, $entry_id ) {
176
-        return sprintf( 'edit_%d_%d_%d', $view_id, $form_id, $entry_id );
177
-    }
178
-
179
-
180
-    /**
181
-     * The edit entry link creates a secure link with a nonce
182
-     *
183
-     * It also mimics the URL structure Gravity Forms expects to have so that
184
-     * it formats the display of the edit form like it does in the backend, like
185
-     * "You can edit this post from the post page" fields, for example.
186
-     *
187
-     * @param $entry array Gravity Forms entry object
188
-     * @param $view_id int GravityView view id
189
-     * @param $post_id int GravityView Post ID where View may be embedded {@since 1.9.2}
190
-     * @param string|array $field_values Parameters to pass in to the Edit Entry form to prefill data. Uses the same format as Gravity Forms "Allow field to be populated dynamically" {@since 1.9.2} {@see https://www.gravityhelp.com/documentation/article/allow-field-to-be-populated-dynamically/ }
191
-     * @return string
192
-     */
193
-    public static function get_edit_link( $entry, $view_id, $post_id = null, $field_values = '' ) {
194
-
195
-        $nonce_key = self::get_nonce_key( $view_id, $entry['form_id'], $entry['id']  );
196
-
197
-        $base = gv_entry_link( $entry, $post_id ? : $view_id  );
198
-
199
-        $url = add_query_arg( array(
200
-            'edit' => wp_create_nonce( $nonce_key )
201
-        ), $base );
202
-
203
-        if( $post_id ) {
204
-	        $url = add_query_arg( array( 'gvid' => $view_id ), $url );
205
-        }
206
-
207
-	    /**
208
-	     * Allow passing params to dynamically populate entry with values
209
-	     * @since 1.9.2
210
-	     */
211
-	    if( !empty( $field_values ) ) {
212
-
213
-		    if( is_array( $field_values ) ) {
214
-			    // If already an array, no parse_str() needed
215
-			    $params = $field_values;
216
-		    } else {
217
-			    parse_str( $field_values, $params );
218
-		    }
219
-
220
-		    $url = add_query_arg( $params, $url );
221
-	    }
154
+	/**
155
+	 * Include this extension templates path
156
+	 * @param array $file_paths List of template paths ordered
157
+	 */
158
+	public function add_template_path( $file_paths ) {
159
+
160
+		// Index 100 is the default GravityView template path.
161
+		$file_paths[ 110 ] = self::$file;
162
+
163
+		return $file_paths;
164
+	}
165
+
166
+	/**
167
+	 *
168
+	 * Return a well formatted nonce key according to GravityView Edit Entry protocol
169
+	 *
170
+	 * @param $view_id int GravityView view id
171
+	 * @param $form_id int Gravity Forms form id
172
+	 * @param $entry_id int Gravity Forms entry id
173
+	 * @return string
174
+	 */
175
+	public static function get_nonce_key( $view_id, $form_id, $entry_id ) {
176
+		return sprintf( 'edit_%d_%d_%d', $view_id, $form_id, $entry_id );
177
+	}
178
+
179
+
180
+	/**
181
+	 * The edit entry link creates a secure link with a nonce
182
+	 *
183
+	 * It also mimics the URL structure Gravity Forms expects to have so that
184
+	 * it formats the display of the edit form like it does in the backend, like
185
+	 * "You can edit this post from the post page" fields, for example.
186
+	 *
187
+	 * @param $entry array Gravity Forms entry object
188
+	 * @param $view_id int GravityView view id
189
+	 * @param $post_id int GravityView Post ID where View may be embedded {@since 1.9.2}
190
+	 * @param string|array $field_values Parameters to pass in to the Edit Entry form to prefill data. Uses the same format as Gravity Forms "Allow field to be populated dynamically" {@since 1.9.2} {@see https://www.gravityhelp.com/documentation/article/allow-field-to-be-populated-dynamically/ }
191
+	 * @return string
192
+	 */
193
+	public static function get_edit_link( $entry, $view_id, $post_id = null, $field_values = '' ) {
194
+
195
+		$nonce_key = self::get_nonce_key( $view_id, $entry['form_id'], $entry['id']  );
196
+
197
+		$base = gv_entry_link( $entry, $post_id ? : $view_id  );
198
+
199
+		$url = add_query_arg( array(
200
+			'edit' => wp_create_nonce( $nonce_key )
201
+		), $base );
202
+
203
+		if( $post_id ) {
204
+			$url = add_query_arg( array( 'gvid' => $view_id ), $url );
205
+		}
206
+
207
+		/**
208
+		 * Allow passing params to dynamically populate entry with values
209
+		 * @since 1.9.2
210
+		 */
211
+		if( !empty( $field_values ) ) {
212
+
213
+			if( is_array( $field_values ) ) {
214
+				// If already an array, no parse_str() needed
215
+				$params = $field_values;
216
+			} else {
217
+				parse_str( $field_values, $params );
218
+			}
219
+
220
+			$url = add_query_arg( $params, $url );
221
+		}
222 222
 
223 223
 		/**
224 224
 		 * @filter `gravityview/edit/link` Filter the edit URL link.
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
 		 * @param \GV\View $view The View.
228 228
 		 */
229 229
 		return apply_filters( 'gravityview/edit/link', $url, $entry, \GV\View::by_id( $view_id  ) );
230
-    }
230
+	}
231 231
 
232 232
 	/**
233 233
 	 * Edit mode doesn't allow certain field types.
@@ -282,19 +282,19 @@  discard block
 block discarded – undo
282 282
 	}
283 283
 
284 284
 
285
-    /**
286
-     * checks if user has permissions to edit a specific entry
287
-     *
288
-     * Needs to be used combined with GravityView_Edit_Entry::user_can_edit_entry for maximum security!!
289
-     *
290
-     * @param  array $entry Gravity Forms entry array
291
-     * @param \GV\View int $view_id ID of the view you want to check visibility against {@since 1.9.2}. Required since 2.0
292
-     * @return bool
293
-     */
294
-    public static function check_user_cap_edit_entry( $entry, $view = 0 ) {
285
+	/**
286
+	 * checks if user has permissions to edit a specific entry
287
+	 *
288
+	 * Needs to be used combined with GravityView_Edit_Entry::user_can_edit_entry for maximum security!!
289
+	 *
290
+	 * @param  array $entry Gravity Forms entry array
291
+	 * @param \GV\View int $view_id ID of the view you want to check visibility against {@since 1.9.2}. Required since 2.0
292
+	 * @return bool
293
+	 */
294
+	public static function check_user_cap_edit_entry( $entry, $view = 0 ) {
295 295
 
296
-        // No permission by default
297
-        $user_can_edit = false;
296
+		// No permission by default
297
+		$user_can_edit = false;
298 298
 
299 299
 		// get user_edit setting
300 300
 		if ( empty( $view ) ) {
@@ -312,59 +312,59 @@  discard block
 block discarded – undo
312 312
 			$user_edit = GVCommon::get_template_setting( $view_id, 'user_edit' );
313 313
 		}
314 314
 
315
-        // If they can edit any entries (as defined in Gravity Forms)
316
-        // Or if they can edit other people's entries
317
-        // Then we're good.
318
-        if( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ), $entry['id'] ) ) {
315
+		// If they can edit any entries (as defined in Gravity Forms)
316
+		// Or if they can edit other people's entries
317
+		// Then we're good.
318
+		if( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ), $entry['id'] ) ) {
319 319
 
320
-            gravityview()->log->debug( 'User has ability to edit all entries.' );
320
+			gravityview()->log->debug( 'User has ability to edit all entries.' );
321 321
 
322
-            $user_can_edit = true;
322
+			$user_can_edit = true;
323 323
 
324
-        } else if( !isset( $entry['created_by'] ) ) {
324
+		} else if( !isset( $entry['created_by'] ) ) {
325 325
 
326
-            gravityview()->log->error( 'Entry `created_by` doesn\'t exist.');
326
+			gravityview()->log->error( 'Entry `created_by` doesn\'t exist.');
327 327
 
328
-            $user_can_edit = false;
328
+			$user_can_edit = false;
329 329
 
330
-        } else {
330
+		} else {
331 331
 
332 332
 
333
-            $current_user = wp_get_current_user();
333
+			$current_user = wp_get_current_user();
334 334
 
335
-            // User edit is disabled
336
-            if( empty( $user_edit ) ) {
335
+			// User edit is disabled
336
+			if( empty( $user_edit ) ) {
337 337
 
338
-                gravityview()->log->debug( 'User Edit is disabled. Returning false.' );
338
+				gravityview()->log->debug( 'User Edit is disabled. Returning false.' );
339 339
 
340
-                $user_can_edit = false;
341
-            }
340
+				$user_can_edit = false;
341
+			}
342 342
 
343
-            // User edit is enabled and the logged-in user is the same as the user who created the entry. We're good.
344
-            else if( is_user_logged_in() && intval( $current_user->ID ) === intval( $entry['created_by'] ) ) {
343
+			// User edit is enabled and the logged-in user is the same as the user who created the entry. We're good.
344
+			else if( is_user_logged_in() && intval( $current_user->ID ) === intval( $entry['created_by'] ) ) {
345 345
 
346
-                gravityview()->log->debug( 'User {user_id} created the entry.', array( 'user_id', $current_user->ID ) );
346
+				gravityview()->log->debug( 'User {user_id} created the entry.', array( 'user_id', $current_user->ID ) );
347 347
 
348
-                $user_can_edit = true;
348
+				$user_can_edit = true;
349 349
 
350
-            } else if( ! is_user_logged_in() ) {
350
+			} else if( ! is_user_logged_in() ) {
351 351
 
352
-                gravityview()->log->debug( 'No user defined; edit entry requires logged in user' );
353
-            }
352
+				gravityview()->log->debug( 'No user defined; edit entry requires logged in user' );
353
+			}
354 354
 
355
-        }
355
+		}
356 356
 
357
-        /**
358
-         * @filter `gravityview/edit_entry/user_can_edit_entry` Modify whether user can edit an entry.
359
-         * @since 1.15 Added `$entry` and `$view_id` parameters
360
-         * @param[in,out] boolean $user_can_edit Can the current user edit the current entry? (Default: false)
361
-         * @param[in] array $entry Gravity Forms entry array {@since 1.15}
362
-         * @param[in] int $view_id ID of the view you want to check visibility against {@since 1.15}
363
-         */
364
-        $user_can_edit = apply_filters( 'gravityview/edit_entry/user_can_edit_entry', $user_can_edit, $entry, $view_id );
357
+		/**
358
+		 * @filter `gravityview/edit_entry/user_can_edit_entry` Modify whether user can edit an entry.
359
+		 * @since 1.15 Added `$entry` and `$view_id` parameters
360
+		 * @param[in,out] boolean $user_can_edit Can the current user edit the current entry? (Default: false)
361
+		 * @param[in] array $entry Gravity Forms entry array {@since 1.15}
362
+		 * @param[in] int $view_id ID of the view you want to check visibility against {@since 1.15}
363
+		 */
364
+		$user_can_edit = apply_filters( 'gravityview/edit_entry/user_can_edit_entry', $user_can_edit, $entry, $view_id );
365 365
 
366
-        return (bool)$user_can_edit;
367
-    }
366
+		return (bool)$user_can_edit;
367
+	}
368 368
 
369 369
 
370 370
 
Please login to merge, or discard this patch.
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 
37 37
         self::$file = plugin_dir_path( __FILE__ );
38 38
 
39
-        if( is_admin() ) {
39
+        if ( is_admin() ) {
40 40
             $this->load_components( 'admin' );
41 41
         }
42 42
 
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 
56 56
     static function getInstance() {
57 57
 
58
-        if( empty( self::$instance ) ) {
58
+        if ( empty( self::$instance ) ) {
59 59
             self::$instance = new GravityView_Edit_Entry;
60 60
         }
61 61
 
@@ -81,10 +81,10 @@  discard block
 block discarded – undo
81 81
     private function add_hooks() {
82 82
 
83 83
         // Add front-end access to Gravity Forms delete file action
84
-        add_action( 'wp_ajax_nopriv_rg_delete_file', array( 'GFForms', 'delete_file') );
84
+        add_action( 'wp_ajax_nopriv_rg_delete_file', array( 'GFForms', 'delete_file' ) );
85 85
 
86 86
         // Make sure this hook is run for non-admins
87
-        add_action( 'wp_ajax_rg_delete_file', array( 'GFForms', 'delete_file') );
87
+        add_action( 'wp_ajax_rg_delete_file', array( 'GFForms', 'delete_file' ) );
88 88
 
89 89
         add_filter( 'gravityview_blacklist_field_types', array( $this, 'modify_field_blacklist' ), 10, 2 );
90 90
 
@@ -101,8 +101,8 @@  discard block
 block discarded – undo
101 101
 	 */
102 102
 	private function addon_specific_hooks() {
103 103
 
104
-		if( class_exists( 'GFSignature' ) && is_callable( array( 'GFSignature', 'get_instance' ) ) ) {
105
-			add_filter('gform_admin_pre_render', array( GFSignature::get_instance(), 'edit_lead_script'));
104
+		if ( class_exists( 'GFSignature' ) && is_callable( array( 'GFSignature', 'get_instance' ) ) ) {
105
+			add_filter( 'gform_admin_pre_render', array( GFSignature::get_instance(), 'edit_lead_script' ) );
106 106
 		}
107 107
 
108 108
 	}
@@ -192,15 +192,15 @@  discard block
 block discarded – undo
192 192
      */
193 193
     public static function get_edit_link( $entry, $view_id, $post_id = null, $field_values = '' ) {
194 194
 
195
-        $nonce_key = self::get_nonce_key( $view_id, $entry['form_id'], $entry['id']  );
195
+        $nonce_key = self::get_nonce_key( $view_id, $entry[ 'form_id' ], $entry[ 'id' ] );
196 196
 
197
-        $base = gv_entry_link( $entry, $post_id ? : $view_id  );
197
+        $base = gv_entry_link( $entry, $post_id ?: $view_id );
198 198
 
199 199
         $url = add_query_arg( array(
200 200
             'edit' => wp_create_nonce( $nonce_key )
201 201
         ), $base );
202 202
 
203
-        if( $post_id ) {
203
+        if ( $post_id ) {
204 204
 	        $url = add_query_arg( array( 'gvid' => $view_id ), $url );
205 205
         }
206 206
 
@@ -208,9 +208,9 @@  discard block
 block discarded – undo
208 208
 	     * Allow passing params to dynamically populate entry with values
209 209
 	     * @since 1.9.2
210 210
 	     */
211
-	    if( !empty( $field_values ) ) {
211
+	    if ( ! empty( $field_values ) ) {
212 212
 
213
-		    if( is_array( $field_values ) ) {
213
+		    if ( is_array( $field_values ) ) {
214 214
 			    // If already an array, no parse_str() needed
215 215
 			    $params = $field_values;
216 216
 		    } else {
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
 		 * @param array $entry The entry.
227 227
 		 * @param \GV\View $view The View.
228 228
 		 */
229
-		return apply_filters( 'gravityview/edit/link', $url, $entry, \GV\View::by_id( $view_id  ) );
229
+		return apply_filters( 'gravityview/edit/link', $url, $entry, \GV\View::by_id( $view_id ) );
230 230
     }
231 231
 
232 232
 	/**
@@ -237,7 +237,7 @@  discard block
 block discarded – undo
237 237
 	 */
238 238
 	public function modify_field_blacklist( $fields = array(), $context = NULL ) {
239 239
 
240
-		if( empty( $context ) || $context !== 'edit' ) {
240
+		if ( empty( $context ) || $context !== 'edit' ) {
241 241
 			return $fields;
242 242
 		}
243 243
 
@@ -315,15 +315,15 @@  discard block
 block discarded – undo
315 315
         // If they can edit any entries (as defined in Gravity Forms)
316 316
         // Or if they can edit other people's entries
317 317
         // Then we're good.
318
-        if( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ), $entry['id'] ) ) {
318
+        if ( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ), $entry[ 'id' ] ) ) {
319 319
 
320 320
             gravityview()->log->debug( 'User has ability to edit all entries.' );
321 321
 
322 322
             $user_can_edit = true;
323 323
 
324
-        } else if( !isset( $entry['created_by'] ) ) {
324
+        } else if ( ! isset( $entry[ 'created_by' ] ) ) {
325 325
 
326
-            gravityview()->log->error( 'Entry `created_by` doesn\'t exist.');
326
+            gravityview()->log->error( 'Entry `created_by` doesn\'t exist.' );
327 327
 
328 328
             $user_can_edit = false;
329 329
 
@@ -333,7 +333,7 @@  discard block
 block discarded – undo
333 333
             $current_user = wp_get_current_user();
334 334
 
335 335
             // User edit is disabled
336
-            if( empty( $user_edit ) ) {
336
+            if ( empty( $user_edit ) ) {
337 337
 
338 338
                 gravityview()->log->debug( 'User Edit is disabled. Returning false.' );
339 339
 
@@ -341,13 +341,13 @@  discard block
 block discarded – undo
341 341
             }
342 342
 
343 343
             // User edit is enabled and the logged-in user is the same as the user who created the entry. We're good.
344
-            else if( is_user_logged_in() && intval( $current_user->ID ) === intval( $entry['created_by'] ) ) {
344
+            else if ( is_user_logged_in() && intval( $current_user->ID ) === intval( $entry[ 'created_by' ] ) ) {
345 345
 
346 346
                 gravityview()->log->debug( 'User {user_id} created the entry.', array( 'user_id', $current_user->ID ) );
347 347
 
348 348
                 $user_can_edit = true;
349 349
 
350
-            } else if( ! is_user_logged_in() ) {
350
+            } else if ( ! is_user_logged_in() ) {
351 351
 
352 352
                 gravityview()->log->debug( 'No user defined; edit entry requires logged in user' );
353 353
             }
Please login to merge, or discard this patch.
includes/admin/class-gravityview-admin-view-item.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -44,12 +44,12 @@  discard block
 block discarded – undo
44 44
 	 */
45 45
 	protected $form_id;
46 46
 
47
-	function __construct( $title = '', $item_id, $item = array(), $settings = array(), $form_id = null) {
47
+	function __construct( $title = '', $item_id, $item = array(), $settings = array(), $form_id = null ) {
48 48
 
49 49
 		// Backward compat
50
-		if ( ! empty( $item['type'] ) ) {
51
-			$item['input_type'] = $item['type'];
52
-			unset( $item['type'] );
50
+		if ( ! empty( $item[ 'type' ] ) ) {
51
+			$item[ 'input_type' ] = $item[ 'type' ];
52
+			unset( $item[ 'type' ] );
53 53
 		}
54 54
 
55 55
 		if ( $admin_label = \GV\Utils::get( $settings, 'admin_label' ) ) {
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 		$this->id         = $item_id;
76 76
 		$this->form_id    = $form_id;
77 77
 		$this->settings   = $settings;
78
-		$this->label_type = $item['label_type'];
78
+		$this->label_type = $item[ 'label_type' ];
79 79
 	}
80 80
 
81 81
 	/**
@@ -119,14 +119,14 @@  discard block
 block discarded – undo
119 119
 
120 120
 			foreach ( $field_info_items as $item ) {
121 121
 
122
-				if( \GV\Utils::get( $item, 'hide_in_picker', false ) ) {
122
+				if ( \GV\Utils::get( $item, 'hide_in_picker', false ) ) {
123 123
 					continue;
124 124
 				}
125 125
 
126
-				$class = isset( $item['class'] ) ? sanitize_html_class( $item['class'] ) . ' description' : 'description';
126
+				$class = isset( $item[ 'class' ] ) ? sanitize_html_class( $item[ 'class' ] ) . ' description' : 'description';
127 127
 				// Add the title in case the value's long, in which case, it'll be truncated by CSS.
128 128
 				$output .= '<span class="' . $class . '">';
129
-				$output .= esc_html( $item['value'] );
129
+				$output .= esc_html( $item[ 'value' ] );
130 130
 				$output .= '</span>';
131 131
 			}
132 132
 
@@ -154,21 +154,21 @@  discard block
 block discarded – undo
154 154
 
155 155
 		// $settings_html will just be hidden inputs if empty. Otherwise, it'll have an <ul>. Ugly hack, I know.
156 156
 		// TODO: Un-hack this
157
-		$hide_settings_link_class = ( empty( $this->item['settings_html'] ) || strpos( $this->item['settings_html'], '<!-- No Options -->' ) > 0 ) ? 'hide-if-js' : '';
158
-		$settings_link      = sprintf( '<button class="gv-field-settings" title="%1$s" aria-label="%1$s"><span class="dashicons-admin-generic dashicons %2$s"></span></button>', esc_attr( $settings_title ), $hide_settings_link_class );
157
+		$hide_settings_link_class = ( empty( $this->item[ 'settings_html' ] ) || strpos( $this->item[ 'settings_html' ], '<!-- No Options -->' ) > 0 ) ? 'hide-if-js' : '';
158
+		$settings_link = sprintf( '<button class="gv-field-settings" title="%1$s" aria-label="%1$s"><span class="dashicons-admin-generic dashicons %2$s"></span></button>', esc_attr( $settings_title ), $hide_settings_link_class );
159 159
 
160 160
 		// Should we show the icon that the field is being used as a link to single entry?
161
-		$hide_show_as_link_class = empty( $this->settings['show_as_link'] ) ? 'hide-if-js' : '';
161
+		$hide_show_as_link_class = empty( $this->settings[ 'show_as_link' ] ) ? 'hide-if-js' : '';
162 162
 		$show_as_link            = '<span class="dashicons dashicons-admin-links ' . $hide_show_as_link_class . '" title="' . esc_attr( $single_link_title ) . '"></span>';
163 163
 
164 164
 		// When a field label is empty, use the Field ID
165 165
 		$label = empty( $this->title ) ? sprintf( _x( 'Field #%s (No Label)', 'Label in field picker for empty label', 'gravityview' ), $this->id ) : $this->title;
166 166
 
167 167
 		// If there's a custom label, and show label is checked, use that as the field heading
168
-		if ( ! empty( $this->settings['custom_label'] ) && ! empty( $this->settings['show_label'] ) ) {
169
-			$label = $this->settings['custom_label'];
170
-		} else if ( ! empty( $this->item['customLabel'] ) ) {
171
-			$label = $this->item['customLabel'];
168
+		if ( ! empty( $this->settings[ 'custom_label' ] ) && ! empty( $this->settings[ 'show_label' ] ) ) {
169
+			$label = $this->settings[ 'custom_label' ];
170
+		} else if ( ! empty( $this->item[ 'customLabel' ] ) ) {
171
+			$label = $this->item[ 'customLabel' ];
172 172
 		}
173 173
 		$label = esc_attr( $label );
174 174
 
@@ -176,8 +176,8 @@  discard block
 block discarded – undo
176 176
 
177 177
 		$output .= '<h5 class="selectable gfield field-id-' . esc_attr( $this->id ) . '">';
178 178
 
179
-		if ( ! empty( $this->item['parent'] ) ) {
180
-			$label .= ' <small>(' . esc_attr( $this->item['parent']['label'] ) . ')</small>';
179
+		if ( ! empty( $this->item[ 'parent' ] ) ) {
180
+			$label .= ' <small>(' . esc_attr( $this->item[ 'parent' ][ 'label' ] ) . ')</small>';
181 181
 		}
182 182
 
183 183
 		// Name of field / widget
@@ -193,10 +193,10 @@  discard block
 block discarded – undo
193 193
 
194 194
 		$output .= '</h5>';
195 195
 
196
-		$container_class = ! empty( $this->item['parent'] ) ? ' gv-child-field' : '';
197
-		$data_form_id   = ! empty( $this->form_id ) ? 'data-formid="' . esc_attr( $this->form_id ) . '"' : '';
196
+		$container_class = ! empty( $this->item[ 'parent' ] ) ? ' gv-child-field' : '';
197
+		$data_form_id = ! empty( $this->form_id ) ? 'data-formid="' . esc_attr( $this->form_id ) . '"' : '';
198 198
 
199
-		$output = '<div data-fieldid="' . esc_attr( $this->id ) . '" ' . $data_form_id . ' data-inputtype="' . esc_attr( $this->item['input_type'] ) . '" class="gv-fields' . $container_class . '">' . $output . $this->item['settings_html'] . '</div>';
199
+		$output = '<div data-fieldid="' . esc_attr( $this->id ) . '" ' . $data_form_id . ' data-inputtype="' . esc_attr( $this->item[ 'input_type' ] ) . '" class="gv-fields' . $container_class . '">' . $output . $this->item[ 'settings_html' ] . '</div>';
200 200
 
201 201
 		return $output;
202 202
 	}
Please login to merge, or discard this patch.
includes/extensions/edit-entry/class-edit-entry-render.php 1 patch
Spacing   +243 added lines, -243 removed lines patch added patch discarded remove patch
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
 	function load() {
136 136
 
137 137
 		/** @define "GRAVITYVIEW_DIR" "../../../" */
138
-		include_once( GRAVITYVIEW_DIR .'includes/class-admin-approve-entries.php' );
138
+		include_once( GRAVITYVIEW_DIR . 'includes/class-admin-approve-entries.php' );
139 139
 
140 140
 		// Don't display an embedded form when editing an entry
141 141
 		add_action( 'wp_head', array( $this, 'prevent_render_form' ) );
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 		add_action( 'wp', array( $this, 'prevent_maybe_process_form' ), 8 );
146 146
 		add_action( 'admin_init', array( $this, 'prevent_maybe_process_form' ), 8 );
147 147
 
148
-		add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry') );
148
+		add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry' ) );
149 149
 
150 150
 		add_action( 'gravityview_edit_entry', array( $this, 'init' ), 10, 4 );
151 151
 
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
 		add_filter( 'gform_plupload_settings', array( $this, 'modify_fileupload_settings' ), 10, 3 );
157 157
 
158 158
 		// Add fields expected by GFFormDisplay::validate()
159
-		add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation') );
159
+		add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation' ) );
160 160
 
161 161
 		// Fix multiselect value for GF 2.2
162 162
 		add_filter( 'gravityview/edit_entry/field_value_multiselect', array( $this, 'fix_multiselect_value_serialization' ), 10, 3 );
@@ -173,8 +173,8 @@  discard block
 block discarded – undo
173 173
 	 * @return void
174 174
 	 */
175 175
 	public function prevent_render_form() {
176
-		if( $this->is_edit_entry() ) {
177
-			if( 'wp_head' === current_filter() ) {
176
+		if ( $this->is_edit_entry() ) {
177
+			if ( 'wp_head' === current_filter() ) {
178 178
 				add_filter( 'gform_shortcode_form', '__return_empty_string' );
179 179
 			} else {
180 180
 				remove_filter( 'gform_shortcode_form', '__return_empty_string' );
@@ -189,17 +189,17 @@  discard block
 block discarded – undo
189 189
 	 */
190 190
 	public function prevent_maybe_process_form() {
191 191
 
192
-	    if( ! $this->is_edit_entry_submission() ) {
192
+	    if ( ! $this->is_edit_entry_submission() ) {
193 193
 			return;
194 194
 		}
195 195
 
196 196
 		gravityview()->log->debug( 'GravityView_Edit_Entry[prevent_maybe_process_form] Removing GFForms::maybe_process_form() action.' );
197 197
 
198
-		remove_action( 'wp',  array( 'RGForms', 'maybe_process_form'), 9 );
199
-		remove_action( 'wp',  array( 'GFForms', 'maybe_process_form'), 9 );
198
+		remove_action( 'wp', array( 'RGForms', 'maybe_process_form' ), 9 );
199
+		remove_action( 'wp', array( 'GFForms', 'maybe_process_form' ), 9 );
200 200
 
201
-		remove_action( 'admin_init',  array( 'GFForms', 'maybe_process_form'), 9 );
202
-		remove_action( 'admin_init',  array( 'RGForms', 'maybe_process_form'), 9 );
201
+		remove_action( 'admin_init', array( 'GFForms', 'maybe_process_form' ), 9 );
202
+		remove_action( 'admin_init', array( 'RGForms', 'maybe_process_form' ), 9 );
203 203
 	}
204 204
 
205 205
 	/**
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
210 210
 
211 211
 		$is_edit_entry =
212 212
 			( GravityView_frontend::is_single_entry() || ( ! empty( gravityview()->request->is_entry() ) ) )
213
-			&& ( ! empty( $_GET['edit'] ) );
213
+			&& ( ! empty( $_GET[ 'edit' ] ) );
214 214
 
215 215
 		return ( $is_edit_entry || $this->is_edit_entry_submission() );
216 216
 	}
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
 	 * @return boolean
222 222
 	 */
223 223
 	public function is_edit_entry_submission() {
224
-		return !empty( $_POST[ self::$nonce_field ] );
224
+		return ! empty( $_POST[ self::$nonce_field ] );
225 225
 	}
226 226
 
227 227
 	/**
@@ -234,16 +234,16 @@  discard block
 block discarded – undo
234 234
 
235 235
 
236 236
 		$entries = $gravityview_view->getEntries();
237
-	    self::$original_entry = $entries[0];
238
-	    $this->entry = $entries[0];
237
+	    self::$original_entry = $entries[ 0 ];
238
+	    $this->entry = $entries[ 0 ];
239 239
 
240 240
 		self::$original_form = $gravityview_view->getForm();
241 241
 		$this->form = $gravityview_view->getForm();
242
-		$this->form_id = $this->entry['form_id'];
242
+		$this->form_id = $this->entry[ 'form_id' ];
243 243
 		$this->view_id = $gravityview_view->getViewId();
244 244
 		$this->post_id = \GV\Utils::get( $post, 'ID', null );
245 245
 
246
-		self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry['id'] );
246
+		self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry[ 'id' ] );
247 247
 	}
248 248
 
249 249
 
@@ -302,9 +302,9 @@  discard block
 block discarded – undo
302 302
 	private function print_scripts() {
303 303
 		$gravityview_view = GravityView_View::getInstance();
304 304
 
305
-		wp_register_script( 'gform_gravityforms', GFCommon::get_base_url().'/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
305
+		wp_register_script( 'gform_gravityforms', GFCommon::get_base_url() . '/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
306 306
 
307
-		GFFormDisplay::enqueue_form_scripts( $gravityview_view->getForm(), false);
307
+		GFFormDisplay::enqueue_form_scripts( $gravityview_view->getForm(), false );
308 308
 
309 309
 		wp_localize_script( 'gravityview-fe-view', 'gvGlobals', array( 'cookiepath' => COOKIEPATH ) );
310 310
 
@@ -320,19 +320,19 @@  discard block
 block discarded – undo
320 320
 	 */
321 321
 	private function process_save( $gv_data ) {
322 322
 
323
-		if ( empty( $_POST ) || ! isset( $_POST['lid'] ) ) {
323
+		if ( empty( $_POST ) || ! isset( $_POST[ 'lid' ] ) ) {
324 324
 			return;
325 325
 		}
326 326
 
327 327
 		// Make sure the entry, view, and form IDs are all correct
328 328
 		$valid = $this->verify_nonce();
329 329
 
330
-		if ( !$valid ) {
330
+		if ( ! $valid ) {
331 331
 			gravityview()->log->error( 'Nonce validation failed.' );
332 332
 			return;
333 333
 		}
334 334
 
335
-		if ( $this->entry['id'] !== $_POST['lid'] ) {
335
+		if ( $this->entry[ 'id' ] !== $_POST[ 'lid' ] ) {
336 336
 			gravityview()->log->error( 'Entry ID did not match posted entry ID.' );
337 337
 			return;
338 338
 		}
@@ -343,7 +343,7 @@  discard block
 block discarded – undo
343 343
 
344 344
 		$this->validate();
345 345
 
346
-		if( $this->is_valid ) {
346
+		if ( $this->is_valid ) {
347 347
 
348 348
 			gravityview()->log->debug( 'Submission is valid.' );
349 349
 
@@ -355,15 +355,15 @@  discard block
 block discarded – undo
355 355
 			/**
356 356
 			 * @hack to avoid the capability validation of the method save_lead for GF 1.9+
357 357
 			 */
358
-			unset( $_GET['page'] );
358
+			unset( $_GET[ 'page' ] );
359 359
 
360
-			$date_created = $this->entry['date_created'];
360
+			$date_created = $this->entry[ 'date_created' ];
361 361
 
362 362
 			/**
363 363
 			 * @hack to force Gravity Forms to use $read_value_from_post in GFFormsModel::save_lead()
364 364
 			 * @since 1.17.2
365 365
 			 */
366
-			unset( $this->entry['date_created'] );
366
+			unset( $this->entry[ 'date_created' ] );
367 367
 
368 368
 			/**
369 369
 			 * @action `gravityview/edit_entry/before_update` Perform an action after the entry has been updated using Edit Entry
@@ -373,14 +373,14 @@  discard block
 block discarded – undo
373 373
 			 * @param GravityView_Edit_Entry_Render $this This object
374 374
 			 * @param GravityView_View_Data $gv_data The View data
375 375
 			 */
376
-			do_action( 'gravityview/edit_entry/before_update', $form, $this->entry['id'], $this, $gv_data );
376
+			do_action( 'gravityview/edit_entry/before_update', $form, $this->entry[ 'id' ], $this, $gv_data );
377 377
 
378 378
 			GFFormsModel::save_lead( $form, $this->entry );
379 379
 
380 380
 	        // Delete the values for hidden inputs
381 381
 	        $this->unset_hidden_field_values();
382 382
 
383
-			$this->entry['date_created'] = $date_created;
383
+			$this->entry[ 'date_created' ] = $date_created;
384 384
 
385 385
 			// Process calculation fields
386 386
 			$this->update_calculation_fields();
@@ -405,7 +405,7 @@  discard block
 block discarded – undo
405 405
 			 * @param GravityView_Edit_Entry_Render $this This object
406 406
 			 * @param GravityView_View_Data $gv_data The View data
407 407
 			 */
408
-			do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry['id'], $this, $gv_data );
408
+			do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry[ 'id' ], $this, $gv_data );
409 409
 
410 410
 		} else {
411 411
 			gravityview()->log->error( 'Submission is NOT valid.', array( 'entry' => $this->entry ) );
@@ -441,10 +441,10 @@  discard block
 block discarded – undo
441 441
 
442 442
 		if ( version_compare( GravityView_GFFormsModel::get_database_version(), '2.3-dev-1', '>=' ) && method_exists( 'GFFormsModel', 'get_entry_meta_table_name' ) ) {
443 443
 			$entry_meta_table = GFFormsModel::get_entry_meta_table_name();
444
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $this->entry['id'] ) );
444
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $this->entry[ 'id' ] ) );
445 445
 		} else {
446 446
 			$lead_detail_table = GFFormsModel::get_lead_details_table_name();
447
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $this->entry['id'] ) );
447
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $this->entry[ 'id' ] ) );
448 448
 		}
449 449
 
450 450
 	    foreach ( $this->entry as $input_id => $field_value ) {
@@ -462,11 +462,11 @@  discard block
 block discarded – undo
462 462
 
463 463
 				$empty_value = $field->get_value_save_entry(
464 464
 					is_array( $field->get_entry_inputs() ) ? array() : '',
465
-					$this->form, '', $this->entry['id'], $this->entry
465
+					$this->form, '', $this->entry[ 'id' ], $this->entry
466 466
 				);
467 467
 
468 468
 				if ( $field->has_calculation() ) {
469
-					$this->unset_hidden_calculations[] = $field->id; // Unset
469
+					$this->unset_hidden_calculations[ ] = $field->id; // Unset
470 470
 					$empty_value = '';
471 471
 				}
472 472
 
@@ -495,7 +495,7 @@  discard block
 block discarded – undo
495 495
 	private function preset_approval_fields() {
496 496
 		$has_approved_field = false;
497 497
 
498
-		foreach ( self::$original_form['fields'] as $field ) {
498
+		foreach ( self::$original_form[ 'fields' ] as $field ) {
499 499
 			if ( $field->gravityview_approved ) {
500 500
 				$has_approved_field = true;
501 501
 				break;
@@ -508,7 +508,7 @@  discard block
 block discarded – undo
508 508
 
509 509
 		$is_field_hidden = true;
510 510
 
511
-		foreach ( $this->form['fields'] as $field ) {
511
+		foreach ( $this->form[ 'fields' ] as $field ) {
512 512
 			if ( $field->gravityview_approved ) {
513 513
 				$is_field_hidden = false;
514 514
 				break;
@@ -533,7 +533,7 @@  discard block
 block discarded – undo
533 533
 
534 534
 		remove_filter( 'gravityview/approve_entries/update_unapproved_meta', array( $this, 'prevent_update_unapproved_meta' ), 9 );
535 535
 
536
-		if ( ! $value = gform_get_meta( $entry['id'], 'is_approved' ) ) {
536
+		if ( ! $value = gform_get_meta( $entry[ 'id' ], 'is_approved' ) ) {
537 537
 
538 538
 			$value = GravityView_Entry_Approval_Status::UNAPPROVED;
539 539
 
@@ -598,7 +598,7 @@  discard block
 block discarded – undo
598 598
 		}
599 599
 
600 600
 		/** No file is being uploaded. */
601
-		if ( empty( $_FILES[ $input_name ]['name'] ) ) {
601
+		if ( empty( $_FILES[ $input_name ][ 'name' ] ) ) {
602 602
 			/** So return the original upload, with $value as backup (it can be empty during edit form rendering) */
603 603
 			return rgar( $entry, $input_id, $value );
604 604
 		}
@@ -616,11 +616,11 @@  discard block
 block discarded – undo
616 616
 	 * @return mixed
617 617
 	 */
618 618
 	public function modify_fileupload_settings( $plupload_init, $form_id, $instance ) {
619
-		if( ! $this->is_edit_entry() ) {
619
+		if ( ! $this->is_edit_entry() ) {
620 620
 			return $plupload_init;
621 621
 		}
622 622
 
623
-		$plupload_init['gf_vars']['max_files'] = 0;
623
+		$plupload_init[ 'gf_vars' ][ 'max_files' ] = 0;
624 624
 
625 625
 		return $plupload_init;
626 626
 	}
@@ -635,27 +635,27 @@  discard block
 block discarded – undo
635 635
 		$form = $this->filter_conditional_logic( $this->form );
636 636
 
637 637
 	    /** @var GF_Field $field */
638
-		foreach( $form['fields'] as $k => &$field ) {
638
+		foreach ( $form[ 'fields' ] as $k => &$field ) {
639 639
 
640 640
 			/**
641 641
 			 * Remove the fields with calculation formulas before save to avoid conflicts with GF logic
642 642
 			 * @since 1.16.3
643 643
 			 * @var GF_Field $field
644 644
 			 */
645
-			if( $field->has_calculation() ) {
646
-				unset( $form['fields'][ $k ] );
645
+			if ( $field->has_calculation() ) {
646
+				unset( $form[ 'fields' ][ $k ] );
647 647
 			}
648 648
 
649 649
 			$field->adminOnly = false;
650 650
 
651
-			if( isset( $field->inputs ) && is_array( $field->inputs ) ) {
652
-				foreach( $field->inputs as $key => $input ) {
653
-				    $field->inputs[ $key ][ 'id' ] = (string)$input['id'];
651
+			if ( isset( $field->inputs ) && is_array( $field->inputs ) ) {
652
+				foreach ( $field->inputs as $key => $input ) {
653
+				    $field->inputs[ $key ][ 'id' ] = (string)$input[ 'id' ];
654 654
 				}
655 655
 			}
656 656
 		}
657 657
 
658
-		$form['fields'] = array_values( $form['fields'] );
658
+		$form[ 'fields' ] = array_values( $form[ 'fields' ] );
659 659
 
660 660
 		return $form;
661 661
 	}
@@ -667,14 +667,14 @@  discard block
 block discarded – undo
667 667
 		$update = false;
668 668
 
669 669
 		// get the most up to date entry values
670
-		$entry = GFAPI::get_entry( $this->entry['id'] );
670
+		$entry = GFAPI::get_entry( $this->entry[ 'id' ] );
671 671
 
672 672
 		if ( version_compare( GravityView_GFFormsModel::get_database_version(), '2.3-dev-1', '>=' ) && method_exists( 'GFFormsModel', 'get_entry_meta_table_name' ) ) {
673 673
 			$entry_meta_table = GFFormsModel::get_entry_meta_table_name();
674
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $entry['id'] ) );
674
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $entry[ 'id' ] ) );
675 675
 		} else {
676 676
 			$lead_detail_table = GFFormsModel::get_lead_details_table_name();
677
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $entry['id'] ) );
677
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $entry[ 'id' ] ) );
678 678
 		}
679 679
 
680 680
 
@@ -691,24 +691,24 @@  discard block
 block discarded – undo
691 691
 				$inputs = $field->get_entry_inputs();
692 692
 				if ( is_array( $inputs ) ) {
693 693
 				    foreach ( $inputs as $input ) {
694
-						list( $field_id, $input_id ) = rgexplode( '.', $input['id'], 2 );
694
+						list( $field_id, $input_id ) = rgexplode( '.', $input[ 'id' ], 2 );
695 695
 
696 696
 						if ( 'product' === $field->type ) {
697
-							$input_name = 'input_' . str_replace( '.', '_', $input['id'] );
697
+							$input_name = 'input_' . str_replace( '.', '_', $input[ 'id' ] );
698 698
 
699 699
 							// Only allow quantity to be set if it's allowed to be edited
700 700
 							if ( in_array( $field_id, $allowed_fields ) && $input_id == 3 ) {
701 701
 							} else { // otherwise set to what it previously was
702
-								$_POST[ $input_name ] = $entry[ $input['id'] ];
702
+								$_POST[ $input_name ] = $entry[ $input[ 'id' ] ];
703 703
 							}
704 704
 						} else {
705 705
 							// Set to what it previously was if it's not editable
706 706
 							if ( ! in_array( $field_id, $allowed_fields ) ) {
707
-								$_POST[ $input_name ] = $entry[ $input['id'] ];
707
+								$_POST[ $input_name ] = $entry[ $input[ 'id' ] ];
708 708
 							}
709 709
 						}
710 710
 
711
-						GFFormsModel::save_input( $form, $field, $entry, $current_fields, $input['id'] );
711
+						GFFormsModel::save_input( $form, $field, $entry, $current_fields, $input[ 'id' ] );
712 712
 				    }
713 713
 				} else {
714 714
 					// Set to what it previously was if it's not editable
@@ -748,19 +748,19 @@  discard block
 block discarded – undo
748 748
 
749 749
 		$input_name = 'input_' . $field_id;
750 750
 
751
-		if ( !empty( $_FILES[ $input_name ]['name'] ) ) {
751
+		if ( ! empty( $_FILES[ $input_name ][ 'name' ] ) ) {
752 752
 
753 753
 			// We have a new image
754 754
 
755
-			$value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'] );
755
+			$value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry[ 'id' ] );
756 756
 
757 757
 			$ary = ! empty( $value ) ? explode( '|:|', $value ) : array();
758 758
 	        $ary = stripslashes_deep( $ary );
759 759
 			$img_url = \GV\Utils::get( $ary, 0 );
760 760
 
761
-			$img_title       = count( $ary ) > 1 ? $ary[1] : '';
762
-			$img_caption     = count( $ary ) > 2 ? $ary[2] : '';
763
-			$img_description = count( $ary ) > 3 ? $ary[3] : '';
761
+			$img_title       = count( $ary ) > 1 ? $ary[ 1 ] : '';
762
+			$img_caption     = count( $ary ) > 2 ? $ary[ 2 ] : '';
763
+			$img_description = count( $ary ) > 3 ? $ary[ 3 ] : '';
764 764
 
765 765
 			$image_meta = array(
766 766
 				'post_excerpt' => $img_caption,
@@ -769,7 +769,7 @@  discard block
 block discarded – undo
769 769
 
770 770
 			//adding title only if it is not empty. It will default to the file name if it is not in the array
771 771
 			if ( ! empty( $img_title ) ) {
772
-				$image_meta['post_title'] = $img_title;
772
+				$image_meta[ 'post_title' ] = $img_title;
773 773
 			}
774 774
 
775 775
 			/**
@@ -827,15 +827,15 @@  discard block
 block discarded – undo
827 827
 	 */
828 828
 	private function maybe_update_post_fields( $form ) {
829 829
 
830
-		if( empty( $this->entry['post_id'] ) ) {
830
+		if ( empty( $this->entry[ 'post_id' ] ) ) {
831 831
 	        gravityview()->log->debug( 'This entry has no post fields. Continuing...' );
832 832
 			return;
833 833
 		}
834 834
 
835
-		$post_id = $this->entry['post_id'];
835
+		$post_id = $this->entry[ 'post_id' ];
836 836
 
837 837
 		// Security check
838
-		if( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
838
+		if ( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
839 839
 			gravityview()->log->error( 'The current user does not have the ability to edit Post #{post_id}', array( 'post_id' => $post_id ) );
840 840
 			return;
841 841
 		}
@@ -848,25 +848,25 @@  discard block
 block discarded – undo
848 848
 
849 849
 			$field = RGFormsModel::get_field( $form, $field_id );
850 850
 
851
-			if( ! $field ) {
851
+			if ( ! $field ) {
852 852
 				continue;
853 853
 			}
854 854
 
855
-			if( GFCommon::is_post_field( $field ) && 'post_category' !== $field->type ) {
855
+			if ( GFCommon::is_post_field( $field ) && 'post_category' !== $field->type ) {
856 856
 
857 857
 				// Get the value of the field, including $_POSTed value
858 858
 				$value = RGFormsModel::get_field_value( $field );
859 859
 
860 860
 				// Use temporary entry variable, to make values available to fill_post_template() and update_post_image()
861 861
 				$entry_tmp = $this->entry;
862
-				$entry_tmp["{$field_id}"] = $value;
862
+				$entry_tmp[ "{$field_id}" ] = $value;
863 863
 
864
-				switch( $field->type ) {
864
+				switch ( $field->type ) {
865 865
 
866 866
 				    case 'post_title':
867 867
 				        $post_title = $value;
868 868
 				        if ( \GV\Utils::get( $form, 'postTitleTemplateEnabled' ) ) {
869
-				            $post_title = $this->fill_post_template( $form['postTitleTemplate'], $form, $entry_tmp );
869
+				            $post_title = $this->fill_post_template( $form[ 'postTitleTemplate' ], $form, $entry_tmp );
870 870
 				        }
871 871
 				        $updated_post->post_title = $post_title;
872 872
 				        $updated_post->post_name  = $post_title;
@@ -876,7 +876,7 @@  discard block
 block discarded – undo
876 876
 				    case 'post_content':
877 877
 				        $post_content = $value;
878 878
 				        if ( \GV\Utils::get( $form, 'postContentTemplateEnabled' ) ) {
879
-				            $post_content = $this->fill_post_template( $form['postContentTemplate'], $form, $entry_tmp, true );
879
+				            $post_content = $this->fill_post_template( $form[ 'postContentTemplate' ], $form, $entry_tmp, true );
880 880
 				        }
881 881
 				        $updated_post->post_content = $post_content;
882 882
 				        unset( $post_content );
@@ -894,11 +894,11 @@  discard block
 block discarded – undo
894 894
 							$value = $value[ $field_id ];
895 895
 						}
896 896
 
897
-				        if( ! empty( $field->customFieldTemplateEnabled ) ) {
897
+				        if ( ! empty( $field->customFieldTemplateEnabled ) ) {
898 898
 				            $value = $this->fill_post_template( $field->customFieldTemplate, $form, $entry_tmp, true );
899 899
 				        }
900 900
 
901
-						$value = $field->get_value_save_entry( $value, $form, '', $this->entry['id'], $this->entry );
901
+						$value = $field->get_value_save_entry( $value, $form, '', $this->entry[ 'id' ], $this->entry );
902 902
 
903 903
 				        update_post_meta( $post_id, $field->postCustomFieldName, $value );
904 904
 				        break;
@@ -910,7 +910,7 @@  discard block
 block discarded – undo
910 910
 				}
911 911
 
912 912
 				// update entry after
913
-				$this->entry["{$field_id}"] = $value;
913
+				$this->entry[ "{$field_id}" ] = $value;
914 914
 
915 915
 				$update_entry = true;
916 916
 
@@ -919,11 +919,11 @@  discard block
 block discarded – undo
919 919
 
920 920
 		}
921 921
 
922
-		if( $update_entry ) {
922
+		if ( $update_entry ) {
923 923
 
924 924
 			$return_entry = GFAPI::update_entry( $this->entry );
925 925
 
926
-			if( is_wp_error( $return_entry ) ) {
926
+			if ( is_wp_error( $return_entry ) ) {
927 927
 				gravityview()->log->error( 'Updating the entry post fields failed', array( 'data' => array( '$this->entry' => $this->entry, '$return_entry' => $return_entry ) ) );
928 928
 			} else {
929 929
 				gravityview()->log->debug( 'Updating the entry post fields for post #{post_id} succeeded', array( 'post_id' => $post_id ) );
@@ -933,7 +933,7 @@  discard block
 block discarded – undo
933 933
 
934 934
 		$return_post = wp_update_post( $updated_post, true );
935 935
 
936
-		if( is_wp_error( $return_post ) ) {
936
+		if ( is_wp_error( $return_post ) ) {
937 937
 			$return_post->add_data( $updated_post, '$updated_post' );
938 938
 			gravityview()->log->error( 'Updating the post content failed', array( 'data' => compact( 'updated_post', 'return_post' ) ) );
939 939
 		} else {
@@ -967,7 +967,7 @@  discard block
 block discarded – undo
967 967
 		$output = GFCommon::replace_variables( $output, $form, $entry, false, false, false );
968 968
 
969 969
 		// replace conditional shortcodes
970
-		if( $do_shortcode ) {
970
+		if ( $do_shortcode ) {
971 971
 			$output = do_shortcode( $output );
972 972
 		}
973 973
 
@@ -986,19 +986,19 @@  discard block
 block discarded – undo
986 986
 	 */
987 987
 	private function after_update() {
988 988
 
989
-		do_action( 'gform_after_update_entry', self::$original_form, $this->entry['id'], self::$original_entry );
990
-		do_action( "gform_after_update_entry_{$this->form['id']}", self::$original_form, $this->entry['id'], self::$original_entry );
989
+		do_action( 'gform_after_update_entry', self::$original_form, $this->entry[ 'id' ], self::$original_entry );
990
+		do_action( "gform_after_update_entry_{$this->form[ 'id' ]}", self::$original_form, $this->entry[ 'id' ], self::$original_entry );
991 991
 
992 992
 		// Re-define the entry now that we've updated it.
993
-		$entry = RGFormsModel::get_lead( $this->entry['id'] );
993
+		$entry = RGFormsModel::get_lead( $this->entry[ 'id' ] );
994 994
 
995 995
 		$entry = GFFormsModel::set_entry_meta( $entry, self::$original_form );
996 996
 
997 997
 		if ( version_compare( GFFormsModel::get_database_version(), '2.3-dev-1', '<' ) ) {
998 998
 			// We need to clear the cache because Gravity Forms caches the field values, which
999 999
 			// we have just updated.
1000
-			foreach ($this->form['fields'] as $key => $field) {
1001
-				GFFormsModel::refresh_lead_field_value( $entry['id'], $field->id );
1000
+			foreach ( $this->form[ 'fields' ] as $key => $field ) {
1001
+				GFFormsModel::refresh_lead_field_value( $entry[ 'id' ], $field->id );
1002 1002
 			}
1003 1003
 		}
1004 1004
 
@@ -1008,11 +1008,11 @@  discard block
 block discarded – undo
1008 1008
 		 * @since develop
1009 1009
 		 */
1010 1010
 		if ( $allowed_feeds = $this->view->settings->get( 'edit_feeds', array() ) ) {
1011
-			$feeds = GFAPI::get_feeds( null, $entry['form_id'] );
1011
+			$feeds = GFAPI::get_feeds( null, $entry[ 'form_id' ] );
1012 1012
 			if ( ! is_wp_error( $feeds ) ) {
1013 1013
 				$registered_feeds = array();
1014 1014
 				foreach ( GFAddOn::get_registered_addons() as $registered_feed ) {
1015
-					if ( is_subclass_of( $registered_feed,  'GFFeedAddOn' ) ) {
1015
+					if ( is_subclass_of( $registered_feed, 'GFFeedAddOn' ) ) {
1016 1016
 						if ( method_exists( $registered_feed, 'get_instance' ) ) {
1017 1017
 							$registered_feed = call_user_func( array( $registered_feed, 'get_instance' ) );
1018 1018
 							$registered_feeds[ $registered_feed->get_slug() ] = $registered_feed;
@@ -1020,8 +1020,8 @@  discard block
 block discarded – undo
1020 1020
 					}
1021 1021
 				}
1022 1022
 				foreach ( $feeds as $feed ) {
1023
-					if ( in_array( $feed['id'], $allowed_feeds ) ) {
1024
-						if ( $feed_object = \GV\Utils::get( $registered_feeds, $feed['addon_slug'] ) ) {
1023
+					if ( in_array( $feed[ 'id' ], $allowed_feeds ) ) {
1024
+						if ( $feed_object = \GV\Utils::get( $registered_feeds, $feed[ 'addon_slug' ] ) ) {
1025 1025
 							$returned_entry = $feed_object->process_feed( $feed, $entry, self::$original_form );
1026 1026
 							if ( is_array( $returned_entry ) && rgar( $returned_entry, 'id' ) ) {
1027 1027
 								$entry = $returned_entry;
@@ -1051,7 +1051,7 @@  discard block
 block discarded – undo
1051 1051
 
1052 1052
 		<div class="gv-edit-entry-wrapper"><?php
1053 1053
 
1054
-			$javascript = gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/inline-javascript.php', $this );
1054
+			$javascript = gravityview_ob_include( GravityView_Edit_Entry::$file . '/partials/inline-javascript.php', $this );
1055 1055
 
1056 1056
 			/**
1057 1057
 			 * Fixes weird wpautop() issue
@@ -1067,7 +1067,7 @@  discard block
 block discarded – undo
1067 1067
 				     * @param string $edit_entry_title Modify the "Edit Entry" title
1068 1068
 				     * @param GravityView_Edit_Entry_Render $this This object
1069 1069
 				     */
1070
-				    $edit_entry_title = apply_filters('gravityview_edit_entry_title', __('Edit Entry', 'gravityview'), $this );
1070
+				    $edit_entry_title = apply_filters( 'gravityview_edit_entry_title', __( 'Edit Entry', 'gravityview' ), $this );
1071 1071
 
1072 1072
 				    echo esc_attr( $edit_entry_title );
1073 1073
 			?></span>
@@ -1133,18 +1133,18 @@  discard block
 block discarded – undo
1133 1133
 				*/
1134 1134
 				$labels = apply_filters( 'gravityview/edit_entry/button_labels', $labels, $this->form, $this->entry, $this->view_id );
1135 1135
 
1136
-				$this->is_paged_submitted = \GV\Utils::_POST( 'save' ) === $labels['submit'];
1136
+				$this->is_paged_submitted = \GV\Utils::_POST( 'save' ) === $labels[ 'submit' ];
1137 1137
 			}
1138 1138
 
1139 1139
 			$back_link = remove_query_arg( array( 'page', 'view', 'edit' ) );
1140 1140
 
1141
-			if( ! $this->is_valid ){
1141
+			if ( ! $this->is_valid ) {
1142 1142
 
1143 1143
 				// Keeping this compatible with Gravity Forms.
1144
-				$validation_message = "<div class='validation_error'>" . __('There was a problem with your submission.', 'gravityview') . " " . __('Errors have been highlighted below.', 'gravityview') . "</div>";
1145
-				$message = apply_filters("gform_validation_message_{$this->form['id']}", apply_filters("gform_validation_message", $validation_message, $this->form), $this->form);
1144
+				$validation_message = "<div class='validation_error'>" . __( 'There was a problem with your submission.', 'gravityview' ) . " " . __( 'Errors have been highlighted below.', 'gravityview' ) . "</div>";
1145
+				$message = apply_filters( "gform_validation_message_{$this->form[ 'id' ]}", apply_filters( "gform_validation_message", $validation_message, $this->form ), $this->form );
1146 1146
 
1147
-				echo GVCommon::generate_notice( $message , 'gv-error' );
1147
+				echo GVCommon::generate_notice( $message, 'gv-error' );
1148 1148
 
1149 1149
 			} elseif ( false === $this->is_paged_submitted ) {
1150 1150
 				// Paged form that hasn't been submitted on the last page yet
@@ -1157,7 +1157,7 @@  discard block
 block discarded – undo
1157 1157
 				 * @param int $view_id View ID
1158 1158
 				 * @param array $entry Gravity Forms entry array
1159 1159
 				 */
1160
-				$message = apply_filters( 'gravityview/edit_entry/page/success', $entry_updated_message , $this->view_id, $this->entry );
1160
+				$message = apply_filters( 'gravityview/edit_entry/page/success', $entry_updated_message, $this->view_id, $this->entry );
1161 1161
 
1162 1162
 				echo GVCommon::generate_notice( $message );
1163 1163
 			} else {
@@ -1169,23 +1169,23 @@  discard block
 block discarded – undo
1169 1169
 
1170 1170
                     case '0':
1171 1171
 	                    $redirect_url = $back_link;
1172
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to Entry%s', 'Replacements are HTML', 'gravityview'), '<a href="'. esc_url( $redirect_url ) .'">', '</a>' );
1172
+	                    $entry_updated_message = sprintf( esc_attr_x( 'Entry Updated. %sReturning to Entry%s', 'Replacements are HTML', 'gravityview' ), '<a href="' . esc_url( $redirect_url ) . '">', '</a>' );
1173 1173
                         break;
1174 1174
 
1175 1175
                     case '1':
1176 1176
 	                    $redirect_url = $directory_link = GravityView_API::directory_link();
1177
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to %s%s', 'Replacement 1 is HTML. Replacement 2 is the title of the page where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $view->post_title ), '</a>' );
1177
+	                    $entry_updated_message = sprintf( esc_attr_x( 'Entry Updated. %sReturning to %s%s', 'Replacement 1 is HTML. Replacement 2 is the title of the page where the user will be taken. Replacement 3 is HTML.', 'gravityview' ), '<a href="' . esc_url( $redirect_url ) . '">', esc_html( $view->post_title ), '</a>' );
1178 1178
 	                    break;
1179 1179
 
1180 1180
                     case '2':
1181 1181
 	                    $redirect_url = $edit_redirect_url;
1182 1182
 	                    $redirect_url = GFCommon::replace_variables( $redirect_url, $this->form, $this->entry, false, false, false, 'text' );
1183
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sRedirecting to %s%s', 'Replacement 1 is HTML. Replacement 2 is the URL where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $edit_redirect_url ), '</a>' );
1183
+	                    $entry_updated_message = sprintf( esc_attr_x( 'Entry Updated. %sRedirecting to %s%s', 'Replacement 1 is HTML. Replacement 2 is the URL where the user will be taken. Replacement 3 is HTML.', 'gravityview' ), '<a href="' . esc_url( $redirect_url ) . '">', esc_html( $edit_redirect_url ), '</a>' );
1184 1184
                         break;
1185 1185
 
1186 1186
                     case '':
1187 1187
                     default:
1188
-					    $entry_updated_message = sprintf( esc_attr__('Entry Updated. %sReturn to Entry%s', 'gravityview'), '<a href="'. esc_url( $back_link ) .'">', '</a>' );
1188
+					    $entry_updated_message = sprintf( esc_attr__( 'Entry Updated. %sReturn to Entry%s', 'gravityview' ), '<a href="' . esc_url( $back_link ) . '">', '</a>' );
1189 1189
                         break;
1190 1190
 				}
1191 1191
 
@@ -1201,7 +1201,7 @@  discard block
 block discarded – undo
1201 1201
 				 * @param array $entry Gravity Forms entry array
1202 1202
 				 * @param string $back_link URL to return to the original entry. @since 1.6
1203 1203
 				 */
1204
-				$message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message , $this->view_id, $this->entry, $back_link );
1204
+				$message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message, $this->view_id, $this->entry, $back_link );
1205 1205
 
1206 1206
 				echo GVCommon::generate_notice( $message );
1207 1207
 			}
@@ -1225,8 +1225,8 @@  discard block
 block discarded – undo
1225 1225
 		 */
1226 1226
 		do_action( 'gravityview/edit-entry/render/before', $this );
1227 1227
 
1228
-		add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields'), 5000, 3 );
1229
-		add_filter( 'gform_submit_button', array( $this, 'render_form_buttons') );
1228
+		add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields' ), 5000, 3 );
1229
+		add_filter( 'gform_submit_button', array( $this, 'render_form_buttons' ) );
1230 1230
 		add_filter( 'gform_next_button', array( $this, 'render_form_buttons' ) );
1231 1231
 		add_filter( 'gform_previous_button', array( $this, 'render_form_buttons' ) );
1232 1232
 		add_filter( 'gform_disable_view_counter', '__return_true' );
@@ -1235,14 +1235,14 @@  discard block
 block discarded – undo
1235 1235
 		add_filter( 'gform_field_input', array( $this, 'modify_edit_field_input' ), 10, 5 );
1236 1236
 
1237 1237
 		// We need to remove the fake $_GET['page'] arg to avoid rendering form as if in admin.
1238
-		unset( $_GET['page'] );
1238
+		unset( $_GET[ 'page' ] );
1239 1239
 
1240 1240
 		$this->show_next_button = false;
1241 1241
 		$this->show_previous_button = false;
1242 1242
 
1243 1243
 		// TODO: Verify multiple-page forms
1244 1244
 		if ( GFCommon::has_pages( $this->form ) && apply_filters( 'gravityview/features/paged-edit', false ) ) {
1245
-			if ( intval( $page_number = \GV\Utils::_POST( 'gform_source_page_number_' . $this->form['id'], 0 ) ) ) {
1245
+			if ( intval( $page_number = \GV\Utils::_POST( 'gform_source_page_number_' . $this->form[ 'id' ], 0 ) ) ) {
1246 1246
 
1247 1247
 				$labels = array(
1248 1248
 					'cancel'   => __( 'Cancel', 'gravityview' ),
@@ -1261,20 +1261,20 @@  discard block
 block discarded – undo
1261 1261
 				*/
1262 1262
 				$labels = apply_filters( 'gravityview/edit_entry/button_labels', $labels, $this->form, $this->entry, $this->view_id );
1263 1263
 
1264
-				GFFormDisplay::$submission[ $this->form['id'] ][ 'form' ] = $this->form;
1265
-				GFFormDisplay::$submission[ $this->form['id'] ][ 'is_valid' ] = true;
1264
+				GFFormDisplay::$submission[ $this->form[ 'id' ] ][ 'form' ] = $this->form;
1265
+				GFFormDisplay::$submission[ $this->form[ 'id' ] ][ 'is_valid' ] = true;
1266 1266
 
1267
-				if ( \GV\Utils::_POST( 'save' ) === $labels['next'] ) {
1267
+				if ( \GV\Utils::_POST( 'save' ) === $labels[ 'next' ] ) {
1268 1268
 					$last_page = \GFFormDisplay::get_max_page_number( $this->form );
1269 1269
 
1270 1270
 					while ( ++$page_number < $last_page && RGFormsModel::is_page_hidden( $this->form, $page_number, \GV\Utils::_POST( 'gform_field_values' ) ) ) {
1271 1271
 					} // Advance to next visible page
1272
-				} elseif ( \GV\Utils::_POST( 'save' ) === $labels['previous'] ) {
1272
+				} elseif ( \GV\Utils::_POST( 'save' ) === $labels[ 'previous' ] ) {
1273 1273
 					while ( --$page_number > 1 && RGFormsModel::is_page_hidden( $this->form, $page_number, \GV\Utils::_POST( 'gform_field_values' ) ) ) {
1274 1274
 					} // Advance to next visible page
1275 1275
 				}
1276 1276
 
1277
-				GFFormDisplay::$submission[ $this->form['id'] ]['page_number'] = $page_number;
1277
+				GFFormDisplay::$submission[ $this->form[ 'id' ] ][ 'page_number' ] = $page_number;
1278 1278
 			}
1279 1279
 
1280 1280
 			if ( ( $page_number = intval( $page_number ) ) < 2 ) {
@@ -1300,7 +1300,7 @@  discard block
 block discarded – undo
1300 1300
 
1301 1301
 		ob_start(); // Prevent PHP warnings possibly caused by prefilling list fields for conditional logic
1302 1302
 
1303
-		$html = GFFormDisplay::get_form( $this->form['id'], false, false, true, $this->entry );
1303
+		$html = GFFormDisplay::get_form( $this->form[ 'id' ], false, false, true, $this->entry );
1304 1304
 
1305 1305
 		ob_get_clean();
1306 1306
 
@@ -1328,7 +1328,7 @@  discard block
 block discarded – undo
1328 1328
 	 * @return string
1329 1329
 	 */
1330 1330
 	public function render_form_buttons() {
1331
-		return gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/form-buttons.php', $this );
1331
+		return gravityview_ob_include( GravityView_Edit_Entry::$file . '/partials/form-buttons.php', $this );
1332 1332
 	}
1333 1333
 
1334 1334
 
@@ -1347,15 +1347,15 @@  discard block
 block discarded – undo
1347 1347
 	 */
1348 1348
 	public function filter_modify_form_fields( $form, $ajax = false, $field_values = '' ) {
1349 1349
 
1350
-		if( $form['id'] != $this->form_id ) {
1350
+		if ( $form[ 'id' ] != $this->form_id ) {
1351 1351
 			return $form;
1352 1352
 		}
1353 1353
 
1354 1354
 		// In case we have validated the form, use it to inject the validation results into the form render
1355
-		if( isset( $this->form_after_validation ) && $this->form_after_validation['id'] === $form['id'] ) {
1355
+		if ( isset( $this->form_after_validation ) && $this->form_after_validation[ 'id' ] === $form[ 'id' ] ) {
1356 1356
 			$form = $this->form_after_validation;
1357 1357
 		} else {
1358
-			$form['fields'] = $this->get_configured_edit_fields( $form, $this->view_id );
1358
+			$form[ 'fields' ] = $this->get_configured_edit_fields( $form, $this->view_id );
1359 1359
 		}
1360 1360
 
1361 1361
 		$form = $this->filter_conditional_logic( $form );
@@ -1363,8 +1363,8 @@  discard block
 block discarded – undo
1363 1363
 		$form = $this->prefill_conditional_logic( $form );
1364 1364
 
1365 1365
 		// for now we don't support Save and Continue feature.
1366
-		if( ! self::$supports_save_and_continue ) {
1367
-	        unset( $form['save'] );
1366
+		if ( ! self::$supports_save_and_continue ) {
1367
+	        unset( $form[ 'save' ] );
1368 1368
 		}
1369 1369
 
1370 1370
 		$form = $this->unselect_default_values( $form );
@@ -1387,31 +1387,31 @@  discard block
 block discarded – undo
1387 1387
 	 */
1388 1388
 	public function verify_user_can_edit_post( $field_content = '', $field, $value, $lead_id = 0, $form_id ) {
1389 1389
 
1390
-		if( ! GFCommon::is_post_field( $field ) ) {
1390
+		if ( ! GFCommon::is_post_field( $field ) ) {
1391 1391
 			return $field_content;
1392 1392
 		}
1393 1393
 
1394 1394
         $message = null;
1395 1395
 
1396 1396
         // First, make sure they have the capability to edit the post.
1397
-        if( false === current_user_can( 'edit_post', $this->entry['post_id'] ) ) {
1397
+        if ( false === current_user_can( 'edit_post', $this->entry[ 'post_id' ] ) ) {
1398 1398
 
1399 1399
             /**
1400 1400
              * @filter `gravityview/edit_entry/unsupported_post_field_text` Modify the message when someone isn't able to edit a post
1401 1401
              * @param string $message The existing "You don't have permission..." text
1402 1402
              */
1403
-            $message = apply_filters('gravityview/edit_entry/unsupported_post_field_text', __('You don&rsquo;t have permission to edit this post.', 'gravityview') );
1403
+            $message = apply_filters( 'gravityview/edit_entry/unsupported_post_field_text', __( 'You don&rsquo;t have permission to edit this post.', 'gravityview' ) );
1404 1404
 
1405
-        } elseif( null === get_post( $this->entry['post_id'] ) ) {
1405
+        } elseif ( null === get_post( $this->entry[ 'post_id' ] ) ) {
1406 1406
             /**
1407 1407
              * @filter `gravityview/edit_entry/no_post_text` Modify the message when someone is editing an entry attached to a post that no longer exists
1408 1408
              * @param string $message The existing "This field is not editable; the post no longer exists." text
1409 1409
              */
1410
-            $message = apply_filters('gravityview/edit_entry/no_post_text', __('This field is not editable; the post no longer exists.', 'gravityview' ) );
1410
+            $message = apply_filters( 'gravityview/edit_entry/no_post_text', __( 'This field is not editable; the post no longer exists.', 'gravityview' ) );
1411 1411
         }
1412 1412
 
1413
-        if( $message ) {
1414
-            $field_content = sprintf('<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
1413
+        if ( $message ) {
1414
+            $field_content = sprintf( '<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
1415 1415
         }
1416 1416
 
1417 1417
         return $field_content;
@@ -1435,8 +1435,8 @@  discard block
 block discarded – undo
1435 1435
 
1436 1436
 		// If the form has been submitted, then we don't need to pre-fill the values,
1437 1437
 		// Except for fileupload type and when a field input is overridden- run always!!
1438
-		if(
1439
-			( $this->is_edit_entry_submission() && !in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
1438
+		if (
1439
+			( $this->is_edit_entry_submission() && ! in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
1440 1440
 			&& false === ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) )
1441 1441
 			&& ! GFCommon::is_product_field( $field->type )
1442 1442
 			|| ! empty( $field_content )
@@ -1456,7 +1456,7 @@  discard block
 block discarded – undo
1456 1456
 	    $return = null;
1457 1457
 
1458 1458
 		/** @var GravityView_Field $gv_field */
1459
-		if( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
1459
+		if ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
1460 1460
 			$return = $gv_field->get_field_input( $this->form, $field_value, $this->entry, $field );
1461 1461
 		} else {
1462 1462
 	        $return = $field->get_field_input( $this->form, $field_value, $this->entry );
@@ -1465,7 +1465,7 @@  discard block
 block discarded – undo
1465 1465
 	    // If there was output, it's an error
1466 1466
 	    $warnings = ob_get_clean();
1467 1467
 
1468
-	    if( !empty( $warnings ) ) {
1468
+	    if ( ! empty( $warnings ) ) {
1469 1469
 		    gravityview()->log->error( '{warning}', array( 'warning' => $warnings, 'data' => $field_value ) );
1470 1470
 	    }
1471 1471
 
@@ -1490,7 +1490,7 @@  discard block
 block discarded – undo
1490 1490
 		$override_saved_value = apply_filters( 'gravityview/edit_entry/pre_populate/override', false, $field );
1491 1491
 
1492 1492
 		// We're dealing with multiple inputs (e.g. checkbox) but not time or date (as it doesn't store data in input IDs)
1493
-		if( isset( $field->inputs ) && is_array( $field->inputs ) && !in_array( $field->type, array( 'time', 'date' ) ) ) {
1493
+		if ( isset( $field->inputs ) && is_array( $field->inputs ) && ! in_array( $field->type, array( 'time', 'date' ) ) ) {
1494 1494
 
1495 1495
 			$field_value = array();
1496 1496
 
@@ -1499,10 +1499,10 @@  discard block
 block discarded – undo
1499 1499
 
1500 1500
 			foreach ( (array)$field->inputs as $input ) {
1501 1501
 
1502
-				$input_id = strval( $input['id'] );
1502
+				$input_id = strval( $input[ 'id' ] );
1503 1503
 
1504 1504
 				if ( isset( $this->entry[ $input_id ] ) && ! gv_empty( $this->entry[ $input_id ], false, false ) ) {
1505
-				    $field_value[ $input_id ] =  'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1505
+				    $field_value[ $input_id ] = 'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1506 1506
 				    $allow_pre_populated = false;
1507 1507
 				}
1508 1508
 
@@ -1510,7 +1510,7 @@  discard block
 block discarded – undo
1510 1510
 
1511 1511
 			$pre_value = $field->get_value_submission( array(), false );
1512 1512
 
1513
-			$field_value = ! $allow_pre_populated && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
1513
+			$field_value = ! $allow_pre_populated && ! ( $override_saved_value && ! gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
1514 1514
 
1515 1515
 		} else {
1516 1516
 
@@ -1521,13 +1521,13 @@  discard block
 block discarded – undo
1521 1521
 
1522 1522
 			// saved field entry value (if empty, fallback to the pre-populated value, if exists)
1523 1523
 			// or pre-populated value if not empty and set to override saved value
1524
-			$field_value = isset( $this->entry[ $id ] ) && ! gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
1524
+			$field_value = isset( $this->entry[ $id ] ) && ! gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && ! gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
1525 1525
 
1526 1526
 			// in case field is post_category but inputType is select, multi-select or radio, convert value into array of category IDs.
1527
-			if ( 'post_category' === $field->type && !gv_empty( $field_value, false, false ) ) {
1527
+			if ( 'post_category' === $field->type && ! gv_empty( $field_value, false, false ) ) {
1528 1528
 				$categories = array();
1529 1529
 				foreach ( explode( ',', $field_value ) as $cat_string ) {
1530
-				    $categories[] = GFCommon::format_post_category( $cat_string, true );
1530
+				    $categories[ ] = GFCommon::format_post_category( $cat_string, true );
1531 1531
 				}
1532 1532
 				$field_value = 'multiselect' === $field->get_input_type() ? $categories : implode( '', $categories );
1533 1533
 			}
@@ -1555,7 +1555,7 @@  discard block
 block discarded – undo
1555 1555
 	     * @param GF_Field $field Gravity Forms field object
1556 1556
 	     * @param GravityView_Edit_Entry_Render $this Current object
1557 1557
 	     */
1558
-	    $field_value = apply_filters( 'gravityview/edit_entry/field_value_' . $field->type , $field_value, $field, $this );
1558
+	    $field_value = apply_filters( 'gravityview/edit_entry/field_value_' . $field->type, $field_value, $field, $this );
1559 1559
 
1560 1560
 		return $field_value;
1561 1561
 	}
@@ -1572,12 +1572,12 @@  discard block
 block discarded – undo
1572 1572
 	 */
1573 1573
 	public function gform_pre_validation( $form ) {
1574 1574
 
1575
-		if( ! $this->verify_nonce() ) {
1575
+		if ( ! $this->verify_nonce() ) {
1576 1576
 			return $form;
1577 1577
 		}
1578 1578
 
1579 1579
 		// Fix PHP warning regarding undefined index.
1580
-		foreach ( $form['fields'] as &$field) {
1580
+		foreach ( $form[ 'fields' ] as &$field ) {
1581 1581
 
1582 1582
 			// This is because we're doing admin form pretending to be front-end, so Gravity Forms
1583 1583
 			// expects certain field array items to be set.
@@ -1585,7 +1585,7 @@  discard block
 block discarded – undo
1585 1585
 	            $field->{$key} = isset( $field->{$key} ) ? $field->{$key} : NULL;
1586 1586
 			}
1587 1587
 
1588
-			switch( RGFormsModel::get_input_type( $field ) ) {
1588
+			switch ( RGFormsModel::get_input_type( $field ) ) {
1589 1589
 
1590 1590
 				/**
1591 1591
 				 * this whole fileupload hack is because in the admin, Gravity Forms simply doesn't update any fileupload field if it's empty, but it DOES in the frontend.
@@ -1599,26 +1599,26 @@  discard block
 block discarded – undo
1599 1599
 				    // Set the previous value
1600 1600
 				    $entry = $this->get_entry();
1601 1601
 
1602
-				    $input_name = 'input_'.$field->id;
1603
-				    $form_id = $form['id'];
1602
+				    $input_name = 'input_' . $field->id;
1603
+				    $form_id = $form[ 'id' ];
1604 1604
 
1605 1605
 				    $value = NULL;
1606 1606
 
1607 1607
 				    // Use the previous entry value as the default.
1608
-				    if( isset( $entry[ $field->id ] ) ) {
1608
+				    if ( isset( $entry[ $field->id ] ) ) {
1609 1609
 				        $value = $entry[ $field->id ];
1610 1610
 				    }
1611 1611
 
1612 1612
 				    // If this is a single upload file
1613
-				    if( !empty( $_FILES[ $input_name ] ) && !empty( $_FILES[ $input_name ]['name'] ) ) {
1614
-				        $file_path = GFFormsModel::get_file_upload_path( $form['id'], $_FILES[ $input_name ]['name'] );
1615
-				        $value = $file_path['url'];
1613
+				    if ( ! empty( $_FILES[ $input_name ] ) && ! empty( $_FILES[ $input_name ][ 'name' ] ) ) {
1614
+				        $file_path = GFFormsModel::get_file_upload_path( $form[ 'id' ], $_FILES[ $input_name ][ 'name' ] );
1615
+				        $value = $file_path[ 'url' ];
1616 1616
 
1617 1617
 				    } else {
1618 1618
 
1619 1619
 				        // Fix PHP warning on line 1498 of form_display.php for post_image fields
1620 1620
 				        // Fix PHP Notice:  Undefined index:  size in form_display.php on line 1511
1621
-				        $_FILES[ $input_name ] = array('name' => '', 'size' => '' );
1621
+				        $_FILES[ $input_name ] = array( 'name' => '', 'size' => '' );
1622 1622
 
1623 1623
 				    }
1624 1624
 
@@ -1626,10 +1626,10 @@  discard block
 block discarded – undo
1626 1626
 
1627 1627
 				        // If there are fresh uploads, process and merge them.
1628 1628
 				        // Otherwise, use the passed values, which should be json-encoded array of URLs
1629
-				        if( isset( GFFormsModel::$uploaded_files[$form_id][$input_name] ) ) {
1629
+				        if ( isset( GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] ) ) {
1630 1630
 				            $value = empty( $value ) ? '[]' : $value;
1631 1631
 				            $value = stripslashes_deep( $value );
1632
-				            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], array());
1632
+				            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry[ 'id' ], array() );
1633 1633
 				        }
1634 1634
 
1635 1635
 				    } else {
@@ -1647,8 +1647,8 @@  discard block
 block discarded – undo
1647 1647
 
1648 1648
 				case 'number':
1649 1649
 				    // Fix "undefined index" issue at line 1286 in form_display.php
1650
-				    if( !isset( $_POST['input_'.$field->id ] ) ) {
1651
-				        $_POST['input_'.$field->id ] = NULL;
1650
+				    if ( ! isset( $_POST[ 'input_' . $field->id ] ) ) {
1651
+				        $_POST[ 'input_' . $field->id ] = NULL;
1652 1652
 				    }
1653 1653
 				    break;
1654 1654
 			}
@@ -1685,7 +1685,7 @@  discard block
 block discarded – undo
1685 1685
 		 * You can enter whatever you want!
1686 1686
 		 * We try validating, and customize the results using `self::custom_validation()`
1687 1687
 		 */
1688
-		add_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10, 4);
1688
+		add_filter( 'gform_validation_' . $this->form_id, array( $this, 'custom_validation' ), 10, 4 );
1689 1689
 
1690 1690
 		// Needed by the validate funtion
1691 1691
 		$failed_validation_page = NULL;
@@ -1693,14 +1693,14 @@  discard block
 block discarded – undo
1693 1693
 
1694 1694
 		// Prevent entry limit from running when editing an entry, also
1695 1695
 		// prevent form scheduling from preventing editing
1696
-		unset( $this->form['limitEntries'], $this->form['scheduleForm'] );
1696
+		unset( $this->form[ 'limitEntries' ], $this->form[ 'scheduleForm' ] );
1697 1697
 
1698 1698
 		// Hide fields depending on Edit Entry settings
1699
-		$this->form['fields'] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1699
+		$this->form[ 'fields' ] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1700 1700
 
1701 1701
 		$this->is_valid = GFFormDisplay::validate( $this->form, $field_values, 1, $failed_validation_page );
1702 1702
 
1703
-		remove_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10 );
1703
+		remove_filter( 'gform_validation_' . $this->form_id, array( $this, 'custom_validation' ), 10 );
1704 1704
 	}
1705 1705
 
1706 1706
 
@@ -1723,7 +1723,7 @@  discard block
 block discarded – undo
1723 1723
 
1724 1724
 		$gv_valid = true;
1725 1725
 
1726
-		foreach ( $validation_results['form']['fields'] as $key => &$field ) {
1726
+		foreach ( $validation_results[ 'form' ][ 'fields' ] as $key => &$field ) {
1727 1727
 
1728 1728
 			$value = RGFormsModel::get_field_value( $field );
1729 1729
 			$field_type = RGFormsModel::get_input_type( $field );
@@ -1736,22 +1736,22 @@  discard block
 block discarded – undo
1736 1736
 				case 'post_image':
1737 1737
 
1738 1738
 				    // in case nothing is uploaded but there are already files saved
1739
-				    if( !empty( $field->failed_validation ) && !empty( $field->isRequired ) && !empty( $value ) ) {
1739
+				    if ( ! empty( $field->failed_validation ) && ! empty( $field->isRequired ) && ! empty( $value ) ) {
1740 1740
 				        $field->failed_validation = false;
1741 1741
 				        unset( $field->validation_message );
1742 1742
 				    }
1743 1743
 
1744 1744
 				    // validate if multi file upload reached max number of files [maxFiles] => 2
1745
-				    if( \GV\Utils::get( $field, 'maxFiles') && \GV\Utils::get( $field, 'multipleFiles') ) {
1745
+				    if ( \GV\Utils::get( $field, 'maxFiles' ) && \GV\Utils::get( $field, 'multipleFiles' ) ) {
1746 1746
 
1747 1747
 				        $input_name = 'input_' . $field->id;
1748 1748
 				        //uploaded
1749
-				        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] : array();
1749
+				        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ][ $input_name ] : array();
1750 1750
 
1751 1751
 				        //existent
1752 1752
 				        $entry = $this->get_entry();
1753 1753
 				        $value = NULL;
1754
-				        if( isset( $entry[ $field->id ] ) ) {
1754
+				        if ( isset( $entry[ $field->id ] ) ) {
1755 1755
 				            $value = json_decode( $entry[ $field->id ], true );
1756 1756
 				        }
1757 1757
 
@@ -1759,13 +1759,13 @@  discard block
 block discarded – undo
1759 1759
 				        $count_files = ( is_array( $file_names ) ? count( $file_names ) : 0 ) +
1760 1760
 						               ( is_array( $value ) ? count( $value ) : 0 );
1761 1761
 
1762
-				        if( $count_files > $field->maxFiles ) {
1762
+				        if ( $count_files > $field->maxFiles ) {
1763 1763
 				            $field->validation_message = __( 'Maximum number of files reached', 'gravityview' );
1764 1764
 				            $field->failed_validation = 1;
1765 1765
 				            $gv_valid = false;
1766 1766
 
1767 1767
 				            // in case of error make sure the newest upload files are removed from the upload input
1768
-				            GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ] = null;
1768
+				            GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ] = null;
1769 1769
 				        }
1770 1770
 
1771 1771
 				    }
@@ -1776,7 +1776,7 @@  discard block
 block discarded – undo
1776 1776
 			}
1777 1777
 
1778 1778
 			// This field has failed validation.
1779
-			if( !empty( $field->failed_validation ) ) {
1779
+			if ( ! empty( $field->failed_validation ) ) {
1780 1780
 
1781 1781
 				gravityview()->log->debug( 'GravityView_Edit_Entry[custom_validation] Field is invalid.', array( 'data' => array( 'field' => $field, 'value' => $value ) ) );
1782 1782
 
@@ -1794,19 +1794,19 @@  discard block
 block discarded – undo
1794 1794
 				}
1795 1795
 
1796 1796
 				// You can't continue inside a switch, so we do it after.
1797
-				if( empty( $field->failed_validation ) ) {
1797
+				if ( empty( $field->failed_validation ) ) {
1798 1798
 				    continue;
1799 1799
 				}
1800 1800
 
1801 1801
 				// checks if the No Duplicates option is not validating entry against itself, since
1802 1802
 				// we're editing a stored entry, it would also assume it's a duplicate.
1803
-				if( !empty( $field->noDuplicates ) ) {
1803
+				if ( ! empty( $field->noDuplicates ) ) {
1804 1804
 
1805 1805
 				    $entry = $this->get_entry();
1806 1806
 
1807 1807
 				    // If the value of the entry is the same as the stored value
1808 1808
 				    // Then we can assume it's not a duplicate, it's the same.
1809
-				    if( !empty( $entry ) && $value == $entry[ $field->id ] ) {
1809
+				    if ( ! empty( $entry ) && $value == $entry[ $field->id ] ) {
1810 1810
 				        //if value submitted was not changed, then don't validate
1811 1811
 				        $field->failed_validation = false;
1812 1812
 
@@ -1819,7 +1819,7 @@  discard block
 block discarded – undo
1819 1819
 				}
1820 1820
 
1821 1821
 				// if here then probably we are facing the validation 'At least one field must be filled out'
1822
-				if( GFFormDisplay::is_empty( $field, $this->form_id  ) && empty( $field->isRequired ) ) {
1822
+				if ( GFFormDisplay::is_empty( $field, $this->form_id ) && empty( $field->isRequired ) ) {
1823 1823
 				    unset( $field->validation_message );
1824 1824
 	                $field->validation_message = false;
1825 1825
 				    continue;
@@ -1831,12 +1831,12 @@  discard block
 block discarded – undo
1831 1831
 
1832 1832
 		}
1833 1833
 
1834
-		$validation_results['is_valid'] = $gv_valid;
1834
+		$validation_results[ 'is_valid' ] = $gv_valid;
1835 1835
 
1836 1836
 		gravityview()->log->debug( 'GravityView_Edit_Entry[custom_validation] Validation results.', array( 'data' => $validation_results ) );
1837 1837
 
1838 1838
 		// We'll need this result when rendering the form ( on GFFormDisplay::get_form )
1839
-		$this->form_after_validation = $validation_results['form'];
1839
+		$this->form_after_validation = $validation_results[ 'form' ];
1840 1840
 
1841 1841
 		return $validation_results;
1842 1842
 	}
@@ -1849,7 +1849,7 @@  discard block
 block discarded – undo
1849 1849
 	 */
1850 1850
 	public function get_entry() {
1851 1851
 
1852
-		if( empty( $this->entry ) ) {
1852
+		if ( empty( $this->entry ) ) {
1853 1853
 			// Get the database value of the entry that's being edited
1854 1854
 			$this->entry = gravityview_get_entry( GravityView_frontend::is_single_entry() );
1855 1855
 		}
@@ -1881,10 +1881,10 @@  discard block
 block discarded – undo
1881 1881
 		}
1882 1882
 
1883 1883
 		// If edit tab not yet configured, show all fields
1884
-		$edit_fields = !empty( $properties['edit_edit-fields'] ) ? $properties['edit_edit-fields'] : NULL;
1884
+		$edit_fields = ! empty( $properties[ 'edit_edit-fields' ] ) ? $properties[ 'edit_edit-fields' ] : NULL;
1885 1885
 
1886 1886
 		// Hide fields depending on admin settings
1887
-		$fields = $this->filter_fields( $form['fields'], $edit_fields );
1887
+		$fields = $this->filter_fields( $form[ 'fields' ], $edit_fields );
1888 1888
 
1889 1889
 	    // If Edit Entry fields are configured, remove adminOnly field settings. Otherwise, don't.
1890 1890
 	    $fields = $this->filter_admin_only_fields( $fields, $edit_fields, $form, $view_id );
@@ -1917,7 +1917,7 @@  discard block
 block discarded – undo
1917 1917
 	 */
1918 1918
 	private function filter_fields( $fields, $configured_fields ) {
1919 1919
 
1920
-		if( empty( $fields ) || !is_array( $fields ) ) {
1920
+		if ( empty( $fields ) || ! is_array( $fields ) ) {
1921 1921
 			return $fields;
1922 1922
 		}
1923 1923
 
@@ -1934,12 +1934,12 @@  discard block
 block discarded – undo
1934 1934
 
1935 1935
 			// Remove the fields that have calculation properties and keep them to be used later
1936 1936
 			// @since 1.16.2
1937
-			if( $field->has_calculation() ) {
1938
-				$this->fields_with_calculation[] = $field;
1937
+			if ( $field->has_calculation() ) {
1938
+				$this->fields_with_calculation[ ] = $field;
1939 1939
 				// don't remove the calculation fields on form render.
1940 1940
 			}
1941 1941
 
1942
-			if( in_array( $field->type, $field_type_blacklist ) ) {
1942
+			if ( in_array( $field->type, $field_type_blacklist ) ) {
1943 1943
 				unset( $fields[ $key ] );
1944 1944
 			}
1945 1945
 		}
@@ -1957,7 +1957,7 @@  discard block
 block discarded – undo
1957 1957
 					continue; // Same
1958 1958
 				}
1959 1959
 
1960
-				$out_fields[] = $field;
1960
+				$out_fields[ ] = $field;
1961 1961
 			}
1962 1962
 
1963 1963
 			return array_values( $out_fields );
@@ -1968,8 +1968,8 @@  discard block
 block discarded – undo
1968 1968
 
1969 1969
 	        /** @var GF_Field $field */
1970 1970
 	        foreach ( $fields as $field ) {
1971
-				if( intval( $configured_field['id'] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1972
-				    $edit_fields[] = $this->merge_field_properties( $field, $configured_field );
1971
+				if ( intval( $configured_field[ 'id' ] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1972
+				    $edit_fields[ ] = $this->merge_field_properties( $field, $configured_field );
1973 1973
 				    break;
1974 1974
 				}
1975 1975
 
@@ -1992,14 +1992,14 @@  discard block
 block discarded – undo
1992 1992
 
1993 1993
 		$return_field = $field;
1994 1994
 
1995
-		if( empty( $field_setting['show_label'] ) ) {
1995
+		if ( empty( $field_setting[ 'show_label' ] ) ) {
1996 1996
 			$return_field->label = '';
1997
-		} elseif ( !empty( $field_setting['custom_label'] ) ) {
1998
-			$return_field->label = $field_setting['custom_label'];
1997
+		} elseif ( ! empty( $field_setting[ 'custom_label' ] ) ) {
1998
+			$return_field->label = $field_setting[ 'custom_label' ];
1999 1999
 		}
2000 2000
 
2001
-		if( !empty( $field_setting['custom_class'] ) ) {
2002
-			$return_field->cssClass .= ' '. gravityview_sanitize_html_class( $field_setting['custom_class'] );
2001
+		if ( ! empty( $field_setting[ 'custom_class' ] ) ) {
2002
+			$return_field->cssClass .= ' ' . gravityview_sanitize_html_class( $field_setting[ 'custom_class' ] );
2003 2003
 		}
2004 2004
 
2005 2005
 		/**
@@ -2037,16 +2037,16 @@  discard block
 block discarded – undo
2037 2037
 	     */
2038 2038
 	    $use_gf_adminonly_setting = apply_filters( 'gravityview/edit_entry/use_gf_admin_only_setting', empty( $edit_fields ), $form, $view_id );
2039 2039
 
2040
-	    if( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry['id'] ) ) {
2041
-			foreach( $fields as $k => $field ) {
2042
-				if( $field->adminOnly ) {
2040
+	    if ( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry[ 'id' ] ) ) {
2041
+			foreach ( $fields as $k => $field ) {
2042
+				if ( $field->adminOnly ) {
2043 2043
 				    unset( $fields[ $k ] );
2044 2044
 				}
2045 2045
 			}
2046 2046
 			return array_values( $fields );
2047 2047
 		}
2048 2048
 
2049
-	    foreach( $fields as &$field ) {
2049
+	    foreach ( $fields as &$field ) {
2050 2050
 		    $field->adminOnly = false;
2051 2051
 		}
2052 2052
 
@@ -2067,7 +2067,7 @@  discard block
 block discarded – undo
2067 2067
 	 */
2068 2068
 	private function unselect_default_values( $form ) {
2069 2069
 
2070
-	    foreach ( $form['fields'] as &$field ) {
2070
+	    foreach ( $form[ 'fields' ] as &$field ) {
2071 2071
 
2072 2072
 			if ( empty( $field->choices ) ) {
2073 2073
                 continue;
@@ -2075,7 +2075,7 @@  discard block
 block discarded – undo
2075 2075
 
2076 2076
             foreach ( $field->choices as &$choice ) {
2077 2077
 				if ( \GV\Utils::get( $choice, 'isSelected' ) ) {
2078
-					$choice['isSelected'] = false;
2078
+					$choice[ 'isSelected' ] = false;
2079 2079
 				}
2080 2080
 			}
2081 2081
 		}
@@ -2100,22 +2100,22 @@  discard block
 block discarded – undo
2100 2100
 	 */
2101 2101
 	function prefill_conditional_logic( $form ) {
2102 2102
 
2103
-		if( ! GFFormDisplay::has_conditional_logic( $form ) ) {
2103
+		if ( ! GFFormDisplay::has_conditional_logic( $form ) ) {
2104 2104
 			return $form;
2105 2105
 		}
2106 2106
 
2107 2107
 		// Have Conditional Logic pre-fill fields as if the data were default values
2108 2108
 		/** @var GF_Field $field */
2109
-		foreach ( $form['fields'] as &$field ) {
2109
+		foreach ( $form[ 'fields' ] as &$field ) {
2110 2110
 
2111
-			if( 'checkbox' === $field->type ) {
2111
+			if ( 'checkbox' === $field->type ) {
2112 2112
 				foreach ( $field->get_entry_inputs() as $key => $input ) {
2113
-				    $input_id = $input['id'];
2113
+				    $input_id = $input[ 'id' ];
2114 2114
 				    $choice = $field->choices[ $key ];
2115 2115
 				    $value = \GV\Utils::get( $this->entry, $input_id );
2116 2116
 				    $match = RGFormsModel::choice_value_match( $field, $choice, $value );
2117
-				    if( $match ) {
2118
-				        $field->choices[ $key ]['isSelected'] = true;
2117
+				    if ( $match ) {
2118
+				        $field->choices[ $key ][ 'isSelected' ] = true;
2119 2119
 				    }
2120 2120
 				}
2121 2121
 			} else {
@@ -2123,15 +2123,15 @@  discard block
 block discarded – undo
2123 2123
 				// We need to run through each field to set the default values
2124 2124
 				foreach ( $this->entry as $field_id => $field_value ) {
2125 2125
 
2126
-				    if( floatval( $field_id ) === floatval( $field->id ) ) {
2126
+				    if ( floatval( $field_id ) === floatval( $field->id ) ) {
2127 2127
 
2128
-				        if( 'list' === $field->type ) {
2128
+				        if ( 'list' === $field->type ) {
2129 2129
 				            $list_rows = maybe_unserialize( $field_value );
2130 2130
 
2131 2131
 				            $list_field_value = array();
2132
-				            foreach ( (array) $list_rows as $row ) {
2133
-				                foreach ( (array) $row as $column ) {
2134
-				                    $list_field_value[] = $column;
2132
+				            foreach ( (array)$list_rows as $row ) {
2133
+				                foreach ( (array)$row as $column ) {
2134
+				                    $list_field_value[ ] = $column;
2135 2135
 				                }
2136 2136
 				            }
2137 2137
 
@@ -2164,32 +2164,32 @@  discard block
 block discarded – undo
2164 2164
 		 * @see https://github.com/gravityview/GravityView/issues/840
2165 2165
 		 * @since develop
2166 2166
 		 */
2167
-		$the_form = GFAPI::get_form( $form['id'] );
2167
+		$the_form = GFAPI::get_form( $form[ 'id' ] );
2168 2168
 		$editable_ids = array();
2169
-		foreach ( $form['fields'] as $field ) {
2170
-			$editable_ids[] = $field['id']; // wp_list_pluck is destructive in this context
2169
+		foreach ( $form[ 'fields' ] as $field ) {
2170
+			$editable_ids[ ] = $field[ 'id' ]; // wp_list_pluck is destructive in this context
2171 2171
 		}
2172 2172
 		$remove_conditions_rule = array();
2173
-		foreach ( $the_form['fields'] as $field ) {
2174
-			if ( ! empty( $field->conditionalLogic ) && ! empty( $field->conditionalLogic['rules'] ) ) {
2175
-				foreach ( $field->conditionalLogic['rules'] as $i => $rule ) {
2176
-					if ( ! in_array( $rule['fieldId'], $editable_ids ) ) {
2173
+		foreach ( $the_form[ 'fields' ] as $field ) {
2174
+			if ( ! empty( $field->conditionalLogic ) && ! empty( $field->conditionalLogic[ 'rules' ] ) ) {
2175
+				foreach ( $field->conditionalLogic[ 'rules' ] as $i => $rule ) {
2176
+					if ( ! in_array( $rule[ 'fieldId' ], $editable_ids ) ) {
2177 2177
 						/**
2178 2178
 						 * This conditional field is not editable in this View.
2179 2179
 						 * We need to remove the rule, but only if it matches.
2180 2180
 						 */
2181
-						if ( $_field = GFAPI::get_field( $the_form, $rule['fieldId'] ) ) {
2181
+						if ( $_field = GFAPI::get_field( $the_form, $rule[ 'fieldId' ] ) ) {
2182 2182
 							$value = $_field->get_value_export( $this->entry );
2183
-						} elseif ( isset( $this->entry[ $rule['fieldId'] ] ) ) {
2184
-							$value = $this->entry[ $rule['fieldId'] ];
2183
+						} elseif ( isset( $this->entry[ $rule[ 'fieldId' ] ] ) ) {
2184
+							$value = $this->entry[ $rule[ 'fieldId' ] ];
2185 2185
 						} else {
2186
-							$value = gform_get_meta( $this->entry['id'], $rule['fieldId'] );
2186
+							$value = gform_get_meta( $this->entry[ 'id' ], $rule[ 'fieldId' ] );
2187 2187
 						}
2188 2188
 
2189
-						$match = GFFormsModel::matches_operation( $value, $rule['value'], $rule['operator'] );
2189
+						$match = GFFormsModel::matches_operation( $value, $rule[ 'value' ], $rule[ 'operator' ] );
2190 2190
 
2191 2191
 						if ( $match ) {
2192
-							$remove_conditions_rule[] = array( $field['id'], $i );
2192
+							$remove_conditions_rule[ ] = array( $field[ 'id' ], $i );
2193 2193
 						}
2194 2194
 					}
2195 2195
 				}
@@ -2197,21 +2197,21 @@  discard block
 block discarded – undo
2197 2197
 		}
2198 2198
 
2199 2199
 		if ( $remove_conditions_rule ) {
2200
-			foreach ( $form['fields'] as &$field ) {
2200
+			foreach ( $form[ 'fields' ] as &$field ) {
2201 2201
 				foreach ( $remove_conditions_rule as $_remove_conditions_r ) {
2202 2202
 
2203 2203
 				    list( $rule_field_id, $rule_i ) = $_remove_conditions_r;
2204 2204
 
2205
-					if ( $field['id'] == $rule_field_id ) {
2206
-						unset( $field->conditionalLogic['rules'][ $rule_i ] );
2207
-						gravityview()->log->debug( 'Removed conditional rule #{rule} for field {field_id}', array( 'rule' => $rule_i, 'field_id' => $field['id'] ) );
2205
+					if ( $field[ 'id' ] == $rule_field_id ) {
2206
+						unset( $field->conditionalLogic[ 'rules' ][ $rule_i ] );
2207
+						gravityview()->log->debug( 'Removed conditional rule #{rule} for field {field_id}', array( 'rule' => $rule_i, 'field_id' => $field[ 'id' ] ) );
2208 2208
 					}
2209 2209
 				}
2210 2210
 			}
2211 2211
 		}
2212 2212
 
2213 2213
 		/** Normalize the indices... */
2214
-		$form['fields'] = array_values( $form['fields'] );
2214
+		$form[ 'fields' ] = array_values( $form[ 'fields' ] );
2215 2215
 
2216 2216
 		/**
2217 2217
 		 * @filter `gravityview/edit_entry/conditional_logic` Should the Edit Entry form use Gravity Forms conditional logic showing/hiding of fields?
@@ -2221,16 +2221,16 @@  discard block
 block discarded – undo
2221 2221
 		 */
2222 2222
 		$use_conditional_logic = apply_filters( 'gravityview/edit_entry/conditional_logic', true, $form );
2223 2223
 
2224
-		if( $use_conditional_logic ) {
2224
+		if ( $use_conditional_logic ) {
2225 2225
 			return $form;
2226 2226
 		}
2227 2227
 
2228
-		foreach( $form['fields'] as &$field ) {
2228
+		foreach ( $form[ 'fields' ] as &$field ) {
2229 2229
 			/* @var GF_Field $field */
2230 2230
 			$field->conditionalLogic = null;
2231 2231
 		}
2232 2232
 
2233
-		unset( $form['button']['conditionalLogic'] );
2233
+		unset( $form[ 'button' ][ 'conditionalLogic' ] );
2234 2234
 
2235 2235
 		return $form;
2236 2236
 
@@ -2247,7 +2247,7 @@  discard block
 block discarded – undo
2247 2247
 	 */
2248 2248
 	public function manage_conditional_logic( $has_conditional_logic, $form ) {
2249 2249
 
2250
-		if( ! $this->is_edit_entry() ) {
2250
+		if ( ! $this->is_edit_entry() ) {
2251 2251
 			return $has_conditional_logic;
2252 2252
 		}
2253 2253
 
@@ -2279,44 +2279,44 @@  discard block
 block discarded – undo
2279 2279
 		 *  2. There are two entries embedded using oEmbed
2280 2280
 		 *  3. One of the entries has just been saved
2281 2281
 		 */
2282
-		if( !empty( $_POST['lid'] ) && !empty( $_GET['entry'] ) && ( $_POST['lid'] !== $_GET['entry'] ) ) {
2282
+		if ( ! empty( $_POST[ 'lid' ] ) && ! empty( $_GET[ 'entry' ] ) && ( $_POST[ 'lid' ] !== $_GET[ 'entry' ] ) ) {
2283 2283
 
2284 2284
 			$error = true;
2285 2285
 
2286 2286
 		}
2287 2287
 
2288
-		if( !empty( $_GET['entry'] ) && (string)$this->entry['id'] !== $_GET['entry'] ) {
2288
+		if ( ! empty( $_GET[ 'entry' ] ) && (string)$this->entry[ 'id' ] !== $_GET[ 'entry' ] ) {
2289 2289
 
2290 2290
 			$error = true;
2291 2291
 
2292
-		} elseif( ! $this->verify_nonce() ) {
2292
+		} elseif ( ! $this->verify_nonce() ) {
2293 2293
 
2294 2294
 			/**
2295 2295
 			 * If the Entry is embedded, there may be two entries on the same page.
2296 2296
 			 * If that's the case, and one is being edited, the other should fail gracefully and not display an error.
2297 2297
 			 */
2298
-			if( GravityView_oEmbed::getInstance()->get_entry_id() ) {
2298
+			if ( GravityView_oEmbed::getInstance()->get_entry_id() ) {
2299 2299
 				$error = true;
2300 2300
 			} else {
2301
-				$error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview');
2301
+				$error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview' );
2302 2302
 			}
2303 2303
 
2304 2304
 		}
2305 2305
 
2306
-		if( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
2307
-			$error = __( 'You do not have permission to edit this entry.', 'gravityview');
2306
+		if ( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
2307
+			$error = __( 'You do not have permission to edit this entry.', 'gravityview' );
2308 2308
 		}
2309 2309
 
2310
-		if( $this->entry['status'] === 'trash' ) {
2311
-			$error = __('You cannot edit the entry; it is in the trash.', 'gravityview' );
2310
+		if ( $this->entry[ 'status' ] === 'trash' ) {
2311
+			$error = __( 'You cannot edit the entry; it is in the trash.', 'gravityview' );
2312 2312
 		}
2313 2313
 
2314 2314
 		// No errors; everything's fine here!
2315
-		if( empty( $error ) ) {
2315
+		if ( empty( $error ) ) {
2316 2316
 			return true;
2317 2317
 		}
2318 2318
 
2319
-		if( $echo && $error !== true ) {
2319
+		if ( $echo && $error !== true ) {
2320 2320
 
2321 2321
 	        $error = esc_html( $error );
2322 2322
 
@@ -2324,10 +2324,10 @@  discard block
 block discarded – undo
2324 2324
 	         * @since 1.9
2325 2325
 	         */
2326 2326
 	        if ( ! empty( $this->entry ) ) {
2327
-		        $error .= ' ' . gravityview_get_link( '#', _x('Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
2327
+		        $error .= ' ' . gravityview_get_link( '#', _x( 'Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
2328 2328
 	        }
2329 2329
 
2330
-			echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error');
2330
+			echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error' );
2331 2331
 		}
2332 2332
 
2333 2333
 		gravityview()->log->error( '{error}', array( 'error' => $error ) );
@@ -2347,17 +2347,17 @@  discard block
 block discarded – undo
2347 2347
 
2348 2348
 		$error = NULL;
2349 2349
 
2350
-		if( ! $this->check_user_cap_edit_field( $field ) ) {
2351
-			$error = __( 'You do not have permission to edit this field.', 'gravityview');
2350
+		if ( ! $this->check_user_cap_edit_field( $field ) ) {
2351
+			$error = __( 'You do not have permission to edit this field.', 'gravityview' );
2352 2352
 		}
2353 2353
 
2354 2354
 		// No errors; everything's fine here!
2355
-		if( empty( $error ) ) {
2355
+		if ( empty( $error ) ) {
2356 2356
 			return true;
2357 2357
 		}
2358 2358
 
2359
-		if( $echo ) {
2360
-			echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error');
2359
+		if ( $echo ) {
2360
+			echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error' );
2361 2361
 		}
2362 2362
 
2363 2363
 		gravityview()->log->error( '{error}', array( 'error' => $error ) );
@@ -2378,14 +2378,14 @@  discard block
 block discarded – undo
2378 2378
 	private function check_user_cap_edit_field( $field ) {
2379 2379
 
2380 2380
 		// If they can edit any entries (as defined in Gravity Forms), we're good.
2381
-		if( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
2381
+		if ( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
2382 2382
 			return true;
2383 2383
 		}
2384 2384
 
2385
-		$field_cap = isset( $field['allow_edit_cap'] ) ? $field['allow_edit_cap'] : false;
2385
+		$field_cap = isset( $field[ 'allow_edit_cap' ] ) ? $field[ 'allow_edit_cap' ] : false;
2386 2386
 
2387
-		if( $field_cap ) {
2388
-			return GVCommon::has_cap( $field['allow_edit_cap'] );
2387
+		if ( $field_cap ) {
2388
+			return GVCommon::has_cap( $field[ 'allow_edit_cap' ] );
2389 2389
 		}
2390 2390
 
2391 2391
 		return false;
@@ -2399,17 +2399,17 @@  discard block
 block discarded – undo
2399 2399
 	public function verify_nonce() {
2400 2400
 
2401 2401
 		// Verify form submitted for editing single
2402
-		if( $this->is_edit_entry_submission() ) {
2402
+		if ( $this->is_edit_entry_submission() ) {
2403 2403
 			$valid = wp_verify_nonce( $_POST[ self::$nonce_field ], self::$nonce_field );
2404 2404
 		}
2405 2405
 
2406 2406
 		// Verify
2407
-		else if( ! $this->is_edit_entry() ) {
2407
+		else if ( ! $this->is_edit_entry() ) {
2408 2408
 			$valid = false;
2409 2409
 		}
2410 2410
 
2411 2411
 		else {
2412
-			$valid = wp_verify_nonce( $_GET['edit'], self::$nonce_key );
2412
+			$valid = wp_verify_nonce( $_GET[ 'edit' ], self::$nonce_key );
2413 2413
 		}
2414 2414
 
2415 2415
 		/**
Please login to merge, or discard this patch.
future/includes/class-gv-view.php 1 patch
Spacing   +79 added lines, -80 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
 		$supports = array( 'title', 'revisions' );
126 126
 
127 127
 		if ( $is_hierarchical ) {
128
-			$supports[] = 'page-attributes';
128
+			$supports[ ] = 'page-attributes';
129 129
 		}
130 130
 
131 131
 		/**
@@ -227,11 +227,11 @@  discard block
 block discarded – undo
227 227
 		$rule = array( sprintf( '%s/([^/]+)/csv/?', $slug ), 'index.php?gravityview=$matches[1]&csv=1', 'top' );
228 228
 
229 229
 		add_filter( 'query_vars', function( $query_vars ) { 
230
-			$query_vars[] = 'csv';
230
+			$query_vars[ ] = 'csv';
231 231
 			return $query_vars;
232 232
 		} );
233 233
 
234
-		if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[0] ] ) ) {
234
+		if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[ 0 ] ] ) ) {
235 235
 			call_user_func_array( 'add_rewrite_rule', $rule );
236 236
 		}
237 237
 	}
@@ -308,13 +308,13 @@  discard block
 block discarded – undo
308 308
 			return $content;
309 309
 		}
310 310
 
311
-		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap('gravityview_moderate_entries', $view->ID );
311
+		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap( 'gravityview_moderate_entries', $view->ID );
312 312
 
313 313
 		/**
314 314
 		 * Editing a single entry.
315 315
 		 */
316 316
 		if ( $entry = $request->is_edit_entry( $view->form ? $view->form->ID : 0 ) ) {
317
-			if ( $entry['status'] != 'active' ) {
317
+			if ( $entry[ 'status' ] != 'active' ) {
318 318
 				gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
319 319
 				return __( 'You are not allowed to view this content.', 'gravityview' );
320 320
 			}
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
325 325
 			}
326 326
 
327 327
 			if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
328
-				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
328
+				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
329 329
 					gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
330 330
 					return __( 'You are not allowed to view this content.', 'gravityview' );
331 331
 				}
@@ -348,7 +348,7 @@  discard block
 block discarded – undo
348 348
 
349 349
 			foreach ( $entryset as $e ) {
350 350
 
351
-				if ( 'active' !== $e['status'] ) {
351
+				if ( 'active' !== $e[ 'status' ] ) {
352 352
 					gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $e->ID ) );
353 353
 					return __( 'You are not allowed to view this content.', 'gravityview' );
354 354
 				}
@@ -359,7 +359,7 @@  discard block
 block discarded – undo
359 359
 				}
360 360
 
361 361
 				if ( $show_only_approved && ! $is_admin_and_can_view ) {
362
-					if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $e->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
362
+					if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $e->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
363 363
 						gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $e->ID ) );
364 364
 						return __( 'You are not allowed to view this content.', 'gravityview' );
365 365
 					}
@@ -534,7 +534,7 @@  discard block
 block discarded – undo
534 534
 			$join_column    = is_numeric( $join_column ) ? GF_Field::by_id( $join, $join_column ) : Internal_Field::by_id( $join_column );
535 535
 			$join_on_column = is_numeric( $join_on_column ) ? GF_Field::by_id( $join_on, $join_on_column ) : Internal_Field::by_id( $join_on_column );
536 536
 
537
-			$joins [] = new Join( $join, $join_column, $join_on, $join_on_column );
537
+			$joins [ ] = new Join( $join, $join_column, $join_on, $join_on_column );
538 538
 		}
539 539
 
540 540
 		return $joins;
@@ -624,13 +624,13 @@  discard block
 block discarded – undo
624 624
 			}
625 625
 
626 626
 			foreach ( $_fields as $field ) {
627
-				if ( ! empty( $field['unions'] ) ) {
628
-					foreach ( $field['unions'] as $form_id => $field_id ) {
627
+				if ( ! empty( $field[ 'unions' ] ) ) {
628
+					foreach ( $field[ 'unions' ] as $form_id => $field_id ) {
629 629
 						if ( ! isset( $unions[ $form_id ] ) ) {
630 630
 							$unions[ $form_id ] = array();
631 631
 						}
632 632
 
633
-						$unions[ $form_id ][ $field['id'] ] =
633
+						$unions[ $form_id ][ $field[ 'id' ] ] =
634 634
 							is_numeric( $field_id ) ? \GV\GF_Field::by_id( \GV\GF_Form::by_id( $form_id ), $field_id ) : \GV\Internal_Field::by_id( $field_id );
635 635
 					}
636 636
 				}
@@ -685,7 +685,7 @@  discard block
 block discarded – undo
685 685
 		if ( ! $view->form ) {
686 686
 			gravityview()->log->error( 'View #{view_id} tried attaching non-existent Form #{form_id} to it.', array(
687 687
 				'view_id' => $view->ID,
688
-				'form_id' => $view->_gravityview_form_id ? : 0,
688
+				'form_id' => $view->_gravityview_form_id ?: 0,
689 689
 			) );
690 690
 		}
691 691
 
@@ -924,11 +924,11 @@  discard block
 block discarded – undo
924 924
 			 * Remove multiple sorting before calling legacy filters.
925 925
 			 * This allows us to fake it till we make it.
926 926
 			 */
927
-			if ( ! empty( $parameters['sort_field'] ) && is_array( $parameters['sort_field'] ) ) {
927
+			if ( ! empty( $parameters[ 'sort_field' ] ) && is_array( $parameters[ 'sort_field' ] ) ) {
928 928
 				$has_multisort = true;
929
-				$parameters['sort_field'] = reset( $parameters['sort_field'] );
930
-				if ( ! empty( $parameters['sort_direction'] ) && is_array( $parameters['sort_direction'] ) ) {
931
-					$parameters['sort_direction'] = reset( $parameters['sort_direction'] );
929
+				$parameters[ 'sort_field' ] = reset( $parameters[ 'sort_field' ] );
930
+				if ( ! empty( $parameters[ 'sort_direction' ] ) && is_array( $parameters[ 'sort_direction' ] ) ) {
931
+					$parameters[ 'sort_direction' ] = reset( $parameters[ 'sort_direction' ] );
932 932
 				}
933 933
 			}
934 934
 
@@ -937,31 +937,30 @@  discard block
 block discarded – undo
937 937
 			 */
938 938
 			$parameters = \GravityView_frontend::get_view_entries_parameters( $parameters, $this->form->ID );
939 939
 
940
-			$parameters['context_view_id'] = $this->ID;
940
+			$parameters[ 'context_view_id' ] = $this->ID;
941 941
 			$parameters = \GVCommon::calculate_get_entries_criteria( $parameters, $this->form->ID );
942 942
 
943 943
 			if ( ! is_array( $parameters ) ) {
944 944
 				$parameters = array();
945 945
 			}
946 946
 
947
-			if ( ! is_array( $parameters['search_criteria'] ) ) {
948
-				$parameters['search_criteria'] = array();
947
+			if ( ! is_array( $parameters[ 'search_criteria' ] ) ) {
948
+				$parameters[ 'search_criteria' ] = array();
949 949
 			}
950 950
 
951
-			if ( ( ! isset( $parameters['search_criteria']['field_filters'] ) ) || ( ! is_array( $parameters['search_criteria']['field_filters'] ) ) ) {
952
-				$parameters['search_criteria']['field_filters'] = array();
951
+			if ( ( ! isset( $parameters[ 'search_criteria' ][ 'field_filters' ] ) ) || ( ! is_array( $parameters[ 'search_criteria' ][ 'field_filters' ] ) ) ) {
952
+				$parameters[ 'search_criteria' ][ 'field_filters' ] = array();
953 953
 			}
954 954
 
955 955
 			if ( $request instanceof REST\Request ) {
956 956
 				$atts = $this->settings->as_atts();
957 957
 				$paging_parameters = wp_parse_args( $request->get_paging(), array(
958
-						'paging' => array( 'page_size' => $atts['page_size'] ),
958
+						'paging' => array( 'page_size' => $atts[ 'page_size' ] ),
959 959
 					) );
960
-				$parameters['paging'] = $paging_parameters['paging'];
960
+				$parameters[ 'paging' ] = $paging_parameters[ 'paging' ];
961 961
 			}
962 962
 
963
-			$page = Utils::get( $parameters['paging'], 'current_page' ) ?
964
-				: ( ( ( $parameters['paging']['offset'] - $this->settings->get( 'offset' ) ) / $parameters['paging']['page_size'] ) + 1 );
963
+			$page = Utils::get( $parameters[ 'paging' ], 'current_page' ) ?: ( ( ( $parameters[ 'paging' ][ 'offset' ] - $this->settings->get( 'offset' ) ) / $parameters[ 'paging' ][ 'page_size' ] ) + 1 );
965 964
 
966 965
 			/**
967 966
 			 * Cleanup duplicate field_filter parameters to simplify the query.
@@ -969,14 +968,14 @@  discard block
 block discarded – undo
969 968
 			$unique_field_filters = array();
970 969
 			foreach ( Utils::get( $parameters, 'search_criteria/field_filters', array() ) as $key => $filter ) {
971 970
 				if ( 'mode' === $key ) {
972
-					$unique_field_filters['mode'] = $filter;
971
+					$unique_field_filters[ 'mode' ] = $filter;
973 972
 				} else if ( ! in_array( $filter, $unique_field_filters ) ) {
974
-					$unique_field_filters[] = $filter;
973
+					$unique_field_filters[ ] = $filter;
975 974
 				}
976 975
 			}
977
-			$parameters['search_criteria']['field_filters'] = $unique_field_filters;
976
+			$parameters[ 'search_criteria' ][ 'field_filters' ] = $unique_field_filters;
978 977
 
979
-			if ( ! empty( $parameters['search_criteria']['field_filters'] ) ) {
978
+			if ( ! empty( $parameters[ 'search_criteria' ][ 'field_filters' ] ) ) {
980 979
 				gravityview()->log->notice( 'search_criteria/field_filters is not empty, third-party code may be using legacy search_criteria filters.' );
981 980
 			}
982 981
 
@@ -985,7 +984,7 @@  discard block
 block discarded – undo
985 984
 				$query_class = $this->get_query_class();
986 985
 
987 986
 				/** @var \GF_Query $query */
988
-				$query = new $query_class( $this->form->ID, $parameters['search_criteria'], Utils::get( $parameters, 'sorting' ) );
987
+				$query = new $query_class( $this->form->ID, $parameters[ 'search_criteria' ], Utils::get( $parameters, 'sorting' ) );
989 988
 
990 989
 				/**
991 990
 				 * Apply multisort.
@@ -996,15 +995,15 @@  discard block
 block discarded – undo
996 995
 					$view_setting_sort_field_ids = \GV\Utils::get( $atts, 'sort_field', array() );
997 996
 					$view_setting_sort_directions = \GV\Utils::get( $atts, 'sort_direction', array() );
998 997
 
999
-					$has_sort_query_param = ! empty( $_GET['sort'] ) && is_array( $_GET['sort'] );
998
+					$has_sort_query_param = ! empty( $_GET[ 'sort' ] ) && is_array( $_GET[ 'sort' ] );
1000 999
 
1001
-					if( $has_sort_query_param ) {
1002
-						$has_sort_query_param = array_filter( array_values( $_GET['sort'] ) );
1000
+					if ( $has_sort_query_param ) {
1001
+						$has_sort_query_param = array_filter( array_values( $_GET[ 'sort' ] ) );
1003 1002
 					}
1004 1003
 
1005 1004
 					if ( $this->settings->get( 'sort_columns' ) && $has_sort_query_param ) {
1006
-						$sort_field_ids = array_keys( $_GET['sort'] );
1007
-						$sort_directions = array_values( $_GET['sort'] );
1005
+						$sort_field_ids = array_keys( $_GET[ 'sort' ] );
1006
+						$sort_directions = array_values( $_GET[ 'sort' ] );
1008 1007
 					} else {
1009 1008
 						$sort_field_ids = $view_setting_sort_field_ids;
1010 1009
 						$sort_directions = $view_setting_sort_directions;
@@ -1012,7 +1011,7 @@  discard block
 block discarded – undo
1012 1011
 
1013 1012
 					$skip_first = false;
1014 1013
 
1015
-					foreach ( (array) $sort_field_ids as $key => $sort_field_id ) {
1014
+					foreach ( (array)$sort_field_ids as $key => $sort_field_id ) {
1016 1015
 
1017 1016
 						if ( ! $skip_first && ! $has_sort_query_param ) {
1018 1017
 							$skip_first = true; // Skip the first one, it's already in the query
@@ -1042,15 +1041,15 @@  discard block
 block discarded – undo
1042 1041
 
1043 1042
 					$merged_time = false;
1044 1043
 
1045
-					foreach ( $q['order'] as $oid => $order ) {
1046
-						if ( $order[0] instanceof \GF_Query_Column ) {
1047
-							$column = $order[0];
1048
-						} else if ( $order[0] instanceof \GF_Query_Call ) {
1049
-							if ( count( $order[0]->columns ) != 1 || ! $order[0]->columns[0] instanceof \GF_Query_Column ) {
1044
+					foreach ( $q[ 'order' ] as $oid => $order ) {
1045
+						if ( $order[ 0 ] instanceof \GF_Query_Column ) {
1046
+							$column = $order[ 0 ];
1047
+						} else if ( $order[ 0 ] instanceof \GF_Query_Call ) {
1048
+							if ( count( $order[ 0 ]->columns ) != 1 || ! $order[ 0 ]->columns[ 0 ] instanceof \GF_Query_Column ) {
1050 1049
 								$orders[ $oid ] = $order;
1051 1050
 								continue; // Need something that resembles a single sort
1052 1051
 							}
1053
-							$column = $order[0]->columns[0];
1052
+							$column = $order[ 0 ]->columns[ 0 ];
1054 1053
 						}
1055 1054
 
1056 1055
 						if ( ( ! $field = \GFAPI::get_field( $column->source, $column->field_id ) ) || $field->type !== 'time' ) {
@@ -1064,7 +1063,7 @@  discard block
 block discarded – undo
1064 1063
 
1065 1064
 						$orders[ $oid ] = array(
1066 1065
 							new \GV\Mocks\GF_Query_Call_TIMESORT( 'timesort', array( $column, $sql ) ),
1067
-							$order[1] // Mock it!
1066
+							$order[ 1 ] // Mock it!
1068 1067
 						);
1069 1068
 
1070 1069
 						$merged_time = true;
@@ -1075,15 +1074,15 @@  discard block
 block discarded – undo
1075 1074
 						 * ORDER again.
1076 1075
 						 */
1077 1076
 						if ( ! empty( $orders ) && $_orders = $query->_order_generate( $orders ) ) {
1078
-							$sql['order'] = 'ORDER BY ' . implode( ', ', $_orders );
1077
+							$sql[ 'order' ] = 'ORDER BY ' . implode( ', ', $_orders );
1079 1078
 						}
1080 1079
 					}
1081 1080
 
1082 1081
 					return $sql;
1083 1082
 				} );
1084 1083
 
1085
-				$query->limit( $parameters['paging']['page_size'] )
1086
-					->offset( ( ( $page - 1 ) * $parameters['paging']['page_size'] ) + $this->settings->get( 'offset' ) );
1084
+				$query->limit( $parameters[ 'paging' ][ 'page_size' ] )
1085
+					->offset( ( ( $page - 1 ) * $parameters[ 'paging' ][ 'page_size' ] ) + $this->settings->get( 'offset' ) );
1087 1086
 
1088 1087
 				/**
1089 1088
 				 * Any joins?
@@ -1106,7 +1105,7 @@  discard block
 block discarded – undo
1106 1105
 
1107 1106
 							$query_parameters = $query->_introspect();
1108 1107
 
1109
-							$query->where( \GF_Query_Condition::_and( $query_parameters['where'], $condition ) );
1108
+							$query->where( \GF_Query_Condition::_and( $query_parameters[ 'where' ], $condition ) );
1110 1109
 						}
1111 1110
 
1112 1111
 						/**
@@ -1140,7 +1139,7 @@  discard block
 block discarded – undo
1140 1139
 						}
1141 1140
 
1142 1141
 						$q = $query->_introspect();
1143
-						$query->where( \GF_Query_Condition::_and( $q['where'], $condition ) );
1142
+						$query->where( \GF_Query_Condition::_and( $q[ 'where' ], $condition ) );
1144 1143
 
1145 1144
 						if ( $this->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
1146 1145
 
@@ -1165,7 +1164,7 @@  discard block
 block discarded – undo
1165 1164
 
1166 1165
 							$query_parameters = $query->_introspect();
1167 1166
 
1168
-							$query->where( \GF_Query_Condition::_and( $query_parameters['where'], $condition ) );
1167
+							$query->where( \GF_Query_Condition::_and( $query_parameters[ 'where' ], $condition ) );
1169 1168
 						}
1170 1169
 					}
1171 1170
 				
@@ -1189,7 +1188,7 @@  discard block
 block discarded – undo
1189 1188
 							$conditions = array();
1190 1189
 
1191 1190
 							foreach ( $condition->expressions as $_condition ) {
1192
-								$conditions[] = $recurse( $_condition, $fields, $recurse );
1191
+								$conditions[ ] = $recurse( $_condition, $fields, $recurse );
1193 1192
 							}
1194 1193
 
1195 1194
 							return call_user_func_array(
@@ -1218,10 +1217,10 @@  discard block
 block discarded – undo
1218 1217
 						$q = new $query_class( $form_id );
1219 1218
 
1220 1219
 						// Copy the WHERE clauses but substitute the field_ids to the respective ones
1221
-						$q->where( $where_union_substitute( $query_parameters['where'], $fields, $where_union_substitute ) );
1220
+						$q->where( $where_union_substitute( $query_parameters[ 'where' ], $fields, $where_union_substitute ) );
1222 1221
 
1223 1222
 						// Copy the ORDER clause and substitute the field_ids to the respective ones
1224
-						foreach ( $query_parameters['order'] as $order ) {
1223
+						foreach ( $query_parameters[ 'order' ] as $order ) {
1225 1224
 							list( $column, $_order ) = $order;
1226 1225
 
1227 1226
 							if ( $column && $column instanceof \GF_Query_Column ) {
@@ -1235,15 +1234,15 @@  discard block
 block discarded – undo
1235 1234
 
1236 1235
 						add_filter( 'gform_gf_query_sql', $gf_query_sql_callback = function( $sql ) use ( &$unions_sql ) {
1237 1236
 							// Remove SQL_CALC_FOUND_ROWS as it's not needed in UNION clauses
1238
-							$select = 'UNION ALL ' . str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql['select'] );
1237
+							$select = 'UNION ALL ' . str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql[ 'select' ] );
1239 1238
 
1240 1239
 							// Record the SQL
1241
-							$unions_sql[] = array(
1240
+							$unions_sql[ ] = array(
1242 1241
 								// Remove columns, we'll rebuild them
1243 1242
 								'select'  => preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $select ),
1244
-								'from'    => $sql['from'],
1245
-								'join'    => $sql['join'],
1246
-								'where'   => $sql['where'],
1243
+								'from'    => $sql[ 'from' ],
1244
+								'join'    => $sql[ 'join' ],
1245
+								'where'   => $sql[ 'where' ],
1247 1246
 								// Remove order and limit
1248 1247
 							);
1249 1248
 
@@ -1260,11 +1259,11 @@  discard block
 block discarded – undo
1260 1259
 
1261 1260
 					add_filter( 'gform_gf_query_sql', $gf_query_sql_callback = function( $sql ) use ( $unions_sql ) {
1262 1261
 						// Remove SQL_CALC_FOUND_ROWS as it's not needed in UNION clauses
1263
-						$sql['select'] = str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql['select'] );
1262
+						$sql[ 'select' ] = str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql[ 'select' ] );
1264 1263
 
1265 1264
 						// Remove columns, we'll rebuild them
1266
-						preg_match( '#DISTINCT (`[motc]\d+`.`.*?`)#', $sql['select'], $select_match );
1267
-						$sql['select'] = preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $sql['select'] );
1265
+						preg_match( '#DISTINCT (`[motc]\d+`.`.*?`)#', $sql[ 'select' ], $select_match );
1266
+						$sql[ 'select' ] = preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $sql[ 'select' ] );
1268 1267
 
1269 1268
 						$unions = array();
1270 1269
 
@@ -1275,30 +1274,30 @@  discard block
 block discarded – undo
1275 1274
 						};
1276 1275
 
1277 1276
 						// Add all the order columns into the selects, so we can order by the whole union group
1278
-						preg_match_all( '#(`[motc]\d+`.`.*?`)#', $sql['order'], $order_matches );
1277
+						preg_match_all( '#(`[motc]\d+`.`.*?`)#', $sql[ 'order' ], $order_matches );
1279 1278
 						
1280 1279
 						$columns = array(
1281
-							sprintf( '%s AS %s', $select_match[1], $column_to_alias( $select_match[1] ) )
1280
+							sprintf( '%s AS %s', $select_match[ 1 ], $column_to_alias( $select_match[ 1 ] ) )
1282 1281
 						);
1283 1282
 
1284 1283
 						foreach ( array_slice( $order_matches, 1 ) as $match ) {
1285
-							$columns[] = sprintf( '%s AS %s', $match[0], $column_to_alias( $match[0] ) );
1284
+							$columns[ ] = sprintf( '%s AS %s', $match[ 0 ], $column_to_alias( $match[ 0 ] ) );
1286 1285
 
1287 1286
 							// Rewrite the order columns to the shared aliases
1288
-							$sql['order'] = str_replace( $match[0], $column_to_alias( $match[0] ), $sql['order'] );
1287
+							$sql[ 'order' ] = str_replace( $match[ 0 ], $column_to_alias( $match[ 0 ] ), $sql[ 'order' ] );
1289 1288
 						}
1290 1289
 
1291 1290
 						$columns = array_unique( $columns );
1292 1291
 
1293 1292
 						// Add the columns to every UNION
1294 1293
 						foreach ( $unions_sql as $union_sql ) {
1295
-							$union_sql['select'] .= implode( ', ', $columns );
1296
-							$unions []= implode( ' ', $union_sql );
1294
+							$union_sql[ 'select' ] .= implode( ', ', $columns );
1295
+							$unions [ ] = implode( ' ', $union_sql );
1297 1296
 						}
1298 1297
 
1299 1298
 						// Add the columns to the main SELECT, but only grab the entry id column
1300
-						$sql['select'] = 'SELECT SQL_CALC_FOUND_ROWS t1_id FROM (' . $sql['select'] . implode( ', ', $columns );
1301
-						$sql['order'] = implode( ' ', $unions ) . ') AS u ' . $sql['order'];
1299
+						$sql[ 'select' ] = 'SELECT SQL_CALC_FOUND_ROWS t1_id FROM (' . $sql[ 'select' ] . implode( ', ', $columns );
1300
+						$sql[ 'order' ] = implode( ' ', $unions ) . ') AS u ' . $sql[ 'order' ];
1302 1301
 
1303 1302
 						return $sql;
1304 1303
 					} );
@@ -1343,20 +1342,20 @@  discard block
 block discarded – undo
1343 1342
 				} );
1344 1343
 			} else {
1345 1344
 				$entries = $this->form->entries
1346
-					->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters['search_criteria'] ) )
1345
+					->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters[ 'search_criteria' ] ) )
1347 1346
 					->offset( $this->settings->get( 'offset' ) )
1348
-					->limit( $parameters['paging']['page_size'] )
1347
+					->limit( $parameters[ 'paging' ][ 'page_size' ] )
1349 1348
 					->page( $page );
1350 1349
 
1351
-				if ( ! empty( $parameters['sorting'] ) && is_array( $parameters['sorting'] && ! isset( $parameters['sorting']['key'] ) ) ) {
1350
+				if ( ! empty( $parameters[ 'sorting' ] ) && is_array( $parameters[ 'sorting' ] && ! isset( $parameters[ 'sorting' ][ 'key' ] ) ) ) {
1352 1351
 					// Pluck off multisort arrays
1353
-					$parameters['sorting'] = $parameters['sorting'][0];
1352
+					$parameters[ 'sorting' ] = $parameters[ 'sorting' ][ 0 ];
1354 1353
 				}
1355 1354
 
1356
-				if ( ! empty( $parameters['sorting'] ) && ! empty( $parameters['sorting']['key'] ) ) {
1355
+				if ( ! empty( $parameters[ 'sorting' ] ) && ! empty( $parameters[ 'sorting' ][ 'key' ] ) ) {
1357 1356
 					$field = new \GV\Field();
1358
-					$field->ID = $parameters['sorting']['key'];
1359
-					$direction = strtolower( $parameters['sorting']['direction'] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
1357
+					$field->ID = $parameters[ 'sorting' ][ 'key' ];
1358
+					$direction = strtolower( $parameters[ 'sorting' ][ 'direction' ] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
1360 1359
 					$entries = $entries->sort( new \GV\Entry_Sort( $field, $direction ) );
1361 1360
 				}
1362 1361
 			}
@@ -1431,7 +1430,7 @@  discard block
 block discarded – undo
1431 1430
 		$allowed = $headers = array();
1432 1431
 
1433 1432
 		foreach ( $view->fields->by_position( "directory_*" )->by_visible( $view )->all() as $id => $field ) {
1434
-			$allowed[] = $field;
1433
+			$allowed[ ] = $field;
1435 1434
 		}
1436 1435
 
1437 1436
 		$renderer = new Field_Renderer();
@@ -1453,17 +1452,17 @@  discard block
 block discarded – undo
1453 1452
 			} );
1454 1453
 
1455 1454
 			foreach ( array_diff( $allowed_field_ids, wp_list_pluck( $allowed, 'ID' ) ) as $field_id ) {
1456
-				$allowed[] = is_numeric( $field_id ) ? \GV\GF_Field::by_id( $view->form, $field_id ) : \GV\Internal_Field::by_id( $field_id );
1455
+				$allowed[ ] = is_numeric( $field_id ) ? \GV\GF_Field::by_id( $view->form, $field_id ) : \GV\Internal_Field::by_id( $field_id );
1457 1456
 			}
1458 1457
 
1459 1458
 			foreach ( $allowed as $field ) {
1460 1459
 				$source = is_numeric( $field->ID ) ? $view->form : new \GV\Internal_Source();
1461 1460
 
1462
-				$return[] = $renderer->render( $field, $view, $source, $entry, gravityview()->request, '\GV\Field_CSV_Template' );
1461
+				$return[ ] = $renderer->render( $field, $view, $source, $entry, gravityview()->request, '\GV\Field_CSV_Template' );
1463 1462
 
1464 1463
 				if ( ! $headers_done ) {
1465 1464
 					$label = $field->get_label( $view, $source, $entry );
1466
-					$headers[] = $label ? $label : $field->ID;
1465
+					$headers[ ] = $label ? $label : $field->ID;
1467 1466
 				}
1468 1467
 			}
1469 1468
 
Please login to merge, or discard this patch.
includes/class-common.php 1 patch
Spacing   +111 added lines, -111 removed lines patch added patch discarded remove patch
@@ -125,8 +125,8 @@  discard block
 block discarded – undo
125 125
 
126 126
 		$form = false;
127 127
 
128
-		if( $entry ) {
129
-			$form = GFAPI::get_form( $entry['form_id'] );
128
+		if ( $entry ) {
129
+			$form = GFAPI::get_form( $entry[ 'form_id' ] );
130 130
 		}
131 131
 
132 132
 		return $form;
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
 			}
203 203
 		}
204 204
 
205
-		return (bool) $has_transaction_data;
205
+		return (bool)$has_transaction_data;
206 206
 	}
207 207
 
208 208
 	/**
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
 
241 241
 		$results = GFAPI::get_entries( intval( $form_id ), $search_criteria, null, $paging );
242 242
 
243
-		$result = ( ! empty( $results ) && ! empty( $results[0]['id'] ) ) ? $results[0]['id'] : null;
243
+		$result = ( ! empty( $results ) && ! empty( $results[ 0 ][ 'id' ] ) ) ? $results[ 0 ][ 'id' ] : null;
244 244
 
245 245
 		return $result;
246 246
 	}
@@ -257,10 +257,10 @@  discard block
 block discarded – undo
257 257
 	 *
258 258
 	 * @return array Empty array if GFAPI class isn't available or no forms. Otherwise, the array of Forms
259 259
 	 */
260
-	public static function get_forms(  $active = true, $trash = false ) {
260
+	public static function get_forms( $active = true, $trash = false ) {
261 261
 		$forms = array();
262 262
 		if ( class_exists( 'GFAPI' ) ) {
263
-			if( 'any' === $active ) {
263
+			if ( 'any' === $active ) {
264 264
 				$active_forms = GFAPI::get_forms( true, $trash );
265 265
 				$inactive_forms = GFAPI::get_forms( false, $trash );
266 266
 				$forms = array_merge( array_filter( $active_forms ), array_filter( $inactive_forms ) );
@@ -291,9 +291,9 @@  discard block
 block discarded – undo
291 291
 		$has_post_fields = false;
292 292
 
293 293
 		if ( $form ) {
294
-			foreach ( $form['fields'] as $field ) {
295
-				if ( $include_parent_field || empty( $field['inputs'] ) ) {
296
-					$fields["{$field['id']}"] = array(
294
+			foreach ( $form[ 'fields' ] as $field ) {
295
+				if ( $include_parent_field || empty( $field[ 'inputs' ] ) ) {
296
+					$fields[ "{$field[ 'id' ]}" ] = array(
297 297
 						'label' => \GV\Utils::get( $field, 'label' ),
298 298
 						'parent' => null,
299 299
 						'type' => \GV\Utils::get( $field, 'type' ),
@@ -302,10 +302,10 @@  discard block
 block discarded – undo
302 302
 					);
303 303
 				}
304 304
 
305
-				if ( $add_default_properties && ! empty( $field['inputs'] ) ) {
306
-					foreach ( $field['inputs'] as $input ) {
305
+				if ( $add_default_properties && ! empty( $field[ 'inputs' ] ) ) {
306
+					foreach ( $field[ 'inputs' ] as $input ) {
307 307
 
308
-						if( ! empty( $input['isHidden'] ) ) {
308
+						if ( ! empty( $input[ 'isHidden' ] ) ) {
309 309
 							continue;
310 310
 						}
311 311
 
@@ -313,10 +313,10 @@  discard block
 block discarded – undo
313 313
                          * @hack
314 314
                          * In case of email/email confirmation, the input for email has the same id as the parent field
315 315
                          */
316
-						if( 'email' === $field['type'] && false === strpos( $input['id'], '.' ) ) {
316
+						if ( 'email' === $field[ 'type' ] && false === strpos( $input[ 'id' ], '.' ) ) {
317 317
                             continue;
318 318
                         }
319
-						$fields["{$input['id']}"] = array(
319
+						$fields[ "{$input[ 'id' ]}" ] = array(
320 320
 							'label' => \GV\Utils::get( $input, 'label' ),
321 321
 							'customLabel' => \GV\Utils::get( $input, 'customLabel' ),
322 322
 							'parent' => $field,
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
 				}
329 329
 
330 330
 
331
-				if( GFCommon::is_product_field( $field['type'] ) ){
331
+				if ( GFCommon::is_product_field( $field[ 'type' ] ) ) {
332 332
 					$has_product_fields = true;
333 333
 				}
334 334
 
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
 		 * @since 1.7
343 343
 		 */
344 344
 		if ( $has_post_fields ) {
345
-			$fields['post_id'] = array(
345
+			$fields[ 'post_id' ] = array(
346 346
 				'label' => __( 'Post ID', 'gravityview' ),
347 347
 				'type' => 'post_id',
348 348
 			);
@@ -355,11 +355,11 @@  discard block
 block discarded – undo
355 355
 			foreach ( $payment_fields as $payment_field ) {
356 356
 
357 357
 				// Either the field exists ($fields['shipping']) or the form explicitly contains a `shipping` field with numeric key
358
-				if( isset( $fields["{$payment_field->name}"] ) || GFCommon::get_fields_by_type( $form, $payment_field->name ) ) {
358
+				if ( isset( $fields[ "{$payment_field->name}" ] ) || GFCommon::get_fields_by_type( $form, $payment_field->name ) ) {
359 359
 					continue;
360 360
 				}
361 361
 
362
-				$fields["{$payment_field->name}"] = array(
362
+				$fields[ "{$payment_field->name}" ] = array(
363 363
 					'label' => $payment_field->label,
364 364
 					'desc' => $payment_field->description,
365 365
 					'type' => $payment_field->name,
@@ -391,9 +391,9 @@  discard block
 block discarded – undo
391 391
 
392 392
 		$fields = array();
393 393
 
394
-		foreach ( $extra_fields as $key => $field ){
395
-			if ( ! empty( $only_default_column ) && ! empty( $field['is_default_column'] ) ) {
396
-				$fields[ $key ] = array( 'label' => $field['label'], 'type' => 'entry_meta' );
394
+		foreach ( $extra_fields as $key => $field ) {
395
+			if ( ! empty( $only_default_column ) && ! empty( $field[ 'is_default_column' ] ) ) {
396
+				$fields[ $key ] = array( 'label' => $field[ 'label' ], 'type' => 'entry_meta' );
397 397
 			}
398 398
 		}
399 399
 
@@ -433,33 +433,33 @@  discard block
 block discarded – undo
433 433
 			'search_criteria' => null,
434 434
 			'sorting' => null,
435 435
 			'paging' => null,
436
-			'cache' => (isset( $passed_criteria['cache'] ) ? (bool) $passed_criteria['cache'] : true),
436
+			'cache' => ( isset( $passed_criteria[ 'cache' ] ) ? (bool)$passed_criteria[ 'cache' ] : true ),
437 437
 			'context_view_id' => null,
438 438
 		);
439 439
 
440 440
 		$criteria = wp_parse_args( $passed_criteria, $search_criteria_defaults );
441 441
 
442
-		if ( ! empty( $criteria['search_criteria']['field_filters'] ) && is_array( $criteria['search_criteria']['field_filters'] ) ) {
443
-			foreach ( $criteria['search_criteria']['field_filters'] as &$filter ) {
442
+		if ( ! empty( $criteria[ 'search_criteria' ][ 'field_filters' ] ) && is_array( $criteria[ 'search_criteria' ][ 'field_filters' ] ) ) {
443
+			foreach ( $criteria[ 'search_criteria' ][ 'field_filters' ] as &$filter ) {
444 444
 
445 445
 				if ( ! is_array( $filter ) ) {
446 446
 					continue;
447 447
 				}
448 448
 
449 449
 				// By default, we want searches to be wildcard for each field.
450
-				$filter['operator'] = empty( $filter['operator'] ) ? 'contains' : $filter['operator'];
450
+				$filter[ 'operator' ] = empty( $filter[ 'operator' ] ) ? 'contains' : $filter[ 'operator' ];
451 451
 
452 452
 				/**
453 453
 				 * @filter `gravityview_search_operator` Modify the search operator for the field (contains, is, isnot, etc)
454 454
 				 * @param string $operator Existing search operator
455 455
 				 * @param array $filter array with `key`, `value`, `operator`, `type` keys
456 456
 				 */
457
-				$filter['operator'] = apply_filters( 'gravityview_search_operator', $filter['operator'], $filter );
457
+				$filter[ 'operator' ] = apply_filters( 'gravityview_search_operator', $filter[ 'operator' ], $filter );
458 458
 			}
459 459
 
460 460
 			// don't send just the [mode] without any field filter.
461
-			if( count( $criteria['search_criteria']['field_filters'] ) === 1 && array_key_exists( 'mode' , $criteria['search_criteria']['field_filters'] ) ) {
462
-				unset( $criteria['search_criteria']['field_filters']['mode'] );
461
+			if ( count( $criteria[ 'search_criteria' ][ 'field_filters' ] ) === 1 && array_key_exists( 'mode', $criteria[ 'search_criteria' ][ 'field_filters' ] ) ) {
462
+				unset( $criteria[ 'search_criteria' ][ 'field_filters' ][ 'mode' ] );
463 463
 			}
464 464
 
465 465
 		}
@@ -470,33 +470,33 @@  discard block
 block discarded – undo
470 470
 		 * Prepare date formats to be in Gravity Forms DB format;
471 471
 		 * $passed_criteria may include date formats incompatible with Gravity Forms.
472 472
 		 */
473
-		foreach ( array('start_date', 'end_date' ) as $key ) {
473
+		foreach ( array( 'start_date', 'end_date' ) as $key ) {
474 474
 
475
-			if ( ! empty( $criteria['search_criteria'][ $key ] ) ) {
475
+			if ( ! empty( $criteria[ 'search_criteria' ][ $key ] ) ) {
476 476
 
477 477
 				// Use date_create instead of new DateTime so it returns false if invalid date format.
478
-				$date = date_create( $criteria['search_criteria'][ $key ] );
478
+				$date = date_create( $criteria[ 'search_criteria' ][ $key ] );
479 479
 
480 480
 				if ( $date ) {
481 481
 					// Gravity Forms wants dates in the `Y-m-d H:i:s` format.
482
-					$criteria['search_criteria'][ $key ] = $date->format( 'Y-m-d H:i:s' );
482
+					$criteria[ 'search_criteria' ][ $key ] = $date->format( 'Y-m-d H:i:s' );
483 483
 				} else {
484
-					gravityview()->log->error( '{key} Date format not valid:', array( 'key' => $key, $criteria['search_criteria'][ $key ] ) );
484
+					gravityview()->log->error( '{key} Date format not valid:', array( 'key' => $key, $criteria[ 'search_criteria' ][ $key ] ) );
485 485
 
486 486
 					// If it's an invalid date, unset it. Gravity Forms freaks out otherwise.
487
-					unset( $criteria['search_criteria'][ $key ] );
487
+					unset( $criteria[ 'search_criteria' ][ $key ] );
488 488
 				}
489 489
 			}
490 490
 		}
491 491
 
492
-		if ( empty( $criteria['context_view_id'] ) ) {
492
+		if ( empty( $criteria[ 'context_view_id' ] ) ) {
493 493
 			// Calculate the context view id and send it to the advanced filter
494 494
 			if ( GravityView_frontend::getInstance()->getSingleEntry() ) {
495
-				$criteria['context_view_id'] = GravityView_frontend::getInstance()->get_context_view_id();
495
+				$criteria[ 'context_view_id' ] = GravityView_frontend::getInstance()->get_context_view_id();
496 496
 			} else if ( class_exists( 'GravityView_View_Data' ) && GravityView_View_Data::getInstance() && GravityView_View_Data::getInstance()->has_multiple_views() ) {
497
-				$criteria['context_view_id'] = GravityView_frontend::getInstance()->get_context_view_id();
497
+				$criteria[ 'context_view_id' ] = GravityView_frontend::getInstance()->get_context_view_id();
498 498
 			} else if ( 'delete' === GFForms::get( 'action' ) ) {
499
-				$criteria['context_view_id'] = isset( $_GET['view_id'] ) ? intval( $_GET['view_id'] ) : null;
499
+				$criteria[ 'context_view_id' ] = isset( $_GET[ 'view_id' ] ) ? intval( $_GET[ 'view_id' ] ) : null;
500 500
 			}
501 501
 		}
502 502
 
@@ -506,7 +506,7 @@  discard block
 block discarded – undo
506 506
 		 * @param array $form_ids Forms to search
507 507
 		 * @param int $view_id ID of the view being used to search
508 508
 		 */
509
-		$criteria = apply_filters( 'gravityview_search_criteria', $criteria, $form_ids, $criteria['context_view_id'] );
509
+		$criteria = apply_filters( 'gravityview_search_criteria', $criteria, $form_ids, $criteria[ 'context_view_id' ] );
510 510
 
511 511
 		return (array)$criteria;
512 512
 	}
@@ -541,7 +541,7 @@  discard block
 block discarded – undo
541 541
 		/** Reduce # of database calls */
542 542
 		add_filter( 'gform_is_encrypted_field', '__return_false' );
543 543
 
544
-		if ( ! empty( $criteria['cache'] ) ) {
544
+		if ( ! empty( $criteria[ 'cache' ] ) ) {
545 545
 
546 546
 			$Cache = new GravityView_Cache( $form_ids, $criteria );
547 547
 
@@ -549,7 +549,7 @@  discard block
 block discarded – undo
549 549
 
550 550
 				// Still update the total count when using cached results
551 551
 				if ( ! is_null( $total ) ) {
552
-					$total = GFAPI::count_entries( $form_ids, $criteria['search_criteria'] );
552
+					$total = GFAPI::count_entries( $form_ids, $criteria[ 'search_criteria' ] );
553 553
 				}
554 554
 
555 555
 				$return = $entries;
@@ -571,9 +571,9 @@  discard block
 block discarded – undo
571 571
 			$entries = apply_filters_ref_array( 'gravityview_before_get_entries', array( null, $criteria, $passed_criteria, &$total ) );
572 572
 
573 573
 			// No entries returned from gravityview_before_get_entries
574
-			if( is_null( $entries ) ) {
574
+			if ( is_null( $entries ) ) {
575 575
 
576
-				$entries = GFAPI::get_entries( $form_ids, $criteria['search_criteria'], $criteria['sorting'], $criteria['paging'], $total );
576
+				$entries = GFAPI::get_entries( $form_ids, $criteria[ 'search_criteria' ], $criteria[ 'sorting' ], $criteria[ 'paging' ], $total );
577 577
 
578 578
 				if ( is_wp_error( $entries ) ) {
579 579
 					gravityview()->log->error( '{error}', array( 'error' => $entries->get_error_message(), 'data' => $entries ) );
@@ -584,7 +584,7 @@  discard block
 block discarded – undo
584 584
 				}
585 585
 			}
586 586
 
587
-			if ( ! empty( $criteria['cache'] ) && isset( $Cache ) ) {
587
+			if ( ! empty( $criteria[ 'cache' ] ) && isset( $Cache ) ) {
588 588
 
589 589
 				// Cache results
590 590
 				$Cache->set( $entries, 'entries' );
@@ -695,7 +695,7 @@  discard block
 block discarded – undo
695 695
 		 */
696 696
 		$check_entry_display = apply_filters( 'gravityview/common/get_entry/check_entry_display', $check_entry_display, $entry, $view );
697 697
 
698
-		if( $check_entry_display ) {
698
+		if ( $check_entry_display ) {
699 699
 			if ( ! $view ) {
700 700
 				$view = \GV\View::by_id( \GravityView_View::getInstance()->getViewId() ); // @todo Bad legacy context, provide $view parameter!
701 701
 				gravityview()->log->warning( '$view parameter not provided! Context assumed from legacy context mocks. Unreliable!' );
@@ -705,7 +705,7 @@  discard block
 block discarded – undo
705 705
 			$entry = self::check_entry_display( $entry, $view );
706 706
 		}
707 707
 
708
-		if( is_wp_error( $entry ) ) {
708
+		if ( is_wp_error( $entry ) ) {
709 709
 			gravityview()->log->error( '{error}', array( 'error' => $entry->get_error_message() ) );
710 710
 			return false;
711 711
 		}
@@ -739,12 +739,12 @@  discard block
 block discarded – undo
739 739
 
740 740
 		$value = false;
741 741
 
742
-		if( 'context' === $val1 ) {
742
+		if ( 'context' === $val1 ) {
743 743
 
744 744
 			$matching_contexts = array( $val2 );
745 745
 
746 746
 			// We allow for non-standard contexts.
747
-			switch( $val2 ) {
747
+			switch ( $val2 ) {
748 748
 				// Check for either single or edit
749 749
 				case 'singular':
750 750
 					$matching_contexts = array( 'single', 'edit' );
@@ -787,18 +787,18 @@  discard block
 block discarded – undo
787 787
 				$json_val_1 = json_decode( $val1, true );
788 788
 				$json_val_2 = json_decode( $val2, true );
789 789
 
790
-				if( ! empty( $json_val_1 ) || ! empty( $json_val_2 ) ) {
790
+				if ( ! empty( $json_val_1 ) || ! empty( $json_val_2 ) ) {
791 791
 
792 792
 					$json_in = false;
793
-					$json_val_1 = $json_val_1 ? (array) $json_val_1 : array( $val1 );
794
-					$json_val_2 = $json_val_2 ? (array) $json_val_2 : array( $val2 );
793
+					$json_val_1 = $json_val_1 ? (array)$json_val_1 : array( $val1 );
794
+					$json_val_2 = $json_val_2 ? (array)$json_val_2 : array( $val2 );
795 795
 
796 796
 					// For JSON, we want to compare as "in" or "not in" rather than "contains"
797 797
 					foreach ( $json_val_1 as $item_1 ) {
798 798
 						foreach ( $json_val_2 as $item_2 ) {
799 799
 							$json_in = self::matches_operation( $item_1, $item_2, 'is' );
800 800
 
801
-							if( $json_in ) {
801
+							if ( $json_in ) {
802 802
 								break 2;
803 803
 							}
804 804
 						}
@@ -850,10 +850,10 @@  discard block
 block discarded – undo
850 850
 	public static function check_entry_display( $entry, $view = null ) {
851 851
 
852 852
 		if ( ! $entry || is_wp_error( $entry ) ) {
853
-			return new WP_Error('entry_not_found', 'Entry was not found.', $entry );
853
+			return new WP_Error( 'entry_not_found', 'Entry was not found.', $entry );
854 854
 		}
855 855
 
856
-		if ( empty( $entry['form_id'] ) ) {
856
+		if ( empty( $entry[ 'form_id' ] ) ) {
857 857
 			return new WP_Error( 'form_id_not_set', '[apply_filters_to_entry] Entry is empty!', $entry );
858 858
 		}
859 859
 
@@ -869,12 +869,12 @@  discard block
 block discarded – undo
869 869
 		$view_form_id = $view->form->ID;
870 870
 
871 871
 		if ( $view->joins ) {
872
-			if ( in_array( (int)$entry['form_id'], array_keys( $view::get_joined_forms( $view->ID ) ), true ) ) {
873
-				$view_form_id = $entry['form_id'];
872
+			if ( in_array( (int)$entry[ 'form_id' ], array_keys( $view::get_joined_forms( $view->ID ) ), true ) ) {
873
+				$view_form_id = $entry[ 'form_id' ];
874 874
 			}
875 875
 		}
876 876
 
877
-		if ( $view_form_id != $entry['form_id'] ) {
877
+		if ( $view_form_id != $entry[ 'form_id' ] ) {
878 878
 			return new WP_Error( 'view_id_not_match', 'View form source does not match entry form source ID.', $entry );
879 879
 		}
880 880
 
@@ -882,13 +882,13 @@  discard block
 block discarded – undo
882 882
 		 * Check whether the entry is in the entries subset by running a modified query.
883 883
 		 */
884 884
 		add_action( 'gravityview/view/query', $entry_subset_callback = function( &$query, $view, $request ) use ( $entry, $view_form_id ) {
885
-			$_tmp_query       = new \GF_Query( $view_form_id, array(
885
+			$_tmp_query = new \GF_Query( $view_form_id, array(
886 886
 				'field_filters' => array(
887 887
 					'mode' => 'all',
888 888
 					array(
889 889
 						'key' => 'id',
890 890
 						'operation' => 'is',
891
-						'value' => $entry['id']
891
+						'value' => $entry[ 'id' ]
892 892
 					)
893 893
 				)
894 894
 			) );
@@ -898,14 +898,14 @@  discard block
 block discarded – undo
898 898
 			/** @var \GF_Query $query */
899 899
 			$query_parts      = $query->_introspect();
900 900
 
901
-			$query->where( \GF_Query_Condition::_and( $_tmp_query_parts['where'], $query_parts['where'] ) );
901
+			$query->where( \GF_Query_Condition::_and( $_tmp_query_parts[ 'where' ], $query_parts[ 'where' ] ) );
902 902
 
903 903
 		}, 10, 3 );
904 904
 
905 905
 		// Prevent page offset from being applied to the single entry query; it's used to return to the referring page number
906 906
 		add_filter( 'gravityview_search_criteria', $remove_pagenum = function( $criteria ) {
907 907
 
908
-			$criteria['paging'] = array(
908
+			$criteria[ 'paging' ] = array(
909 909
 				'offset' => 0,
910 910
 				'page_size' => 25
911 911
 			);
@@ -924,20 +924,20 @@  discard block
 block discarded – undo
924 924
 		}
925 925
 
926 926
 		// This entry is on a View with joins
927
-		if ( $entries[0]->is_multi() ) {
927
+		if ( $entries[ 0 ]->is_multi() ) {
928 928
 
929 929
 			$multi_entry_ids = array();
930 930
 
931
-			foreach ( $entries[0]->entries as $multi_entry ) {
932
-				$multi_entry_ids[] = (int) $multi_entry->ID;
931
+			foreach ( $entries[ 0 ]->entries as $multi_entry ) {
932
+				$multi_entry_ids[ ] = (int)$multi_entry->ID;
933 933
 			}
934 934
 
935
-			if ( ! in_array( (int) $entry['id'], $multi_entry_ids, true ) ) {
935
+			if ( ! in_array( (int)$entry[ 'id' ], $multi_entry_ids, true ) ) {
936 936
 				remove_action( 'gravityview/view/query', $entry_subset_callback );
937 937
 				return new \WP_Error( 'failed_criteria', 'Entry failed search_criteria and field_filters' );
938 938
 			}
939 939
 
940
-		} elseif ( (int) $entries[0]->ID !== (int) $entry['id'] ) {
940
+		} elseif ( (int)$entries[ 0 ]->ID !== (int)$entry[ 'id' ] ) {
941 941
 			remove_action( 'gravityview/view/query', $entry_subset_callback );
942 942
 			return new \WP_Error( 'failed_criteria', 'Entry failed search_criteria and field_filters' );
943 943
 		}
@@ -982,18 +982,18 @@  discard block
 block discarded – undo
982 982
 		 * Gravity Forms code to adjust date to locally-configured Time Zone
983 983
 		 * @see GFCommon::format_date() for original code
984 984
 		 */
985
-		$date_gmt_time   = mysql2date( 'G', $date_string );
985
+		$date_gmt_time = mysql2date( 'G', $date_string );
986 986
 		$date_local_timestamp = GFCommon::get_local_timestamp( $date_gmt_time );
987 987
 
988
-		$format  = \GV\Utils::get( $atts, 'format' );
989
-		$is_human  = ! empty( $atts['human'] );
990
-		$is_diff  = ! empty( $atts['diff'] );
991
-		$is_raw = ! empty( $atts['raw'] );
992
-		$is_timestamp = ! empty( $atts['timestamp'] );
993
-		$include_time = ! empty( $atts['time'] );
988
+		$format = \GV\Utils::get( $atts, 'format' );
989
+		$is_human = ! empty( $atts[ 'human' ] );
990
+		$is_diff = ! empty( $atts[ 'diff' ] );
991
+		$is_raw = ! empty( $atts[ 'raw' ] );
992
+		$is_timestamp = ! empty( $atts[ 'timestamp' ] );
993
+		$include_time = ! empty( $atts[ 'time' ] );
994 994
 
995 995
 		// If we're using time diff, we want to have a different default format
996
-		if( empty( $format ) ) {
996
+		if ( empty( $format ) ) {
997 997
 			/* translators: %s: relative time from now, used for generic date comparisons. "1 day ago", or "20 seconds ago" */
998 998
 			$format = $is_diff ? esc_html__( '%s ago', 'gravityview' ) : get_option( 'date_format' );
999 999
 		}
@@ -1001,7 +1001,7 @@  discard block
 block discarded – undo
1001 1001
 		// If raw was specified, don't modify the stored value
1002 1002
 		if ( $is_raw ) {
1003 1003
 			$formatted_date = $date_string;
1004
-		} elseif( $is_timestamp ) {
1004
+		} elseif ( $is_timestamp ) {
1005 1005
 			$formatted_date = $date_local_timestamp;
1006 1006
 		} elseif ( $is_diff ) {
1007 1007
 			$formatted_date = sprintf( $format, human_time_diff( $date_gmt_time ) );
@@ -1035,7 +1035,7 @@  discard block
 block discarded – undo
1035 1035
 
1036 1036
 		$label = \GV\Utils::get( $field, 'label' );
1037 1037
 
1038
-		if( floor( $field_id ) !== floatval( $field_id ) ) {
1038
+		if ( floor( $field_id ) !== floatval( $field_id ) ) {
1039 1039
 			$label = GFFormsModel::get_choice_text( $field, $field_value, $field_id );
1040 1040
 		}
1041 1041
 
@@ -1063,7 +1063,7 @@  discard block
 block discarded – undo
1063 1063
 			$form = GFAPI::get_form( $form );
1064 1064
 		}
1065 1065
 
1066
-		if ( class_exists( 'GFFormsModel' ) ){
1066
+		if ( class_exists( 'GFFormsModel' ) ) {
1067 1067
 			return GFFormsModel::get_field( $form, $field_id );
1068 1068
 		} else {
1069 1069
 			return null;
@@ -1110,19 +1110,19 @@  discard block
 block discarded – undo
1110 1110
 			$shortcodes = array();
1111 1111
 
1112 1112
 			preg_match_all( '/' . get_shortcode_regex() . '/s', $content, $matches, PREG_SET_ORDER );
1113
-			if ( empty( $matches ) ){
1113
+			if ( empty( $matches ) ) {
1114 1114
 				return false;
1115 1115
 			}
1116 1116
 
1117 1117
 			foreach ( $matches as $shortcode ) {
1118
-				if ( $tag === $shortcode[2] ) {
1118
+				if ( $tag === $shortcode[ 2 ] ) {
1119 1119
 
1120 1120
 					// Changed this to $shortcode instead of true so we get the parsed atts.
1121
-					$shortcodes[] = $shortcode;
1121
+					$shortcodes[ ] = $shortcode;
1122 1122
 
1123
-				} else if ( isset( $shortcode[5] ) && $results = self::has_shortcode_r( $shortcode[5], $tag ) ) {
1124
-					foreach( $results as $result ) {
1125
-						$shortcodes[] = $result;
1123
+				} else if ( isset( $shortcode[ 5 ] ) && $results = self::has_shortcode_r( $shortcode[ 5 ], $tag ) ) {
1124
+					foreach ( $results as $result ) {
1125
+						$shortcodes[ ] = $result;
1126 1126
 					}
1127 1127
 				}
1128 1128
 			}
@@ -1154,7 +1154,7 @@  discard block
 block discarded – undo
1154 1154
 			'post_type'      => 'gravityview',
1155 1155
 			'posts_per_page' => 100,
1156 1156
 			'meta_key'       => '_gravityview_form_id',
1157
-			'meta_value'     => (int) $form_id,
1157
+			'meta_value'     => (int)$form_id,
1158 1158
 		);
1159 1159
 		$args     = wp_parse_args( $args, $defaults );
1160 1160
 		$views    = get_posts( $args );
@@ -1166,21 +1166,21 @@  discard block
 block discarded – undo
1166 1166
 
1167 1167
 			$data = unserialize( $view->meta_value );
1168 1168
 
1169
-			if( ! $data || ! is_array( $data ) ) {
1169
+			if ( ! $data || ! is_array( $data ) ) {
1170 1170
 				continue;
1171 1171
 			}
1172 1172
 
1173 1173
 			foreach ( $data as $datum ) {
1174
-				if ( ! empty( $datum[2] ) && (int) $datum[2] === (int) $form_id ) {
1175
-					$joined_forms[] = $view->post_id;
1174
+				if ( ! empty( $datum[ 2 ] ) && (int)$datum[ 2 ] === (int)$form_id ) {
1175
+					$joined_forms[ ] = $view->post_id;
1176 1176
 				}
1177 1177
 			}
1178 1178
 		}
1179 1179
 
1180 1180
 		if ( $joined_forms ) {
1181
-			$joined_args  = array(
1181
+			$joined_args = array(
1182 1182
 				'post_type'      => 'gravityview',
1183
-				'posts_per_page' => $args['posts_per_page'],
1183
+				'posts_per_page' => $args[ 'posts_per_page' ],
1184 1184
 				'post__in'       => $joined_forms,
1185 1185
 			);
1186 1186
 			$views = array_merge( $views, get_posts( $joined_args ) );
@@ -1336,7 +1336,7 @@  discard block
 block discarded – undo
1336 1336
 
1337 1337
 		$directory_widgets = wp_parse_args( $view_widgets, $defaults );
1338 1338
 
1339
-		if( $json_decode ) {
1339
+		if ( $json_decode ) {
1340 1340
 			$directory_widgets = gv_map_deep( $directory_widgets, 'gv_maybe_json_decode' );
1341 1341
 		}
1342 1342
 
@@ -1352,7 +1352,7 @@  discard block
 block discarded – undo
1352 1352
 	 * @return string         html
1353 1353
 	 */
1354 1354
 	public static function get_sortable_fields( $formid, $current = '' ) {
1355
-		$output = '<option value="" ' . selected( '', $current, false ).'>' . esc_html__( 'Default', 'gravityview' ) .'</option>';
1355
+		$output = '<option value="" ' . selected( '', $current, false ) . '>' . esc_html__( 'Default', 'gravityview' ) . '</option>';
1356 1356
 
1357 1357
 		if ( empty( $formid ) ) {
1358 1358
 			return $output;
@@ -1365,11 +1365,11 @@  discard block
 block discarded – undo
1365 1365
 			$blacklist_field_types = apply_filters( 'gravityview_blacklist_field_types', array( 'list', 'textarea' ), null );
1366 1366
 
1367 1367
 			foreach ( $fields as $id => $field ) {
1368
-				if ( in_array( $field['type'], $blacklist_field_types ) ) {
1368
+				if ( in_array( $field[ 'type' ], $blacklist_field_types ) ) {
1369 1369
 					continue;
1370 1370
 				}
1371 1371
 
1372
-				$output .= '<option value="'. $id .'" '. selected( $id, $current, false ).'>'. esc_attr( $field['label'] ) .'</option>';
1372
+				$output .= '<option value="' . $id . '" ' . selected( $id, $current, false ) . '>' . esc_attr( $field[ 'label' ] ) . '</option>';
1373 1373
 			}
1374 1374
 		}
1375 1375
 
@@ -1404,16 +1404,16 @@  discard block
 block discarded – undo
1404 1404
 		$blacklist_field_types = apply_filters( 'gravityview_blacklist_field_types', $blacklist, NULL );
1405 1405
 
1406 1406
 		// TODO: Convert to using array_filter
1407
-		foreach( $fields as $id => $field ) {
1407
+		foreach ( $fields as $id => $field ) {
1408 1408
 
1409
-			if( in_array( $field['type'], $blacklist_field_types ) ) {
1409
+			if ( in_array( $field[ 'type' ], $blacklist_field_types ) ) {
1410 1410
 				unset( $fields[ $id ] );
1411 1411
 			}
1412 1412
 
1413 1413
 			/**
1414 1414
 			 * Merge date and time subfields.
1415 1415
 			 */
1416
-			if ( in_array( $field['type'], array( 'date', 'time' ) ) && ! empty( $field['parent'] ) ) {
1416
+			if ( in_array( $field[ 'type' ], array( 'date', 'time' ) ) && ! empty( $field[ 'parent' ] ) ) {
1417 1417
 				$fields[ intval( $id ) ] = array(
1418 1418
 					'label' => \GV\Utils::get( $field, 'parent/label' ),
1419 1419
 					'parent' => null,
@@ -1463,14 +1463,14 @@  discard block
 block discarded – undo
1463 1463
 	 * @param  int|array  $field field key or field array
1464 1464
 	 * @return boolean
1465 1465
 	 */
1466
-	public static function is_field_numeric(  $form = null, $field = '' ) {
1466
+	public static function is_field_numeric( $form = null, $field = '' ) {
1467 1467
 
1468 1468
 		if ( ! is_array( $form ) && ! is_array( $field ) ) {
1469 1469
 			$form = self::get_form( $form );
1470 1470
 		}
1471 1471
 
1472 1472
 		// If entry meta, it's a string. Otherwise, numeric
1473
-		if( ! is_numeric( $field ) && is_string( $field ) ) {
1473
+		if ( ! is_numeric( $field ) && is_string( $field ) ) {
1474 1474
 			$type = $field;
1475 1475
 		} else {
1476 1476
 			$type = self::get_field_type( $form, $field );
@@ -1484,9 +1484,9 @@  discard block
 block discarded – undo
1484 1484
 		$numeric_types = apply_filters( 'gravityview/common/numeric_types', array( 'number', 'time' ) );
1485 1485
 
1486 1486
 		// Defer to GravityView_Field setting, if the field type is registered and `is_numeric` is true
1487
-		if( $gv_field = GravityView_Fields::get( $type ) ) {
1488
-			if( true === $gv_field->is_numeric ) {
1489
-				$numeric_types[] = $gv_field->is_numeric;
1487
+		if ( $gv_field = GravityView_Fields::get( $type ) ) {
1488
+			if ( true === $gv_field->is_numeric ) {
1489
+				$numeric_types[ ] = $gv_field->is_numeric;
1490 1490
 			}
1491 1491
 		}
1492 1492
 
@@ -1636,18 +1636,18 @@  discard block
 block discarded – undo
1636 1636
 		$final_atts = array_filter( $final_atts );
1637 1637
 
1638 1638
 		// If the href wasn't passed as an attribute, use the value passed to the function
1639
-		if ( empty( $final_atts['href'] ) && ! empty( $href ) ) {
1640
-			$final_atts['href'] = $href;
1639
+		if ( empty( $final_atts[ 'href' ] ) && ! empty( $href ) ) {
1640
+			$final_atts[ 'href' ] = $href;
1641 1641
 		}
1642 1642
 
1643
-		$final_atts['href'] = esc_url_raw( $href );
1643
+		$final_atts[ 'href' ] = esc_url_raw( $href );
1644 1644
 
1645 1645
 		/**
1646 1646
 		 * Fix potential security issue with target=_blank
1647 1647
 		 * @see https://dev.to/ben/the-targetblank-vulnerability-by-example
1648 1648
 		 */
1649
-		if( '_blank' === \GV\Utils::get( $final_atts, 'target' ) ) {
1650
-			$final_atts['rel'] = trim( \GV\Utils::get( $final_atts, 'rel', '' ) . ' noopener noreferrer' );
1649
+		if ( '_blank' === \GV\Utils::get( $final_atts, 'target' ) ) {
1650
+			$final_atts[ 'rel' ] = trim( \GV\Utils::get( $final_atts, 'rel', '' ) . ' noopener noreferrer' );
1651 1651
 		}
1652 1652
 
1653 1653
 		// Sort the attributes alphabetically, to help testing
@@ -1659,7 +1659,7 @@  discard block
 block discarded – undo
1659 1659
 			$output .= sprintf( ' %s="%s"', $attr, esc_attr( $value ) );
1660 1660
 		}
1661 1661
 
1662
-		if( '' !== $output ) {
1662
+		if ( '' !== $output ) {
1663 1663
 			$output = '<a' . $output . '>' . $anchor_text . '</a>';
1664 1664
 		}
1665 1665
 
@@ -1686,7 +1686,7 @@  discard block
 block discarded – undo
1686 1686
 			if ( is_array( $value ) && isset( $merged[ $key ] ) && is_array( $merged[ $key ] ) ) {
1687 1687
 				$merged[ $key ] = self::array_merge_recursive_distinct( $merged[ $key ], $value );
1688 1688
 			} else if ( is_numeric( $key ) && isset( $merged[ $key ] ) ) {
1689
-				$merged[] = $value;
1689
+				$merged[ ] = $value;
1690 1690
 			} else {
1691 1691
 				$merged[ $key ] = $value;
1692 1692
 			}
@@ -1719,7 +1719,7 @@  discard block
 block discarded – undo
1719 1719
 		 * `$context` is where are we using this information (e.g. change_entry_creator, search_widget ..)
1720 1720
 		 * @param array $settings Settings array, with `number` key defining the # of users to display
1721 1721
 		 */
1722
-		$get_users_settings = apply_filters( 'gravityview/get_users/'. $context, apply_filters( 'gravityview_change_entry_creator_user_parameters', $get_users_settings ) );
1722
+		$get_users_settings = apply_filters( 'gravityview/get_users/' . $context, apply_filters( 'gravityview_change_entry_creator_user_parameters', $get_users_settings ) );
1723 1723
 
1724 1724
 		return get_users( $get_users_settings );
1725 1725
 	}
@@ -1739,11 +1739,11 @@  discard block
 block discarded – undo
1739 1739
     public static function generate_notice( $notice, $class = '', $cap = '', $object_id = null ) {
1740 1740
 
1741 1741
     	// If $cap is defined, only show notice if user has capability
1742
-    	if( $cap && ! GVCommon::has_cap( $cap, $object_id ) ) {
1742
+    	if ( $cap && ! GVCommon::has_cap( $cap, $object_id ) ) {
1743 1743
     		return '';
1744 1744
 	    }
1745 1745
 
1746
-        return '<div class="gv-notice '.gravityview_sanitize_html_class( $class ) .'">'. $notice .'</div>';
1746
+        return '<div class="gv-notice ' . gravityview_sanitize_html_class( $class ) . '">' . $notice . '</div>';
1747 1747
     }
1748 1748
 
1749 1749
 	/**
Please login to merge, or discard this patch.