Completed
Push — develop ( 4d830b...72e688 )
by Zack
06:12
created
future/includes/class-gv-view.php 2 patches
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -230,8 +230,9 @@
 block discarded – undo
230 230
 		 * Check permissions.
231 231
 		 */
232 232
 		while ( $error = $view->can_render( null, $request ) ) {
233
-			if ( ! is_wp_error( $error ) )
234
-				break;
233
+			if ( ! is_wp_error( $error ) ) {
234
+							break;
235
+			}
235 236
 
236 237
 			switch ( str_replace( 'gravityview/', '', $error->get_error_code() ) ) {
237 238
 				case 'post_password_required':
Please login to merge, or discard this patch.
Spacing   +79 added lines, -80 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
 		$supports = array( 'title', 'revisions' );
126 126
 
127 127
 		if ( $is_hierarchical ) {
128
-			$supports[] = 'page-attributes';
128
+			$supports[ ] = 'page-attributes';
129 129
 		}
130 130
 
131 131
 		/**
@@ -227,11 +227,11 @@  discard block
 block discarded – undo
227 227
 		$rule = array( sprintf( '%s/([^/]+)/csv/?', $slug ), 'index.php?gravityview=$matches[1]&csv=1', 'top' );
228 228
 
229 229
 		add_filter( 'query_vars', function( $query_vars ) {
230
-			$query_vars[] = 'csv';
230
+			$query_vars[ ] = 'csv';
231 231
 			return $query_vars;
232 232
 		} );
233 233
 
234
-		if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[0] ] ) ) {
234
+		if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[ 0 ] ] ) ) {
235 235
 			call_user_func_array( 'add_rewrite_rule', $rule );
236 236
 		}
237 237
 	}
@@ -308,13 +308,13 @@  discard block
 block discarded – undo
308 308
 			return $content;
309 309
 		}
310 310
 
311
-		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap('gravityview_moderate_entries', $view->ID );
311
+		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap( 'gravityview_moderate_entries', $view->ID );
312 312
 
313 313
 		/**
314 314
 		 * Editing a single entry.
315 315
 		 */
316 316
 		if ( $entry = $request->is_edit_entry( $view->form ? $view->form->ID : 0 ) ) {
317
-			if ( $entry['status'] != 'active' ) {
317
+			if ( $entry[ 'status' ] != 'active' ) {
318 318
 				gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
319 319
 				return __( 'You are not allowed to view this content.', 'gravityview' );
320 320
 			}
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
325 325
 			}
326 326
 
327 327
 			if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
328
-				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
328
+				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
329 329
 					gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
330 330
 					return __( 'You are not allowed to view this content.', 'gravityview' );
331 331
 				}
@@ -348,7 +348,7 @@  discard block
 block discarded – undo
348 348
 
349 349
 			foreach ( $entryset as $e ) {
350 350
 
351
-				if ( 'active' !== $e['status'] ) {
351
+				if ( 'active' !== $e[ 'status' ] ) {
352 352
 					gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $e->ID ) );
353 353
 					return __( 'You are not allowed to view this content.', 'gravityview' );
354 354
 				}
@@ -359,7 +359,7 @@  discard block
 block discarded – undo
359 359
 				}
360 360
 
361 361
 				if ( $show_only_approved && ! $is_admin_and_can_view ) {
362
-					if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $e->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
362
+					if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $e->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
363 363
 						gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $e->ID ) );
364 364
 						return __( 'You are not allowed to view this content.', 'gravityview' );
365 365
 					}
@@ -534,7 +534,7 @@  discard block
 block discarded – undo
534 534
 			$join_column    = is_numeric( $join_column ) ? GF_Field::by_id( $join, $join_column ) : Internal_Field::by_id( $join_column );
535 535
 			$join_on_column = is_numeric( $join_on_column ) ? GF_Field::by_id( $join_on, $join_on_column ) : Internal_Field::by_id( $join_on_column );
536 536
 
537
-			$joins [] = new Join( $join, $join_column, $join_on, $join_on_column );
537
+			$joins [ ] = new Join( $join, $join_column, $join_on, $join_on_column );
538 538
 		}
539 539
 
540 540
 		return $joins;
@@ -624,13 +624,13 @@  discard block
 block discarded – undo
624 624
 			}
625 625
 
626 626
 			foreach ( $_fields as $field ) {
627
-				if ( ! empty( $field['unions'] ) ) {
628
-					foreach ( $field['unions'] as $form_id => $field_id ) {
627
+				if ( ! empty( $field[ 'unions' ] ) ) {
628
+					foreach ( $field[ 'unions' ] as $form_id => $field_id ) {
629 629
 						if ( ! isset( $unions[ $form_id ] ) ) {
630 630
 							$unions[ $form_id ] = array();
631 631
 						}
632 632
 
633
-						$unions[ $form_id ][ $field['id'] ] =
633
+						$unions[ $form_id ][ $field[ 'id' ] ] =
634 634
 							is_numeric( $field_id ) ? \GV\GF_Field::by_id( \GV\GF_Form::by_id( $form_id ), $field_id ) : \GV\Internal_Field::by_id( $field_id );
635 635
 					}
636 636
 				}
@@ -685,7 +685,7 @@  discard block
 block discarded – undo
685 685
 		if ( ! $view->form ) {
686 686
 			gravityview()->log->error( 'View #{view_id} tried attaching non-existent Form #{form_id} to it.', array(
687 687
 				'view_id' => $view->ID,
688
-				'form_id' => $view->_gravityview_form_id ? : 0,
688
+				'form_id' => $view->_gravityview_form_id ?: 0,
689 689
 			) );
690 690
 		}
691 691
 
@@ -924,11 +924,11 @@  discard block
 block discarded – undo
924 924
 			 * Remove multiple sorting before calling legacy filters.
925 925
 			 * This allows us to fake it till we make it.
926 926
 			 */
927
-			if ( ! empty( $parameters['sort_field'] ) && is_array( $parameters['sort_field'] ) ) {
927
+			if ( ! empty( $parameters[ 'sort_field' ] ) && is_array( $parameters[ 'sort_field' ] ) ) {
928 928
 				$has_multisort = true;
929
-				$parameters['sort_field'] = reset( $parameters['sort_field'] );
930
-				if ( ! empty( $parameters['sort_direction'] ) && is_array( $parameters['sort_direction'] ) ) {
931
-					$parameters['sort_direction'] = reset( $parameters['sort_direction'] );
929
+				$parameters[ 'sort_field' ] = reset( $parameters[ 'sort_field' ] );
930
+				if ( ! empty( $parameters[ 'sort_direction' ] ) && is_array( $parameters[ 'sort_direction' ] ) ) {
931
+					$parameters[ 'sort_direction' ] = reset( $parameters[ 'sort_direction' ] );
932 932
 				}
933 933
 			}
934 934
 
@@ -937,31 +937,30 @@  discard block
 block discarded – undo
937 937
 			 */
938 938
 			$parameters = \GravityView_frontend::get_view_entries_parameters( $parameters, $this->form->ID );
939 939
 
940
-			$parameters['context_view_id'] = $this->ID;
940
+			$parameters[ 'context_view_id' ] = $this->ID;
941 941
 			$parameters = \GVCommon::calculate_get_entries_criteria( $parameters, $this->form->ID );
942 942
 
943 943
 			if ( ! is_array( $parameters ) ) {
944 944
 				$parameters = array();
945 945
 			}
946 946
 
947
-			if ( ! is_array( $parameters['search_criteria'] ) ) {
948
-				$parameters['search_criteria'] = array();
947
+			if ( ! is_array( $parameters[ 'search_criteria' ] ) ) {
948
+				$parameters[ 'search_criteria' ] = array();
949 949
 			}
950 950
 
951
-			if ( ( ! isset( $parameters['search_criteria']['field_filters'] ) ) || ( ! is_array( $parameters['search_criteria']['field_filters'] ) ) ) {
952
-				$parameters['search_criteria']['field_filters'] = array();
951
+			if ( ( ! isset( $parameters[ 'search_criteria' ][ 'field_filters' ] ) ) || ( ! is_array( $parameters[ 'search_criteria' ][ 'field_filters' ] ) ) ) {
952
+				$parameters[ 'search_criteria' ][ 'field_filters' ] = array();
953 953
 			}
954 954
 
955 955
 			if ( $request instanceof REST\Request ) {
956 956
 				$atts = $this->settings->as_atts();
957 957
 				$paging_parameters = wp_parse_args( $request->get_paging(), array(
958
-						'paging' => array( 'page_size' => $atts['page_size'] ),
958
+						'paging' => array( 'page_size' => $atts[ 'page_size' ] ),
959 959
 					) );
960
-				$parameters['paging'] = $paging_parameters['paging'];
960
+				$parameters[ 'paging' ] = $paging_parameters[ 'paging' ];
961 961
 			}
962 962
 
963
-			$page = Utils::get( $parameters['paging'], 'current_page' ) ?
964
-				: ( ( ( $parameters['paging']['offset'] - $this->settings->get( 'offset' ) ) / \GV\Utils::get( $parameters, 'paging/page_size', 25 ) ) + 1 );
963
+			$page = Utils::get( $parameters[ 'paging' ], 'current_page' ) ?: ( ( ( $parameters[ 'paging' ][ 'offset' ] - $this->settings->get( 'offset' ) ) / \GV\Utils::get( $parameters, 'paging/page_size', 25 ) ) + 1 );
965 964
 
966 965
 			/**
967 966
 			 * Cleanup duplicate field_filter parameters to simplify the query.
@@ -969,14 +968,14 @@  discard block
 block discarded – undo
969 968
 			$unique_field_filters = array();
970 969
 			foreach ( Utils::get( $parameters, 'search_criteria/field_filters', array() ) as $key => $filter ) {
971 970
 				if ( 'mode' === $key ) {
972
-					$unique_field_filters['mode'] = $filter;
971
+					$unique_field_filters[ 'mode' ] = $filter;
973 972
 				} else if ( ! in_array( $filter, $unique_field_filters ) ) {
974
-					$unique_field_filters[] = $filter;
973
+					$unique_field_filters[ ] = $filter;
975 974
 				}
976 975
 			}
977
-			$parameters['search_criteria']['field_filters'] = $unique_field_filters;
976
+			$parameters[ 'search_criteria' ][ 'field_filters' ] = $unique_field_filters;
978 977
 
979
-			if ( ! empty( $parameters['search_criteria']['field_filters'] ) ) {
978
+			if ( ! empty( $parameters[ 'search_criteria' ][ 'field_filters' ] ) ) {
980 979
 				gravityview()->log->notice( 'search_criteria/field_filters is not empty, third-party code may be using legacy search_criteria filters.' );
981 980
 			}
982 981
 
@@ -985,7 +984,7 @@  discard block
 block discarded – undo
985 984
 				$query_class = $this->get_query_class();
986 985
 
987 986
 				/** @var \GF_Query $query */
988
-				$query = new $query_class( $this->form->ID, $parameters['search_criteria'], Utils::get( $parameters, 'sorting' ) );
987
+				$query = new $query_class( $this->form->ID, $parameters[ 'search_criteria' ], Utils::get( $parameters, 'sorting' ) );
989 988
 
990 989
 				/**
991 990
 				 * Apply multisort.
@@ -996,15 +995,15 @@  discard block
 block discarded – undo
996 995
 					$view_setting_sort_field_ids = \GV\Utils::get( $atts, 'sort_field', array() );
997 996
 					$view_setting_sort_directions = \GV\Utils::get( $atts, 'sort_direction', array() );
998 997
 
999
-					$has_sort_query_param = ! empty( $_GET['sort'] ) && is_array( $_GET['sort'] );
998
+					$has_sort_query_param = ! empty( $_GET[ 'sort' ] ) && is_array( $_GET[ 'sort' ] );
1000 999
 
1001
-					if( $has_sort_query_param ) {
1002
-						$has_sort_query_param = array_filter( array_values( $_GET['sort'] ) );
1000
+					if ( $has_sort_query_param ) {
1001
+						$has_sort_query_param = array_filter( array_values( $_GET[ 'sort' ] ) );
1003 1002
 					}
1004 1003
 
1005 1004
 					if ( $this->settings->get( 'sort_columns' ) && $has_sort_query_param ) {
1006
-						$sort_field_ids = array_keys( $_GET['sort'] );
1007
-						$sort_directions = array_values( $_GET['sort'] );
1005
+						$sort_field_ids = array_keys( $_GET[ 'sort' ] );
1006
+						$sort_directions = array_values( $_GET[ 'sort' ] );
1008 1007
 					} else {
1009 1008
 						$sort_field_ids = $view_setting_sort_field_ids;
1010 1009
 						$sort_directions = $view_setting_sort_directions;
@@ -1012,7 +1011,7 @@  discard block
 block discarded – undo
1012 1011
 
1013 1012
 					$skip_first = false;
1014 1013
 
1015
-					foreach ( (array) $sort_field_ids as $key => $sort_field_id ) {
1014
+					foreach ( (array)$sort_field_ids as $key => $sort_field_id ) {
1016 1015
 
1017 1016
 						if ( ! $skip_first && ! $has_sort_query_param ) {
1018 1017
 							$skip_first = true; // Skip the first one, it's already in the query
@@ -1042,15 +1041,15 @@  discard block
 block discarded – undo
1042 1041
 
1043 1042
 					$merged_time = false;
1044 1043
 
1045
-					foreach ( $q['order'] as $oid => $order ) {
1046
-						if ( $order[0] instanceof \GF_Query_Column ) {
1047
-							$column = $order[0];
1048
-						} else if ( $order[0] instanceof \GF_Query_Call ) {
1049
-							if ( count( $order[0]->columns ) != 1 || ! $order[0]->columns[0] instanceof \GF_Query_Column ) {
1044
+					foreach ( $q[ 'order' ] as $oid => $order ) {
1045
+						if ( $order[ 0 ] instanceof \GF_Query_Column ) {
1046
+							$column = $order[ 0 ];
1047
+						} else if ( $order[ 0 ] instanceof \GF_Query_Call ) {
1048
+							if ( count( $order[ 0 ]->columns ) != 1 || ! $order[ 0 ]->columns[ 0 ] instanceof \GF_Query_Column ) {
1050 1049
 								$orders[ $oid ] = $order;
1051 1050
 								continue; // Need something that resembles a single sort
1052 1051
 							}
1053
-							$column = $order[0]->columns[0];
1052
+							$column = $order[ 0 ]->columns[ 0 ];
1054 1053
 						}
1055 1054
 
1056 1055
 						if ( ( ! $field = \GFAPI::get_field( $column->source, $column->field_id ) ) || $field->type !== 'time' ) {
@@ -1064,7 +1063,7 @@  discard block
 block discarded – undo
1064 1063
 
1065 1064
 						$orders[ $oid ] = array(
1066 1065
 							new \GV\Mocks\GF_Query_Call_TIMESORT( 'timesort', array( $column, $sql ) ),
1067
-							$order[1] // Mock it!
1066
+							$order[ 1 ] // Mock it!
1068 1067
 						);
1069 1068
 
1070 1069
 						$merged_time = true;
@@ -1075,15 +1074,15 @@  discard block
 block discarded – undo
1075 1074
 						 * ORDER again.
1076 1075
 						 */
1077 1076
 						if ( ! empty( $orders ) && $_orders = $query->_order_generate( $orders ) ) {
1078
-							$sql['order'] = 'ORDER BY ' . implode( ', ', $_orders );
1077
+							$sql[ 'order' ] = 'ORDER BY ' . implode( ', ', $_orders );
1079 1078
 						}
1080 1079
 					}
1081 1080
 
1082 1081
 					return $sql;
1083 1082
 				} );
1084 1083
 
1085
-				$query->limit( $parameters['paging']['page_size'] )
1086
-					->offset( ( ( $page - 1 ) * $parameters['paging']['page_size'] ) + $this->settings->get( 'offset' ) );
1084
+				$query->limit( $parameters[ 'paging' ][ 'page_size' ] )
1085
+					->offset( ( ( $page - 1 ) * $parameters[ 'paging' ][ 'page_size' ] ) + $this->settings->get( 'offset' ) );
1087 1086
 
1088 1087
 				/**
1089 1088
 				 * Any joins?
@@ -1106,7 +1105,7 @@  discard block
 block discarded – undo
1106 1105
 
1107 1106
 							$query_parameters = $query->_introspect();
1108 1107
 
1109
-							$query->where( \GF_Query_Condition::_and( $query_parameters['where'], $condition ) );
1108
+							$query->where( \GF_Query_Condition::_and( $query_parameters[ 'where' ], $condition ) );
1110 1109
 						}
1111 1110
 
1112 1111
 						/**
@@ -1140,7 +1139,7 @@  discard block
 block discarded – undo
1140 1139
 						}
1141 1140
 
1142 1141
 						$q = $query->_introspect();
1143
-						$query->where( \GF_Query_Condition::_and( $q['where'], $condition ) );
1142
+						$query->where( \GF_Query_Condition::_and( $q[ 'where' ], $condition ) );
1144 1143
 
1145 1144
 						if ( $this->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
1146 1145
 
@@ -1165,7 +1164,7 @@  discard block
 block discarded – undo
1165 1164
 
1166 1165
 							$query_parameters = $query->_introspect();
1167 1166
 
1168
-							$query->where( \GF_Query_Condition::_and( $query_parameters['where'], $condition ) );
1167
+							$query->where( \GF_Query_Condition::_and( $query_parameters[ 'where' ], $condition ) );
1169 1168
 						}
1170 1169
 					}
1171 1170
 
@@ -1189,7 +1188,7 @@  discard block
 block discarded – undo
1189 1188
 							$conditions = array();
1190 1189
 
1191 1190
 							foreach ( $condition->expressions as $_condition ) {
1192
-								$conditions[] = $recurse( $_condition, $fields, $recurse );
1191
+								$conditions[ ] = $recurse( $_condition, $fields, $recurse );
1193 1192
 							}
1194 1193
 
1195 1194
 							return call_user_func_array(
@@ -1218,10 +1217,10 @@  discard block
 block discarded – undo
1218 1217
 						$q = new $query_class( $form_id );
1219 1218
 
1220 1219
 						// Copy the WHERE clauses but substitute the field_ids to the respective ones
1221
-						$q->where( $where_union_substitute( $query_parameters['where'], $fields, $where_union_substitute ) );
1220
+						$q->where( $where_union_substitute( $query_parameters[ 'where' ], $fields, $where_union_substitute ) );
1222 1221
 
1223 1222
 						// Copy the ORDER clause and substitute the field_ids to the respective ones
1224
-						foreach ( $query_parameters['order'] as $order ) {
1223
+						foreach ( $query_parameters[ 'order' ] as $order ) {
1225 1224
 							list( $column, $_order ) = $order;
1226 1225
 
1227 1226
 							if ( $column && $column instanceof \GF_Query_Column ) {
@@ -1235,15 +1234,15 @@  discard block
 block discarded – undo
1235 1234
 
1236 1235
 						add_filter( 'gform_gf_query_sql', $gf_query_sql_callback = function( $sql ) use ( &$unions_sql ) {
1237 1236
 							// Remove SQL_CALC_FOUND_ROWS as it's not needed in UNION clauses
1238
-							$select = 'UNION ALL ' . str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql['select'] );
1237
+							$select = 'UNION ALL ' . str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql[ 'select' ] );
1239 1238
 
1240 1239
 							// Record the SQL
1241
-							$unions_sql[] = array(
1240
+							$unions_sql[ ] = array(
1242 1241
 								// Remove columns, we'll rebuild them
1243 1242
 								'select'  => preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $select ),
1244
-								'from'    => $sql['from'],
1245
-								'join'    => $sql['join'],
1246
-								'where'   => $sql['where'],
1243
+								'from'    => $sql[ 'from' ],
1244
+								'join'    => $sql[ 'join' ],
1245
+								'where'   => $sql[ 'where' ],
1247 1246
 								// Remove order and limit
1248 1247
 							);
1249 1248
 
@@ -1260,11 +1259,11 @@  discard block
 block discarded – undo
1260 1259
 
1261 1260
 					add_filter( 'gform_gf_query_sql', $gf_query_sql_callback = function( $sql ) use ( $unions_sql ) {
1262 1261
 						// Remove SQL_CALC_FOUND_ROWS as it's not needed in UNION clauses
1263
-						$sql['select'] = str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql['select'] );
1262
+						$sql[ 'select' ] = str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql[ 'select' ] );
1264 1263
 
1265 1264
 						// Remove columns, we'll rebuild them
1266
-						preg_match( '#DISTINCT (`[motc]\d+`.`.*?`)#', $sql['select'], $select_match );
1267
-						$sql['select'] = preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $sql['select'] );
1265
+						preg_match( '#DISTINCT (`[motc]\d+`.`.*?`)#', $sql[ 'select' ], $select_match );
1266
+						$sql[ 'select' ] = preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $sql[ 'select' ] );
1268 1267
 
1269 1268
 						$unions = array();
1270 1269
 
@@ -1275,30 +1274,30 @@  discard block
 block discarded – undo
1275 1274
 						};
1276 1275
 
1277 1276
 						// Add all the order columns into the selects, so we can order by the whole union group
1278
-						preg_match_all( '#(`[motc]\d+`.`.*?`)#', $sql['order'], $order_matches );
1277
+						preg_match_all( '#(`[motc]\d+`.`.*?`)#', $sql[ 'order' ], $order_matches );
1279 1278
 
1280 1279
 						$columns = array(
1281
-							sprintf( '%s AS %s', $select_match[1], $column_to_alias( $select_match[1] ) )
1280
+							sprintf( '%s AS %s', $select_match[ 1 ], $column_to_alias( $select_match[ 1 ] ) )
1282 1281
 						);
1283 1282
 
1284 1283
 						foreach ( array_slice( $order_matches, 1 ) as $match ) {
1285
-							$columns[] = sprintf( '%s AS %s', $match[0], $column_to_alias( $match[0] ) );
1284
+							$columns[ ] = sprintf( '%s AS %s', $match[ 0 ], $column_to_alias( $match[ 0 ] ) );
1286 1285
 
1287 1286
 							// Rewrite the order columns to the shared aliases
1288
-							$sql['order'] = str_replace( $match[0], $column_to_alias( $match[0] ), $sql['order'] );
1287
+							$sql[ 'order' ] = str_replace( $match[ 0 ], $column_to_alias( $match[ 0 ] ), $sql[ 'order' ] );
1289 1288
 						}
1290 1289
 
1291 1290
 						$columns = array_unique( $columns );
1292 1291
 
1293 1292
 						// Add the columns to every UNION
1294 1293
 						foreach ( $unions_sql as $union_sql ) {
1295
-							$union_sql['select'] .= implode( ', ', $columns );
1296
-							$unions []= implode( ' ', $union_sql );
1294
+							$union_sql[ 'select' ] .= implode( ', ', $columns );
1295
+							$unions [ ] = implode( ' ', $union_sql );
1297 1296
 						}
1298 1297
 
1299 1298
 						// Add the columns to the main SELECT, but only grab the entry id column
1300
-						$sql['select'] = 'SELECT SQL_CALC_FOUND_ROWS t1_id FROM (' . $sql['select'] . implode( ', ', $columns );
1301
-						$sql['order'] = implode( ' ', $unions ) . ') AS u ' . $sql['order'];
1299
+						$sql[ 'select' ] = 'SELECT SQL_CALC_FOUND_ROWS t1_id FROM (' . $sql[ 'select' ] . implode( ', ', $columns );
1300
+						$sql[ 'order' ] = implode( ' ', $unions ) . ') AS u ' . $sql[ 'order' ];
1302 1301
 
1303 1302
 						return $sql;
1304 1303
 					} );
@@ -1343,20 +1342,20 @@  discard block
 block discarded – undo
1343 1342
 				} );
1344 1343
 			} else {
1345 1344
 				$entries = $this->form->entries
1346
-					->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters['search_criteria'] ) )
1345
+					->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters[ 'search_criteria' ] ) )
1347 1346
 					->offset( $this->settings->get( 'offset' ) )
1348
-					->limit( $parameters['paging']['page_size'] )
1347
+					->limit( $parameters[ 'paging' ][ 'page_size' ] )
1349 1348
 					->page( $page );
1350 1349
 
1351
-				if ( ! empty( $parameters['sorting'] ) && is_array( $parameters['sorting'] && ! isset( $parameters['sorting']['key'] ) ) ) {
1350
+				if ( ! empty( $parameters[ 'sorting' ] ) && is_array( $parameters[ 'sorting' ] && ! isset( $parameters[ 'sorting' ][ 'key' ] ) ) ) {
1352 1351
 					// Pluck off multisort arrays
1353
-					$parameters['sorting'] = $parameters['sorting'][0];
1352
+					$parameters[ 'sorting' ] = $parameters[ 'sorting' ][ 0 ];
1354 1353
 				}
1355 1354
 
1356
-				if ( ! empty( $parameters['sorting'] ) && ! empty( $parameters['sorting']['key'] ) ) {
1355
+				if ( ! empty( $parameters[ 'sorting' ] ) && ! empty( $parameters[ 'sorting' ][ 'key' ] ) ) {
1357 1356
 					$field = new \GV\Field();
1358
-					$field->ID = $parameters['sorting']['key'];
1359
-					$direction = strtolower( $parameters['sorting']['direction'] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
1357
+					$field->ID = $parameters[ 'sorting' ][ 'key' ];
1358
+					$direction = strtolower( $parameters[ 'sorting' ][ 'direction' ] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
1360 1359
 					$entries = $entries->sort( new \GV\Entry_Sort( $field, $direction ) );
1361 1360
 				}
1362 1361
 			}
@@ -1431,7 +1430,7 @@  discard block
 block discarded – undo
1431 1430
 		$allowed = $headers = array();
1432 1431
 
1433 1432
 		foreach ( $view->fields->by_position( "directory_*" )->by_visible( $view )->all() as $id => $field ) {
1434
-			$allowed[] = $field;
1433
+			$allowed[ ] = $field;
1435 1434
 		}
1436 1435
 
1437 1436
 		$renderer = new Field_Renderer();
@@ -1453,17 +1452,17 @@  discard block
 block discarded – undo
1453 1452
 			} );
1454 1453
 
1455 1454
 			foreach ( array_diff( $allowed_field_ids, wp_list_pluck( $allowed, 'ID' ) ) as $field_id ) {
1456
-				$allowed[] = is_numeric( $field_id ) ? \GV\GF_Field::by_id( $view->form, $field_id ) : \GV\Internal_Field::by_id( $field_id );
1455
+				$allowed[ ] = is_numeric( $field_id ) ? \GV\GF_Field::by_id( $view->form, $field_id ) : \GV\Internal_Field::by_id( $field_id );
1457 1456
 			}
1458 1457
 
1459 1458
 			foreach ( $allowed as $field ) {
1460 1459
 				$source = is_numeric( $field->ID ) ? $view->form : new \GV\Internal_Source();
1461 1460
 
1462
-				$return[] = $renderer->render( $field, $view, $source, $entry, gravityview()->request, '\GV\Field_CSV_Template' );
1461
+				$return[ ] = $renderer->render( $field, $view, $source, $entry, gravityview()->request, '\GV\Field_CSV_Template' );
1463 1462
 
1464 1463
 				if ( ! $headers_done ) {
1465 1464
 					$label = $field->get_label( $view, $source, $entry );
1466
-					$headers[] = $label ? $label : $field->ID;
1465
+					$headers[ ] = $label ? $label : $field->ID;
1467 1466
 				}
1468 1467
 			}
1469 1468
 
Please login to merge, or discard this patch.
includes/fields/class-gravityview-field-hidden.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
 	function edit_entry_fix_hidden_fields( $fields ) {
50 50
 
51 51
 		/** @var GF_Field $field */
52
-		foreach( $fields as &$field ) {
52
+		foreach ( $fields as &$field ) {
53 53
 
54 54
 			if ( 'hidden' === $field->type ) {
55 55
 
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
 				 */
62 62
 				$reveal_hidden_field = apply_filters( 'gravityview/edit_entry/reveal_hidden_field', true, $field );
63 63
 
64
-				if( ! $reveal_hidden_field ) {
64
+				if ( ! $reveal_hidden_field ) {
65 65
 					continue;
66 66
 				}
67 67
 
Please login to merge, or discard this patch.
includes/class-gravityview-admin-bar.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
 		/** @var WP_Admin_Bar $wp_admin_bar */
39 39
 		global $wp_admin_bar;
40 40
 
41
-		if( is_admin() || ! GVCommon::has_cap( array( 'edit_gravityviews', 'gravityview_edit_entry', 'gravityforms_edit_forms' ) ) ) {
41
+		if ( is_admin() || ! GVCommon::has_cap( array( 'edit_gravityviews', 'gravityview_edit_entry', 'gravityforms_edit_forms' ) ) ) {
42 42
 			return;
43 43
 		}
44 44
 
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
 				'meta' => array(
104 104
 					'title' => sprintf( __( 'Edit Entry %s', 'gravityview' ), \GravityView_API::get_entry_slug( $entry->ID, $entry ) ),
105 105
 				),
106
-				'href' => esc_url_raw( admin_url( sprintf( 'admin.php?page=gf_entries&screen_mode=edit&view=entry&id=%d&lid=%d', $entry['form_id'], $entry['id'] ) ) ),
106
+				'href' => esc_url_raw( admin_url( sprintf( 'admin.php?page=gf_entries&screen_mode=edit&view=entry&id=%d&lid=%d', $entry[ 'form_id' ], $entry[ 'id' ] ) ) ),
107 107
 			) );
108 108
 
109 109
 		}
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
 		/** @var WP_Admin_Bar $wp_admin_bar */
120 120
 		global $wp_admin_bar;
121 121
 
122
-		if( GVCommon::has_cap( array( 'edit_gravityviews', 'edit_gravityview', 'gravityforms_edit_forms' ) ) ) {
122
+		if ( GVCommon::has_cap( array( 'edit_gravityviews', 'edit_gravityview', 'gravityforms_edit_forms' ) ) ) {
123 123
 
124 124
 			$view_data = GravityView_View_Data::getInstance();
125 125
 			$views = $view_data->get_views();
@@ -131,21 +131,21 @@  discard block
 block discarded – undo
131 131
 				$added_views = array();
132 132
 
133 133
 				foreach ( $views as $view ) {
134
-					$view = \GV\View::by_id( $view['id'] );
134
+					$view = \GV\View::by_id( $view[ 'id' ] );
135 135
 					$view_id = $view->ID;
136 136
 					$form_id = $view->form ? $view->form->ID : null;
137 137
 
138 138
 					$edit_view_title = __( 'Edit View', 'gravityview' );
139 139
 					$edit_form_title = __( 'Edit Form', 'gravityview' );
140 140
 
141
-					if( sizeof( $views ) > 1 ) {
141
+					if ( sizeof( $views ) > 1 ) {
142 142
 						$edit_view_title = sprintf( _x( 'Edit View #%d', 'Edit View with the ID of %d', 'gravityview' ), $view_id );
143 143
 						$edit_form_title = sprintf( __( 'Edit Form #%d', 'Edit Form with the ID of %d', 'gravityview' ), $form_id );
144 144
 					}
145 145
 
146
-					if( GVCommon::has_cap( 'edit_gravityview', $view_id ) && ! in_array( $view_id, $added_views ) ) {
146
+					if ( GVCommon::has_cap( 'edit_gravityview', $view_id ) && ! in_array( $view_id, $added_views ) ) {
147 147
 
148
-						$added_views[] = $view_id;
148
+						$added_views[ ] = $view_id;
149 149
 
150 150
 						$wp_admin_bar->add_menu( array(
151 151
 							'id'    => 'edit-view-' . $view_id,
@@ -155,9 +155,9 @@  discard block
 block discarded – undo
155 155
 						) );
156 156
 					}
157 157
 
158
-					if ( ! empty( $form_id ) && GVCommon::has_cap( array( 'gravityforms_edit_forms' ), $form_id ) && ! in_array( $form_id, $added_forms )  ) {
158
+					if ( ! empty( $form_id ) && GVCommon::has_cap( array( 'gravityforms_edit_forms' ), $form_id ) && ! in_array( $form_id, $added_forms ) ) {
159 159
 
160
-						$added_forms[] = $form_id;
160
+						$added_forms[ ] = $form_id;
161 161
 
162 162
 						$wp_admin_bar->add_menu( array(
163 163
 							'id'    => 'edit-form-' . $form_id,
Please login to merge, or discard this patch.
includes/extensions/edit-entry/class-edit-entry-locking.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -67,20 +67,20 @@  discard block
 block discarded – undo
67 67
 		$result = array();
68 68
 		if ( ! $lock_holder_user_id ) {
69 69
 			$this->set_lock( $object_id );
70
-			$result['html']   = __( 'You now have control', 'gravityforms' );
71
-			$result['status'] = 'lock_obtained';
70
+			$result[ 'html' ]   = __( 'You now have control', 'gravityforms' );
71
+			$result[ 'status' ] = 'lock_obtained';
72 72
 		} else {
73 73
 
74
-			if( GVCommon::has_cap( 'gravityforms_edit_entries' ) ) {
74
+			if ( GVCommon::has_cap( 'gravityforms_edit_entries' ) ) {
75 75
 				$user = get_userdata( $lock_holder_user_id );
76
-				$result['html']   = sprintf( __( 'Your request has been sent to %s.', 'gravityforms' ), $user->display_name );
76
+				$result[ 'html' ]   = sprintf( __( 'Your request has been sent to %s.', 'gravityforms' ), $user->display_name );
77 77
 			} else {
78
-				$result['html']   = __( 'Your request has been sent.', 'gravityforms' );
78
+				$result[ 'html' ]   = __( 'Your request has been sent.', 'gravityforms' );
79 79
 			}
80 80
 
81 81
 			$this->update_lock_request_meta( $object_id, $user_id );
82 82
 
83
-			$result['status'] = 'lock_requested';
83
+			$result[ 'status' ] = 'lock_requested';
84 84
 		}
85 85
 
86 86
 		return $result;
@@ -122,19 +122,19 @@  discard block
 block discarded – undo
122 122
 		$continue_enqueuing = false;
123 123
 
124 124
 		// If any Views being loaded have entry locking, enqueue the scripts
125
-		foreach( $views->all() as $view ) {
125
+		foreach ( $views->all() as $view ) {
126 126
 
127 127
 			// Make sure the View has edit locking enabled
128
-			if( ! $view->settings->get( 'edit_locking' ) ) {
128
+			if ( ! $view->settings->get( 'edit_locking' ) ) {
129 129
 				continue;
130 130
 			}
131 131
 
132 132
 			// Make sure that the entry belongs to one of the forms connected to one of the Views in this request
133 133
 			$joined_forms = $view::get_joined_forms( $view->ID );
134 134
 
135
-			$entry_form_id = $entry_array['form_id'];
135
+			$entry_form_id = $entry_array[ 'form_id' ];
136 136
 
137
-			if( ! isset( $joined_forms[ $entry_form_id ] ) ) {
137
+			if ( ! isset( $joined_forms[ $entry_form_id ] ) ) {
138 138
 				continue;
139 139
 			}
140 140
 
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 			break;
144 144
 		}
145 145
 
146
-		if( ! $continue_enqueuing ) {
146
+		if ( ! $continue_enqueuing ) {
147 147
 			return;
148 148
 		}
149 149
 
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
 	 */
164 164
 	protected function enqueue_scripts( $entry ) {
165 165
 
166
-		$min = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG || isset( $_GET['gform_debug'] ) ? '' : '.min';
166
+		$min = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG || isset( $_GET[ 'gform_debug' ] ) ? '' : '.min';
167 167
 		$locking_path = GFCommon::get_base_url() . '/includes/locking/';
168 168
 
169 169
 		wp_enqueue_script( 'gforms_locking', $locking_path . "js/locking{$min}.js", array( 'jquery', 'heartbeat' ), GFCommon::$version );
@@ -172,20 +172,20 @@  discard block
 block discarded – undo
172 172
 		$translations = array_map( 'wp_strip_all_tags', $this->get_strings() );
173 173
 
174 174
 		$strings = array(
175
-			'noResponse'    => $translations['no_response'],
176
-			'requestAgain'  => $translations['request_again'],
177
-			'requestError'  => $translations['request_error'],
178
-			'gainedControl' => $translations['gained_control'],
179
-			'rejected'      => $translations['request_rejected'],
180
-			'pending'       => $translations['request_pending'],
175
+			'noResponse'    => $translations[ 'no_response' ],
176
+			'requestAgain'  => $translations[ 'request_again' ],
177
+			'requestError'  => $translations[ 'request_error' ],
178
+			'gainedControl' => $translations[ 'gained_control' ],
179
+			'rejected'      => $translations[ 'request_rejected' ],
180
+			'pending'       => $translations[ 'request_pending' ],
181 181
 		);
182 182
 
183
-		$lock_user_id = $this->check_lock( $entry['id'] );
183
+		$lock_user_id = $this->check_lock( $entry[ 'id' ] );
184 184
 
185 185
 		$vars = array(
186 186
 			'hasLock'    => ! $lock_user_id ? 1 : 0,
187 187
 			'lockUI'     => $this->get_lock_ui( $lock_user_id ),
188
-			'objectID'   => $entry['id'],
188
+			'objectID'   => $entry[ 'id' ],
189 189
 			'objectType' => 'entry',
190 190
 			'strings'    => $strings,
191 191
 		);
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
 		$hidden = $locked ? '' : ' hidden';
216 216
 		if ( $locked ) {
217 217
 
218
-			if( GVCommon::has_cap( 'gravityforms_edit_entries' ) ) {
218
+			if ( GVCommon::has_cap( 'gravityforms_edit_entries' ) ) {
219 219
 				$avatar = get_avatar( $user->ID, 64 );
220 220
 				$person_editing_text = $user->display_name;
221 221
 			} else {
@@ -322,11 +322,11 @@  discard block
 block discarded – undo
322 322
 
323 323
 		$current_url = add_query_arg( $wp->query_string, '', home_url( $wp->request ) );
324 324
 
325
-		if ( isset( $_GET['get-edit-lock'] ) ) {
325
+		if ( isset( $_GET[ 'get-edit-lock' ] ) ) {
326 326
 			$this->set_lock( $entry_id );
327 327
 			echo '<script>window.location = ' . json_encode( remove_query_arg( 'get-edit-lock', $current_url ) ) . ';</script>';
328 328
 			exit();
329
-		} else if ( isset( $_GET['release-edit-lock'] ) ) {
329
+		} else if ( isset( $_GET[ 'release-edit-lock' ] ) ) {
330 330
 			$this->delete_lock_meta( $entry_id );
331 331
 			$current_url = remove_query_arg( 'edit', $current_url );
332 332
 			echo '<script>window.location = ' . json_encode( remove_query_arg( 'release-edit-lock', $current_url ) ) . ';</script>';
Please login to merge, or discard this patch.
includes/extensions/edit-entry/class-edit-entry-render.php 1 patch
Spacing   +245 added lines, -245 removed lines patch added patch discarded remove patch
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
 	function load() {
136 136
 
137 137
 		/** @define "GRAVITYVIEW_DIR" "../../../" */
138
-		include_once( GRAVITYVIEW_DIR .'includes/class-admin-approve-entries.php' );
138
+		include_once( GRAVITYVIEW_DIR . 'includes/class-admin-approve-entries.php' );
139 139
 
140 140
 		// Don't display an embedded form when editing an entry
141 141
 		add_action( 'wp_head', array( $this, 'prevent_render_form' ) );
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 		add_action( 'wp', array( $this, 'prevent_maybe_process_form' ), 8 );
146 146
 		add_action( 'admin_init', array( $this, 'prevent_maybe_process_form' ), 8 );
147 147
 
148
-		add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry') );
148
+		add_filter( 'gravityview_is_edit_entry', array( $this, 'is_edit_entry' ) );
149 149
 
150 150
 		add_action( 'gravityview_edit_entry', array( $this, 'init' ), 10, 4 );
151 151
 
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
 		add_filter( 'gform_plupload_settings', array( $this, 'modify_fileupload_settings' ), 10, 3 );
157 157
 
158 158
 		// Add fields expected by GFFormDisplay::validate()
159
-		add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation') );
159
+		add_filter( 'gform_pre_validation', array( $this, 'gform_pre_validation' ) );
160 160
 
161 161
 		// Fix multiselect value for GF 2.2
162 162
 		add_filter( 'gravityview/edit_entry/field_value_multiselect', array( $this, 'fix_multiselect_value_serialization' ), 10, 3 );
@@ -173,8 +173,8 @@  discard block
 block discarded – undo
173 173
 	 * @return void
174 174
 	 */
175 175
 	public function prevent_render_form() {
176
-		if( $this->is_edit_entry() ) {
177
-			if( 'wp_head' === current_filter() ) {
176
+		if ( $this->is_edit_entry() ) {
177
+			if ( 'wp_head' === current_filter() ) {
178 178
 				add_filter( 'gform_shortcode_form', '__return_empty_string' );
179 179
 			} else {
180 180
 				remove_filter( 'gform_shortcode_form', '__return_empty_string' );
@@ -189,17 +189,17 @@  discard block
 block discarded – undo
189 189
 	 */
190 190
 	public function prevent_maybe_process_form() {
191 191
 
192
-	    if( ! $this->is_edit_entry_submission() ) {
192
+	    if ( ! $this->is_edit_entry_submission() ) {
193 193
 			return;
194 194
 		}
195 195
 
196 196
 		gravityview()->log->debug( 'GravityView_Edit_Entry[prevent_maybe_process_form] Removing GFForms::maybe_process_form() action.' );
197 197
 
198
-		remove_action( 'wp',  array( 'RGForms', 'maybe_process_form'), 9 );
199
-		remove_action( 'wp',  array( 'GFForms', 'maybe_process_form'), 9 );
198
+		remove_action( 'wp', array( 'RGForms', 'maybe_process_form' ), 9 );
199
+		remove_action( 'wp', array( 'GFForms', 'maybe_process_form' ), 9 );
200 200
 
201
-		remove_action( 'admin_init',  array( 'GFForms', 'maybe_process_form'), 9 );
202
-		remove_action( 'admin_init',  array( 'RGForms', 'maybe_process_form'), 9 );
201
+		remove_action( 'admin_init', array( 'GFForms', 'maybe_process_form' ), 9 );
202
+		remove_action( 'admin_init', array( 'RGForms', 'maybe_process_form' ), 9 );
203 203
 	}
204 204
 
205 205
 	/**
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
210 210
 
211 211
 		$is_edit_entry =
212 212
 			( GravityView_frontend::is_single_entry() || ( ! empty( gravityview()->request->is_entry() ) ) )
213
-			&& ( ! empty( $_GET['edit'] ) );
213
+			&& ( ! empty( $_GET[ 'edit' ] ) );
214 214
 
215 215
 		return ( $is_edit_entry || $this->is_edit_entry_submission() );
216 216
 	}
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
 	 * @return boolean
222 222
 	 */
223 223
 	public function is_edit_entry_submission() {
224
-		return !empty( $_POST[ self::$nonce_field ] );
224
+		return ! empty( $_POST[ self::$nonce_field ] );
225 225
 	}
226 226
 
227 227
 	/**
@@ -234,16 +234,16 @@  discard block
 block discarded – undo
234 234
 
235 235
 
236 236
 		$entries = $gravityview_view->getEntries();
237
-	    self::$original_entry = $entries[0];
238
-	    $this->entry = $entries[0];
237
+	    self::$original_entry = $entries[ 0 ];
238
+	    $this->entry = $entries[ 0 ];
239 239
 
240 240
 		self::$original_form = $gravityview_view->getForm();
241 241
 		$this->form = $gravityview_view->getForm();
242
-		$this->form_id = $this->entry['form_id'];
242
+		$this->form_id = $this->entry[ 'form_id' ];
243 243
 		$this->view_id = $gravityview_view->getViewId();
244 244
 		$this->post_id = \GV\Utils::get( $post, 'ID', null );
245 245
 
246
-		self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry['id'] );
246
+		self::$nonce_key = GravityView_Edit_Entry::get_nonce_key( $this->view_id, $this->form_id, $this->entry[ 'id' ] );
247 247
 	}
248 248
 
249 249
 
@@ -302,9 +302,9 @@  discard block
 block discarded – undo
302 302
 	private function print_scripts() {
303 303
 		$gravityview_view = GravityView_View::getInstance();
304 304
 
305
-		wp_register_script( 'gform_gravityforms', GFCommon::get_base_url().'/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
305
+		wp_register_script( 'gform_gravityforms', GFCommon::get_base_url() . '/js/gravityforms.js', array( 'jquery', 'gform_json', 'gform_placeholder', 'sack', 'plupload-all', 'gravityview-fe-view' ) );
306 306
 
307
-		GFFormDisplay::enqueue_form_scripts( $gravityview_view->getForm(), false);
307
+		GFFormDisplay::enqueue_form_scripts( $gravityview_view->getForm(), false );
308 308
 
309 309
 		wp_localize_script( 'gravityview-fe-view', 'gvGlobals', array( 'cookiepath' => COOKIEPATH ) );
310 310
 
@@ -320,19 +320,19 @@  discard block
 block discarded – undo
320 320
 	 */
321 321
 	private function process_save( $gv_data ) {
322 322
 
323
-		if ( empty( $_POST ) || ! isset( $_POST['lid'] ) ) {
323
+		if ( empty( $_POST ) || ! isset( $_POST[ 'lid' ] ) ) {
324 324
 			return;
325 325
 		}
326 326
 
327 327
 		// Make sure the entry, view, and form IDs are all correct
328 328
 		$valid = $this->verify_nonce();
329 329
 
330
-		if ( !$valid ) {
330
+		if ( ! $valid ) {
331 331
 			gravityview()->log->error( 'Nonce validation failed.' );
332 332
 			return;
333 333
 		}
334 334
 
335
-		if ( $this->entry['id'] !== $_POST['lid'] ) {
335
+		if ( $this->entry[ 'id' ] !== $_POST[ 'lid' ] ) {
336 336
 			gravityview()->log->error( 'Entry ID did not match posted entry ID.' );
337 337
 			return;
338 338
 		}
@@ -343,7 +343,7 @@  discard block
 block discarded – undo
343 343
 
344 344
 		$this->validate();
345 345
 
346
-		if( $this->is_valid ) {
346
+		if ( $this->is_valid ) {
347 347
 
348 348
 			gravityview()->log->debug( 'Submission is valid.' );
349 349
 
@@ -355,15 +355,15 @@  discard block
 block discarded – undo
355 355
 			/**
356 356
 			 * @hack to avoid the capability validation of the method save_lead for GF 1.9+
357 357
 			 */
358
-			unset( $_GET['page'] );
358
+			unset( $_GET[ 'page' ] );
359 359
 
360
-			$date_created = $this->entry['date_created'];
360
+			$date_created = $this->entry[ 'date_created' ];
361 361
 
362 362
 			/**
363 363
 			 * @hack to force Gravity Forms to use $read_value_from_post in GFFormsModel::save_lead()
364 364
 			 * @since 1.17.2
365 365
 			 */
366
-			unset( $this->entry['date_created'] );
366
+			unset( $this->entry[ 'date_created' ] );
367 367
 
368 368
 			/**
369 369
 			 * @action `gravityview/edit_entry/before_update` Perform an action after the entry has been updated using Edit Entry
@@ -373,14 +373,14 @@  discard block
 block discarded – undo
373 373
 			 * @param GravityView_Edit_Entry_Render $this This object
374 374
 			 * @param GravityView_View_Data $gv_data The View data
375 375
 			 */
376
-			do_action( 'gravityview/edit_entry/before_update', $form, $this->entry['id'], $this, $gv_data );
376
+			do_action( 'gravityview/edit_entry/before_update', $form, $this->entry[ 'id' ], $this, $gv_data );
377 377
 
378 378
 			GFFormsModel::save_lead( $form, $this->entry );
379 379
 
380 380
 	        // Delete the values for hidden inputs
381 381
 	        $this->unset_hidden_field_values();
382 382
 
383
-			$this->entry['date_created'] = $date_created;
383
+			$this->entry[ 'date_created' ] = $date_created;
384 384
 
385 385
 			// Process calculation fields
386 386
 			$this->update_calculation_fields();
@@ -405,7 +405,7 @@  discard block
 block discarded – undo
405 405
 			 * @param GravityView_Edit_Entry_Render $this This object
406 406
 			 * @param GravityView_View_Data $gv_data The View data
407 407
 			 */
408
-			do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry['id'], $this, $gv_data );
408
+			do_action( 'gravityview/edit_entry/after_update', $this->form, $this->entry[ 'id' ], $this, $gv_data );
409 409
 
410 410
 		} else {
411 411
 			gravityview()->log->error( 'Submission is NOT valid.', array( 'entry' => $this->entry ) );
@@ -441,10 +441,10 @@  discard block
 block discarded – undo
441 441
 
442 442
 		if ( version_compare( GravityView_GFFormsModel::get_database_version(), '2.3-dev-1', '>=' ) && method_exists( 'GFFormsModel', 'get_entry_meta_table_name' ) ) {
443 443
 			$entry_meta_table = GFFormsModel::get_entry_meta_table_name();
444
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $this->entry['id'] ) );
444
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $this->entry[ 'id' ] ) );
445 445
 		} else {
446 446
 			$lead_detail_table = GFFormsModel::get_lead_details_table_name();
447
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $this->entry['id'] ) );
447
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $this->entry[ 'id' ] ) );
448 448
 		}
449 449
 
450 450
 	    foreach ( $this->entry as $input_id => $field_value ) {
@@ -462,11 +462,11 @@  discard block
 block discarded – undo
462 462
 
463 463
 				$empty_value = $field->get_value_save_entry(
464 464
 					is_array( $field->get_entry_inputs() ) ? array() : '',
465
-					$this->form, '', $this->entry['id'], $this->entry
465
+					$this->form, '', $this->entry[ 'id' ], $this->entry
466 466
 				);
467 467
 
468 468
 				if ( $field->has_calculation() ) {
469
-					$this->unset_hidden_calculations[] = $field->id; // Unset
469
+					$this->unset_hidden_calculations[ ] = $field->id; // Unset
470 470
 					$empty_value = '';
471 471
 				}
472 472
 
@@ -495,7 +495,7 @@  discard block
 block discarded – undo
495 495
 	private function preset_approval_fields() {
496 496
 		$has_approved_field = false;
497 497
 
498
-		foreach ( self::$original_form['fields'] as $field ) {
498
+		foreach ( self::$original_form[ 'fields' ] as $field ) {
499 499
 			if ( $field->gravityview_approved ) {
500 500
 				$has_approved_field = true;
501 501
 				break;
@@ -508,7 +508,7 @@  discard block
 block discarded – undo
508 508
 
509 509
 		$is_field_hidden = true;
510 510
 
511
-		foreach ( $this->form['fields'] as $field ) {
511
+		foreach ( $this->form[ 'fields' ] as $field ) {
512 512
 			if ( $field->gravityview_approved ) {
513 513
 				$is_field_hidden = false;
514 514
 				break;
@@ -533,7 +533,7 @@  discard block
 block discarded – undo
533 533
 
534 534
 		remove_filter( 'gravityview/approve_entries/update_unapproved_meta', array( $this, 'prevent_update_unapproved_meta' ), 9 );
535 535
 
536
-		if ( ! $value = gform_get_meta( $entry['id'], 'is_approved' ) ) {
536
+		if ( ! $value = gform_get_meta( $entry[ 'id' ], 'is_approved' ) ) {
537 537
 
538 538
 			$value = GravityView_Entry_Approval_Status::UNAPPROVED;
539 539
 
@@ -598,7 +598,7 @@  discard block
 block discarded – undo
598 598
 		}
599 599
 
600 600
 		/** No file is being uploaded. */
601
-		if ( empty( $_FILES[ $input_name ]['name'] ) ) {
601
+		if ( empty( $_FILES[ $input_name ][ 'name' ] ) ) {
602 602
 			/** So return the original upload, with $value as backup (it can be empty during edit form rendering) */
603 603
 			return rgar( $entry, $input_id, $value );
604 604
 		}
@@ -616,11 +616,11 @@  discard block
 block discarded – undo
616 616
 	 * @return mixed
617 617
 	 */
618 618
 	public function modify_fileupload_settings( $plupload_init, $form_id, $instance ) {
619
-		if( ! $this->is_edit_entry() ) {
619
+		if ( ! $this->is_edit_entry() ) {
620 620
 			return $plupload_init;
621 621
 		}
622 622
 
623
-		$plupload_init['gf_vars']['max_files'] = 0;
623
+		$plupload_init[ 'gf_vars' ][ 'max_files' ] = 0;
624 624
 
625 625
 		return $plupload_init;
626 626
 	}
@@ -635,27 +635,27 @@  discard block
 block discarded – undo
635 635
 		$form = $this->filter_conditional_logic( $this->form );
636 636
 
637 637
 	    /** @var GF_Field $field */
638
-		foreach( $form['fields'] as $k => &$field ) {
638
+		foreach ( $form[ 'fields' ] as $k => &$field ) {
639 639
 
640 640
 			/**
641 641
 			 * Remove the fields with calculation formulas before save to avoid conflicts with GF logic
642 642
 			 * @since 1.16.3
643 643
 			 * @var GF_Field $field
644 644
 			 */
645
-			if( $field->has_calculation() ) {
646
-				unset( $form['fields'][ $k ] );
645
+			if ( $field->has_calculation() ) {
646
+				unset( $form[ 'fields' ][ $k ] );
647 647
 			}
648 648
 
649 649
 			$field->adminOnly = false;
650 650
 
651
-			if( isset( $field->inputs ) && is_array( $field->inputs ) ) {
652
-				foreach( $field->inputs as $key => $input ) {
653
-				    $field->inputs[ $key ][ 'id' ] = (string)$input['id'];
651
+			if ( isset( $field->inputs ) && is_array( $field->inputs ) ) {
652
+				foreach ( $field->inputs as $key => $input ) {
653
+				    $field->inputs[ $key ][ 'id' ] = (string)$input[ 'id' ];
654 654
 				}
655 655
 			}
656 656
 		}
657 657
 
658
-		$form['fields'] = array_values( $form['fields'] );
658
+		$form[ 'fields' ] = array_values( $form[ 'fields' ] );
659 659
 
660 660
 		return $form;
661 661
 	}
@@ -667,14 +667,14 @@  discard block
 block discarded – undo
667 667
 		$update = false;
668 668
 
669 669
 		// get the most up to date entry values
670
-		$entry = GFAPI::get_entry( $this->entry['id'] );
670
+		$entry = GFAPI::get_entry( $this->entry[ 'id' ] );
671 671
 
672 672
 		if ( version_compare( GravityView_GFFormsModel::get_database_version(), '2.3-dev-1', '>=' ) && method_exists( 'GFFormsModel', 'get_entry_meta_table_name' ) ) {
673 673
 			$entry_meta_table = GFFormsModel::get_entry_meta_table_name();
674
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $entry['id'] ) );
674
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $entry_meta_table WHERE entry_id=%d", $entry[ 'id' ] ) );
675 675
 		} else {
676 676
 			$lead_detail_table = GFFormsModel::get_lead_details_table_name();
677
-			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $entry['id'] ) );
677
+			$current_fields = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $lead_detail_table WHERE lead_id=%d", $entry[ 'id' ] ) );
678 678
 		}
679 679
 
680 680
 
@@ -691,24 +691,24 @@  discard block
 block discarded – undo
691 691
 				$inputs = $field->get_entry_inputs();
692 692
 				if ( is_array( $inputs ) ) {
693 693
 				    foreach ( $inputs as $input ) {
694
-						list( $field_id, $input_id ) = rgexplode( '.', $input['id'], 2 );
694
+						list( $field_id, $input_id ) = rgexplode( '.', $input[ 'id' ], 2 );
695 695
 
696 696
 						if ( 'product' === $field->type ) {
697
-							$input_name = 'input_' . str_replace( '.', '_', $input['id'] );
697
+							$input_name = 'input_' . str_replace( '.', '_', $input[ 'id' ] );
698 698
 
699 699
 							// Only allow quantity to be set if it's allowed to be edited
700 700
 							if ( in_array( $field_id, $allowed_fields ) && $input_id == 3 ) {
701 701
 							} else { // otherwise set to what it previously was
702
-								$_POST[ $input_name ] = $entry[ $input['id'] ];
702
+								$_POST[ $input_name ] = $entry[ $input[ 'id' ] ];
703 703
 							}
704 704
 						} else {
705 705
 							// Set to what it previously was if it's not editable
706 706
 							if ( ! in_array( $field_id, $allowed_fields ) ) {
707
-								$_POST[ $input_name ] = $entry[ $input['id'] ];
707
+								$_POST[ $input_name ] = $entry[ $input[ 'id' ] ];
708 708
 							}
709 709
 						}
710 710
 
711
-						GFFormsModel::save_input( $form, $field, $entry, $current_fields, $input['id'] );
711
+						GFFormsModel::save_input( $form, $field, $entry, $current_fields, $input[ 'id' ] );
712 712
 				    }
713 713
 				} else {
714 714
 					// Set to what it previously was if it's not editable
@@ -748,19 +748,19 @@  discard block
 block discarded – undo
748 748
 
749 749
 		$input_name = 'input_' . $field_id;
750 750
 
751
-		if ( !empty( $_FILES[ $input_name ]['name'] ) ) {
751
+		if ( ! empty( $_FILES[ $input_name ][ 'name' ] ) ) {
752 752
 
753 753
 			// We have a new image
754 754
 
755
-			$value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'] );
755
+			$value = RGFormsModel::prepare_value( $form, $field, $value, $input_name, $entry[ 'id' ] );
756 756
 
757 757
 			$ary = ! empty( $value ) ? explode( '|:|', $value ) : array();
758 758
 	        $ary = stripslashes_deep( $ary );
759 759
 			$img_url = \GV\Utils::get( $ary, 0 );
760 760
 
761
-			$img_title       = count( $ary ) > 1 ? $ary[1] : '';
762
-			$img_caption     = count( $ary ) > 2 ? $ary[2] : '';
763
-			$img_description = count( $ary ) > 3 ? $ary[3] : '';
761
+			$img_title       = count( $ary ) > 1 ? $ary[ 1 ] : '';
762
+			$img_caption     = count( $ary ) > 2 ? $ary[ 2 ] : '';
763
+			$img_description = count( $ary ) > 3 ? $ary[ 3 ] : '';
764 764
 
765 765
 			$image_meta = array(
766 766
 				'post_excerpt' => $img_caption,
@@ -769,7 +769,7 @@  discard block
 block discarded – undo
769 769
 
770 770
 			//adding title only if it is not empty. It will default to the file name if it is not in the array
771 771
 			if ( ! empty( $img_title ) ) {
772
-				$image_meta['post_title'] = $img_title;
772
+				$image_meta[ 'post_title' ] = $img_title;
773 773
 			}
774 774
 
775 775
 			/**
@@ -827,15 +827,15 @@  discard block
 block discarded – undo
827 827
 	 */
828 828
 	private function maybe_update_post_fields( $form ) {
829 829
 
830
-		if( empty( $this->entry['post_id'] ) ) {
830
+		if ( empty( $this->entry[ 'post_id' ] ) ) {
831 831
 	        gravityview()->log->debug( 'This entry has no post fields. Continuing...' );
832 832
 			return;
833 833
 		}
834 834
 
835
-		$post_id = $this->entry['post_id'];
835
+		$post_id = $this->entry[ 'post_id' ];
836 836
 
837 837
 		// Security check
838
-		if( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
838
+		if ( false === GVCommon::has_cap( 'edit_post', $post_id ) ) {
839 839
 			gravityview()->log->error( 'The current user does not have the ability to edit Post #{post_id}', array( 'post_id' => $post_id ) );
840 840
 			return;
841 841
 		}
@@ -848,25 +848,25 @@  discard block
 block discarded – undo
848 848
 
849 849
 			$field = RGFormsModel::get_field( $form, $field_id );
850 850
 
851
-			if( ! $field ) {
851
+			if ( ! $field ) {
852 852
 				continue;
853 853
 			}
854 854
 
855
-			if( GFCommon::is_post_field( $field ) && 'post_category' !== $field->type ) {
855
+			if ( GFCommon::is_post_field( $field ) && 'post_category' !== $field->type ) {
856 856
 
857 857
 				// Get the value of the field, including $_POSTed value
858 858
 				$value = RGFormsModel::get_field_value( $field );
859 859
 
860 860
 				// Use temporary entry variable, to make values available to fill_post_template() and update_post_image()
861 861
 				$entry_tmp = $this->entry;
862
-				$entry_tmp["{$field_id}"] = $value;
862
+				$entry_tmp[ "{$field_id}" ] = $value;
863 863
 
864
-				switch( $field->type ) {
864
+				switch ( $field->type ) {
865 865
 
866 866
 				    case 'post_title':
867 867
 				        $post_title = $value;
868 868
 				        if ( \GV\Utils::get( $form, 'postTitleTemplateEnabled' ) ) {
869
-				            $post_title = $this->fill_post_template( $form['postTitleTemplate'], $form, $entry_tmp );
869
+				            $post_title = $this->fill_post_template( $form[ 'postTitleTemplate' ], $form, $entry_tmp );
870 870
 				        }
871 871
 				        $updated_post->post_title = $post_title;
872 872
 				        $updated_post->post_name  = $post_title;
@@ -876,7 +876,7 @@  discard block
 block discarded – undo
876 876
 				    case 'post_content':
877 877
 				        $post_content = $value;
878 878
 				        if ( \GV\Utils::get( $form, 'postContentTemplateEnabled' ) ) {
879
-				            $post_content = $this->fill_post_template( $form['postContentTemplate'], $form, $entry_tmp, true );
879
+				            $post_content = $this->fill_post_template( $form[ 'postContentTemplate' ], $form, $entry_tmp, true );
880 880
 				        }
881 881
 				        $updated_post->post_content = $post_content;
882 882
 				        unset( $post_content );
@@ -894,11 +894,11 @@  discard block
 block discarded – undo
894 894
 							$value = $value[ $field_id ];
895 895
 						}
896 896
 
897
-				        if( ! empty( $field->customFieldTemplateEnabled ) ) {
897
+				        if ( ! empty( $field->customFieldTemplateEnabled ) ) {
898 898
 				            $value = $this->fill_post_template( $field->customFieldTemplate, $form, $entry_tmp, true );
899 899
 				        }
900 900
 
901
-						$value = $field->get_value_save_entry( $value, $form, '', $this->entry['id'], $this->entry );
901
+						$value = $field->get_value_save_entry( $value, $form, '', $this->entry[ 'id' ], $this->entry );
902 902
 
903 903
 				        update_post_meta( $post_id, $field->postCustomFieldName, $value );
904 904
 				        break;
@@ -910,7 +910,7 @@  discard block
 block discarded – undo
910 910
 				}
911 911
 
912 912
 				// update entry after
913
-				$this->entry["{$field_id}"] = $value;
913
+				$this->entry[ "{$field_id}" ] = $value;
914 914
 
915 915
 				$update_entry = true;
916 916
 
@@ -919,11 +919,11 @@  discard block
 block discarded – undo
919 919
 
920 920
 		}
921 921
 
922
-		if( $update_entry ) {
922
+		if ( $update_entry ) {
923 923
 
924 924
 			$return_entry = GFAPI::update_entry( $this->entry );
925 925
 
926
-			if( is_wp_error( $return_entry ) ) {
926
+			if ( is_wp_error( $return_entry ) ) {
927 927
 				gravityview()->log->error( 'Updating the entry post fields failed', array( 'data' => array( '$this->entry' => $this->entry, '$return_entry' => $return_entry ) ) );
928 928
 			} else {
929 929
 				gravityview()->log->debug( 'Updating the entry post fields for post #{post_id} succeeded', array( 'post_id' => $post_id ) );
@@ -933,7 +933,7 @@  discard block
 block discarded – undo
933 933
 
934 934
 		$return_post = wp_update_post( $updated_post, true );
935 935
 
936
-		if( is_wp_error( $return_post ) ) {
936
+		if ( is_wp_error( $return_post ) ) {
937 937
 			$return_post->add_data( $updated_post, '$updated_post' );
938 938
 			gravityview()->log->error( 'Updating the post content failed', array( 'data' => compact( 'updated_post', 'return_post' ) ) );
939 939
 		} else {
@@ -967,7 +967,7 @@  discard block
 block discarded – undo
967 967
 		$output = GFCommon::replace_variables( $output, $form, $entry, false, false, false );
968 968
 
969 969
 		// replace conditional shortcodes
970
-		if( $do_shortcode ) {
970
+		if ( $do_shortcode ) {
971 971
 			$output = do_shortcode( $output );
972 972
 		}
973 973
 
@@ -986,19 +986,19 @@  discard block
 block discarded – undo
986 986
 	 */
987 987
 	private function after_update() {
988 988
 
989
-		do_action( 'gform_after_update_entry', self::$original_form, $this->entry['id'], self::$original_entry );
990
-		do_action( "gform_after_update_entry_{$this->form['id']}", self::$original_form, $this->entry['id'], self::$original_entry );
989
+		do_action( 'gform_after_update_entry', self::$original_form, $this->entry[ 'id' ], self::$original_entry );
990
+		do_action( "gform_after_update_entry_{$this->form[ 'id' ]}", self::$original_form, $this->entry[ 'id' ], self::$original_entry );
991 991
 
992 992
 		// Re-define the entry now that we've updated it.
993
-		$entry = RGFormsModel::get_lead( $this->entry['id'] );
993
+		$entry = RGFormsModel::get_lead( $this->entry[ 'id' ] );
994 994
 
995 995
 		$entry = GFFormsModel::set_entry_meta( $entry, self::$original_form );
996 996
 
997 997
 		if ( version_compare( GFFormsModel::get_database_version(), '2.3-dev-1', '<' ) ) {
998 998
 			// We need to clear the cache because Gravity Forms caches the field values, which
999 999
 			// we have just updated.
1000
-			foreach ($this->form['fields'] as $key => $field) {
1001
-				GFFormsModel::refresh_lead_field_value( $entry['id'], $field->id );
1000
+			foreach ( $this->form[ 'fields' ] as $key => $field ) {
1001
+				GFFormsModel::refresh_lead_field_value( $entry[ 'id' ], $field->id );
1002 1002
 			}
1003 1003
 		}
1004 1004
 
@@ -1008,11 +1008,11 @@  discard block
 block discarded – undo
1008 1008
 		 * @since develop
1009 1009
 		 */
1010 1010
 		if ( $allowed_feeds = $this->view->settings->get( 'edit_feeds', array() ) ) {
1011
-			$feeds = GFAPI::get_feeds( null, $entry['form_id'] );
1011
+			$feeds = GFAPI::get_feeds( null, $entry[ 'form_id' ] );
1012 1012
 			if ( ! is_wp_error( $feeds ) ) {
1013 1013
 				$registered_feeds = array();
1014 1014
 				foreach ( GFAddOn::get_registered_addons() as $registered_feed ) {
1015
-					if ( is_subclass_of( $registered_feed,  'GFFeedAddOn' ) ) {
1015
+					if ( is_subclass_of( $registered_feed, 'GFFeedAddOn' ) ) {
1016 1016
 						if ( method_exists( $registered_feed, 'get_instance' ) ) {
1017 1017
 							$registered_feed = call_user_func( array( $registered_feed, 'get_instance' ) );
1018 1018
 							$registered_feeds[ $registered_feed->get_slug() ] = $registered_feed;
@@ -1020,8 +1020,8 @@  discard block
 block discarded – undo
1020 1020
 					}
1021 1021
 				}
1022 1022
 				foreach ( $feeds as $feed ) {
1023
-					if ( in_array( $feed['id'], $allowed_feeds ) ) {
1024
-						if ( $feed_object = \GV\Utils::get( $registered_feeds, $feed['addon_slug'] ) ) {
1023
+					if ( in_array( $feed[ 'id' ], $allowed_feeds ) ) {
1024
+						if ( $feed_object = \GV\Utils::get( $registered_feeds, $feed[ 'addon_slug' ] ) ) {
1025 1025
 							$returned_entry = $feed_object->process_feed( $feed, $entry, self::$original_form );
1026 1026
 							if ( is_array( $returned_entry ) && rgar( $returned_entry, 'id' ) ) {
1027 1027
 								$entry = $returned_entry;
@@ -1049,9 +1049,9 @@  discard block
 block discarded – undo
1049 1049
 
1050 1050
 		$view = \GV\View::by_id( $this->view_id );
1051 1051
 
1052
-		if( $view->settings->get( 'edit_locking' ) ) {
1052
+		if ( $view->settings->get( 'edit_locking' ) ) {
1053 1053
 			$locking = new GravityView_Edit_Entry_Locking();
1054
-			$locking->maybe_lock_object( $this->entry['id'] );
1054
+			$locking->maybe_lock_object( $this->entry[ 'id' ] );
1055 1055
 		}
1056 1056
 
1057 1057
 		?>
@@ -1064,7 +1064,7 @@  discard block
 block discarded – undo
1064 1064
 
1065 1065
 		<div class="gv-edit-entry-wrapper"><?php
1066 1066
 
1067
-			$javascript = gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/inline-javascript.php', $this );
1067
+			$javascript = gravityview_ob_include( GravityView_Edit_Entry::$file . '/partials/inline-javascript.php', $this );
1068 1068
 
1069 1069
 			/**
1070 1070
 			 * Fixes weird wpautop() issue
@@ -1080,7 +1080,7 @@  discard block
 block discarded – undo
1080 1080
 				     * @param string $edit_entry_title Modify the "Edit Entry" title
1081 1081
 				     * @param GravityView_Edit_Entry_Render $this This object
1082 1082
 				     */
1083
-				    $edit_entry_title = apply_filters('gravityview_edit_entry_title', __('Edit Entry', 'gravityview'), $this );
1083
+				    $edit_entry_title = apply_filters( 'gravityview_edit_entry_title', __( 'Edit Entry', 'gravityview' ), $this );
1084 1084
 
1085 1085
 				    echo esc_attr( $edit_entry_title );
1086 1086
 			?></span>
@@ -1146,18 +1146,18 @@  discard block
 block discarded – undo
1146 1146
 				*/
1147 1147
 				$labels = apply_filters( 'gravityview/edit_entry/button_labels', $labels, $this->form, $this->entry, $this->view_id );
1148 1148
 
1149
-				$this->is_paged_submitted = \GV\Utils::_POST( 'save' ) === $labels['submit'];
1149
+				$this->is_paged_submitted = \GV\Utils::_POST( 'save' ) === $labels[ 'submit' ];
1150 1150
 			}
1151 1151
 
1152 1152
 			$back_link = remove_query_arg( array( 'page', 'view', 'edit' ) );
1153 1153
 
1154
-			if( ! $this->is_valid ){
1154
+			if ( ! $this->is_valid ) {
1155 1155
 
1156 1156
 				// Keeping this compatible with Gravity Forms.
1157
-				$validation_message = "<div class='validation_error'>" . __('There was a problem with your submission.', 'gravityview') . " " . __('Errors have been highlighted below.', 'gravityview') . "</div>";
1158
-				$message = apply_filters("gform_validation_message_{$this->form['id']}", apply_filters("gform_validation_message", $validation_message, $this->form), $this->form);
1157
+				$validation_message = "<div class='validation_error'>" . __( 'There was a problem with your submission.', 'gravityview' ) . " " . __( 'Errors have been highlighted below.', 'gravityview' ) . "</div>";
1158
+				$message = apply_filters( "gform_validation_message_{$this->form[ 'id' ]}", apply_filters( "gform_validation_message", $validation_message, $this->form ), $this->form );
1159 1159
 
1160
-				echo GVCommon::generate_notice( $message , 'gv-error' );
1160
+				echo GVCommon::generate_notice( $message, 'gv-error' );
1161 1161
 
1162 1162
 			} elseif ( false === $this->is_paged_submitted ) {
1163 1163
 				// Paged form that hasn't been submitted on the last page yet
@@ -1170,7 +1170,7 @@  discard block
 block discarded – undo
1170 1170
 				 * @param int $view_id View ID
1171 1171
 				 * @param array $entry Gravity Forms entry array
1172 1172
 				 */
1173
-				$message = apply_filters( 'gravityview/edit_entry/page/success', $entry_updated_message , $this->view_id, $this->entry );
1173
+				$message = apply_filters( 'gravityview/edit_entry/page/success', $entry_updated_message, $this->view_id, $this->entry );
1174 1174
 
1175 1175
 				echo GVCommon::generate_notice( $message );
1176 1176
 			} else {
@@ -1182,23 +1182,23 @@  discard block
 block discarded – undo
1182 1182
 
1183 1183
                     case '0':
1184 1184
 	                    $redirect_url = $back_link;
1185
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to Entry%s', 'Replacements are HTML', 'gravityview'), '<a href="'. esc_url( $redirect_url ) .'">', '</a>' );
1185
+	                    $entry_updated_message = sprintf( esc_attr_x( 'Entry Updated. %sReturning to Entry%s', 'Replacements are HTML', 'gravityview' ), '<a href="' . esc_url( $redirect_url ) . '">', '</a>' );
1186 1186
                         break;
1187 1187
 
1188 1188
                     case '1':
1189 1189
 	                    $redirect_url = $directory_link = GravityView_API::directory_link();
1190
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sReturning to %s%s', 'Replacement 1 is HTML. Replacement 2 is the title of the page where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $view->post_title ), '</a>' );
1190
+	                    $entry_updated_message = sprintf( esc_attr_x( 'Entry Updated. %sReturning to %s%s', 'Replacement 1 is HTML. Replacement 2 is the title of the page where the user will be taken. Replacement 3 is HTML.', 'gravityview' ), '<a href="' . esc_url( $redirect_url ) . '">', esc_html( $view->post_title ), '</a>' );
1191 1191
 	                    break;
1192 1192
 
1193 1193
                     case '2':
1194 1194
 	                    $redirect_url = $edit_redirect_url;
1195 1195
 	                    $redirect_url = GFCommon::replace_variables( $redirect_url, $this->form, $this->entry, false, false, false, 'text' );
1196
-	                    $entry_updated_message = sprintf( esc_attr_x('Entry Updated. %sRedirecting to %s%s', 'Replacement 1 is HTML. Replacement 2 is the URL where the user will be taken. Replacement 3 is HTML.','gravityview'), '<a href="'. esc_url( $redirect_url ) . '">', esc_html( $edit_redirect_url ), '</a>' );
1196
+	                    $entry_updated_message = sprintf( esc_attr_x( 'Entry Updated. %sRedirecting to %s%s', 'Replacement 1 is HTML. Replacement 2 is the URL where the user will be taken. Replacement 3 is HTML.', 'gravityview' ), '<a href="' . esc_url( $redirect_url ) . '">', esc_html( $edit_redirect_url ), '</a>' );
1197 1197
                         break;
1198 1198
 
1199 1199
                     case '':
1200 1200
                     default:
1201
-					    $entry_updated_message = sprintf( esc_attr__('Entry Updated. %sReturn to Entry%s', 'gravityview'), '<a href="'. esc_url( $back_link ) .'">', '</a>' );
1201
+					    $entry_updated_message = sprintf( esc_attr__( 'Entry Updated. %sReturn to Entry%s', 'gravityview' ), '<a href="' . esc_url( $back_link ) . '">', '</a>' );
1202 1202
                         break;
1203 1203
 				}
1204 1204
 
@@ -1214,7 +1214,7 @@  discard block
 block discarded – undo
1214 1214
 				 * @param array $entry Gravity Forms entry array
1215 1215
 				 * @param string $back_link URL to return to the original entry. @since 1.6
1216 1216
 				 */
1217
-				$message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message , $this->view_id, $this->entry, $back_link );
1217
+				$message = apply_filters( 'gravityview/edit_entry/success', $entry_updated_message, $this->view_id, $this->entry, $back_link );
1218 1218
 
1219 1219
 				echo GVCommon::generate_notice( $message );
1220 1220
 			}
@@ -1238,8 +1238,8 @@  discard block
 block discarded – undo
1238 1238
 		 */
1239 1239
 		do_action( 'gravityview/edit-entry/render/before', $this );
1240 1240
 
1241
-		add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields'), 5000, 3 );
1242
-		add_filter( 'gform_submit_button', array( $this, 'render_form_buttons') );
1241
+		add_filter( 'gform_pre_render', array( $this, 'filter_modify_form_fields' ), 5000, 3 );
1242
+		add_filter( 'gform_submit_button', array( $this, 'render_form_buttons' ) );
1243 1243
 		add_filter( 'gform_next_button', array( $this, 'render_form_buttons' ) );
1244 1244
 		add_filter( 'gform_previous_button', array( $this, 'render_form_buttons' ) );
1245 1245
 		add_filter( 'gform_disable_view_counter', '__return_true' );
@@ -1248,14 +1248,14 @@  discard block
 block discarded – undo
1248 1248
 		add_filter( 'gform_field_input', array( $this, 'modify_edit_field_input' ), 10, 5 );
1249 1249
 
1250 1250
 		// We need to remove the fake $_GET['page'] arg to avoid rendering form as if in admin.
1251
-		unset( $_GET['page'] );
1251
+		unset( $_GET[ 'page' ] );
1252 1252
 
1253 1253
 		$this->show_next_button = false;
1254 1254
 		$this->show_previous_button = false;
1255 1255
 
1256 1256
 		// TODO: Verify multiple-page forms
1257 1257
 		if ( GFCommon::has_pages( $this->form ) && apply_filters( 'gravityview/features/paged-edit', false ) ) {
1258
-			if ( intval( $page_number = \GV\Utils::_POST( 'gform_source_page_number_' . $this->form['id'], 0 ) ) ) {
1258
+			if ( intval( $page_number = \GV\Utils::_POST( 'gform_source_page_number_' . $this->form[ 'id' ], 0 ) ) ) {
1259 1259
 
1260 1260
 				$labels = array(
1261 1261
 					'cancel'   => __( 'Cancel', 'gravityview' ),
@@ -1274,20 +1274,20 @@  discard block
 block discarded – undo
1274 1274
 				*/
1275 1275
 				$labels = apply_filters( 'gravityview/edit_entry/button_labels', $labels, $this->form, $this->entry, $this->view_id );
1276 1276
 
1277
-				GFFormDisplay::$submission[ $this->form['id'] ][ 'form' ] = $this->form;
1278
-				GFFormDisplay::$submission[ $this->form['id'] ][ 'is_valid' ] = true;
1277
+				GFFormDisplay::$submission[ $this->form[ 'id' ] ][ 'form' ] = $this->form;
1278
+				GFFormDisplay::$submission[ $this->form[ 'id' ] ][ 'is_valid' ] = true;
1279 1279
 
1280
-				if ( \GV\Utils::_POST( 'save' ) === $labels['next'] ) {
1280
+				if ( \GV\Utils::_POST( 'save' ) === $labels[ 'next' ] ) {
1281 1281
 					$last_page = \GFFormDisplay::get_max_page_number( $this->form );
1282 1282
 
1283 1283
 					while ( ++$page_number < $last_page && RGFormsModel::is_page_hidden( $this->form, $page_number, \GV\Utils::_POST( 'gform_field_values' ) ) ) {
1284 1284
 					} // Advance to next visible page
1285
-				} elseif ( \GV\Utils::_POST( 'save' ) === $labels['previous'] ) {
1285
+				} elseif ( \GV\Utils::_POST( 'save' ) === $labels[ 'previous' ] ) {
1286 1286
 					while ( --$page_number > 1 && RGFormsModel::is_page_hidden( $this->form, $page_number, \GV\Utils::_POST( 'gform_field_values' ) ) ) {
1287 1287
 					} // Advance to next visible page
1288 1288
 				}
1289 1289
 
1290
-				GFFormDisplay::$submission[ $this->form['id'] ]['page_number'] = $page_number;
1290
+				GFFormDisplay::$submission[ $this->form[ 'id' ] ][ 'page_number' ] = $page_number;
1291 1291
 			}
1292 1292
 
1293 1293
 			if ( ( $page_number = intval( $page_number ) ) < 2 ) {
@@ -1313,7 +1313,7 @@  discard block
 block discarded – undo
1313 1313
 
1314 1314
 		ob_start(); // Prevent PHP warnings possibly caused by prefilling list fields for conditional logic
1315 1315
 
1316
-		$html = GFFormDisplay::get_form( $this->form['id'], false, false, true, $this->entry );
1316
+		$html = GFFormDisplay::get_form( $this->form[ 'id' ], false, false, true, $this->entry );
1317 1317
 
1318 1318
 		ob_get_clean();
1319 1319
 
@@ -1341,7 +1341,7 @@  discard block
 block discarded – undo
1341 1341
 	 * @return string
1342 1342
 	 */
1343 1343
 	public function render_form_buttons() {
1344
-		return gravityview_ob_include( GravityView_Edit_Entry::$file .'/partials/form-buttons.php', $this );
1344
+		return gravityview_ob_include( GravityView_Edit_Entry::$file . '/partials/form-buttons.php', $this );
1345 1345
 	}
1346 1346
 
1347 1347
 
@@ -1360,15 +1360,15 @@  discard block
 block discarded – undo
1360 1360
 	 */
1361 1361
 	public function filter_modify_form_fields( $form, $ajax = false, $field_values = '' ) {
1362 1362
 
1363
-		if( $form['id'] != $this->form_id ) {
1363
+		if ( $form[ 'id' ] != $this->form_id ) {
1364 1364
 			return $form;
1365 1365
 		}
1366 1366
 
1367 1367
 		// In case we have validated the form, use it to inject the validation results into the form render
1368
-		if( isset( $this->form_after_validation ) && $this->form_after_validation['id'] === $form['id'] ) {
1368
+		if ( isset( $this->form_after_validation ) && $this->form_after_validation[ 'id' ] === $form[ 'id' ] ) {
1369 1369
 			$form = $this->form_after_validation;
1370 1370
 		} else {
1371
-			$form['fields'] = $this->get_configured_edit_fields( $form, $this->view_id );
1371
+			$form[ 'fields' ] = $this->get_configured_edit_fields( $form, $this->view_id );
1372 1372
 		}
1373 1373
 
1374 1374
 		$form = $this->filter_conditional_logic( $form );
@@ -1376,8 +1376,8 @@  discard block
 block discarded – undo
1376 1376
 		$form = $this->prefill_conditional_logic( $form );
1377 1377
 
1378 1378
 		// for now we don't support Save and Continue feature.
1379
-		if( ! self::$supports_save_and_continue ) {
1380
-	        unset( $form['save'] );
1379
+		if ( ! self::$supports_save_and_continue ) {
1380
+	        unset( $form[ 'save' ] );
1381 1381
 		}
1382 1382
 
1383 1383
 		$form = $this->unselect_default_values( $form );
@@ -1400,31 +1400,31 @@  discard block
 block discarded – undo
1400 1400
 	 */
1401 1401
 	public function verify_user_can_edit_post( $field_content = '', $field, $value, $lead_id = 0, $form_id ) {
1402 1402
 
1403
-		if( ! GFCommon::is_post_field( $field ) ) {
1403
+		if ( ! GFCommon::is_post_field( $field ) ) {
1404 1404
 			return $field_content;
1405 1405
 		}
1406 1406
 
1407 1407
         $message = null;
1408 1408
 
1409 1409
         // First, make sure they have the capability to edit the post.
1410
-        if( false === current_user_can( 'edit_post', $this->entry['post_id'] ) ) {
1410
+        if ( false === current_user_can( 'edit_post', $this->entry[ 'post_id' ] ) ) {
1411 1411
 
1412 1412
             /**
1413 1413
              * @filter `gravityview/edit_entry/unsupported_post_field_text` Modify the message when someone isn't able to edit a post
1414 1414
              * @param string $message The existing "You don't have permission..." text
1415 1415
              */
1416
-            $message = apply_filters('gravityview/edit_entry/unsupported_post_field_text', __('You don&rsquo;t have permission to edit this post.', 'gravityview') );
1416
+            $message = apply_filters( 'gravityview/edit_entry/unsupported_post_field_text', __( 'You don&rsquo;t have permission to edit this post.', 'gravityview' ) );
1417 1417
 
1418
-        } elseif( null === get_post( $this->entry['post_id'] ) ) {
1418
+        } elseif ( null === get_post( $this->entry[ 'post_id' ] ) ) {
1419 1419
             /**
1420 1420
              * @filter `gravityview/edit_entry/no_post_text` Modify the message when someone is editing an entry attached to a post that no longer exists
1421 1421
              * @param string $message The existing "This field is not editable; the post no longer exists." text
1422 1422
              */
1423
-            $message = apply_filters('gravityview/edit_entry/no_post_text', __('This field is not editable; the post no longer exists.', 'gravityview' ) );
1423
+            $message = apply_filters( 'gravityview/edit_entry/no_post_text', __( 'This field is not editable; the post no longer exists.', 'gravityview' ) );
1424 1424
         }
1425 1425
 
1426
-        if( $message ) {
1427
-            $field_content = sprintf('<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
1426
+        if ( $message ) {
1427
+            $field_content = sprintf( '<div class="ginput_container ginput_container_' . $field->type . '">%s</div>', wpautop( $message ) );
1428 1428
         }
1429 1429
 
1430 1430
         return $field_content;
@@ -1448,8 +1448,8 @@  discard block
 block discarded – undo
1448 1448
 
1449 1449
 		// If the form has been submitted, then we don't need to pre-fill the values,
1450 1450
 		// Except for fileupload type and when a field input is overridden- run always!!
1451
-		if(
1452
-			( $this->is_edit_entry_submission() && !in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
1451
+		if (
1452
+			( $this->is_edit_entry_submission() && ! in_array( $field->type, array( 'fileupload', 'post_image' ) ) )
1453 1453
 			&& false === ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) )
1454 1454
 			&& ! GFCommon::is_product_field( $field->type )
1455 1455
 			|| ! empty( $field_content )
@@ -1469,7 +1469,7 @@  discard block
 block discarded – undo
1469 1469
 	    $return = null;
1470 1470
 
1471 1471
 		/** @var GravityView_Field $gv_field */
1472
-		if( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
1472
+		if ( $gv_field && is_callable( array( $gv_field, 'get_field_input' ) ) ) {
1473 1473
 			$return = $gv_field->get_field_input( $this->form, $field_value, $this->entry, $field );
1474 1474
 		} else {
1475 1475
 	        $return = $field->get_field_input( $this->form, $field_value, $this->entry );
@@ -1478,7 +1478,7 @@  discard block
 block discarded – undo
1478 1478
 	    // If there was output, it's an error
1479 1479
 	    $warnings = ob_get_clean();
1480 1480
 
1481
-	    if( !empty( $warnings ) ) {
1481
+	    if ( ! empty( $warnings ) ) {
1482 1482
 		    gravityview()->log->error( '{warning}', array( 'warning' => $warnings, 'data' => $field_value ) );
1483 1483
 	    }
1484 1484
 
@@ -1503,7 +1503,7 @@  discard block
 block discarded – undo
1503 1503
 		$override_saved_value = apply_filters( 'gravityview/edit_entry/pre_populate/override', false, $field );
1504 1504
 
1505 1505
 		// We're dealing with multiple inputs (e.g. checkbox) but not time or date (as it doesn't store data in input IDs)
1506
-		if( isset( $field->inputs ) && is_array( $field->inputs ) && !in_array( $field->type, array( 'time', 'date' ) ) ) {
1506
+		if ( isset( $field->inputs ) && is_array( $field->inputs ) && ! in_array( $field->type, array( 'time', 'date' ) ) ) {
1507 1507
 
1508 1508
 			$field_value = array();
1509 1509
 
@@ -1512,10 +1512,10 @@  discard block
 block discarded – undo
1512 1512
 
1513 1513
 			foreach ( (array)$field->inputs as $input ) {
1514 1514
 
1515
-				$input_id = strval( $input['id'] );
1515
+				$input_id = strval( $input[ 'id' ] );
1516 1516
 
1517 1517
 				if ( isset( $this->entry[ $input_id ] ) && ! gv_empty( $this->entry[ $input_id ], false, false ) ) {
1518
-				    $field_value[ $input_id ] =  'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1518
+				    $field_value[ $input_id ] = 'post_category' === $field->type ? GFCommon::format_post_category( $this->entry[ $input_id ], true ) : $this->entry[ $input_id ];
1519 1519
 				    $allow_pre_populated = false;
1520 1520
 				}
1521 1521
 
@@ -1523,7 +1523,7 @@  discard block
 block discarded – undo
1523 1523
 
1524 1524
 			$pre_value = $field->get_value_submission( array(), false );
1525 1525
 
1526
-			$field_value = ! $allow_pre_populated && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
1526
+			$field_value = ! $allow_pre_populated && ! ( $override_saved_value && ! gv_empty( $pre_value, false, false ) ) ? $field_value : $pre_value;
1527 1527
 
1528 1528
 		} else {
1529 1529
 
@@ -1534,13 +1534,13 @@  discard block
 block discarded – undo
1534 1534
 
1535 1535
 			// saved field entry value (if empty, fallback to the pre-populated value, if exists)
1536 1536
 			// or pre-populated value if not empty and set to override saved value
1537
-			$field_value = isset( $this->entry[ $id ] ) && ! gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && !gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
1537
+			$field_value = isset( $this->entry[ $id ] ) && ! gv_empty( $this->entry[ $id ], false, false ) && ! ( $override_saved_value && ! gv_empty( $pre_value, false, false ) ) ? $this->entry[ $id ] : $pre_value;
1538 1538
 
1539 1539
 			// in case field is post_category but inputType is select, multi-select or radio, convert value into array of category IDs.
1540
-			if ( 'post_category' === $field->type && !gv_empty( $field_value, false, false ) ) {
1540
+			if ( 'post_category' === $field->type && ! gv_empty( $field_value, false, false ) ) {
1541 1541
 				$categories = array();
1542 1542
 				foreach ( explode( ',', $field_value ) as $cat_string ) {
1543
-				    $categories[] = GFCommon::format_post_category( $cat_string, true );
1543
+				    $categories[ ] = GFCommon::format_post_category( $cat_string, true );
1544 1544
 				}
1545 1545
 				$field_value = 'multiselect' === $field->get_input_type() ? $categories : implode( '', $categories );
1546 1546
 			}
@@ -1568,7 +1568,7 @@  discard block
 block discarded – undo
1568 1568
 	     * @param GF_Field $field Gravity Forms field object
1569 1569
 	     * @param GravityView_Edit_Entry_Render $this Current object
1570 1570
 	     */
1571
-	    $field_value = apply_filters( 'gravityview/edit_entry/field_value_' . $field->type , $field_value, $field, $this );
1571
+	    $field_value = apply_filters( 'gravityview/edit_entry/field_value_' . $field->type, $field_value, $field, $this );
1572 1572
 
1573 1573
 		return $field_value;
1574 1574
 	}
@@ -1585,12 +1585,12 @@  discard block
 block discarded – undo
1585 1585
 	 */
1586 1586
 	public function gform_pre_validation( $form ) {
1587 1587
 
1588
-		if( ! $this->verify_nonce() ) {
1588
+		if ( ! $this->verify_nonce() ) {
1589 1589
 			return $form;
1590 1590
 		}
1591 1591
 
1592 1592
 		// Fix PHP warning regarding undefined index.
1593
-		foreach ( $form['fields'] as &$field) {
1593
+		foreach ( $form[ 'fields' ] as &$field ) {
1594 1594
 
1595 1595
 			// This is because we're doing admin form pretending to be front-end, so Gravity Forms
1596 1596
 			// expects certain field array items to be set.
@@ -1598,7 +1598,7 @@  discard block
 block discarded – undo
1598 1598
 	            $field->{$key} = isset( $field->{$key} ) ? $field->{$key} : NULL;
1599 1599
 			}
1600 1600
 
1601
-			switch( RGFormsModel::get_input_type( $field ) ) {
1601
+			switch ( RGFormsModel::get_input_type( $field ) ) {
1602 1602
 
1603 1603
 				/**
1604 1604
 				 * this whole fileupload hack is because in the admin, Gravity Forms simply doesn't update any fileupload field if it's empty, but it DOES in the frontend.
@@ -1612,26 +1612,26 @@  discard block
 block discarded – undo
1612 1612
 				    // Set the previous value
1613 1613
 				    $entry = $this->get_entry();
1614 1614
 
1615
-				    $input_name = 'input_'.$field->id;
1616
-				    $form_id = $form['id'];
1615
+				    $input_name = 'input_' . $field->id;
1616
+				    $form_id = $form[ 'id' ];
1617 1617
 
1618 1618
 				    $value = NULL;
1619 1619
 
1620 1620
 				    // Use the previous entry value as the default.
1621
-				    if( isset( $entry[ $field->id ] ) ) {
1621
+				    if ( isset( $entry[ $field->id ] ) ) {
1622 1622
 				        $value = $entry[ $field->id ];
1623 1623
 				    }
1624 1624
 
1625 1625
 				    // If this is a single upload file
1626
-				    if( !empty( $_FILES[ $input_name ] ) && !empty( $_FILES[ $input_name ]['name'] ) ) {
1627
-				        $file_path = GFFormsModel::get_file_upload_path( $form['id'], $_FILES[ $input_name ]['name'] );
1628
-				        $value = $file_path['url'];
1626
+				    if ( ! empty( $_FILES[ $input_name ] ) && ! empty( $_FILES[ $input_name ][ 'name' ] ) ) {
1627
+				        $file_path = GFFormsModel::get_file_upload_path( $form[ 'id' ], $_FILES[ $input_name ][ 'name' ] );
1628
+				        $value = $file_path[ 'url' ];
1629 1629
 
1630 1630
 				    } else {
1631 1631
 
1632 1632
 				        // Fix PHP warning on line 1498 of form_display.php for post_image fields
1633 1633
 				        // Fix PHP Notice:  Undefined index:  size in form_display.php on line 1511
1634
-				        $_FILES[ $input_name ] = array('name' => '', 'size' => '' );
1634
+				        $_FILES[ $input_name ] = array( 'name' => '', 'size' => '' );
1635 1635
 
1636 1636
 				    }
1637 1637
 
@@ -1639,10 +1639,10 @@  discard block
 block discarded – undo
1639 1639
 
1640 1640
 				        // If there are fresh uploads, process and merge them.
1641 1641
 				        // Otherwise, use the passed values, which should be json-encoded array of URLs
1642
-				        if( isset( GFFormsModel::$uploaded_files[$form_id][$input_name] ) ) {
1642
+				        if ( isset( GFFormsModel::$uploaded_files[ $form_id ][ $input_name ] ) ) {
1643 1643
 				            $value = empty( $value ) ? '[]' : $value;
1644 1644
 				            $value = stripslashes_deep( $value );
1645
-				            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry['id'], array());
1645
+				            $value = GFFormsModel::prepare_value( $form, $field, $value, $input_name, $entry[ 'id' ], array() );
1646 1646
 				        }
1647 1647
 
1648 1648
 				    } else {
@@ -1660,8 +1660,8 @@  discard block
 block discarded – undo
1660 1660
 
1661 1661
 				case 'number':
1662 1662
 				    // Fix "undefined index" issue at line 1286 in form_display.php
1663
-				    if( !isset( $_POST['input_'.$field->id ] ) ) {
1664
-				        $_POST['input_'.$field->id ] = NULL;
1663
+				    if ( ! isset( $_POST[ 'input_' . $field->id ] ) ) {
1664
+				        $_POST[ 'input_' . $field->id ] = NULL;
1665 1665
 				    }
1666 1666
 				    break;
1667 1667
 			}
@@ -1698,7 +1698,7 @@  discard block
 block discarded – undo
1698 1698
 		 * You can enter whatever you want!
1699 1699
 		 * We try validating, and customize the results using `self::custom_validation()`
1700 1700
 		 */
1701
-		add_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10, 4);
1701
+		add_filter( 'gform_validation_' . $this->form_id, array( $this, 'custom_validation' ), 10, 4 );
1702 1702
 
1703 1703
 		// Needed by the validate funtion
1704 1704
 		$failed_validation_page = NULL;
@@ -1706,14 +1706,14 @@  discard block
 block discarded – undo
1706 1706
 
1707 1707
 		// Prevent entry limit from running when editing an entry, also
1708 1708
 		// prevent form scheduling from preventing editing
1709
-		unset( $this->form['limitEntries'], $this->form['scheduleForm'] );
1709
+		unset( $this->form[ 'limitEntries' ], $this->form[ 'scheduleForm' ] );
1710 1710
 
1711 1711
 		// Hide fields depending on Edit Entry settings
1712
-		$this->form['fields'] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1712
+		$this->form[ 'fields' ] = $this->get_configured_edit_fields( $this->form, $this->view_id );
1713 1713
 
1714 1714
 		$this->is_valid = GFFormDisplay::validate( $this->form, $field_values, 1, $failed_validation_page );
1715 1715
 
1716
-		remove_filter( 'gform_validation_'. $this->form_id, array( $this, 'custom_validation' ), 10 );
1716
+		remove_filter( 'gform_validation_' . $this->form_id, array( $this, 'custom_validation' ), 10 );
1717 1717
 	}
1718 1718
 
1719 1719
 
@@ -1736,7 +1736,7 @@  discard block
 block discarded – undo
1736 1736
 
1737 1737
 		$gv_valid = true;
1738 1738
 
1739
-		foreach ( $validation_results['form']['fields'] as $key => &$field ) {
1739
+		foreach ( $validation_results[ 'form' ][ 'fields' ] as $key => &$field ) {
1740 1740
 
1741 1741
 			$value = RGFormsModel::get_field_value( $field );
1742 1742
 			$field_type = RGFormsModel::get_input_type( $field );
@@ -1749,22 +1749,22 @@  discard block
 block discarded – undo
1749 1749
 				case 'post_image':
1750 1750
 
1751 1751
 				    // in case nothing is uploaded but there are already files saved
1752
-				    if( !empty( $field->failed_validation ) && !empty( $field->isRequired ) && !empty( $value ) ) {
1752
+				    if ( ! empty( $field->failed_validation ) && ! empty( $field->isRequired ) && ! empty( $value ) ) {
1753 1753
 				        $field->failed_validation = false;
1754 1754
 				        unset( $field->validation_message );
1755 1755
 				    }
1756 1756
 
1757 1757
 				    // validate if multi file upload reached max number of files [maxFiles] => 2
1758
-				    if( \GV\Utils::get( $field, 'maxFiles') && \GV\Utils::get( $field, 'multipleFiles') ) {
1758
+				    if ( \GV\Utils::get( $field, 'maxFiles' ) && \GV\Utils::get( $field, 'multipleFiles' ) ) {
1759 1759
 
1760 1760
 				        $input_name = 'input_' . $field->id;
1761 1761
 				        //uploaded
1762
-				        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ][ $input_name ] : array();
1762
+				        $file_names = isset( GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ][ $input_name ] ) ? GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ][ $input_name ] : array();
1763 1763
 
1764 1764
 				        //existent
1765 1765
 				        $entry = $this->get_entry();
1766 1766
 				        $value = NULL;
1767
-				        if( isset( $entry[ $field->id ] ) ) {
1767
+				        if ( isset( $entry[ $field->id ] ) ) {
1768 1768
 				            $value = json_decode( $entry[ $field->id ], true );
1769 1769
 				        }
1770 1770
 
@@ -1772,13 +1772,13 @@  discard block
 block discarded – undo
1772 1772
 				        $count_files = ( is_array( $file_names ) ? count( $file_names ) : 0 ) +
1773 1773
 						               ( is_array( $value ) ? count( $value ) : 0 );
1774 1774
 
1775
-				        if( $count_files > $field->maxFiles ) {
1775
+				        if ( $count_files > $field->maxFiles ) {
1776 1776
 				            $field->validation_message = __( 'Maximum number of files reached', 'gravityview' );
1777 1777
 				            $field->failed_validation = 1;
1778 1778
 				            $gv_valid = false;
1779 1779
 
1780 1780
 				            // in case of error make sure the newest upload files are removed from the upload input
1781
-				            GFFormsModel::$uploaded_files[ $validation_results['form']['id'] ] = null;
1781
+				            GFFormsModel::$uploaded_files[ $validation_results[ 'form' ][ 'id' ] ] = null;
1782 1782
 				        }
1783 1783
 
1784 1784
 				    }
@@ -1789,7 +1789,7 @@  discard block
 block discarded – undo
1789 1789
 			}
1790 1790
 
1791 1791
 			// This field has failed validation.
1792
-			if( !empty( $field->failed_validation ) ) {
1792
+			if ( ! empty( $field->failed_validation ) ) {
1793 1793
 
1794 1794
 				gravityview()->log->debug( 'GravityView_Edit_Entry[custom_validation] Field is invalid.', array( 'data' => array( 'field' => $field, 'value' => $value ) ) );
1795 1795
 
@@ -1807,19 +1807,19 @@  discard block
 block discarded – undo
1807 1807
 				}
1808 1808
 
1809 1809
 				// You can't continue inside a switch, so we do it after.
1810
-				if( empty( $field->failed_validation ) ) {
1810
+				if ( empty( $field->failed_validation ) ) {
1811 1811
 				    continue;
1812 1812
 				}
1813 1813
 
1814 1814
 				// checks if the No Duplicates option is not validating entry against itself, since
1815 1815
 				// we're editing a stored entry, it would also assume it's a duplicate.
1816
-				if( !empty( $field->noDuplicates ) ) {
1816
+				if ( ! empty( $field->noDuplicates ) ) {
1817 1817
 
1818 1818
 				    $entry = $this->get_entry();
1819 1819
 
1820 1820
 				    // If the value of the entry is the same as the stored value
1821 1821
 				    // Then we can assume it's not a duplicate, it's the same.
1822
-				    if( !empty( $entry ) && $value == $entry[ $field->id ] ) {
1822
+				    if ( ! empty( $entry ) && $value == $entry[ $field->id ] ) {
1823 1823
 				        //if value submitted was not changed, then don't validate
1824 1824
 				        $field->failed_validation = false;
1825 1825
 
@@ -1832,7 +1832,7 @@  discard block
 block discarded – undo
1832 1832
 				}
1833 1833
 
1834 1834
 				// if here then probably we are facing the validation 'At least one field must be filled out'
1835
-				if( GFFormDisplay::is_empty( $field, $this->form_id  ) && empty( $field->isRequired ) ) {
1835
+				if ( GFFormDisplay::is_empty( $field, $this->form_id ) && empty( $field->isRequired ) ) {
1836 1836
 				    unset( $field->validation_message );
1837 1837
 	                $field->validation_message = false;
1838 1838
 				    continue;
@@ -1844,12 +1844,12 @@  discard block
 block discarded – undo
1844 1844
 
1845 1845
 		}
1846 1846
 
1847
-		$validation_results['is_valid'] = $gv_valid;
1847
+		$validation_results[ 'is_valid' ] = $gv_valid;
1848 1848
 
1849 1849
 		gravityview()->log->debug( 'GravityView_Edit_Entry[custom_validation] Validation results.', array( 'data' => $validation_results ) );
1850 1850
 
1851 1851
 		// We'll need this result when rendering the form ( on GFFormDisplay::get_form )
1852
-		$this->form_after_validation = $validation_results['form'];
1852
+		$this->form_after_validation = $validation_results[ 'form' ];
1853 1853
 
1854 1854
 		return $validation_results;
1855 1855
 	}
@@ -1862,7 +1862,7 @@  discard block
 block discarded – undo
1862 1862
 	 */
1863 1863
 	public function get_entry() {
1864 1864
 
1865
-		if( empty( $this->entry ) ) {
1865
+		if ( empty( $this->entry ) ) {
1866 1866
 			// Get the database value of the entry that's being edited
1867 1867
 			$this->entry = gravityview_get_entry( GravityView_frontend::is_single_entry() );
1868 1868
 		}
@@ -1894,10 +1894,10 @@  discard block
 block discarded – undo
1894 1894
 		}
1895 1895
 
1896 1896
 		// If edit tab not yet configured, show all fields
1897
-		$edit_fields = !empty( $properties['edit_edit-fields'] ) ? $properties['edit_edit-fields'] : NULL;
1897
+		$edit_fields = ! empty( $properties[ 'edit_edit-fields' ] ) ? $properties[ 'edit_edit-fields' ] : NULL;
1898 1898
 
1899 1899
 		// Hide fields depending on admin settings
1900
-		$fields = $this->filter_fields( $form['fields'], $edit_fields );
1900
+		$fields = $this->filter_fields( $form[ 'fields' ], $edit_fields );
1901 1901
 
1902 1902
 	    // If Edit Entry fields are configured, remove adminOnly field settings. Otherwise, don't.
1903 1903
 	    $fields = $this->filter_admin_only_fields( $fields, $edit_fields, $form, $view_id );
@@ -1930,7 +1930,7 @@  discard block
 block discarded – undo
1930 1930
 	 */
1931 1931
 	private function filter_fields( $fields, $configured_fields ) {
1932 1932
 
1933
-		if( empty( $fields ) || !is_array( $fields ) ) {
1933
+		if ( empty( $fields ) || ! is_array( $fields ) ) {
1934 1934
 			return $fields;
1935 1935
 		}
1936 1936
 
@@ -1947,12 +1947,12 @@  discard block
 block discarded – undo
1947 1947
 
1948 1948
 			// Remove the fields that have calculation properties and keep them to be used later
1949 1949
 			// @since 1.16.2
1950
-			if( $field->has_calculation() ) {
1951
-				$this->fields_with_calculation[] = $field;
1950
+			if ( $field->has_calculation() ) {
1951
+				$this->fields_with_calculation[ ] = $field;
1952 1952
 				// don't remove the calculation fields on form render.
1953 1953
 			}
1954 1954
 
1955
-			if( in_array( $field->type, $field_type_blacklist ) ) {
1955
+			if ( in_array( $field->type, $field_type_blacklist ) ) {
1956 1956
 				unset( $fields[ $key ] );
1957 1957
 			}
1958 1958
 		}
@@ -1970,7 +1970,7 @@  discard block
 block discarded – undo
1970 1970
 					continue; // Same
1971 1971
 				}
1972 1972
 
1973
-				$out_fields[] = $field;
1973
+				$out_fields[ ] = $field;
1974 1974
 			}
1975 1975
 
1976 1976
 			return array_values( $out_fields );
@@ -1981,8 +1981,8 @@  discard block
 block discarded – undo
1981 1981
 
1982 1982
 	        /** @var GF_Field $field */
1983 1983
 	        foreach ( $fields as $field ) {
1984
-				if( intval( $configured_field['id'] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1985
-				    $edit_fields[] = $this->merge_field_properties( $field, $configured_field );
1984
+				if ( intval( $configured_field[ 'id' ] ) === intval( $field->id ) && $this->user_can_edit_field( $configured_field, false ) ) {
1985
+				    $edit_fields[ ] = $this->merge_field_properties( $field, $configured_field );
1986 1986
 				    break;
1987 1987
 				}
1988 1988
 
@@ -2005,14 +2005,14 @@  discard block
 block discarded – undo
2005 2005
 
2006 2006
 		$return_field = $field;
2007 2007
 
2008
-		if( empty( $field_setting['show_label'] ) ) {
2008
+		if ( empty( $field_setting[ 'show_label' ] ) ) {
2009 2009
 			$return_field->label = '';
2010
-		} elseif ( !empty( $field_setting['custom_label'] ) ) {
2011
-			$return_field->label = $field_setting['custom_label'];
2010
+		} elseif ( ! empty( $field_setting[ 'custom_label' ] ) ) {
2011
+			$return_field->label = $field_setting[ 'custom_label' ];
2012 2012
 		}
2013 2013
 
2014
-		if( !empty( $field_setting['custom_class'] ) ) {
2015
-			$return_field->cssClass .= ' '. gravityview_sanitize_html_class( $field_setting['custom_class'] );
2014
+		if ( ! empty( $field_setting[ 'custom_class' ] ) ) {
2015
+			$return_field->cssClass .= ' ' . gravityview_sanitize_html_class( $field_setting[ 'custom_class' ] );
2016 2016
 		}
2017 2017
 
2018 2018
 		/**
@@ -2050,16 +2050,16 @@  discard block
 block discarded – undo
2050 2050
 	     */
2051 2051
 	    $use_gf_adminonly_setting = apply_filters( 'gravityview/edit_entry/use_gf_admin_only_setting', empty( $edit_fields ), $form, $view_id );
2052 2052
 
2053
-	    if( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry['id'] ) ) {
2054
-			foreach( $fields as $k => $field ) {
2055
-				if( $field->adminOnly ) {
2053
+	    if ( $use_gf_adminonly_setting && false === GVCommon::has_cap( 'gravityforms_edit_entries', $this->entry[ 'id' ] ) ) {
2054
+			foreach ( $fields as $k => $field ) {
2055
+				if ( $field->adminOnly ) {
2056 2056
 				    unset( $fields[ $k ] );
2057 2057
 				}
2058 2058
 			}
2059 2059
 			return array_values( $fields );
2060 2060
 		}
2061 2061
 
2062
-	    foreach( $fields as &$field ) {
2062
+	    foreach ( $fields as &$field ) {
2063 2063
 		    $field->adminOnly = false;
2064 2064
 		}
2065 2065
 
@@ -2080,7 +2080,7 @@  discard block
 block discarded – undo
2080 2080
 	 */
2081 2081
 	private function unselect_default_values( $form ) {
2082 2082
 
2083
-	    foreach ( $form['fields'] as &$field ) {
2083
+	    foreach ( $form[ 'fields' ] as &$field ) {
2084 2084
 
2085 2085
 			if ( empty( $field->choices ) ) {
2086 2086
                 continue;
@@ -2088,7 +2088,7 @@  discard block
 block discarded – undo
2088 2088
 
2089 2089
             foreach ( $field->choices as &$choice ) {
2090 2090
 				if ( \GV\Utils::get( $choice, 'isSelected' ) ) {
2091
-					$choice['isSelected'] = false;
2091
+					$choice[ 'isSelected' ] = false;
2092 2092
 				}
2093 2093
 			}
2094 2094
 		}
@@ -2113,22 +2113,22 @@  discard block
 block discarded – undo
2113 2113
 	 */
2114 2114
 	function prefill_conditional_logic( $form ) {
2115 2115
 
2116
-		if( ! GFFormDisplay::has_conditional_logic( $form ) ) {
2116
+		if ( ! GFFormDisplay::has_conditional_logic( $form ) ) {
2117 2117
 			return $form;
2118 2118
 		}
2119 2119
 
2120 2120
 		// Have Conditional Logic pre-fill fields as if the data were default values
2121 2121
 		/** @var GF_Field $field */
2122
-		foreach ( $form['fields'] as &$field ) {
2122
+		foreach ( $form[ 'fields' ] as &$field ) {
2123 2123
 
2124
-			if( 'checkbox' === $field->type ) {
2124
+			if ( 'checkbox' === $field->type ) {
2125 2125
 				foreach ( $field->get_entry_inputs() as $key => $input ) {
2126
-				    $input_id = $input['id'];
2126
+				    $input_id = $input[ 'id' ];
2127 2127
 				    $choice = $field->choices[ $key ];
2128 2128
 				    $value = \GV\Utils::get( $this->entry, $input_id );
2129 2129
 				    $match = RGFormsModel::choice_value_match( $field, $choice, $value );
2130
-				    if( $match ) {
2131
-				        $field->choices[ $key ]['isSelected'] = true;
2130
+				    if ( $match ) {
2131
+				        $field->choices[ $key ][ 'isSelected' ] = true;
2132 2132
 				    }
2133 2133
 				}
2134 2134
 			} else {
@@ -2136,15 +2136,15 @@  discard block
 block discarded – undo
2136 2136
 				// We need to run through each field to set the default values
2137 2137
 				foreach ( $this->entry as $field_id => $field_value ) {
2138 2138
 
2139
-				    if( floatval( $field_id ) === floatval( $field->id ) ) {
2139
+				    if ( floatval( $field_id ) === floatval( $field->id ) ) {
2140 2140
 
2141
-				        if( 'list' === $field->type ) {
2141
+				        if ( 'list' === $field->type ) {
2142 2142
 				            $list_rows = maybe_unserialize( $field_value );
2143 2143
 
2144 2144
 				            $list_field_value = array();
2145
-				            foreach ( (array) $list_rows as $row ) {
2146
-				                foreach ( (array) $row as $column ) {
2147
-				                    $list_field_value[] = $column;
2145
+				            foreach ( (array)$list_rows as $row ) {
2146
+				                foreach ( (array)$row as $column ) {
2147
+				                    $list_field_value[ ] = $column;
2148 2148
 				                }
2149 2149
 				            }
2150 2150
 
@@ -2177,32 +2177,32 @@  discard block
 block discarded – undo
2177 2177
 		 * @see https://github.com/gravityview/GravityView/issues/840
2178 2178
 		 * @since develop
2179 2179
 		 */
2180
-		$the_form = GFAPI::get_form( $form['id'] );
2180
+		$the_form = GFAPI::get_form( $form[ 'id' ] );
2181 2181
 		$editable_ids = array();
2182
-		foreach ( $form['fields'] as $field ) {
2183
-			$editable_ids[] = $field['id']; // wp_list_pluck is destructive in this context
2182
+		foreach ( $form[ 'fields' ] as $field ) {
2183
+			$editable_ids[ ] = $field[ 'id' ]; // wp_list_pluck is destructive in this context
2184 2184
 		}
2185 2185
 		$remove_conditions_rule = array();
2186
-		foreach ( $the_form['fields'] as $field ) {
2187
-			if ( ! empty( $field->conditionalLogic ) && ! empty( $field->conditionalLogic['rules'] ) ) {
2188
-				foreach ( $field->conditionalLogic['rules'] as $i => $rule ) {
2189
-					if ( ! in_array( $rule['fieldId'], $editable_ids ) ) {
2186
+		foreach ( $the_form[ 'fields' ] as $field ) {
2187
+			if ( ! empty( $field->conditionalLogic ) && ! empty( $field->conditionalLogic[ 'rules' ] ) ) {
2188
+				foreach ( $field->conditionalLogic[ 'rules' ] as $i => $rule ) {
2189
+					if ( ! in_array( $rule[ 'fieldId' ], $editable_ids ) ) {
2190 2190
 						/**
2191 2191
 						 * This conditional field is not editable in this View.
2192 2192
 						 * We need to remove the rule, but only if it matches.
2193 2193
 						 */
2194
-						if ( $_field = GFAPI::get_field( $the_form, $rule['fieldId'] ) ) {
2194
+						if ( $_field = GFAPI::get_field( $the_form, $rule[ 'fieldId' ] ) ) {
2195 2195
 							$value = $_field->get_value_export( $this->entry );
2196
-						} elseif ( isset( $this->entry[ $rule['fieldId'] ] ) ) {
2197
-							$value = $this->entry[ $rule['fieldId'] ];
2196
+						} elseif ( isset( $this->entry[ $rule[ 'fieldId' ] ] ) ) {
2197
+							$value = $this->entry[ $rule[ 'fieldId' ] ];
2198 2198
 						} else {
2199
-							$value = gform_get_meta( $this->entry['id'], $rule['fieldId'] );
2199
+							$value = gform_get_meta( $this->entry[ 'id' ], $rule[ 'fieldId' ] );
2200 2200
 						}
2201 2201
 
2202
-						$match = GFFormsModel::matches_operation( $value, $rule['value'], $rule['operator'] );
2202
+						$match = GFFormsModel::matches_operation( $value, $rule[ 'value' ], $rule[ 'operator' ] );
2203 2203
 
2204 2204
 						if ( $match ) {
2205
-							$remove_conditions_rule[] = array( $field['id'], $i );
2205
+							$remove_conditions_rule[ ] = array( $field[ 'id' ], $i );
2206 2206
 						}
2207 2207
 					}
2208 2208
 				}
@@ -2210,21 +2210,21 @@  discard block
 block discarded – undo
2210 2210
 		}
2211 2211
 
2212 2212
 		if ( $remove_conditions_rule ) {
2213
-			foreach ( $form['fields'] as &$field ) {
2213
+			foreach ( $form[ 'fields' ] as &$field ) {
2214 2214
 				foreach ( $remove_conditions_rule as $_remove_conditions_r ) {
2215 2215
 
2216 2216
 				    list( $rule_field_id, $rule_i ) = $_remove_conditions_r;
2217 2217
 
2218
-					if ( $field['id'] == $rule_field_id ) {
2219
-						unset( $field->conditionalLogic['rules'][ $rule_i ] );
2220
-						gravityview()->log->debug( 'Removed conditional rule #{rule} for field {field_id}', array( 'rule' => $rule_i, 'field_id' => $field['id'] ) );
2218
+					if ( $field[ 'id' ] == $rule_field_id ) {
2219
+						unset( $field->conditionalLogic[ 'rules' ][ $rule_i ] );
2220
+						gravityview()->log->debug( 'Removed conditional rule #{rule} for field {field_id}', array( 'rule' => $rule_i, 'field_id' => $field[ 'id' ] ) );
2221 2221
 					}
2222 2222
 				}
2223 2223
 			}
2224 2224
 		}
2225 2225
 
2226 2226
 		/** Normalize the indices... */
2227
-		$form['fields'] = array_values( $form['fields'] );
2227
+		$form[ 'fields' ] = array_values( $form[ 'fields' ] );
2228 2228
 
2229 2229
 		/**
2230 2230
 		 * @filter `gravityview/edit_entry/conditional_logic` Should the Edit Entry form use Gravity Forms conditional logic showing/hiding of fields?
@@ -2234,16 +2234,16 @@  discard block
 block discarded – undo
2234 2234
 		 */
2235 2235
 		$use_conditional_logic = apply_filters( 'gravityview/edit_entry/conditional_logic', true, $form );
2236 2236
 
2237
-		if( $use_conditional_logic ) {
2237
+		if ( $use_conditional_logic ) {
2238 2238
 			return $form;
2239 2239
 		}
2240 2240
 
2241
-		foreach( $form['fields'] as &$field ) {
2241
+		foreach ( $form[ 'fields' ] as &$field ) {
2242 2242
 			/* @var GF_Field $field */
2243 2243
 			$field->conditionalLogic = null;
2244 2244
 		}
2245 2245
 
2246
-		unset( $form['button']['conditionalLogic'] );
2246
+		unset( $form[ 'button' ][ 'conditionalLogic' ] );
2247 2247
 
2248 2248
 		return $form;
2249 2249
 
@@ -2260,7 +2260,7 @@  discard block
 block discarded – undo
2260 2260
 	 */
2261 2261
 	public function manage_conditional_logic( $has_conditional_logic, $form ) {
2262 2262
 
2263
-		if( ! $this->is_edit_entry() ) {
2263
+		if ( ! $this->is_edit_entry() ) {
2264 2264
 			return $has_conditional_logic;
2265 2265
 		}
2266 2266
 
@@ -2292,44 +2292,44 @@  discard block
 block discarded – undo
2292 2292
 		 *  2. There are two entries embedded using oEmbed
2293 2293
 		 *  3. One of the entries has just been saved
2294 2294
 		 */
2295
-		if( !empty( $_POST['lid'] ) && !empty( $_GET['entry'] ) && ( $_POST['lid'] !== $_GET['entry'] ) ) {
2295
+		if ( ! empty( $_POST[ 'lid' ] ) && ! empty( $_GET[ 'entry' ] ) && ( $_POST[ 'lid' ] !== $_GET[ 'entry' ] ) ) {
2296 2296
 
2297 2297
 			$error = true;
2298 2298
 
2299 2299
 		}
2300 2300
 
2301
-		if( !empty( $_GET['entry'] ) && (string)$this->entry['id'] !== $_GET['entry'] ) {
2301
+		if ( ! empty( $_GET[ 'entry' ] ) && (string)$this->entry[ 'id' ] !== $_GET[ 'entry' ] ) {
2302 2302
 
2303 2303
 			$error = true;
2304 2304
 
2305
-		} elseif( ! $this->verify_nonce() ) {
2305
+		} elseif ( ! $this->verify_nonce() ) {
2306 2306
 
2307 2307
 			/**
2308 2308
 			 * If the Entry is embedded, there may be two entries on the same page.
2309 2309
 			 * If that's the case, and one is being edited, the other should fail gracefully and not display an error.
2310 2310
 			 */
2311
-			if( GravityView_oEmbed::getInstance()->get_entry_id() ) {
2311
+			if ( GravityView_oEmbed::getInstance()->get_entry_id() ) {
2312 2312
 				$error = true;
2313 2313
 			} else {
2314
-				$error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview');
2314
+				$error = __( 'The link to edit this entry is not valid; it may have expired.', 'gravityview' );
2315 2315
 			}
2316 2316
 
2317 2317
 		}
2318 2318
 
2319
-		if( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
2320
-			$error = __( 'You do not have permission to edit this entry.', 'gravityview');
2319
+		if ( ! GravityView_Edit_Entry::check_user_cap_edit_entry( $this->entry ) ) {
2320
+			$error = __( 'You do not have permission to edit this entry.', 'gravityview' );
2321 2321
 		}
2322 2322
 
2323
-		if( $this->entry['status'] === 'trash' ) {
2324
-			$error = __('You cannot edit the entry; it is in the trash.', 'gravityview' );
2323
+		if ( $this->entry[ 'status' ] === 'trash' ) {
2324
+			$error = __( 'You cannot edit the entry; it is in the trash.', 'gravityview' );
2325 2325
 		}
2326 2326
 
2327 2327
 		// No errors; everything's fine here!
2328
-		if( empty( $error ) ) {
2328
+		if ( empty( $error ) ) {
2329 2329
 			return true;
2330 2330
 		}
2331 2331
 
2332
-		if( $echo && $error !== true ) {
2332
+		if ( $echo && $error !== true ) {
2333 2333
 
2334 2334
 	        $error = esc_html( $error );
2335 2335
 
@@ -2337,10 +2337,10 @@  discard block
 block discarded – undo
2337 2337
 	         * @since 1.9
2338 2338
 	         */
2339 2339
 	        if ( ! empty( $this->entry ) ) {
2340
-		        $error .= ' ' . gravityview_get_link( '#', _x('Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
2340
+		        $error .= ' ' . gravityview_get_link( '#', _x( 'Go back.', 'Link shown when invalid Edit Entry link is clicked', 'gravityview' ), array( 'onclick' => "window.history.go(-1); return false;" ) );
2341 2341
 	        }
2342 2342
 
2343
-			echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error');
2343
+			echo GVCommon::generate_notice( wpautop( $error ), 'gv-error error' );
2344 2344
 		}
2345 2345
 
2346 2346
 		gravityview()->log->error( '{error}', array( 'error' => $error ) );
@@ -2360,17 +2360,17 @@  discard block
 block discarded – undo
2360 2360
 
2361 2361
 		$error = NULL;
2362 2362
 
2363
-		if( ! $this->check_user_cap_edit_field( $field ) ) {
2364
-			$error = __( 'You do not have permission to edit this field.', 'gravityview');
2363
+		if ( ! $this->check_user_cap_edit_field( $field ) ) {
2364
+			$error = __( 'You do not have permission to edit this field.', 'gravityview' );
2365 2365
 		}
2366 2366
 
2367 2367
 		// No errors; everything's fine here!
2368
-		if( empty( $error ) ) {
2368
+		if ( empty( $error ) ) {
2369 2369
 			return true;
2370 2370
 		}
2371 2371
 
2372
-		if( $echo ) {
2373
-			echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error');
2372
+		if ( $echo ) {
2373
+			echo GVCommon::generate_notice( wpautop( esc_html( $error ) ), 'gv-error error' );
2374 2374
 		}
2375 2375
 
2376 2376
 		gravityview()->log->error( '{error}', array( 'error' => $error ) );
@@ -2391,14 +2391,14 @@  discard block
 block discarded – undo
2391 2391
 	private function check_user_cap_edit_field( $field ) {
2392 2392
 
2393 2393
 		// If they can edit any entries (as defined in Gravity Forms), we're good.
2394
-		if( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
2394
+		if ( GVCommon::has_cap( array( 'gravityforms_edit_entries', 'gravityview_edit_others_entries' ) ) ) {
2395 2395
 			return true;
2396 2396
 		}
2397 2397
 
2398
-		$field_cap = isset( $field['allow_edit_cap'] ) ? $field['allow_edit_cap'] : false;
2398
+		$field_cap = isset( $field[ 'allow_edit_cap' ] ) ? $field[ 'allow_edit_cap' ] : false;
2399 2399
 
2400
-		if( $field_cap ) {
2401
-			return GVCommon::has_cap( $field['allow_edit_cap'] );
2400
+		if ( $field_cap ) {
2401
+			return GVCommon::has_cap( $field[ 'allow_edit_cap' ] );
2402 2402
 		}
2403 2403
 
2404 2404
 		return false;
@@ -2412,17 +2412,17 @@  discard block
 block discarded – undo
2412 2412
 	public function verify_nonce() {
2413 2413
 
2414 2414
 		// Verify form submitted for editing single
2415
-		if( $this->is_edit_entry_submission() ) {
2415
+		if ( $this->is_edit_entry_submission() ) {
2416 2416
 			$valid = wp_verify_nonce( $_POST[ self::$nonce_field ], self::$nonce_field );
2417 2417
 		}
2418 2418
 
2419 2419
 		// Verify
2420
-		else if( ! $this->is_edit_entry() ) {
2420
+		else if ( ! $this->is_edit_entry() ) {
2421 2421
 			$valid = false;
2422 2422
 		}
2423 2423
 
2424 2424
 		else {
2425
-			$valid = wp_verify_nonce( $_GET['edit'], self::$nonce_key );
2425
+			$valid = wp_verify_nonce( $_GET[ 'edit' ], self::$nonce_key );
2426 2426
 		}
2427 2427
 
2428 2428
 		/**
Please login to merge, or discard this patch.