@@ -84,6 +84,7 @@ discard block  | 
                                                    ||
| 84 | 84 | /**  | 
                                                        
| 85 | 85 | * Return the query class for this View.  | 
                                                        
| 86 | 86 | *  | 
                                                        
| 87 | + * @param View $view  | 
                                                        |
| 87 | 88 | * @return string The class name.  | 
                                                        
| 88 | 89 | */  | 
                                                        
| 89 | 90 |  	public function get_query_class( $view ) { | 
                                                        
@@ -575,10 +576,8 @@ discard block  | 
                                                    ||
| 575 | 576 | /**  | 
                                                        
| 576 | 577 | * Get a \GV\Field by Form and Field ID for this data source.  | 
                                                        
| 577 | 578 | *  | 
                                                        
| 578 | - * @param \GV\GF_Form $form The Gravity Form form ID.  | 
                                                        |
| 579 | - * @param int $field_id The Gravity Form field ID for the $form_id.  | 
                                                        |
| 580 | 579 | *  | 
                                                        
| 581 | - * @return \GV\Field|null The requested field or null if not found.  | 
                                                        |
| 580 | + * @return null|GF_Field The requested field or null if not found.  | 
                                                        |
| 582 | 581 | */  | 
                                                        
| 583 | 582 |  	public static function get_field( /** varargs */ ) { | 
                                                        
| 584 | 583 | $args = func_get_args();  | 
                                                        
@@ -55,7 +55,7 @@ discard block  | 
                                                    ||
| 55 | 55 | $self = new self();  | 
                                                        
| 56 | 56 | $self->form = $form;  | 
                                                        
| 57 | 57 | |
| 58 | - $self->ID = intval( $self->form['id'] );  | 
                                                        |
| 58 | + $self->ID = intval( $self->form[ 'id' ] );  | 
                                                        |
| 59 | 59 | |
| 60 | 60 | return $self;  | 
                                                        
| 61 | 61 | }  | 
                                                        
@@ -70,13 +70,13 @@ discard block  | 
                                                    ||
| 70 | 70 | * @return \GV\GF_Form|null An instance of this form or null if not found.  | 
                                                        
| 71 | 71 | */  | 
                                                        
| 72 | 72 |  	public static function from_form( $form ) { | 
                                                        
| 73 | -		if ( empty( $form['id'] ) ) { | 
                                                        |
| 73 | +		if ( empty( $form[ 'id' ] ) ) { | 
                                                        |
| 74 | 74 | return null;  | 
                                                        
| 75 | 75 | }  | 
                                                        
| 76 | 76 | |
| 77 | 77 | $self = new self();  | 
                                                        
| 78 | 78 | $self->form = $form;  | 
                                                        
| 79 | - $self->ID = $self->form['id'];  | 
                                                        |
| 79 | + $self->ID = $self->form[ 'id' ];  | 
                                                        |
| 80 | 80 | |
| 81 | 81 | return $self;  | 
                                                        
| 82 | 82 | }  | 
                                                        
@@ -138,11 +138,11 @@ discard block  | 
                                                    ||
| 138 | 138 | |
| 139 | 139 | /** The offset and limit */  | 
                                                        
| 140 | 140 |  				if ( ! empty( $offset->limit ) ) { | 
                                                        
| 141 | - $paging['page_size'] = $offset->limit;  | 
                                                        |
| 141 | + $paging[ 'page_size' ] = $offset->limit;  | 
                                                        |
| 142 | 142 | }  | 
                                                        
| 143 | 143 | |
| 144 | 144 |  				if ( ! empty( $offset->offset ) ) { | 
                                                        
| 145 | - $paging['offset'] = $offset->offset;  | 
                                                        |
| 145 | + $paging[ 'offset' ] = $offset->offset;  | 
                                                        |
| 146 | 146 | }  | 
                                                        
| 147 | 147 | |
| 148 | 148 | $query_class = $form->get_query_class( $view );  | 
                                                        
@@ -157,15 +157,15 @@ discard block  | 
                                                    ||
| 157 | 157 | $view_setting_sort_field_ids = \GV\Utils::get( $atts, 'sort_field', array() );  | 
                                                        
| 158 | 158 | $view_setting_sort_directions = \GV\Utils::get( $atts, 'sort_direction', array() );  | 
                                                        
| 159 | 159 | |
| 160 | - $has_sort_query_param = ! empty( $_GET['sort'] ) && is_array( $_GET['sort'] );  | 
                                                        |
| 160 | + $has_sort_query_param = ! empty( $_GET[ 'sort' ] ) && is_array( $_GET[ 'sort' ] );  | 
                                                        |
| 161 | 161 | |
| 162 | -					if( $has_sort_query_param ) { | 
                                                        |
| 163 | - $has_sort_query_param = array_filter( array_values( $_GET['sort'] ) );  | 
                                                        |
| 162 | +					if ( $has_sort_query_param ) { | 
                                                        |
| 163 | + $has_sort_query_param = array_filter( array_values( $_GET[ 'sort' ] ) );  | 
                                                        |
| 164 | 164 | }  | 
                                                        
| 165 | 165 | |
| 166 | 166 |  					if ( $view->settings->get( 'sort_columns' ) && $has_sort_query_param ) { | 
                                                        
| 167 | - $sort_field_ids = array_keys( $_GET['sort'] );  | 
                                                        |
| 168 | - $sort_directions = array_values( $_GET['sort'] );  | 
                                                        |
| 167 | + $sort_field_ids = array_keys( $_GET[ 'sort' ] );  | 
                                                        |
| 168 | + $sort_directions = array_values( $_GET[ 'sort' ] );  | 
                                                        |
| 169 | 169 |  					} else { | 
                                                        
| 170 | 170 | $sort_field_ids = $view_setting_sort_field_ids;  | 
                                                        
| 171 | 171 | $sort_directions = $view_setting_sort_directions;  | 
                                                        
@@ -173,7 +173,7 @@ discard block  | 
                                                    ||
| 173 | 173 | |
| 174 | 174 | $skip_first = false;  | 
                                                        
| 175 | 175 | |
| 176 | -					foreach ( (array) $sort_field_ids as $key => $sort_field_id ) { | 
                                                        |
| 176 | +					foreach ( (array)$sort_field_ids as $key => $sort_field_id ) { | 
                                                        |
| 177 | 177 | |
| 178 | 178 |  						if ( ! $skip_first && ! $has_sort_query_param ) { | 
                                                        
| 179 | 179 | $skip_first = true; // Skip the first one, it's already in the query  | 
                                                        
@@ -203,15 +203,15 @@ discard block  | 
                                                    ||
| 203 | 203 | |
| 204 | 204 | $merged_time = false;  | 
                                                        
| 205 | 205 | |
| 206 | -					foreach ( $q['order'] as $oid => $order ) { | 
                                                        |
| 207 | -						if ( $order[0] instanceof \GF_Query_Column ) { | 
                                                        |
| 208 | - $column = $order[0];  | 
                                                        |
| 209 | -						} else if ( $order[0] instanceof \GF_Query_Call ) { | 
                                                        |
| 210 | -							if ( count( $order[0]->columns ) != 1 || ! $order[0]->columns[0] instanceof \GF_Query_Column ) { | 
                                                        |
| 206 | +					foreach ( $q[ 'order' ] as $oid => $order ) { | 
                                                        |
| 207 | +						if ( $order[ 0 ] instanceof \GF_Query_Column ) { | 
                                                        |
| 208 | + $column = $order[ 0 ];  | 
                                                        |
| 209 | +						} else if ( $order[ 0 ] instanceof \GF_Query_Call ) { | 
                                                        |
| 210 | +							if ( count( $order[ 0 ]->columns ) != 1 || ! $order[ 0 ]->columns[ 0 ] instanceof \GF_Query_Column ) { | 
                                                        |
| 211 | 211 | $orders[ $oid ] = $order;  | 
                                                        
| 212 | 212 | continue; // Need something that resembles a single sort  | 
                                                        
| 213 | 213 | }  | 
                                                        
| 214 | - $column = $order[0]->columns[0];  | 
                                                        |
| 214 | + $column = $order[ 0 ]->columns[ 0 ];  | 
                                                        |
| 215 | 215 | }  | 
                                                        
| 216 | 216 | |
| 217 | 217 |  						if ( ( ! $field = \GFAPI::get_field( $column->source, $column->field_id ) ) || $field->type !== 'time' ) { | 
                                                        
@@ -225,7 +225,7 @@ discard block  | 
                                                    ||
| 225 | 225 | |
| 226 | 226 | $orders[ $oid ] = array(  | 
                                                        
| 227 | 227 | new \GV\Mocks\GF_Query_Call_TIMESORT( 'timesort', array( $column, $sql ) ),  | 
                                                        
| 228 | - $order[1] // Mock it!  | 
                                                        |
| 228 | + $order[ 1 ] // Mock it!  | 
                                                        |
| 229 | 229 | );  | 
                                                        
| 230 | 230 | |
| 231 | 231 | $merged_time = true;  | 
                                                        
@@ -236,7 +236,7 @@ discard block  | 
                                                    ||
| 236 | 236 | * ORDER again.  | 
                                                        
| 237 | 237 | */  | 
                                                        
| 238 | 238 |  						if ( ! empty( $orders ) && $_orders = $query->_order_generate( $orders ) ) { | 
                                                        
| 239 | - $sql['order'] = 'ORDER BY ' . implode( ', ', $_orders );  | 
                                                        |
| 239 | + $sql[ 'order' ] = 'ORDER BY ' . implode( ', ', $_orders );  | 
                                                        |
| 240 | 240 | }  | 
                                                        
| 241 | 241 | }  | 
                                                        
| 242 | 242 | |
@@ -264,7 +264,7 @@ discard block  | 
                                                    ||
| 264 | 264 | |
| 265 | 265 | $query_parameters = $query->_introspect();  | 
                                                        
| 266 | 266 | |
| 267 | - $query->where( \GF_Query_Condition::_and( $query_parameters['where'], $condition ) );  | 
                                                        |
| 267 | + $query->where( \GF_Query_Condition::_and( $query_parameters[ 'where' ], $condition ) );  | 
                                                        |
| 268 | 268 | }  | 
                                                        
| 269 | 269 | |
| 270 | 270 | /**  | 
                                                        
@@ -298,7 +298,7 @@ discard block  | 
                                                    ||
| 298 | 298 | }  | 
                                                        
| 299 | 299 | |
| 300 | 300 | $q = $query->_introspect();  | 
                                                        
| 301 | - $query->where( \GF_Query_Condition::_and( $q['where'], $condition ) );  | 
                                                        |
| 301 | + $query->where( \GF_Query_Condition::_and( $q[ 'where' ], $condition ) );  | 
                                                        |
| 302 | 302 | |
| 303 | 303 |  						if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) { | 
                                                        
| 304 | 304 | |
@@ -323,7 +323,7 @@ discard block  | 
                                                    ||
| 323 | 323 | |
| 324 | 324 | $query_parameters = $query->_introspect();  | 
                                                        
| 325 | 325 | |
| 326 | - $query->where( \GF_Query_Condition::_and( $query_parameters['where'], $condition ) );  | 
                                                        |
| 326 | + $query->where( \GF_Query_Condition::_and( $query_parameters[ 'where' ], $condition ) );  | 
                                                        |
| 327 | 327 | }  | 
                                                        
| 328 | 328 | }  | 
                                                        
| 329 | 329 | /**  | 
                                                        
@@ -346,7 +346,7 @@ discard block  | 
                                                    ||
| 346 | 346 | $conditions = array();  | 
                                                        
| 347 | 347 | |
| 348 | 348 |  							foreach ( $condition->expressions as $_condition ) { | 
                                                        
| 349 | - $conditions[] = $recurse( $_condition, $fields, $recurse );  | 
                                                        |
| 349 | + $conditions[ ] = $recurse( $_condition, $fields, $recurse );  | 
                                                        |
| 350 | 350 | }  | 
                                                        
| 351 | 351 | |
| 352 | 352 | return call_user_func_array(  | 
                                                        
@@ -374,10 +374,10 @@ discard block  | 
                                                    ||
| 374 | 374 | $q = new $query_class( $form_id );  | 
                                                        
| 375 | 375 | |
| 376 | 376 | // Copy the WHERE clauses but substitute the field_ids to the respective ones  | 
                                                        
| 377 | - $q->where( $where_union_substitute( $query_parameters['where'], $fields, $where_union_substitute ) );  | 
                                                        |
| 377 | + $q->where( $where_union_substitute( $query_parameters[ 'where' ], $fields, $where_union_substitute ) );  | 
                                                        |
| 378 | 378 | |
| 379 | 379 | // Copy the ORDER clause and substitute the field_ids to the respective ones  | 
                                                        
| 380 | -						foreach ( $query_parameters['order'] as $order ) { | 
                                                        |
| 380 | +						foreach ( $query_parameters[ 'order' ] as $order ) { | 
                                                        |
| 381 | 381 | list( $column, $_order ) = $order;  | 
                                                        
| 382 | 382 | |
| 383 | 383 |  							if ( $column && $column instanceof \GF_Query_Column ) { | 
                                                        
@@ -391,15 +391,15 @@ discard block  | 
                                                    ||
| 391 | 391 | |
| 392 | 392 |  						add_filter( 'gform_gf_query_sql', $gf_query_sql_callback = function( $sql ) use ( &$unions_sql ) { | 
                                                        
| 393 | 393 | // Remove SQL_CALC_FOUND_ROWS as it's not needed in UNION clauses  | 
                                                        
| 394 | - $select = 'UNION ALL ' . str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql['select'] );  | 
                                                        |
| 394 | + $select = 'UNION ALL ' . str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql[ 'select' ] );  | 
                                                        |
| 395 | 395 | |
| 396 | 396 | // Record the SQL  | 
                                                        
| 397 | - $unions_sql[] = array(  | 
                                                        |
| 397 | + $unions_sql[ ] = array(  | 
                                                        |
| 398 | 398 | // Remove columns, we'll rebuild them  | 
                                                        
| 399 | 399 | 'select' => preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $select ),  | 
                                                        
| 400 | - 'from' => $sql['from'],  | 
                                                        |
| 401 | - 'join' => $sql['join'],  | 
                                                        |
| 402 | - 'where' => $sql['where'],  | 
                                                        |
| 400 | + 'from' => $sql[ 'from' ],  | 
                                                        |
| 401 | + 'join' => $sql[ 'join' ],  | 
                                                        |
| 402 | + 'where' => $sql[ 'where' ],  | 
                                                        |
| 403 | 403 | // Remove order and limit  | 
                                                        
| 404 | 404 | );  | 
                                                        
| 405 | 405 | |
@@ -416,11 +416,11 @@ discard block  | 
                                                    ||
| 416 | 416 | |
| 417 | 417 |  					add_filter( 'gform_gf_query_sql', $gf_query_sql_callback = function( $sql ) use ( $unions_sql ) { | 
                                                        
| 418 | 418 | // Remove SQL_CALC_FOUND_ROWS as it's not needed in UNION clauses  | 
                                                        
| 419 | - $sql['select'] = str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql['select'] );  | 
                                                        |
| 419 | + $sql[ 'select' ] = str_replace( 'SQL_CALC_FOUND_ROWS ', '', $sql[ 'select' ] );  | 
                                                        |
| 420 | 420 | |
| 421 | 421 | // Remove columns, we'll rebuild them  | 
                                                        
| 422 | - preg_match( '#DISTINCT (`[motc]\d+`.`.*?`)#', $sql['select'], $select_match );  | 
                                                        |
| 423 | - $sql['select'] = preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $sql['select'] );  | 
                                                        |
| 422 | + preg_match( '#DISTINCT (`[motc]\d+`.`.*?`)#', $sql[ 'select' ], $select_match );  | 
                                                        |
| 423 | + $sql[ 'select' ] = preg_replace( '#DISTINCT (.*)#', 'DISTINCT ', $sql[ 'select' ] );  | 
                                                        |
| 424 | 424 | |
| 425 | 425 | $unions = array();  | 
                                                        
| 426 | 426 | |
@@ -431,30 +431,30 @@ discard block  | 
                                                    ||
| 431 | 431 | };  | 
                                                        
| 432 | 432 | |
| 433 | 433 | // Add all the order columns into the selects, so we can order by the whole union group  | 
                                                        
| 434 | - preg_match_all( '#(`[motc]\d+`.`.*?`)#', $sql['order'], $order_matches );  | 
                                                        |
| 434 | + preg_match_all( '#(`[motc]\d+`.`.*?`)#', $sql[ 'order' ], $order_matches );  | 
                                                        |
| 435 | 435 | |
| 436 | 436 | $columns = array(  | 
                                                        
| 437 | - sprintf( '%s AS %s', $select_match[1], $column_to_alias( $select_match[1] ) )  | 
                                                        |
| 437 | + sprintf( '%s AS %s', $select_match[ 1 ], $column_to_alias( $select_match[ 1 ] ) )  | 
                                                        |
| 438 | 438 | );  | 
                                                        
| 439 | 439 | |
| 440 | 440 |  						foreach ( array_slice( $order_matches, 1 ) as $match ) { | 
                                                        
| 441 | - $columns[] = sprintf( '%s AS %s', $match[0], $column_to_alias( $match[0] ) );  | 
                                                        |
| 441 | + $columns[ ] = sprintf( '%s AS %s', $match[ 0 ], $column_to_alias( $match[ 0 ] ) );  | 
                                                        |
| 442 | 442 | |
| 443 | 443 | // Rewrite the order columns to the shared aliases  | 
                                                        
| 444 | - $sql['order'] = str_replace( $match[0], $column_to_alias( $match[0] ), $sql['order'] );  | 
                                                        |
| 444 | + $sql[ 'order' ] = str_replace( $match[ 0 ], $column_to_alias( $match[ 0 ] ), $sql[ 'order' ] );  | 
                                                        |
| 445 | 445 | }  | 
                                                        
| 446 | 446 | |
| 447 | 447 | $columns = array_unique( $columns );  | 
                                                        
| 448 | 448 | |
| 449 | 449 | // Add the columns to every UNION  | 
                                                        
| 450 | 450 |  						foreach ( $unions_sql as $union_sql ) { | 
                                                        
| 451 | - $union_sql['select'] .= implode( ', ', $columns );  | 
                                                        |
| 452 | - $unions []= implode( ' ', $union_sql );  | 
                                                        |
| 451 | + $union_sql[ 'select' ] .= implode( ', ', $columns );  | 
                                                        |
| 452 | + $unions [ ] = implode( ' ', $union_sql );  | 
                                                        |
| 453 | 453 | }  | 
                                                        
| 454 | 454 | |
| 455 | 455 | // Add the columns to the main SELECT, but only grab the entry id column  | 
                                                        
| 456 | -						$sql['select'] = 'SELECT SQL_CALC_FOUND_ROWS t1_id FROM (' . $sql['select'] . implode( ', ', $columns ); | 
                                                        |
| 457 | - $sql['order'] = implode( ' ', $unions ) . ') AS u ' . $sql['order'];  | 
                                                        |
| 456 | +						$sql[ 'select' ] = 'SELECT SQL_CALC_FOUND_ROWS t1_id FROM (' . $sql[ 'select' ] . implode( ', ', $columns ); | 
                                                        |
| 457 | + $sql[ 'order' ] = implode( ' ', $unions ) . ') AS u ' . $sql[ 'order' ];  | 
                                                        |
| 458 | 458 | |
| 459 | 459 | return $sql;  | 
                                                        
| 460 | 460 | } );  | 
                                                        
@@ -540,11 +540,11 @@ discard block  | 
                                                    ||
| 540 | 540 | |
| 541 | 541 | /** The offset and limit */  | 
                                                        
| 542 | 542 |  				if ( ! empty( $offset->limit ) ) { | 
                                                        
| 543 | - $paging['page_size'] = $offset->limit;  | 
                                                        |
| 543 | + $paging[ 'page_size' ] = $offset->limit;  | 
                                                        |
| 544 | 544 | }  | 
                                                        
| 545 | 545 | |
| 546 | 546 |  				if ( ! empty( $offset->offset ) ) { | 
                                                        
| 547 | - $paging['offset'] = $offset->offset;  | 
                                                        |
| 547 | + $paging[ 'offset' ] = $offset->offset;  | 
                                                        |
| 548 | 548 | }  | 
                                                        
| 549 | 549 | |
| 550 | 550 |  				foreach ( \GFAPI::get_entries( $form->ID, $search_criteria, $sorting, $paging ) as $entry ) { | 
                                                        
@@ -602,8 +602,8 @@ discard block  | 
                                                    ||
| 602 | 602 | */  | 
                                                        
| 603 | 603 |  	public function get_fields() { | 
                                                        
| 604 | 604 | $fields = array();  | 
                                                        
| 605 | -		foreach ( $this['fields'] as $field ) { | 
                                                        |
| 606 | -			foreach ( empty( $field['inputs'] ) ? array( $field['id'] ) : wp_list_pluck( $field['inputs'], 'id' ) as $id ) { | 
                                                        |
| 605 | +		foreach ( $this[ 'fields' ] as $field ) { | 
                                                        |
| 606 | +			foreach ( empty( $field[ 'inputs' ] ) ? array( $field[ 'id' ] ) : wp_list_pluck( $field[ 'inputs' ], 'id' ) as $id ) { | 
                                                        |
| 607 | 607 |  				if ( is_numeric( $id ) ) { | 
                                                        
| 608 | 608 | $fields[ $id ] = self::get_field( $this, $id );  | 
                                                        
| 609 | 609 |  				} else { | 
                                                        
@@ -640,7 +640,7 @@ discard block  | 
                                                    ||
| 640 | 640 | * @return bool Whether the offset exists or not.  | 
                                                        
| 641 | 641 | */  | 
                                                        
| 642 | 642 |  	public function offsetExists( $offset ) { | 
                                                        
| 643 | - return isset( $this->form[$offset] );  | 
                                                        |
| 643 | + return isset( $this->form[ $offset ] );  | 
                                                        |
| 644 | 644 | }  | 
                                                        
| 645 | 645 | |
| 646 | 646 | /**  | 
                                                        
@@ -655,7 +655,7 @@ discard block  | 
                                                    ||
| 655 | 655 | * @return mixed The value of the requested form data.  | 
                                                        
| 656 | 656 | */  | 
                                                        
| 657 | 657 |  	public function offsetGet( $offset ) { | 
                                                        
| 658 | - return $this->form[$offset];  | 
                                                        |
| 658 | + return $this->form[ $offset ];  | 
                                                        |
| 659 | 659 | }  | 
                                                        
| 660 | 660 | |
| 661 | 661 | /**  | 
                                                        
@@ -111,7 +111,8 @@  | 
                                                    ||
| 111 | 111 | |
| 112 | 112 | $form = &$this;  | 
                                                        
| 113 | 113 | |
| 114 | -		if ( gravityview()->plugin->supports( Plugin::FEATURE_GFQUERY ) ) { // @todo switch to GFAPI:: once they start supporting nested and joins stuff | 
                                                        |
| 114 | +		if ( gravityview()->plugin->supports( Plugin::FEATURE_GFQUERY ) ) { | 
                                                        |
| 115 | +// @todo switch to GFAPI:: once they start supporting nested and joins stuff  | 
                                                        |
| 115 | 116 |  			$entries->add_fetch_callback( function( $filters, $sorts, $offset ) use ( $view, &$form ) { | 
                                                        
| 116 | 117 | $atts = $view->settings->as_atts();  | 
                                                        
| 117 | 118 | |
@@ -55,6 +55,7 @@  | 
                                                    ||
| 55 | 55 | * Magic shortcuts.  | 
                                                        
| 56 | 56 | *  | 
                                                        
| 57 | 57 | * - `entries` -> `$this->get_entries()`  | 
                                                        
| 58 | + * @param string $key  | 
                                                        |
| 58 | 59 | */  | 
                                                        
| 59 | 60 |  	public function __get( $key ) { | 
                                                        
| 60 | 61 | switch ( $key ):  | 
                                                        
@@ -64,7 +64,7 @@ discard block  | 
                                                    ||
| 64 | 64 | 'type' => 'radio',  | 
                                                        
| 65 | 65 | 'full_width' => true,  | 
                                                        
| 66 | 66 | 'label' => esc_html__( 'Search Mode', 'gravityview' ),  | 
                                                        
| 67 | -				'desc' => __('Should search results match all search fields, or any?', 'gravityview'), | 
                                                        |
| 67 | + 'desc' => __( 'Should search results match all search fields, or any?', 'gravityview' ),  | 
                                                        |
| 68 | 68 | 'value' => 'any',  | 
                                                        
| 69 | 69 | 'class' => 'hide-if-js',  | 
                                                        
| 70 | 70 | 'options' => array(  | 
                                                        
@@ -83,7 +83,7 @@ discard block  | 
                                                    ||
| 83 | 83 | |
| 84 | 84 | // admin - add scripts - run at 1100 to make sure GravityView_Admin_Views::add_scripts_and_styles() runs first at 999  | 
                                                        
| 85 | 85 | add_action( 'admin_enqueue_scripts', array( $this, 'add_scripts_and_styles' ), 1100 );  | 
                                                        
| 86 | - add_action( 'wp_enqueue_scripts', array( $this, 'register_scripts') );  | 
                                                        |
| 86 | + add_action( 'wp_enqueue_scripts', array( $this, 'register_scripts' ) );  | 
                                                        |
| 87 | 87 | add_filter( 'gravityview_noconflict_scripts', array( $this, 'register_no_conflict' ) );  | 
                                                        
| 88 | 88 | |
| 89 | 89 | // ajax - get the searchable fields  | 
                                                        
@@ -227,7 +227,7 @@ discard block  | 
                                                    ||
| 227 | 227 | $script_min = ( defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ) ? '' : '.min';  | 
                                                        
| 228 | 228 | $script_source = empty( $script_min ) ? '/source' : '';  | 
                                                        
| 229 | 229 | |
| 230 | - wp_enqueue_script( 'gravityview_searchwidget_admin', plugins_url( 'assets/js'.$script_source.'/admin-search-widget'.$script_min.'.js', __FILE__ ), array( 'jquery', 'gravityview_views_scripts' ), \GV\Plugin::$version );  | 
                                                        |
| 230 | + wp_enqueue_script( 'gravityview_searchwidget_admin', plugins_url( 'assets/js' . $script_source . '/admin-search-widget' . $script_min . '.js', __FILE__ ), array( 'jquery', 'gravityview_views_scripts' ), \GV\Plugin::$version );  | 
                                                        |
| 231 | 231 | |
| 232 | 232 | wp_localize_script( 'gravityview_searchwidget_admin', 'gvSearchVar', array(  | 
                                                        
| 233 | 233 | 'nonce' => wp_create_nonce( 'gravityview_ajaxsearchwidget' ),  | 
                                                        
@@ -249,7 +249,7 @@ discard block  | 
                                                    ||
| 249 | 249 | * @return array Scripts allowed in no-conflict mode, plus the search widget script  | 
                                                        
| 250 | 250 | */  | 
                                                        
| 251 | 251 |  	public function register_no_conflict( $allowed ) { | 
                                                        
| 252 | - $allowed[] = 'gravityview_searchwidget_admin';  | 
                                                        |
| 252 | + $allowed[ ] = 'gravityview_searchwidget_admin';  | 
                                                        |
| 253 | 253 | return $allowed;  | 
                                                        
| 254 | 254 | }  | 
                                                        
| 255 | 255 | |
@@ -262,24 +262,24 @@ discard block  | 
                                                    ||
| 262 | 262 | */  | 
                                                        
| 263 | 263 |  	public static function get_searchable_fields() { | 
                                                        
| 264 | 264 | |
| 265 | -		if ( ! isset( $_POST['nonce'] ) || ! wp_verify_nonce( $_POST['nonce'], 'gravityview_ajaxsearchwidget' ) ) { | 
                                                        |
| 265 | +		if ( ! isset( $_POST[ 'nonce' ] ) || ! wp_verify_nonce( $_POST[ 'nonce' ], 'gravityview_ajaxsearchwidget' ) ) { | 
                                                        |
| 266 | 266 | exit( '0' );  | 
                                                        
| 267 | 267 | }  | 
                                                        
| 268 | 268 | |
| 269 | 269 | $form = '';  | 
                                                        
| 270 | 270 | |
| 271 | 271 | // Fetch the form for the current View  | 
                                                        
| 272 | -		if ( ! empty( $_POST['view_id'] ) ) { | 
                                                        |
| 272 | +		if ( ! empty( $_POST[ 'view_id' ] ) ) { | 
                                                        |
| 273 | 273 | |
| 274 | - $form = gravityview_get_form_id( $_POST['view_id'] );  | 
                                                        |
| 274 | + $form = gravityview_get_form_id( $_POST[ 'view_id' ] );  | 
                                                        |
| 275 | 275 | |
| 276 | -		} elseif ( ! empty( $_POST['formid'] ) ) { | 
                                                        |
| 276 | +		} elseif ( ! empty( $_POST[ 'formid' ] ) ) { | 
                                                        |
| 277 | 277 | |
| 278 | - $form = (int) $_POST['formid'];  | 
                                                        |
| 278 | + $form = (int)$_POST[ 'formid' ];  | 
                                                        |
| 279 | 279 | |
| 280 | -		} elseif ( ! empty( $_POST['template_id'] ) && class_exists( 'GravityView_Ajax' ) ) { | 
                                                        |
| 280 | +		} elseif ( ! empty( $_POST[ 'template_id' ] ) && class_exists( 'GravityView_Ajax' ) ) { | 
                                                        |
| 281 | 281 | |
| 282 | - $form = GravityView_Ajax::pre_get_form_fields( $_POST['template_id'] );  | 
                                                        |
| 282 | + $form = GravityView_Ajax::pre_get_form_fields( $_POST[ 'template_id' ] );  | 
                                                        |
| 283 | 283 | |
| 284 | 284 | }  | 
                                                        
| 285 | 285 | |
@@ -329,14 +329,14 @@ discard block  | 
                                                    ||
| 329 | 329 | );  | 
                                                        
| 330 | 330 | |
| 331 | 331 |  		if ( gravityview()->plugin->supports( \GV\Plugin::FEATURE_GFQUERY ) ) { | 
                                                        
| 332 | - $custom_fields['is_approved'] = array(  | 
                                                        |
| 332 | + $custom_fields[ 'is_approved' ] = array(  | 
                                                        |
| 333 | 333 | 'text' => esc_html__( 'Approval Status', 'gravityview' ),  | 
                                                        
| 334 | 334 | 'type' => 'multi',  | 
                                                        
| 335 | 335 | );  | 
                                                        
| 336 | 336 | }  | 
                                                        
| 337 | 337 | |
| 338 | -		foreach( $custom_fields as $custom_field_key => $custom_field ) { | 
                                                        |
| 339 | -			$output .= sprintf( '<option value="%s" %s data-inputtypes="%s" data-placeholder="%s">%s</option>', $custom_field_key, selected( $custom_field_key, $current, false ), $custom_field['type'], self::get_field_label( array('field' => $custom_field_key ) ), $custom_field['text'] ); | 
                                                        |
| 338 | +		foreach ( $custom_fields as $custom_field_key => $custom_field ) { | 
                                                        |
| 339 | + $output .= sprintf( '<option value="%s" %s data-inputtypes="%s" data-placeholder="%s">%s</option>', $custom_field_key, selected( $custom_field_key, $current, false ), $custom_field[ 'type' ], self::get_field_label( array( 'field' => $custom_field_key ) ), $custom_field[ 'text' ] );  | 
                                                        |
| 340 | 340 | }  | 
                                                        
| 341 | 341 | |
| 342 | 342 | // Get fields with sub-inputs and no parent  | 
                                                        
@@ -358,13 +358,13 @@ discard block  | 
                                                    ||
| 358 | 358 | |
| 359 | 359 |  			foreach ( $fields as $id => $field ) { | 
                                                        
| 360 | 360 | |
| 361 | -				if ( in_array( $field['type'], $blacklist_field_types ) ) { | 
                                                        |
| 361 | +				if ( in_array( $field[ 'type' ], $blacklist_field_types ) ) { | 
                                                        |
| 362 | 362 | continue;  | 
                                                        
| 363 | 363 | }  | 
                                                        
| 364 | 364 | |
| 365 | - $types = self::get_search_input_types( $id, $field['type'] );  | 
                                                        |
| 365 | + $types = self::get_search_input_types( $id, $field[ 'type' ] );  | 
                                                        |
| 366 | 366 | |
| 367 | - $output .= '<option value="'. $id .'" '. selected( $id, $current, false ).'data-inputtypes="'. esc_attr( $types ) .'">'. esc_html( $field['label'] ) .'</option>';  | 
                                                        |
| 367 | + $output .= '<option value="' . $id . '" ' . selected( $id, $current, false ) . 'data-inputtypes="' . esc_attr( $types ) . '">' . esc_html( $field[ 'label' ] ) . '</option>';  | 
                                                        |
| 368 | 368 | }  | 
                                                        
| 369 | 369 | }  | 
                                                        
| 370 | 370 | |
@@ -387,7 +387,7 @@ discard block  | 
                                                    ||
| 387 | 387 |  	public static function get_search_input_types( $field_id = '', $field_type = null ) { | 
                                                        
| 388 | 388 | |
| 389 | 389 | // @todo - This needs to be improved - many fields have . including products and addresses  | 
                                                        
| 390 | -		if ( false !== strpos( (string) $field_id, '.' ) && in_array( $field_type, array( 'checkbox' ) ) || in_array( $field_id, array( 'is_fulfilled' ) ) ) { | 
                                                        |
| 390 | +		if ( false !== strpos( (string)$field_id, '.' ) && in_array( $field_type, array( 'checkbox' ) ) || in_array( $field_id, array( 'is_fulfilled' ) ) ) { | 
                                                        |
| 391 | 391 | $input_type = 'boolean'; // on/off checkbox  | 
                                                        
| 392 | 392 |  		} elseif ( in_array( $field_type, array( 'checkbox', 'post_category', 'multiselect' ) ) ) { | 
                                                        
| 393 | 393 | $input_type = 'multi'; //multiselect  | 
                                                        
@@ -433,19 +433,19 @@ discard block  | 
                                                    ||
| 433 | 433 | $post_id = 0;  | 
                                                        
| 434 | 434 | |
| 435 | 435 | // We're in the WordPress Widget context, and an overriding post ID has been set.  | 
                                                        
| 436 | -			if ( ! empty( $widget_args['post_id'] ) ) { | 
                                                        |
| 437 | - $post_id = absint( $widget_args['post_id'] );  | 
                                                        |
| 436 | +			if ( ! empty( $widget_args[ 'post_id' ] ) ) { | 
                                                        |
| 437 | + $post_id = absint( $widget_args[ 'post_id' ] );  | 
                                                        |
| 438 | 438 | }  | 
                                                        
| 439 | 439 | // We're in the WordPress Widget context, and the base View ID should be used  | 
                                                        
| 440 | -			else if ( ! empty( $widget_args['view_id'] ) ) { | 
                                                        |
| 441 | - $post_id = absint( $widget_args['view_id'] );  | 
                                                        |
| 440 | +			else if ( ! empty( $widget_args[ 'view_id' ] ) ) { | 
                                                        |
| 441 | + $post_id = absint( $widget_args[ 'view_id' ] );  | 
                                                        |
| 442 | 442 | }  | 
                                                        
| 443 | 443 | |
| 444 | 444 | $args = gravityview_get_permalink_query_args( $post_id );  | 
                                                        
| 445 | 445 | |
| 446 | 446 | // Add hidden fields to the search form  | 
                                                        
| 447 | 447 |  			foreach ( $args as $key => $value ) { | 
                                                        
| 448 | - $search_fields[] = array(  | 
                                                        |
| 448 | + $search_fields[ ] = array(  | 
                                                        |
| 449 | 449 | 'name' => $key,  | 
                                                        
| 450 | 450 | 'input' => 'hidden',  | 
                                                        
| 451 | 451 | 'value' => $value,  | 
                                                        
@@ -484,28 +484,28 @@ discard block  | 
                                                    ||
| 484 | 484 | /**  | 
                                                        
| 485 | 485 | * Include the sidebar Widgets.  | 
                                                        
| 486 | 486 | */  | 
                                                        
| 487 | - $widgets = (array) get_option( 'widget_gravityview_search', array() );  | 
                                                        |
| 487 | + $widgets = (array)get_option( 'widget_gravityview_search', array() );  | 
                                                        |
| 488 | 488 | |
| 489 | 489 |  		foreach ( $widgets as $widget ) { | 
                                                        
| 490 | -			if ( ! empty( $widget['view_id'] ) && $widget['view_id'] == $view->ID ) { | 
                                                        |
| 491 | -				if( $_fields = json_decode( $widget['search_fields'], true ) ) { | 
                                                        |
| 490 | +			if ( ! empty( $widget[ 'view_id' ] ) && $widget[ 'view_id' ] == $view->ID ) { | 
                                                        |
| 491 | +				if ( $_fields = json_decode( $widget[ 'search_fields' ], true ) ) { | 
                                                        |
| 492 | 492 |  					foreach ( $_fields as $field ) { | 
                                                        
| 493 | -						if ( empty( $field['form_id'] ) ) { | 
                                                        |
| 494 | - $field['form_id'] = $view->form ? $view->form->ID : 0;  | 
                                                        |
| 493 | +						if ( empty( $field[ 'form_id' ] ) ) { | 
                                                        |
| 494 | + $field[ 'form_id' ] = $view->form ? $view->form->ID : 0;  | 
                                                        |
| 495 | 495 | }  | 
                                                        
| 496 | - $searchable_fields[] = $with_full_field ? $field : $field['field'];  | 
                                                        |
| 496 | + $searchable_fields[ ] = $with_full_field ? $field : $field[ 'field' ];  | 
                                                        |
| 497 | 497 | }  | 
                                                        
| 498 | 498 | }  | 
                                                        
| 499 | 499 | }  | 
                                                        
| 500 | 500 | }  | 
                                                        
| 501 | 501 | |
| 502 | 502 |  		foreach ( $view->widgets->by_id( $this->get_widget_id() )->all() as $widget ) { | 
                                                        
| 503 | -			if( $_fields = json_decode( $widget->configuration->get( 'search_fields' ), true ) ) { | 
                                                        |
| 503 | +			if ( $_fields = json_decode( $widget->configuration->get( 'search_fields' ), true ) ) { | 
                                                        |
| 504 | 504 |  				foreach ( $_fields as $field ) { | 
                                                        
| 505 | -					if ( empty( $field['form_id'] ) ) { | 
                                                        |
| 506 | - $field['form_id'] = $view->form ? $view->form->ID : 0;  | 
                                                        |
| 505 | +					if ( empty( $field[ 'form_id' ] ) ) { | 
                                                        |
| 506 | + $field[ 'form_id' ] = $view->form ? $view->form->ID : 0;  | 
                                                        |
| 507 | 507 | }  | 
                                                        
| 508 | - $searchable_fields[] = $with_full_field ? $field : $field['field'];  | 
                                                        |
| 508 | + $searchable_fields[ ] = $with_full_field ? $field : $field[ 'field' ];  | 
                                                        |
| 509 | 509 | }  | 
                                                        
| 510 | 510 | }  | 
                                                        
| 511 | 511 | }  | 
                                                        
@@ -543,7 +543,7 @@ discard block  | 
                                                    ||
| 543 | 543 | return $search_criteria; // Return the original criteria, GF_Query modification kicks in later  | 
                                                        
| 544 | 544 | }  | 
                                                        
| 545 | 545 | |
| 546 | -		if( 'post' === $this->search_method ) { | 
                                                        |
| 546 | +		if ( 'post' === $this->search_method ) { | 
                                                        |
| 547 | 547 | $get = $_POST;  | 
                                                        
| 548 | 548 |  		} else { | 
                                                        
| 549 | 549 | $get = $_GET;  | 
                                                        
@@ -562,15 +562,15 @@ discard block  | 
                                                    ||
| 562 | 562 | $get = gv_map_deep( $get, 'rawurldecode' );  | 
                                                        
| 563 | 563 | |
| 564 | 564 | // Make sure array key is set up  | 
                                                        
| 565 | - $search_criteria['field_filters'] = \GV\Utils::get( $search_criteria, 'field_filters', array() );  | 
                                                        |
| 565 | + $search_criteria[ 'field_filters' ] = \GV\Utils::get( $search_criteria, 'field_filters', array() );  | 
                                                        |
| 566 | 566 | |
| 567 | 567 | $searchable_fields = $this->get_view_searchable_fields( $view );  | 
                                                        
| 568 | 568 | $searchable_field_objects = $this->get_view_searchable_fields( $view, true );  | 
                                                        
| 569 | 569 | |
| 570 | 570 | // add free search  | 
                                                        
| 571 | -		if ( isset( $get['gv_search'] ) && '' !== $get['gv_search'] && in_array( 'search_all', $searchable_fields ) ) { | 
                                                        |
| 571 | +		if ( isset( $get[ 'gv_search' ] ) && '' !== $get[ 'gv_search' ] && in_array( 'search_all', $searchable_fields ) ) { | 
                                                        |
| 572 | 572 | |
| 573 | - $search_all_value = trim( $get['gv_search'] );  | 
                                                        |
| 573 | + $search_all_value = trim( $get[ 'gv_search' ] );  | 
                                                        |
| 574 | 574 | |
| 575 | 575 | /**  | 
                                                        
| 576 | 576 | * @filter `gravityview/search-all-split-words` Search for each word separately or the whole phrase?  | 
                                                        
@@ -595,7 +595,7 @@ discard block  | 
                                                    ||
| 595 | 595 | }  | 
                                                        
| 596 | 596 | |
| 597 | 597 |  			foreach ( $words as $word ) { | 
                                                        
| 598 | - $search_criteria['field_filters'][] = array(  | 
                                                        |
| 598 | + $search_criteria[ 'field_filters' ][ ] = array(  | 
                                                        |
| 599 | 599 | 'key' => null, // The field ID to search  | 
                                                        
| 600 | 600 | 'value' => $word, // The value to search  | 
                                                        
| 601 | 601 | 'operator' => 'contains', // What to search in. Options: `is` or `contains`  | 
                                                        
@@ -608,14 +608,14 @@ discard block  | 
                                                    ||
| 608 | 608 | /**  | 
                                                        
| 609 | 609 | * Get and normalize the dates according to the input format.  | 
                                                        
| 610 | 610 | */  | 
                                                        
| 611 | -			if ( $curr_start = ! empty( $get['gv_start'] ) ? $get['gv_start'] : '' ) { | 
                                                        |
| 612 | -				if( $curr_start_date = date_create_from_format( $this->get_datepicker_format( true ), $curr_start ) ) { | 
                                                        |
| 611 | +			if ( $curr_start = ! empty( $get[ 'gv_start' ] ) ? $get[ 'gv_start' ] : '' ) { | 
                                                        |
| 612 | +				if ( $curr_start_date = date_create_from_format( $this->get_datepicker_format( true ), $curr_start ) ) { | 
                                                        |
| 613 | 613 | $curr_start = $curr_start_date->format( 'Y-m-d' );  | 
                                                        
| 614 | 614 | }  | 
                                                        
| 615 | 615 | }  | 
                                                        
| 616 | 616 | |
| 617 | -			if ( $curr_end = ! empty( $get['gv_start'] ) ? ( ! empty( $get['gv_end'] ) ? $get['gv_end'] : '' ) : '' ) { | 
                                                        |
| 618 | -				if( $curr_end_date = date_create_from_format( $this->get_datepicker_format( true ), $curr_end ) ) { | 
                                                        |
| 617 | +			if ( $curr_end = ! empty( $get[ 'gv_start' ] ) ? ( ! empty( $get[ 'gv_end' ] ) ? $get[ 'gv_end' ] : '' ) : '' ) { | 
                                                        |
| 618 | +				if ( $curr_end_date = date_create_from_format( $this->get_datepicker_format( true ), $curr_end ) ) { | 
                                                        |
| 619 | 619 | $curr_end = $curr_end_date->format( 'Y-m-d' );  | 
                                                        
| 620 | 620 | }  | 
                                                        
| 621 | 621 | }  | 
                                                        
@@ -650,22 +650,22 @@ discard block  | 
                                                    ||
| 650 | 650 | */  | 
                                                        
| 651 | 651 |  			if ( ! empty( $curr_start ) ) { | 
                                                        
| 652 | 652 | $curr_start = date( 'Y-m-d H:i:s', strtotime( $curr_start ) );  | 
                                                        
| 653 | - $search_criteria['start_date'] = $adjust_tz ? get_gmt_from_date( $curr_start ) : $curr_start;  | 
                                                        |
| 653 | + $search_criteria[ 'start_date' ] = $adjust_tz ? get_gmt_from_date( $curr_start ) : $curr_start;  | 
                                                        |
| 654 | 654 | }  | 
                                                        
| 655 | 655 | |
| 656 | 656 |  			if ( ! empty( $curr_end ) ) { | 
                                                        
| 657 | 657 | // Fast-forward 24 hour on the end time  | 
                                                        
| 658 | 658 | $curr_end = date( 'Y-m-d H:i:s', strtotime( $curr_end ) + DAY_IN_SECONDS );  | 
                                                        
| 659 | - $search_criteria['end_date'] = $adjust_tz ? get_gmt_from_date( $curr_end ) : $curr_end;  | 
                                                        |
| 660 | -				if ( strpos( $search_criteria['end_date'], '00:00:00' ) ) { // See https://github.com/gravityview/GravityView/issues/1056 | 
                                                        |
| 661 | - $search_criteria['end_date'] = date( 'Y-m-d H:i:s', strtotime( $search_criteria['end_date'] ) - 1 );  | 
                                                        |
| 659 | + $search_criteria[ 'end_date' ] = $adjust_tz ? get_gmt_from_date( $curr_end ) : $curr_end;  | 
                                                        |
| 660 | +				if ( strpos( $search_criteria[ 'end_date' ], '00:00:00' ) ) { // See https://github.com/gravityview/GravityView/issues/1056 | 
                                                        |
| 661 | + $search_criteria[ 'end_date' ] = date( 'Y-m-d H:i:s', strtotime( $search_criteria[ 'end_date' ] ) - 1 );  | 
                                                        |
| 662 | 662 | }  | 
                                                        
| 663 | 663 | }  | 
                                                        
| 664 | 664 | }  | 
                                                        
| 665 | 665 | |
| 666 | 666 | // search for a specific entry ID  | 
                                                        
| 667 | 667 |  		if ( ! empty( $get[ 'gv_id' ] ) && in_array( 'entry_id', $searchable_fields ) ) { | 
                                                        
| 668 | - $search_criteria['field_filters'][] = array(  | 
                                                        |
| 668 | + $search_criteria[ 'field_filters' ][ ] = array(  | 
                                                        |
| 669 | 669 | 'key' => 'id',  | 
                                                        
| 670 | 670 | 'value' => absint( $get[ 'gv_id' ] ),  | 
                                                        
| 671 | 671 | 'operator' => $this->get_operator( $get, 'gv_id', array( '=' ), '=' ),  | 
                                                        
@@ -674,20 +674,20 @@ discard block  | 
                                                    ||
| 674 | 674 | |
| 675 | 675 | // search for a specific Created_by ID  | 
                                                        
| 676 | 676 |  		if ( ! empty( $get[ 'gv_by' ] ) && in_array( 'created_by', $searchable_fields ) ) { | 
                                                        
| 677 | - $search_criteria['field_filters'][] = array(  | 
                                                        |
| 677 | + $search_criteria[ 'field_filters' ][ ] = array(  | 
                                                        |
| 678 | 678 | 'key' => 'created_by',  | 
                                                        
| 679 | - 'value' => $get['gv_by'],  | 
                                                        |
| 679 | + 'value' => $get[ 'gv_by' ],  | 
                                                        |
| 680 | 680 | 'operator' => $this->get_operator( $get, 'gv_by', array( '=' ), '=' ),  | 
                                                        
| 681 | 681 | );  | 
                                                        
| 682 | 682 | }  | 
                                                        
| 683 | 683 | |
| 684 | 684 | // Get search mode passed in URL  | 
                                                        
| 685 | - $mode = isset( $get['mode'] ) && in_array( $get['mode'], array( 'any', 'all' ) ) ? $get['mode'] : 'any';  | 
                                                        |
| 685 | + $mode = isset( $get[ 'mode' ] ) && in_array( $get[ 'mode' ], array( 'any', 'all' ) ) ? $get[ 'mode' ] : 'any';  | 
                                                        |
| 686 | 686 | |
| 687 | 687 | // get the other search filters  | 
                                                        
| 688 | 688 |  		foreach ( $get as $key => $value ) { | 
                                                        
| 689 | 689 | |
| 690 | -			if ( 0 !== strpos( $key, 'filter_' ) || gv_empty( $value, false, false ) || ( is_array( $value ) && count( $value ) === 1 && gv_empty( $value[0], false, false ) ) ) { | 
                                                        |
| 690 | +			if ( 0 !== strpos( $key, 'filter_' ) || gv_empty( $value, false, false ) || ( is_array( $value ) && count( $value ) === 1 && gv_empty( $value[ 0 ], false, false ) ) ) { | 
                                                        |
| 691 | 691 | continue; // Not a filter, or empty  | 
                                                        
| 692 | 692 | }  | 
                                                        
| 693 | 693 | |
@@ -701,19 +701,19 @@ discard block  | 
                                                    ||
| 701 | 701 | continue;  | 
                                                        
| 702 | 702 | }  | 
                                                        
| 703 | 703 | |
| 704 | -			if ( ! isset( $filter['operator'] ) ) { | 
                                                        |
| 705 | - $filter['operator'] = $this->get_operator( $get, $key, array( 'contains' ), 'contains' );  | 
                                                        |
| 704 | +			if ( ! isset( $filter[ 'operator' ] ) ) { | 
                                                        |
| 705 | + $filter[ 'operator' ] = $this->get_operator( $get, $key, array( 'contains' ), 'contains' );  | 
                                                        |
| 706 | 706 | }  | 
                                                        
| 707 | 707 | |
| 708 | -			if ( isset( $filter[0]['value'] ) ) { | 
                                                        |
| 709 | - $search_criteria['field_filters'] = array_merge( $search_criteria['field_filters'], $filter );  | 
                                                        |
| 708 | +			if ( isset( $filter[ 0 ][ 'value' ] ) ) { | 
                                                        |
| 709 | + $search_criteria[ 'field_filters' ] = array_merge( $search_criteria[ 'field_filters' ], $filter );  | 
                                                        |
| 710 | 710 | |
| 711 | 711 | // if date range type, set search mode to ALL  | 
                                                        
| 712 | -				if ( ! empty( $filter[0]['operator'] ) && in_array( $filter[0]['operator'], array( '>=', '<=', '>', '<' ) ) ) { | 
                                                        |
| 712 | +				if ( ! empty( $filter[ 0 ][ 'operator' ] ) && in_array( $filter[ 0 ][ 'operator' ], array( '>=', '<=', '>', '<' ) ) ) { | 
                                                        |
| 713 | 713 | $mode = 'all';  | 
                                                        
| 714 | 714 | }  | 
                                                        
| 715 | -			} elseif( !empty( $filter ) ) { | 
                                                        |
| 716 | - $search_criteria['field_filters'][] = $filter;  | 
                                                        |
| 715 | +			} elseif ( ! empty( $filter ) ) { | 
                                                        |
| 716 | + $search_criteria[ 'field_filters' ][ ] = $filter;  | 
                                                        |
| 717 | 717 | }  | 
                                                        
| 718 | 718 | }  | 
                                                        
| 719 | 719 | |
@@ -722,7 +722,7 @@ discard block  | 
                                                    ||
| 722 | 722 | * @since 1.5.1  | 
                                                        
| 723 | 723 | * @param[out,in] string $mode Search mode (`any` vs `all`)  | 
                                                        
| 724 | 724 | */  | 
                                                        
| 725 | - $search_criteria['field_filters']['mode'] = apply_filters( 'gravityview/search/mode', $mode );  | 
                                                        |
| 725 | + $search_criteria[ 'field_filters' ][ 'mode' ] = apply_filters( 'gravityview/search/mode', $mode );  | 
                                                        |
| 726 | 726 | |
| 727 | 727 | gravityview()->log->debug( 'Returned Search Criteria: ', array( 'data' => $search_criteria ) );  | 
                                                        
| 728 | 728 | |
@@ -756,19 +756,19 @@ discard block  | 
                                                    ||
| 756 | 756 | |
| 757 | 757 | $query_class = $view->form->get_query_class( $view );  | 
                                                        
| 758 | 758 | |
| 759 | -		if ( empty( $search_criteria['field_filters'] ) ) { | 
                                                        |
| 759 | +		if ( empty( $search_criteria[ 'field_filters' ] ) ) { | 
                                                        |
| 760 | 760 | return;  | 
                                                        
| 761 | 761 | }  | 
                                                        
| 762 | 762 | |
| 763 | 763 | $widgets = $view->widgets->by_id( $this->widget_id );  | 
                                                        
| 764 | 764 |  		if ( $widgets->count() ) { | 
                                                        
| 765 | 765 | $widgets = $widgets->all();  | 
                                                        
| 766 | - $widget = $widgets[0];  | 
                                                        |
| 766 | + $widget = $widgets[ 0 ];  | 
                                                        |
| 767 | 767 | |
| 768 | 768 | $search_fields = json_decode( $widget->configuration->get( 'search_fields' ), true );  | 
                                                        
| 769 | 769 | |
| 770 | -			foreach ( (array) $search_fields as $search_field ) { | 
                                                        |
| 771 | -				if ( 'created_by' === $search_field['field'] && 'input_text' === $search_field['input'] ) { | 
                                                        |
| 770 | +			foreach ( (array)$search_fields as $search_field ) { | 
                                                        |
| 771 | +				if ( 'created_by' === $search_field[ 'field' ] && 'input_text' === $search_field[ 'input' ] ) { | 
                                                        |
| 772 | 772 | $created_by_text_mode = true;  | 
                                                        
| 773 | 773 | }  | 
                                                        
| 774 | 774 | }  | 
                                                        
@@ -777,7 +777,7 @@ discard block  | 
                                                    ||
| 777 | 777 | $extra_conditions = array();  | 
                                                        
| 778 | 778 | $mode = 'any';  | 
                                                        
| 779 | 779 | |
| 780 | -		foreach ( $search_criteria['field_filters'] as &$filter ) { | 
                                                        |
| 780 | +		foreach ( $search_criteria[ 'field_filters' ] as &$filter ) { | 
                                                        |
| 781 | 781 |  			if ( ! is_array( $filter ) ) { | 
                                                        
| 782 | 782 |  				if ( in_array( strtolower( $filter ), array( 'any', 'all' ) ) ) { | 
                                                        
| 783 | 783 | $mode = $filter;  | 
                                                        
@@ -786,13 +786,13 @@ discard block  | 
                                                    ||
| 786 | 786 | }  | 
                                                        
| 787 | 787 | |
| 788 | 788 | // Construct a manual query for unapproved statuses  | 
                                                        
| 789 | -			if ( 'is_approved' === $filter['key'] && in_array( \GravityView_Entry_Approval_Status::UNAPPROVED, (array) $filter['value'] ) ) { | 
                                                        |
| 790 | - $_tmp_query = new $query_class( $view->form->ID, array(  | 
                                                        |
| 789 | +			if ( 'is_approved' === $filter[ 'key' ] && in_array( \GravityView_Entry_Approval_Status::UNAPPROVED, (array)$filter[ 'value' ] ) ) { | 
                                                        |
| 790 | + $_tmp_query = new $query_class( $view->form->ID, array(  | 
                                                        |
| 791 | 791 | 'field_filters' => array(  | 
                                                        
| 792 | 792 | array(  | 
                                                        
| 793 | 793 | 'operator' => 'in',  | 
                                                        
| 794 | 794 | 'key' => 'is_approved',  | 
                                                        
| 795 | - 'value' => (array) $filter['value'],  | 
                                                        |
| 795 | + 'value' => (array)$filter[ 'value' ],  | 
                                                        |
| 796 | 796 | ),  | 
                                                        
| 797 | 797 | array(  | 
                                                        
| 798 | 798 | 'operator' => 'is',  | 
                                                        
@@ -804,30 +804,30 @@ discard block  | 
                                                    ||
| 804 | 804 | ) );  | 
                                                        
| 805 | 805 | $_tmp_query_parts = $_tmp_query->_introspect();  | 
                                                        
| 806 | 806 | |
| 807 | - $extra_conditions[] = $_tmp_query_parts['where'];  | 
                                                        |
| 807 | + $extra_conditions[ ] = $_tmp_query_parts[ 'where' ];  | 
                                                        |
| 808 | 808 | |
| 809 | 809 | $filter = false;  | 
                                                        
| 810 | 810 | continue;  | 
                                                        
| 811 | 811 | }  | 
                                                        
| 812 | 812 | |
| 813 | 813 | // Construct manual query for text mode creator search  | 
                                                        
| 814 | -			if ( 'created_by' === $filter['key'] && ! empty( $created_by_text_mode ) ) { | 
                                                        |
| 815 | - $extra_conditions[] = new GravityView_Widget_Search_Author_GF_Query_Condition( $filter, $view );  | 
                                                        |
| 814 | +			if ( 'created_by' === $filter[ 'key' ] && ! empty( $created_by_text_mode ) ) { | 
                                                        |
| 815 | + $extra_conditions[ ] = new GravityView_Widget_Search_Author_GF_Query_Condition( $filter, $view );  | 
                                                        |
| 816 | 816 | $filter = false;  | 
                                                        
| 817 | 817 | continue;  | 
                                                        
| 818 | 818 | }  | 
                                                        
| 819 | 819 | |
| 820 | 820 | // By default, we want searches to be wildcard for each field.  | 
                                                        
| 821 | - $filter['operator'] = empty( $filter['operator'] ) ? 'contains' : $filter['operator'];  | 
                                                        |
| 821 | + $filter[ 'operator' ] = empty( $filter[ 'operator' ] ) ? 'contains' : $filter[ 'operator' ];  | 
                                                        |
| 822 | 822 | |
| 823 | 823 | // For multichoice, let's have an in (OR) search.  | 
                                                        
| 824 | -			if ( is_array( $filter['value'] ) ) { | 
                                                        |
| 825 | - $filter['operator'] = 'in'; // @todo what about in contains (OR LIKE chains)?  | 
                                                        |
| 824 | +			if ( is_array( $filter[ 'value' ] ) ) { | 
                                                        |
| 825 | + $filter[ 'operator' ] = 'in'; // @todo what about in contains (OR LIKE chains)?  | 
                                                        |
| 826 | 826 | }  | 
                                                        
| 827 | 827 | |
| 828 | 828 | // Default form with joins functionality  | 
                                                        
| 829 | -			if ( empty( $filter['form_id'] ) ) { | 
                                                        |
| 830 | - $filter['form_id'] = $view->form ? $view->form->ID : 0;  | 
                                                        |
| 829 | +			if ( empty( $filter[ 'form_id' ] ) ) { | 
                                                        |
| 830 | + $filter[ 'form_id' ] = $view->form ? $view->form->ID : 0;  | 
                                                        |
| 831 | 831 | }  | 
                                                        
| 832 | 832 | |
| 833 | 833 | /**  | 
                                                        
@@ -837,28 +837,28 @@ discard block  | 
                                                    ||
| 837 | 837 | * @since develop  | 
                                                        
| 838 | 838 | * @param \GV\View $view The View we're operating on.  | 
                                                        
| 839 | 839 | */  | 
                                                        
| 840 | - $filter['operator'] = apply_filters( 'gravityview_search_operator', $filter['operator'], $filter, $view );  | 
                                                        |
| 840 | + $filter[ 'operator' ] = apply_filters( 'gravityview_search_operator', $filter[ 'operator' ], $filter, $view );  | 
                                                        |
| 841 | 841 | }  | 
                                                        
| 842 | 842 | |
| 843 | -		if ( ! empty( $search_criteria['start_date'] ) || ! empty( $search_criteria['end_date'] ) ) { | 
                                                        |
| 843 | +		if ( ! empty( $search_criteria[ 'start_date' ] ) || ! empty( $search_criteria[ 'end_date' ] ) ) { | 
                                                        |
| 844 | 844 | $date_criteria = array();  | 
                                                        
| 845 | 845 | |
| 846 | -			if ( isset( $search_criteria['start_date'] ) ) { | 
                                                        |
| 847 | - $date_criteria['start_date'] = $search_criteria['start_date'];  | 
                                                        |
| 846 | +			if ( isset( $search_criteria[ 'start_date' ] ) ) { | 
                                                        |
| 847 | + $date_criteria[ 'start_date' ] = $search_criteria[ 'start_date' ];  | 
                                                        |
| 848 | 848 | }  | 
                                                        
| 849 | 849 | |
| 850 | -			if ( isset( $search_criteria['end_date'] ) ) { | 
                                                        |
| 851 | - $date_criteria['end_date'] = $search_criteria['end_date'];  | 
                                                        |
| 850 | +			if ( isset( $search_criteria[ 'end_date' ] ) ) { | 
                                                        |
| 851 | + $date_criteria[ 'end_date' ] = $search_criteria[ 'end_date' ];  | 
                                                        |
| 852 | 852 | }  | 
                                                        
| 853 | 853 | |
| 854 | 854 | $_tmp_query = new $query_class( $view->form->ID, $date_criteria );  | 
                                                        
| 855 | 855 | $_tmp_query_parts = $_tmp_query->_introspect();  | 
                                                        
| 856 | - $extra_conditions[] = $_tmp_query_parts['where'];  | 
                                                        |
| 856 | + $extra_conditions[ ] = $_tmp_query_parts[ 'where' ];  | 
                                                        |
| 857 | 857 | }  | 
                                                        
| 858 | 858 | |
| 859 | 859 | $search_conditions = array();  | 
                                                        
| 860 | 860 | |
| 861 | -		if ( $filters = array_filter( $search_criteria['field_filters'] ) ) { | 
                                                        |
| 861 | +		if ( $filters = array_filter( $search_criteria[ 'field_filters' ] ) ) { | 
                                                        |
| 862 | 862 |  			foreach ( $filters as &$filter ) { | 
                                                        
| 863 | 863 |  				if ( ! is_array( $filter ) ) { | 
                                                        
| 864 | 864 | continue;  | 
                                                        
@@ -870,12 +870,12 @@ discard block  | 
                                                    ||
| 870 | 870 | * code by reusing what's inside GF_Query already as they  | 
                                                        
| 871 | 871 | * take care of many small things like forcing numeric, etc.  | 
                                                        
| 872 | 872 | */  | 
                                                        
| 873 | - $_tmp_query = new $query_class( $filter['form_id'], array( 'mode' => 'any', 'field_filters' => array( $filter ) ) );  | 
                                                        |
| 873 | + $_tmp_query = new $query_class( $filter[ 'form_id' ], array( 'mode' => 'any', 'field_filters' => array( $filter ) ) );  | 
                                                        |
| 874 | 874 | $_tmp_query_parts = $_tmp_query->_introspect();  | 
                                                        
| 875 | - $search_condition = $_tmp_query_parts['where'];  | 
                                                        |
| 875 | + $search_condition = $_tmp_query_parts[ 'where' ];  | 
                                                        |
| 876 | 876 | |
| 877 | -				if ( empty( $filter['key'] ) && $search_condition->expressions ) { | 
                                                        |
| 878 | - $search_conditions[] = $search_condition;  | 
                                                        |
| 877 | +				if ( empty( $filter[ 'key' ] ) && $search_condition->expressions ) { | 
                                                        |
| 878 | + $search_conditions[ ] = $search_condition;  | 
                                                        |
| 879 | 879 |  				} else { | 
                                                        
| 880 | 880 | $left = $search_condition->left;  | 
                                                        
| 881 | 881 | $alias = $query->_alias( $left->field_id, $left->source, $left->is_entry_column() ? 't' : 'm' );  | 
                                                        
@@ -885,7 +885,7 @@ discard block  | 
                                                    ||
| 885 | 885 | $on = $_join->join_on;  | 
                                                        
| 886 | 886 | $join = $_join->join;  | 
                                                        
| 887 | 887 | |
| 888 | - $search_conditions[] = GF_Query_Condition::_or(  | 
                                                        |
| 888 | + $search_conditions[ ] = GF_Query_Condition::_or(  | 
                                                        |
| 889 | 889 | // Join  | 
                                                        
| 890 | 890 | new GF_Query_Condition(  | 
                                                        
| 891 | 891 | new GF_Query_Column( GF_Query_Column::META, $join->ID, $query->_alias( GF_Query_Column::META, $join->ID, 'm' ) ),  | 
                                                        
@@ -901,7 +901,7 @@ discard block  | 
                                                    ||
| 901 | 901 | );  | 
                                                        
| 902 | 902 | }  | 
                                                        
| 903 | 903 |  					} else { | 
                                                        
| 904 | - $search_conditions[] = new GF_Query_Condition(  | 
                                                        |
| 904 | + $search_conditions[ ] = new GF_Query_Condition(  | 
                                                        |
| 905 | 905 | new GF_Query_Column( $left->field_id, $left->source, $alias ),  | 
                                                        
| 906 | 906 | $search_condition->operator,  | 
                                                        
| 907 | 907 | $search_condition->right  | 
                                                        
@@ -923,7 +923,7 @@ discard block  | 
                                                    ||
| 923 | 923 | /**  | 
                                                        
| 924 | 924 | * Combine the parts as a new WHERE clause.  | 
                                                        
| 925 | 925 | */  | 
                                                        
| 926 | - $where = call_user_func_array( '\GF_Query_Condition::_and', array_merge( array( $query_parts['where'] ), $search_conditions, $extra_conditions ) );  | 
                                                        |
| 926 | + $where = call_user_func_array( '\GF_Query_Condition::_and', array_merge( array( $query_parts[ 'where' ] ), $search_conditions, $extra_conditions ) );  | 
                                                        |
| 927 | 927 | $query->where( $where );  | 
                                                        
| 928 | 928 | }  | 
                                                        
| 929 | 929 | |
@@ -946,7 +946,7 @@ discard block  | 
                                                    ||
| 946 | 946 | $field_id = str_replace( 'filter_', '', $key );  | 
                                                        
| 947 | 947 | |
| 948 | 948 | // calculates field_id, removing 'filter_' and for '_' for advanced fields ( like name or checkbox )  | 
                                                        
| 949 | -		if ( preg_match('/^[0-9_]+$/ism', $field_id ) ) { | 
                                                        |
| 949 | +		if ( preg_match( '/^[0-9_]+$/ism', $field_id ) ) { | 
                                                        |
| 950 | 950 | $field_id = str_replace( '_', '.', $field_id );  | 
                                                        
| 951 | 951 | }  | 
                                                        
| 952 | 952 | |
@@ -1003,7 +1003,7 @@ discard block  | 
                                                    ||
| 1003 | 1003 | // form is in searchable fields  | 
                                                        
| 1004 | 1004 | $found = false;  | 
                                                        
| 1005 | 1005 |  			foreach ( $searchable_fields as $field ) { | 
                                                        
| 1006 | -				if ( $field_id == $field['field'] && $form->ID == $field['form_id'] ) { | 
                                                        |
| 1006 | +				if ( $field_id == $field[ 'field' ] && $form->ID == $field[ 'form_id' ] ) { | 
                                                        |
| 1007 | 1007 | $found = true;  | 
                                                        
| 1008 | 1008 | break;  | 
                                                        
| 1009 | 1009 | }  | 
                                                        
@@ -1043,7 +1043,7 @@ discard block  | 
                                                    ||
| 1043 | 1043 | |
| 1044 | 1044 | case 'select':  | 
                                                        
| 1045 | 1045 | case 'radio':  | 
                                                        
| 1046 | - $filter['operator'] = $this->get_operator( $get, $key, array( 'is' ), 'is' );  | 
                                                        |
| 1046 | + $filter[ 'operator' ] = $this->get_operator( $get, $key, array( 'is' ), 'is' );  | 
                                                        |
| 1047 | 1047 | break;  | 
                                                        
| 1048 | 1048 | |
| 1049 | 1049 | case 'post_category':  | 
                                                        
@@ -1057,7 +1057,7 @@ discard block  | 
                                                    ||
| 1057 | 1057 | |
| 1058 | 1058 |  				foreach ( $value as $val ) { | 
                                                        
| 1059 | 1059 | $cat = get_term( $val, 'category' );  | 
                                                        
| 1060 | - $filter[] = array(  | 
                                                        |
| 1060 | + $filter[ ] = array(  | 
                                                        |
| 1061 | 1061 | 'key' => $field_id,  | 
                                                        
| 1062 | 1062 | 'value' => esc_attr( $cat->name ) . ':' . $val,  | 
                                                        
| 1063 | 1063 | 'operator' => $this->get_operator( $get, $key, array( 'is' ), 'is' ),  | 
                                                        
@@ -1076,7 +1076,7 @@ discard block  | 
                                                    ||
| 1076 | 1076 | $filter = array();  | 
                                                        
| 1077 | 1077 | |
| 1078 | 1078 |  				foreach ( $value as $val ) { | 
                                                        
| 1079 | - $filter[] = array( 'key' => $field_id, 'value' => $val );  | 
                                                        |
| 1079 | + $filter[ ] = array( 'key' => $field_id, 'value' => $val );  | 
                                                        |
| 1080 | 1080 | }  | 
                                                        
| 1081 | 1081 | |
| 1082 | 1082 | break;  | 
                                                        
@@ -1085,9 +1085,9 @@ discard block  | 
                                                    ||
| 1085 | 1085 | // convert checkbox on/off into the correct search filter  | 
                                                        
| 1086 | 1086 |  				if ( false !== strpos( $field_id, '.' ) && ! empty( $form_field->inputs ) && ! empty( $form_field->choices ) ) { | 
                                                        
| 1087 | 1087 |  					foreach ( $form_field->inputs as $k => $input ) { | 
                                                        
| 1088 | -						if ( $input['id'] == $field_id ) { | 
                                                        |
| 1089 | - $filter['value'] = $form_field->choices[ $k ]['value'];  | 
                                                        |
| 1090 | - $filter['operator'] = $this->get_operator( $get, $key, array( 'is' ), 'is' );  | 
                                                        |
| 1088 | +						if ( $input[ 'id' ] == $field_id ) { | 
                                                        |
| 1089 | + $filter[ 'value' ] = $form_field->choices[ $k ][ 'value' ];  | 
                                                        |
| 1090 | + $filter[ 'operator' ] = $this->get_operator( $get, $key, array( 'is' ), 'is' );  | 
                                                        |
| 1091 | 1091 | break;  | 
                                                        
| 1092 | 1092 | }  | 
                                                        
| 1093 | 1093 | }  | 
                                                        
@@ -1097,7 +1097,7 @@ discard block  | 
                                                    ||
| 1097 | 1097 | $filter = array();  | 
                                                        
| 1098 | 1098 | |
| 1099 | 1099 |  					foreach ( $value as $val ) { | 
                                                        
| 1100 | - $filter[] = array(  | 
                                                        |
| 1100 | + $filter[ ] = array(  | 
                                                        |
| 1101 | 1101 | 'key' => $field_id,  | 
                                                        
| 1102 | 1102 | 'value' => $val,  | 
                                                        
| 1103 | 1103 | 'operator' => $this->get_operator( $get, $key, array( 'is' ), 'is' ),  | 
                                                        
@@ -1118,9 +1118,9 @@ discard block  | 
                                                    ||
| 1118 | 1118 |  					foreach ( $words as $word ) { | 
                                                        
| 1119 | 1119 |  						if ( ! empty( $word ) && strlen( $word ) > 1 ) { | 
                                                        
| 1120 | 1120 | // Keep the same key for each filter  | 
                                                        
| 1121 | - $filter['value'] = $word;  | 
                                                        |
| 1121 | + $filter[ 'value' ] = $word;  | 
                                                        |
| 1122 | 1122 | // Add a search for the value  | 
                                                        
| 1123 | - $filters[] = $filter;  | 
                                                        |
| 1123 | + $filters[ ] = $filter;  | 
                                                        |
| 1124 | 1124 | }  | 
                                                        
| 1125 | 1125 | }  | 
                                                        
| 1126 | 1126 | |
@@ -1134,19 +1134,19 @@ discard block  | 
                                                    ||
| 1134 | 1134 | |
| 1135 | 1135 |  					foreach ( $searchable_fields as $searchable_field ) { | 
                                                        
| 1136 | 1136 | |
| 1137 | -						if( $form_field->ID !== $searchable_field['field'] ) { | 
                                                        |
| 1137 | +						if ( $form_field->ID !== $searchable_field[ 'field' ] ) { | 
                                                        |
| 1138 | 1138 | continue;  | 
                                                        
| 1139 | 1139 | }  | 
                                                        
| 1140 | 1140 | |
| 1141 | 1141 | // Only exact-match dropdowns, not text search  | 
                                                        
| 1142 | -						if( in_array( $searchable_field['input'], array( 'text', 'search' ), true ) ) { | 
                                                        |
| 1142 | +						if ( in_array( $searchable_field[ 'input' ], array( 'text', 'search' ), true ) ) { | 
                                                        |
| 1143 | 1143 | continue;  | 
                                                        
| 1144 | 1144 | }  | 
                                                        
| 1145 | 1145 | |
| 1146 | 1146 | $input_id = gravityview_get_input_id_from_id( $form_field->ID );  | 
                                                        
| 1147 | 1147 | |
| 1148 | 1148 |  						if ( 4 === $input_id ) { | 
                                                        
| 1149 | - $filter['operator'] = $this->get_operator( $get, $key, array( 'is' ), 'is' );  | 
                                                        |
| 1149 | + $filter[ 'operator' ] = $this->get_operator( $get, $key, array( 'is' ), 'is' );  | 
                                                        |
| 1150 | 1150 | };  | 
                                                        
| 1151 | 1151 | }  | 
                                                        
| 1152 | 1152 | }  | 
                                                        
@@ -1173,12 +1173,12 @@ discard block  | 
                                                    ||
| 1173 | 1173 | * @since 1.16.3  | 
                                                        
| 1174 | 1174 | * Safeguard until GF implements '<=' operator  | 
                                                        
| 1175 | 1175 | */  | 
                                                        
| 1176 | -						if( !GFFormsModel::is_valid_operator( $operator ) && $operator === '<=' ) { | 
                                                        |
| 1176 | +						if ( ! GFFormsModel::is_valid_operator( $operator ) && $operator === '<=' ) { | 
                                                        |
| 1177 | 1177 | $operator = '<';  | 
                                                        
| 1178 | 1178 | $date = date( 'Y-m-d', strtotime( self::get_formatted_date( $date, 'Y-m-d', $date_format ) . ' +1 day' ) );  | 
                                                        
| 1179 | 1179 | }  | 
                                                        
| 1180 | 1180 | |
| 1181 | - $filter[] = array(  | 
                                                        |
| 1181 | + $filter[ ] = array(  | 
                                                        |
| 1182 | 1182 | 'key' => $field_id,  | 
                                                        
| 1183 | 1183 | 'value' => self::get_formatted_date( $date, 'Y-m-d', $date_format ),  | 
                                                        
| 1184 | 1184 | 'operator' => $this->get_operator( $get, $key, array( $operator ), $operator ),  | 
                                                        
@@ -1186,8 +1186,8 @@ discard block  | 
                                                    ||
| 1186 | 1186 | }  | 
                                                        
| 1187 | 1187 |  				} else { | 
                                                        
| 1188 | 1188 | $date = $value;  | 
                                                        
| 1189 | - $filter['value'] = self::get_formatted_date( $date, 'Y-m-d', $date_format );  | 
                                                        |
| 1190 | - $filter['operator'] = $this->get_operator( $get, $key, array( 'is' ), 'is' );  | 
                                                        |
| 1189 | + $filter[ 'value' ] = self::get_formatted_date( $date, 'Y-m-d', $date_format );  | 
                                                        |
| 1190 | + $filter[ 'operator' ] = $this->get_operator( $get, $key, array( 'is' ), 'is' );  | 
                                                        |
| 1191 | 1191 | }  | 
                                                        
| 1192 | 1192 | |
| 1193 | 1193 | break;  | 
                                                        
@@ -1218,7 +1218,7 @@ discard block  | 
                                                    ||
| 1218 | 1218 | 'ymd_dot' => 'Y.m.d',  | 
                                                        
| 1219 | 1219 | );  | 
                                                        
| 1220 | 1220 | |
| 1221 | -		if ( ! empty( $field->dateFormat ) && isset( $datepicker[ $field->dateFormat ] ) ){ | 
                                                        |
| 1221 | +		if ( ! empty( $field->dateFormat ) && isset( $datepicker[ $field->dateFormat ] ) ) { | 
                                                        |
| 1222 | 1222 | $format = $datepicker[ $field->dateFormat ];  | 
                                                        
| 1223 | 1223 | }  | 
                                                        
| 1224 | 1224 | |
@@ -1255,7 +1255,7 @@ discard block  | 
                                                    ||
| 1255 | 1255 |  	public function add_template_path( $file_paths ) { | 
                                                        
| 1256 | 1256 | |
| 1257 | 1257 | // Index 100 is the default GravityView template path.  | 
                                                        
| 1258 | - $file_paths[102] = self::$file . 'templates/';  | 
                                                        |
| 1258 | + $file_paths[ 102 ] = self::$file . 'templates/';  | 
                                                        |
| 1259 | 1259 | |
| 1260 | 1260 | return $file_paths;  | 
                                                        
| 1261 | 1261 | }  | 
                                                        
@@ -1274,7 +1274,7 @@ discard block  | 
                                                    ||
| 1274 | 1274 | $has_date = false;  | 
                                                        
| 1275 | 1275 | |
| 1276 | 1276 |  		foreach ( $search_fields as $k => $field ) { | 
                                                        
| 1277 | -			if ( in_array( $field['input'], array( 'date', 'date_range', 'entry_date' ) ) ) { | 
                                                        |
| 1277 | +			if ( in_array( $field[ 'input' ], array( 'date', 'date_range', 'entry_date' ) ) ) { | 
                                                        |
| 1278 | 1278 | $has_date = true;  | 
                                                        
| 1279 | 1279 | break;  | 
                                                        
| 1280 | 1280 | }  | 
                                                        
@@ -1301,7 +1301,7 @@ discard block  | 
                                                    ||
| 1301 | 1301 | }  | 
                                                        
| 1302 | 1302 | |
| 1303 | 1303 | // get configured search fields  | 
                                                        
| 1304 | - $search_fields = ! empty( $widget_args['search_fields'] ) ? json_decode( $widget_args['search_fields'], true ) : '';  | 
                                                        |
| 1304 | + $search_fields = ! empty( $widget_args[ 'search_fields' ] ) ? json_decode( $widget_args[ 'search_fields' ], true ) : '';  | 
                                                        |
| 1305 | 1305 | |
| 1306 | 1306 |  		if ( empty( $search_fields ) || ! is_array( $search_fields ) ) { | 
                                                        
| 1307 | 1307 | gravityview()->log->debug( 'No search fields configured for widget:', array( 'data' => $widget_args ) );  | 
                                                        
@@ -1317,40 +1317,40 @@ discard block  | 
                                                    ||
| 1317 | 1317 | |
| 1318 | 1318 | $updated_field = $this->get_search_filter_details( $updated_field, $context );  | 
                                                        
| 1319 | 1319 | |
| 1320 | -			switch ( $field['field'] ) { | 
                                                        |
| 1320 | +			switch ( $field[ 'field' ] ) { | 
                                                        |
| 1321 | 1321 | |
| 1322 | 1322 | case 'search_all':  | 
                                                        
| 1323 | - $updated_field['key'] = 'search_all';  | 
                                                        |
| 1324 | - $updated_field['input'] = 'search_all';  | 
                                                        |
| 1325 | - $updated_field['value'] = $this->rgget_or_rgpost( 'gv_search' );  | 
                                                        |
| 1323 | + $updated_field[ 'key' ] = 'search_all';  | 
                                                        |
| 1324 | + $updated_field[ 'input' ] = 'search_all';  | 
                                                        |
| 1325 | + $updated_field[ 'value' ] = $this->rgget_or_rgpost( 'gv_search' );  | 
                                                        |
| 1326 | 1326 | break;  | 
                                                        
| 1327 | 1327 | |
| 1328 | 1328 | case 'entry_date':  | 
                                                        
| 1329 | - $updated_field['key'] = 'entry_date';  | 
                                                        |
| 1330 | - $updated_field['input'] = 'entry_date';  | 
                                                        |
| 1331 | - $updated_field['value'] = array(  | 
                                                        |
| 1329 | + $updated_field[ 'key' ] = 'entry_date';  | 
                                                        |
| 1330 | + $updated_field[ 'input' ] = 'entry_date';  | 
                                                        |
| 1331 | + $updated_field[ 'value' ] = array(  | 
                                                        |
| 1332 | 1332 | 'start' => $this->rgget_or_rgpost( 'gv_start' ),  | 
                                                        
| 1333 | 1333 | 'end' => $this->rgget_or_rgpost( 'gv_end' ),  | 
                                                        
| 1334 | 1334 | );  | 
                                                        
| 1335 | 1335 | break;  | 
                                                        
| 1336 | 1336 | |
| 1337 | 1337 | case 'entry_id':  | 
                                                        
| 1338 | - $updated_field['key'] = 'entry_id';  | 
                                                        |
| 1339 | - $updated_field['input'] = 'entry_id';  | 
                                                        |
| 1340 | - $updated_field['value'] = $this->rgget_or_rgpost( 'gv_id' );  | 
                                                        |
| 1338 | + $updated_field[ 'key' ] = 'entry_id';  | 
                                                        |
| 1339 | + $updated_field[ 'input' ] = 'entry_id';  | 
                                                        |
| 1340 | + $updated_field[ 'value' ] = $this->rgget_or_rgpost( 'gv_id' );  | 
                                                        |
| 1341 | 1341 | break;  | 
                                                        
| 1342 | 1342 | |
| 1343 | 1343 | case 'created_by':  | 
                                                        
| 1344 | - $updated_field['key'] = 'created_by';  | 
                                                        |
| 1345 | - $updated_field['name'] = 'gv_by';  | 
                                                        |
| 1346 | - $updated_field['value'] = $this->rgget_or_rgpost( 'gv_by' );  | 
                                                        |
| 1347 | - $updated_field['choices'] = self::get_created_by_choices( $view );  | 
                                                        |
| 1344 | + $updated_field[ 'key' ] = 'created_by';  | 
                                                        |
| 1345 | + $updated_field[ 'name' ] = 'gv_by';  | 
                                                        |
| 1346 | + $updated_field[ 'value' ] = $this->rgget_or_rgpost( 'gv_by' );  | 
                                                        |
| 1347 | + $updated_field[ 'choices' ] = self::get_created_by_choices( $view );  | 
                                                        |
| 1348 | 1348 | break;  | 
                                                        
| 1349 | 1349 | |
| 1350 | 1350 | case 'is_approved':  | 
                                                        
| 1351 | - $updated_field['key'] = 'is_approved';  | 
                                                        |
| 1352 | - $updated_field['value'] = $this->rgget_or_rgpost( 'filter_is_approved' );  | 
                                                        |
| 1353 | - $updated_field['choices'] = self::get_is_approved_choices();  | 
                                                        |
| 1351 | + $updated_field[ 'key' ] = 'is_approved';  | 
                                                        |
| 1352 | + $updated_field[ 'value' ] = $this->rgget_or_rgpost( 'filter_is_approved' );  | 
                                                        |
| 1353 | + $updated_field[ 'choices' ] = self::get_is_approved_choices();  | 
                                                        |
| 1354 | 1354 | break;  | 
                                                        
| 1355 | 1355 | }  | 
                                                        
| 1356 | 1356 | |
@@ -1371,16 +1371,16 @@ discard block  | 
                                                    ||
| 1371 | 1371 | |
| 1372 | 1372 | $gravityview_view->permalink_fields = $this->add_no_permalink_fields( array(), $this, $widget_args );  | 
                                                        
| 1373 | 1373 | |
| 1374 | - $gravityview_view->search_layout = ! empty( $widget_args['search_layout'] ) ? $widget_args['search_layout'] : 'horizontal';  | 
                                                        |
| 1374 | + $gravityview_view->search_layout = ! empty( $widget_args[ 'search_layout' ] ) ? $widget_args[ 'search_layout' ] : 'horizontal';  | 
                                                        |
| 1375 | 1375 | |
| 1376 | 1376 | /** @since 1.14 */  | 
                                                        
| 1377 | - $gravityview_view->search_mode = ! empty( $widget_args['search_mode'] ) ? $widget_args['search_mode'] : 'any';  | 
                                                        |
| 1377 | + $gravityview_view->search_mode = ! empty( $widget_args[ 'search_mode' ] ) ? $widget_args[ 'search_mode' ] : 'any';  | 
                                                        |
| 1378 | 1378 | |
| 1379 | - $custom_class = ! empty( $widget_args['custom_class'] ) ? $widget_args['custom_class'] : '';  | 
                                                        |
| 1379 | + $custom_class = ! empty( $widget_args[ 'custom_class' ] ) ? $widget_args[ 'custom_class' ] : '';  | 
                                                        |
| 1380 | 1380 | |
| 1381 | 1381 | $gravityview_view->search_class = self::get_search_class( $custom_class );  | 
                                                        
| 1382 | 1382 | |
| 1383 | - $gravityview_view->search_clear = ! empty( $widget_args['search_clear'] ) ? $widget_args['search_clear'] : false;  | 
                                                        |
| 1383 | + $gravityview_view->search_clear = ! empty( $widget_args[ 'search_clear' ] ) ? $widget_args[ 'search_clear' ] : false;  | 
                                                        |
| 1384 | 1384 | |
| 1385 | 1385 |  		if ( $this->has_date_field( $search_fields ) ) { | 
                                                        
| 1386 | 1386 | // enqueue datepicker stuff only if needed!  | 
                                                        
@@ -1402,10 +1402,10 @@ discard block  | 
                                                    ||
| 1402 | 1402 |  	public static function get_search_class( $custom_class = '' ) { | 
                                                        
| 1403 | 1403 | $gravityview_view = GravityView_View::getInstance();  | 
                                                        
| 1404 | 1404 | |
| 1405 | - $search_class = 'gv-search-'.$gravityview_view->search_layout;  | 
                                                        |
| 1405 | + $search_class = 'gv-search-' . $gravityview_view->search_layout;  | 
                                                        |
| 1406 | 1406 | |
| 1407 | -		if ( ! empty( $custom_class )  ) { | 
                                                        |
| 1408 | - $search_class .= ' '.$custom_class;  | 
                                                        |
| 1407 | +		if ( ! empty( $custom_class ) ) { | 
                                                        |
| 1408 | + $search_class .= ' ' . $custom_class;  | 
                                                        |
| 1409 | 1409 | }  | 
                                                        
| 1410 | 1410 | |
| 1411 | 1411 | /**  | 
                                                        
@@ -1456,9 +1456,9 @@ discard block  | 
                                                    ||
| 1456 | 1456 | |
| 1457 | 1457 |  		if ( ! $label ) { | 
                                                        
| 1458 | 1458 | |
| 1459 | - $label = isset( $form_field['label'] ) ? $form_field['label'] : '';  | 
                                                        |
| 1459 | + $label = isset( $form_field[ 'label' ] ) ? $form_field[ 'label' ] : '';  | 
                                                        |
| 1460 | 1460 | |
| 1461 | -			switch( $field['field'] ) { | 
                                                        |
| 1461 | +			switch ( $field[ 'field' ] ) { | 
                                                        |
| 1462 | 1462 | case 'search_all':  | 
                                                        
| 1463 | 1463 | $label = __( 'Search Entries:', 'gravityview' );  | 
                                                        
| 1464 | 1464 | break;  | 
                                                        
@@ -1470,10 +1470,10 @@ discard block  | 
                                                    ||
| 1470 | 1470 | break;  | 
                                                        
| 1471 | 1471 | default:  | 
                                                        
| 1472 | 1472 | // If this is a field input, not a field  | 
                                                        
| 1473 | -					if ( strpos( $field['field'], '.' ) > 0 && ! empty( $form_field['inputs'] ) ) { | 
                                                        |
| 1473 | +					if ( strpos( $field[ 'field' ], '.' ) > 0 && ! empty( $form_field[ 'inputs' ] ) ) { | 
                                                        |
| 1474 | 1474 | |
| 1475 | 1475 | // Get the label for the field in question, which returns an array  | 
                                                        
| 1476 | - $items = wp_list_filter( $form_field['inputs'], array( 'id' => $field['field'] ) );  | 
                                                        |
| 1476 | + $items = wp_list_filter( $form_field[ 'inputs' ], array( 'id' => $field[ 'field' ] ) );  | 
                                                        |
| 1477 | 1477 | |
| 1478 | 1478 | // Get the item with the `label` key  | 
                                                        
| 1479 | 1479 | $values = wp_list_pluck( $items, 'label' );  | 
                                                        
@@ -1514,35 +1514,35 @@ discard block  | 
                                                    ||
| 1514 | 1514 | $form = $gravityview_view->getForm();  | 
                                                        
| 1515 | 1515 | |
| 1516 | 1516 | // for advanced field ids (eg, first name / last name )  | 
                                                        
| 1517 | - $name = 'filter_' . str_replace( '.', '_', $field['field'] );  | 
                                                        |
| 1517 | + $name = 'filter_' . str_replace( '.', '_', $field[ 'field' ] );  | 
                                                        |
| 1518 | 1518 | |
| 1519 | 1519 | // get searched value from $_GET/$_POST (string or array)  | 
                                                        
| 1520 | 1520 | $value = $this->rgget_or_rgpost( $name );  | 
                                                        
| 1521 | 1521 | |
| 1522 | 1522 | // get form field details  | 
                                                        
| 1523 | - $form_field = gravityview_get_field( $form, $field['field'] );  | 
                                                        |
| 1523 | + $form_field = gravityview_get_field( $form, $field[ 'field' ] );  | 
                                                        |
| 1524 | 1524 | |
| 1525 | 1525 | $filter = array(  | 
                                                        
| 1526 | - 'key' => $field['field'],  | 
                                                        |
| 1526 | + 'key' => $field[ 'field' ],  | 
                                                        |
| 1527 | 1527 | 'name' => $name,  | 
                                                        
| 1528 | 1528 | 'label' => self::get_field_label( $field, $form_field ),  | 
                                                        
| 1529 | - 'input' => $field['input'],  | 
                                                        |
| 1529 | + 'input' => $field[ 'input' ],  | 
                                                        |
| 1530 | 1530 | 'value' => $value,  | 
                                                        
| 1531 | - 'type' => $form_field['type'],  | 
                                                        |
| 1531 | + 'type' => $form_field[ 'type' ],  | 
                                                        |
| 1532 | 1532 | );  | 
                                                        
| 1533 | 1533 | |
| 1534 | 1534 | // collect choices  | 
                                                        
| 1535 | -		if ( 'post_category' === $form_field['type'] && ! empty( $form_field['displayAllCategories'] ) && empty( $form_field['choices'] ) ) { | 
                                                        |
| 1536 | - $filter['choices'] = gravityview_get_terms_choices();  | 
                                                        |
| 1537 | -		} elseif ( ! empty( $form_field['choices'] ) ) { | 
                                                        |
| 1538 | - $filter['choices'] = $form_field['choices'];  | 
                                                        |
| 1535 | +		if ( 'post_category' === $form_field[ 'type' ] && ! empty( $form_field[ 'displayAllCategories' ] ) && empty( $form_field[ 'choices' ] ) ) { | 
                                                        |
| 1536 | + $filter[ 'choices' ] = gravityview_get_terms_choices();  | 
                                                        |
| 1537 | +		} elseif ( ! empty( $form_field[ 'choices' ] ) ) { | 
                                                        |
| 1538 | + $filter[ 'choices' ] = $form_field[ 'choices' ];  | 
                                                        |
| 1539 | 1539 | }  | 
                                                        
| 1540 | 1540 | |
| 1541 | -		if ( 'date_range' === $field['input'] && empty( $value ) ) { | 
                                                        |
| 1542 | - $filter['value'] = array( 'start' => '', 'end' => '' );  | 
                                                        |
| 1541 | +		if ( 'date_range' === $field[ 'input' ] && empty( $value ) ) { | 
                                                        |
| 1542 | + $filter[ 'value' ] = array( 'start' => '', 'end' => '' );  | 
                                                        |
| 1543 | 1543 | }  | 
                                                        
| 1544 | 1544 | |
| 1545 | -		if ( ! empty( $filter['choices'] ) ) { | 
                                                        |
| 1545 | +		if ( ! empty( $filter[ 'choices' ] ) ) { | 
                                                        |
| 1546 | 1546 | /**  | 
                                                        
| 1547 | 1547 | * @filter `gravityview/search/sieve_choices` Only output used choices for this field.  | 
                                                        
| 1548 | 1548 | * @param[in,out] bool Yes or no.  | 
                                                        
@@ -1550,7 +1550,7 @@ discard block  | 
                                                    ||
| 1550 | 1550 | * @param \GV\Context The context.  | 
                                                        
| 1551 | 1551 | */  | 
                                                        
| 1552 | 1552 |  			if ( apply_filters( 'gravityview/search/sieve_choices', false, $field, $context ) ) { | 
                                                        
| 1553 | - $filter['choices'] = $this->sieve_filter_choices( $filter, $context );  | 
                                                        |
| 1553 | + $filter[ 'choices' ] = $this->sieve_filter_choices( $filter, $context );  | 
                                                        |
| 1554 | 1554 | }  | 
                                                        
| 1555 | 1555 | }  | 
                                                        
| 1556 | 1556 | |
@@ -1579,11 +1579,11 @@ discard block  | 
                                                    ||
| 1579 | 1579 | * @return array The filter choices.  | 
                                                        
| 1580 | 1580 | */  | 
                                                        
| 1581 | 1581 |  	private function sieve_filter_choices( $filter, $context ) { | 
                                                        
| 1582 | -		if ( empty( $filter['key'] ) || empty( $filter['choices'] ) ) { | 
                                                        |
| 1582 | +		if ( empty( $filter[ 'key' ] ) || empty( $filter[ 'choices' ] ) ) { | 
                                                        |
| 1583 | 1583 | return $filter; // @todo Populate plugins might give us empty choices  | 
                                                        
| 1584 | 1584 | }  | 
                                                        
| 1585 | 1585 | |
| 1586 | -		if ( ! is_numeric( $filter['key'] ) ) { | 
                                                        |
| 1586 | +		if ( ! is_numeric( $filter[ 'key' ] ) ) { | 
                                                        |
| 1587 | 1587 | return $filter;  | 
                                                        
| 1588 | 1588 | }  | 
                                                        
| 1589 | 1589 | |
@@ -1593,29 +1593,29 @@ discard block  | 
                                                    ||
| 1593 | 1593 | |
| 1594 | 1594 | $table = GFFormsModel::get_entry_meta_table_name();  | 
                                                        
| 1595 | 1595 | |
| 1596 | - $key_like = $wpdb->esc_like( $filter['key'] ) . '.%';  | 
                                                        |
| 1596 | + $key_like = $wpdb->esc_like( $filter[ 'key' ] ) . '.%';  | 
                                                        |
| 1597 | 1597 | |
| 1598 | 1598 | switch ( \GV\Utils::get( $filter, 'type' ) ):  | 
                                                        
| 1599 | 1599 | case 'post_category':  | 
                                                        
| 1600 | 1600 | $choices = $wpdb->get_col( $wpdb->prepare(  | 
                                                        
| 1601 | 1601 | "SELECT DISTINCT SUBSTRING_INDEX(meta_value, ':', 1) FROM $table WHERE (meta_key LIKE %s OR meta_key = %d) AND form_id = %d",  | 
                                                        
| 1602 | - $key_like, $filter['key'], $form_id  | 
                                                        |
| 1602 | + $key_like, $filter[ 'key' ], $form_id  | 
                                                        |
| 1603 | 1603 | ) );  | 
                                                        
| 1604 | 1604 | break;  | 
                                                        
| 1605 | 1605 | default:  | 
                                                        
| 1606 | 1606 | $choices = $wpdb->get_col( $wpdb->prepare(  | 
                                                        
| 1607 | 1607 | "SELECT DISTINCT meta_value FROM $table WHERE (meta_key LIKE %s OR meta_key = %d) AND form_id = %d",  | 
                                                        
| 1608 | - $key_like, $filter['key'], $form_id  | 
                                                        |
| 1608 | + $key_like, $filter[ 'key' ], $form_id  | 
                                                        |
| 1609 | 1609 | ) );  | 
                                                        
| 1610 | 1610 | |
| 1611 | -				if ( ( $field = gravityview_get_field( $form_id, $filter['key'] ) ) && 'json' === $field->storageType ) { | 
                                                        |
| 1611 | +				if ( ( $field = gravityview_get_field( $form_id, $filter[ 'key' ] ) ) && 'json' === $field->storageType ) { | 
                                                        |
| 1612 | 1612 | $choices = array_map( 'json_decode', $choices );  | 
                                                        
| 1613 | 1613 | $_choices_array = array();  | 
                                                        
| 1614 | 1614 |  					foreach ( $choices as $choice ) { | 
                                                        
| 1615 | 1615 |  						if ( is_array( $choice ) ) { | 
                                                        
| 1616 | 1616 | $_choices_array = array_merge( $_choices_array, $choice );  | 
                                                        
| 1617 | 1617 |  						} else { | 
                                                        
| 1618 | - $_choices_array []= $choice;  | 
                                                        |
| 1618 | + $_choices_array [ ] = $choice;  | 
                                                        |
| 1619 | 1619 | }  | 
                                                        
| 1620 | 1620 | }  | 
                                                        
| 1621 | 1621 | $choices = array_unique( $_choices_array );  | 
                                                        
@@ -1625,9 +1625,9 @@ discard block  | 
                                                    ||
| 1625 | 1625 | endswitch;  | 
                                                        
| 1626 | 1626 | |
| 1627 | 1627 | $filter_choices = array();  | 
                                                        
| 1628 | -		foreach ( $filter['choices'] as $choice ) { | 
                                                        |
| 1629 | -			if ( in_array( $choice['text'], $choices, true ) || in_array( $choice['value'], $choices, true ) ) { | 
                                                        |
| 1630 | - $filter_choices[] = $choice;  | 
                                                        |
| 1628 | +		foreach ( $filter[ 'choices' ] as $choice ) { | 
                                                        |
| 1629 | +			if ( in_array( $choice[ 'text' ], $choices, true ) || in_array( $choice[ 'value' ], $choices, true ) ) { | 
                                                        |
| 1630 | + $filter_choices[ ] = $choice;  | 
                                                        |
| 1631 | 1631 | }  | 
                                                        
| 1632 | 1632 | }  | 
                                                        
| 1633 | 1633 | |
@@ -1662,7 +1662,7 @@ discard block  | 
                                                    ||
| 1662 | 1662 | * @param \GV\View $view The view.  | 
                                                        
| 1663 | 1663 | */  | 
                                                        
| 1664 | 1664 | $text = apply_filters( 'gravityview/search/created_by/text', $user->display_name, $user, $view );  | 
                                                        
| 1665 | - $choices[] = array(  | 
                                                        |
| 1665 | + $choices[ ] = array(  | 
                                                        |
| 1666 | 1666 | 'value' => $user->ID,  | 
                                                        
| 1667 | 1667 | 'text' => $text,  | 
                                                        
| 1668 | 1668 | );  | 
                                                        
@@ -1682,9 +1682,9 @@ discard block  | 
                                                    ||
| 1682 | 1682 | |
| 1683 | 1683 | $choices = array();  | 
                                                        
| 1684 | 1684 |  		foreach ( GravityView_Entry_Approval_Status::get_all() as $status ) { | 
                                                        
| 1685 | - $choices[] = array(  | 
                                                        |
| 1686 | - 'value' => $status['value'],  | 
                                                        |
| 1687 | - 'text' => $status['label'],  | 
                                                        |
| 1685 | + $choices[ ] = array(  | 
                                                        |
| 1686 | + 'value' => $status[ 'value' ],  | 
                                                        |
| 1687 | + 'text' => $status[ 'label' ],  | 
                                                        |
| 1688 | 1688 | );  | 
                                                        
| 1689 | 1689 | }  | 
                                                        
| 1690 | 1690 | |
@@ -1736,7 +1736,7 @@ discard block  | 
                                                    ||
| 1736 | 1736 | */  | 
                                                        
| 1737 | 1737 |  	public function add_datepicker_js_dependency( $js_dependencies ) { | 
                                                        
| 1738 | 1738 | |
| 1739 | - $js_dependencies[] = 'jquery-ui-datepicker';  | 
                                                        |
| 1739 | + $js_dependencies[ ] = 'jquery-ui-datepicker';  | 
                                                        |
| 1740 | 1740 | |
| 1741 | 1741 | return $js_dependencies;  | 
                                                        
| 1742 | 1742 | }  | 
                                                        
@@ -1780,7 +1780,7 @@ discard block  | 
                                                    ||
| 1780 | 1780 | 'isRTL' => is_rtl(),  | 
                                                        
| 1781 | 1781 | ), $view_data );  | 
                                                        
| 1782 | 1782 | |
| 1783 | - $localizations['datepicker'] = $datepicker_settings;  | 
                                                        |
| 1783 | + $localizations[ 'datepicker' ] = $datepicker_settings;  | 
                                                        |
| 1784 | 1784 | |
| 1785 | 1785 | return $localizations;  | 
                                                        
| 1786 | 1786 | |
@@ -1807,7 +1807,7 @@ discard block  | 
                                                    ||
| 1807 | 1807 | * @return void  | 
                                                        
| 1808 | 1808 | */  | 
                                                        
| 1809 | 1809 |  	private function maybe_enqueue_flexibility() { | 
                                                        
| 1810 | -		if ( isset( $_SERVER['HTTP_USER_AGENT'] ) && preg_match( '/MSIE [8-9]/', $_SERVER['HTTP_USER_AGENT'] ) ) { | 
                                                        |
| 1810 | +		if ( isset( $_SERVER[ 'HTTP_USER_AGENT' ] ) && preg_match( '/MSIE [8-9]/', $_SERVER[ 'HTTP_USER_AGENT' ] ) ) { | 
                                                        |
| 1811 | 1811 | wp_enqueue_script( 'gv-flexibility' );  | 
                                                        
| 1812 | 1812 | }  | 
                                                        
| 1813 | 1813 | }  | 
                                                        
@@ -1829,7 +1829,7 @@ discard block  | 
                                                    ||
| 1829 | 1829 | add_filter( 'gravityview_js_localization', array( $this, 'add_datepicker_localization' ), 10, 2 );  | 
                                                        
| 1830 | 1830 | |
| 1831 | 1831 | $scheme = is_ssl() ? 'https://' : 'http://';  | 
                                                        
| 1832 | - wp_enqueue_style( 'jquery-ui-datepicker', $scheme.'ajax.googleapis.com/ajax/libs/jqueryui/1.8.18/themes/smoothness/jquery-ui.css' );  | 
                                                        |
| 1832 | + wp_enqueue_style( 'jquery-ui-datepicker', $scheme . 'ajax.googleapis.com/ajax/libs/jqueryui/1.8.18/themes/smoothness/jquery-ui.css' );  | 
                                                        |
| 1833 | 1833 | |
| 1834 | 1834 | /**  | 
                                                        
| 1835 | 1835 | * @filter `gravityview_search_datepicker_class`  | 
                                                        
@@ -1908,7 +1908,7 @@ discard block  | 
                                                    ||
| 1908 | 1908 |  	public function add_preview_inputs() { | 
                                                        
| 1909 | 1909 | global $wp;  | 
                                                        
| 1910 | 1910 | |
| 1911 | -		if ( ! is_preview() || ! current_user_can( 'publish_gravityviews') ) { | 
                                                        |
| 1911 | +		if ( ! is_preview() || ! current_user_can( 'publish_gravityviews' ) ) { | 
                                                        |
| 1912 | 1912 | return;  | 
                                                        
| 1913 | 1913 | }  | 
                                                        
| 1914 | 1914 | |
@@ -1960,7 +1960,7 @@ discard block  | 
                                                    ||
| 1960 | 1960 | */  | 
                                                        
| 1961 | 1961 |  class GravityView_Widget_Search_Author_GF_Query_Condition extends \GF_Query_Condition { | 
                                                        
| 1962 | 1962 |  	public function __construct( $filter, $view ) { | 
                                                        
| 1963 | - $this->value = $filter['value'];  | 
                                                        |
| 1963 | + $this->value = $filter[ 'value' ];  | 
                                                        |
| 1964 | 1964 | $this->view = $view;  | 
                                                        
| 1965 | 1965 | }  | 
                                                        
| 1966 | 1966 | |
@@ -1992,11 +1992,11 @@ discard block  | 
                                                    ||
| 1992 | 1992 | $conditions = array();  | 
                                                        
| 1993 | 1993 | |
| 1994 | 1994 |  		foreach ( $user_fields as $user_field ) { | 
                                                        
| 1995 | - $conditions[] = $wpdb->prepare( "`u`.`$user_field` LIKE %s", '%' . $wpdb->esc_like( $this->value ) . '%' );  | 
                                                        |
| 1995 | + $conditions[ ] = $wpdb->prepare( "`u`.`$user_field` LIKE %s", '%' . $wpdb->esc_like( $this->value ) . '%' );  | 
                                                        |
| 1996 | 1996 | }  | 
                                                        
| 1997 | 1997 | |
| 1998 | 1998 |  		foreach ( $user_meta_fields as $meta_field ) { | 
                                                        
| 1999 | - $conditions[] = $wpdb->prepare( "(`um`.`meta_key` = %s AND `um`.`meta_value` LIKE %s)", $meta_field, '%' . $wpdb->esc_like( $this->value ) . '%' );  | 
                                                        |
| 1999 | + $conditions[ ] = $wpdb->prepare( "(`um`.`meta_key` = %s AND `um`.`meta_value` LIKE %s)", $meta_field, '%' . $wpdb->esc_like( $this->value ) . '%' );  | 
                                                        |
| 2000 | 2000 | }  | 
                                                        
| 2001 | 2001 | |
| 2002 | 2002 |  		$conditions = '(' . implode( ' OR ', $conditions ) . ')'; | 
                                                        
@@ -46,19 +46,19 @@ discard block  | 
                                                    ||
| 46 | 46 | */  | 
                                                        
| 47 | 47 | $atts = apply_filters( 'gravityview/shortcodes/gvfield/atts', $atts );  | 
                                                        
| 48 | 48 | |
| 49 | -		if ( ! $view = \GV\View::by_id( $atts['view_id'] ) ) { | 
                                                        |
| 50 | -			gravityview()->log->error( 'View #{view_id} not found', array( 'view_id' => $atts['view_id'] ) ); | 
                                                        |
| 49 | +		if ( ! $view = \GV\View::by_id( $atts[ 'view_id' ] ) ) { | 
                                                        |
| 50 | +			gravityview()->log->error( 'View #{view_id} not found', array( 'view_id' => $atts[ 'view_id' ] ) ); | 
                                                        |
| 51 | 51 | return apply_filters( 'gravityview/shortcodes/gvfield/output', '', $view, null, null, $atts );  | 
                                                        
| 52 | 52 | }  | 
                                                        
| 53 | 53 | |
| 54 | - switch( $atts['entry_id'] ):  | 
                                                        |
| 54 | + switch ( $atts[ 'entry_id' ] ):  | 
                                                        |
| 55 | 55 | case 'last':  | 
                                                        
| 56 | 56 | $entries = $view->get_entries();  | 
                                                        
| 57 | 57 | |
| 58 | 58 | /** If a sort already exists, reverse it. */  | 
                                                        
| 59 | 59 |  				if ( $sort = end( $entries->sorts ) ) { | 
                                                        
| 60 | 60 | // @todo For multisorts we need to do this for each sort  | 
                                                        
| 61 | - $entries = $entries->sort( new \GV\Entry_Sort( $sort->field, $sort->direction == \GV\Entry_Sort::RAND ? : ( $sort->direction == \GV\Entry_Sort::ASC ? \GV\Entry_Sort::DESC : \GV\Entry_Sort::ASC ) ), $sort->mode );  | 
                                                        |
| 61 | + $entries = $entries->sort( new \GV\Entry_Sort( $sort->field, $sort->direction == \GV\Entry_Sort::RAND ?: ( $sort->direction == \GV\Entry_Sort::ASC ? \GV\Entry_Sort::DESC : \GV\Entry_Sort::ASC ) ), $sort->mode );  | 
                                                        |
| 62 | 62 |  				} else { | 
                                                        
| 63 | 63 | /** Otherwise, sort by date_created */  | 
                                                        
| 64 | 64 | $entries = $entries->sort( new \GV\Entry_Sort( \GV\Internal_Field::by_id( 'id' ), \GV\Entry_Sort::ASC ), \GV\Entry_Sort::NUMERIC );  | 
                                                        
@@ -74,20 +74,20 @@ discard block  | 
                                                    ||
| 74 | 74 | }  | 
                                                        
| 75 | 75 | break;  | 
                                                        
| 76 | 76 | default:  | 
                                                        
| 77 | -				if ( ! $entry = \GV\GF_Entry::by_id( $atts['entry_id'] ) ) { | 
                                                        |
| 78 | -					gravityview()->log->error( 'Entry #{entry_id} not found', array( 'view_id' => $atts['view_id'] ) ); | 
                                                        |
| 77 | +				if ( ! $entry = \GV\GF_Entry::by_id( $atts[ 'entry_id' ] ) ) { | 
                                                        |
| 78 | +					gravityview()->log->error( 'Entry #{entry_id} not found', array( 'view_id' => $atts[ 'view_id' ] ) ); | 
                                                        |
| 79 | 79 | return apply_filters( 'gravityview/shortcodes/gvfield/output', '', $view, $entry, null, $atts );  | 
                                                        
| 80 | 80 | }  | 
                                                        
| 81 | 81 | endswitch;  | 
                                                        
| 82 | 82 | |
| 83 | - $field = is_numeric( $atts['field_id'] ) ? \GV\GF_Field::by_id( $view->form, $atts['field_id'] ) : \GV\Internal_Field::by_id( $atts['field_id'] );  | 
                                                        |
| 83 | + $field = is_numeric( $atts[ 'field_id' ] ) ? \GV\GF_Field::by_id( $view->form, $atts[ 'field_id' ] ) : \GV\Internal_Field::by_id( $atts[ 'field_id' ] );  | 
                                                        |
| 84 | 84 | |
| 85 | 85 |  		if ( ! $field ) { | 
                                                        
| 86 | -			gravityview()->log->error( 'Field #{field_id} not found', array( 'view_id' => $atts['field_id'] ) ); | 
                                                        |
| 86 | +			gravityview()->log->error( 'Field #{field_id} not found', array( 'view_id' => $atts[ 'field_id' ] ) ); | 
                                                        |
| 87 | 87 | return apply_filters( 'gravityview/shortcodes/gvfield/output', '', $view, $entry, $field, $atts );  | 
                                                        
| 88 | 88 | }  | 
                                                        
| 89 | 89 | |
| 90 | -		if ( $view->form->ID != $entry['form_id'] ) { | 
                                                        |
| 90 | +		if ( $view->form->ID != $entry[ 'form_id' ] ) { | 
                                                        |
| 91 | 91 | gravityview()->log->error( 'Entry does not belong to view (form mismatch)' );  | 
                                                        
| 92 | 92 | return apply_filters( 'gravityview/shortcodes/gvfield/output', '', $view, $entry, $atts );  | 
                                                        
| 93 | 93 | }  | 
                                                        
@@ -97,7 +97,7 @@ discard block  | 
                                                    ||
| 97 | 97 | return apply_filters( 'gravityview/shortcodes/gvfield/output', get_the_password_form( $view->ID ), $view, $entry, $atts );  | 
                                                        
| 98 | 98 | }  | 
                                                        
| 99 | 99 | |
| 100 | -		if ( ! $view->form  ) { | 
                                                        |
| 100 | +		if ( ! $view->form ) { | 
                                                        |
| 101 | 101 |  			gravityview()->log->notice( 'View #{id} has no form attached to it.', array( 'id' => $view->ID ) ); | 
                                                        
| 102 | 102 | |
| 103 | 103 | /**  | 
                                                        
@@ -120,13 +120,13 @@ discard block  | 
                                                    ||
| 120 | 120 | }  | 
                                                        
| 121 | 121 | |
| 122 | 122 | /** Unapproved entries. */  | 
                                                        
| 123 | -		if ( $entry['status'] != 'active' ) { | 
                                                        |
| 123 | +		if ( $entry[ 'status' ] != 'active' ) { | 
                                                        |
| 124 | 124 |  			gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) ); | 
                                                        
| 125 | 125 | return apply_filters( 'gravityview/shortcodes/gvfield/output', '', $view, $entry, $atts );  | 
                                                        
| 126 | 126 | }  | 
                                                        
| 127 | 127 | |
| 128 | 128 |  		if ( $view->settings->get( 'show_only_approved' ) ) { | 
                                                        
| 129 | -			if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) { | 
                                                        |
| 129 | +			if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) { | 
                                                        |
| 130 | 130 |  				gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) ); | 
                                                        
| 131 | 131 | return apply_filters( 'gravityview/shortcodes/gvfield/output', '', $view, $entry, $atts );  | 
                                                        
| 132 | 132 | }  | 
                                                        
@@ -125,7 +125,7 @@ discard block  | 
                                                    ||
| 125 | 125 | $supports = array( 'title', 'revisions' );  | 
                                                        
| 126 | 126 | |
| 127 | 127 |  		if ( $is_hierarchical ) { | 
                                                        
| 128 | - $supports[] = 'page-attributes';  | 
                                                        |
| 128 | + $supports[ ] = 'page-attributes';  | 
                                                        |
| 129 | 129 | }  | 
                                                        
| 130 | 130 | |
| 131 | 131 | /**  | 
                                                        
@@ -227,11 +227,11 @@ discard block  | 
                                                    ||
| 227 | 227 | $rule = array( sprintf( '%s/([^/]+)/csv/?', $slug ), 'index.php?gravityview=$matches[1]&csv=1', 'top' );  | 
                                                        
| 228 | 228 | |
| 229 | 229 |  		add_filter( 'query_vars', function( $query_vars ) { | 
                                                        
| 230 | - $query_vars[] = 'csv';  | 
                                                        |
| 230 | + $query_vars[ ] = 'csv';  | 
                                                        |
| 231 | 231 | return $query_vars;  | 
                                                        
| 232 | 232 | } );  | 
                                                        
| 233 | 233 | |
| 234 | -		if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[0] ] ) ) { | 
                                                        |
| 234 | +		if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[ 0 ] ] ) ) { | 
                                                        |
| 235 | 235 | call_user_func_array( 'add_rewrite_rule', $rule );  | 
                                                        
| 236 | 236 | }  | 
                                                        
| 237 | 237 | }  | 
                                                        
@@ -308,13 +308,13 @@ discard block  | 
                                                    ||
| 308 | 308 | return $content;  | 
                                                        
| 309 | 309 | }  | 
                                                        
| 310 | 310 | |
| 311 | -		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap('gravityview_moderate_entries', $view->ID ); | 
                                                        |
| 311 | + $is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap( 'gravityview_moderate_entries', $view->ID );  | 
                                                        |
| 312 | 312 | |
| 313 | 313 | /**  | 
                                                        
| 314 | 314 | * Editing a single entry.  | 
                                                        
| 315 | 315 | */  | 
                                                        
| 316 | 316 |  		if ( $entry = $request->is_edit_entry( $view->form ? $view->form->ID : 0 ) ) { | 
                                                        
| 317 | -			if ( $entry['status'] != 'active' ) { | 
                                                        |
| 317 | +			if ( $entry[ 'status' ] != 'active' ) { | 
                                                        |
| 318 | 318 |  				gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) ); | 
                                                        
| 319 | 319 | return __( 'You are not allowed to view this content.', 'gravityview' );  | 
                                                        
| 320 | 320 | }  | 
                                                        
@@ -325,7 +325,7 @@ discard block  | 
                                                    ||
| 325 | 325 | }  | 
                                                        
| 326 | 326 | |
| 327 | 327 |  			if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) { | 
                                                        
| 328 | -				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) { | 
                                                        |
| 328 | +				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) { | 
                                                        |
| 329 | 329 |  					gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) ); | 
                                                        
| 330 | 330 | return __( 'You are not allowed to view this content.', 'gravityview' );  | 
                                                        
| 331 | 331 | }  | 
                                                        
@@ -348,7 +348,7 @@ discard block  | 
                                                    ||
| 348 | 348 | |
| 349 | 349 |  			foreach ( $entryset as $e ) { | 
                                                        
| 350 | 350 | |
| 351 | -				if ( 'active' !== $e['status'] ) { | 
                                                        |
| 351 | +				if ( 'active' !== $e[ 'status' ] ) { | 
                                                        |
| 352 | 352 |  					gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $e->ID ) ); | 
                                                        
| 353 | 353 | return __( 'You are not allowed to view this content.', 'gravityview' );  | 
                                                        
| 354 | 354 | }  | 
                                                        
@@ -359,7 +359,7 @@ discard block  | 
                                                    ||
| 359 | 359 | }  | 
                                                        
| 360 | 360 | |
| 361 | 361 |  				if ( $show_only_approved && ! $is_admin_and_can_view ) { | 
                                                        
| 362 | -					if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $e->ID, \GravityView_Entry_Approval::meta_key ) )  ) { | 
                                                        |
| 362 | +					if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $e->ID, \GravityView_Entry_Approval::meta_key ) ) ) { | 
                                                        |
| 363 | 363 |  						gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $e->ID ) ); | 
                                                        
| 364 | 364 | return __( 'You are not allowed to view this content.', 'gravityview' );  | 
                                                        
| 365 | 365 | }  | 
                                                        
@@ -534,7 +534,7 @@ discard block  | 
                                                    ||
| 534 | 534 | $join_column = is_numeric( $join_column ) ? GF_Field::by_id( $join, $join_column ) : Internal_Field::by_id( $join_column );  | 
                                                        
| 535 | 535 | $join_on_column = is_numeric( $join_on_column ) ? GF_Field::by_id( $join_on, $join_on_column ) : Internal_Field::by_id( $join_on_column );  | 
                                                        
| 536 | 536 | |
| 537 | - $joins [] = new Join( $join, $join_column, $join_on, $join_on_column );  | 
                                                        |
| 537 | + $joins [ ] = new Join( $join, $join_column, $join_on, $join_on_column );  | 
                                                        |
| 538 | 538 | }  | 
                                                        
| 539 | 539 | |
| 540 | 540 | return $joins;  | 
                                                        
@@ -624,13 +624,13 @@ discard block  | 
                                                    ||
| 624 | 624 | }  | 
                                                        
| 625 | 625 | |
| 626 | 626 |  			foreach ( $_fields as $field ) { | 
                                                        
| 627 | -				if ( ! empty( $field['unions'] ) ) { | 
                                                        |
| 628 | -					foreach ( $field['unions'] as $form_id => $field_id ) { | 
                                                        |
| 627 | +				if ( ! empty( $field[ 'unions' ] ) ) { | 
                                                        |
| 628 | +					foreach ( $field[ 'unions' ] as $form_id => $field_id ) { | 
                                                        |
| 629 | 629 |  						if ( ! isset( $unions[ $form_id ] ) ) { | 
                                                        
| 630 | 630 | $unions[ $form_id ] = array();  | 
                                                        
| 631 | 631 | }  | 
                                                        
| 632 | 632 | |
| 633 | - $unions[ $form_id ][ $field['id'] ] =  | 
                                                        |
| 633 | + $unions[ $form_id ][ $field[ 'id' ] ] =  | 
                                                        |
| 634 | 634 | is_numeric( $field_id ) ? \GV\GF_Field::by_id( \GV\GF_Form::by_id( $form_id ), $field_id ) : \GV\Internal_Field::by_id( $field_id );  | 
                                                        
| 635 | 635 | }  | 
                                                        
| 636 | 636 | }  | 
                                                        
@@ -685,7 +685,7 @@ discard block  | 
                                                    ||
| 685 | 685 |  		if ( ! $view->form ) { | 
                                                        
| 686 | 686 |  			gravityview()->log->error( 'View #{view_id} tried attaching non-existent Form #{form_id} to it.', array( | 
                                                        
| 687 | 687 | 'view_id' => $view->ID,  | 
                                                        
| 688 | - 'form_id' => $view->_gravityview_form_id ? : 0,  | 
                                                        |
| 688 | + 'form_id' => $view->_gravityview_form_id ?: 0,  | 
                                                        |
| 689 | 689 | ) );  | 
                                                        
| 690 | 690 | }  | 
                                                        
| 691 | 691 | |
@@ -925,10 +925,10 @@ discard block  | 
                                                    ||
| 925 | 925 | * Remove multiple sorting before calling legacy filters.  | 
                                                        
| 926 | 926 | * This allows us to fake it till we make it.  | 
                                                        
| 927 | 927 | */  | 
                                                        
| 928 | -			if ( ! empty( $parameters['sort_field'] ) && is_array( $parameters['sort_field'] ) ) { | 
                                                        |
| 929 | - $parameters['sort_field'] = reset( $parameters['sort_field'] );  | 
                                                        |
| 930 | -				if ( ! empty( $parameters['sort_direction'] ) && is_array( $parameters['sort_direction'] ) ) { | 
                                                        |
| 931 | - $parameters['sort_direction'] = reset( $parameters['sort_direction'] );  | 
                                                        |
| 928 | +			if ( ! empty( $parameters[ 'sort_field' ] ) && is_array( $parameters[ 'sort_field' ] ) ) { | 
                                                        |
| 929 | + $parameters[ 'sort_field' ] = reset( $parameters[ 'sort_field' ] );  | 
                                                        |
| 930 | +				if ( ! empty( $parameters[ 'sort_direction' ] ) && is_array( $parameters[ 'sort_direction' ] ) ) { | 
                                                        |
| 931 | + $parameters[ 'sort_direction' ] = reset( $parameters[ 'sort_direction' ] );  | 
                                                        |
| 932 | 932 | }  | 
                                                        
| 933 | 933 | }  | 
                                                        
| 934 | 934 | |
@@ -937,31 +937,30 @@ discard block  | 
                                                    ||
| 937 | 937 | */  | 
                                                        
| 938 | 938 | $parameters = \GravityView_frontend::get_view_entries_parameters( $parameters, $this->form->ID );  | 
                                                        
| 939 | 939 | |
| 940 | - $parameters['context_view_id'] = $this->ID;  | 
                                                        |
| 940 | + $parameters[ 'context_view_id' ] = $this->ID;  | 
                                                        |
| 941 | 941 | $parameters = \GVCommon::calculate_get_entries_criteria( $parameters, $this->form->ID );  | 
                                                        
| 942 | 942 | |
| 943 | 943 |  			if ( ! is_array( $parameters ) ) { | 
                                                        
| 944 | 944 | $parameters = array();  | 
                                                        
| 945 | 945 | }  | 
                                                        
| 946 | 946 | |
| 947 | -			if ( ! is_array( $parameters['search_criteria'] ) ) { | 
                                                        |
| 948 | - $parameters['search_criteria'] = array();  | 
                                                        |
| 947 | +			if ( ! is_array( $parameters[ 'search_criteria' ] ) ) { | 
                                                        |
| 948 | + $parameters[ 'search_criteria' ] = array();  | 
                                                        |
| 949 | 949 | }  | 
                                                        
| 950 | 950 | |
| 951 | -			if ( ( ! isset( $parameters['search_criteria']['field_filters'] ) ) || ( ! is_array( $parameters['search_criteria']['field_filters'] ) ) ) { | 
                                                        |
| 952 | - $parameters['search_criteria']['field_filters'] = array();  | 
                                                        |
| 951 | +			if ( ( ! isset( $parameters[ 'search_criteria' ][ 'field_filters' ] ) ) || ( ! is_array( $parameters[ 'search_criteria' ][ 'field_filters' ] ) ) ) { | 
                                                        |
| 952 | + $parameters[ 'search_criteria' ][ 'field_filters' ] = array();  | 
                                                        |
| 953 | 953 | }  | 
                                                        
| 954 | 954 | |
| 955 | 955 |  			if ( $request instanceof REST\Request ) { | 
                                                        
| 956 | 956 | $atts = $this->settings->as_atts();  | 
                                                        
| 957 | 957 | $paging_parameters = wp_parse_args( $request->get_paging(), array(  | 
                                                        
| 958 | - 'paging' => array( 'page_size' => $atts['page_size'] ),  | 
                                                        |
| 958 | + 'paging' => array( 'page_size' => $atts[ 'page_size' ] ),  | 
                                                        |
| 959 | 959 | ) );  | 
                                                        
| 960 | - $parameters['paging'] = $paging_parameters['paging'];  | 
                                                        |
| 960 | + $parameters[ 'paging' ] = $paging_parameters[ 'paging' ];  | 
                                                        |
| 961 | 961 | }  | 
                                                        
| 962 | 962 | |
| 963 | - $page = Utils::get( $parameters['paging'], 'current_page' ) ?  | 
                                                        |
| 964 | - : ( ( ( $parameters['paging']['offset'] - $this->settings->get( 'offset' ) ) / \GV\Utils::get( $parameters, 'paging/page_size', 25 ) ) + 1 );  | 
                                                        |
| 963 | + $page = Utils::get( $parameters[ 'paging' ], 'current_page' ) ?: ( ( ( $parameters[ 'paging' ][ 'offset' ] - $this->settings->get( 'offset' ) ) / \GV\Utils::get( $parameters, 'paging/page_size', 25 ) ) + 1 );  | 
                                                        |
| 965 | 964 | |
| 966 | 965 | /**  | 
                                                        
| 967 | 966 | * Cleanup duplicate field_filter parameters to simplify the query.  | 
                                                        
@@ -969,28 +968,28 @@ discard block  | 
                                                    ||
| 969 | 968 | $unique_field_filters = array();  | 
                                                        
| 970 | 969 |  			foreach ( Utils::get( $parameters, 'search_criteria/field_filters', array() ) as $key => $filter ) { | 
                                                        
| 971 | 970 |  				if ( 'mode' === $key ) { | 
                                                        
| 972 | - $unique_field_filters['mode'] = $filter;  | 
                                                        |
| 971 | + $unique_field_filters[ 'mode' ] = $filter;  | 
                                                        |
| 973 | 972 |  				} else if ( ! in_array( $filter, $unique_field_filters ) ) { | 
                                                        
| 974 | - $unique_field_filters[] = $filter;  | 
                                                        |
| 973 | + $unique_field_filters[ ] = $filter;  | 
                                                        |
| 975 | 974 | }  | 
                                                        
| 976 | 975 | }  | 
                                                        
| 977 | - $parameters['search_criteria']['field_filters'] = $unique_field_filters;  | 
                                                        |
| 976 | + $parameters[ 'search_criteria' ][ 'field_filters' ] = $unique_field_filters;  | 
                                                        |
| 978 | 977 | |
| 979 | -			if ( ! empty( $parameters['search_criteria']['field_filters'] ) ) { | 
                                                        |
| 978 | +			if ( ! empty( $parameters[ 'search_criteria' ][ 'field_filters' ] ) ) { | 
                                                        |
| 980 | 979 | gravityview()->log->notice( 'search_criteria/field_filters is not empty, third-party code may be using legacy search_criteria filters.' );  | 
                                                        
| 981 | 980 | }  | 
                                                        
| 982 | 981 | |
| 983 | 982 | $entries = $this->form->get_entries( $this )  | 
                                                        
| 984 | - ->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters['search_criteria'] ) )  | 
                                                        |
| 983 | + ->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters[ 'search_criteria' ] ) )  | 
                                                        |
| 985 | 984 | ->offset( $this->settings->get( 'offset' ) )  | 
                                                        
| 986 | - ->limit( $parameters['paging']['page_size'] )  | 
                                                        |
| 985 | + ->limit( $parameters[ 'paging' ][ 'page_size' ] )  | 
                                                        |
| 987 | 986 | ->page( $page );  | 
                                                        
| 988 | 987 | |
| 989 | 988 | |
| 990 | -			if ( ! empty( $parameters['sorting'] ) && ! empty( $parameters['sorting']['key'] ) ) { | 
                                                        |
| 989 | +			if ( ! empty( $parameters[ 'sorting' ] ) && ! empty( $parameters[ 'sorting' ][ 'key' ] ) ) { | 
                                                        |
| 991 | 990 | $field = new \GV\Field();  | 
                                                        
| 992 | - $field->ID = $parameters['sorting']['key'];  | 
                                                        |
| 993 | - $direction = strtolower( $parameters['sorting']['direction'] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;  | 
                                                        |
| 991 | + $field->ID = $parameters[ 'sorting' ][ 'key' ];  | 
                                                        |
| 992 | + $direction = strtolower( $parameters[ 'sorting' ][ 'direction' ] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;  | 
                                                        |
| 994 | 993 | $entries = $entries->sort( new \GV\Entry_Sort( $field, $direction ) );  | 
                                                        
| 995 | 994 | }  | 
                                                        
| 996 | 995 | }  | 
                                                        
@@ -1064,7 +1063,7 @@ discard block  | 
                                                    ||
| 1064 | 1063 | $allowed = $headers = array();  | 
                                                        
| 1065 | 1064 | |
| 1066 | 1065 |  		foreach ( $view->fields->by_position( "directory_*" )->by_visible( $view )->all() as $id => $field ) { | 
                                                        
| 1067 | - $allowed[] = $field;  | 
                                                        |
| 1066 | + $allowed[ ] = $field;  | 
                                                        |
| 1068 | 1067 | }  | 
                                                        
| 1069 | 1068 | |
| 1070 | 1069 | $renderer = new Field_Renderer();  | 
                                                        
@@ -1086,17 +1085,17 @@ discard block  | 
                                                    ||
| 1086 | 1085 | } );  | 
                                                        
| 1087 | 1086 | |
| 1088 | 1087 |  			foreach ( array_diff( $allowed_field_ids, wp_list_pluck( $allowed, 'ID' ) ) as $field_id ) { | 
                                                        
| 1089 | - $allowed[] = is_numeric( $field_id ) ? \GV\GF_Field::by_id( $view->form, $field_id ) : \GV\Internal_Field::by_id( $field_id );  | 
                                                        |
| 1088 | + $allowed[ ] = is_numeric( $field_id ) ? \GV\GF_Field::by_id( $view->form, $field_id ) : \GV\Internal_Field::by_id( $field_id );  | 
                                                        |
| 1090 | 1089 | }  | 
                                                        
| 1091 | 1090 | |
| 1092 | 1091 |  			foreach ( $allowed as $field ) { | 
                                                        
| 1093 | 1092 | $source = is_numeric( $field->ID ) ? $view->form : new \GV\Internal_Source();  | 
                                                        
| 1094 | 1093 | |
| 1095 | - $return[] = $renderer->render( $field, $view, $source, $entry, gravityview()->request, '\GV\Field_CSV_Template' );  | 
                                                        |
| 1094 | + $return[ ] = $renderer->render( $field, $view, $source, $entry, gravityview()->request, '\GV\Field_CSV_Template' );  | 
                                                        |
| 1096 | 1095 | |
| 1097 | 1096 |  				if ( ! $headers_done ) { | 
                                                        
| 1098 | 1097 | $label = $field->get_label( $view, $source, $entry );  | 
                                                        
| 1099 | - $headers[] = $label ? $label : $field->ID;  | 
                                                        |
| 1098 | + $headers[ ] = $label ? $label : $field->ID;  | 
                                                        |
| 1100 | 1099 | }  | 
                                                        
| 1101 | 1100 | }  | 
                                                        
| 1102 | 1101 | |