Completed
Push — develop ( 6a9d11...10b764 )
by Gennady
22:55 queued 17:48
created
includes/class-gravityview-gfformsmodel.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -40,12 +40,12 @@  discard block
 block discarded – undo
40 40
 	public static function is_value_match( $field_value, $target_value, $operation = 'is', $source_field = null, $rule = null, $form = null ) {
41 41
 
42 42
 		if ( 'date_created' === $source_field ) {
43
-			$field_value = is_int( $field_value )? $field_value : strtotime( $field_value );
44
-			$target_value = is_int( $target_value )? $target_value : strtotime( $target_value );
43
+			$field_value = is_int( $field_value ) ? $field_value : strtotime( $field_value );
44
+			$target_value = is_int( $target_value ) ? $target_value : strtotime( $target_value );
45 45
 		}
46 46
 
47 47
 		if ( in_array( $operation, array( 'in', 'not_in' ) ) ) {
48
-			return GVCommon::matches_operation( (array) $field_value, (array) $target_value, $operation );
48
+			return GVCommon::matches_operation( (array)$field_value, (array)$target_value, $operation );
49 49
 		}
50 50
 
51 51
 		return parent::is_value_match( $field_value, $target_value, $operation, $source_field, $rule, $form );
@@ -69,18 +69,18 @@  discard block
 block discarded – undo
69 69
 
70 70
         $post_data = self::get_post_fields( $form, $entry );
71 71
 
72
-        $media = get_attached_media( 'image', $entry['post_id'] );
72
+        $media = get_attached_media( 'image', $entry[ 'post_id' ] );
73 73
 
74 74
         $post_images = array();
75 75
 
76 76
         foreach ( $media as $media_item ) {
77
-            foreach( (array) $post_data['images'] as $post_data_item ) {
78
-                if(
77
+            foreach ( (array)$post_data[ 'images' ] as $post_data_item ) {
78
+                if (
79 79
                     \GV\Utils::get( $post_data_item, 'title' ) === $media_item->post_title &&
80 80
                     \GV\Utils::get( $post_data_item, 'description' ) === $media_item->post_content &&
81 81
                     \GV\Utils::get( $post_data_item, 'caption' ) === $media_item->post_excerpt
82 82
                 ) {
83
-                    $post_images["{$post_data_item['field_id']}"] = $media_item->ID;
83
+                    $post_images[ "{$post_data_item[ 'field_id' ]}" ] = $media_item->ID;
84 84
                 }
85 85
             }
86 86
         }
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
          * If the method changes to public, use Gravity Forms' method
109 109
          * @todo: If/when the method is public, remove the unneeded copied code.
110 110
          */
111
-        if( $reflection->isPublic() ) {
111
+        if ( $reflection->isPublic() ) {
112 112
             return parent::get_post_fields( $form, $entry );
113 113
         }
114 114
 
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
          * If the method changes to public, use Gravity Forms' method
136 136
          * @todo: If/when the method is public, remove the unneeded copied code.
137 137
          */
138
-        if( $reflection->isPublic() ) {
138
+        if ( $reflection->isPublic() ) {
139 139
             return parent::copy_post_image( $url, $post_id );
140 140
         }
141 141
 
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
          * If the method changes to public, use Gravity Forms' method
171 171
          * @todo: If/when the method is public, remove the unneeded copied code.
172 172
          */
173
-        if( $reflection->isPublic() ) {
173
+        if ( $reflection->isPublic() ) {
174 174
             return parent::media_handle_upload( $url, $post_id, $post_data );
175 175
         }
176 176
 
Please login to merge, or discard this patch.
includes/class-common.php 1 patch
Spacing   +120 added lines, -120 removed lines patch added patch discarded remove patch
@@ -125,8 +125,8 @@  discard block
 block discarded – undo
125 125
 
126 126
 		$form = false;
127 127
 
128
-		if( $entry ) {
129
-			$form = GFAPI::get_form( $entry['form_id'] );
128
+		if ( $entry ) {
129
+			$form = GFAPI::get_form( $entry[ 'form_id' ] );
130 130
 		}
131 131
 
132 132
 		return $form;
@@ -192,12 +192,12 @@  discard block
 block discarded – undo
192 192
 
193 193
 			$has_transaction_data = \GV\Utils::get( $entry, $meta, false );
194 194
 
195
-			if( ! empty( $has_transaction_data ) ) {
195
+			if ( ! empty( $has_transaction_data ) ) {
196 196
 				break;
197 197
 			}
198 198
 		}
199 199
 
200
-		return (bool) $has_transaction_data;
200
+		return (bool)$has_transaction_data;
201 201
 	}
202 202
 
203 203
 	/**
@@ -235,7 +235,7 @@  discard block
 block discarded – undo
235 235
 
236 236
 		$results = GFAPI::get_entries( intval( $form_id ), $search_criteria, null, $paging );
237 237
 
238
-		$result = ( ! empty( $results ) && ! empty( $results[0]['id'] ) ) ? $results[0]['id'] : null;
238
+		$result = ( ! empty( $results ) && ! empty( $results[ 0 ][ 'id' ] ) ) ? $results[ 0 ][ 'id' ] : null;
239 239
 
240 240
 		return $result;
241 241
 	}
@@ -252,10 +252,10 @@  discard block
 block discarded – undo
252 252
 	 *
253 253
 	 * @return array Empty array if GFAPI class isn't available or no forms. Otherwise, the array of Forms
254 254
 	 */
255
-	public static function get_forms(  $active = true, $trash = false ) {
255
+	public static function get_forms( $active = true, $trash = false ) {
256 256
 		$forms = array();
257 257
 		if ( class_exists( 'GFAPI' ) ) {
258
-			if( 'any' === $active ) {
258
+			if ( 'any' === $active ) {
259 259
 				$active_forms = GFAPI::get_forms( true, $trash );
260 260
 				$inactive_forms = GFAPI::get_forms( false, $trash );
261 261
 				$forms = array_merge( array_filter( $active_forms ), array_filter( $inactive_forms ) );
@@ -286,9 +286,9 @@  discard block
 block discarded – undo
286 286
 		$has_post_fields = false;
287 287
 
288 288
 		if ( $form ) {
289
-			foreach ( $form['fields'] as $field ) {
290
-				if ( $include_parent_field || empty( $field['inputs'] ) ) {
291
-					$fields["{$field['id']}"] = array(
289
+			foreach ( $form[ 'fields' ] as $field ) {
290
+				if ( $include_parent_field || empty( $field[ 'inputs' ] ) ) {
291
+					$fields[ "{$field[ 'id' ]}" ] = array(
292 292
 						'label' => \GV\Utils::get( $field, 'label' ),
293 293
 						'parent' => null,
294 294
 						'type' => \GV\Utils::get( $field, 'type' ),
@@ -297,10 +297,10 @@  discard block
 block discarded – undo
297 297
 					);
298 298
 				}
299 299
 
300
-				if ( $add_default_properties && ! empty( $field['inputs'] ) ) {
301
-					foreach ( $field['inputs'] as $input ) {
300
+				if ( $add_default_properties && ! empty( $field[ 'inputs' ] ) ) {
301
+					foreach ( $field[ 'inputs' ] as $input ) {
302 302
 
303
-						if( ! empty( $input['isHidden'] ) ) {
303
+						if ( ! empty( $input[ 'isHidden' ] ) ) {
304 304
 							continue;
305 305
 						}
306 306
 
@@ -308,10 +308,10 @@  discard block
 block discarded – undo
308 308
                          * @hack
309 309
                          * In case of email/email confirmation, the input for email has the same id as the parent field
310 310
                          */
311
-						if( 'email' === $field['type'] && false === strpos( $input['id'], '.' ) ) {
311
+						if ( 'email' === $field[ 'type' ] && false === strpos( $input[ 'id' ], '.' ) ) {
312 312
                             continue;
313 313
                         }
314
-						$fields["{$input['id']}"] = array(
314
+						$fields[ "{$input[ 'id' ]}" ] = array(
315 315
 							'label' => \GV\Utils::get( $input, 'label' ),
316 316
 							'customLabel' => \GV\Utils::get( $input, 'customLabel' ),
317 317
 							'parent' => $field,
@@ -323,7 +323,7 @@  discard block
 block discarded – undo
323 323
 				}
324 324
 
325 325
 
326
-				if( GFCommon::is_product_field( $field['type'] ) ){
326
+				if ( GFCommon::is_product_field( $field[ 'type' ] ) ) {
327 327
 					$has_product_fields = true;
328 328
 				}
329 329
 
@@ -337,7 +337,7 @@  discard block
 block discarded – undo
337 337
 		 * @since 1.7
338 338
 		 */
339 339
 		if ( $has_post_fields ) {
340
-			$fields['post_id'] = array(
340
+			$fields[ 'post_id' ] = array(
341 341
 				'label' => __( 'Post ID', 'gravityview' ),
342 342
 				'type' => 'post_id',
343 343
 			);
@@ -350,11 +350,11 @@  discard block
 block discarded – undo
350 350
 			foreach ( $payment_fields as $payment_field ) {
351 351
 
352 352
 				// Either the field exists ($fields['shipping']) or the form explicitly contains a `shipping` field with numeric key
353
-				if( isset( $fields["{$payment_field->name}"] ) || GFCommon::get_fields_by_type( $form, $payment_field->name ) ) {
353
+				if ( isset( $fields[ "{$payment_field->name}" ] ) || GFCommon::get_fields_by_type( $form, $payment_field->name ) ) {
354 354
 					continue;
355 355
 				}
356 356
 
357
-				$fields["{$payment_field->name}"] = array(
357
+				$fields[ "{$payment_field->name}" ] = array(
358 358
 					'label' => $payment_field->label,
359 359
 					'desc' => $payment_field->description,
360 360
 					'type' => $payment_field->name,
@@ -386,9 +386,9 @@  discard block
 block discarded – undo
386 386
 
387 387
 		$fields = array();
388 388
 
389
-		foreach ( $extra_fields as $key => $field ){
390
-			if ( ! empty( $only_default_column ) && ! empty( $field['is_default_column'] ) ) {
391
-				$fields[ $key ] = array( 'label' => $field['label'], 'type' => 'entry_meta' );
389
+		foreach ( $extra_fields as $key => $field ) {
390
+			if ( ! empty( $only_default_column ) && ! empty( $field[ 'is_default_column' ] ) ) {
391
+				$fields[ $key ] = array( 'label' => $field[ 'label' ], 'type' => 'entry_meta' );
392 392
 			}
393 393
 		}
394 394
 
@@ -428,33 +428,33 @@  discard block
 block discarded – undo
428 428
 			'search_criteria' => null,
429 429
 			'sorting' => null,
430 430
 			'paging' => null,
431
-			'cache' => (isset( $passed_criteria['cache'] ) ? (bool) $passed_criteria['cache'] : true),
431
+			'cache' => ( isset( $passed_criteria[ 'cache' ] ) ? (bool)$passed_criteria[ 'cache' ] : true ),
432 432
 			'context_view_id' => null,
433 433
 		);
434 434
 
435 435
 		$criteria = wp_parse_args( $passed_criteria, $search_criteria_defaults );
436 436
 
437
-		if ( ! empty( $criteria['search_criteria']['field_filters'] ) ) {
438
-			foreach ( $criteria['search_criteria']['field_filters'] as &$filter ) {
437
+		if ( ! empty( $criteria[ 'search_criteria' ][ 'field_filters' ] ) ) {
438
+			foreach ( $criteria[ 'search_criteria' ][ 'field_filters' ] as &$filter ) {
439 439
 
440 440
 				if ( ! is_array( $filter ) ) {
441 441
 					continue;
442 442
 				}
443 443
 
444 444
 				// By default, we want searches to be wildcard for each field.
445
-				$filter['operator'] = empty( $filter['operator'] ) ? 'contains' : $filter['operator'];
445
+				$filter[ 'operator' ] = empty( $filter[ 'operator' ] ) ? 'contains' : $filter[ 'operator' ];
446 446
 
447 447
 				/**
448 448
 				 * @filter `gravityview_search_operator` Modify the search operator for the field (contains, is, isnot, etc)
449 449
 				 * @param string $operator Existing search operator
450 450
 				 * @param array $filter array with `key`, `value`, `operator`, `type` keys
451 451
 				 */
452
-				$filter['operator'] = apply_filters( 'gravityview_search_operator', $filter['operator'], $filter );
452
+				$filter[ 'operator' ] = apply_filters( 'gravityview_search_operator', $filter[ 'operator' ], $filter );
453 453
 			}
454 454
 
455 455
 			// don't send just the [mode] without any field filter.
456
-			if( count( $criteria['search_criteria']['field_filters'] ) === 1 && array_key_exists( 'mode' , $criteria['search_criteria']['field_filters'] ) ) {
457
-				unset( $criteria['search_criteria']['field_filters']['mode'] );
456
+			if ( count( $criteria[ 'search_criteria' ][ 'field_filters' ] ) === 1 && array_key_exists( 'mode', $criteria[ 'search_criteria' ][ 'field_filters' ] ) ) {
457
+				unset( $criteria[ 'search_criteria' ][ 'field_filters' ][ 'mode' ] );
458 458
 			}
459 459
 
460 460
 		}
@@ -465,33 +465,33 @@  discard block
 block discarded – undo
465 465
 		 * Prepare date formats to be in Gravity Forms DB format;
466 466
 		 * $passed_criteria may include date formats incompatible with Gravity Forms.
467 467
 		 */
468
-		foreach ( array('start_date', 'end_date' ) as $key ) {
468
+		foreach ( array( 'start_date', 'end_date' ) as $key ) {
469 469
 
470
-			if ( ! empty( $criteria['search_criteria'][ $key ] ) ) {
470
+			if ( ! empty( $criteria[ 'search_criteria' ][ $key ] ) ) {
471 471
 
472 472
 				// Use date_create instead of new DateTime so it returns false if invalid date format.
473
-				$date = date_create( $criteria['search_criteria'][ $key ] );
473
+				$date = date_create( $criteria[ 'search_criteria' ][ $key ] );
474 474
 
475 475
 				if ( $date ) {
476 476
 					// Gravity Forms wants dates in the `Y-m-d H:i:s` format.
477
-					$criteria['search_criteria'][ $key ] = $date->format( 'Y-m-d H:i:s' );
477
+					$criteria[ 'search_criteria' ][ $key ] = $date->format( 'Y-m-d H:i:s' );
478 478
 				} else {
479
-					gravityview()->log->error( '{key} Date format not valid:', array( 'key' => $key, $criteria['search_criteria'][ $key ] ) );
479
+					gravityview()->log->error( '{key} Date format not valid:', array( 'key' => $key, $criteria[ 'search_criteria' ][ $key ] ) );
480 480
 
481 481
 					// If it's an invalid date, unset it. Gravity Forms freaks out otherwise.
482
-					unset( $criteria['search_criteria'][ $key ] );
482
+					unset( $criteria[ 'search_criteria' ][ $key ] );
483 483
 				}
484 484
 			}
485 485
 		}
486 486
 
487
-		if ( empty( $criteria['context_view_id'] ) ) {
487
+		if ( empty( $criteria[ 'context_view_id' ] ) ) {
488 488
 			// Calculate the context view id and send it to the advanced filter
489 489
 			if ( GravityView_frontend::getInstance()->getSingleEntry() ) {
490
-				$criteria['context_view_id'] = GravityView_frontend::getInstance()->get_context_view_id();
490
+				$criteria[ 'context_view_id' ] = GravityView_frontend::getInstance()->get_context_view_id();
491 491
 			} else if ( class_exists( 'GravityView_View_Data' ) && GravityView_View_Data::getInstance() && GravityView_View_Data::getInstance()->has_multiple_views() ) {
492
-				$criteria['context_view_id'] = GravityView_frontend::getInstance()->get_context_view_id();
492
+				$criteria[ 'context_view_id' ] = GravityView_frontend::getInstance()->get_context_view_id();
493 493
 			} else if ( 'delete' === GFForms::get( 'action' ) ) {
494
-				$criteria['context_view_id'] = isset( $_GET['view_id'] ) ? intval( $_GET['view_id'] ) : null;
494
+				$criteria[ 'context_view_id' ] = isset( $_GET[ 'view_id' ] ) ? intval( $_GET[ 'view_id' ] ) : null;
495 495
 			}
496 496
 		}
497 497
 
@@ -501,7 +501,7 @@  discard block
 block discarded – undo
501 501
 		 * @param array $form_ids Forms to search
502 502
 		 * @param int $view_id ID of the view being used to search
503 503
 		 */
504
-		$criteria = apply_filters( 'gravityview_search_criteria', $criteria, $form_ids, $criteria['context_view_id'] );
504
+		$criteria = apply_filters( 'gravityview_search_criteria', $criteria, $form_ids, $criteria[ 'context_view_id' ] );
505 505
 
506 506
 		return (array)$criteria;
507 507
 	}
@@ -531,7 +531,7 @@  discard block
 block discarded – undo
531 531
 		/** Reduce # of database calls */
532 532
 		add_filter( 'gform_is_encrypted_field', '__return_false' );
533 533
 
534
-		if ( ! empty( $criteria['cache'] ) ) {
534
+		if ( ! empty( $criteria[ 'cache' ] ) ) {
535 535
 
536 536
 			$Cache = new GravityView_Cache( $form_ids, $criteria );
537 537
 
@@ -539,7 +539,7 @@  discard block
 block discarded – undo
539 539
 
540 540
 				// Still update the total count when using cached results
541 541
 				if ( ! is_null( $total ) ) {
542
-					$total = GFAPI::count_entries( $form_ids, $criteria['search_criteria'] );
542
+					$total = GFAPI::count_entries( $form_ids, $criteria[ 'search_criteria' ] );
543 543
 				}
544 544
 
545 545
 				$return = $entries;
@@ -560,9 +560,9 @@  discard block
 block discarded – undo
560 560
 			$entries = apply_filters( 'gravityview_before_get_entries', null, $criteria, $passed_criteria, $total );
561 561
 
562 562
 			// No entries returned from gravityview_before_get_entries
563
-			if( is_null( $entries ) ) {
563
+			if ( is_null( $entries ) ) {
564 564
 
565
-				$entries = GFAPI::get_entries( $form_ids, $criteria['search_criteria'], $criteria['sorting'], $criteria['paging'], $total );
565
+				$entries = GFAPI::get_entries( $form_ids, $criteria[ 'search_criteria' ], $criteria[ 'sorting' ], $criteria[ 'paging' ], $total );
566 566
 
567 567
 				if ( is_wp_error( $entries ) ) {
568 568
 					gravityview()->log->error( '{error}', array( 'error' => $entries->get_error_message(), 'data' => $entries ) );
@@ -573,7 +573,7 @@  discard block
 block discarded – undo
573 573
 				}
574 574
 			}
575 575
 
576
-			if ( ! empty( $criteria['cache'] ) && isset( $Cache ) ) {
576
+			if ( ! empty( $criteria[ 'cache' ] ) && isset( $Cache ) ) {
577 577
 
578 578
 				// Cache results
579 579
 				$Cache->set( $entries, 'entries' );
@@ -680,12 +680,12 @@  discard block
 block discarded – undo
680 680
 		 */
681 681
 		$check_entry_display = apply_filters( 'gravityview/common/get_entry/check_entry_display', $check_entry_display, $entry );
682 682
 
683
-		if( $check_entry_display ) {
683
+		if ( $check_entry_display ) {
684 684
 			// Is the entry allowed
685 685
 			$entry = self::check_entry_display( $entry );
686 686
 		}
687 687
 
688
-		if( is_wp_error( $entry ) ) {
688
+		if ( is_wp_error( $entry ) ) {
689 689
 			gravityview()->log->error( '{error}', array( 'error' => $entry->get_error_message() ) );
690 690
 			return false;
691 691
 		}
@@ -719,12 +719,12 @@  discard block
 block discarded – undo
719 719
 
720 720
 		$value = false;
721 721
 
722
-		if( 'context' === $val1 ) {
722
+		if ( 'context' === $val1 ) {
723 723
 
724 724
 			$matching_contexts = array( $val2 );
725 725
 
726 726
 			// We allow for non-standard contexts.
727
-			switch( $val2 ) {
727
+			switch ( $val2 ) {
728 728
 				// Check for either single or edit
729 729
 				case 'singular':
730 730
 					$matching_contexts = array( 'single', 'edit' );
@@ -767,18 +767,18 @@  discard block
 block discarded – undo
767 767
 				$json_val_1 = json_decode( $val1, true );
768 768
 				$json_val_2 = json_decode( $val2, true );
769 769
 
770
-				if( ! empty( $json_val_1 ) || ! empty( $json_val_2 ) ) {
770
+				if ( ! empty( $json_val_1 ) || ! empty( $json_val_2 ) ) {
771 771
 
772 772
 					$json_in = false;
773
-					$json_val_1 = $json_val_1 ? (array) $json_val_1 : array( $val1 );
774
-					$json_val_2 = $json_val_2 ? (array) $json_val_2 : array( $val2 );
773
+					$json_val_1 = $json_val_1 ? (array)$json_val_1 : array( $val1 );
774
+					$json_val_2 = $json_val_2 ? (array)$json_val_2 : array( $val2 );
775 775
 
776 776
 					// For JSON, we want to compare as "in" or "not in" rather than "contains"
777 777
 					foreach ( $json_val_1 as $item_1 ) {
778 778
 						foreach ( $json_val_2 as $item_2 ) {
779 779
 							$json_in = self::matches_operation( $item_1, $item_2, 'is' );
780 780
 
781
-							if( $json_in ) {
781
+							if ( $json_in ) {
782 782
 								break 2;
783 783
 							}
784 784
 						}
@@ -830,10 +830,10 @@  discard block
 block discarded – undo
830 830
 	public static function check_entry_display( $entry, $view = null ) {
831 831
 
832 832
 		if ( ! $entry || is_wp_error( $entry ) ) {
833
-			return new WP_Error('entry_not_found', 'Entry was not found.', $entry );
833
+			return new WP_Error( 'entry_not_found', 'Entry was not found.', $entry );
834 834
 		}
835 835
 
836
-		if ( empty( $entry['form_id'] ) ) {
836
+		if ( empty( $entry[ 'form_id' ] ) ) {
837 837
 			return new WP_Error( 'form_id_not_set', '[apply_filters_to_entry] Entry is empty!', $entry );
838 838
 		}
839 839
 
@@ -841,55 +841,55 @@  discard block
 block discarded – undo
841 841
 			'context_view_id' => $view ? $view->ID : null,
842 842
 		) );
843 843
 
844
-		if ( empty( $criteria['search_criteria'] ) || ! is_array( $criteria['search_criteria'] ) ) {
844
+		if ( empty( $criteria[ 'search_criteria' ] ) || ! is_array( $criteria[ 'search_criteria' ] ) ) {
845 845
 			gravityview()->log->debug( '[apply_filters_to_entry] Entry approved! No search criteria found:', array( 'data' => $criteria ) );
846 846
 			return $entry;
847 847
 		}
848 848
 
849 849
 		// Make sure the current View is connected to the same form as the Entry
850
-		if( ! empty( $criteria['context_view_id'] ) ) {
851
-			$context_view_id = intval( $criteria['context_view_id'] );
850
+		if ( ! empty( $criteria[ 'context_view_id' ] ) ) {
851
+			$context_view_id = intval( $criteria[ 'context_view_id' ] );
852 852
 			$context_form_id = gravityview_get_form_id( $context_view_id );
853
-			if( intval( $context_form_id ) !== intval( $entry['form_id'] ) ) {
854
-				return new WP_Error( 'view_id_not_match', sprintf( '[apply_filters_to_entry] Entry form ID does not match current View connected form ID:', $entry['form_id'] ), $criteria['context_view_id'] );
853
+			if ( intval( $context_form_id ) !== intval( $entry[ 'form_id' ] ) ) {
854
+				return new WP_Error( 'view_id_not_match', sprintf( '[apply_filters_to_entry] Entry form ID does not match current View connected form ID:', $entry[ 'form_id' ] ), $criteria[ 'context_view_id' ] );
855 855
 			}
856 856
 		}
857 857
 
858
-		$search_criteria = $criteria['search_criteria'];
858
+		$search_criteria = $criteria[ 'search_criteria' ];
859 859
 
860 860
 		// check entry status
861
-		if ( array_key_exists( 'status', $search_criteria ) && $search_criteria['status'] != $entry['status'] ) {
862
-			return new WP_Error( 'status_not_valid', sprintf( '[apply_filters_to_entry] Entry status - %s - is not valid according to filter:', $entry['status'] ), $search_criteria );
861
+		if ( array_key_exists( 'status', $search_criteria ) && $search_criteria[ 'status' ] != $entry[ 'status' ] ) {
862
+			return new WP_Error( 'status_not_valid', sprintf( '[apply_filters_to_entry] Entry status - %s - is not valid according to filter:', $entry[ 'status' ] ), $search_criteria );
863 863
 		}
864 864
 
865 865
 		// check entry date
866 866
 		// @todo: Does it make sense to apply the Date create filters to the single entry?
867 867
 
868 868
 		// field_filters
869
-		if ( empty( $search_criteria['field_filters'] ) || ! is_array( $search_criteria['field_filters'] ) ) {
869
+		if ( empty( $search_criteria[ 'field_filters' ] ) || ! is_array( $search_criteria[ 'field_filters' ] ) ) {
870 870
 			gravityview()->log->debug( '[apply_filters_to_entry] Entry approved! No field filters criteria found:', array( 'data' => $search_criteria ) );
871 871
 			return $entry;
872 872
 		}
873 873
 
874
-		$filters = $search_criteria['field_filters'];
874
+		$filters = $search_criteria[ 'field_filters' ];
875 875
 
876
-		$mode = array_key_exists( 'mode', $filters ) ? strtolower( $filters['mode'] ) : 'all';
876
+		$mode = array_key_exists( 'mode', $filters ) ? strtolower( $filters[ 'mode' ] ) : 'all';
877 877
 
878
-		$mode = $mode ? : 'all'; // If mode is an empty string, assume it's 'all'
878
+		$mode = $mode ?: 'all'; // If mode is an empty string, assume it's 'all'
879 879
 
880 880
 		// Prevent the mode from being processed below
881
-		unset( $filters['mode'] );
881
+		unset( $filters[ 'mode' ] );
882 882
 
883
-		$form = self::get_form( $entry['form_id'] );
883
+		$form = self::get_form( $entry[ 'form_id' ] );
884 884
 
885 885
 		foreach ( $filters as $filter ) {
886 886
 
887
-			if ( ! isset( $filter['key'] ) ) {
887
+			if ( ! isset( $filter[ 'key' ] ) ) {
888 888
 				gravityview()->log->debug( '[apply_filters_to_entry] Filter key not set: {filter}', array( 'filter' => $filter ) );
889 889
 				continue;
890 890
 			}
891 891
 
892
-			$k = $filter['key'];
892
+			$k = $filter[ 'key' ];
893 893
 
894 894
 			$field = self::get_field( $form, $k );
895 895
 
@@ -897,14 +897,14 @@  discard block
 block discarded – undo
897 897
 				$field_value = isset( $entry[ $k ] ) ? $entry[ $k ] : null;
898 898
 				$field = $k;
899 899
 			} else {
900
-				$field_value  = GFFormsModel::get_lead_field_value( $entry, $field );
900
+				$field_value = GFFormsModel::get_lead_field_value( $entry, $field );
901 901
 				 // If it's a complex field, then fetch the input's value, if exists at the current key. Otherwise, let GF handle it
902 902
 				$field_value = ( is_array( $field_value ) && isset( $field_value[ $k ] ) ) ? \GV\Utils::get( $field_value, $k ) : $field_value;
903 903
 			}
904 904
 
905
-			$operator = isset( $filter['operator'] ) ? strtolower( $filter['operator'] ) : 'is';
905
+			$operator = isset( $filter[ 'operator' ] ) ? strtolower( $filter[ 'operator' ] ) : 'is';
906 906
 
907
-			$is_value_match = GravityView_GFFormsModel::is_value_match( $field_value, $filter['value'], $operator, $field );
907
+			$is_value_match = GravityView_GFFormsModel::is_value_match( $field_value, $filter[ 'value' ], $operator, $field );
908 908
 
909 909
 			// Any match is all we need to know
910 910
 			if ( $is_value_match && 'any' === $mode ) {
@@ -913,7 +913,7 @@  discard block
 block discarded – undo
913 913
 
914 914
 			// Any failed match is a total fail
915 915
 			if ( ! $is_value_match && 'all' === $mode ) {
916
-				return new WP_Error('failed_criteria', '[apply_filters_to_entry] Entry cannot be displayed. Failed a criterium for ALL mode', $filter );
916
+				return new WP_Error( 'failed_criteria', '[apply_filters_to_entry] Entry cannot be displayed. Failed a criterium for ALL mode', $filter );
917 917
 			}
918 918
 		}
919 919
 
@@ -923,7 +923,7 @@  discard block
 block discarded – undo
923 923
 			gravityview()->log->debug( '[apply_filters_to_entry] Entry approved: all conditions were met' );
924 924
 			return $entry;
925 925
 		} else {
926
-			return new WP_Error('failed_any_criteria', '[apply_filters_to_entry] Entry cannot be displayed. Failed all the criteria for ANY mode', $filters );
926
+			return new WP_Error( 'failed_any_criteria', '[apply_filters_to_entry] Entry cannot be displayed. Failed all the criteria for ANY mode', $filters );
927 927
 		}
928 928
 
929 929
 	}
@@ -964,18 +964,18 @@  discard block
 block discarded – undo
964 964
 		 * Gravity Forms code to adjust date to locally-configured Time Zone
965 965
 		 * @see GFCommon::format_date() for original code
966 966
 		 */
967
-		$date_gmt_time   = mysql2date( 'G', $date_string );
967
+		$date_gmt_time = mysql2date( 'G', $date_string );
968 968
 		$date_local_timestamp = GFCommon::get_local_timestamp( $date_gmt_time );
969 969
 
970
-		$format  = \GV\Utils::get( $atts, 'format' );
971
-		$is_human  = ! empty( $atts['human'] );
972
-		$is_diff  = ! empty( $atts['diff'] );
973
-		$is_raw = ! empty( $atts['raw'] );
974
-		$is_timestamp = ! empty( $atts['timestamp'] );
975
-		$include_time = ! empty( $atts['time'] );
970
+		$format = \GV\Utils::get( $atts, 'format' );
971
+		$is_human = ! empty( $atts[ 'human' ] );
972
+		$is_diff = ! empty( $atts[ 'diff' ] );
973
+		$is_raw = ! empty( $atts[ 'raw' ] );
974
+		$is_timestamp = ! empty( $atts[ 'timestamp' ] );
975
+		$include_time = ! empty( $atts[ 'time' ] );
976 976
 
977 977
 		// If we're using time diff, we want to have a different default format
978
-		if( empty( $format ) ) {
978
+		if ( empty( $format ) ) {
979 979
 			/* translators: %s: relative time from now, used for generic date comparisons. "1 day ago", or "20 seconds ago" */
980 980
 			$format = $is_diff ? esc_html__( '%s ago', 'gravityview' ) : get_option( 'date_format' );
981 981
 		}
@@ -983,7 +983,7 @@  discard block
 block discarded – undo
983 983
 		// If raw was specified, don't modify the stored value
984 984
 		if ( $is_raw ) {
985 985
 			$formatted_date = $date_string;
986
-		} elseif( $is_timestamp ) {
986
+		} elseif ( $is_timestamp ) {
987 987
 			$formatted_date = $date_local_timestamp;
988 988
 		} elseif ( $is_diff ) {
989 989
 			$formatted_date = sprintf( $format, human_time_diff( $date_gmt_time ) );
@@ -1017,7 +1017,7 @@  discard block
 block discarded – undo
1017 1017
 
1018 1018
 		$label = \GV\Utils::get( $field, 'label' );
1019 1019
 
1020
-		if( floor( $field_id ) !== floatval( $field_id ) ) {
1020
+		if ( floor( $field_id ) !== floatval( $field_id ) ) {
1021 1021
 			$label = GFFormsModel::get_choice_text( $field, $field_value, $field_id );
1022 1022
 		}
1023 1023
 
@@ -1045,7 +1045,7 @@  discard block
 block discarded – undo
1045 1045
 			$form = GFAPI::get_form( $form );
1046 1046
 		}
1047 1047
 
1048
-		if ( class_exists( 'GFFormsModel' ) ){
1048
+		if ( class_exists( 'GFFormsModel' ) ) {
1049 1049
 			return GFFormsModel::get_field( $form, $field_id );
1050 1050
 		} else {
1051 1051
 			return null;
@@ -1092,19 +1092,19 @@  discard block
 block discarded – undo
1092 1092
 			$shortcodes = array();
1093 1093
 
1094 1094
 			preg_match_all( '/' . get_shortcode_regex() . '/s', $content, $matches, PREG_SET_ORDER );
1095
-			if ( empty( $matches ) ){
1095
+			if ( empty( $matches ) ) {
1096 1096
 				return false;
1097 1097
 			}
1098 1098
 
1099 1099
 			foreach ( $matches as $shortcode ) {
1100
-				if ( $tag === $shortcode[2] ) {
1100
+				if ( $tag === $shortcode[ 2 ] ) {
1101 1101
 
1102 1102
 					// Changed this to $shortcode instead of true so we get the parsed atts.
1103
-					$shortcodes[] = $shortcode;
1103
+					$shortcodes[ ] = $shortcode;
1104 1104
 
1105
-				} else if ( isset( $shortcode[5] ) && $results = self::has_shortcode_r( $shortcode[5], $tag ) ) {
1106
-					foreach( $results as $result ) {
1107
-						$shortcodes[] = $result;
1105
+				} else if ( isset( $shortcode[ 5 ] ) && $results = self::has_shortcode_r( $shortcode[ 5 ], $tag ) ) {
1106
+					foreach ( $results as $result ) {
1107
+						$shortcodes[ ] = $result;
1108 1108
 					}
1109 1109
 				}
1110 1110
 			}
@@ -1136,7 +1136,7 @@  discard block
 block discarded – undo
1136 1136
 			'post_type'      => 'gravityview',
1137 1137
 			'posts_per_page' => 100,
1138 1138
 			'meta_key'       => '_gravityview_form_id',
1139
-			'meta_value'     => (int) $form_id,
1139
+			'meta_value'     => (int)$form_id,
1140 1140
 		);
1141 1141
 		$args     = wp_parse_args( $args, $defaults );
1142 1142
 		$views    = get_posts( $args );
@@ -1148,21 +1148,21 @@  discard block
 block discarded – undo
1148 1148
 
1149 1149
 			$data = unserialize( $view->meta_value );
1150 1150
 
1151
-			if( ! $data || ! is_array( $data ) ) {
1151
+			if ( ! $data || ! is_array( $data ) ) {
1152 1152
 				continue;
1153 1153
 			}
1154 1154
 
1155 1155
 			foreach ( $data as $datum ) {
1156
-				if ( ! empty( $datum[2] ) && (int) $datum[2] === (int) $form_id ) {
1157
-					$joined_forms[] = $view->post_id;
1156
+				if ( ! empty( $datum[ 2 ] ) && (int)$datum[ 2 ] === (int)$form_id ) {
1157
+					$joined_forms[ ] = $view->post_id;
1158 1158
 				}
1159 1159
 			}
1160 1160
 		}
1161 1161
 
1162 1162
 		if ( $joined_forms ) {
1163
-			$joined_args  = array(
1163
+			$joined_args = array(
1164 1164
 				'post_type'      => 'gravityview',
1165
-				'posts_per_page' => $args['posts_per_page'],
1165
+				'posts_per_page' => $args[ 'posts_per_page' ],
1166 1166
 				'post__in'       => $joined_forms,
1167 1167
 			);
1168 1168
 			$views = array_merge( $views, get_posts( $joined_args ) );
@@ -1318,7 +1318,7 @@  discard block
 block discarded – undo
1318 1318
 
1319 1319
 		$directory_widgets = wp_parse_args( $view_widgets, $defaults );
1320 1320
 
1321
-		if( $json_decode ) {
1321
+		if ( $json_decode ) {
1322 1322
 			$directory_widgets = gv_map_deep( $directory_widgets, 'gv_maybe_json_decode' );
1323 1323
 		}
1324 1324
 
@@ -1334,7 +1334,7 @@  discard block
 block discarded – undo
1334 1334
 	 * @return string         html
1335 1335
 	 */
1336 1336
 	public static function get_sortable_fields( $formid, $current = '' ) {
1337
-		$output = '<option value="" ' . selected( '', $current, false ).'>' . esc_html__( 'Default', 'gravityview' ) .'</option>';
1337
+		$output = '<option value="" ' . selected( '', $current, false ) . '>' . esc_html__( 'Default', 'gravityview' ) . '</option>';
1338 1338
 
1339 1339
 		if ( empty( $formid ) ) {
1340 1340
 			return $output;
@@ -1347,11 +1347,11 @@  discard block
 block discarded – undo
1347 1347
 			$blacklist_field_types = apply_filters( 'gravityview_blacklist_field_types', array( 'list', 'textarea' ), null );
1348 1348
 
1349 1349
 			foreach ( $fields as $id => $field ) {
1350
-				if ( in_array( $field['type'], $blacklist_field_types ) ) {
1350
+				if ( in_array( $field[ 'type' ], $blacklist_field_types ) ) {
1351 1351
 					continue;
1352 1352
 				}
1353 1353
 
1354
-				$output .= '<option value="'. $id .'" '. selected( $id, $current, false ).'>'. esc_attr( $field['label'] ) .'</option>';
1354
+				$output .= '<option value="' . $id . '" ' . selected( $id, $current, false ) . '>' . esc_attr( $field[ 'label' ] ) . '</option>';
1355 1355
 			}
1356 1356
 		}
1357 1357
 
@@ -1386,9 +1386,9 @@  discard block
 block discarded – undo
1386 1386
 		$blacklist_field_types = apply_filters( 'gravityview_blacklist_field_types', $blacklist, NULL );
1387 1387
 
1388 1388
 		// TODO: Convert to using array_filter
1389
-		foreach( $fields as $id => $field ) {
1389
+		foreach ( $fields as $id => $field ) {
1390 1390
 
1391
-			if( in_array( $field['type'], $blacklist_field_types ) ) {
1391
+			if ( in_array( $field[ 'type' ], $blacklist_field_types ) ) {
1392 1392
 				unset( $fields[ $id ] );
1393 1393
 			}
1394 1394
 		}
@@ -1429,14 +1429,14 @@  discard block
 block discarded – undo
1429 1429
 	 * @param  int|array  $field field key or field array
1430 1430
 	 * @return boolean
1431 1431
 	 */
1432
-	public static function is_field_numeric(  $form = null, $field = '' ) {
1432
+	public static function is_field_numeric( $form = null, $field = '' ) {
1433 1433
 
1434 1434
 		if ( ! is_array( $form ) && ! is_array( $field ) ) {
1435 1435
 			$form = self::get_form( $form );
1436 1436
 		}
1437 1437
 
1438 1438
 		// If entry meta, it's a string. Otherwise, numeric
1439
-		if( ! is_numeric( $field ) && is_string( $field ) ) {
1439
+		if ( ! is_numeric( $field ) && is_string( $field ) ) {
1440 1440
 			$type = $field;
1441 1441
 		} else {
1442 1442
 			$type = self::get_field_type( $form, $field );
@@ -1450,9 +1450,9 @@  discard block
 block discarded – undo
1450 1450
 		$numeric_types = apply_filters( 'gravityview/common/numeric_types', array( 'number', 'time' ) );
1451 1451
 
1452 1452
 		// Defer to GravityView_Field setting, if the field type is registered and `is_numeric` is true
1453
-		if( $gv_field = GravityView_Fields::get( $type ) ) {
1454
-			if( true === $gv_field->is_numeric ) {
1455
-				$numeric_types[] = $gv_field->is_numeric;
1453
+		if ( $gv_field = GravityView_Fields::get( $type ) ) {
1454
+			if ( true === $gv_field->is_numeric ) {
1455
+				$numeric_types[ ] = $gv_field->is_numeric;
1456 1456
 			}
1457 1457
 		}
1458 1458
 
@@ -1602,18 +1602,18 @@  discard block
 block discarded – undo
1602 1602
 		$final_atts = array_filter( $final_atts );
1603 1603
 
1604 1604
 		// If the href wasn't passed as an attribute, use the value passed to the function
1605
-		if ( empty( $final_atts['href'] ) && ! empty( $href ) ) {
1606
-			$final_atts['href'] = $href;
1605
+		if ( empty( $final_atts[ 'href' ] ) && ! empty( $href ) ) {
1606
+			$final_atts[ 'href' ] = $href;
1607 1607
 		}
1608 1608
 
1609
-		$final_atts['href'] = esc_url_raw( $href );
1609
+		$final_atts[ 'href' ] = esc_url_raw( $href );
1610 1610
 
1611 1611
 		/**
1612 1612
 		 * Fix potential security issue with target=_blank
1613 1613
 		 * @see https://dev.to/ben/the-targetblank-vulnerability-by-example
1614 1614
 		 */
1615
-		if( '_blank' === \GV\Utils::get( $final_atts, 'target' ) ) {
1616
-			$final_atts['rel'] = trim( \GV\Utils::get( $final_atts, 'rel', '' ) . ' noopener noreferrer' );
1615
+		if ( '_blank' === \GV\Utils::get( $final_atts, 'target' ) ) {
1616
+			$final_atts[ 'rel' ] = trim( \GV\Utils::get( $final_atts, 'rel', '' ) . ' noopener noreferrer' );
1617 1617
 		}
1618 1618
 
1619 1619
 		// Sort the attributes alphabetically, to help testing
@@ -1625,7 +1625,7 @@  discard block
 block discarded – undo
1625 1625
 			$output .= sprintf( ' %s="%s"', $attr, esc_attr( $value ) );
1626 1626
 		}
1627 1627
 
1628
-		if( '' !== $output ) {
1628
+		if ( '' !== $output ) {
1629 1629
 			$output = '<a' . $output . '>' . $anchor_text . '</a>';
1630 1630
 		}
1631 1631
 
@@ -1652,7 +1652,7 @@  discard block
 block discarded – undo
1652 1652
 			if ( is_array( $value ) && isset( $merged[ $key ] ) && is_array( $merged[ $key ] ) ) {
1653 1653
 				$merged[ $key ] = self::array_merge_recursive_distinct( $merged[ $key ], $value );
1654 1654
 			} else if ( is_numeric( $key ) && isset( $merged[ $key ] ) ) {
1655
-				$merged[] = $value;
1655
+				$merged[ ] = $value;
1656 1656
 			} else {
1657 1657
 				$merged[ $key ] = $value;
1658 1658
 			}
@@ -1685,7 +1685,7 @@  discard block
 block discarded – undo
1685 1685
 		 * `$context` is where are we using this information (e.g. change_entry_creator, search_widget ..)
1686 1686
 		 * @param array $settings Settings array, with `number` key defining the # of users to display
1687 1687
 		 */
1688
-		$get_users_settings = apply_filters( 'gravityview/get_users/'. $context, apply_filters( 'gravityview_change_entry_creator_user_parameters', $get_users_settings ) );
1688
+		$get_users_settings = apply_filters( 'gravityview/get_users/' . $context, apply_filters( 'gravityview_change_entry_creator_user_parameters', $get_users_settings ) );
1689 1689
 
1690 1690
 		return get_users( $get_users_settings );
1691 1691
 	}
@@ -1705,11 +1705,11 @@  discard block
 block discarded – undo
1705 1705
     public static function generate_notice( $notice, $class = '', $cap = '', $object_id = null ) {
1706 1706
 
1707 1707
     	// If $cap is defined, only show notice if user has capability
1708
-    	if( $cap && ! GVCommon::has_cap( $cap, $object_id ) ) {
1708
+    	if ( $cap && ! GVCommon::has_cap( $cap, $object_id ) ) {
1709 1709
     		return '';
1710 1710
 	    }
1711 1711
 
1712
-        return '<div class="gv-notice '.gravityview_sanitize_html_class( $class ) .'">'. $notice .'</div>';
1712
+        return '<div class="gv-notice ' . gravityview_sanitize_html_class( $class ) . '">' . $notice . '</div>';
1713 1713
     }
1714 1714
 
1715 1715
 	/**
Please login to merge, or discard this patch.
includes/fields/class-gravityview-field-fileupload.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -24,16 +24,16 @@  discard block
 block discarded – undo
24 24
 
25 25
 	function field_options( $field_options, $template_id, $field_id, $context, $input_type ) {
26 26
 
27
-		unset( $field_options['search_filter'] );
27
+		unset( $field_options[ 'search_filter' ] );
28 28
 
29
-		if( 'edit' === $context ) {
29
+		if ( 'edit' === $context ) {
30 30
 			return $field_options;
31 31
 		}
32 32
 
33
-		$add_options['link_to_file'] = array(
33
+		$add_options[ 'link_to_file' ] = array(
34 34
 			'type' => 'checkbox',
35 35
 			'label' => __( 'Display as a Link:', 'gravityview' ),
36
-			'desc' => __('Display the uploaded files as links, rather than embedded content.', 'gravityview'),
36
+			'desc' => __( 'Display the uploaded files as links, rather than embedded content.', 'gravityview' ),
37 37
 			'value' => false,
38 38
 			'merge_tags' => false,
39 39
 		);
@@ -119,14 +119,14 @@  discard block
 block discarded – undo
119 119
 			$base_id = null;
120 120
 
121 121
 			$is_single = gravityview_get_context() === 'single';
122
-			$lightbox = ! empty( $gravityview_view->atts['lightbox'] );
122
+			$lightbox = ! empty( $gravityview_view->atts[ 'lightbox' ] );
123 123
 			$field_compat = $gravityview_view->getCurrentField();
124 124
 		}
125 125
 
126 126
 		$output_arr = array();
127 127
 
128 128
 		// Get an array of file paths for the field.
129
-		$file_paths = \GV\Utils::get( $field , 'multipleFiles' ) ? json_decode( $value ) : array( $value );
129
+		$file_paths = \GV\Utils::get( $field, 'multipleFiles' ) ? json_decode( $value ) : array( $value );
130 130
 
131 131
 		// The $value JSON was probably truncated; let's check lead_detail_long.
132 132
 		if ( ! is_array( $file_paths ) ) {
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 			$text = $rendered = null;
146 146
 
147 147
 			// If the site is HTTPS, use HTTPS
148
-			if ( function_exists('set_url_scheme') ) {
148
+			if ( function_exists( 'set_url_scheme' ) ) {
149 149
 				$file_path = set_url_scheme( $file_path );
150 150
 			}
151 151
 
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
 			$file_path_info = pathinfo( $file_path );
169 169
 
170 170
 			// If pathinfo() gave us the extension of the file, run the switch statement using that.
171
-			$extension = empty( $file_path_info['extension'] ) ? NULL : strtolower( $file_path_info['extension'] );
171
+			$extension = empty( $file_path_info[ 'extension' ] ) ? NULL : strtolower( $file_path_info[ 'extension' ] );
172 172
 
173 173
 			// Audio
174 174
 			if ( in_array( $extension, wp_get_audio_extensions() ) ) {
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
 					 */
183 183
 					$audio_settings = apply_filters( 'gravityview_audio_settings', array(
184 184
 						'src' => $file_path,
185
-						'class' => 'wp-audio-shortcode gv-audio gv-field-id-'.$field_settings['id']
185
+						'class' => 'wp-audio-shortcode gv-audio gv-field-id-' . $field_settings[ 'id' ]
186 186
 					), $context );
187 187
 
188 188
 					/**
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 					 */
207 207
 					$video_settings = apply_filters( 'gravityview_video_settings', array(
208 208
 						'src' => $file_path,
209
-						'class' => 'wp-video-shortcode gv-video gv-field-id-'.$field_settings['id']
209
+						'class' => 'wp-video-shortcode gv-video gv-field-id-' . $field_settings[ 'id' ]
210 210
 					), $context );
211 211
 
212 212
 					/**
@@ -226,8 +226,8 @@  discard block
 block discarded – undo
226 226
 			} else if ( in_array( $extension, array( 'jpg', 'jpeg', 'jpe', 'gif', 'png' ) ) ) {
227 227
 				$image_atts = array(
228 228
 					'src' => $file_path,
229
-					'class' => 'gv-image gv-field-id-'.$field_settings['id'],
230
-					'alt' => $field_settings['label'],
229
+					'class' => 'gv-image gv-field-id-' . $field_settings[ 'id' ],
230
+					'alt' => $field_settings[ 'label' ],
231 231
 					'width' => ( $is_single ? NULL : 250 )
232 232
 				);
233 233
 
@@ -241,11 +241,11 @@  discard block
 block discarded – undo
241 241
 
242 242
 				$image = new GravityView_Image( $image_atts );
243 243
 
244
-				$entry_slug = GravityView_API::get_entry_slug( $entry['id'], $entry );
244
+				$entry_slug = GravityView_API::get_entry_slug( $entry[ 'id' ], $entry );
245 245
 
246 246
 				$text = $image->html();
247 247
 
248
-				if ( $lightbox && empty( $field_settings['show_as_link'] ) ) {
248
+				if ( $lightbox && empty( $field_settings[ 'show_as_link' ] ) ) {
249 249
 					$lightbox_link_atts = array(
250 250
 						'rel' => sprintf( "%s-%s", $gv_class, $entry_slug ),
251 251
 						'class' => 'thickbox',
@@ -269,8 +269,8 @@  discard block
 block discarded – undo
269 269
 			$disable_wrapped_link = apply_filters( 'gravityview/fields/fileupload/disable_link', false, $field_compat, $context );
270 270
 
271 271
 			// Output textualized content where 
272
-			if ( ! $disable_wrapped_link && ( ! empty( $field_settings['link_to_file'] ) && empty( $field_settings['show_as_link'] ) ) ) {
273
-				$content = empty( $text ) ? $file_path_info['basename'] : $text;
272
+			if ( ! $disable_wrapped_link && ( ! empty( $field_settings[ 'link_to_file' ] ) && empty( $field_settings[ 'show_as_link' ] ) ) ) {
273
+				$content = empty( $text ) ? $file_path_info[ 'basename' ] : $text;
274 274
 
275 275
 				/**
276 276
 				 * Modify the link text (defaults to the file name)
@@ -295,10 +295,10 @@  discard block
 block discarded – undo
295 295
 
296 296
 				$content = gravityview_get_link( $file_path, $content, $link_atts );
297 297
 			} else {
298
-				$content = empty( $rendered ) ? ( empty( $text ) ? $file_path_info['basename'] : $text ) : $rendered;
298
+				$content = empty( $rendered ) ? ( empty( $text ) ? $file_path_info[ 'basename' ] : $text ) : $rendered;
299 299
 			}
300 300
 
301
-			$output_arr[] = array(
301
+			$output_arr[ ] = array(
302 302
 				'file_path' => $file_path,
303 303
 				'content' => $content
304 304
 			);
Please login to merge, or discard this patch.
future/includes/class-gv-shortcode-gravityview.php 1 patch
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -41,8 +41,8 @@  discard block
 block discarded – undo
41 41
 			'detail' => null,
42 42
 		) );
43 43
 		
44
-		if ( ! $view_id = $atts['id'] ? : $atts['view_id'] ) {
45
-			if ( $atts['detail'] && $view = $request->is_view() ) {
44
+		if ( ! $view_id = $atts[ 'id' ] ?: $atts[ 'view_id' ] ) {
45
+			if ( $atts[ 'detail' ] && $view = $request->is_view() ) {
46 46
 				$view_id = $view->ID;
47 47
 			}
48 48
 		}
@@ -110,12 +110,12 @@  discard block
 block discarded – undo
110 110
 			}
111 111
 		}
112 112
 
113
-		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap('gravityview_moderate_entries', $view->ID );
113
+		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap( 'gravityview_moderate_entries', $view->ID );
114 114
 
115 115
 		/**
116 116
 		 * View details.
117 117
 		 */
118
-		if ( $atts['detail'] ) {
118
+		if ( $atts[ 'detail' ] ) {
119 119
 			$entries = $view->get_entries( $request );
120 120
 			return self::_return( $this->detail( $view, $entries, $atts ) );
121 121
 
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
 				return self::_return( '' );
133 133
 			}
134 134
 
135
-			if ( $entry['status'] != 'active' ) {
135
+			if ( $entry[ 'status' ] != 'active' ) {
136 136
 				gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
137 137
 				return self::_return( __( 'You are not allowed to view this content.', 'gravityview' ) );
138 138
 			}
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 			}
144 144
 
145 145
 			if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
146
-				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
146
+				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
147 147
 					gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
148 148
 					return self::_return( __( 'You are not allowed to view this content.', 'gravityview' ) );
149 149
 				}
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
 				return self::_return( '' );
164 164
 			}
165 165
 
166
-			if ( $entry['status'] != 'active' ) {
166
+			if ( $entry[ 'status' ] != 'active' ) {
167 167
 				gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
168 168
 				return self::_return( __( 'You are not allowed to view this content.', 'gravityview' ) );
169 169
 			}
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
 			}
175 175
 
176 176
 			if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
177
-				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
177
+				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
178 178
 					gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
179 179
 					return self::_return( __( 'You are not allowed to view this content.', 'gravityview' ) );
180 180
 				}
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
 
183 183
 			$error = \GVCommon::check_entry_display( $entry->as_entry(), $view );
184 184
 
185
-			if( is_wp_error( $error ) ) {
185
+			if ( is_wp_error( $error ) ) {
186 186
 				gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing: {message}', array( 'entry_id' => $entry->ID, 'message' => $error->get_error_message() ) );
187 187
 				return self::_return( __( 'You are not allowed to view this content.', 'gravityview' ) );
188 188
 			}
@@ -198,10 +198,10 @@  discard block
 block discarded – undo
198 198
 				
199 199
 				// Mock the request with the actual View, not the global one
200 200
 				$mock_request = new \GV\Mock_Request();
201
-				$mock_request->returns['is_view'] = $view;
202
-				$mock_request->returns['is_entry'] = $request->is_entry();
203
-				$mock_request->returns['is_edit_entry'] = $request->is_edit_entry();
204
-				$mock_request->returns['is_search'] = $request->is_search();
201
+				$mock_request->returns[ 'is_view' ] = $view;
202
+				$mock_request->returns[ 'is_entry' ] = $request->is_entry();
203
+				$mock_request->returns[ 'is_edit_entry' ] = $request->is_edit_entry();
204
+				$mock_request->returns[ 'is_search' ] = $request->is_search();
205 205
 
206 206
 				$request = $mock_request;
207 207
 			}
@@ -237,16 +237,16 @@  discard block
 block discarded – undo
237 237
 		$filtered_atts = shortcode_atts( $supported_atts, $passed_atts, 'gravityview' );
238 238
 
239 239
 		// Only keep the passed attributes after making sure that they're valid pairs
240
-		$filtered_atts = array_intersect_key( (array) $passed_atts, $filtered_atts );
240
+		$filtered_atts = array_intersect_key( (array)$passed_atts, $filtered_atts );
241 241
 
242 242
 		$atts = array();
243 243
 
244
-		foreach( $filtered_atts as $key => $passed_value ) {
244
+		foreach ( $filtered_atts as $key => $passed_value ) {
245 245
 
246 246
 			// Allow using GravityView merge tags in shortcode attributes, like {get} and {created_by}
247 247
 			$passed_value = \GravityView_Merge_Tags::replace_variables( $passed_value );
248 248
 
249
-			switch( $defaults[ $key ]['type'] ) {
249
+			switch ( $defaults[ $key ][ 'type' ] ) {
250 250
 
251 251
 				/**
252 252
 				 * Make sure number fields are numeric.
@@ -254,7 +254,7 @@  discard block
 block discarded – undo
254 254
 				 * @see http://php.net/manual/en/function.is-numeric.php#107326
255 255
 				 */
256 256
 				case 'number':
257
-					if( is_numeric( $passed_value ) ) {
257
+					if ( is_numeric( $passed_value ) ) {
258 258
 						$atts[ $key ] = ( $passed_value + 0 );
259 259
 					}
260 260
 					break;
@@ -269,8 +269,8 @@  discard block
 block discarded – undo
269 269
 				 */
270 270
 				case 'select':
271 271
 				case 'radio':
272
-					$options = isset( $defaults[ $key ]['choices'] ) ? $defaults[ $key ]['choices'] : $defaults[ $key ]['options'];
273
-					if( in_array( $passed_value, array_keys( $options ) ) ) {
272
+					$options = isset( $defaults[ $key ][ 'choices' ] ) ? $defaults[ $key ][ 'choices' ] : $defaults[ $key ][ 'options' ];
273
+					if ( in_array( $passed_value, array_keys( $options ) ) ) {
274 274
 						$atts[ $key ] = $passed_value;
275 275
 					}
276 276
 					break;
@@ -282,7 +282,7 @@  discard block
 block discarded – undo
282 282
 			}
283 283
 		}
284 284
 
285
-		$atts['detail'] = \GV\Utils::get( $passed_atts, 'detail', null );
285
+		$atts[ 'detail' ] = \GV\Utils::get( $passed_atts, 'detail', null );
286 286
 
287 287
 		return $atts;
288 288
 	}
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
 	private function detail( $view, $entries, $atts ) {
300 300
 		$output = '';
301 301
 
302
-		switch ( $key = $atts['detail'] ):
302
+		switch ( $key = $atts[ 'detail' ] ):
303 303
 			case 'total_entries':
304 304
 				$output = number_format_i18n( $entries->total() );
305 305
 				break;
Please login to merge, or discard this patch.
future/includes/class-gv-view.php 1 patch
Spacing   +25 added lines, -26 removed lines patch added patch discarded remove patch
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 		$supports = array( 'title', 'revisions' );
109 109
 
110 110
 		if ( $is_hierarchical ) {
111
-			$supports[] = 'page-attributes';
111
+			$supports[ ] = 'page-attributes';
112 112
 		}
113 113
 
114 114
 		/**
@@ -210,11 +210,11 @@  discard block
 block discarded – undo
210 210
 		$rule = array( sprintf( '%s/([^/]+)/csv/?', $slug ), 'index.php?gravityview=$matches[1]&csv=1', 'top' );
211 211
 
212 212
 		add_filter( 'query_vars', function( $query_vars ) { 
213
-			$query_vars[] = 'csv';
213
+			$query_vars[ ] = 'csv';
214 214
 			return $query_vars;
215 215
 		} );
216 216
 
217
-		if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[0] ] ) ) {
217
+		if ( ! isset( $wp_rewrite->extra_rules_top[ $rule[ 0 ] ] ) ) {
218 218
 			call_user_func_array( 'add_rewrite_rule', $rule );
219 219
 		}
220 220
 	}
@@ -282,13 +282,13 @@  discard block
 block discarded – undo
282 282
 			return $content;
283 283
 		}
284 284
 
285
-		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap('gravityview_moderate_entries', $view->ID );
285
+		$is_admin_and_can_view = $view->settings->get( 'admin_show_all_statuses' ) && \GVCommon::has_cap( 'gravityview_moderate_entries', $view->ID );
286 286
 
287 287
 		/**
288 288
 		 * Editing a single entry.
289 289
 		 */
290 290
 		if ( $entry = $request->is_edit_entry() ) {
291
-			if ( $entry['status'] != 'active' ) {
291
+			if ( $entry[ 'status' ] != 'active' ) {
292 292
 				gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
293 293
 				return __( 'You are not allowed to view this content.', 'gravityview' );
294 294
 			}
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
 			}
300 300
 
301 301
 			if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
302
-				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
302
+				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
303 303
 					gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
304 304
 					return __( 'You are not allowed to view this content.', 'gravityview' );
305 305
 				}
@@ -312,7 +312,7 @@  discard block
 block discarded – undo
312 312
 		 * Viewing a single entry.
313 313
 		 */
314 314
 		} else if ( $entry = $request->is_entry() ) {
315
-			if ( $entry['status'] != 'active' ) {
315
+			if ( $entry[ 'status' ] != 'active' ) {
316 316
 				gravityview()->log->notice( 'Entry ID #{entry_id} is not active', array( 'entry_id' => $entry->ID ) );
317 317
 				return __( 'You are not allowed to view this content.', 'gravityview' );
318 318
 			}
@@ -323,7 +323,7 @@  discard block
 block discarded – undo
323 323
 			}
324 324
 
325 325
 			if ( $view->settings->get( 'show_only_approved' ) && ! $is_admin_and_can_view ) {
326
-				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) )  ) {
326
+				if ( ! \GravityView_Entry_Approval_Status::is_approved( gform_get_meta( $entry->ID, \GravityView_Entry_Approval::meta_key ) ) ) {
327 327
 					gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing', array( 'entry_id' => $entry->ID ) );
328 328
 					return __( 'You are not allowed to view this content.', 'gravityview' );
329 329
 				}
@@ -331,7 +331,7 @@  discard block
 block discarded – undo
331 331
 
332 332
 			$error = \GVCommon::check_entry_display( $entry->as_entry(), $view );
333 333
 
334
-			if( is_wp_error( $error ) ) {
334
+			if ( is_wp_error( $error ) ) {
335 335
 				gravityview()->log->error( 'Entry ID #{entry_id} is not approved for viewing: {message}', array( 'entry_id' => $entry->ID, 'message' => $error->get_error_message() ) );
336 336
 				return __( 'You are not allowed to view this content.', 'gravityview' );
337 337
 			}
@@ -489,7 +489,7 @@  discard block
 block discarded – undo
489 489
 			$join_column    = is_numeric( $join_column ) ? GF_Field::by_id( $join, $join_column ) : Internal_Field( $join_column );
490 490
 			$join_on_column = is_numeric( $join_on_column ) ? GF_Field::by_id( $join_on, $join_on_column ) : Internal_Field( $join_on_column );
491 491
 
492
-			$joins [] = new Join( $join, $join_column, $join_on, $join_on_column );
492
+			$joins [ ] = new Join( $join, $join_column, $join_on, $join_on_column );
493 493
 		}
494 494
 
495 495
 		return $joins;
@@ -531,10 +531,10 @@  discard block
 block discarded – undo
531 531
 
532 532
 			list( $join, $join_column, $join_on, $join_on_column ) = $meta;
533 533
 
534
-			$forms_ids [] = GF_Form::by_id( $join_on );
534
+			$forms_ids [ ] = GF_Form::by_id( $join_on );
535 535
 		}
536 536
 
537
-		return ( !empty( $forms_ids) ) ? $forms_ids : null;
537
+		return ( ! empty( $forms_ids ) ) ? $forms_ids : null;
538 538
 	}
539 539
 
540 540
 	/**
@@ -565,7 +565,7 @@  discard block
 block discarded – undo
565 565
 		if ( ! $view->form ) {
566 566
 			gravityview()->log->error( 'View #{view_id} tried attaching non-existent Form #{form_id} to it.', array(
567 567
 				'view_id' => $view->ID,
568
-				'form_id' => $view->_gravityview_form_id ? : 0,
568
+				'form_id' => $view->_gravityview_form_id ?: 0,
569 569
 			) );
570 570
 		}
571 571
 
@@ -791,28 +791,27 @@  discard block
 block discarded – undo
791 791
 			 * @todo: Stop using _frontend and use something like $request->get_search_criteria() instead
792 792
 			 */
793 793
 			$parameters = \GravityView_frontend::get_view_entries_parameters( $this->settings->as_atts(), $this->form->ID );
794
-			$parameters['context_view_id'] = $this->ID;
794
+			$parameters[ 'context_view_id' ] = $this->ID;
795 795
 			$parameters = \GVCommon::calculate_get_entries_criteria( $parameters, $this->form->ID );
796 796
 
797 797
 			if ( $request instanceof REST\Request ) {
798 798
 				$atts = $this->settings->as_atts();
799 799
 				$paging_parameters = wp_parse_args( $request->get_paging(), array(
800
-						'paging' => array( 'page_size' => $atts['page_size'] ),
800
+						'paging' => array( 'page_size' => $atts[ 'page_size' ] ),
801 801
 					) );
802
-				$parameters['paging'] = $paging_parameters['paging'];
802
+				$parameters[ 'paging' ] = $paging_parameters[ 'paging' ];
803 803
 			}
804 804
 
805
-			$page = Utils::get( $parameters['paging'], 'current_page' ) ?
806
-				: ( ( ( $parameters['paging']['offset'] - $this->settings->get( 'offset' ) ) / $parameters['paging']['page_size'] ) + 1 );
805
+			$page = Utils::get( $parameters[ 'paging' ], 'current_page' ) ?: ( ( ( $parameters[ 'paging' ][ 'offset' ] - $this->settings->get( 'offset' ) ) / $parameters[ 'paging' ][ 'page_size' ] ) + 1 );
807 806
 
808 807
 			if ( gravityview()->plugin->supports( Plugin::FEATURE_GFQUERY ) ) {
809 808
 				/**
810 809
 				 * New \GF_Query stuff :)
811 810
 				 */
812
-				$query = new \GF_Query( $this->form->ID, $parameters['search_criteria'], $parameters['sorting'] );
811
+				$query = new \GF_Query( $this->form->ID, $parameters[ 'search_criteria' ], $parameters[ 'sorting' ] );
813 812
 
814
-				$query->limit( $parameters['paging']['page_size'] )
815
-					->offset( ( ( $page - 1 ) * $parameters['paging']['page_size'] ) + $this->settings->get( 'offset' ) );
813
+				$query->limit( $parameters[ 'paging' ][ 'page_size' ] )
814
+					->offset( ( ( $page - 1 ) * $parameters[ 'paging' ][ 'page_size' ] ) + $this->settings->get( 'offset' ) );
816 815
 
817 816
 				/**
818 817
 				 * Any joins?
@@ -852,15 +851,15 @@  discard block
 block discarded – undo
852 851
 				} );
853 852
 			} else {
854 853
 				$entries = $this->form->entries
855
-					->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters['search_criteria'] ) )
854
+					->filter( \GV\GF_Entry_Filter::from_search_criteria( $parameters[ 'search_criteria' ] ) )
856 855
 					->offset( $this->settings->get( 'offset' ) )
857
-					->limit( $parameters['paging']['page_size'] )
856
+					->limit( $parameters[ 'paging' ][ 'page_size' ] )
858 857
 					->page( $page );
859 858
 
860
-				if ( ! empty( $parameters['sorting'] ) && ! empty( $parameters['sorting']['key'] ) ) {
859
+				if ( ! empty( $parameters[ 'sorting' ] ) && ! empty( $parameters[ 'sorting' ][ 'key' ] ) ) {
861 860
 					$field = new \GV\Field();
862
-					$field->ID = $parameters['sorting']['key'];
863
-					$direction = strtolower( $parameters['sorting']['direction'] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
861
+					$field->ID = $parameters[ 'sorting' ][ 'key' ];
862
+					$direction = strtolower( $parameters[ 'sorting' ][ 'direction' ] ) == 'asc' ? \GV\Entry_Sort::ASC : \GV\Entry_Sort::DESC;
864 863
 					$entries = $entries->sort( new \GV\Entry_Sort( $field, $direction ) );
865 864
 				}
866 865
 			}
Please login to merge, or discard this patch.