Completed
Pull Request — master (#26)
by Andriy
03:52
created
src/utils/GeneratorUtils.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
 
30 30
 	public static function callMethod(\ReflectionMethod $method, array $params = null) {
31 31
 		if (null === $params) {
32
-			$params = array_map(function ($p) {
32
+			$params = array_map(function($p) {
33 33
 				return '$' . $p->name;
34 34
 			}, $method->getParameters());
35 35
 		}
Please login to merge, or discard this patch.
src/utils/ReflectionUtils.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 			$filter |= \ReflectionMethod::IS_PROTECTED;
33 33
 		}
34 34
 		
35
-		return array_filter($class->getMethods($filter), function ($method) {
35
+		return array_filter($class->getMethods($filter), function($method) {
36 36
 			return !$method->isFinal() && !$method->isStatic();
37 37
 		});
38 38
 	}
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
 		}
82 82
 		$tokenizer = new PhpTokenizer();
83 83
 		$tokens = $tokenizer->tokenize($content);
84
-		$tokens = $tokens->filter(function ($token) {
84
+		$tokens = $tokens->filter(function($token) {
85 85
 			return $token->type !== T_WHITESPACE && $token->type !== T_COMMENT && $token->type !== T_DOC_COMMENT;
86 86
 		});
87 87
 		$statements = [];
Please login to merge, or discard this patch.
src/model/parts/ConstantsTrait.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@
 block discarded – undo
92 92
 			return $this->constants;
93 93
 		}
94 94
 		
95
-		return array_map(function (PhpConstant $constant) {
95
+		return array_map(function(PhpConstant $constant) {
96 96
 			return $constant->getValue();
97 97
 		}, $this->constants);
98 98
 	}
Please login to merge, or discard this patch.
src/visitor/DefaultNavigator.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
 	}
144 144
 
145 145
 	private function getConstantSortFunc() {
146
-		return $this->constantSortFunc ?  : 'strcasecmp';
146
+		return $this->constantSortFunc ?: 'strcasecmp';
147 147
 	}
148 148
 
149 149
 	private function getMethodSortFunc() {
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
 		}
153 153
 		
154 154
 		if (empty(self::$defaultMethodSortFunc)) {
155
-			self::$defaultMethodSortFunc = function ($a, $b) {
155
+			self::$defaultMethodSortFunc = function($a, $b) {
156 156
 				if ($a->isStatic() !== $isStatic = $b->isStatic()) {
157 157
 					return $isStatic ? 1 : -1;
158 158
 				}
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
 		}
178 178
 		
179 179
 		if (empty(self::$defaultPropertySortFunc)) {
180
-			self::$defaultPropertySortFunc = function ($a, $b) {
180
+			self::$defaultPropertySortFunc = function($a, $b) {
181 181
 				if (($aV = $a->getVisibility()) !== $bV = $b->getVisibility()) {
182 182
 					$aV = 'public' === $aV ? 3 : ('protected' === $aV ? 2 : 1);
183 183
 					$bV = 'public' === $bV ? 3 : ('protected' === $bV ? 2 : 1);
Please login to merge, or discard this patch.
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -146,6 +146,9 @@  discard block
 block discarded – undo
146 146
 		return $this->constantSortFunc ?  : 'strcasecmp';
147 147
 	}
148 148
 
149
+	/**
150
+	 * @return callable
151
+	 */
149 152
 	private function getMethodSortFunc() {
150 153
 		if (null !== $this->methodSortFunc) {
151 154
 			return $this->methodSortFunc;
@@ -171,6 +174,9 @@  discard block
 block discarded – undo
171 174
 		return self::$defaultMethodSortFunc;
172 175
 	}
173 176
 
177
+	/**
178
+	 * @return callable
179
+	 */
174 180
 	private function getPropertySortFunc() {
175 181
 		if (null !== $this->propertySortFunc) {
176 182
 			return $this->propertySortFunc;
Please login to merge, or discard this patch.
src/visitor/DefaultVisitor.php 2 patches
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -358,7 +358,7 @@
 block discarded – undo
358 358
 	}
359 359
 
360 360
 	protected function writeFunctionReturnType($type) {
361
-		if ($this->config->getGenerateReturnTypeHints() && $type != NULL && false === strpos($type, '|')) {
361
+		if ($this->config->getGenerateReturnTypeHints() && $type != null && false === strpos($type, '|')) {
362 362
 			$this->writer->write(': ')->write($type);
363 363
 		}
364 364
 	}
Please login to merge, or discard this patch.
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -357,6 +357,9 @@
 block discarded – undo
357 357
 		}
358 358
 	}
359 359
 
360
+	/**
361
+	 * @param string $type
362
+	 */
360 363
 	protected function writeFunctionReturnType($type) {
361 364
 		if ($this->config->getGenerateReturnTypeHints() && $type != NULL && false === strpos($type, '|')) {
362 365
 			$this->writer->write(': ')->write($type);
Please login to merge, or discard this patch.
src/parser/visitor/AbstractPhpStructVisitor.php 3 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,6 @@
 block discarded – undo
19 19
 use PhpParser\Node\Stmt\Property;
20 20
 use PhpParser\Node\Stmt\TraitUse;
21 21
 use PhpParser\Node\Stmt\UseUse;
22
-use PhpParser\NodeTraverser;
23 22
 use PhpParser\NodeVisitorAbstract;
24 23
 use PhpParser\PrettyPrinter\Standard;
25 24
 use PhpParser\Node\Stmt\Class_;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -187,7 +187,7 @@
 block discarded – undo
187 187
 				$p->setDefaultValue($this->getValue($default));
188 188
 			}
189 189
 			
190
-			$tag = $params->find($p, function (ParamTag $t, $p) {
190
+			$tag = $params->find($p, function(ParamTag $t, $p) {
191 191
 				return $t->getVariable() == '$' . $p->getName();
192 192
 			});
193 193
 			
Please login to merge, or discard this patch.
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -263,6 +263,9 @@
 block discarded – undo
263 263
 		}
264 264
 	}
265 265
 	
266
+	/**
267
+	 * @return string
268
+	 */
266 269
 	private function getVisibility(Node $node) {
267 270
 		if ($node->isPrivate()) {
268 271
 			return AbstractPhpMember::VISIBILITY_PRIVATE;
Please login to merge, or discard this patch.
src/model/AbstractPhpStruct.php 2 patches
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -160,11 +160,11 @@
 block discarded – undo
160 160
 	 * 
161 161
 	 * If the class has already been declared you get only the set alias.
162 162
 	 * 
163
- 	 * @param string      $qualifiedName
164
- 	 * @param null|string $alias
165
- 	 *
166
- 	 * @return string the used alias
167
- 	 */
163
+	 * @param string      $qualifiedName
164
+	 * @param null|string $alias
165
+	 *
166
+	 * @return string the used alias
167
+	 */
168 168
  	public function declareUse($qualifiedName, $alias = null)
169 169
 	{
170 170
  		$qualifiedName = trim($qualifiedName, '\\');
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -165,8 +165,7 @@
 block discarded – undo
165 165
  	 *
166 166
  	 * @return string the used alias
167 167
  	 */
168
- 	public function declareUse($qualifiedName, $alias = null)
169
-	{
168
+ 	public function declareUse($qualifiedName, $alias = null) {
170 169
  		$qualifiedName = trim($qualifiedName, '\\');
171 170
  		if (!$this->hasUseStatement($qualifiedName)) {
172 171
  			$this->addUseStatement($qualifiedName, $alias);
Please login to merge, or discard this patch.
src/model/PhpParameter.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 		$docblock = new Docblock($ref->getDeclaringFunction());
65 65
 		
66 66
 		$params = $docblock->getTags('param');
67
-		$tag = $params->find($ref->name, function (ParamTag $t, $name) {
67
+		$tag = $params->find($ref->name, function(ParamTag $t, $name) {
68 68
 			return $t->getVariable() == '$' . $name;
69 69
 		});
70 70
 		
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
 	 */
124 124
 	public function getDocblockTag() {
125 125
 		return ParamTag::create()
126
-			->setType($this->getType() ?  : 'mixed')
126
+			->setType($this->getType() ?: 'mixed')
127 127
 			->setVariable($this->getName())
128 128
 			->setDescription($this->getTypeDescription());
129 129
 	}
Please login to merge, or discard this patch.
sami.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -12,8 +12,8 @@
 block discarded – undo
12 12
 	->in($dir);
13 13
 
14 14
 $versions = GitVersionCollection::create($dir)
15
-    ->addFromTags('v0.*')
16
-    ->add('master', 'master branch')
15
+	->addFromTags('v0.*')
16
+	->add('master', 'master branch')
17 17
 ;
18 18
 
19 19
 return new Sami($iterator, [
Please login to merge, or discard this patch.