Suilven\CovidAPIClient\Transport\Http::request()

Complexity

Conditions	2
Paths	2

Size

Total Lines	20
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php declare(strict_types = 1);
    public function request(string $jsonurl)
    {
        $ch = \curl_init();
        \curl_setopt($ch, \CURLOPT_URL, \str_replace(' ', '%20', $jsonurl));

It seems like $ch can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

        \curl_setopt($ch, \CURLOPT_CUSTOMREQUEST, 'GET');
        \curl_setopt($ch, \CURLOPT_HTTPHEADER, [
            'Content-Type: application/json',
        ]);
        \curl_setopt($ch, \CURLOPT_RETURNTRANSFER, 1);
        $response = \curl_exec($ch);

It seems like $ch can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

        $info = \curl_getinfo($ch);

It seems like $ch can also be of type false; however, parameter $ch of curl_getinfo() does only seem to accept resource, maybe add an additional type check?

        \curl_close($ch);

It seems like $ch can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

        $httpCode = \intval($info['http_code']);

        if ($httpCode !== 200) {
            throw new \Exception('http error returned');
        }

        return $response;
    }