Suilven\CovidAPIClient\Transport\Http

Complexity

Total Complexity

2

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	request()	0	20	2

<?php declare(strict_types = 1);

namespace Suilven\CovidAPIClient\Transport;

class Http
{

    public const ENDPOINT = 'https://api.coronavirus.data.gov.uk/v1/data';

    /**
     * Execute a request
     *
     * @return bool|string
     */
    public function request(string $jsonurl)
    {
        $ch = \curl_init();
        \curl_setopt($ch, \CURLOPT_URL, \str_replace(' ', '%20', $jsonurl));

It seems like $ch can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

        \curl_setopt($ch, \CURLOPT_CUSTOMREQUEST, 'GET');
        \curl_setopt($ch, \CURLOPT_HTTPHEADER, [
            'Content-Type: application/json',
        ]);
        \curl_setopt($ch, \CURLOPT_RETURNTRANSFER, 1);
        $response = \curl_exec($ch);

It seems like $ch can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

        $info = \curl_getinfo($ch);

It seems like $ch can also be of type false; however, parameter $ch of curl_getinfo() does only seem to accept resource, maybe add an additional type check?

        \curl_close($ch);

It seems like $ch can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

        $httpCode = \intval($info['http_code']);

        if ($httpCode !== 200) {
            throw new \Exception('http error returned');
        }

        return $response;
    }
}