Completed
Push — AUTOMATED_TESTING ( 33af86...424fb1 )
by Gordon
04:09
created
code/MapExtension.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -184,7 +184,7 @@
 block discarded – undo
184 184
 
185 185
 	/**
186 186
 	 * Access the map editing field for the purpose of adding guide points
187
-	 * @return [LatLongField] instance of location editing field
187
+	 * @return FormField instance of location editing field
188 188
 	 */
189 189
 	public function getMapField() {
190 190
 		if (!isset($this->mapField)) {
Please login to merge, or discard this patch.
Indentation   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -186,8 +186,7 @@
 block discarded – undo
186 186
 			}
187 187
 			$map->setClusterer(true);
188 188
 		}
189
-
190
-		**/
189
+		 **/
191 190
 
192 191
 		$map->setEnableAutomaticCenterZoom($autozoom);
193 192
 		$map->setShowInlineMapDivStyle(true);
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
 		'MapPinIcon' => 'Image'
19 19
 	);
20 20
 
21
-	static $defaults = array (
21
+	static $defaults = array(
22 22
 		'Lat' =>0,
23 23
 		'Lon' => 0,
24 24
 		'Zoom' => 4,
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
 
155 155
 		// add any KML map layers
156 156
 		if (Object::has_extension($this->owner->ClassName, 'MapLayerExtension')) {
157
-		  foreach($this->owner->MapLayers() as $layer) {
157
+		  foreach ($this->owner->MapLayers() as $layer) {
158 158
 			$map->addKML($layer->KmlFile()->getAbsoluteURL());
159 159
 			// we have a layer, so turn on autozoom
160 160
 			$autozoom = true;
Please login to merge, or discard this patch.
code/shortcodes/GoogleStreetViewShortCodeHandler.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -8,15 +8,15 @@
 block discarded – undo
8 8
 
9 9
 	public static function parse_googlestreetview($arguments, $caption = null, $parser = null) {
10 10
 		// each of latitude, longitude and heading are required at a bare minimum
11
-		if(!isset($arguments['latitude'])){
11
+		if (!isset($arguments['latitude'])) {
12 12
 			return '';
13 13
 		}
14 14
 
15
-		if(!isset($arguments['longitude'])){
15
+		if (!isset($arguments['longitude'])) {
16 16
 			return '';
17 17
 		}
18 18
 
19
-		if(!isset($arguments['heading'])){
19
+		if (!isset($arguments['heading'])) {
20 20
 			return '';
21 21
 		}
22 22
 
Please login to merge, or discard this patch.
code/shortcodes/GoogleMapShortCodeHandler.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -7,11 +7,11 @@
 block discarded – undo
7 7
 
8 8
 	public static function parse_googlemap($arguments, $caption = null, $parser = null) {
9 9
 		// each of latitude and longitude are required at a bare minimum
10
-		if(!isset($arguments['latitude'])){
10
+		if (!isset($arguments['latitude'])) {
11 11
 			return '';
12 12
 		}
13 13
 
14
-		if(!isset($arguments['longitude'])){
14
+		if (!isset($arguments['longitude'])) {
15 15
 			return '';
16 16
 		}
17 17
 
Please login to merge, or discard this patch.
code/MappableDataObjectSet.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
 		$gmap = MapUtil::get_map($this->owner, $this->MarkerTemplateValues);
28 28
 		$w = $width ? $width : MapUtil::$map_width;
29 29
 		$h = $height ? $height : MapUtil::$map_height;
30
-		$gmap->setSize($w,$h);
30
+		$gmap->setSize($w, $h);
31 31
 		return $gmap;
32 32
 	}
33 33
 
Please login to merge, or discard this patch.
code/MappableData.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 		$gmap = MapUtil::get_map(new ArrayList(array($this->owner)), $this->MarkerTemplateValues);
41 41
 		$w = $width ? $width : MapUtil::$map_width;
42 42
 		$h = $height ? $height : MapUtil::$map_height;
43
-		$gmap->setSize($w,$h);
43
+		$gmap->setSize($w, $h);
44 44
 		$gmap->setZoom($zoom);
45 45
 		$gmap->setEnableAutomaticCenterZoom(false);
46 46
 		if ($this->owner->MapPinEdited) {
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 			$urlparts['markers'] = "icon:$pin|$lat,$lng";
90 90
 		}
91 91
 
92
-		$src = htmlentities($apiurl . '?' . http_build_query($urlparts));
92
+		$src = htmlentities($apiurl.'?'.http_build_query($urlparts));
93 93
 		return '<img src="'.$src.'" width="'.$w.'" height="'.$h.'" alt="'.$this->owner->Title.'" />';
94 94
 	}
95 95
 
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@
 block discarded – undo
80 80
 		}
81 81
 
82 82
 		//https://maps.googleapis.com/maps/api/staticmap?center=Berkeley,CA&zoom=14&size=400x400&key=YOUR_API_KEY
83
-			    //maps.googleapis.com/maps/api/staticmap';
83
+				//maps.googleapis.com/maps/api/staticmap';
84 84
 
85 85
 		$apiurl = Config::inst()->get('MappableData', 'staticmap_api_url');
86 86
 
Please login to merge, or discard this patch.
code/MapField.php 3 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Map field to point for pois langitude and longitude positioning
4
- */
3
+	 * Map field to point for pois langitude and longitude positioning
4
+	 */
5 5
 class MapField extends DatalessField {
6 6
 
7 7
 		/**
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -19,19 +19,19 @@  discard block
 block discarded – undo
19 19
 			// legacy handling for old parameters: $title, $heading, ...
20 20
 			// instead of new handling: $name, $title, $heading, ...
21 21
 			$args = func_get_args();
22
-			if(!isset($args[1]) || is_numeric($args[1])) {
22
+			if (!isset($args[1]) || is_numeric($args[1])) {
23 23
 					$title = (isset($args[0])) ? $args[0] : null;
24 24
 					// Use "HeaderField(title)" as the default field name for a HeaderField;
25 25
 					// if it's just set to title then we risk causing accidental duplicate-field creation.
26 26
 
27 27
 					// this means i18nized fields won't be easily accessible through fieldByName()
28
-					$name = 'MapField' . $title;
28
+					$name = 'MapField'.$title;
29 29
 					$headingLevel = (isset($args[1])) ? $args[1] : null;
30 30
 					$allowHTML = (isset($args[2])) ? $args[2] : null;
31 31
 					$form = (isset($args[3])) ? $args[3] : null;
32 32
 			}
33 33
 
34
-			if($headingLevel) $this->headingLevel = $headingLevel;
34
+			if ($headingLevel) $this->headingLevel = $headingLevel;
35 35
 			$this->allowHTML = $allowHTML;
36 36
 			parent::__construct($name, $title, null, $allowHTML, $form);
37 37
 		}
@@ -47,9 +47,9 @@  discard block
 block discarded – undo
47 47
 
48 48
 				Requirements::css('mappable/css/mapField.css');
49 49
 
50
-				return '<div class="editableMap">' . $this->createTag(
50
+				return '<div class="editableMap">'.$this->createTag(
51 51
 						"div",
52 52
 						$attributes
53
-				) . '</div>';
53
+				).'</div>';
54 54
 		}
55 55
 }
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,9 @@
 block discarded – undo
31 31
 					$form = (isset($args[3])) ? $args[3] : null;
32 32
 			}
33 33
 
34
-			if($headingLevel) $this->headingLevel = $headingLevel;
34
+			if($headingLevel) {
35
+				$this->headingLevel = $headingLevel;
36
+			}
35 37
 			$this->allowHTML = $allowHTML;
36 38
 			parent::__construct($name, $title, null, $allowHTML, $form);
37 39
 		}
Please login to merge, or discard this patch.
code/MapAPI.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -397,10 +397,10 @@
 block discarded – undo
397 397
 	}
398 398
 
399 399
 	/**
400
-	* Set the center of the gmap
401
-	*
402
-	* @return MapAPI This same object, in order to enable chaining of methods
403
-	**/
400
+	 * Set the center of the gmap
401
+	 *
402
+	 * @return MapAPI This same object, in order to enable chaining of methods
403
+	 **/
404 404
 	public function setLatLongCenter($center) {
405 405
 		$this->latLongCenter = $center;
406 406
 		return $this;
Please login to merge, or discard this patch.
code/MapUtil.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -226,8 +226,9 @@
 block discarded – undo
226 226
 		$gmap = self::instance();
227 227
 		if ($list) {
228 228
 			foreach ($list as $mappable) {
229
-				if (self::ChooseToAddDataobject($mappable))
230
-					$gmap->addMarkerAsObject($mappable, $infowindowtemplateparams);
229
+				if (self::ChooseToAddDataobject($mappable)) {
230
+									$gmap->addMarkerAsObject($mappable, $infowindowtemplateparams);
231
+				}
231 232
 			}
232 233
 		}
233 234
 		return $gmap;
Please login to merge, or discard this patch.
code/LatLongField.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,8 +23,10 @@
 block discarded – undo
23 23
 		if ((sizeof($children) < 2) || (sizeof($children) > 3) ||
24 24
 			 (!$children[0] instanceof FormField) ||
25 25
 			 (!$children[1] instanceof FormField)
26
-		) user_error('LatLongField argument 1 must be an array containing at least two FormField '.
26
+		) {
27
+			user_error('LatLongField argument 1 must be an array containing at least two FormField '.
27 28
 				'objects for Lat/Long values, respectively.', E_USER_ERROR);
29
+		}
28 30
 
29 31
 		parent::__construct($children);
30 32
 
Please login to merge, or discard this patch.