ApcKeyDeleteCommand::execute() - Code Metrics - Inspection of "Merge pull request #35 from fyrye/patch-2" - gordalina/cachetool - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 1.x ( 8c31f4...5f4811 )

by Samuel

created 2016-05-27 10:19 UTC

ApcKeyDeleteCommand::execute() A

↳ Parent: ApcKeyDeleteCommand

Complexity

Conditions	4
Paths	6

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	17
rs	9.2
nc	6
cc	4
eloc	10
nop	2

<?php

/*
 * This file is part of CacheTool.
 *
 * (c) Samuel Gordalina <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace CacheTool\Command;

use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class ApcKeyDeleteCommand extends AbstractCommand
{
    /**
     * {@inheritdoc}
     */
    protected function configure()
    {
        $this
            ->setName('apc:key:delete')
            ->setDescription('Deletes an APC key')
            ->addArgument('key', InputArgument::REQUIRED)
            ->setHelp('');
    }

    /**
     * {@inheritdoc}
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $this->ensureExtensionLoaded('apc');

        $key = $input->getArgument('key');
        $success = $this->getCacheTool()->apc_delete($key);

        if ($output->isVerbose()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            if ($success) {
                $output->writeln("<comment>APC key <info>{$key}</info> was deleted</comment>");
            } else {
                $output->writeln("<comment>APC key <info>{$key}</info> could not be deleted.</comment>");
            }
        }

        return $success ? 0 : 1;
    }
}


1			<?php
2
3			/*
4			* This file is part of CacheTool.
5			*
6			* (c) Samuel Gordalina <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace CacheTool\Command;
13
14			use Symfony\Component\Console\Input\InputArgument;
15			use Symfony\Component\Console\Input\InputInterface;
16			use Symfony\Component\Console\Output\OutputInterface;
17
18			class ApcKeyDeleteCommand extends AbstractCommand
19			{
20			/**
21			* {@inheritdoc}
22			*/
23			protected function configure()
24			{
25			$this
26			->setName('apc:key:delete')
27			->setDescription('Deletes an APC key')
28			->addArgument('key', InputArgument::REQUIRED)
29			->setHelp('');
30			}
31
32			/**
33			* {@inheritdoc}
34			*/
35			protected function execute(InputInterface $input, OutputInterface $output)
36			{
37			$this->ensureExtensionLoaded('apc');
38
39			$key = $input->getArgument('key');
40			$success = $this->getCacheTool()->apc_delete($key);
41
42			if ($output->isVerbose()) {
			0 ignored issues – show Bug introduced 2016-05-13 17:20 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Console\Output\OutputInterface` as the method `isVerbose()` does only exist in the following implementations of said interface: `Symfony\Component\Console\Output\BufferedOutput`, `Symfony\Component\Console\Output\ConsoleOutput`, `Symfony\Component\Console\Output\NullOutput`, `Symfony\Component\Console\Output\Output`, `Symfony\Component\Console\Output\StreamOutput`, `Symfony\Component\Consol...ts\Fixtures\DummyOutput`, `Symfony\Component\Console\Tests\Output\TestOutput`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
43			if ($success) {
44			$output->writeln("<comment>APC key <info>{$key}</info> was deleted</comment>");
45			} else {
46			$output->writeln("<comment>APC key <info>{$key}</info> could not be deleted.</comment>");
47			}
48			}
49
50			return $success ? 0 : 1;
51			}
52			}
53

gordalina / cachetool

Push — 1.x ( 8c31f4...5f4811 )

ApcKeyDeleteCommand::execute() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like