| Conditions | 33 |
| Paths | 1 |
| Total Lines | 105 |
| Code Lines | 93 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 67 | public function format( |
||
| 68 | RequestInterface $request, |
||
| 69 | ResponseInterface $response = null, |
||
| 70 | \Exception $error = null |
||
| 71 | ) { |
||
| 72 | $cache = []; |
||
| 73 | |||
| 74 | return preg_replace_callback( |
||
| 75 | '/{\s*([A-Za-z_\-\.0-9]+)\s*}/', |
||
| 76 | function (array $matches) use ($request, $response, $error, &$cache) { |
||
| 77 | |||
| 78 | if (isset($cache[$matches[1]])) { |
||
| 79 | return $cache[$matches[1]]; |
||
| 80 | } |
||
| 81 | |||
| 82 | $result = ''; |
||
| 83 | switch ($matches[1]) { |
||
| 84 | case 'request': |
||
| 85 | $result = Psr7\str($request); |
||
| 86 | break; |
||
| 87 | case 'response': |
||
| 88 | $result = $response ? Psr7\str($response) : ''; |
||
| 89 | break; |
||
| 90 | case 'req_headers': |
||
| 91 | $result = trim($request->getMethod() |
||
| 92 | . ' ' . $request->getRequestTarget()) |
||
| 93 | . ' HTTP/' . $request->getProtocolVersion() . "\r\n" |
||
| 94 | . $this->headers($request); |
||
| 95 | break; |
||
| 96 | case 'res_headers': |
||
| 97 | $result = $response ? |
||
| 98 | sprintf( |
||
| 99 | 'HTTP/%s %d %s', |
||
| 100 | $response->getProtocolVersion(), |
||
| 101 | $response->getStatusCode(), |
||
| 102 | $response->getReasonPhrase() |
||
| 103 | ) . "\r\n" . $this->headers($response) |
||
| 104 | : 'NULL'; |
||
| 105 | break; |
||
| 106 | case 'req_body': |
||
| 107 | $result = $request->getBody(); |
||
| 108 | break; |
||
| 109 | case 'res_body': |
||
| 110 | $result = $response ? $response->getBody() : 'NULL'; |
||
| 111 | break; |
||
| 112 | case 'ts': |
||
| 113 | case 'date_iso_8601': |
||
| 114 | $result = gmdate('c'); |
||
| 115 | break; |
||
| 116 | case 'date_common_log': |
||
| 117 | $result = date('d/M/Y:H:i:s O'); |
||
| 118 | break; |
||
| 119 | case 'method': |
||
| 120 | $result = $request->getMethod(); |
||
| 121 | break; |
||
| 122 | case 'version': |
||
| 123 | $result = $request->getProtocolVersion(); |
||
| 124 | break; |
||
| 125 | case 'uri': |
||
| 126 | case 'url': |
||
| 127 | $result = $request->getUri(); |
||
| 128 | break; |
||
| 129 | case 'target': |
||
| 130 | $result = $request->getRequestTarget(); |
||
| 131 | break; |
||
| 132 | case 'req_version': |
||
| 133 | $result = $request->getProtocolVersion(); |
||
| 134 | break; |
||
| 135 | case 'res_version': |
||
| 136 | $result = $response |
||
| 137 | ? $response->getProtocolVersion() |
||
| 138 | : 'NULL'; |
||
| 139 | break; |
||
| 140 | case 'host': |
||
| 141 | $result = $request->getHeaderLine('Host'); |
||
| 142 | break; |
||
| 143 | case 'hostname': |
||
| 144 | $result = gethostname(); |
||
| 145 | break; |
||
| 146 | case 'code': |
||
| 147 | $result = $response ? $response->getStatusCode() : 'NULL'; |
||
| 148 | break; |
||
| 149 | case 'phrase': |
||
| 150 | $result = $response ? $response->getReasonPhrase() : 'NULL'; |
||
| 151 | break; |
||
| 152 | case 'error': |
||
| 153 | $result = $error ? $error->getMessage() : 'NULL'; |
||
| 154 | break; |
||
| 155 | default: |
||
| 156 | // handle prefixed dynamic headers |
||
| 157 | if (strpos($matches[1], 'req_header_') === 0) { |
||
| 158 | $result = $request->getHeaderLine(substr($matches[1], 11)); |
||
| 159 | } elseif (strpos($matches[1], 'res_header_') === 0) { |
||
| 160 | $result = $response |
||
| 161 | ? $response->getHeaderLine(substr($matches[1], 11)) |
||
| 162 | : 'NULL'; |
||
| 163 | } |
||
| 164 | } |
||
| 165 | |||
| 166 | $cache[$matches[1]] = $result; |
||
| 167 | return $result; |
||
| 168 | }, |
||
| 169 | $this->template |
||
| 170 | ); |
||
| 171 | } |
||
| 172 | |||
| 183 |